Skip to content

[backport cloud/1.43] QPO thumbnails (#11946) + Vue node slot validation (#11950) - #11996

Merged
dante01yoon merged 2 commits into
cloud/1.43from
glary/cloud-1.43-qpo-and-slot-validation
May 8, 2026
Merged

dante01yoon merged 2 commits into
cloud/1.43from
glary/cloud-1.43-qpo-and-slot-validation

Conversation

@DrJKL

@DrJKL DrJKL commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

Two follow-up bug fixes that landed on main after the previous backport batches (#11926, #11975).

Picked

PR Subject User-visible bug
#11946 fix: use resized QPO thumbnails (FE-538) Floating QPO row thumbnails currently load full-size image/video assets while the canvas is being navigated; this swaps to previewUrl to use resized thumbnails.
#11950 fix: highlight missing input slots on Vue nodes Required-input validation highlighting was lost on Vue-rendered node input slots. Restores the error ring on the missing slot itself by wiring useExecutionErrorStore through NodeSlots.vue → InputSlot.

Conflict resolution notes

  • fix: use resized QPO thumbnails #11946 — applied cleanly, no conflicts.
  • fix: highlight missing input slots on Vue nodes #11950 —
    • src/renderer/extensions/vueNodes/components/NodeSlots.vue: cloud/1.43 imports cn from @/utils/tailwindUtil, main from @comfyorg/tailwind-utils. Kept cloud/1.43's import path; pulled in the new useExecutionErrorStore and getLocatorIdFromNodeData imports (both modules already exist on cloud/1.43).
    • browser_tests/tests/vueNodes/nodeStates/error.spec.ts: incoming version references helpers (ErrorsTabHelper, cleanupFakeModel) that don't exist on cloud/1.43. Restored cloud/1.43's version of the test file and removed the new vue-node-required-input-missing-slot-error-chromium-linux.png snapshot. The runtime fix in NodeSlots.vue lands; the new e2e regression test would need its helper deps backported separately.

Verification

  • ✅ pnpm typecheck clean
  • ✅ pnpm typecheck:browser clean
  • ✅ pnpm knip clean
  • ✅ Targeted unit tests passing: NodeSlots.test.ts (9), useErrorClearingHooks.test.ts (24), JobAssetsList.test.ts (16) — 49/49 passed

┆Issue is synchronized with this Notion page by Unito

benceruleanlu and others added 2 commits May 5, 2026 22:56
## Summary

Use resized preview URLs for floating QPO row thumbnails so the expanded
overlay does not load full-size image assets while the canvas is being
navigated.

Linear: FE-538

## Changes

- **What**: Pass `ResultItemImpl.previewUrl` into `AssetsListItem` for
completed image/video job rows.
- **Dependencies**: None.

## Review Focus

Confirm this only changes the row thumbnail source; full asset viewing
still flows through the existing job/task preview output.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11946-fix-use-resized-QPO-thumbnails-3576d73d365081b68682d1b7b109af30)
by [Unito](https://www.unito.io)

(cherry picked from commit f6ddd26)
(cherry picked from commit 0307281)
Conflicts:
- src/renderer/extensions/vueNodes/components/NodeSlots.vue: cloud/1.43
  uses '@/utils/tailwindUtil' for cn (not '@comfyorg/tailwind-utils');
  kept cloud/1.43's import, kept the new useExecutionErrorStore +
  getLocatorIdFromNodeData imports.
- browser_tests/tests/vueNodes/nodeStates/error.spec.ts: incoming version
  references ErrorsTabHelper/cleanupFakeModel helpers that don't exist
  on cloud/1.43; restored cloud/1.43's version of the test file. Removed
  the new vue-node-required-input-missing-slot-error snapshot (no test
  references it on cloud/1.43).
@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 55110d84-2e2b-4736-983b-43c3156ab69a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/cloud-1.43-qpo-and-slot-validation

Comment @coderabbitai help to get the list of available commands and usage tips.

@glary-bot

glary-bot Bot commented May 5, 2026

Copy link
Copy Markdown

Acknowledged — CodeRabbit auto-skipped because the title contains [backport, which is in the repo's ignore-keyword list. Each cherry-pick records its source SHA via cherry picked from commit ..., so the original PRs (#11946, #11950) on main are the canonical review targets.

@github-actions

github-actions Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/05/2026, 11:06:51 PM UTC

Links

@codecov

codecov Bot commented May 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.43   #11996   +/-   ##
=============================================
  Coverage              ?   45.39%           
=============================================
  Files                 ?     1349           
  Lines                 ?    69487           
  Branches              ?    18460           
=============================================
  Hits                  ?    31545           
  Misses                ?    37351           
  Partials              ?      591           
Files with missing lines Coverage Δ
src/components/queue/job/JobAssetsList.vue 85.27% <100.00%> (ø)
...derer/extensions/vueNodes/components/NodeSlots.vue 86.48% <100.00%> (ø)
...tensions/vueNodes/components/SlotConnectionDot.vue 51.42% <ø> (ø)
src/utils/__tests__/executionErrorTestUtils.ts 100.00% <100.00%> (ø)
src/utils/__tests__/litegraphTestUtils.ts 94.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.2 MB heap

No baseline found — showing absolute values.

Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 349ms
canvas-idle: script duration 21ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.7 MB
canvas-idle: DOM nodes 22
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 82
canvas-mouse-sweep: task duration 926ms
canvas-mouse-sweep: script duration 130ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.3 MB
canvas-mouse-sweep: DOM nodes 66
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 292ms
canvas-zoom-sweep: script duration 24ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 64.8 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 342ms
dom-widget-clipping: script duration 62ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 47.1 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 12
large-graph-idle: task duration 548ms
large-graph-idle: script duration 90ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 53.5 MB
large-graph-idle: DOM nodes -256
large-graph-idle: event listeners -125
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 987ms
large-graph-pan: script duration 349ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 67.2 MB
large-graph-pan: DOM nodes -266
large-graph-pan: event listeners -125
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 19ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1267ms
large-graph-zoom: script duration 474ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 57.8 MB
large-graph-zoom: DOM nodes -264
large-graph-zoom: event listeners -125
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 516ms
minimap-idle: script duration 83ms
minimap-idle: TBT 0ms
minimap-idle: heap used 54.9 MB
minimap-idle: DOM nodes -259
minimap-idle: event listeners -125
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 349ms
subgraph-dom-widget-clipping: script duration 123ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 48.5 MB
subgraph-dom-widget-clipping: DOM nodes 23
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 343ms
subgraph-idle: script duration 18ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.3 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 44ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 83
subgraph-mouse-sweep: task duration 865ms
subgraph-mouse-sweep: script duration 94ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 52.6 MB
subgraph-mouse-sweep: DOM nodes 71
subgraph-mouse-sweep: event listeners 6
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 56ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3399ms
viewport-pan-sweep: script duration 1122ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.8 MB
viewport-pan-sweep: DOM nodes -256
viewport-pan-sweep: event listeners -111
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12348ms
vue-large-graph-idle: script duration 555ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.2 MB
vue-large-graph-idle: DOM nodes -8329
vue-large-graph-idle: event listeners -16464
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 14839ms
vue-large-graph-pan: script duration 826ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 164.6 MB
vue-large-graph-pan: DOM nodes -8329
vue-large-graph-pan: event listeners -16460
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 5
workflow-execution: style recalc count 17
workflow-execution: task duration 120ms
workflow-execution: script duration 27ms
workflow-execution: TBT 0ms
workflow-execution: heap used 47.2 MB
workflow-execution: DOM nodes 158
workflow-execution: event listeners 71
Raw data
{
  "timestamp": "2026-05-05T23:17:14.970Z",
  "gitSha": "209c215018a6bcba82054fbcc75a57a77140407d",
  "branch": "glary/cloud-1.43-qpo-and-slot-validation",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2013.0909999999744,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.750999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.72099999999995,
      "heapDeltaBytes": 20729528,
      "heapUsedBytes": 63297928,
      "domNodes": 22,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 22.147,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.7189999999855,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.749999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.26800000000003,
      "heapDeltaBytes": 20666240,
      "heapUsedBytes": 63649464,
      "domNodes": 22,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 20.888,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2028.7250000000085,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.585,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.417,
      "heapDeltaBytes": 20580792,
      "heapUsedBytes": 63685084,
      "domNodes": 22,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 17.625999999999994,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2053.0819999999608,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 47.575,
      "layouts": 12,
      "layoutDurationMs": 4.0969999999999995,
      "taskDurationMs": 1001.5180000000001,
      "heapDeltaBytes": 16381244,
      "heapUsedBytes": 59015896,
      "domNodes": 66,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 136.25199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2016.3729999999873,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 41.946,
      "layouts": 12,
      "layoutDurationMs": 3.482,
      "taskDurationMs": 926.0010000000001,
      "heapDeltaBytes": 16331236,
      "heapUsedBytes": 59265640,
      "domNodes": 67,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 130.26100000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1713.3049999999912,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 34.163,
      "layouts": 12,
      "layoutDurationMs": 3.548,
      "taskDurationMs": 703.1,
      "heapDeltaBytes": 16070052,
      "heapUsedBytes": 58987404,
      "domNodes": 57,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 119.53899999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.0950000000103,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.897,
      "layouts": 6,
      "layoutDurationMs": 0.6579999999999999,
      "taskDurationMs": 289.127,
      "heapDeltaBytes": 25033340,
      "heapUsedBytes": 67896944,
      "domNodes": 77,
      "jsHeapTotalBytes": 20709376,
      "scriptDurationMs": 24.462000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.6989999999969,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.331,
      "layouts": 6,
      "layoutDurationMs": 0.6809999999999999,
      "taskDurationMs": 292.065,
      "heapDeltaBytes": 25066676,
      "heapUsedBytes": 67965164,
      "domNodes": 78,
      "jsHeapTotalBytes": 21233664,
      "scriptDurationMs": 25.426000000000005,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.711000000042,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.497999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.6200000000000001,
      "taskDurationMs": 292.48,
      "heapDeltaBytes": 24902180,
      "heapUsedBytes": 67693624,
      "domNodes": 79,
      "jsHeapTotalBytes": 20447232,
      "scriptDurationMs": 19.267000000000007,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 579.3709999999805,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.645,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.939,
      "heapDeltaBytes": 7606292,
      "heapUsedBytes": 50525688,
      "domNodes": 22,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 66.202,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 564.2599999999902,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.984999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.25600000000003,
      "heapDeltaBytes": 6255128,
      "heapUsedBytes": 49173104,
      "domNodes": 22,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 62.37499999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 528.8959999999179,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.696999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 322.832,
      "heapDeltaBytes": 6428364,
      "heapUsedBytes": 49427052,
      "domNodes": 20,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 60.289,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.6170000000398,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.790000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.966,
      "heapDeltaBytes": 4377812,
      "heapUsedBytes": 55764332,
      "domNodes": -255,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 86.76199999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.641000000046,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.782000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 552.885,
      "heapDeltaBytes": 4861940,
      "heapUsedBytes": 56190252,
      "domNodes": -257,
      "jsHeapTotalBytes": 16969728,
      "scriptDurationMs": 90.00800000000001,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2065.307999999959,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.173999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.123,
      "heapDeltaBytes": 4997104,
      "heapUsedBytes": 56060052,
      "domNodes": -256,
      "jsHeapTotalBytes": 16707584,
      "scriptDurationMs": 90.57799999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.140999999999,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 19.51,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1001.199,
      "heapDeltaBytes": 18324188,
      "heapUsedBytes": 70437956,
      "domNodes": -261,
      "jsHeapTotalBytes": 17960960,
      "scriptDurationMs": 356.286,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2107.161000000019,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.913999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 984.1529999999998,
      "heapDeltaBytes": 16295840,
      "heapUsedBytes": 70641080,
      "domNodes": -268,
      "jsHeapTotalBytes": 17776640,
      "scriptDurationMs": 348.964,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2105.538000000024,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 16.162999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 987.101,
      "heapDeltaBytes": 11308752,
      "heapUsedBytes": 65404660,
      "domNodes": -266,
      "jsHeapTotalBytes": 19009536,
      "scriptDurationMs": 346.87100000000004,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3133.037999999999,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 19.494,
      "layouts": 60,
      "layoutDurationMs": 7.6160000000000005,
      "taskDurationMs": 1267.418,
      "heapDeltaBytes": 7059044,
      "heapUsedBytes": 62077412,
      "domNodes": -265,
      "jsHeapTotalBytes": 17494016,
      "scriptDurationMs": 473.653,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3164.7449999999253,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 18.545,
      "layouts": 60,
      "layoutDurationMs": 7.6419999999999995,
      "taskDurationMs": 1248.0880000000002,
      "heapDeltaBytes": 5306960,
      "heapUsedBytes": 60597448,
      "domNodes": -264,
      "jsHeapTotalBytes": 17494016,
      "scriptDurationMs": 462.706,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3178.530999999907,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 19.535,
      "layouts": 60,
      "layoutDurationMs": 7.736000000000001,
      "taskDurationMs": 1273.263,
      "heapDeltaBytes": 3215864,
      "heapUsedBytes": 58222252,
      "domNodes": -262,
      "jsHeapTotalBytes": 16183296,
      "scriptDurationMs": 480.267,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.5150000000217,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.439000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.1400000000001,
      "heapDeltaBytes": -215576,
      "heapUsedBytes": 52934800,
      "domNodes": -258,
      "jsHeapTotalBytes": 15921152,
      "scriptDurationMs": 83.276,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.668999999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.960000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.49100000000004,
      "heapDeltaBytes": 3107068,
      "heapUsedBytes": 57645728,
      "domNodes": -260,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 76.00899999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.7860000000683,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.249000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.6489999999999,
      "heapDeltaBytes": 4086676,
      "heapUsedBytes": 57566864,
      "domNodes": -259,
      "jsHeapTotalBytes": 15953920,
      "scriptDurationMs": 85.64999999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.9870000000165,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.471999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.39799999999997,
      "heapDeltaBytes": 7532316,
      "heapUsedBytes": 50891580,
      "domNodes": 23,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 124.612,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 536.4819999999781,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 12.593000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 351.24899999999997,
      "heapDeltaBytes": 7109576,
      "heapUsedBytes": 51226548,
      "domNodes": 24,
      "jsHeapTotalBytes": 13107200,
      "scriptDurationMs": 123.36200000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.053000000029,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.235,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.13300000000004,
      "heapDeltaBytes": 6536732,
      "heapUsedBytes": 49737828,
      "domNodes": 20,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 123.39,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.7290000000025,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.26,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.598,
      "heapDeltaBytes": 20048880,
      "heapUsedBytes": 63201500,
      "domNodes": 20,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 17.705000000000005,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.7199999999962,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.767999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.94399999999996,
      "heapDeltaBytes": 20266096,
      "heapUsedBytes": 63444688,
      "domNodes": 23,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 18.767,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.8509999999314,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.641999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 332.55199999999996,
      "heapDeltaBytes": 20075072,
      "heapUsedBytes": 62920444,
      "domNodes": 16,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 18.093000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1973.635999999999,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 46.157000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.6770000000000005,
      "taskDurationMs": 883.129,
      "heapDeltaBytes": 11955208,
      "heapUsedBytes": 55104676,
      "domNodes": 74,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 95.46199999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1964.8799999999937,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 42.175000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.589,
      "taskDurationMs": 864.687,
      "heapDeltaBytes": 12344932,
      "heapUsedBytes": 55427176,
      "domNodes": 71,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 92.89699999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1975.2059999999574,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 43.996,
      "layouts": 16,
      "layoutDurationMs": 4.6,
      "taskDurationMs": 860.2420000000001,
      "heapDeltaBytes": 11896112,
      "heapUsedBytes": 55115152,
      "domNodes": 71,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 93.837,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8165.311999999972,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.821000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3380.683,
      "heapDeltaBytes": 24931752,
      "heapUsedBytes": 76333112,
      "domNodes": -255,
      "jsHeapTotalBytes": 19009536,
      "scriptDurationMs": 1122.2100000000003,
      "eventListeners": -105,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8208.524000000012,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 56.25100000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3453.149,
      "heapDeltaBytes": 2235712,
      "heapUsedBytes": 53013632,
      "domNodes": -256,
      "jsHeapTotalBytes": 19329024,
      "scriptDurationMs": 1146.117,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8142.959000000019,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 54.49700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3399.493,
      "heapDeltaBytes": 28111696,
      "heapUsedBytes": 79269400,
      "domNodes": -257,
      "jsHeapTotalBytes": 18747392,
      "scriptDurationMs": 1118.9589999999998,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12357.671000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12347.898000000001,
      "heapDeltaBytes": -33088744,
      "heapUsedBytes": 165975820,
      "domNodes": -8329,
      "jsHeapTotalBytes": 25780224,
      "scriptDurationMs": 572.812,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12582.587000000103,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12572.999,
      "heapDeltaBytes": -35678928,
      "heapUsedBytes": 165925916,
      "domNodes": -8331,
      "jsHeapTotalBytes": 23945216,
      "scriptDurationMs": 555.471,
      "eventListeners": -16464,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12303.449999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12290.078999999998,
      "heapDeltaBytes": -47109452,
      "heapUsedBytes": 165931676,
      "domNodes": -8329,
      "jsHeapTotalBytes": 26304512,
      "scriptDurationMs": 545.6909999999999,
      "eventListeners": -16470,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15004.945000000022,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 17.35700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14983.681999999999,
      "heapDeltaBytes": -35772532,
      "heapUsedBytes": 160386308,
      "domNodes": -8329,
      "jsHeapTotalBytes": -6025216,
      "scriptDurationMs": 812.5830000000001,
      "eventListeners": -16460,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14670.746000000008,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 16.85700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14650.608999999999,
      "heapDeltaBytes": -23215844,
      "heapUsedBytes": 173504560,
      "domNodes": -8329,
      "jsHeapTotalBytes": 24645632,
      "scriptDurationMs": 844.742,
      "eventListeners": -16460,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14864.466000000106,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.08399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14839.357999999998,
      "heapDeltaBytes": -30166120,
      "heapUsedBytes": 172577292,
      "domNodes": -8329,
      "jsHeapTotalBytes": -5500928,
      "scriptDurationMs": 826.05,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.89200000003893,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 26.911,
      "layouts": 5,
      "layoutDurationMs": 1.7109999999999994,
      "taskDurationMs": 131.236,
      "heapDeltaBytes": 4791200,
      "heapUsedBytes": 49464268,
      "domNodes": 191,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.150999999999996,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.28400000001056,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 22.933000000000003,
      "layouts": 5,
      "layoutDurationMs": 1.2819999999999998,
      "taskDurationMs": 119.72699999999998,
      "heapDeltaBytes": 4504880,
      "heapUsedBytes": 50506680,
      "domNodes": 158,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 29.56199999999999,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.70699999995304,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 18.858999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.591,
      "taskDurationMs": 86.08099999999999,
      "heapDeltaBytes": 2760268,
      "heapUsedBytes": 47705064,
      "domNodes": 143,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 23.026999999999997,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@dante01yoon
dante01yoon marked this pull request as ready for review May 8, 2026 22:56
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 8, 2026
@dante01yoon
dante01yoon merged commit fa332d1 into cloud/1.43 May 8, 2026
30 checks passed
@dante01yoon
dante01yoon deleted the glary/cloud-1.43-qpo-and-slot-validation branch May 8, 2026 22:56
@glary-bot

glary-bot Bot commented May 8, 2026

Copy link
Copy Markdown

Thanks for the review @dante01yoon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants