Repository navigation
[backport core/1.43] fix: route progress_text feature flag check through getDevOverride (#11384) - #11958
Conversation
…11384) ## Summary Route the `progress_text` binary parser's feature-flag check through `serverSupportsFeature()` so dev overrides via `localStorage` take effect. ## Changes - **What**: Replace `this.getClientFeatureFlags()?.supports_progress_text_metadata` with `this.serverSupportsFeature('supports_progress_text_metadata')` in the `case 3` binary message handler, consistent with all other feature-flag checks in the class. ## Review Focus Minimal one-line change. The key consideration is that `serverSupportsFeature()` routes through `getDevOverride()` first, enabling `localStorage` overrides (`ff:supports_progress_text_metadata`) for dev testing of the binary wire format. Fixes #11187 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11384-fix-route-progress_text-feature-flag-check-through-getDevOverride-3476d73d36508161bca0d6c2ea7c3c55) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 4b7a027)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
|
Re: CodeRabbit auto-skip notification (comment 4378407707) — config-based skip due to For the record: 1-line cherry-pick of |
🎭 Playwright: ✅ 1043 passed, 0 failed · 4 flaky📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## glary/backport-core-1.43-11174-guard-progress-text #11958 +/- ##
===================================================================================
Coverage 44.73% 44.73%
===================================================================================
Files 1344 1344
Lines 69046 69046
Branches 19136 19136
===================================================================================
Hits 30891 30891
Misses 37560 37560
Partials 595 595
🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
No baseline found — showing absolute values.
Raw data{
"timestamp": "2026-05-05T10:38:20.111Z",
"gitSha": "bf7db75b5a45c938a1e0a6c26dc352c4445daf9d",
"branch": "glary/backport-core-1.43-11384-progress-text-devoverride",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.8680000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.5,
"heapDeltaBytes": 20103012,
"heapUsedBytes": 63259304,
"domNodes": 19,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 15.095,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.2140000000095,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.943,
"heapDeltaBytes": 20630072,
"heapUsedBytes": 63606432,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.884,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2013.7230000000272,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.530999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.94899999999996,
"heapDeltaBytes": 20777680,
"heapUsedBytes": 64638272,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 21.105,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2050.815,
"styleRecalcs": 81,
"styleRecalcDurationMs": 40.013,
"layouts": 12,
"layoutDurationMs": 3.1279999999999997,
"taskDurationMs": 1004.3480000000001,
"heapDeltaBytes": 17042328,
"heapUsedBytes": 59915260,
"domNodes": 65,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 143.28199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2067.1629999999936,
"styleRecalcs": 82,
"styleRecalcDurationMs": 45.032,
"layouts": 12,
"layoutDurationMs": 3.4790000000000005,
"taskDurationMs": 994.5350000000001,
"heapDeltaBytes": 16235728,
"heapUsedBytes": 59347472,
"domNodes": 68,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 133.886,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2015.7829999999421,
"styleRecalcs": 84,
"styleRecalcDurationMs": 42.324,
"layouts": 12,
"layoutDurationMs": 3.6120000000000005,
"taskDurationMs": 946.9320000000001,
"heapDeltaBytes": 16379692,
"heapUsedBytes": 59369200,
"domNodes": 66,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 132.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.607000000021,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.195,
"layouts": 6,
"layoutDurationMs": 0.637,
"taskDurationMs": 298.089,
"heapDeltaBytes": 25043644,
"heapUsedBytes": 68056088,
"domNodes": 78,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 23.598999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.1950000000184,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.677999999999997,
"layouts": 6,
"layoutDurationMs": 0.588,
"taskDurationMs": 300.27,
"heapDeltaBytes": 25053460,
"heapUsedBytes": 67849760,
"domNodes": 78,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 25.993000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.8500000000322,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.179,
"layouts": 6,
"layoutDurationMs": 0.5609999999999998,
"taskDurationMs": 293.694,
"heapDeltaBytes": 25072696,
"heapUsedBytes": 67761788,
"domNodes": 80,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 24.542,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 606.1360000000207,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.20799999999997,
"heapDeltaBytes": 7175068,
"heapUsedBytes": 50412128,
"domNodes": 17,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 61.15000000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 574.1139999999518,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.200999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.69499999999994,
"heapDeltaBytes": 6558116,
"heapUsedBytes": 49398368,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 65.127,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 580.2159999999503,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.959999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.931,
"heapDeltaBytes": 6495284,
"heapUsedBytes": 49123152,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 65.12499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2056.653000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.436,
"heapDeltaBytes": 4327836,
"heapUsedBytes": 55688340,
"domNodes": -259,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 99.79599999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2067.7049999999895,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.362999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.136,
"heapDeltaBytes": 4348024,
"heapUsedBytes": 55984364,
"domNodes": -256,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 101.72500000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.5049999999537,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.5620000000001,
"heapDeltaBytes": 3604248,
"heapUsedBytes": 56428912,
"domNodes": -261,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 90.345,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2116.317000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.267999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1030.95,
"heapDeltaBytes": 17527216,
"heapUsedBytes": 70606792,
"domNodes": -260,
"jsHeapTotalBytes": 17698816,
"scriptDurationMs": 386.04299999999995,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2161.3590000000045,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.313000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1070.366,
"heapDeltaBytes": 17346764,
"heapUsedBytes": 71204860,
"domNodes": -262,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 400.355,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2133.7200000000394,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.113000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1063.463,
"heapDeltaBytes": 16428956,
"heapUsedBytes": 70550776,
"domNodes": -263,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 387.969,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.7639999999537,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.987,
"layouts": 60,
"layoutDurationMs": 6.986000000000001,
"taskDurationMs": 1332.094,
"heapDeltaBytes": 9656080,
"heapUsedBytes": 65338844,
"domNodes": -265,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 512.7900000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.6510000000117,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.717000000000002,
"layouts": 60,
"layoutDurationMs": 7.046,
"taskDurationMs": 1370.241,
"heapDeltaBytes": 8906844,
"heapUsedBytes": 64229520,
"domNodes": -265,
"jsHeapTotalBytes": 18804736,
"scriptDurationMs": 529.8799999999999,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3164.7070000000213,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.620000000000003,
"layouts": 60,
"layoutDurationMs": 6.910999999999999,
"taskDurationMs": 1321.8909999999998,
"heapDeltaBytes": -5069428,
"heapUsedBytes": 49856236,
"domNodes": -264,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 509.43399999999997,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.791000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.598999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.92199999999997,
"heapDeltaBytes": 1773516,
"heapUsedBytes": 55931428,
"domNodes": -263,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 89.367,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.2779999999711,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.861000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.728,
"heapDeltaBytes": 3956772,
"heapUsedBytes": 56964424,
"domNodes": -259,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 106.036,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2067.8510000000188,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.493000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.683,
"heapDeltaBytes": 5219148,
"heapUsedBytes": 57853724,
"domNodes": -260,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 102.374,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.4260000000149,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.412,
"heapDeltaBytes": 6391932,
"heapUsedBytes": 50966516,
"domNodes": 20,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 118.66000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.1639999999902,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.616999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.16399999999993,
"heapDeltaBytes": 6725436,
"heapUsedBytes": 49840348,
"domNodes": 20,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 122.42,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.2600000000521,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.834,
"heapDeltaBytes": 6418996,
"heapUsedBytes": 49500636,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 126.017,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.2510000000102,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.43100000000004,
"heapDeltaBytes": 20021092,
"heapUsedBytes": 62779708,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.999999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1994.039999999984,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.687000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.52099999999996,
"heapDeltaBytes": 20042540,
"heapUsedBytes": 62850148,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.403999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2010.2970000000369,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.01300000000003,
"heapDeltaBytes": 20022324,
"heapUsedBytes": 63152316,
"domNodes": 21,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 19.058,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.190999999999,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.455000000000005,
"layouts": 16,
"layoutDurationMs": 4.667,
"taskDurationMs": 635.511,
"heapDeltaBytes": 11761808,
"heapUsedBytes": 55051088,
"domNodes": 61,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 91.417,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.4719999999957,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.739999999999995,
"layouts": 16,
"layoutDurationMs": 4.328,
"taskDurationMs": 667.4760000000001,
"heapDeltaBytes": 11877916,
"heapUsedBytes": 55079784,
"domNodes": 64,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 101.66999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.6420000000408,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.026,
"layouts": 16,
"layoutDurationMs": 4.7219999999999995,
"taskDurationMs": 901.318,
"heapDeltaBytes": 11983068,
"heapUsedBytes": 55104524,
"domNodes": 73,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 101.312,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.174999999996,
"styleRecalcs": 253,
"styleRecalcDurationMs": 44.363,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3601.1800000000003,
"heapDeltaBytes": 26340112,
"heapUsedBytes": 76897936,
"domNodes": -254,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 1242.9270000000001,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.365000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3857.6070000000004,
"heapDeltaBytes": 33447548,
"heapUsedBytes": 84614412,
"domNodes": -256,
"jsHeapTotalBytes": 23990272,
"scriptDurationMs": 1439.571,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.247999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.13699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3562.42,
"heapDeltaBytes": 28179668,
"heapUsedBytes": 79017436,
"domNodes": -256,
"jsHeapTotalBytes": 19271680,
"scriptDurationMs": 1232.889,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11529.327000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11518.869999999999,
"heapDeltaBytes": -32865680,
"heapUsedBytes": 165732480,
"domNodes": -8329,
"jsHeapTotalBytes": 25780224,
"scriptDurationMs": 563.461,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11760.991999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11748.897,
"heapDeltaBytes": -45258320,
"heapUsedBytes": 166236892,
"domNodes": -8329,
"jsHeapTotalBytes": 26304512,
"scriptDurationMs": 580.625,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11687.695000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11677.892,
"heapDeltaBytes": -30546808,
"heapUsedBytes": 166599312,
"domNodes": -8329,
"jsHeapTotalBytes": 26828800,
"scriptDurationMs": 578.508,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14231.16600000003,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.473000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14198.36,
"heapDeltaBytes": -12845380,
"heapUsedBytes": 184067768,
"domNodes": -8331,
"jsHeapTotalBytes": 23597056,
"scriptDurationMs": 855.675,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14137.802999999964,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.83599999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14112.336000000001,
"heapDeltaBytes": -32591088,
"heapUsedBytes": 163695184,
"domNodes": -8329,
"jsHeapTotalBytes": 24469504,
"scriptDurationMs": 860.3629999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13798.989000000005,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.092999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13780.480999999998,
"heapDeltaBytes": -25447160,
"heapUsedBytes": 184939748,
"domNodes": -8329,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 838.3149999999999,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 458.24500000003354,
"styleRecalcs": 23,
"styleRecalcDurationMs": 24.477000000000004,
"layouts": 5,
"layoutDurationMs": 1.651,
"taskDurationMs": 123.51600000000002,
"heapDeltaBytes": 4765828,
"heapUsedBytes": 48847464,
"domNodes": 192,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.744999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 445.70099999998547,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.226000000000003,
"layouts": 5,
"layoutDurationMs": 1.324,
"taskDurationMs": 106.187,
"heapDeltaBytes": 4352364,
"heapUsedBytes": 49212568,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.708000000000002,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 106.3570000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.506,
"layouts": 4,
"layoutDurationMs": 1.2860000000000003,
"taskDurationMs": 85.03500000000001,
"heapDeltaBytes": 2765420,
"heapUsedBytes": 47427376,
"domNodes": 143,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 22.787999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
f347ff5
into
glary/backport-core-1.43-11174-guard-progress-text
|
Thanks for the approval @dante01yoon — confirmed via the reviews API there's no review body or inline comments to address (the "comments" surfaced via the Slack notification were CI status updates: ✅ Storybook built, ✅ Playwright 1043/0/4-flaky, ✅ Codecov coverage held). This PR is the second of a two-PR stack (#11957 → this). Once #11957 lands, I'll retarget this base from the stack branch back to |
|
Thanks for the approval @dante01yoon — confirmed via the reviews API there's no review body or inline comments to address (the "comments" surfaced via the Slack notification were CI bot status updates, not review feedback). This PR is the first of a two-PR stack (this → #11958). Both are draft. Once this merges, I'll retarget #11958's base from |
PR Created by the Glary-Bot Agent
Cherry-pick of
4b7a02794(PR #11384) frommainontocore/1.43.This is PR 2 of 2 in a sequential stack. Stacked on top of #11957 (
fix: guard progress_text before canvas init). Merge #11957 first, then this PR's base will retarget tocore/1.43.Why
Cloud reports of "Preview as Text" not displaying output when fed by API nodes traced back to two missing
progress_textWebSocket fixes oncore/1.43. The bundle PR #11926 picked these ontocloud/1.43butcore/1.43was not in scope.This is the primary fix for the API-node Preview-as-Text symptom:
api.tswas checking the client feature flags instead of server feature flags before parsing the newprogress_textbinary wire format ([event_type][prompt_id_len][prompt_id][node_id_len][node_id][text]). When the server advertisedsupports_progress_text_metadata(which v0.20.2 does) but the client check failed silently, the new wire format was parsed as the legacy format, mangling the bytes — which is exactly why API-node text outputs (which stream viaprogress_text) failed while Concatenate (which doesn't useprogress_text) worked.Status confirmed via:
git merge-base --is-ancestor 4b7a02794 origin/main→ YESgit merge-base --is-ancestor 4b7a02794 origin/core/1.43→ NO (needs pick)Original PR Summary (#11384)
Files Changed
src/scripts/api.ts— 1 line: route theprogress_textflag check throughserverSupportsFeature()Verification
Local automated checks:
pnpm typecheck→ cleanpnpm exec eslint src/scripts/api.ts→ 0 errors (file is in lint ignore list, expected)pnpm exec vitest run src/scripts/api.featureFlags.test.ts→ 15/15 passedCode review (Oracle): 0 critical, 0 warning, 1 suggestion. Suggestion was about extending test coverage in
executionStore.test.tsfor an adjacent nullable branch — that file belongs to PR 1 (#11957) and the suggestion is out of scope for this 1-line API fix. Backports should not drift from main's test scope.Manual / browser verification: N/A for this change. The fix is a 1-line feature-flag routing correction with deterministic unit-test coverage. The behavior (binary-decoding
progress_textevent-type-3 frames) is the same code path already shipping in production viamain(v1.44.16+) andcloud/1.43(via bundle PR #11926). End-to-end repro requires the cloud frontend pin to be bumped to acore/1.43build that includes this commit, which is the follow-up step outside this PR.Stack
core/1.43glary/backport-core-1.43-11174-guard-progress-text(merge that first, then retarget)┆Issue is synchronized with this Notion page by Unito