Skip to content

[backport cloud/1.43] Load3D fixes follow-up: #11825 + #11838 - #11975

Merged
DrJKL merged 3 commits into
cloud/1.43from
glary/cloud-1.43-load3d-keybinding-fixes
May 5, 2026
Merged

DrJKL merged 3 commits into
cloud/1.43from
glary/cloud-1.43-load3d-keybinding-fixes

Conversation

@DrJKL

@DrJKL DrJKL commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

Small follow-up to #11926 picking up two Load3D bug fixes the strict pass identified as still missing on cloud/1.43. Skips one originally-shortlisted candidate (#11810) after verification — the bug doesn't exist on cloud/1.43.

Picked

PR Subject User-visible bug
#11825 fix(load3d): snapshot original materials before reapplying materialMode Wireframe / normal / depth modes don't restore the model's true original materials on reload
#11838 fix(load3d): preserve unknown Model Config fields with spread Future Model Config fields silently dropped on viewer dialog cancel/apply (Fixes #11346)

Skipped

  • #11810 ("use capitalize for keybinding badges") — verified not applicable. The bug is uppercase Tailwind class on the Tag in KeyComboDisplay.vue. cloud/1.43's file already uses neither uppercase nor capitalize — it just renders whatever KeyComboImpl.getKeySequences() returns directly, which is already canonical (Ctrl, Alt, Shift). No action needed.

Conflict resolution notes

  • #11825 — modify/delete on SceneModelManager.test.ts (deleted on cloud/1.43). Dropped the test additions; runtime fix in SceneModelManager.ts applied cleanly.
  • #11838 — text conflict in useLoad3dViewer.ts because cloud/1.43 lacks gizmo support. Kept the spread fix (...existingModelConfig + ModelConfig typing) — that is the bug fix — and omitted the gizmo-related Model Config additions.

Verification

  • ✅ pnpm typecheck clean
  • ✅ pnpm typecheck:browser clean
  • ✅ pnpm knip clean
  • ✅ pnpm vitest run src/composables/useLoad3dViewer.test.ts — 39/39 passed

┆Issue is synchronized with this Notion page by Unito

…de (#11825)

(cherry picked from commit 2c8ecd82ee01ab9e88efba24eafa39c8810a572a)
Conflict: SceneModelManager.test.ts deleted on cloud/1.43; runtime fix only.
(cherry picked from commit 6ea5a5e32f1cd3f8e6deeac72b1c89cf03fb6e21)
Conflict: cloud/1.43 lacks gizmo support; kept the spread fix only,
omitted the gizmo Model Config additions.
@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bb8aa150-9197-415d-a071-4df0180f45d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/cloud-1.43-load3d-keybinding-fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

@glary-bot

glary-bot Bot commented May 5, 2026

Copy link
Copy Markdown

Acknowledged — CodeRabbit auto-skipped because the title contains [backport, which is in the repo's ignore-keyword list. Each cherry-pick records its source SHA via cherry picked from commit ..., so the original PRs (#11825, #11838) on main are the canonical review targets.

@github-actions

github-actions Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/05/2026, 06:15:36 PM UTC

Links

@codecov

codecov Bot commented May 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extensions/core/load3d/SceneModelManager.ts 0.00% 4 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.43   #11975   +/-   ##
=============================================
  Coverage              ?   45.39%           
=============================================
  Files                 ?     1348           
  Lines                 ?    69479           
  Branches              ?    18460           
=============================================
  Hits                  ?    31537           
  Misses                ?    37351           
  Partials              ?      591           
Files with missing lines Coverage Δ
src/composables/useLoad3dViewer.ts 77.70% <100.00%> (ø)
src/extensions/core/load3d/SceneModelManager.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 153.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.6 MB heap

No baseline found — showing absolute values.

Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 379ms
canvas-idle: script duration 26ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.0 MB
canvas-idle: DOM nodes 20
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 84
canvas-mouse-sweep: task duration 980ms
canvas-mouse-sweep: script duration 138ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 56.6 MB
canvas-mouse-sweep: DOM nodes 65
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 333ms
canvas-zoom-sweep: script duration 29ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 64.6 MB
canvas-zoom-sweep: DOM nodes 80
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 10ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 344ms
dom-widget-clipping: script duration 68ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 48.0 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 614ms
large-graph-idle: script duration 122ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 53.5 MB
large-graph-idle: DOM nodes -259
large-graph-idle: event listeners -127
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 19ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1146ms
large-graph-pan: script duration 404ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.6 MB
large-graph-pan: DOM nodes -263
large-graph-pan: event listeners -127
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 19ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1417ms
large-graph-zoom: script duration 530ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 60.8 MB
large-graph-zoom: DOM nodes -265
large-graph-zoom: event listeners -123
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 9ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 576ms
minimap-idle: script duration 105ms
minimap-idle: TBT 0ms
minimap-idle: heap used 55.2 MB
minimap-idle: DOM nodes -263
minimap-idle: event listeners -127
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 369ms
subgraph-dom-widget-clipping: script duration 128ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 47.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 11ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 376ms
subgraph-idle: script duration 22ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.5 MB
subgraph-idle: DOM nodes 22
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 48ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 84
subgraph-mouse-sweep: task duration 948ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 53.0 MB
subgraph-mouse-sweep: DOM nodes 73
subgraph-mouse-sweep: event listeners 6
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 55ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3903ms
viewport-pan-sweep: script duration 1290ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.5 MB
viewport-pan-sweep: DOM nodes -255
viewport-pan-sweep: event listeners -111
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12454ms
vue-large-graph-idle: script duration 606ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.3 MB
vue-large-graph-idle: DOM nodes -8329
vue-large-graph-idle: event listeners -16462
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 14524ms
vue-large-graph-pan: script duration 861ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 153.1 MB
vue-large-graph-pan: DOM nodes -8329
vue-large-graph-pan: event listeners -16484
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 5
workflow-execution: style recalc count 12
workflow-execution: task duration 99ms
workflow-execution: script duration 23ms
workflow-execution: TBT 0ms
workflow-execution: heap used 46.6 MB
workflow-execution: DOM nodes 147
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-05-05T17:42:32.706Z",
  "gitSha": "82ac06d34730b993c44c0ec83bf850cff3da40fa",
  "branch": "glary/cloud-1.43-load3d-keybinding-fixes",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.4060000000084,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.326,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.3709999999999,
      "heapDeltaBytes": 21145956,
      "heapUsedBytes": 63776500,
      "domNodes": 20,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 31.319,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 1999.9030000000175,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.659,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.93300000000005,
      "heapDeltaBytes": 20771828,
      "heapUsedBytes": 64004672,
      "domNodes": 19,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 18.080999999999992,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.5450000000837,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.562999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.46399999999994,
      "heapDeltaBytes": 21083728,
      "heapUsedBytes": 63958872,
      "domNodes": 22,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 25.759999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2052.457000000004,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 48.724000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.887,
      "taskDurationMs": 1081.903,
      "heapDeltaBytes": 16196916,
      "heapUsedBytes": 59322184,
      "domNodes": 66,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 149.229,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2032.2329999999624,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 44.106,
      "layouts": 12,
      "layoutDurationMs": 3.68,
      "taskDurationMs": 979.5959999999999,
      "heapDeltaBytes": 16806760,
      "heapUsedBytes": 59332956,
      "domNodes": 65,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 136.77100000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1999.0910000000213,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 43.913999999999994,
      "layouts": 12,
      "layoutDurationMs": 3.5460000000000007,
      "taskDurationMs": 971.8310000000001,
      "heapDeltaBytes": 16734712,
      "heapUsedBytes": 59608276,
      "domNodes": 65,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 137.65800000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1752.8369999999995,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.985000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.682,
      "taskDurationMs": 333.39300000000003,
      "heapDeltaBytes": 25109328,
      "heapUsedBytes": 67727748,
      "domNodes": 80,
      "jsHeapTotalBytes": 20447232,
      "scriptDurationMs": 30.343000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.4939999999979,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.752,
      "layouts": 6,
      "layoutDurationMs": 0.742,
      "taskDurationMs": 336.4119999999999,
      "heapDeltaBytes": 15834412,
      "heapUsedBytes": 67490928,
      "domNodes": 79,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 29.252000000000006,
      "eventListeners": 23,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1729.861000000028,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.279999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.6460000000000001,
      "taskDurationMs": 308.669,
      "heapDeltaBytes": 25061792,
      "heapUsedBytes": 68088792,
      "domNodes": 80,
      "jsHeapTotalBytes": 20971520,
      "scriptDurationMs": 27.876999999999992,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 570.6610000000012,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.786999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.20000000000005,
      "heapDeltaBytes": -3687180,
      "heapUsedBytes": 50343584,
      "domNodes": 22,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 69.64799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 529.7970000000305,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.191,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.847,
      "heapDeltaBytes": 7669244,
      "heapUsedBytes": 50511376,
      "domNodes": 20,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 64.43,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 548.1149999999388,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.674,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.56,
      "heapDeltaBytes": 6775776,
      "heapUsedBytes": 49502124,
      "domNodes": 22,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 67.957,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.8749999999623,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.060000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.093,
      "heapDeltaBytes": 4837088,
      "heapUsedBytes": 56088632,
      "domNodes": -260,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 114.71799999999999,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.3830000000153,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.962000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.5550000000001,
      "heapDeltaBytes": 4581384,
      "heapUsedBytes": 56062616,
      "domNodes": -259,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 121.922,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.7959999999957,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 12.332000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 673.3910000000001,
      "heapDeltaBytes": 4754408,
      "heapUsedBytes": 55860832,
      "domNodes": -256,
      "jsHeapTotalBytes": 15921152,
      "scriptDurationMs": 124.27400000000002,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2123.8500000000045,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.586,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1125.207,
      "heapDeltaBytes": 18091760,
      "heapUsedBytes": 71854936,
      "domNodes": -263,
      "jsHeapTotalBytes": 18223104,
      "scriptDurationMs": 398.461,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2135.1809999999887,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 18.648999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1166.129,
      "heapDeltaBytes": 18098608,
      "heapUsedBytes": 71961316,
      "domNodes": -263,
      "jsHeapTotalBytes": 18485248,
      "scriptDurationMs": 410.44000000000005,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2144.9499999999944,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 18.726,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1146.3380000000002,
      "heapDeltaBytes": 18851352,
      "heapUsedBytes": 72180536,
      "domNodes": -259,
      "jsHeapTotalBytes": 19533824,
      "scriptDurationMs": 404.276,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3166.796999999974,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 17.916999999999994,
      "layouts": 60,
      "layoutDurationMs": 7.481999999999999,
      "taskDurationMs": 1430.896,
      "heapDeltaBytes": 9502784,
      "heapUsedBytes": 65187504,
      "domNodes": -270,
      "jsHeapTotalBytes": 15659008,
      "scriptDurationMs": 530.245,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3206.7240000000083,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 23.178,
      "layouts": 60,
      "layoutDurationMs": 7.988,
      "taskDurationMs": 1417.252,
      "heapDeltaBytes": 3163808,
      "heapUsedBytes": 57776272,
      "domNodes": -262,
      "jsHeapTotalBytes": 17231872,
      "scriptDurationMs": 522.5600000000001,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3161.3139999999476,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 18.748,
      "layouts": 60,
      "layoutDurationMs": 7.404000000000001,
      "taskDurationMs": 1414.225,
      "heapDeltaBytes": 8723636,
      "heapUsedBytes": 63737416,
      "domNodes": -265,
      "jsHeapTotalBytes": 17756160,
      "scriptDurationMs": 540.2570000000001,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.065999999972,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.679999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.211,
      "heapDeltaBytes": 3413800,
      "heapUsedBytes": 57993412,
      "domNodes": -264,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 107.97800000000002,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.357000000014,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.357000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.9510000000001,
      "heapDeltaBytes": 3396608,
      "heapUsedBytes": 57909376,
      "domNodes": -263,
      "jsHeapTotalBytes": 16445440,
      "scriptDurationMs": 104.987,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.4670000000533,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.145999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.667,
      "heapDeltaBytes": 3787592,
      "heapUsedBytes": 56438204,
      "domNodes": -259,
      "jsHeapTotalBytes": 15921152,
      "scriptDurationMs": 104.11499999999998,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 552.9640000000313,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.460999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.348,
      "heapDeltaBytes": 6410072,
      "heapUsedBytes": 49692404,
      "domNodes": 21,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 129.00699999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.9539999999861,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.779,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.964,
      "heapDeltaBytes": 9022160,
      "heapUsedBytes": 58353832,
      "domNodes": 22,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 126.77199999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.8239999999732,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.205,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.61699999999996,
      "heapDeltaBytes": 6430816,
      "heapUsedBytes": 49543160,
      "domNodes": 19,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 128.068,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.3109999999972,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.859,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.84100000000007,
      "heapDeltaBytes": 20001728,
      "heapUsedBytes": 63200428,
      "domNodes": 20,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 23.703000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2042.1419999999557,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.986999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.719,
      "heapDeltaBytes": 20327496,
      "heapUsedBytes": 63607220,
      "domNodes": 23,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 20.741999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.727999999991,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.978000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.983,
      "heapDeltaBytes": 20170556,
      "heapUsedBytes": 63461176,
      "domNodes": 22,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 21.972000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1964.492000000007,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 47.99199999999999,
      "layouts": 16,
      "layoutDurationMs": 4.568,
      "taskDurationMs": 927.2860000000001,
      "heapDeltaBytes": 12647512,
      "heapUsedBytes": 55801636,
      "domNodes": 71,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 107.66999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2003.0970000000252,
      "styleRecalcs": 88,
      "styleRecalcDurationMs": 52.580999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.414,
      "taskDurationMs": 947.646,
      "heapDeltaBytes": 11804816,
      "heapUsedBytes": 54779872,
      "domNodes": 73,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 103.76,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1976.7170000000078,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 46.795,
      "layouts": 16,
      "layoutDurationMs": 4.364,
      "taskDurationMs": 951.4999999999999,
      "heapDeltaBytes": 3281600,
      "heapUsedBytes": 55567376,
      "domNodes": 74,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 106.55000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8193.371000000014,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.33800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3902.9170000000004,
      "heapDeltaBytes": 25956772,
      "heapUsedBytes": 76683252,
      "domNodes": -255,
      "jsHeapTotalBytes": 20058112,
      "scriptDurationMs": 1284.616,
      "eventListeners": -107,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8199.812000000009,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.099000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3888.798,
      "heapDeltaBytes": 26027556,
      "heapUsedBytes": 77039408,
      "domNodes": -257,
      "jsHeapTotalBytes": 19533824,
      "scriptDurationMs": 1289.965,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8271.309999999972,
      "styleRecalcs": 253,
      "styleRecalcDurationMs": 54.70599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3989.5159999999996,
      "heapDeltaBytes": 30381456,
      "heapUsedBytes": 81324452,
      "domNodes": -255,
      "jsHeapTotalBytes": 20582400,
      "scriptDurationMs": 1367.178,
      "eventListeners": -111,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12761.279000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12748.732,
      "heapDeltaBytes": -47137344,
      "heapUsedBytes": 166090224,
      "domNodes": -8329,
      "jsHeapTotalBytes": 26828800,
      "scriptDurationMs": 599.5729999999999,
      "eventListeners": -16466,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12457.430999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12441.959999999997,
      "heapDeltaBytes": -30974984,
      "heapUsedBytes": 166020888,
      "domNodes": -8329,
      "jsHeapTotalBytes": 26042368,
      "scriptDurationMs": 625.679,
      "eventListeners": -16460,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12464.581000000067,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12453.833,
      "heapDeltaBytes": -45666916,
      "heapUsedBytes": 159412164,
      "domNodes": -8333,
      "jsHeapTotalBytes": 17129472,
      "scriptDurationMs": 606.171,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14645.287999999993,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 17.021000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14625.784,
      "heapDeltaBytes": -48172460,
      "heapUsedBytes": 148079500,
      "domNodes": -8329,
      "jsHeapTotalBytes": -3842048,
      "scriptDurationMs": 861.173,
      "eventListeners": -16488,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14298.460999999974,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.762,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14277.658,
      "heapDeltaBytes": -31285484,
      "heapUsedBytes": 169811992,
      "domNodes": -8331,
      "jsHeapTotalBytes": -520192,
      "scriptDurationMs": 856.5489999999999,
      "eventListeners": -16484,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14545.36900000005,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.581000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14523.662999999999,
      "heapDeltaBytes": -35832468,
      "heapUsedBytes": 160566868,
      "domNodes": -8329,
      "jsHeapTotalBytes": -3928064,
      "scriptDurationMs": 890.6510000000001,
      "eventListeners": -16458,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.76600000002645,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 16.009999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.112,
      "taskDurationMs": 80.673,
      "heapDeltaBytes": 2829352,
      "heapUsedBytes": 53270604,
      "domNodes": 145,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 19.150999999999993,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 443.0810000000065,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 24.970000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.377,
      "taskDurationMs": 121.559,
      "heapDeltaBytes": 4485900,
      "heapUsedBytes": 48891744,
      "domNodes": 156,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 29.550000000000008,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 131.06699999991633,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 18.750000000000004,
      "layouts": 5,
      "layoutDurationMs": 1.3230000000000002,
      "taskDurationMs": 98.587,
      "heapDeltaBytes": 2823908,
      "heapUsedBytes": 46596364,
      "domNodes": 147,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 23.252000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@DrJKL DrJKL assigned jtydhr88 and christian-byrne and unassigned jtydhr88 May 5, 2026
@DrJKL
DrJKL marked this pull request as ready for review May 5, 2026 17:53
@DrJKL
DrJKL requested a review from jtydhr88 as a code owner May 5, 2026 17:53
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 5, 2026
@DrJKL
DrJKL enabled auto-merge (squash) May 5, 2026 17:53

@jtydhr88 jtydhr88 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glary-bot

glary-bot Bot commented May 5, 2026

Copy link
Copy Markdown

Thanks for the review @jtydhr88!

@DrJKL
DrJKL merged commit 1272310 into cloud/1.43 May 5, 2026
24 checks passed
@DrJKL
DrJKL deleted the glary/cloud-1.43-load3d-keybinding-fixes branch May 5, 2026 18:21
dante01yoon pushed a commit that referenced this pull request May 8, 2026
…ion (#11950) (#11996)

*PR Created by the Glary-Bot Agent*

---

## Summary

Two follow-up bug fixes that landed on `main` after the previous
backport batches (#11926, #11975).

## Picked

| PR | Subject | User-visible bug |
|---|---|---|
| `#11946` | fix: use resized QPO thumbnails (FE-538) | Floating QPO row
thumbnails currently load full-size image/video assets while the canvas
is being navigated; this swaps to `previewUrl` to use resized
thumbnails. |
| `#11950` | fix: highlight missing input slots on Vue nodes |
Required-input validation highlighting was lost on Vue-rendered node
input slots. Restores the error ring on the missing slot itself by
wiring `useExecutionErrorStore` through `NodeSlots.vue` → `InputSlot`. |

## Conflict resolution notes

- **#11946** — applied cleanly, no conflicts.
- **#11950** —
- `src/renderer/extensions/vueNodes/components/NodeSlots.vue`:
cloud/1.43 imports `cn` from `@/utils/tailwindUtil`, main from
`@comfyorg/tailwind-utils`. Kept cloud/1.43's import path; pulled in the
new `useExecutionErrorStore` and `getLocatorIdFromNodeData` imports
(both modules already exist on cloud/1.43).
- `browser_tests/tests/vueNodes/nodeStates/error.spec.ts`: incoming
version references helpers (`ErrorsTabHelper`, `cleanupFakeModel`) that
don't exist on cloud/1.43. Restored cloud/1.43's version of the test
file and removed the new
`vue-node-required-input-missing-slot-error-chromium-linux.png`
snapshot. The runtime fix in `NodeSlots.vue` lands; the new e2e
regression test would need its helper deps backported separately.

## Verification

- ✅ `pnpm typecheck` clean
- ✅ `pnpm typecheck:browser` clean
- ✅ `pnpm knip` clean
- ✅ Targeted unit tests passing: `NodeSlots.test.ts` (9),
`useErrorClearingHooks.test.ts` (24), `JobAssetsList.test.ts` (16) —
49/49 passed

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11996-backport-cloud-1-43-QPO-thumbnails-11946-Vue-node-slot-validation-11950-3576d73d365081e5b48bd3552cd34294)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants