Repository navigation
[backport cloud/1.43] revert: roll back #10849 + #11697 (per-instance promoted widget values) (#11790) - #12098
Conversation
…s) (#11790) Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. The fix in #10849 caused regressions in promoted-widget serialization (notably the Z-Image-Turbo template, see #10146 follow-up). A replacement fix is being developed on `fix/subgraph-promoted-widget-inline-state` and will land separately. - **Revert #11697** — drops the `it.fails`-marked tests that pin the falsely flip to passing. - **Revert #10849** — removes per-instance `_instanceWidgetValues` map, `_pendingWidgetsValues` configure-time hydration, the `widgets_values` write path in `SubgraphNode.serialize()`, the `sourceSerialize` field on `PromotedWidgetView`, the multi-instance Vitest suite, and the multi-instance E2E test + asset. - **Conflict resolution** in `browser_tests/tests/subgraph/subgraphSerialization.spec.ts`: kept the restored test coverage from #11579 (which is post-#10849 on main) and removed only the now-unreachable multi-instance test, its helper, and its workflow constant. Auto-merge with #11698 (`incrementVersion`) and - Confirm no other on-main code path has come to depend on `PromotedWidgetView.sourceSerialize` or `SubgraphNode._instanceWidgetValues` since #10849 (grep is clean locally). - Confirm we want to land this revert before the replacement fix on `fix/subgraph-promoted-widget-inline-state` is ready — this leaves the original #10146 (multi-instance widget value collision) unfixed in the meantime. - The retained #11579 test coverage now exercises pre-#10849 behavior; some of those assertions were written expecting the #10849 code path. CI will surface any that need adjustment. ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11790-revert-roll-back-10849-11697-per-instance-promoted-widget-values-3536d73d3650814094abd58b6b712d8d) by [Unito](https://www.unito.io) (cherry picked from commit 73d4e24)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Acknowledged — CodeRabbit auto-skipped this PR because |
🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.43 #12098 +/- ##
=============================================
Coverage ? 45.73%
=============================================
Files ? 1350
Lines ? 69775
Branches ? 18412
=============================================
Hits ? 31910
Misses ? 37274
Partials ? 591
🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
No baseline found — showing absolute values.
Raw data{
"timestamp": "2026-05-09T02:53:36.072Z",
"gitSha": "02677784ae8fe0e5ebcb2ad3102d4134a43dc0d9",
"branch": "glary/backport-11790-revert-promoted-widget-values",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.5140000000056,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.278000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.18600000000004,
"heapDeltaBytes": 20297080,
"heapUsedBytes": 63344312,
"domNodes": 12,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 16.977,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2040.2710000000184,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.519,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.812,
"heapDeltaBytes": 21158880,
"heapUsedBytes": 64176516,
"domNodes": 22,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 26.022999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.2969999999941,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.50600000000003,
"heapDeltaBytes": 21103032,
"heapUsedBytes": 63855812,
"domNodes": 22,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 23.862000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2075.033000000019,
"styleRecalcs": 83,
"styleRecalcDurationMs": 44.57600000000001,
"layouts": 12,
"layoutDurationMs": 3.705,
"taskDurationMs": 983.2460000000001,
"heapDeltaBytes": 16363872,
"heapUsedBytes": 59126984,
"domNodes": 69,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 136.00099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2026.2799999999856,
"styleRecalcs": 84,
"styleRecalcDurationMs": 45.678000000000004,
"layouts": 12,
"layoutDurationMs": 3.398,
"taskDurationMs": 999.356,
"heapDeltaBytes": 16359436,
"heapUsedBytes": 59095412,
"domNodes": 66,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 141.46999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1820.391000000086,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.751,
"layouts": 12,
"layoutDurationMs": 3.7649999999999997,
"taskDurationMs": 778.0550000000001,
"heapDeltaBytes": 16797868,
"heapUsedBytes": 59405948,
"domNodes": 60,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 135.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.5919999999674,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.228,
"layouts": 6,
"layoutDurationMs": 0.7359999999999999,
"taskDurationMs": 309.87,
"heapDeltaBytes": 24700892,
"heapUsedBytes": 68062724,
"domNodes": 78,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 20.485000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.9309999999932,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.622000000000003,
"layouts": 6,
"layoutDurationMs": 0.5820000000000001,
"taskDurationMs": 315.717,
"heapDeltaBytes": 24773520,
"heapUsedBytes": 67738824,
"domNodes": 78,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 27.451999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.278999999925,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.727,
"layouts": 6,
"layoutDurationMs": 0.576,
"taskDurationMs": 323.237,
"heapDeltaBytes": 24984036,
"heapUsedBytes": 67705624,
"domNodes": 80,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 27.426000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 568.2840000000056,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.18799999999993,
"heapDeltaBytes": 6517976,
"heapUsedBytes": 49159500,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 72.179,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 576.938000000041,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.355,
"heapDeltaBytes": 6228576,
"heapUsedBytes": 49203932,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 67.76199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 515.4469999999947,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.547,
"heapDeltaBytes": 6777456,
"heapUsedBytes": 49675760,
"domNodes": 23,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 60.88,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2069.560000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.033999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.9749999999999,
"heapDeltaBytes": -18276232,
"heapUsedBytes": 53667840,
"domNodes": -255,
"jsHeapTotalBytes": 19361792,
"scriptDurationMs": 135.97899999999998,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.8479999999827,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.482000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.7379999999999,
"heapDeltaBytes": 13474628,
"heapUsedBytes": 65927084,
"domNodes": -255,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 106.772,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2041.2990000000946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.3470000000001,
"heapDeltaBytes": 5074240,
"heapUsedBytes": 56215652,
"domNodes": -258,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 108.508,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2148.380000000003,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1108.419,
"heapDeltaBytes": 20950744,
"heapUsedBytes": 73203624,
"domNodes": -259,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 406.74,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.3770000000377,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.681999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1077.8919999999998,
"heapDeltaBytes": 16693024,
"heapUsedBytes": 70621376,
"domNodes": -265,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 396.44500000000005,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2128.7849999999935,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.854000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1101.828,
"heapDeltaBytes": 13014036,
"heapUsedBytes": 65382852,
"domNodes": -258,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 402.24199999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3145.4160000000115,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.279,
"layouts": 60,
"layoutDurationMs": 6.828000000000001,
"taskDurationMs": 1288.104,
"heapDeltaBytes": 7511912,
"heapUsedBytes": 62281308,
"domNodes": -265,
"jsHeapTotalBytes": 18018304,
"scriptDurationMs": 479.56000000000006,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3132.1530000000166,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.746000000000002,
"layouts": 60,
"layoutDurationMs": 7.301,
"taskDurationMs": 1335.262,
"heapDeltaBytes": 8696076,
"heapUsedBytes": 64436396,
"domNodes": -269,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 491.783,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3149.432000000047,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.719,
"layouts": 60,
"layoutDurationMs": 6.9750000000000005,
"taskDurationMs": 1315.1899999999998,
"heapDeltaBytes": 9371884,
"heapUsedBytes": 64489860,
"domNodes": -265,
"jsHeapTotalBytes": 15134720,
"scriptDurationMs": 488.523,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.9799999999714,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.456000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.2249999999999,
"heapDeltaBytes": 3664700,
"heapUsedBytes": 57971436,
"domNodes": -261,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 91.09899999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2067.9509999999937,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.134,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.79,
"heapDeltaBytes": 4557264,
"heapUsedBytes": 57347708,
"domNodes": -259,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 105.736,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.506999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.431,
"heapDeltaBytes": 5077072,
"heapUsedBytes": 58041172,
"domNodes": -259,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 108.465,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.2569999999791,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.604,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.512,
"heapDeltaBytes": 6455932,
"heapUsedBytes": 49687984,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 125.08999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 545.1919999999859,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.083,
"heapDeltaBytes": 6226664,
"heapUsedBytes": 49467440,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 122.404,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.5570000000498,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.997,
"heapDeltaBytes": 6853596,
"heapUsedBytes": 49776960,
"domNodes": 20,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 124.59399999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2020.9749999999929,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.95000000000005,
"heapDeltaBytes": 19994616,
"heapUsedBytes": 63252360,
"domNodes": 23,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 21.223000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.3989999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.711,
"heapDeltaBytes": 20957564,
"heapUsedBytes": 64173044,
"domNodes": 20,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 20.168,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.2029999999668,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.44,
"heapDeltaBytes": 19998924,
"heapUsedBytes": 63326280,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 20.274999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1964.4030000000043,
"styleRecalcs": 84,
"styleRecalcDurationMs": 47.111,
"layouts": 16,
"layoutDurationMs": 4.898,
"taskDurationMs": 918.377,
"heapDeltaBytes": 3166408,
"heapUsedBytes": 55501700,
"domNodes": 73,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 103.48299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.1719999999964,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.294,
"layouts": 16,
"layoutDurationMs": 4.696000000000001,
"taskDurationMs": 706.663,
"heapDeltaBytes": 12654332,
"heapUsedBytes": 55816784,
"domNodes": 63,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 102.528,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2014.4770000000563,
"styleRecalcs": 87,
"styleRecalcDurationMs": 46.892,
"layouts": 16,
"layoutDurationMs": 4.494,
"taskDurationMs": 959.707,
"heapDeltaBytes": 11952120,
"heapUsedBytes": 55302724,
"domNodes": 72,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 110.50999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8184.603000000038,
"styleRecalcs": 251,
"styleRecalcDurationMs": 51.04399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3738.462,
"heapDeltaBytes": 28261072,
"heapUsedBytes": 79492984,
"domNodes": -258,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 1256.464,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8210.704000000022,
"styleRecalcs": 252,
"styleRecalcDurationMs": 52.202000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3883.2090000000003,
"heapDeltaBytes": 30201588,
"heapUsedBytes": 81244012,
"domNodes": -255,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 1341.526,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8463.704000000007,
"styleRecalcs": 252,
"styleRecalcDurationMs": 51.522999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4163.57,
"heapDeltaBytes": 84607444,
"heapUsedBytes": 147028492,
"domNodes": -260,
"jsHeapTotalBytes": 85712896,
"scriptDurationMs": 1281.0520000000001,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12498.914999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12484.334,
"heapDeltaBytes": -33322508,
"heapUsedBytes": 165085776,
"domNodes": -8329,
"jsHeapTotalBytes": 24731648,
"scriptDurationMs": 605.954,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12270.389000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12253.679999999998,
"heapDeltaBytes": -32223476,
"heapUsedBytes": 167069572,
"domNodes": -8329,
"jsHeapTotalBytes": 15818752,
"scriptDurationMs": 632.817,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11621.241000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11609.811,
"heapDeltaBytes": -47924792,
"heapUsedBytes": 160752588,
"domNodes": -8329,
"jsHeapTotalBytes": 18440192,
"scriptDurationMs": 569.241,
"eventListeners": -16470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14371.616000000016,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.440000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14347.376,
"heapDeltaBytes": -37709144,
"heapUsedBytes": 160168064,
"domNodes": -8329,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 883.3120000000001,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13829.512000000022,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.357999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13807.025,
"heapDeltaBytes": -11675836,
"heapUsedBytes": 185941828,
"domNodes": -8329,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 842.2570000000001,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14064.792000000012,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.46700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14043.789,
"heapDeltaBytes": -42141872,
"heapUsedBytes": 169804528,
"domNodes": -8329,
"jsHeapTotalBytes": -2093056,
"scriptDurationMs": 874.7890000000001,
"eventListeners": -16492,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 445.5799999999499,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.252,
"layouts": 6,
"layoutDurationMs": 1.6649999999999998,
"taskDurationMs": 131.932,
"heapDeltaBytes": 4793220,
"heapUsedBytes": 49582408,
"domNodes": 167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.539,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 451.55099999999493,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.769000000000002,
"layouts": 5,
"layoutDurationMs": 1.3259999999999998,
"taskDurationMs": 129.60299999999998,
"heapDeltaBytes": 4502276,
"heapUsedBytes": 49589448,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.334,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 441.1159999999654,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.54,
"layouts": 4,
"layoutDurationMs": 0.9750000000000002,
"taskDurationMs": 109.955,
"heapDeltaBytes": 4382712,
"heapUsedBytes": 48861020,
"domNodes": 158,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 23.273999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
PR Created by the Glary-Bot Agent
Summary
Backport of #11790 onto
cloud/1.43. Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697.Why this is needed on
cloud/1.43: Glary-Bot's consolidated backport (#11926) cherry-picked #10849 intocloud/1.43on May 5 — four days after the same change was reverted onmainin #11790. The audit didn't surface the upstream revert. As a result,cloud/1.43(1.43.16) currently ships the buggy #10849 implementation whilemain/ nightly (1.45.1) doesn't. This is the cause of the Hubrob_realistic_2k_images_quick_variationsmodel/vae/clip mixup regression reported in#bug-dump; the same template renders correctly on nightly.After this lands,
cloud/1.43andmainwill be on the same code path for promoted-widget serialization. The replacement fix (#11811 with_pendingWidgetsValuesReplay) will land separately onmainand can be backported afterward.Changes
Mirrors the upstream revert of #10849 + #11697:
_instanceWidgetValuesmap,_pendingWidgetsValueshydration, and thewidgets_valueswrite path inSubgraphNode.serialize()sourceSerializefield onPromotedWidgetViewSubgraphNode.multiInstance.test.ts) and the multi-instance E2E test + workflow assetConflict Resolution
Two conflicts surfaced (vs the original revert, which conflict-resolved against #11579 on
main):browser_tests/tests/subgraph/subgraphSerialization.spec.ts—cloud/1.43does not have the test: restore deleted subgraph serialization E2E tests #11579 expanded test coverage (Duplicate ID Remapping,Legacy Prefixed proxyWidget Normalization) that the original revert preserved. Took thecloud/1.43HEAD structure and removed only the now-unreachable multi-instance test, its helpergetPromotedHostWidgetValues, and the unusedComfyPageimport.src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts—modify/delete(file was present oncloud/1.43's fix: store promoted widget values per SubgraphNode instance #10849 backport, deleted by the revert). Resolved by removing the file, matching the revert.Verification
Static analysis & tests:
pnpm typecheck— cleanpnpm typecheck:browser— cleanpnpm exec eslinton all changed files — cleanpnpm test:unit -- --run subgraph— 506 tests passing across 34 suites (SubgraphNode.test.ts,promotedWidgetView.test.ts,subgraphNodePromotion.test.ts, etc.)Manual verification (Playwright + local dev server):
--cpu --port 8188) andpnpm devfrontend; loaded the page successfully.subgraph-with-multiple-promoted-widgets.json— subgraph node hydrated with 2 promoted widgets.first-promoted-value,second-promoted-value), serialized viaapp.graph.serialize(), and reloaded viaapp.loadGraphData(...). Both values round-tripped correctly to the right widget slots — confirming the revert restores the working single-instance path that nightly currently ships.rob_realistic_2k_images_quick_variations) could not be reproduced locally —comfy.org/workflows/...API returns 404 to anonymous curl from the sandbox, and the Hub UI flow needs auth wired up. The team has already confirmed this template renders correctly on nightly, which ships this same revert.Note on Oracle Review
Oracle flagged the multi-instance regression and the cloud/1.43 forward-compat trade-off as "critical." These describe the intended behavior of this revert — the team has consciously chosen the legacy clobber path over #10849's broken per-instance code while the replacement (#11811) is finalized on
main. Both findings are accepted trade-offs, not blockers.┆Issue is synchronized with this Notion page by Unito