Repository navigation
[backport core/1.43] fix: guard progress_text before canvas init (#11174) - #11957
Conversation
## Summary Prevent early `progress_text` websocket events from throwing before the graph canvas is initialized. ## Changes - **What**: Guard `handleProgressText()` until `canvasStore.canvas` exists, and add a regression test for a startup-time `progress_text` event arriving before `GraphCanvas` finishes initialization. ## Review Focus Confirm this is the right guard point for the startup race between `GraphView` websocket binding and `GraphCanvas` async setup, and that progress text behavior is unchanged once the canvas is ready. ## Validation - `pnpm exec eslint src/stores/executionStore.ts src/stores/executionStore.test.ts` - `pnpm exec vitest run src/stores/executionStore.test.ts -t "should ignore progress_text before the canvas is initialized"` - `pnpm test:unit -- --run src/stores/executionStore.test.ts` still reports one unrelated isolated-file failure in `nodeLocatorIdToExecutionId` on current `main` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11174-fix-guard-progress_text-before-canvas-init-3406d73d3650813dad23d511fb51add5) by [Unito](https://www.unito.io) (cherry picked from commit 2524846)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
|
Re: CodeRabbit auto-skip notification (comment 4378358771) — this is a config-based skip due to For the record on this backport: it's a verbatim cherry-pick of |
🎭 Playwright: ✅ 1052 passed, 0 failed · 3 flaky📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.43 #11957 +/- ##
=============================================
+ Coverage 44.72% 45.11% +0.39%
=============================================
Files 1344 1346 +2
Lines 69046 69383 +337
Branches 19136 18238 -898
=============================================
+ Hits 30878 31301 +423
+ Misses 37573 37487 -86
Partials 595 595
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-05T10:29:23.126Z",
"gitSha": "4f5869ac553c94d105e4978e68bce72090877f71",
"branch": "glary/backport-core-1.43-11174-guard-progress-text",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.1289999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.3469999999999,
"heapDeltaBytes": 20599708,
"heapUsedBytes": 63944828,
"domNodes": 16,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 22.741,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.1939999999463,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.57,
"heapDeltaBytes": 20359448,
"heapUsedBytes": 63408880,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.464000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2045.4130000000532,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.02799999999996,
"heapDeltaBytes": -4085348,
"heapUsedBytes": 44973252,
"domNodes": 23,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 29.41,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2006.7099999999982,
"styleRecalcs": 80,
"styleRecalcDurationMs": 53.043,
"layouts": 12,
"layoutDurationMs": 4.670999999999999,
"taskDurationMs": 919.87,
"heapDeltaBytes": 16435004,
"heapUsedBytes": 59058996,
"domNodes": 64,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 140.08,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.553000000033,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.427,
"layouts": 12,
"layoutDurationMs": 3.8580000000000005,
"taskDurationMs": 813.342,
"heapDeltaBytes": 16741384,
"heapUsedBytes": 59528620,
"domNodes": 60,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 128.669,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.513999999922,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.150000000000006,
"layouts": 12,
"layoutDurationMs": 3.509,
"taskDurationMs": 827.105,
"heapDeltaBytes": 16043876,
"heapUsedBytes": 58910736,
"domNodes": 58,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 133.886,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1765.5650000000378,
"styleRecalcs": 33,
"styleRecalcDurationMs": 20.755999999999997,
"layouts": 6,
"layoutDurationMs": 0.8500000000000003,
"taskDurationMs": 381.07499999999993,
"heapDeltaBytes": 25035544,
"heapUsedBytes": 67751324,
"domNodes": 80,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 32.76,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2620000000438,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.971999999999994,
"layouts": 6,
"layoutDurationMs": 0.74,
"taskDurationMs": 357.67199999999997,
"heapDeltaBytes": 25084048,
"heapUsedBytes": 67712936,
"domNodes": 79,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 33.964,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.0360000000073,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.99,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 339.07,
"heapDeltaBytes": 24925280,
"heapUsedBytes": 67980596,
"domNodes": 80,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 24.622999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 592.833000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7200000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.301,
"heapDeltaBytes": 8066244,
"heapUsedBytes": 59257608,
"domNodes": 17,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 67.939,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 580.9770000000185,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.679,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.231,
"heapDeltaBytes": 6786456,
"heapUsedBytes": 49433840,
"domNodes": 24,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 68.701,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 624.9979999998914,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.08,
"heapDeltaBytes": 6811852,
"heapUsedBytes": 49310464,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 69.3,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2084.5039999999813,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.056,
"heapDeltaBytes": 5127836,
"heapUsedBytes": 55806184,
"domNodes": -253,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 110.80100000000002,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2033.3549999999718,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.662,
"heapDeltaBytes": 4613132,
"heapUsedBytes": 56157372,
"domNodes": -257,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 107.98200000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.3120000000426,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.8340000000001,
"heapDeltaBytes": 4429112,
"heapUsedBytes": 55465664,
"domNodes": -257,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 106.75699999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.025999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.944999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1212.986,
"heapDeltaBytes": -6905888,
"heapUsedBytes": 47787428,
"domNodes": -260,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 406.63300000000004,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2115.528999999981,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1137.989,
"heapDeltaBytes": 12157576,
"heapUsedBytes": 68691748,
"domNodes": -263,
"jsHeapTotalBytes": 18198528,
"scriptDurationMs": 383.22,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2151.9499999999425,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.664999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1277.8470000000002,
"heapDeltaBytes": 5554128,
"heapUsedBytes": 58212384,
"domNodes": -260,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 468.23499999999996,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3317.498999999998,
"styleRecalcs": 66,
"styleRecalcDurationMs": 19.132,
"layouts": 60,
"layoutDurationMs": 8.591999999999999,
"taskDurationMs": 1496.9229999999998,
"heapDeltaBytes": 2701492,
"heapUsedBytes": 67270288,
"domNodes": -262,
"jsHeapTotalBytes": 17346560,
"scriptDurationMs": 520.413,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3199.590999999998,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.295000000000005,
"layouts": 60,
"layoutDurationMs": 7.835,
"taskDurationMs": 1346.863,
"heapDeltaBytes": 9706600,
"heapUsedBytes": 65180660,
"domNodes": -267,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 475.96799999999996,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3326.308999999924,
"styleRecalcs": 68,
"styleRecalcDurationMs": 20.610999999999997,
"layouts": 60,
"layoutDurationMs": 8.053999999999998,
"taskDurationMs": 1456.452,
"heapDeltaBytes": 3427244,
"heapUsedBytes": 58476936,
"domNodes": -260,
"jsHeapTotalBytes": 16551936,
"scriptDurationMs": 506.85999999999996,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.667000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.486999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.1709999999999,
"heapDeltaBytes": 3611864,
"heapUsedBytes": 58080688,
"domNodes": -263,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 99.746,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2073.0819999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.302999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.0869999999999,
"heapDeltaBytes": 4551824,
"heapUsedBytes": 57942560,
"domNodes": -259,
"jsHeapTotalBytes": 16347136,
"scriptDurationMs": 107.709,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.4250000000457,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.971000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.713,
"heapDeltaBytes": 18815888,
"heapUsedBytes": 71752960,
"domNodes": -257,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 98.95499999999998,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.3989999999908,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.75000000000006,
"heapDeltaBytes": 6995696,
"heapUsedBytes": 49844712,
"domNodes": 23,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 134.02800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.4169999999499,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.510000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.0739999999999,
"heapDeltaBytes": 7584852,
"heapUsedBytes": 58694060,
"domNodes": 24,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 123.33899999999998,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.3019999999569,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.19500000000005,
"heapDeltaBytes": 6497996,
"heapUsedBytes": 49782220,
"domNodes": 23,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 132.70100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1997.09900000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.21,
"heapDeltaBytes": 20262672,
"heapUsedBytes": 63445212,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 24.523000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.9169999999494,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.156000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.44800000000004,
"heapDeltaBytes": 20026532,
"heapUsedBytes": 62874252,
"domNodes": 18,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 25.483000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.470999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.103999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.152,
"heapDeltaBytes": 19898476,
"heapUsedBytes": 63132360,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 19.093,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2028.7659999999903,
"styleRecalcs": 88,
"styleRecalcDurationMs": 53.642999999999994,
"layouts": 16,
"layoutDurationMs": 5.385,
"taskDurationMs": 1056.796,
"heapDeltaBytes": 11866684,
"heapUsedBytes": 54731872,
"domNodes": 74,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 106.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.7060000000256,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.174,
"layouts": 16,
"layoutDurationMs": 4.922000000000001,
"taskDurationMs": 737.22,
"heapDeltaBytes": 11798236,
"heapUsedBytes": 54743680,
"domNodes": 64,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 98.768,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2025.258000000008,
"styleRecalcs": 88,
"styleRecalcDurationMs": 52.504,
"layouts": 16,
"layoutDurationMs": 5.3790000000000004,
"taskDurationMs": 1035.147,
"heapDeltaBytes": 2398552,
"heapUsedBytes": 54724080,
"domNodes": 75,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 106.15100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8179.970000000026,
"styleRecalcs": 252,
"styleRecalcDurationMs": 50.053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4351.105,
"heapDeltaBytes": 1687408,
"heapUsedBytes": 52472148,
"domNodes": -259,
"jsHeapTotalBytes": 18804736,
"scriptDurationMs": 1374.5810000000001,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.478999999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3883.0339999999997,
"heapDeltaBytes": 28532348,
"heapUsedBytes": 80418788,
"domNodes": -261,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 1259.6860000000001,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8170.495999999957,
"styleRecalcs": 251,
"styleRecalcDurationMs": 48.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4092.287,
"heapDeltaBytes": 1077664,
"heapUsedBytes": 52359492,
"domNodes": -255,
"jsHeapTotalBytes": 18018304,
"scriptDurationMs": 1275.143,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11771.911000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11746.798999999999,
"heapDeltaBytes": -33330088,
"heapUsedBytes": 165363468,
"domNodes": -8329,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 601.558,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10694.362000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10679.342,
"heapDeltaBytes": -40163380,
"heapUsedBytes": 166083840,
"domNodes": -8329,
"jsHeapTotalBytes": 24469504,
"scriptDurationMs": 561.9049999999999,
"eventListeners": -16470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10828.970000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10811.4,
"heapDeltaBytes": -32162592,
"heapUsedBytes": 165766324,
"domNodes": -8329,
"jsHeapTotalBytes": 26042368,
"scriptDurationMs": 576.392,
"eventListeners": -16465,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12949.951999999996,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.739000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12912.256999999998,
"heapDeltaBytes": -24805904,
"heapUsedBytes": 174161756,
"domNodes": -8329,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 936.8969999999999,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13226.974999999982,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.645999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13204.067000000003,
"heapDeltaBytes": -50310940,
"heapUsedBytes": 148670524,
"domNodes": -8331,
"jsHeapTotalBytes": -3579904,
"scriptDurationMs": 873.673,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13253.381999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.963999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13226.396,
"heapDeltaBytes": -48546424,
"heapUsedBytes": 148330492,
"domNodes": -8329,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 879.586,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.11600000000453,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.247000000000003,
"layouts": 5,
"layoutDurationMs": 2.1980000000000004,
"taskDurationMs": 134.53699999999998,
"heapDeltaBytes": 4624396,
"heapUsedBytes": 49188788,
"domNodes": 182,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 25.655000000000005,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 457.19599999995353,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.548999999999996,
"layouts": 5,
"layoutDurationMs": 1.476,
"taskDurationMs": 133.255,
"heapDeltaBytes": 4501152,
"heapUsedBytes": 48482300,
"domNodes": 156,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.381,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 447.28599999996277,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.872000000000003,
"layouts": 5,
"layoutDurationMs": 1.4569999999999999,
"taskDurationMs": 126.16800000000003,
"heapDeltaBytes": 4469184,
"heapUsedBytes": 48922652,
"domNodes": 156,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.324,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
…ugh getDevOverride (#11384) (#11958) *PR Created by the Glary-Bot Agent* --- Cherry-pick of `4b7a02794` (PR #11384) from `main` onto `core/1.43`. This is **PR 2 of 2** in a sequential stack. **Stacked on top of #11957** (`fix: guard progress_text before canvas init`). **Merge #11957 first**, then this PR's base will retarget to `core/1.43`. ## Why Cloud reports of "Preview as Text" not displaying output when fed by API nodes traced back to two missing `progress_text` WebSocket fixes on `core/1.43`. The bundle PR #11926 picked these onto `cloud/1.43` but `core/1.43` was not in scope. This is the **primary fix** for the API-node Preview-as-Text symptom: `api.ts` was checking the **client** feature flags instead of **server** feature flags before parsing the new `progress_text` binary wire format (`[event_type][prompt_id_len][prompt_id][node_id_len][node_id][text]`). When the server advertised `supports_progress_text_metadata` (which v0.20.2 does) but the client check failed silently, the new wire format was parsed as the legacy format, mangling the bytes — which is exactly why API-node text outputs (which stream via `progress_text`) failed while Concatenate (which doesn't use `progress_text`) worked. Status confirmed via: - `git merge-base --is-ancestor 4b7a027 origin/main` → YES - `git merge-base --is-ancestor 4b7a027 origin/core/1.43` → NO (needs pick) ## Original PR Summary (#11384) > Route the `progress_text` binary parser's feature-flag check through `serverSupportsFeature()` so dev overrides via `localStorage` take effect. Replace `this.getClientFeatureFlags()?.supports_progress_text_metadata` with `this.serverSupportsFeature('supports_progress_text_metadata')` in the `case 3` binary message handler, consistent with all other feature-flag checks in the class. ## Files Changed - `src/scripts/api.ts` — 1 line: route the `progress_text` flag check through `serverSupportsFeature()` ## Verification **Local automated checks:** - `pnpm typecheck` → clean - `pnpm exec eslint src/scripts/api.ts` → 0 errors (file is in lint ignore list, expected) - `pnpm exec vitest run src/scripts/api.featureFlags.test.ts` → **15/15 passed** - Cherry-pick applied cleanly with no conflicts **Code review (Oracle):** 0 critical, 0 warning, 1 suggestion. Suggestion was about extending test coverage in `executionStore.test.ts` for an adjacent nullable branch — that file belongs to PR 1 (#11957) and the suggestion is out of scope for this 1-line API fix. Backports should not drift from main's test scope. **Manual / browser verification:** N/A for this change. The fix is a 1-line feature-flag routing correction with deterministic unit-test coverage. The behavior (binary-decoding `progress_text` event-type-3 frames) is the same code path already shipping in production via `main` (v1.44.16+) and `cloud/1.43` (via bundle PR #11926). End-to-end repro requires the cloud frontend pin to be bumped to a `core/1.43` build that includes this commit, which is the follow-up step outside this PR. ## Stack - Previous PR (#11957) → `core/1.43` - **This PR** → `glary/backport-core-1.43-11174-guard-progress-text` (merge that first, then retarget) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11958-backport-core-1-43-fix-route-progress_text-feature-flag-check-through-getDevOverride--3576d73d365081d486b2d71ee8beb522) by [Unito](https://www.unito.io) Co-authored-by: GitHub Action <action@github.com>
PR Created by the Glary-Bot Agent
Cherry-pick of
2524846f5(PR #11174) frommainontocore/1.43.This is PR 1 of 2 in a sequential stack of
progress_textWebSocket fixes that thecore/1.43branch is missing. PR 2 (#11384,route progress_text feature flag check through getDevOverride) will stack on top of this branch.Why
Cloud reports of "Preview as Text" not displaying output when fed by API nodes traced back to two missing
progress_textWebSocket fixes oncore/1.43. The bundle PR #11926 picked these ontocloud/1.43butcore/1.43was not in scope and is still missing them.Status confirmed via:
git merge-base --is-ancestor 2524846f5 origin/main→ YESgit merge-base --is-ancestor 2524846f5 origin/core/1.43→ NO (needs pick)Original PR Summary (#11174)
Files Changed
src/stores/executionStore.ts— null-guard canvas access at line 530 (canvas?.graph?...)src/stores/executionStore.test.ts— regression test for pre-canvas-init eventVerification
Local automated checks:
pnpm typecheck→ cleanpnpm exec eslint src/stores/executionStore.ts src/stores/executionStore.test.ts→ 0 errorspnpm exec vitest run src/stores/executionStore.test.ts→ 40/40 passedpnpm exec vitest run src/stores/executionStore.test.ts -t "progress_text"→ 2/2 targeted regression tests passCode review (Oracle): no critical or warning issues. Reviewer noted that early
progress_textevents are now silently dropped — this is the intended upstream behavior.Manual / browser verification: N/A for this change. The bug is a startup race where early
progress_textbinary WS frames (event type 3) hitexecutionStorebefore thecanvasStore.canvasis set. The deterministic regression test inexecutionStore.test.tssimulates this race via mocked stores; reproducing it in a live browser would not be more meaningful and would not produce any visual diff. This is also a verbatim pick of a commit already shipping in production viamain(v1.44.16+) andcloud/1.43(via bundle PR #11926).Stack
core/1.43┆Issue is synchronized with this Notion page by Unito