Skip to content

test: extract shared subgraph E2E test utilities - #10629

Merged
DrJKL merged 5 commits into
mainfrom
drjkl/test/subgraphs-1
Mar 28, 2026
Merged

DrJKL merged 5 commits into
mainfrom
drjkl/test/subgraphs-1

Conversation

@DrJKL

@DrJKL DrJKL commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Extract repeated patterns from 12 subgraph Playwright spec files into shared test utilities, reducing duplication by ~142 lines.

Changes

  • What: New shared helpers for common subgraph test operations:
    • SubgraphHelper: getSlotCount(), getSlotLabel(), removeSlot(), findSubgraphNodeId()
    • NodeReference: delete()
    • subgraphTestUtils: serializeAndReload(), convertDefaultKSamplerToSubgraph(), expectWidgetBelowHeader(), collectConsoleWarnings(), packAllInteriorNodes()
    • Replaced ~72 inline page.evaluate blocks and multi-line sequences with single helper calls across 12 spec files

Review Focus

  • Behavioral equivalence: every replacement is a mechanical extraction with no test logic changes
  • API surface of new helpers: naming, parameter types, placement in existing utility classes
  • Whether any remaining inline patterns in the spec files would benefit from further extraction

┆Issue is synchronized with this Notion page by Unito

@coderabbitai

coderabbitai Bot commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adds comprehensive Subgraph testing helpers and a node deletion utility, removes a legacy test helper file, and updates many browser tests to use the new helper APIs instead of inline page.evaluate, DOM inspections, context-menu flows, and manual console listeners.

Changes

Cohort / File(s) Summary
Subgraph helper & utilities
browser_tests/fixtures/helpers/SubgraphHelper.ts
Added instance methods: getSlotCount, getSlotLabel, removeSlot, findSubgraphNodeId, serializeAndReload, convertDefaultKSamplerToSubgraph, packAllInteriorNodes; added static utilities: getTextSlotPosition, expectWidgetBelowHeader, collectConsoleWarnings. Updated imports for Playwright types and workflow schema.
Litegraph node utilities
browser_tests/fixtures/utils/litegraphUtils.ts
Added NodeReference.delete(): Promise<void> to remove nodes via keyboard/Delete flow.
Removed legacy helpers
browser_tests/helpers/subgraphTestUtils.ts
Deleted legacy helpers (assertSubgraph, prior getTextSlotPosition) moved into SubgraphHelper.
Test updates — API adoption
browser_tests/tests/.../subgraph*.spec.ts, browser_tests/tests/subgraph-promoted-widget-dom.spec.ts
Replaced inline page.evaluate graph inspections, DOM bounding-box logic, context-menu interactions, manual console listeners, and UI deletion flows with comfyPage.subgraph.*, SubgraphHelper.*, and NodeReference.delete() calls across many subgraph-related tests (slot counts/labels, navigation checks, serialization round-trips, packing, promoted-widget position, console-warnings capture).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • AustinMroz
  • christian-byrne
  • benceruleanlu

Poem

🐇
I hopped through slots and labels bright,
Packed nodes by day and tested night,
I clicked, I serialized, I cleared a warn,
With tiny paws the bugs were shorn,
Now tests call helpers—hooray, delight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: extracting shared subgraph E2E test utilities to reduce duplication.
Description check ✅ Passed The description follows the template, includes summary, detailed changes, and review focus. However, the Breaking/Dependencies sections are omitted (expected for this type of refactor).
End-To-End Regression Coverage For Fixes ✅ Passed PR contains a commit with 'fix' language and modifies 16 files under browser_tests/ including multiple spec test files.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR modifies only test files in browser_tests/ directory, not src/lib/litegraph/, src/ecs/, or core graph entity implementations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drjkl/test/subgraphs-1

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (3)
browser_tests/tests/appModeWidgetRename.spec.ts (1)

17-67: Consider extracting the remaining builder-setup flow into the shared utils.

setupSubgraphBuilder still contains a sizable inline sequence (seed selection + output node selection). Moving that block into subgraphTestUtils would keep this spec focused on rename behavior and improve reuse across subgraph specs.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/appModeWidgetRename.spec.ts` around lines 17 - 67,
setupSubgraphBuilder contains a long inline sequence (seed selection + output
node selection) that should be moved to shared utilities; extract the flow
starting from the seed widget selection (the block using subgraphNode.getWidget,
getPosition, page.evaluate to read NODE_TITLE_HEIGHT, and page.mouse.click)
through the output node selection (the appMode.goToOutputs call, page.evaluate
that finds SaveImage/PreviewImage, comfyPage.nodeOps.getNodeRefById and
saveImageRef.centerOnNode plus the canvas click) into a new helper in
subgraphTestUtils (e.g., selectPromotedSeedAndCenterOutput), then replace that
inline block in setupSubgraphBuilder with a call to the new helper and keep
existing calls to fitToViewInstant, appMode.enterBuilder, appMode.goToInputs,
comfyPage.canvasOps.setScale and subgraphNode.centerOnNode intact so behavior is
unchanged.
browser_tests/helpers/subgraphTestUtils.ts (1)

107-123: collectConsoleWarnings should expose a detach path for the console listener.

Right now every call adds a permanent page.on('console') handler for that page, which can duplicate captures in longer tests.

♻️ Suggested update with disposer
-export function collectConsoleWarnings(
+export function collectConsoleWarnings(
   page: Page,
   patterns: string[] = [
     'No link found',
     'Failed to resolve legacy -1',
     'No inner link found'
   ]
-): string[] {
+): { warnings: string[]; dispose: () => void } {
   const warnings: string[] = []
-  page.on('console', (msg) => {
+  const handler = (msg: { text: () => string }) => {
     const text = msg.text()
     if (patterns.some((p) => text.includes(p))) {
       warnings.push(text)
     }
-  })
-  return warnings
+  }
+  page.on('console', handler)
+  return {
+    warnings,
+    dispose: () => page.off('console', handler)
+  }
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/helpers/subgraphTestUtils.ts` around lines 107 - 123,
collectConsoleWarnings currently attaches a permanent page.on('console') handler
(in function collectConsoleWarnings) which can accumulate duplicates; change it
to register the listener as a named callback, push matched messages into the
warnings array, and return a disposer (e.g., return { warnings, stop } or
[warnings, stop]) that calls page.off('console', listener) (or
page.removeListener) to detach the handler when the test is done; keep the
patterns parameter and behavior but ensure you reference the same listener
instance when removing it.
browser_tests/tests/subgraph.spec.ts (1)

112-113: Prefer explicit null guards for slot labels before rename actions.

At Line 112 (and the other listed reads), getSlotLabel() can return null, but downstream usage relies on non-null assertions. An explicit guard gives deterministic failure messages when fixtures evolve.

♻️ Suggested pattern
 const initialInputLabel = await comfyPage.subgraph.getSlotLabel('inputs')
+if (initialInputLabel === null) {
+  throw new Error('Expected subgraph to have at least one input slot label')
+}
 
-await comfyPage.subgraph.rightClickInputSlot(initialInputLabel!)
+await comfyPage.subgraph.rightClickInputSlot(initialInputLabel)

Also applies to: 140-141, 166-167, 196-197, 228-229

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraph.spec.ts` around lines 112 - 113, The tests call
comfyPage.subgraph.getSlotLabel(...) which can return null but the code proceeds
assuming non-null; add explicit null guards where getSlotLabel('inputs') (and
the other calls at the listed locations) are used before any rename action:
check the returned value and throw or assert with a clear message like "expected
slot label for 'inputs' to be present" (or use expect(...).not.toBeNull()) so
the subsequent rename/usage (the code referencing the label) only runs when the
label is non-null; update each occurrence that reads getSlotLabel to perform
this explicit check (reference comfyPage.subgraph.getSlotLabel) before
proceeding.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/helpers/subgraphTestUtils.ts`:
- Around line 107-123: collectConsoleWarnings currently attaches a permanent
page.on('console') handler (in function collectConsoleWarnings) which can
accumulate duplicates; change it to register the listener as a named callback,
push matched messages into the warnings array, and return a disposer (e.g.,
return { warnings, stop } or [warnings, stop]) that calls page.off('console',
listener) (or page.removeListener) to detach the handler when the test is done;
keep the patterns parameter and behavior but ensure you reference the same
listener instance when removing it.

In `@browser_tests/tests/appModeWidgetRename.spec.ts`:
- Around line 17-67: setupSubgraphBuilder contains a long inline sequence (seed
selection + output node selection) that should be moved to shared utilities;
extract the flow starting from the seed widget selection (the block using
subgraphNode.getWidget, getPosition, page.evaluate to read NODE_TITLE_HEIGHT,
and page.mouse.click) through the output node selection (the appMode.goToOutputs
call, page.evaluate that finds SaveImage/PreviewImage,
comfyPage.nodeOps.getNodeRefById and saveImageRef.centerOnNode plus the canvas
click) into a new helper in subgraphTestUtils (e.g.,
selectPromotedSeedAndCenterOutput), then replace that inline block in
setupSubgraphBuilder with a call to the new helper and keep existing calls to
fitToViewInstant, appMode.enterBuilder, appMode.goToInputs,
comfyPage.canvasOps.setScale and subgraphNode.centerOnNode intact so behavior is
unchanged.

In `@browser_tests/tests/subgraph.spec.ts`:
- Around line 112-113: The tests call comfyPage.subgraph.getSlotLabel(...) which
can return null but the code proceeds assuming non-null; add explicit null
guards where getSlotLabel('inputs') (and the other calls at the listed
locations) are used before any rename action: check the returned value and throw
or assert with a clear message like "expected slot label for 'inputs' to be
present" (or use expect(...).not.toBeNull()) so the subsequent rename/usage (the
code referencing the label) only runs when the label is non-null; update each
occurrence that reads getSlotLabel to perform this explicit check (reference
comfyPage.subgraph.getSlotLabel) before proceeding.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8d29cd1c-ac38-4d80-a022-b5645f1c3043

📥 Commits

Reviewing files that changed from the base of the PR and between 070a5f5 and ffab360.

📒 Files selected for processing (15)
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/fixtures/utils/litegraphUtils.ts
  • browser_tests/helpers/subgraphTestUtils.ts
  • browser_tests/tests/appModeWidgetRename.spec.ts
  • browser_tests/tests/subgraph-promoted-widget-dom.spec.ts
  • browser_tests/tests/subgraph-rename-dialog.spec.ts
  • browser_tests/tests/subgraph.spec.ts
  • browser_tests/tests/subgraphInputSlotRename.spec.ts
  • browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts
  • browser_tests/tests/subgraphLifecycle.spec.ts
  • browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
  • browser_tests/tests/subgraphNestedPackValues.spec.ts
  • browser_tests/tests/subgraphProgressClear.spec.ts
  • browser_tests/tests/subgraphPromotion.spec.ts
  • browser_tests/tests/subgraphSearchAliases.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Mar 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts (1)

34-34: Consider calling dispose() for consistency with the helper's design.

The collectConsoleWarnings helper returns a dispose function to remove the listener. While Playwright's fresh page contexts make this unlikely to cause issues, calling dispose() after the assertion maintains consistency with the helper's design and documents the intended cleanup pattern.

♻️ Optional: Call dispose after assertion
-      const { warnings } = collectConsoleWarnings(comfyPage.page)
+      const { warnings, dispose } = collectConsoleWarnings(comfyPage.page)

       await comfyPage.workflow.loadWorkflow(WORKFLOW)

       expect(warnings).toEqual([])
+      dispose()
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts` at line 34,
The test uses collectConsoleWarnings(comfyPage.page) which returns a dispose
function that removes the console listener; call that dispose() after you finish
asserting on warnings to consistently clean up the listener — locate the
collectConsoleWarnings call in subgraphLegacyPrefixedProxyWidgets.spec.ts and
invoke the returned dispose() (e.g., const { warnings, dispose } =
collectConsoleWarnings(...); ... expect(...); dispose();) immediately after the
assertion to follow the helper's intended cleanup pattern.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts`:
- Line 34: The test uses collectConsoleWarnings(comfyPage.page) which returns a
dispose function that removes the console listener; call that dispose() after
you finish asserting on warnings to consistently clean up the listener — locate
the collectConsoleWarnings call in subgraphLegacyPrefixedProxyWidgets.spec.ts
and invoke the returned dispose() (e.g., const { warnings, dispose } =
collectConsoleWarnings(...); ... expect(...); dispose();) immediately after the
assertion to follow the helper's intended cleanup pattern.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f98b80de-80eb-42b6-9337-7d257e2b84ff

📥 Commits

Reviewing files that changed from the base of the PR and between ffab360 and e558868.

📒 Files selected for processing (7)
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/helpers/subgraphTestUtils.ts
  • browser_tests/tests/subgraph-duplicate-ids.spec.ts
  • browser_tests/tests/subgraph-rename-dialog.spec.ts
  • browser_tests/tests/subgraph.spec.ts
  • browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts
  • browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
✅ Files skipped from review due to trivial changes (1)
  • browser_tests/tests/subgraph.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • browser_tests/fixtures/helpers/SubgraphHelper.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Mar 27, 2026
DrJKL and others added 2 commits March 27, 2026 15:02
Extract repeated patterns from 12 subgraph Playwright spec files into
shared utilities, reducing duplication by ~142 lines.

New SubgraphHelper methods:
- getSlotCount(type) — subgraph I/O slot count
- getSlotLabel(type, index?) — slot label/name
- removeSlot(type, slotName?) — right-click + Remove Slot
- findSubgraphNodeId() — find first subgraph node in graph

New NodeReference method:
- delete() — click title + Delete key + nextFrame

New subgraphTestUtils helpers:
- serializeAndReload() — graph serialize/loadGraphData round-trip
- convertDefaultKSamplerToSubgraph() — common test setup
- expectWidgetBelowHeader() — DOM position assertion
- collectConsoleWarnings() — console warning interception
- packAllInteriorNodes() — enter subgraph + select all + convert

Amp-Thread-ID: https://ampcode.com/threads/T-019d30ce-1665-76d1-9164-a95b1d92ba34
Co-authored-by: Amp <amp@ampcode.com>
- Return disposer from collectConsoleWarnings to prevent listener leaks
- Unify slot type params to singular 'input'|'output' across SubgraphHelper
- Replace || with ?? in getSlotCount and getSlotLabel for correctness
- Remove dead assertSubgraph export and unused imports
- Migrate subgraph-duplicate-ids.spec.ts to shared isInSubgraph helper
- Add trust-boundary comment on serializeAndReload cast
- Use early-throw narrowing in expectWidgetBelowHeader

Amp-Thread-ID: https://ampcode.com/threads/T-019d311b-133d-71a8-87bb-e628ea82f90c
Co-authored-by: Amp <amp@ampcode.com>
@github-actions

github-actions Bot commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 03/28/2026, 09:06:57 PM UTC

Links

@github-actions

github-actions Bot commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 749 passed, 0 failed · 6 flaky

📊 Browser Reports
  • chromium: View Report (✅ 735 / ❌ 0 / ⚠️ 6 / ⏭️ 1)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 11 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.09 MB gzip 🔴 +303 B

Details

Summary

  • Raw size: 23.4 MB baseline 23.4 MB — ⚪ 0 B
  • Gzip: 5.09 MB baseline 5.09 MB — 🔴 +303 B
  • Brotli: 3.94 MB baseline 3.94 MB — 🔴 +110 B
  • Bundles: 249 current • 249 baseline • 114 added / 114 removed

Category Glance
Vendor & Third-Party ⚪ 0 B (9.8 MB) · Other ⚪ 0 B (8.43 MB) · Data & Services ⚪ 0 B (2.96 MB) · Graph Workspace ⚪ 0 B (1.14 MB) · Panels & Settings ⚪ 0 B (484 kB) · Utilities & Hooks ⚪ 0 B (334 kB) · + 5 more

App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CqTDLdMz.js (removed) 22.3 kB — 🟢 -22.3 kB 🟢 -7.93 kB 🟢 -6.82 kB
assets/index-DYrCavW1.js (new) — 22.3 kB 🔴 +22.3 kB 🔴 +7.93 kB 🔴 +6.79 kB

Status: 1 added / 1 removed

Graph Workspace — 1.14 MB (baseline 1.14 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-A7hhMc36.js (new) — 1.14 MB 🔴 +1.14 MB 🔴 +244 kB 🔴 +184 kB
assets/GraphView-DYTlE0Ke.js (removed) 1.14 MB — 🟢 -1.14 MB 🟢 -244 kB 🟢 -184 kB

Status: 1 added / 1 removed

Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BEMJt2oY.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.4 kB 🟢 -2.9 kB
assets/CloudSurveyView-CYbB12wz.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.4 kB 🔴 +2.9 kB
assets/CloudLoginView-DZz1Y1C0.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.35 kB 🟢 -2.96 kB
assets/CloudLoginView-NWFnVpoL.js (new) — 12 kB 🔴 +12 kB 🔴 +3.36 kB 🔴 +2.96 kB
assets/CloudSignupView-3jpCPLvP.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.85 kB 🔴 +2.52 kB
assets/CloudSignupView-CgQLuJHE.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.85 kB 🟢 -2.49 kB
assets/UserCheckView-BkQUjiBd.js (new) — 9.04 kB 🔴 +9.04 kB 🔴 +2.33 kB 🔴 +2.02 kB
assets/UserCheckView-CQ_BVT_c.js (removed) 9.04 kB — 🟢 -9.04 kB 🟢 -2.33 kB 🟢 -2.03 kB
assets/CloudLayoutView-6vR47oWK.js (new) — 7.54 kB 🔴 +7.54 kB 🔴 +2.36 kB 🔴 +2.04 kB
assets/CloudLayoutView-DICKqlNs.js (removed) 7.54 kB — 🟢 -7.54 kB 🟢 -2.36 kB 🟢 -2.05 kB
assets/CloudForgotPasswordView-BvUgiror.js (removed) 5.94 kB — 🟢 -5.94 kB 🟢 -2.09 kB 🟢 -1.85 kB
assets/CloudForgotPasswordView-C1WTImje.js (new) — 5.94 kB 🔴 +5.94 kB 🔴 +2.1 kB 🔴 +1.86 kB
assets/CloudAuthTimeoutView-DAnLvHYj.js (removed) 5.31 kB — 🟢 -5.31 kB 🟢 -1.93 kB 🟢 -1.69 kB
assets/CloudAuthTimeoutView-L-pqRtzT.js (new) — 5.31 kB 🔴 +5.31 kB 🔴 +1.93 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-7m8PoUvN.js (removed) 5.08 kB — 🟢 -5.08 kB 🟢 -1.91 kB 🟢 -1.69 kB
assets/CloudSubscriptionRedirectView-BOd11JmC.js (new) — 5.08 kB 🔴 +5.08 kB 🔴 +1.91 kB 🔴 +1.69 kB
assets/UserSelectView-r86KdvYw.js (removed) 4.71 kB — 🟢 -4.71 kB 🟢 -1.74 kB 🟢 -1.54 kB
assets/UserSelectView-xg5oaeI2.js (new) — 4.71 kB 🔴 +4.71 kB 🔴 +1.74 kB 🔴 +1.54 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-BqKO1wR4.js (new) — 46.6 kB 🔴 +46.6 kB 🔴 +9.52 kB 🔴 +8.47 kB
assets/KeybindingPanel-BzWi-Ff2.js (removed) 46.6 kB — 🟢 -46.6 kB 🟢 -9.52 kB 🟢 -8.46 kB
assets/SecretsPanel-Bhdbb-o0.js (new) — 22.4 kB 🔴 +22.4 kB 🔴 +5.42 kB 🔴 +4.76 kB
assets/SecretsPanel-EqipMKmH.js (removed) 22.4 kB — 🟢 -22.4 kB 🟢 -5.42 kB 🟢 -4.76 kB
assets/LegacyCreditsPanel-ClDEwyCo.js (new) — 21.5 kB 🔴 +21.5 kB 🔴 +5.81 kB 🔴 +5.13 kB
assets/LegacyCreditsPanel-D1ukBTb5.js (removed) 21.5 kB — 🟢 -21.5 kB 🟢 -5.81 kB 🟢 -5.13 kB
assets/SubscriptionPanel-Bk_YC7Rl.js (removed) 19.7 kB — 🟢 -19.7 kB 🟢 -5.01 kB 🟢 -4.4 kB
assets/SubscriptionPanel-D1A9EtDh.js (new) — 19.7 kB 🔴 +19.7 kB 🔴 +5.01 kB 🔴 +4.41 kB
assets/AboutPanel-BgUx_eiv.js (new) — 12 kB 🔴 +12 kB 🔴 +3.32 kB 🔴 +2.97 kB
assets/AboutPanel-CgKfT5Se.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.32 kB 🟢 -2.98 kB
assets/ExtensionPanel-CwiqRL2V.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.82 kB 🔴 +2.51 kB
assets/ExtensionPanel-Dhi2IaDN.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.82 kB 🟢 -2.51 kB
assets/ServerConfigPanel-DMsD2Y-W.js (new) — 6.85 kB 🔴 +6.85 kB 🔴 +2.28 kB 🔴 +2.03 kB
assets/ServerConfigPanel-mhd4vWVX.js (removed) 6.85 kB — 🟢 -6.85 kB 🟢 -2.27 kB 🟢 -2.03 kB
assets/UserPanel-ChcKR2Pg.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -2.15 kB 🟢 -1.9 kB
assets/UserPanel-Cs_0S-74.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +2.16 kB 🔴 +1.9 kB
assets/cloudRemoteConfig-BuentT-L.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +903 B 🔴 +792 B
assets/cloudRemoteConfig-DhQCReaa.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -900 B 🟢 -775 B
assets/refreshRemoteConfig-D1CGnmVx.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +650 B 🔴 +549 B
assets/refreshRemoteConfig-RWMR89ow.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -650 B 🟢 -549 B

Status: 10 added / 10 removed / 12 unchanged

User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-3wlH2HZ6.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.08 kB
assets/auth-CaGTZ2JS.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.08 kB
assets/SignUpForm-CJMSi06l.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.28 kB 🔴 +1.15 kB
assets/SignUpForm-fMxnr0rd.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.28 kB 🟢 -1.14 kB
assets/UpdatePasswordContent-BWE8gLLW.js (new) — 2.66 kB 🔴 +2.66 kB 🔴 +1.2 kB 🔴 +1.06 kB
assets/UpdatePasswordContent-CX3PpfMN.js (removed) 2.66 kB — 🟢 -2.66 kB 🟢 -1.19 kB 🟢 -1.06 kB
assets/authStore-Cw5cCzcX.js (removed) 989 B — 🟢 -989 B 🟢 -480 B 🟢 -430 B
assets/authStore-DfB0rVVJ.js (new) — 989 B 🔴 +989 B 🔴 +486 B 🔴 +425 B
assets/auth-DOIWe6L_.js (removed) 348 B — 🟢 -348 B 🟢 -217 B 🟢 -192 B
assets/auth-mHkSOay5.js (new) — 348 B 🔴 +348 B 🔴 +217 B 🔴 +187 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-3dsEd1sv.js (new) — 108 kB 🔴 +108 kB 🔴 +22.4 kB 🔴 +18.9 kB
assets/useShareDialog-BpYY16ww.js (removed) 108 kB — 🟢 -108 kB 🟢 -22.4 kB 🟢 -18.9 kB
assets/useSubscriptionDialog-CLBVzkIH.js (removed) 969 B — 🟢 -969 B 🟢 -474 B 🟢 -421 B
assets/useSubscriptionDialog-DZrgpCCr.js (new) — 969 B 🔴 +969 B 🔴 +478 B 🔴 +418 B

Status: 2 added / 2 removed

UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-DvnSN6b-.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/ComfyQueueButton-hAL-55Oh.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.37 kB
assets/useTerminalTabs-B46AgHVT.js (removed) 10.7 kB — 🟢 -10.7 kB 🟢 -3.6 kB 🟢 -3.17 kB
assets/useTerminalTabs-BwPFfkj9.js (new) — 10.7 kB 🔴 +10.7 kB 🔴 +3.6 kB 🔴 +3.17 kB
assets/SubscribeButton-BtwlDavx.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.04 kB 🟢 -914 B
assets/SubscribeButton-ByHhvRZh.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.04 kB 🔴 +913 B
assets/cloudFeedbackTopbarButton-DLVXQ03e.js (removed) 1.66 kB — 🟢 -1.66 kB 🟢 -843 B 🟢 -748 B
assets/cloudFeedbackTopbarButton-DvA9XHh-.js (new) — 1.66 kB 🔴 +1.66 kB 🔴 +848 B 🔴 +748 B
assets/ComfyQueueButton-B_CGM170.js (removed) 1.03 kB — 🟢 -1.03 kB 🟢 -487 B 🟢 -439 B
assets/ComfyQueueButton-BopufU_t.js (new) — 1.03 kB 🔴 +1.03 kB 🔴 +491 B 🔴 +440 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 2.96 MB (baseline 2.96 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-BExGshKK.js (new) — 1.92 MB 🔴 +1.92 MB 🔴 +443 kB 🔴 +336 kB
assets/dialogService-Bsiw0CnS.js (removed) 1.92 MB — 🟢 -1.92 MB 🟢 -443 kB 🟢 -336 kB
assets/api-BxuzO3qh.js (new) — 885 kB 🔴 +885 kB 🔴 +211 kB 🔴 +167 kB
assets/api-DHizwRx7.js (removed) 885 kB — 🟢 -885 kB 🟢 -211 kB 🟢 -167 kB
assets/load3dService-B-NayVNA.js (removed) 92.5 kB — 🟢 -92.5 kB 🟢 -19.7 kB 🟢 -16.9 kB
assets/load3dService-BkNyJYKX.js (new) — 92.5 kB 🔴 +92.5 kB 🔴 +19.7 kB 🔴 +16.9 kB
assets/workflowShareService-C-Rj0gXg.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.88 kB 🟢 -4.32 kB
assets/workflowShareService-DxGUMoEp.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.88 kB 🔴 +4.32 kB
assets/keybindingService-ByVQDC2F.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.21 kB
assets/keybindingService-CRl698yJ.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.21 kB
assets/releaseStore-BDm8QKHq.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/releaseStore-Dhn4F2w6.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/userStore-CCXe0JXR.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -870 B 🟢 -762 B
assets/userStore-VuxL_1VZ.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +870 B 🔴 +761 B
assets/audioService-BbHFhFvr.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -878 B 🟢 -758 B
assets/audioService-Cb8VXI6h.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +879 B 🔴 +759 B
assets/releaseStore-D-luZMNi.js (removed) 993 B — 🟢 -993 B 🟢 -479 B 🟢 -428 B
assets/releaseStore-Dn42D6sI.js (new) — 993 B 🔴 +993 B 🔴 +483 B 🔴 +428 B
assets/workflowDraftStore-BNMkBats.js (removed) 969 B — 🟢 -969 B 🟢 -473 B 🟢 -427 B
assets/workflowDraftStore-Ce6mbWyW.js (new) — 969 B 🔴 +969 B 🔴 +477 B 🔴 +425 B
assets/dialogService-B6VKZoWq.js (removed) 958 B — 🟢 -958 B 🟢 -465 B 🟢 -418 B
assets/dialogService-BhmZpngZ.js (new) — 958 B 🔴 +958 B 🔴 +470 B 🔴 +414 B
assets/settingStore-B_DDDuDB.js (removed) 956 B — 🟢 -956 B 🟢 -469 B 🟢 -414 B
assets/settingStore-DB8TLPiT.js (new) — 956 B 🔴 +956 B 🔴 +473 B 🔴 +412 B
assets/assetsStore-BlANC5UT.js (removed) 955 B — 🟢 -955 B 🟢 -469 B 🟢 -419 B
assets/assetsStore-CLSAZSQi.js (new) — 955 B 🔴 +955 B 🔴 +472 B 🔴 +416 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 334 kB (baseline 334 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-Ce5a6xIg.js (removed) 232 kB — 🟢 -232 kB 🟢 -51.3 kB 🟢 -41.7 kB
assets/useConflictDetection-CriBByLi.js (new) — 232 kB 🔴 +232 kB 🔴 +51.3 kB 🔴 +41.7 kB
assets/useLoad3dViewer-C8RmqyHn.js (new) — 18.7 kB 🔴 +18.7 kB 🔴 +4.44 kB 🔴 +3.9 kB
assets/useLoad3dViewer-gBp7TIJ3.js (removed) 18.7 kB — 🟢 -18.7 kB 🟢 -4.44 kB 🟢 -3.87 kB
assets/useLoad3d-BC2K4rFF.js (removed) 15 kB — 🟢 -15 kB 🟢 -3.79 kB 🟢 -3.36 kB
assets/useLoad3d-BybKcBbl.js (new) — 15 kB 🔴 +15 kB 🔴 +3.79 kB 🔴 +3.37 kB
assets/useFeatureFlags-DC9LEJ3P.js (new) — 5.78 kB 🔴 +5.78 kB 🔴 +1.75 kB 🔴 +1.49 kB
assets/useFeatureFlags-Gcoo09Bb.js (removed) 5.78 kB — 🟢 -5.78 kB 🟢 -1.75 kB 🟢 -1.49 kB
assets/useCopyToClipboard-CMecmJuA.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useCopyToClipboard-E8AiZlXY.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/useWorkspaceUI-DjhhSKQl.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -978 B 🟢 -809 B
assets/useWorkspaceUI-TulkSfJL.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +980 B 🔴 +811 B
assets/subscriptionCheckoutUtil-DoYxX5fJ.js (removed) 2.97 kB — 🟢 -2.97 kB 🟢 -1.31 kB 🟢 -1.14 kB
assets/subscriptionCheckoutUtil-Vz_2U8Bz.js (new) — 2.97 kB 🔴 +2.97 kB 🔴 +1.31 kB 🔴 +1.14 kB
assets/assetPreviewUtil-BjncqHrP.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -957 B 🟢 -833 B
assets/assetPreviewUtil-VdAuUaKy.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +958 B 🔴 +832 B
assets/useUpstreamValue-Cl87iuEu.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +804 B 🔴 +712 B
assets/useUpstreamValue-zTeM5Z0-.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -804 B 🟢 -711 B
assets/useLoad3d-BSgrSizK.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +542 B 🔴 +481 B
assets/useLoad3d-TrVZXtmr.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -537 B 🟢 -481 B
assets/useLoad3dViewer-BO8EAZUu.js (removed) 1.07 kB — 🟢 -1.07 kB 🟢 -504 B 🟢 -457 B
assets/useLoad3dViewer-Di1tgV48.js (new) — 1.07 kB 🔴 +1.07 kB 🔴 +509 B 🔴 +456 B
assets/useCurrentUser-Dmhl2_wG.js (new) — 955 B 🔴 +955 B 🔴 +473 B 🔴 +414 B
assets/useCurrentUser-hS4mCrnA.js (removed) 955 B — 🟢 -955 B 🟢 -469 B 🟢 -417 B
assets/useWorkspaceSwitch-B1lzZTo6.js (removed) 747 B — 🟢 -747 B 🟢 -385 B 🟢 -334 B
assets/useWorkspaceSwitch-DBy1OWGv.js (new) — 747 B 🔴 +747 B 🔴 +382 B 🔴 +332 B

Status: 13 added / 13 removed / 12 unchanged

Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.43 MB (baseline 8.43 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-C7jvPQxJ.js (new) — 76.8 kB 🔴 +76.8 kB 🔴 +19.9 kB 🔴 +16.9 kB
assets/core-CrFPXkGO.js (removed) 76.8 kB — 🟢 -76.8 kB 🟢 -19.9 kB 🟢 -16.9 kB
assets/groupNode-D91I-3R8.js (new) — 74 kB 🔴 +74 kB 🔴 +18.5 kB 🔴 +16.3 kB
assets/groupNode-Dg1zXrg8.js (removed) 74 kB — 🟢 -74 kB 🟢 -18.5 kB 🟢 -16.3 kB
assets/WidgetSelect-DfP28YzV.js (new) — 64.6 kB 🔴 +64.6 kB 🔴 +14.1 kB 🔴 +12.2 kB
assets/WidgetSelect-vzBRdXc5.js (removed) 64.6 kB — 🟢 -64.6 kB 🟢 -14.1 kB 🟢 -12.2 kB
assets/SubscriptionRequiredDialogContentWorkspace-DzOeTLTq.js (removed) 48.9 kB — 🟢 -48.9 kB 🟢 -9.29 kB 🟢 -7.96 kB
assets/SubscriptionRequiredDialogContentWorkspace-nBfiM2lu.js (new) — 48.9 kB 🔴 +48.9 kB 🔴 +9.29 kB 🔴 +7.96 kB
assets/WidgetPainter-BD0X6GWp.js (new) — 33.3 kB 🔴 +33.3 kB 🔴 +8.11 kB 🔴 +7.2 kB
assets/WidgetPainter-D-FdbP0n.js (removed) 33.3 kB — 🟢 -33.3 kB 🟢 -8.11 kB 🟢 -7.21 kB
assets/Load3DControls-CG4j5sZe.js (removed) 32.1 kB — 🟢 -32.1 kB 🟢 -5.47 kB 🟢 -4.77 kB
assets/Load3DControls-TNkI5kky.js (new) — 32.1 kB 🔴 +32.1 kB 🔴 +5.47 kB 🔴 +4.77 kB
assets/WorkspacePanelContent-8K0KHtEx.js (removed) 29.9 kB — 🟢 -29.9 kB 🟢 -6.33 kB 🟢 -5.55 kB
assets/WorkspacePanelContent-BCqCNDKq.js (new) — 29.9 kB 🔴 +29.9 kB 🔴 +6.33 kB 🔴 +5.54 kB
assets/SubscriptionRequiredDialogContent-DHvtPKj1.js (new) — 28.2 kB 🔴 +28.2 kB 🔴 +7.17 kB 🔴 +6.3 kB
assets/SubscriptionRequiredDialogContent-gijHuWh7.js (removed) 28.2 kB — 🟢 -28.2 kB 🟢 -7.16 kB 🟢 -6.31 kB
assets/Load3dViewerContent-DsxL3Vmd.js (new) — 24.3 kB 🔴 +24.3 kB 🔴 +5.32 kB 🔴 +4.63 kB
assets/Load3dViewerContent-QXbSjXoY.js (removed) 24.3 kB — 🟢 -24.3 kB 🟢 -5.32 kB 🟢 -4.63 kB
assets/WidgetImageCrop-160vKIJ6.js (new) — 23.3 kB 🔴 +23.3 kB 🔴 +5.83 kB 🔴 +5.14 kB
assets/WidgetImageCrop-DQiotdX1.js (removed) 23.3 kB — 🟢 -23.3 kB 🟢 -5.82 kB 🟢 -5.13 kB
assets/SubscriptionPanelContentWorkspace-BJa3vNgA.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.56 kB
assets/SubscriptionPanelContentWorkspace-ggLbL4rA.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.56 kB
assets/SignInContent-Bg9HCmHq.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.29 kB 🟢 -4.62 kB
assets/SignInContent-uoarpMcN.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.29 kB 🔴 +4.62 kB
assets/CurrentUserPopoverWorkspace-BG5-kMFZ.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +4.84 kB 🔴 +4.34 kB
assets/CurrentUserPopoverWorkspace-CTig1KVy.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -4.83 kB 🟢 -4.33 kB
assets/WidgetInputNumber-DqjEMfnJ.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.3 kB
assets/WidgetInputNumber-DXYRskWk.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.29 kB
assets/WidgetRecordAudio-CsMkT-NM.js (new) — 18.1 kB 🔴 +18.1 kB 🔴 +5.18 kB 🔴 +4.64 kB
assets/WidgetRecordAudio-CsWwSBKi.js (removed) 18.1 kB — 🟢 -18.1 kB 🟢 -5.18 kB 🟢 -4.64 kB
assets/Load3D-Alz1DwPs.js (removed) 16.9 kB — 🟢 -16.9 kB 🟢 -4.11 kB 🟢 -3.59 kB
assets/Load3D-jcCAUVK-.js (new) — 16.9 kB 🔴 +16.9 kB 🔴 +4.12 kB 🔴 +3.59 kB
assets/WidgetCurve-BYJTr6ZS.js (new) — 16.1 kB 🔴 +16.1 kB 🔴 +4.97 kB 🔴 +4.45 kB
assets/WidgetCurve-DIDaZnI3.js (removed) 16.1 kB — 🟢 -16.1 kB 🟢 -4.97 kB 🟢 -4.46 kB
assets/load3d-C1f2H_Ou.js (new) — 15 kB 🔴 +15 kB 🔴 +4.32 kB 🔴 +3.74 kB
assets/load3d-UfpxfGnq.js (removed) 15 kB — 🟢 -15 kB 🟢 -4.32 kB 🟢 -3.74 kB
assets/WaveAudioPlayer-Bbiy0435.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.68 kB 🔴 +3.23 kB
assets/WaveAudioPlayer-CyofyPjd.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.68 kB 🟢 -3.23 kB
assets/TeamWorkspacesDialogContent-BeXdxvIb.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -3.33 kB 🟢 -2.97 kB
assets/TeamWorkspacesDialogContent-CSiYCdOj.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +3.34 kB 🔴 +2.96 kB
assets/nodeTemplates-BuOv5-qK.js (new) — 9.58 kB 🔴 +9.58 kB 🔴 +3.38 kB 🔴 +2.97 kB
assets/nodeTemplates-C7HPPPXp.js (removed) 9.58 kB — 🟢 -9.58 kB 🟢 -3.37 kB 🟢 -2.96 kB
assets/InviteMemberDialogContent-BP2zfggV.js (new) — 7.77 kB 🔴 +7.77 kB 🔴 +2.45 kB 🔴 +2.13 kB
assets/InviteMemberDialogContent-ClIAUbj8.js (removed) 7.77 kB — 🟢 -7.77 kB 🟢 -2.45 kB 🟢 -2.15 kB
assets/Load3DConfiguration-CafOQqe3.js (new) — 6.6 kB 🔴 +6.6 kB 🔴 +2.04 kB 🔴 +1.77 kB
assets/Load3DConfiguration-QH7qrntC.js (removed) 6.6 kB — 🟢 -6.6 kB 🟢 -2.04 kB 🟢 -1.77 kB
assets/onboardingCloudRoutes-Bh0tjyI3.js (removed) 6.53 kB — 🟢 -6.53 kB 🟢 -2.04 kB 🟢 -1.75 kB
assets/onboardingCloudRoutes-qRhWEUTQ.js (new) — 6.53 kB 🔴 +6.53 kB 🔴 +2.04 kB 🔴 +1.77 kB
assets/WidgetWithControl-BBaUBhDb.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.38 kB 🔴 +2.12 kB
assets/WidgetWithControl-Dy8cuZ5y.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.38 kB 🟢 -2.13 kB
assets/CreateWorkspaceDialogContent-CEcPWcTn.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.15 kB 🟢 -1.88 kB
assets/CreateWorkspaceDialogContent-CKpiy3_9.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.15 kB 🔴 +1.88 kB
assets/FreeTierDialogContent-CbIpzG2M.js (removed) 5.82 kB — 🟢 -5.82 kB 🟢 -2.04 kB 🟢 -1.82 kB
assets/FreeTierDialogContent-D5bJALeD.js (new) — 5.82 kB 🔴 +5.82 kB 🔴 +2.05 kB 🔴 +1.81 kB
assets/EditWorkspaceDialogContent-CHUxqgxB.js (new) — 5.75 kB 🔴 +5.75 kB 🔴 +2.11 kB 🔴 +1.84 kB
assets/EditWorkspaceDialogContent-Djk9bUdS.js (removed) 5.75 kB — 🟢 -5.75 kB 🟢 -2.11 kB 🟢 -1.84 kB
assets/WidgetTextarea-4-skLBmm.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.17 kB 🔴 +1.92 kB
assets/WidgetTextarea-C_V-N22A.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.17 kB 🟢 -1.92 kB
assets/Preview3d-BURHpc1c.js (new) — 5.36 kB 🔴 +5.36 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/Preview3d-DqVw8uLF.js (removed) 5.36 kB — 🟢 -5.36 kB 🟢 -1.79 kB 🟢 -1.56 kB
assets/ValueControlPopover-BYVRnZAn.js (removed) 5.33 kB — 🟢 -5.33 kB 🟢 -1.93 kB 🟢 -1.72 kB
assets/ValueControlPopover-DagN_CRn.js (new) — 5.33 kB 🔴 +5.33 kB 🔴 +1.93 kB 🔴 +1.72 kB
assets/CancelSubscriptionDialogContent-9f3KtfHD.js (new) — 5.22 kB 🔴 +5.22 kB 🔴 +1.95 kB 🔴 +1.7 kB
assets/CancelSubscriptionDialogContent-COD7mwJi.js (removed) 5.22 kB — 🟢 -5.22 kB 🟢 -1.95 kB 🟢 -1.7 kB
assets/DeleteWorkspaceDialogContent-CpsqQy_t.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/DeleteWorkspaceDialogContent-DA8FTv3N.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/LeaveWorkspaceDialogContent-BI-Q2bHu.js (new) — 4.48 kB 🔴 +4.48 kB 🔴 +1.74 kB 🔴 +1.51 kB
assets/LeaveWorkspaceDialogContent-D9ysyNYZ.js (removed) 4.48 kB — 🟢 -4.48 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/RemoveMemberDialogContent-CYAXPBjV.js (new) — 4.46 kB 🔴 +4.46 kB 🔴 +1.69 kB 🔴 +1.47 kB
assets/RemoveMemberDialogContent-DwxYni0-.js (removed) 4.46 kB — 🟢 -4.46 kB 🟢 -1.69 kB 🟢 -1.48 kB
assets/tierBenefits-CyuNXcr_.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/tierBenefits-DeNeUq5b.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/RevokeInviteDialogContent-CMyyIAHT.js (removed) 4.37 kB — 🟢 -4.37 kB 🟢 -1.7 kB 🟢 -1.48 kB
assets/RevokeInviteDialogContent-CxaseITV.js (new) — 4.37 kB 🔴 +4.37 kB 🔴 +1.7 kB 🔴 +1.49 kB
assets/InviteMemberUpsellDialogContent-C0vzearU.js (removed) 4.27 kB — 🟢 -4.27 kB 🟢 -1.56 kB 🟢 -1.36 kB
assets/InviteMemberUpsellDialogContent-CsUa4J-n.js (new) — 4.27 kB 🔴 +4.27 kB 🔴 +1.56 kB 🔴 +1.37 kB
assets/cloudSessionCookie-BwhPbJdN.js (removed) 4.12 kB — 🟢 -4.12 kB 🟢 -1.49 kB 🟢 -1.3 kB
assets/cloudSessionCookie-DGgi9AgM.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +1.49 kB 🔴 +1.29 kB
assets/saveMesh-BEeRd4ah.js (removed) 3.92 kB — 🟢 -3.92 kB 🟢 -1.68 kB 🟢 -1.48 kB
assets/saveMesh-CrFR_Z92.js (new) — 3.92 kB 🔴 +3.92 kB 🔴 +1.69 kB 🔴 +1.48 kB
assets/Media3DTop-BeG8iy6L.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.63 kB 🔴 +1.44 kB
assets/Media3DTop-Cs0KRpW7.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.62 kB 🟢 -1.44 kB
assets/GlobalToast-C7xBNRIs.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/GlobalToast-DSNr9b9h.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.25 kB 🟢 -1.07 kB
assets/SubscribeToRun-C333FvqC.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +984 B 🔴 +877 B
assets/SubscribeToRun-KVhMjrSA.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -982 B 🟢 -877 B
assets/MediaAudioTop-BPa5oyPB.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +981 B 🔴 +834 B
assets/MediaAudioTop-CfuLebBc.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -981 B 🟢 -835 B
assets/CloudRunButtonWrapper-BCqSHdxo.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +915 B 🔴 +809 B
assets/CloudRunButtonWrapper-RT_qE65d.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -911 B 🟢 -811 B
assets/graphHasMissingNodes-BGrAmmiC.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +860 B 🔴 +751 B
assets/graphHasMissingNodes-BUxf833k.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -861 B 🟢 -752 B
assets/cloudBadges-BlsU5El7.js (new) — 1.77 kB 🔴 +1.77 kB 🔴 +894 B 🔴 +774 B
assets/cloudBadges-Cn8Du1dA.js (removed) 1.77 kB — 🟢 -1.77 kB 🟢 -891 B 🟢 -774 B
assets/cloudSubscription-CBLByp-z.js (removed) 1.68 kB — 🟢 -1.68 kB 🟢 -813 B 🟢 -712 B
assets/cloudSubscription-CKGPkaiT.js (new) — 1.68 kB 🔴 +1.68 kB 🔴 +817 B 🔴 +713 B
assets/previousFullPath-C-U5kzUk.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -693 B 🟢 -600 B
assets/previousFullPath-CP_M0iIg.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +695 B 🔴 +601 B
assets/Load3D-ycFCDJio.js (new) — 1.34 kB 🔴 +1.34 kB 🔴 +619 B 🔴 +555 B
assets/Load3D-Z8dNe3xR.js (removed) 1.34 kB — 🟢 -1.34 kB 🟢 -613 B 🟢 -546 B
assets/nightlyBadges-CFpc6fsl.js (removed) 1.29 kB — 🟢 -1.29 kB 🟢 -655 B 🟢 -589 B
assets/nightlyBadges-d5YvrppY.js (new) — 1.29 kB 🔴 +1.29 kB 🔴 +660 B 🔴 +582 B
assets/Load3dViewerContent-DYm9jD78.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -565 B 🟢 -501 B
assets/Load3dViewerContent-OOZpf7-F.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +571 B 🔴 +496 B
assets/SubscriptionPanelContentWorkspace-B3l49XF8.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +537 B 🔴 +468 B
assets/SubscriptionPanelContentWorkspace-CXWtiswK.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -533 B 🟢 -469 B
assets/WidgetLegacy-A1AfuvCh.js (removed) 978 B — 🟢 -978 B 🟢 -480 B 🟢 -426 B
assets/WidgetLegacy-khPQS-i1.js (new) — 978 B 🔴 +978 B 🔴 +484 B 🔴 +424 B
assets/changeTracker-42N9wWfJ.js (new) — 952 B 🔴 +952 B 🔴 +473 B 🔴 +412 B
assets/changeTracker-ssOFptLM.js (removed) 952 B — 🟢 -952 B 🟢 -469 B 🟢 -415 B

Status: 55 added / 55 removed / 79 unchanged

⚡ Performance

⏳ Performance tests in progress…

@DrJKL
DrJKL marked this pull request as ready for review March 27, 2026 22:09
@DrJKL
DrJKL requested a review from a team March 27, 2026 22:09
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 27, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
browser_tests/helpers/subgraphTestUtils.ts (1)

92-109: Make console warning collection self-disposing to prevent accidental listener retention.

collectConsoleWarnings is correct, but the current API is easy to misuse because callers can forget dispose(). A scoped wrapper would make cleanup automatic and avoid lingering listeners.

♻️ Suggested scoped wrapper
 export function collectConsoleWarnings(
   page: Page,
   patterns: string[] = [
     'No link found',
     'Failed to resolve legacy -1',
     'No inner link found'
   ]
 ): { warnings: string[]; dispose: () => void } {
   const warnings: string[] = []
   const handler = (msg: ConsoleMessage) => {
     const text = msg.text()
     if (patterns.some((p) => text.includes(p))) {
       warnings.push(text)
     }
   }
   page.on('console', handler)
   return { warnings, dispose: () => page.off('console', handler) }
 }
+
+export async function withConsoleWarnings<T>(
+  page: Page,
+  run: () => Promise<T>,
+  patterns?: string[]
+): Promise<{ result: T; warnings: string[] }> {
+  const { warnings, dispose } = collectConsoleWarnings(page, patterns)
+  try {
+    const result = await run()
+    return { result, warnings }
+  } finally {
+    dispose()
+  }
+}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/helpers/subgraphTestUtils.ts` around lines 92 - 109, The
current collectConsoleWarnings attaches a listener and returns a dispose() that
callers may forget to call; add a scoped wrapper (e.g., withConsoleWarnings)
that takes the same parameters plus an async callback (fn: () => Promise<T>) and
internally installs the same handler (use the existing handler logic from
collectConsoleWarnings), runs await fn() inside a try/finally, and always calls
page.off('console', handler) in the finally before returning { result: await
fnReturn, warnings }. Alternatively overload collectConsoleWarnings to accept a
callback and ensure removal in finally; reference the existing symbols
collectConsoleWarnings, handler and dispose when making the change so the
listener registration and cleanup logic is identical.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/helpers/subgraphTestUtils.ts`:
- Around line 92-109: The current collectConsoleWarnings attaches a listener and
returns a dispose() that callers may forget to call; add a scoped wrapper (e.g.,
withConsoleWarnings) that takes the same parameters plus an async callback (fn:
() => Promise<T>) and internally installs the same handler (use the existing
handler logic from collectConsoleWarnings), runs await fn() inside a
try/finally, and always calls page.off('console', handler) in the finally before
returning { result: await fnReturn, warnings }. Alternatively overload
collectConsoleWarnings to accept a callback and ensure removal in finally;
reference the existing symbols collectConsoleWarnings, handler and dispose when
making the change so the listener registration and cleanup logic is identical.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c7c8be37-5944-483c-9c7e-2c141225744a

📥 Commits

Reviewing files that changed from the base of the PR and between e558868 and a4ce1a8.

📒 Files selected for processing (15)
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/fixtures/utils/litegraphUtils.ts
  • browser_tests/helpers/subgraphTestUtils.ts
  • browser_tests/tests/subgraph-duplicate-ids.spec.ts
  • browser_tests/tests/subgraph-promoted-widget-dom.spec.ts
  • browser_tests/tests/subgraph-rename-dialog.spec.ts
  • browser_tests/tests/subgraph.spec.ts
  • browser_tests/tests/subgraphInputSlotRename.spec.ts
  • browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts
  • browser_tests/tests/subgraphLifecycle.spec.ts
  • browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
  • browser_tests/tests/subgraphNestedPackValues.spec.ts
  • browser_tests/tests/subgraphProgressClear.spec.ts
  • browser_tests/tests/subgraphPromotion.spec.ts
  • browser_tests/tests/subgraphSearchAliases.spec.ts
✅ Files skipped from review due to trivial changes (1)
  • browser_tests/tests/subgraphProgressClear.spec.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • browser_tests/fixtures/utils/litegraphUtils.ts
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/tests/subgraph-duplicate-ids.spec.ts

coderabbitai[bot]
coderabbitai Bot previously approved these changes Mar 27, 2026
Move all standalone functions from helpers/subgraphTestUtils.ts into
SubgraphHelper as instance methods (serializeAndReload,
convertDefaultKSamplerToSubgraph, packAllInteriorNodes) and static
methods (getTextSlotPosition, expectWidgetBelowHeader,
collectConsoleWarnings). Update 9 spec files and delete the old module.

Amp-Thread-ID: https://ampcode.com/threads/T-019d3158-4e9c-76c8-84ae-dffccccbd0ca
Co-authored-by: Amp <amp@ampcode.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
browser_tests/fixtures/helpers/SubgraphHelper.ts (2)

483-498: Don't let packAllInteriorNodes() silently change Vue mode on return.

This helper enters through vueNodes.enterSubgraph() but returns with Comfy.VueNodes.Enabled forced to false. That hidden state mutation makes the API easy to misuse from future specs. Restoring the original setting in a finally would make the helper much safer to compose.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/fixtures/helpers/SubgraphHelper.ts` around lines 483 - 498,
packAllInteriorNodes currently disables the Comfy.VueNodes.Enabled setting
before performing actions and never restores it; update packAllInteriorNodes so
it reads and stores the current value of the 'Comfy.VueNodes.Enabled' setting
before changing it, perform the work (enterSubgraph, convertToSubgraph,
exitViaBreadcrumb) and then restore the original setting in a finally block to
guarantee the setting is returned to its prior state even on errors; reference
the methods comfyPage.vueNodes.enterSubgraph, comfyPage.settings.setSetting and
the setting key 'Comfy.VueNodes.Enabled' when making this change.

474-480: Avoid hardcoding the default workflow's node ID in this shared helper.

Baking 'default' and node id '3' into a fixture API makes every caller depend on one exact workflow snapshot. If that workflow changes, all dependent specs break together. Prefer a generic helper that takes the workflow and node id as parameters, or resolves the KSampler by a stable characteristic inside the helper.

♻️ Possible shape
-  async convertDefaultKSamplerToSubgraph(): Promise<NodeReference> {
-    await this.comfyPage.workflow.loadWorkflow('default')
-    const ksampler = await this.comfyPage.nodeOps.getNodeRefById('3')
-    await ksampler.click('title')
-    const subgraphNode = await ksampler.convertToSubgraph()
+  async convertNodeToSubgraph(
+    workflow: string,
+    nodeId: string
+  ): Promise<NodeReference> {
+    await this.comfyPage.workflow.loadWorkflow(workflow)
+    const node = await this.comfyPage.nodeOps.getNodeRefById(nodeId)
+    await node.click('title')
+    const subgraphNode = await node.convertToSubgraph()
     await this.comfyPage.nextFrame()
     return subgraphNode
   }

Based on learnings, the default workflow composition can change, making fixed assumptions brittle.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/fixtures/helpers/SubgraphHelper.ts` around lines 474 - 480, The
helper convertDefaultKSamplerToSubgraph hardcodes the workflow name 'default'
and node id '3', which is brittle; modify convertDefaultKSamplerToSubgraph to
accept parameters (e.g., workflowName: string, nodeId?: string) or to resolve
the target node by a stable characteristic (e.g., node type/name/title) using
comfyPage.nodeOps APIs instead of getNodeRefById('3'), then call
this.comfyPage.workflow.loadWorkflow(workflowName) and locate the KSampler node
(by id if provided or by stable selector) before clicking title and calling
convertToSubgraph to return subgraphNode.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@browser_tests/tests/subgraphNestedConfigureOrder.spec.ts`:
- Line 12: The call to SubgraphHelper.collectConsoleWarnings(comfyPage.page)
relies on a helper default that also matches "No inner link found", causing
extra warnings to be captured; update the call to pass the two specific expected
warning strings explicitly (e.g.
SubgraphHelper.collectConsoleWarnings(comfyPage.page, ["<expected warning A>",
"<expected warning B>")) so only the two intended patterns are extracted and the
test remains equivalent — make this change where the call occurs in
subgraphNestedConfigureOrder.spec.ts and ensure the strings match the original
assertion/test name.

---

Nitpick comments:
In `@browser_tests/fixtures/helpers/SubgraphHelper.ts`:
- Around line 483-498: packAllInteriorNodes currently disables the
Comfy.VueNodes.Enabled setting before performing actions and never restores it;
update packAllInteriorNodes so it reads and stores the current value of the
'Comfy.VueNodes.Enabled' setting before changing it, perform the work
(enterSubgraph, convertToSubgraph, exitViaBreadcrumb) and then restore the
original setting in a finally block to guarantee the setting is returned to its
prior state even on errors; reference the methods
comfyPage.vueNodes.enterSubgraph, comfyPage.settings.setSetting and the setting
key 'Comfy.VueNodes.Enabled' when making this change.
- Around line 474-480: The helper convertDefaultKSamplerToSubgraph hardcodes the
workflow name 'default' and node id '3', which is brittle; modify
convertDefaultKSamplerToSubgraph to accept parameters (e.g., workflowName:
string, nodeId?: string) or to resolve the target node by a stable
characteristic (e.g., node type/name/title) using comfyPage.nodeOps APIs instead
of getNodeRefById('3'), then call
this.comfyPage.workflow.loadWorkflow(workflowName) and locate the KSampler node
(by id if provided or by stable selector) before clicking title and calling
convertToSubgraph to return subgraphNode.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 193341f4-1af2-40d0-99eb-558bdbeabed9

📥 Commits

Reviewing files that changed from the base of the PR and between a4ce1a8 and 52af5f2.

📒 Files selected for processing (11)
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/helpers/subgraphTestUtils.ts
  • browser_tests/tests/subgraph-promoted-slot-position.spec.ts
  • browser_tests/tests/subgraph-promoted-widget-dom.spec.ts
  • browser_tests/tests/subgraphInputSlotRename.spec.ts
  • browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts
  • browser_tests/tests/subgraphLifecycle.spec.ts
  • browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
  • browser_tests/tests/subgraphNestedPackValues.spec.ts
  • browser_tests/tests/subgraphPromotion.spec.ts
  • browser_tests/tests/subgraphSearchAliases.spec.ts
💤 Files with no reviewable changes (1)
  • browser_tests/helpers/subgraphTestUtils.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • browser_tests/tests/subgraphSearchAliases.spec.ts
  • browser_tests/tests/subgraphLifecycle.spec.ts

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of nits. Obviously these comments are moreso about the existing functionality since this is just a refactoring, so they are not blocking.

Overall +244/-414 is nice to see and the PR LGTM!

Comment on lines +418 to +439
async getSlotCount(type: 'input' | 'output'): Promise<number> {
return this.page.evaluate((slotType: 'input' | 'output') => {
const graph = window.app!.canvas.graph
if (!graph || !('inputNode' in graph)) return 0
return graph[`${slotType}s`]?.length ?? 0
}, type)
}

async getSlotLabel(
type: 'input' | 'output',
index = 0
): Promise<string | null> {
return this.page.evaluate(
([slotType, idx]) => {
const graph = window.app!.canvas.graph
if (!graph || !('inputNode' in graph)) return null
const slot = graph[`${slotType}s`]?.[idx]
return slot?.label ?? slot?.name ?? null
},
[type, index] as const
)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the need for litegraph-based helpers like this is just unavoidable here I am assuming?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, yes.

await this.comfyPage.nextFrame()
}

async findSubgraphNodeId(): Promise<string> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's more like findFirstNodeInCurrentGraphThatIsASubgraphNode (and throw error if none found unlike standard find functions) (and it won't be deterministic).

Comment on lines +463 to +472
async serializeAndReload(): Promise<void> {
const serialized = await this.page.evaluate(() =>
window.app!.graph!.serialize()
)
await this.page.evaluate(
(workflow: ComfyWorkflowJSON) => window.app!.loadGraphData(workflow),
serialized as ComfyWorkflowJSON
)
await this.comfyPage.nextFrame()
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this fucntion seems like it wants to be somewhere higher up

Comment on lines +474 to +475
async convertDefaultKSamplerToSubgraph(): Promise<NodeReference> {
await this.comfyPage.workflow.loadWorkflow('default')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wouldn't expect that this function loads a workflow based on the name


async convertDefaultKSamplerToSubgraph(): Promise<NodeReference> {
await this.comfyPage.workflow.loadWorkflow('default')
const ksampler = await this.comfyPage.nodeOps.getNodeRefById('3')

@christian-byrne christian-byrne Mar 28, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about maintaining some mapping in code between ids->nodename for the common workflows? Although that's basically what the jsons already are... just thinking that as this pattern becomes more common we lose a bit of expressiveness that might be aided by a constant object / enum (but not actually a ts enum but you get what I mean).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that adding structure to the fixtures is going to be great for readability, especially if we can also get intellisense and type checking for names/ids.

Comment on lines +478 to +479
const subgraphNode = await ksampler.convertToSubgraph()
await this.comfyPage.nextFrame()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ksampler.convertToSubgraph not calling nextFrame itself?

Comment on lines +485 to +493
await this.comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', false)
await this.comfyPage.nextFrame()
await this.comfyPage.canvas.click()
await this.comfyPage.canvas.press('Control+a')
await this.comfyPage.nextFrame()
await this.page.evaluate(() => {
const canvas = window.app!.canvas
canvas.graph!.convertToSubgraph(canvas.selectedItems)
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we cannot just:

  1. Control+a
  2. Click a node
  3. Find selection toolbox
  4. Convert to subgraph icon -> click

(while staying in vue mode)

What's currently making this difficult/flaky? Finding a node to click in the viewport?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a child branch where I'm working on updating the Helper logic to do things like this.

await this.comfyPage.nextFrame()
}

static getTextSlotPosition(page: Page, nodeId: string) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I know this is a pre-existing method in the subgraph helpers, but this feels like it wants to be in another helper or the node reference class.

expect(widgetBox.y).toBeGreaterThan(headerBox.y + headerBox.height)
}

static collectConsoleWarnings(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honest question: is this actually considered good practice? Genuinely don't know the arguments for/against using this pattern in e2e tests.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a step back, having information that's only in the console isn't great for users. If it's a real problem that they can fix, it should be presented to them. If it's not a real problem, why log it in the first place?
For cases like this, it can be very useful within test and dev contexts to have extra information about known past issues that you can confirm are behaving in the way you expect even when it is opaque to a user.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve

@DrJKL
DrJKL enabled auto-merge (squash) March 28, 2026 21:09

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
browser_tests/tests/subgraphNestedConfigureOrder.spec.ts (1)

12-19: ⚠️ Potential issue | 🟡 Minor

Dispose the console listener to avoid test pollution.

collectConsoleWarnings returns a dispose teardown; not calling it leaves the console listener attached longer than needed and can leak warnings into later steps/tests.

♻️ Suggested fix
-    const { warnings } = SubgraphHelper.collectConsoleWarnings(comfyPage.page, [
-      'No link found',
-      'Failed to resolve legacy -1'
-    ])
-
-    await comfyPage.workflow.loadWorkflow(WORKFLOW)
-
-    expect(warnings).toEqual([])
+    const { warnings, dispose } = SubgraphHelper.collectConsoleWarnings(
+      comfyPage.page,
+      ['No link found', 'Failed to resolve legacy -1']
+    )
+    try {
+      await comfyPage.workflow.loadWorkflow(WORKFLOW)
+      expect(warnings).toEqual([])
+    } finally {
+      dispose()
+    }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/subgraphNestedConfigureOrder.spec.ts` around lines 12 -
19, collectConsoleWarnings attaches a console listener and returns a teardown
function; you should capture and call that dispose to avoid leaking listeners.
Update the test around SubgraphHelper.collectConsoleWarnings(comfyPage.page,
[...]) to store the returned dispose (e.g., const { warnings, dispose } =
SubgraphHelper.collectConsoleWarnings(...)) and invoke dispose() after the
assertion (after expect(warnings).toEqual([])) so the listener is removed and
does not pollute later tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@browser_tests/tests/subgraphNestedConfigureOrder.spec.ts`:
- Around line 12-19: collectConsoleWarnings attaches a console listener and
returns a teardown function; you should capture and call that dispose to avoid
leaking listeners. Update the test around
SubgraphHelper.collectConsoleWarnings(comfyPage.page, [...]) to store the
returned dispose (e.g., const { warnings, dispose } =
SubgraphHelper.collectConsoleWarnings(...)) and invoke dispose() after the
assertion (after expect(warnings).toEqual([])) so the listener is removed and
does not pollute later tests.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f36d8822-7650-4571-b50e-b568efe39737

📥 Commits

Reviewing files that changed from the base of the PR and between 52af5f2 and 04b121f.

📒 Files selected for processing (2)
  • browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
  • browser_tests/tests/subgraphPromotion.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • browser_tests/tests/subgraphPromotion.spec.ts

@DrJKL
DrJKL merged commit d2358c8 into main Mar 28, 2026
32 checks passed
@DrJKL
DrJKL deleted the drjkl/test/subgraphs-1 branch March 28, 2026 21:12
DrJKL added a commit that referenced this pull request Mar 28, 2026
- Rename convertDefaultKSamplerToSubgraph to loadDefaultAndConvertKSamplerToSubgraph
- Remove redundant nextFrame() after convertToSubgraph (already called internally)
- Add dispose() calls after collectConsoleWarnings assertions
- Add explicit null guards on getSlotLabel() before non-null assertions

Amp-Thread-ID: https://ampcode.com/threads/T-019d3651-bd02-760c-9542-a2fbe03e051a
Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit that referenced this pull request Mar 28, 2026
## Summary

Extract repeated patterns from 12 subgraph Playwright spec files into
shared test utilities, reducing duplication by ~142 lines.

## Changes

- **What**: New shared helpers for common subgraph test operations:
- `SubgraphHelper`: `getSlotCount()`, `getSlotLabel()`, `removeSlot()`,
`findSubgraphNodeId()`
  - `NodeReference`: `delete()`
- `subgraphTestUtils`: `serializeAndReload()`,
`convertDefaultKSamplerToSubgraph()`, `expectWidgetBelowHeader()`,
`collectConsoleWarnings()`, `packAllInteriorNodes()`
- Replaced ~72 inline `page.evaluate` blocks and multi-line sequences
with single helper calls across 12 spec files

## Review Focus

- Behavioral equivalence: every replacement is a mechanical extraction
with no test logic changes
- API surface of new helpers: naming, parameter types, placement in
existing utility classes
- Whether any remaining inline patterns in the spec files would benefit
from further extraction

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10629-test-extract-shared-subgraph-E2E-test-utilities-3306d73d365081b0b6b5db52ed0a4552)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
jaeone94 pushed a commit that referenced this pull request Mar 31, 2026
## Summary

Extract repeated patterns from 12 subgraph Playwright spec files into
shared test utilities, reducing duplication by ~142 lines.

## Changes

- **What**: New shared helpers for common subgraph test operations:
- `SubgraphHelper`: `getSlotCount()`, `getSlotLabel()`, `removeSlot()`,
`findSubgraphNodeId()`
  - `NodeReference`: `delete()`
- `subgraphTestUtils`: `serializeAndReload()`,
`convertDefaultKSamplerToSubgraph()`, `expectWidgetBelowHeader()`,
`collectConsoleWarnings()`, `packAllInteriorNodes()`
- Replaced ~72 inline `page.evaluate` blocks and multi-line sequences
with single helper calls across 12 spec files

## Review Focus

- Behavioral equivalence: every replacement is a mechanical extraction
with no test logic changes
- API surface of new helpers: naming, parameter types, placement in
existing utility classes
- Whether any remaining inline patterns in the spec files would benefit
from further extraction

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10629-test-extract-shared-subgraph-E2E-test-utilities-3306d73d365081b0b6b5db52ed0a4552)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
## Summary

Extract repeated patterns from 12 subgraph Playwright spec files into
shared test utilities, reducing duplication by ~142 lines.

## Changes

- **What**: New shared helpers for common subgraph test operations:
- `SubgraphHelper`: `getSlotCount()`, `getSlotLabel()`, `removeSlot()`,
`findSubgraphNodeId()`
  - `NodeReference`: `delete()`
- `subgraphTestUtils`: `serializeAndReload()`,
`convertDefaultKSamplerToSubgraph()`, `expectWidgetBelowHeader()`,
`collectConsoleWarnings()`, `packAllInteriorNodes()`
- Replaced ~72 inline `page.evaluate` blocks and multi-line sequences
with single helper calls across 12 spec files

## Review Focus

- Behavioral equivalence: every replacement is a mechanical extraction
with no test logic changes
- API surface of new helpers: naming, parameter types, placement in
existing utility classes
- Whether any remaining inline patterns in the spec files would benefit
from further extraction

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10629-test-extract-shared-subgraph-E2E-test-utilities-3306d73d365081b0b6b5db52ed0a4552)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants