Repository navigation
test: migrate browser_tests/ to @e2e/ path alias and add lint rule - #10958
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR updates import/module resolution across the browser_tests suite and fixtures, replacing many relative paths with alias paths ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts (1)
193-199: Preferexpect.poll()overtoPass()for single async assertion.This block is a single async call with one assertion, matching the repo-preferred pattern per coding guidelines.
♻️ Suggested refactor
- await expect(async () => { - const promotedNames = await getPromotedWidgetNames( - comfyPage, - subgraphNodeId - ) - expect(promotedNames).toContain('seed') - }).toPass({ timeout: 5000 }) + await expect + .poll( + () => getPromotedWidgetNames(comfyPage, subgraphNodeId), + { timeout: 5000 } + ) + .toContain('seed')🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts` around lines 193 - 199, Replace the toPass() usage with expect.poll() for the single async assertion: call expect.poll with an async callback that invokes getPromotedWidgetNames(comfyPage, subgraphNodeId) and returns whether the returned array includes 'seed', then assert .toBe(true) (or .toEqual(true)) and pass the same timeout: 5000; this keeps the polling pattern consistent and targets the single assertion on getPromotedWidgetNames.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/helpers/builderTestUtils.ts`:
- Around line 65-66: After calling ksampler.convertToSubgraph() and awaiting one
frame, add a deterministic post-conversion poll that waits for the
subgraph/hydration to be ready before returning; specifically, replace the
single comfyPage.nextFrame() wait with a short polling loop (with a sensible
timeout) that repeatedly checks for the promoted-widget hydration or the builder
selection readiness (e.g., a DOM selector or a ksampler readiness flag if
available) and only proceeds when that condition is true, otherwise fail the
test after the timeout. Ensure you reference ksampler.convertToSubgraph() and
comfyPage (or the appropriate DOM selector) in the check and keep the timeout to
avoid hanging tests.
In `@browser_tests/tests/bottomPanelLogs.spec.ts`:
- Line 4: ESLint import resolution is failing because apps/website/tsconfig.json
extends the missing "astro/tsconfigs/strict", which breaks resolving the
'@e2e/fixtures/ComfyPage' import in bottomPanelLogs.spec.ts; fix by either
removing the extends line from apps/website/tsconfig.json if that tsconfig was
added accidentally, or by installing and adding the missing package
(`@astrojs/tsconfigs`) to dependencies and re-running install so
"astro/tsconfigs/strict" is available to the TypeScript/ESLint resolver.
In `@browser_tests/tests/subgraph/subgraphSearch.spec.ts`:
- Around line 3-4: Update the import resolver configuration in eslint.config.ts
so the TypeScript import resolver (createTypeScriptImportResolver used in the
'import-x/resolver-next' entry) includes './browser_tests/tsconfig.json' in its
project array; locate the createTypeScriptImportResolver(...) call and add
'./browser_tests/tsconfig.json' alongside './tsconfig.json',
'./apps/*/tsconfig.json', and './packages/*/tsconfig.json' (keeping
noWarnOnMultipleProjects: true).
In `@browser_tests/tests/useSettingSearch.spec.ts`:
- Line 4: The ESLint resolver is missing the browser_tests tsconfig so imports
like `@e2e/`* trigger import-x/no-unresolved; open eslint.config.ts, find the
resolver configuration where the "project" array is defined (the entry that
currently lists other tsconfig paths), and add './browser_tests/tsconfig.json'
to that array so the resolver can resolve the `@e2e` aliases and eliminate the
unresolved import errors.
In `@browser_tests/tests/workflowPersistence.spec.ts`:
- Around line 5-6: The import-x/no-unresolved ESLint failures are caused by the
ESLint resolver's projects list including a tsconfig that extends an
unresolvable astro config, breaking import resolution; open the ESLint resolver
configuration (the resolver "projects" / project list entry) and either
remove/exclude the apps/website/tsconfig.json entry from that projects array so
the resolver no longer tries to load the astro-extended tsconfig, OR make the
astro base config resolvable in the resolver context (e.g., ensure the astro
dependency and its tsconfigs are installed/available to the ESLint process or
replace the extends in apps/website/tsconfig.json with a resolvable path);
update the resolver projects array (and rerun ESLint) or install/configure astro
so import-x/no-unresolved for `@e2e/`* and `@playwright/test` resolves correctly.
In `@eslint.config.ts`:
- Around line 450-454: The patterns grouping ['./**','../**'] in the
no-restricted-imports blocks won't match bare "." and "..", so for both the spec
browser-tests block and the non-spec block where you currently set patterns: [{
group: ['./**','../**'], message: 'Use the `@e2e/` path alias instead of relative
imports.' }], add a separate paths: ['.', '..'] entry alongside patterns so the
rule explicitly forbids the bare specifiers; update both occurrences in
eslint.config.ts to include paths: ['.', '..'] with the same message.
---
Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts`:
- Around line 193-199: Replace the toPass() usage with expect.poll() for the
single async assertion: call expect.poll with an async callback that invokes
getPromotedWidgetNames(comfyPage, subgraphNodeId) and returns whether the
returned array includes 'seed', then assert .toBe(true) (or .toEqual(true)) and
pass the same timeout: 5000; this keeps the polling pattern consistent and
targets the single assertion on getPromotedWidgetNames.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d01c5b1f-a50a-45c3-ad16-159d0078daf0
📒 Files selected for processing (186)
browser_tests/AGENTS.mdbrowser_tests/FLAKE_PREVENTION_RULES.mdbrowser_tests/fixtures/ComfyMouse.tsbrowser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/VueNodeHelpers.tsbrowser_tests/fixtures/components/ComfyNodeSearchBox.tsbrowser_tests/fixtures/components/ComfyNodeSearchBoxV2.tsbrowser_tests/fixtures/components/ConfirmDialog.tsbrowser_tests/fixtures/components/QueuePanel.tsbrowser_tests/fixtures/components/SettingDialog.tsbrowser_tests/fixtures/components/SidebarTab.tsbrowser_tests/fixtures/components/SignInDialog.tsbrowser_tests/fixtures/components/Topbar.tsbrowser_tests/fixtures/constants/defaultGraphPositions.tsbrowser_tests/fixtures/helpers/AppModeHelper.tsbrowser_tests/fixtures/helpers/AppModeWidgetHelper.tsbrowser_tests/fixtures/helpers/AssetHelper.tsbrowser_tests/fixtures/helpers/AssetsHelper.tsbrowser_tests/fixtures/helpers/BuilderFooterHelper.tsbrowser_tests/fixtures/helpers/BuilderSaveAsHelper.tsbrowser_tests/fixtures/helpers/BuilderSelectHelper.tsbrowser_tests/fixtures/helpers/BuilderStepsHelper.tsbrowser_tests/fixtures/helpers/CanvasHelper.tsbrowser_tests/fixtures/helpers/ClipboardHelper.tsbrowser_tests/fixtures/helpers/CommandHelper.tsbrowser_tests/fixtures/helpers/DragDropHelper.tsbrowser_tests/fixtures/helpers/ModelLibraryHelper.tsbrowser_tests/fixtures/helpers/NodeOperationsHelper.tsbrowser_tests/fixtures/helpers/SubgraphHelper.tsbrowser_tests/fixtures/helpers/WorkflowHelper.tsbrowser_tests/fixtures/utils/customMatchers.tsbrowser_tests/fixtures/utils/litegraphUtils.tsbrowser_tests/fixtures/utils/vueNodeFixtures.tsbrowser_tests/globalSetup.tsbrowser_tests/globalTeardown.tsbrowser_tests/helpers/actionbar.tsbrowser_tests/helpers/builderTestUtils.tsbrowser_tests/helpers/fitToView.tsbrowser_tests/helpers/perfReporter.tsbrowser_tests/helpers/promotedWidgets.tsbrowser_tests/helpers/templates.tsbrowser_tests/tests/actionbar.spec.tsbrowser_tests/tests/appModeDropdownClipping.spec.tsbrowser_tests/tests/appModeWidgetRename.spec.tsbrowser_tests/tests/appModeWidgetValues.spec.tsbrowser_tests/tests/assetHelper.spec.tsbrowser_tests/tests/backgroundImageUpload.spec.tsbrowser_tests/tests/bottomPanelLogs.spec.tsbrowser_tests/tests/bottomPanelShortcuts.spec.tsbrowser_tests/tests/browserTabTitle.spec.tsbrowser_tests/tests/builderReorder.spec.tsbrowser_tests/tests/builderSaveFlow.spec.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/changeTrackerLoadGuard.spec.tsbrowser_tests/tests/collapsedNodeLinks.spec.tsbrowser_tests/tests/colorPalette.spec.tsbrowser_tests/tests/commands.spec.tsbrowser_tests/tests/confirmDialogTextWrap.spec.tsbrowser_tests/tests/containAudit.spec.tsbrowser_tests/tests/copyPaste.spec.tsbrowser_tests/tests/customIcons.spec.tsbrowser_tests/tests/defaultKeybindings.spec.tsbrowser_tests/tests/dialog.spec.tsbrowser_tests/tests/dialogs/queueClearHistory.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/domWidget.spec.tsbrowser_tests/tests/errorOverlaySeeErrors.spec.tsbrowser_tests/tests/execution.spec.tsbrowser_tests/tests/extensionAPI.spec.tsbrowser_tests/tests/featureFlags.spec.tsbrowser_tests/tests/focusMode.spec.tsbrowser_tests/tests/graph.spec.tsbrowser_tests/tests/graphCanvasMenu.spec.tsbrowser_tests/tests/groupCopyPaste.spec.tsbrowser_tests/tests/groupNode.spec.tsbrowser_tests/tests/groupSelectChildren.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/imagePastePriority.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/jobHistoryActions.spec.tsbrowser_tests/tests/keybindingPresets.spec.tsbrowser_tests/tests/keybindings.spec.tsbrowser_tests/tests/linearMode.spec.tsbrowser_tests/tests/litegraphEvent.spec.tsbrowser_tests/tests/loadWorkflowInMedia.spec.tsbrowser_tests/tests/lodThreshold.spec.tsbrowser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/missingMedia.spec.tsbrowser_tests/tests/mobileBaseline.spec.tsbrowser_tests/tests/nodeBadge.spec.tsbrowser_tests/tests/nodeDisplay.spec.tsbrowser_tests/tests/nodeGhostPlacement.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeLibraryEssentials.spec.tsbrowser_tests/tests/nodeSearchBox.spec.tsbrowser_tests/tests/nodeSearchBoxV2.spec.tsbrowser_tests/tests/nodeSearchBoxV2Extended.spec.tsbrowser_tests/tests/noteNode.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/pasteImageContextMenu.spec.tsbrowser_tests/tests/performance.spec.tsbrowser_tests/tests/primitiveNode.spec.tsbrowser_tests/tests/propertiesPanel/PropertiesPanelHelper.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/infoTab.spec.tsbrowser_tests/tests/propertiesPanel/nodeSelection.spec.tsbrowser_tests/tests/propertiesPanel/nodeSettings.spec.tsbrowser_tests/tests/propertiesPanel/openClose.spec.tsbrowser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.tsbrowser_tests/tests/propertiesPanel/searchFiltering.spec.tsbrowser_tests/tests/propertiesPanel/titleEditing.spec.tsbrowser_tests/tests/propertiesPanel/workflowOverview.spec.tsbrowser_tests/tests/recordAudio.spec.tsbrowser_tests/tests/releaseNotifications.spec.tsbrowser_tests/tests/remoteWidgets.spec.tsbrowser_tests/tests/rendererToggleStability.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/resultGallery.spec.tsbrowser_tests/tests/rightClickMenu.spec.tsbrowser_tests/tests/rightSidePanelTabs.spec.tsbrowser_tests/tests/saveImageAndWebp.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/selectionToolbox.spec.tsbrowser_tests/tests/selectionToolboxActions.spec.tsbrowser_tests/tests/selectionToolboxSubmenus.spec.tsbrowser_tests/tests/sidebar/assets.spec.tsbrowser_tests/tests/sidebar/modelLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibraryV2.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphCrud.spec.tsbrowser_tests/tests/subgraph/subgraphDraftPositions.spec.tsbrowser_tests/tests/subgraph/subgraphDuplicateIndependentValues.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphNested.spec.tsbrowser_tests/tests/subgraph/subgraphOperations.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/subgraph/subgraphZeroUuid.spec.tsbrowser_tests/tests/subgraphPromotedWidgetPanel.spec.tsbrowser_tests/tests/templateFitView.spec.tsbrowser_tests/tests/templates.spec.tsbrowser_tests/tests/toastNotifications.spec.tsbrowser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/useSettingSearch.spec.tsbrowser_tests/tests/userSelectView.spec.tsbrowser_tests/tests/versionMismatchWarnings.spec.tsbrowser_tests/tests/viewport.spec.tsbrowser_tests/tests/vueNodes/groups/groups.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/imagePreview.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/remove.spec.tsbrowser_tests/tests/vueNodes/interactions/node/rename.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.tsbrowser_tests/tests/vueNodes/nodeStates/collapse.spec.tsbrowser_tests/tests/vueNodes/nodeStates/colors.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/nodeStates/mute.spec.tsbrowser_tests/tests/vueNodes/nodeStates/pin.spec.tsbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.tsbrowser_tests/tests/vueNodes/widgets/advancedWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/int/integerWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/text/multilineStringWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/widgetReactivity.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/widgetCopyButton.spec.tsbrowser_tests/tests/workflowPersistence.spec.tsbrowser_tests/tests/workflowTabThumbnail.spec.tsbrowser_tests/tests/zoomControls.spec.tseslint.config.tsplaywright.config.ts
- Migrate all 354 relative imports across 181 files to use @e2e/ alias - External imports into src/ migrated to @/ alias - Add ESLint no-restricted-imports rule banning relative imports in browser_tests/ - Consolidate @playwright/test ban into spec-scoped block - Suppress pre-existing oxlint no-eval and no-console warnings Follows up on #10735 which introduced the @e2e/* tsconfig path alias. Amp-Thread-ID: https://ampcode.com/threads/T-019d6acd-6c53-7652-90e9-4bf2bf776cb2 Co-authored-by: Amp <amp@ampcode.com>
763f5f8 to
64e9e96
Compare
🎭 Playwright: ✅ 1013 passed, 0 failed · 1 flaky📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle: 5.12 MB gzip 🔴 +97 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.98 MB (baseline 2.98 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 338 kB (baseline 338 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 13 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.53 MB (baseline 8.53 MB) • ⚪ 0 BBundles that do not match a named category
Status: 55 added / 55 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-08T18:26:48.513Z",
"gitSha": "71ea934fdb7d681821804498b457c2c323c318e5",
"branch": "drjkl/test/path-to-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.84800000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.534000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.862,
"heapDeltaBytes": 20050136,
"heapUsedBytes": 64538220,
"domNodes": 12,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.928000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.949000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.401000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.40799999999996,
"heapDeltaBytes": 21069972,
"heapUsedBytes": 63859064,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.564999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.9000000000497,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.213000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.821,
"heapDeltaBytes": 20369480,
"heapUsedBytes": 63207760,
"domNodes": 22,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 22.087000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2019.1030000000012,
"styleRecalcs": 83,
"styleRecalcDurationMs": 41.711,
"layouts": 12,
"layoutDurationMs": 3.678,
"taskDurationMs": 939.6750000000002,
"heapDeltaBytes": 16717676,
"heapUsedBytes": 59161484,
"domNodes": 69,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 118.171,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.5860000000212,
"styleRecalcs": 80,
"styleRecalcDurationMs": 38.144,
"layouts": 12,
"layoutDurationMs": 3.448,
"taskDurationMs": 924.07,
"heapDeltaBytes": 15982116,
"heapUsedBytes": 58817000,
"domNodes": 65,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 122.54,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2004.1159999999536,
"styleRecalcs": 84,
"styleRecalcDurationMs": 42.875,
"layouts": 12,
"layoutDurationMs": 3.9569999999999994,
"taskDurationMs": 973.098,
"heapDeltaBytes": 16287980,
"heapUsedBytes": 59142688,
"domNodes": 67,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 125.943,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.191999999984,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.530000000000003,
"layouts": 6,
"layoutDurationMs": 0.6639999999999999,
"taskDurationMs": 334.001,
"heapDeltaBytes": 5469556,
"heapUsedBytes": 48180788,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 47.889,
"eventListeners": 23,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.5539999999655,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.953,
"layouts": 6,
"layoutDurationMs": 0.7049999999999998,
"taskDurationMs": 311.223,
"heapDeltaBytes": 24656408,
"heapUsedBytes": 67152584,
"domNodes": 80,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 25.347,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.133000000028,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.201,
"layouts": 6,
"layoutDurationMs": 0.544,
"taskDurationMs": 287.022,
"heapDeltaBytes": 24999468,
"heapUsedBytes": 67844124,
"domNodes": 77,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 23.633,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 560.6830000000116,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.161000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.06800000000004,
"heapDeltaBytes": 6489028,
"heapUsedBytes": 49296004,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 60.95,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 535.1569999999697,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.158999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.249,
"heapDeltaBytes": 6594272,
"heapUsedBytes": 49053512,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 58.846999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 530.2580000000034,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.14300000000003,
"heapDeltaBytes": 6213156,
"heapUsedBytes": 49001124,
"domNodes": 20,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 58.881,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2035.726000000011,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.785000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.3149999999999,
"heapDeltaBytes": 4606504,
"heapUsedBytes": 55539412,
"domNodes": -256,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 86.617,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.3359999999961,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.3720000000001,
"heapDeltaBytes": 4235160,
"heapUsedBytes": 54609692,
"domNodes": -256,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 87.162,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2047.5910000000113,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.236,
"heapDeltaBytes": 4834832,
"heapUsedBytes": 55269484,
"domNodes": -254,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 92.619,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2106.741999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.290999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1018.289,
"heapDeltaBytes": 18684060,
"heapUsedBytes": 70792684,
"domNodes": -261,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 356.159,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2119.3380000000275,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1067.717,
"heapDeltaBytes": 17975536,
"heapUsedBytes": 71682704,
"domNodes": -264,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 381.52699999999993,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2138.9879999999266,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1042.883,
"heapDeltaBytes": 17861216,
"heapUsedBytes": 71463280,
"domNodes": -262,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 362.569,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3143.9340000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.745000000000005,
"layouts": 60,
"layoutDurationMs": 7.507,
"taskDurationMs": 1274.139,
"heapDeltaBytes": 7211292,
"heapUsedBytes": 62104520,
"domNodes": -264,
"jsHeapTotalBytes": 17756160,
"scriptDurationMs": 469.785,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3145.462000000009,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.843000000000004,
"layouts": 60,
"layoutDurationMs": 8.261999999999999,
"taskDurationMs": 1341.918,
"heapDeltaBytes": 7061248,
"heapUsedBytes": 61688560,
"domNodes": -264,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 498.17499999999995,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3197.6170000000366,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.355999999999998,
"layouts": 60,
"layoutDurationMs": 7.825,
"taskDurationMs": 1342.6299999999999,
"heapDeltaBytes": 8226244,
"heapUsedBytes": 63325016,
"domNodes": -265,
"jsHeapTotalBytes": 18018304,
"scriptDurationMs": 508.3230000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.950999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.861999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.513,
"heapDeltaBytes": 3617688,
"heapUsedBytes": 57767372,
"domNodes": -261,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 77.35199999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2045.357000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.886999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5479999999999,
"heapDeltaBytes": 4943156,
"heapUsedBytes": 56837208,
"domNodes": -261,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 90.551,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.521999999939,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.657000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.353,
"heapDeltaBytes": 3443176,
"heapUsedBytes": 57771392,
"domNodes": -262,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 80.559,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.8530000000364,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.767000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.313,
"heapDeltaBytes": 6512736,
"heapUsedBytes": 49557556,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 118.72899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.5970000000016,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.99800000000005,
"heapDeltaBytes": 6869644,
"heapUsedBytes": 49632792,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 124.447,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.0990000000074,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.246,
"heapDeltaBytes": 6496172,
"heapUsedBytes": 49488668,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 128.528,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.786999999988,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.441,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.387,
"heapDeltaBytes": 19925172,
"heapUsedBytes": 63133392,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 17.403,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.4979999999932,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.861999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.466,
"heapDeltaBytes": 19873584,
"heapUsedBytes": 63090060,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 16.631,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.377999999927,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.531000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.436,
"heapDeltaBytes": 20140672,
"heapUsedBytes": 63310576,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 17.045,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.8230000000053,
"styleRecalcs": 85,
"styleRecalcDurationMs": 41.007000000000005,
"layouts": 16,
"layoutDurationMs": 4.26,
"taskDurationMs": 853.4490000000001,
"heapDeltaBytes": 12256992,
"heapUsedBytes": 55290036,
"domNodes": 75,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 89.85400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1955.1510000000007,
"styleRecalcs": 83,
"styleRecalcDurationMs": 47.26,
"layouts": 16,
"layoutDurationMs": 5.296,
"taskDurationMs": 888.509,
"heapDeltaBytes": 11878268,
"heapUsedBytes": 54672148,
"domNodes": 72,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 97.452,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1980.7939999999462,
"styleRecalcs": 85,
"styleRecalcDurationMs": 43.885,
"layouts": 16,
"layoutDurationMs": 4.8069999999999995,
"taskDurationMs": 872.655,
"heapDeltaBytes": 11932940,
"heapUsedBytes": 54639740,
"domNodes": 76,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 92.70100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.758999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3381.466,
"heapDeltaBytes": 25578416,
"heapUsedBytes": 76324428,
"domNodes": -257,
"jsHeapTotalBytes": 21106688,
"scriptDurationMs": 1096.6719999999998,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.623000000045,
"styleRecalcs": 251,
"styleRecalcDurationMs": 48.849000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3700.2589999999996,
"heapDeltaBytes": 27479692,
"heapUsedBytes": 78603912,
"domNodes": -255,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 1212.809,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8233.044999999947,
"styleRecalcs": 252,
"styleRecalcDurationMs": 45.599000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3557.384,
"heapDeltaBytes": -4431528,
"heapUsedBytes": 65734992,
"domNodes": -253,
"jsHeapTotalBytes": 23236608,
"scriptDurationMs": 1165.311,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11980.270000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11968.685,
"heapDeltaBytes": -40451464,
"heapUsedBytes": 152789996,
"domNodes": -8331,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 565,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13976.936999999964,
"styleRecalcs": 2,
"styleRecalcDurationMs": 32.165999999999976,
"layouts": 2,
"layoutDurationMs": 9.489999999999998,
"taskDurationMs": 13958.572,
"heapDeltaBytes": 14054316,
"heapUsedBytes": 166385436,
"domNodes": -4996,
"jsHeapTotalBytes": 56451072,
"scriptDurationMs": 609.614,
"eventListeners": 3530,
"totalBlockingTimeMs": 793,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13306.541999999921,
"styleRecalcs": 2,
"styleRecalcDurationMs": 28.517999999999986,
"layouts": 2,
"layoutDurationMs": 9.201,
"taskDurationMs": 13290.289,
"heapDeltaBytes": -3093164,
"heapUsedBytes": 162427520,
"domNodes": -4997,
"jsHeapTotalBytes": 50421760,
"scriptDurationMs": 584.298,
"eventListeners": 3532,
"totalBlockingTimeMs": 793,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14890.491999999995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.378999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14868.428000000002,
"heapDeltaBytes": -31824632,
"heapUsedBytes": 160387336,
"domNodes": -8331,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 895.868,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14700.06399999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.224999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14667.804,
"heapDeltaBytes": -36233152,
"heapUsedBytes": 172116948,
"domNodes": -8331,
"jsHeapTotalBytes": -11792384,
"scriptDurationMs": 845.988,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14613.460000000032,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.082999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14588.875000000002,
"heapDeltaBytes": -23598308,
"heapUsedBytes": 171203148,
"domNodes": -8331,
"jsHeapTotalBytes": 24383488,
"scriptDurationMs": 832.449,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 440.29199999999946,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.162999999999997,
"layouts": 5,
"layoutDurationMs": 1.595,
"taskDurationMs": 118.053,
"heapDeltaBytes": 4681236,
"heapUsedBytes": 49356680,
"domNodes": 167,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 25.424000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 441.8520000000399,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.359,
"layouts": 5,
"layoutDurationMs": 1.4260000000000002,
"taskDurationMs": 123.93100000000001,
"heapDeltaBytes": 4504044,
"heapUsedBytes": 48887932,
"domNodes": 157,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.881,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 462.2140000000172,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.832,
"layouts": 6,
"layoutDurationMs": 1.801,
"taskDurationMs": 122.10200000000002,
"heapDeltaBytes": 4564244,
"heapUsedBytes": 48443024,
"domNodes": 180,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.145000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #10958 +/- ##
==========================================
- Coverage 43.09% 43.08% -0.02%
==========================================
Files 1332 1332
Lines 68165 68165
Branches 18812 17955 -857
==========================================
- Hits 29377 29366 -11
- Misses 38192 38203 +11
Partials 596 596 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
browser_tests/tests/assetHelper.spec.ts (1)
3-18:⚠️ Potential issue | 🔴 CriticalFix missing
astrodependency and addbrowser_tests/tsconfig.jsonto ESLint resolver config before merging.The alias imports fail because ESLint's tsconfig resolver crashes when parsing
apps/website/tsconfig.json, which extendsastro/tsconfigs/strictbut astro is not installed. Additionally,browser_tests/tsconfig.jsonis missing from the ESLint resolver's project list, so path aliases cannot be resolved even after the astro issue is fixed.Required fixes:
- Add astro to package.json dependencies (if intentional for apps/website), or update
apps/website/tsconfig.jsonto not extend astro- Add
'./browser_tests/tsconfig.json'to theprojectarray ineslint.config.tsundercreateTypeScriptImportResolversettings🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/assetHelper.spec.ts` around lines 3 - 18, The project’s ESLint TypeScript resolver is failing because apps/website/tsconfig.json extends astro/tsconfigs/strict while astro is not installed, and browser_tests/tsconfig.json is missing from the resolver projects; fix by either adding "astro" to package.json dependencies (if apps/website intentionally uses Astro) or remove/replace the extend in apps/website/tsconfig.json so it no longer references astro, and then update eslint.config.ts to include './browser_tests/tsconfig.json' in the project array passed to createTypeScriptImportResolver so alias imports from browser_tests resolve correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/fixtures/helpers/WorkflowHelper.ts`:
- Line 10: The ESLint resolver fails to parse tsconfig because the extends chain
includes "astro/tsconfigs/strict" which is missing, causing the alias import in
browser_tests/fixtures/helpers/WorkflowHelper.ts (import { assetPath } from
'@e2e/fixtures/utils/paths') to be unresolved; fix by restoring or replacing the
missing extended config: either install the astro package that provides
"astro/tsconfigs/strict" or remove/replace that extends entry in tsconfig.json
so the TypeScript resolver in eslint.config.ts can read the
compilerOptions.paths mapping (confirm the `@e2e/`* paths remain defined), then
re-run ESLint to ensure the import in WorkflowHelper.ts resolves.
In `@browser_tests/tests/noteNode.spec.ts`:
- Line 3: The import error comes from the unresolved alias
'@e2e/fixtures/ComfyPage' used in the test import (comfyPageFixture as test);
fix by adding the same alias mapping to both TypeScript and ESLint: update your
tsconfig.json "paths" to map "@e2e/*" to the actual fixtures directory and
ensure the exported module name matches ComfyPage, and add the resolver config
in your ESLint settings (e.g. settings.import/resolver -> typescript or node
with the same alias) so the import-x/no-unresolved rule can resolve
'@e2e/fixtures/ComfyPage'.
In `@browser_tests/tests/rightClickMenu.spec.ts`:
- Around line 3-5: Update the ESLint import resolver configuration in
eslint.config.ts to include the browser tests tsconfig by adding
'./browser_tests/tsconfig.json' to the project array so path aliases used in
browser tests (e.g., imports like '@/...' and '@e2e/...') are resolvable; locate
the project: [...] array in eslint.config.ts and append the new entry alongside
'./tsconfig.json', './apps/*/tsconfig.json', and './packages/*/tsconfig.json'.
In `@browser_tests/tests/vueNodes/interactions/node/imagePreview.spec.ts`:
- Around line 3-4: Add the missing browser_tests tsconfig to the TypeScript
import resolver: in eslint.config.ts locate the createTypeScriptImportResolver
call and update its projects array to include './browser_tests/tsconfig.json'
alongside the existing './tsconfig.json', './apps/*/tsconfig.json', and
'./packages/*/tsconfig.json' so the `@e2e/`* alias (used in imports like
comfyPageFixture) resolves without import-x/no-unresolved errors.
---
Outside diff comments:
In `@browser_tests/tests/assetHelper.spec.ts`:
- Around line 3-18: The project’s ESLint TypeScript resolver is failing because
apps/website/tsconfig.json extends astro/tsconfigs/strict while astro is not
installed, and browser_tests/tsconfig.json is missing from the resolver
projects; fix by either adding "astro" to package.json dependencies (if
apps/website intentionally uses Astro) or remove/replace the extend in
apps/website/tsconfig.json so it no longer references astro, and then update
eslint.config.ts to include './browser_tests/tsconfig.json' in the project array
passed to createTypeScriptImportResolver so alias imports from browser_tests
resolve correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 10f97920-7115-4d48-858b-29f061d8a3af
📒 Files selected for processing (182)
browser_tests/fixtures/ComfyMouse.tsbrowser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/VueNodeHelpers.tsbrowser_tests/fixtures/components/ComfyNodeSearchBoxV2.tsbrowser_tests/fixtures/components/ConfirmDialog.tsbrowser_tests/fixtures/components/QueuePanel.tsbrowser_tests/fixtures/components/SettingDialog.tsbrowser_tests/fixtures/components/SidebarTab.tsbrowser_tests/fixtures/components/SignInDialog.tsbrowser_tests/fixtures/components/Topbar.tsbrowser_tests/fixtures/constants/defaultGraphPositions.tsbrowser_tests/fixtures/helpers/AppModeHelper.tsbrowser_tests/fixtures/helpers/AppModeWidgetHelper.tsbrowser_tests/fixtures/helpers/AssetHelper.tsbrowser_tests/fixtures/helpers/AssetsHelper.tsbrowser_tests/fixtures/helpers/BuilderFooterHelper.tsbrowser_tests/fixtures/helpers/BuilderSaveAsHelper.tsbrowser_tests/fixtures/helpers/BuilderSelectHelper.tsbrowser_tests/fixtures/helpers/BuilderStepsHelper.tsbrowser_tests/fixtures/helpers/CanvasHelper.tsbrowser_tests/fixtures/helpers/ClipboardHelper.tsbrowser_tests/fixtures/helpers/CommandHelper.tsbrowser_tests/fixtures/helpers/DragDropHelper.tsbrowser_tests/fixtures/helpers/ModelLibraryHelper.tsbrowser_tests/fixtures/helpers/NodeOperationsHelper.tsbrowser_tests/fixtures/helpers/SubgraphHelper.tsbrowser_tests/fixtures/helpers/WorkflowHelper.tsbrowser_tests/fixtures/utils/customMatchers.tsbrowser_tests/fixtures/utils/litegraphUtils.tsbrowser_tests/fixtures/utils/vueNodeFixtures.tsbrowser_tests/globalSetup.tsbrowser_tests/globalTeardown.tsbrowser_tests/helpers/actionbar.tsbrowser_tests/helpers/builderTestUtils.tsbrowser_tests/helpers/fitToView.tsbrowser_tests/helpers/perfReporter.tsbrowser_tests/helpers/promotedWidgets.tsbrowser_tests/helpers/templates.tsbrowser_tests/tests/actionbar.spec.tsbrowser_tests/tests/appModeDropdownClipping.spec.tsbrowser_tests/tests/appModeWidgetRename.spec.tsbrowser_tests/tests/appModeWidgetValues.spec.tsbrowser_tests/tests/assetHelper.spec.tsbrowser_tests/tests/backgroundImageUpload.spec.tsbrowser_tests/tests/bottomPanelLogs.spec.tsbrowser_tests/tests/bottomPanelShortcuts.spec.tsbrowser_tests/tests/browserTabTitle.spec.tsbrowser_tests/tests/builderReorder.spec.tsbrowser_tests/tests/builderSaveFlow.spec.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/changeTrackerLoadGuard.spec.tsbrowser_tests/tests/collapsedNodeLinks.spec.tsbrowser_tests/tests/colorPalette.spec.tsbrowser_tests/tests/commands.spec.tsbrowser_tests/tests/confirmDialogTextWrap.spec.tsbrowser_tests/tests/containAudit.spec.tsbrowser_tests/tests/copyPaste.spec.tsbrowser_tests/tests/customIcons.spec.tsbrowser_tests/tests/defaultKeybindings.spec.tsbrowser_tests/tests/dialog.spec.tsbrowser_tests/tests/dialogs/queueClearHistory.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/domWidget.spec.tsbrowser_tests/tests/errorOverlaySeeErrors.spec.tsbrowser_tests/tests/execution.spec.tsbrowser_tests/tests/extensionAPI.spec.tsbrowser_tests/tests/featureFlags.spec.tsbrowser_tests/tests/focusMode.spec.tsbrowser_tests/tests/graph.spec.tsbrowser_tests/tests/graphCanvasMenu.spec.tsbrowser_tests/tests/groupCopyPaste.spec.tsbrowser_tests/tests/groupNode.spec.tsbrowser_tests/tests/groupSelectChildren.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/imagePastePriority.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/jobHistoryActions.spec.tsbrowser_tests/tests/keybindingPresets.spec.tsbrowser_tests/tests/keybindings.spec.tsbrowser_tests/tests/linearMode.spec.tsbrowser_tests/tests/litegraphEvent.spec.tsbrowser_tests/tests/loadWorkflowInMedia.spec.tsbrowser_tests/tests/lodThreshold.spec.tsbrowser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/missingMedia.spec.tsbrowser_tests/tests/mobileBaseline.spec.tsbrowser_tests/tests/nodeBadge.spec.tsbrowser_tests/tests/nodeDisplay.spec.tsbrowser_tests/tests/nodeGhostPlacement.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeLibraryEssentials.spec.tsbrowser_tests/tests/nodeSearchBox.spec.tsbrowser_tests/tests/nodeSearchBoxV2.spec.tsbrowser_tests/tests/nodeSearchBoxV2Extended.spec.tsbrowser_tests/tests/noteNode.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/pasteImageContextMenu.spec.tsbrowser_tests/tests/performance.spec.tsbrowser_tests/tests/primitiveNode.spec.tsbrowser_tests/tests/propertiesPanel/PropertiesPanelHelper.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/infoTab.spec.tsbrowser_tests/tests/propertiesPanel/nodeSelection.spec.tsbrowser_tests/tests/propertiesPanel/nodeSettings.spec.tsbrowser_tests/tests/propertiesPanel/openClose.spec.tsbrowser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.tsbrowser_tests/tests/propertiesPanel/searchFiltering.spec.tsbrowser_tests/tests/propertiesPanel/titleEditing.spec.tsbrowser_tests/tests/propertiesPanel/workflowOverview.spec.tsbrowser_tests/tests/recordAudio.spec.tsbrowser_tests/tests/releaseNotifications.spec.tsbrowser_tests/tests/remoteWidgets.spec.tsbrowser_tests/tests/rendererToggleStability.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/resultGallery.spec.tsbrowser_tests/tests/rightClickMenu.spec.tsbrowser_tests/tests/rightSidePanelTabs.spec.tsbrowser_tests/tests/saveImageAndWebp.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/selectionToolbox.spec.tsbrowser_tests/tests/selectionToolboxActions.spec.tsbrowser_tests/tests/selectionToolboxSubmenus.spec.tsbrowser_tests/tests/sidebar/assets.spec.tsbrowser_tests/tests/sidebar/modelLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibraryV2.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphCrud.spec.tsbrowser_tests/tests/subgraph/subgraphDraftPositions.spec.tsbrowser_tests/tests/subgraph/subgraphDuplicateIndependentValues.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphNested.spec.tsbrowser_tests/tests/subgraph/subgraphOperations.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/subgraph/subgraphZeroUuid.spec.tsbrowser_tests/tests/subgraphPromotedWidgetPanel.spec.tsbrowser_tests/tests/templateFitView.spec.tsbrowser_tests/tests/templates.spec.tsbrowser_tests/tests/toastNotifications.spec.tsbrowser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/useSettingSearch.spec.tsbrowser_tests/tests/userSelectView.spec.tsbrowser_tests/tests/versionMismatchWarnings.spec.tsbrowser_tests/tests/viewport.spec.tsbrowser_tests/tests/vueNodes/groups/groups.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/imagePreview.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/remove.spec.tsbrowser_tests/tests/vueNodes/interactions/node/rename.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.tsbrowser_tests/tests/vueNodes/nodeStates/collapse.spec.tsbrowser_tests/tests/vueNodes/nodeStates/colors.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/nodeStates/mute.spec.tsbrowser_tests/tests/vueNodes/nodeStates/pin.spec.tsbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.tsbrowser_tests/tests/vueNodes/widgets/advancedWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/int/integerWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/text/multilineStringWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/widgetReactivity.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/widgetCopyButton.spec.tsbrowser_tests/tests/workflowPersistence.spec.tsbrowser_tests/tests/workflowTabThumbnail.spec.tsbrowser_tests/tests/zoomControls.spec.tseslint.config.ts
✅ Files skipped from review due to trivial changes (12)
- browser_tests/fixtures/components/Topbar.ts
- browser_tests/fixtures/helpers/AppModeWidgetHelper.ts
- browser_tests/fixtures/helpers/AssetsHelper.ts
- browser_tests/fixtures/helpers/BuilderSaveAsHelper.ts
- browser_tests/fixtures/helpers/ModelLibraryHelper.ts
- browser_tests/fixtures/helpers/BuilderStepsHelper.ts
- browser_tests/fixtures/helpers/CommandHelper.ts
- browser_tests/fixtures/ComfyMouse.ts
- browser_tests/helpers/perfReporter.ts
- browser_tests/fixtures/components/ComfyNodeSearchBoxV2.ts
- browser_tests/fixtures/components/ConfirmDialog.ts
- browser_tests/fixtures/utils/customMatchers.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- eslint.config.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019d6dc2-c369-7148-9399-f18e137bfa16 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # browser_tests/tests/dialog.spec.ts # browser_tests/tests/errorOverlaySeeErrors.spec.ts # browser_tests/tests/propertiesPanel/errorsTab.spec.ts # browser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.ts
| ignores: ['**/use[A-Z]*.ts', '**/*.test.ts', 'src/i18n.ts'], | ||
| files: ['**/use[A-Z]*.ts', '**/*.test.ts', 'src/i18n.ts'], | ||
| rules: { | ||
| 'no-restricted-imports': [ |
There was a problem hiding this comment.
Can we define these in Oxc lint instead?
https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-restricted-imports
There was a problem hiding this comment.
Good question! I investigated this — unfortunately these particular rules need to stay in ESLint because of how they layer per-file-scope.
The problem: oxlint already has a global no-restricted-imports config in .oxlintrc.json (the PrimeVue deprecation bans on lines 40-66). The browser_tests rules need different no-restricted-imports configurations scoped to specific file globs. While oxlint supports overrides, it replaces the entire rule config rather than merging — so adding no-restricted-imports in a browser_tests override would lose the global PrimeVue restrictions for those files.
ESLint's flat config handles this correctly: each config block layers additively, so the PrimeVue bans (global), the useI18n/useVirtualList bans (scoped), and the relative-import bans (browser_tests-scoped) all coexist without collision.
The same issue applies to the @playwright/test import ban and the useI18n vs global t enforcement — they all need different no-restricted-imports configs for different file sets, which requires ESLint's layered merging.
There was a problem hiding this comment.
One addendum: there is a future path if we ever want to consolidate. Oxlint now supports nested config files (browser_tests/.oxlintrc.json), but they don't cascade/merge with the root — the nearest config wins outright, and extends replaces rule options rather than concatenating paths/patterns.
The viable Oxlint-native approach would be migrating from .oxlintrc.json to oxlint.config.ts, where we could compose shared arrays programmatically:
const primeVueDeprecatedPaths = [
{ name: 'primevue/calendar', message: '...' },
// ...
]
const e2eAliasPatterns = [
{ group: ['./**', '../**'], message: 'Use the @e2e/ path alias instead of relative imports.' }
]
// Then compose per scope:
overrides: [{
files: ['browser_tests/**/*.ts'],
rules: {
'no-restricted-imports': ['error', {
paths: primeVueDeprecatedPaths,
patterns: e2eAliasPatterns
}]
}
}]That's a separate migration though — not in scope here. For now, ESLint flat config's additive layering is the right tool for the job.
…10958) ## Summary Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding. ## Changes - **What**: Migrate all relative imports in browser_tests/ to use `@e2e/` (intra-directory) and `@/` (src/ imports) path aliases. Add `no-restricted-imports` ESLint rule banning `./` and `../` imports in `browser_tests/**/*.ts`. Suppress pre-existing oxlint `no-eval` and `no-console` warnings exposed by touching those files. ## Review Focus - ESLint flat-config merging: the `@playwright/test` ban and relative-import ban are in two separate blocks to avoid last-match-wins collision with the `useI18n`/`useVirtualList` blocks higher in the config. - The `['./**', '../**']` glob patterns (not `['./*', '../*']`) are needed to catch multi-level relative paths like `../../../src/foo`. Follows up on #10735 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10958-test-migrate-browser_tests-to-e2e-path-alias-and-add-lint-rule-33c6d73d365081649d1be771eac986fd) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
Summary
Complete the @e2e/ path alias migration started in #10735 by converting all 354 remaining relative imports and adding a lint rule to prevent backsliding.
Changes
@e2e/(intra-directory) and@/(src/ imports) path aliases. Addno-restricted-importsESLint rule banning./and../imports inbrowser_tests/**/*.ts. Suppress pre-existing oxlintno-evalandno-consolewarnings exposed by touching those files.Review Focus
@playwright/testban and relative-import ban are in two separate blocks to avoid last-match-wins collision with theuseI18n/useVirtualListblocks higher in the config.['./**', '../**']glob patterns (not['./*', '../*']) are needed to catch multi-level relative paths like../../../src/foo.Follows up on #10735
┆Issue is synchronized with this Notion page by Unito