Repository navigation
refactor: consolidate browser_tests/helpers/ into fixtures/ - #11411
Conversation
Eliminate the confusing dual-helpers structure where browser_tests/helpers/
and browser_tests/fixtures/helpers/ coexisted one tier apart.
File moves:
- helpers/actionbar.ts → fixtures/components/Actionbar.ts (page object)
- helpers/templates.ts → fixtures/components/Templates.ts (page object)
- helpers/{7 files} → fixtures/utils/ (standalone utilities)
- fixtures/helpers/boundsUtils.ts → fixtures/utils/ (pure function)
- fixtures/helpers/mimeTypeUtil.ts → fixtures/utils/ (pure function)
Updated all 28 import statements, 3 markdown docs, and 1 skill file.
Added eslint rule to prevent re-creating browser_tests/helpers/.
🎭 Playwright: ✅ 1365 passed, 0 failed📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughReplaces many Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.23 MB gzip 🔴 +147 BDetailsSummary
Category Glance App Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.23 MB (baseline 1.23 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 77.7 kB (baseline 77.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.4 kB (baseline 17.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 113 kB (baseline 113 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 61 kB (baseline 61 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.04 MB (baseline 3.04 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 363 kB (baseline 363 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.88 MB (baseline 9.88 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.83 MB (baseline 8.83 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-28T02:13:45.143Z",
"gitSha": "9df04d18f66132bd2e1666b8b8a84ba89985ee24",
"branch": "glary/refactor-browser-tests-helpers-structure",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.7669999999498,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4890000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.42199999999997,
"heapDeltaBytes": 20074960,
"heapUsedBytes": 63760772,
"domNodes": 8,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 15.89,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.1790000000747,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.371000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.25800000000004,
"heapDeltaBytes": 20571936,
"heapUsedBytes": 64701772,
"domNodes": 14,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.559000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2024.2490000000544,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.519999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.9599999999999,
"heapDeltaBytes": 20597932,
"heapUsedBytes": 64732412,
"domNodes": 14,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 18.294999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1968.200999999965,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.086,
"layouts": 12,
"layoutDurationMs": 3.3180000000000005,
"taskDurationMs": 909.146,
"heapDeltaBytes": 16483480,
"heapUsedBytes": 60458456,
"domNodes": 62,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 122.72200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.6799999999657,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.017,
"layouts": 12,
"layoutDurationMs": 3.438,
"taskDurationMs": 755.76,
"heapDeltaBytes": 16362912,
"heapUsedBytes": 59996452,
"domNodes": 56,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 132.669,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1982.0109999999431,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.382,
"layouts": 12,
"layoutDurationMs": 3.4479999999999995,
"taskDurationMs": 938.7829999999999,
"heapDeltaBytes": 15992112,
"heapUsedBytes": 59760352,
"domNodes": 64,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 132.685,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.0729999999949,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.191999999999997,
"layouts": 6,
"layoutDurationMs": 0.5139999999999999,
"taskDurationMs": 299.58000000000004,
"heapDeltaBytes": 159580,
"heapUsedBytes": 49921252,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 23.056,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.8369999999604,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.578000000000003,
"layouts": 6,
"layoutDurationMs": 0.6789999999999999,
"taskDurationMs": 291.173,
"heapDeltaBytes": 25017648,
"heapUsedBytes": 68702868,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 23.126,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7830000000495,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.745000000000005,
"layouts": 6,
"layoutDurationMs": 0.601,
"taskDurationMs": 306.554,
"heapDeltaBytes": 25009008,
"heapUsedBytes": 68785972,
"domNodes": 79,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 25.145,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 533.5230000000024,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.982,
"heapDeltaBytes": 6909936,
"heapUsedBytes": 50546280,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 60.25999999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 547.8070000000343,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.72,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.59700000000004,
"heapDeltaBytes": 6655612,
"heapUsedBytes": 50785584,
"domNodes": 18,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 57.672000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 544.858999999974,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.431000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.42100000000005,
"heapDeltaBytes": 7060244,
"heapUsedBytes": 50781652,
"domNodes": 20,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 65.70800000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2052.3599999999647,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.682,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.6639999999999,
"heapDeltaBytes": 4814604,
"heapUsedBytes": 57212584,
"domNodes": -258,
"jsHeapTotalBytes": 16420864,
"scriptDurationMs": 102.824,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.636000000096,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.992999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.0310000000001,
"heapDeltaBytes": 4051104,
"heapUsedBytes": 56602152,
"domNodes": -261,
"jsHeapTotalBytes": 16420864,
"scriptDurationMs": 121.95,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.998000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.248999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.9820000000001,
"heapDeltaBytes": 4260816,
"heapUsedBytes": 56800628,
"domNodes": -258,
"jsHeapTotalBytes": 16420864,
"scriptDurationMs": 100.55699999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2113.7190000000032,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.707,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1034.9579999999999,
"heapDeltaBytes": 13678704,
"heapUsedBytes": 68636132,
"domNodes": -262,
"jsHeapTotalBytes": 17412096,
"scriptDurationMs": 383.81399999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.6810000000432,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.911999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1083.2069999999999,
"heapDeltaBytes": 18427380,
"heapUsedBytes": 73742740,
"domNodes": -265,
"jsHeapTotalBytes": 17489920,
"scriptDurationMs": 399.717,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2115.601999999967,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1059.8890000000001,
"heapDeltaBytes": 1847620,
"heapUsedBytes": 56692352,
"domNodes": -264,
"jsHeapTotalBytes": 18460672,
"scriptDurationMs": 385.972,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3128.3220000000256,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.504,
"layouts": 60,
"layoutDurationMs": 7.204,
"taskDurationMs": 1297.284,
"heapDeltaBytes": 6156380,
"heapUsedBytes": 61835896,
"domNodes": -262,
"jsHeapTotalBytes": 16683008,
"scriptDurationMs": 487.094,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3130.1879999999755,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.210000000000004,
"layouts": 60,
"layoutDurationMs": 7.182,
"taskDurationMs": 1308.532,
"heapDeltaBytes": 8022756,
"heapUsedBytes": 64622292,
"domNodes": -268,
"jsHeapTotalBytes": 16420864,
"scriptDurationMs": 485.621,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3151.7410000000154,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.936,
"layouts": 60,
"layoutDurationMs": 6.964,
"taskDurationMs": 1297.838,
"heapDeltaBytes": 6499104,
"heapUsedBytes": 62690800,
"domNodes": -264,
"jsHeapTotalBytes": 17993728,
"scriptDurationMs": 479.008,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.9299999999935,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.2370000000001,
"heapDeltaBytes": 3206780,
"heapUsedBytes": 59000392,
"domNodes": -261,
"jsHeapTotalBytes": 16683008,
"scriptDurationMs": 89.201,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2021.0230000000138,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.736999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.404,
"heapDeltaBytes": 2839996,
"heapUsedBytes": 58674364,
"domNodes": -263,
"jsHeapTotalBytes": 16158720,
"scriptDurationMs": 94.222,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.345000000054,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.517999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.979,
"heapDeltaBytes": -1296724,
"heapUsedBytes": 54739424,
"domNodes": -263,
"jsHeapTotalBytes": 15896576,
"scriptDurationMs": 89.515,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.5700000000161,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.041000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.20399999999995,
"heapDeltaBytes": 7356464,
"heapUsedBytes": 51252404,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 122.98899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.0310000000227,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.422,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.078,
"heapDeltaBytes": 7024816,
"heapUsedBytes": 50989692,
"domNodes": 20,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 122.472,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 540.0419999999713,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.82,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.20199999999994,
"heapDeltaBytes": 7261736,
"heapUsedBytes": 51263700,
"domNodes": 19,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 123.96799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2003.1099999999924,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.28100000000006,
"heapDeltaBytes": 19882044,
"heapUsedBytes": 63979556,
"domNodes": 21,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 13.459,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2008.6509999999862,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.392000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.24,
"heapDeltaBytes": 19986180,
"heapUsedBytes": 63977192,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 16.464000000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.5829999999305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.736000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.835,
"heapDeltaBytes": 20217436,
"heapUsedBytes": 64581324,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 24.624999999999993,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2000.7679999999937,
"styleRecalcs": 84,
"styleRecalcDurationMs": 45.712,
"layouts": 16,
"layoutDurationMs": 4.337,
"taskDurationMs": 895.1090000000002,
"heapDeltaBytes": 12261132,
"heapUsedBytes": 57523564,
"domNodes": 73,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 96.53,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.5180000000792,
"styleRecalcs": 84,
"styleRecalcDurationMs": 47.455,
"layouts": 16,
"layoutDurationMs": 4.583,
"taskDurationMs": 902.5699999999999,
"heapDeltaBytes": 11814392,
"heapUsedBytes": 56196180,
"domNodes": 72,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 103.518,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.0180000000482,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.657999999999994,
"layouts": 16,
"layoutDurationMs": 4.859,
"taskDurationMs": 935.7110000000001,
"heapDeltaBytes": 12336008,
"heapUsedBytes": 56270924,
"domNodes": 72,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 106.234,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.872000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 50.793000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3590.871,
"heapDeltaBytes": 26044300,
"heapUsedBytes": 78365052,
"domNodes": -258,
"jsHeapTotalBytes": 19247104,
"scriptDurationMs": 1242.822,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.283000000045,
"styleRecalcs": 251,
"styleRecalcDurationMs": 52.488,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3680.1540000000005,
"heapDeltaBytes": -9740192,
"heapUsedBytes": 51690936,
"domNodes": -256,
"jsHeapTotalBytes": 18575360,
"scriptDurationMs": 1226.002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.999999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 50.17099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3627.744,
"heapDeltaBytes": 15935072,
"heapUsedBytes": 68480356,
"domNodes": -260,
"jsHeapTotalBytes": 19771392,
"scriptDurationMs": 1239.0220000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11881.282,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11869.100000000002,
"heapDeltaBytes": -46684760,
"heapUsedBytes": 168786340,
"domNodes": -9850,
"jsHeapTotalBytes": 26275840,
"scriptDurationMs": 583.86,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12334.075999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12323.072,
"heapDeltaBytes": -48827716,
"heapUsedBytes": 168452820,
"domNodes": -9850,
"jsHeapTotalBytes": 24178688,
"scriptDurationMs": 607.933,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11977.83400000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11954.903999999999,
"heapDeltaBytes": -52326564,
"heapUsedBytes": 162289604,
"domNodes": -9850,
"jsHeapTotalBytes": 18149376,
"scriptDurationMs": 592.494,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14141.342000000008,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.610000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14118.787,
"heapDeltaBytes": -43761000,
"heapUsedBytes": 167949472,
"domNodes": -9848,
"jsHeapTotalBytes": 25489408,
"scriptDurationMs": 887.408,
"eventListeners": -23955,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14201.867999999991,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.427000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14180.381000000001,
"heapDeltaBytes": -39052956,
"heapUsedBytes": 174421476,
"domNodes": -9848,
"jsHeapTotalBytes": -11296768,
"scriptDurationMs": 896.126,
"eventListeners": -23955,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14359.71799999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.074000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14324.041000000001,
"heapDeltaBytes": -55196524,
"heapUsedBytes": 158547756,
"domNodes": -9850,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 927.043,
"eventListeners": -23983,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.4919999999638,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.686999999999998,
"layouts": 5,
"layoutDurationMs": 1.492,
"taskDurationMs": 125.583,
"heapDeltaBytes": 5332596,
"heapUsedBytes": 50933592,
"domNodes": 167,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.540999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 459.4130000000405,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.999,
"layouts": 5,
"layoutDurationMs": 1.2000000000000002,
"taskDurationMs": 119.17499999999997,
"heapDeltaBytes": 4989144,
"heapUsedBytes": 50570484,
"domNodes": 155,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.049,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 455.23100000002614,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.511999999999997,
"layouts": 5,
"layoutDurationMs": 1.3070000000000002,
"taskDurationMs": 127.333,
"heapDeltaBytes": 5029908,
"heapUsedBytes": 56642060,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.621999999999993,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@eslint.config.ts`:
- Around line 473-477: The import restriction currently lists only the wildcard
pattern '@e2e/helpers/*' which allows direct imports from '@e2e/helpers'; update
the restriction entries that reference '@e2e/helpers/*' (the group arrays shown)
to include the bare module name '@e2e/helpers' alongside the wildcard, and make
the same change for the other identical restriction further down so both places
block direct and subpath imports and keep the existing message text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 18826955-80b3-447f-8430-cdc347e03fc4
📒 Files selected for processing (38)
.claude/skills/perf-fix-with-proof/SKILL.mdbrowser_tests/AGENTS.mdbrowser_tests/README.mdbrowser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/components/Actionbar.tsbrowser_tests/fixtures/components/Templates.tsbrowser_tests/fixtures/helpers/ClipboardHelper.tsbrowser_tests/fixtures/helpers/DragDropHelper.tsbrowser_tests/fixtures/utils/boundsUtils.tsbrowser_tests/fixtures/utils/builderTestUtils.tsbrowser_tests/fixtures/utils/clipboardSpy.tsbrowser_tests/fixtures/utils/fitToView.tsbrowser_tests/fixtures/utils/litegraphUtils.tsbrowser_tests/fixtures/utils/manageGroupNode.tsbrowser_tests/fixtures/utils/mimeTypeUtil.tsbrowser_tests/fixtures/utils/painter.tsbrowser_tests/fixtures/utils/perfReporter.tsbrowser_tests/fixtures/utils/promotedWidgets.tsbrowser_tests/globalTeardown.tsbrowser_tests/tests/appModeArrange.spec.tsbrowser_tests/tests/appModePruning.spec.tsbrowser_tests/tests/appModeWidgetRename.spec.tsbrowser_tests/tests/builderReorder.spec.tsbrowser_tests/tests/builderSaveFlow.spec.tsbrowser_tests/tests/errorDialog.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/performance.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tsbrowser_tests/tests/selectionBoundingBox.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/imagePreview.spec.tseslint.config.ts
💤 Files with no reviewable changes (1)
- browser_tests/fixtures/utils/fitToView.ts
The wildcard pattern @e2e/helpers/* doesn't match a bare @e2e/helpers import (e.g. from a barrel index.ts). Add both patterns to fully prevent re-creating the removed helpers/ surface.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11411 +/- ##
===========================================
- Coverage 69.32% 51.47% -17.86%
===========================================
Files 1482 1374 -108
Lines 84455 70339 -14116
Branches 23043 18654 -4389
===========================================
- Hits 58551 36209 -22342
- Misses 24961 33531 +8570
+ Partials 943 599 -344
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
1. On the design intent and path consolidation: 2. On the approval and documentation: 3. On the remaining issues: Suggestion(non-block): A more stable boundary should be based on what the file itself is, rather than who imports it. The decision rule simplifies to a single flow: Is it a class? Benefit: e.g. If |
christian-byrne
left a comment
There was a problem hiding this comment.
Kaili suggested this:
1. On the design intent and path consolidation: I fully understand @DrJKL original design intent to place classes extracted from
ComfyPageintofixtures/helpers/; that approach was perfectly fine at the start. However, over time, the boundaries betweenbrowser_tests/helpers/andbrowser_tests/fixtures/helpers/have become blurred. This PR is resolving this duplicate setup.2. On the approval and documentation: LGTM. The key is that the updates to
AGENTS.mdand theREADMEhave been completed, which prevents any future references to the old paths. All tests passed manually & locally.3. On the remaining issues: A remaining issue is that the boundary for
fixtures/utils/is still vague. It is currently acting as acatch-allbucket for all files that are 'not wired intoComfyPage'."Suggestion(non-block): A more stable boundary should be based on what the file itself is, rather than who imports it. The decision rule simplifies to a single flow:
Is it a class? — Yes → Is it attached to ComfyPage? — Yes →
fixtures/helpers/— No →fixtures/components/— No (is a function) →fixtures/utils/Benefit: e.g. If
ManageGroupNodeis added toComfyPagein the future, the file would not have to be migrated again.
Is there anything to change about the PR to better adopt this suggested organization/semantics?
Move ManageGroupNode to fixtures/components/ (it's a page object class, not a utility function). Codify the placement rule in AGENTS.md: - Class wired into ComfyPage → fixtures/helpers/ - Standalone class → fixtures/components/ - Exported functions → fixtures/utils/
a90c0b7
christian-byrne
left a comment
There was a problem hiding this comment.
Now getting basic failures in playwright checks:
Error: Cannot find package '@e2e/helpers' imported from /__w/ComfyUI_frontend/ComfyUI_frontend/browser_tests/tests/bottomPanelLogs.spec.ts
and in the lint-and-format ci check:
> @comfyorg/comfyui-frontend@1.44.6 format:check /home/runner/work/ComfyUI_frontend/ComfyUI_frontend
> oxfmt --check
Checking formatting...
All matched files use the correct format.
Finished in 11755ms on 3066 files using 4 threads.
> @comfyorg/comfyui-frontend@1.44.6 knip /home/runner/work/ComfyUI_frontend/ComfyUI_frontend
> knip --cache
[log] Unlisted dependencies (1)
[log] @e2e/helpers/clipboardSpy browser_tests/tests/bottomPanelLogs.spec.ts:15:8
ELIFECYCLE Command failed with exit code 1.
Error: Process completed with exit code 1.
…r-tests-helpers-structure
New file merged from main still referenced the removed browser_tests/helpers/ path. Updated to @e2e/fixtures/utils/.
82b4b1a to
7b08f4c
Compare
|
I'd sort of want to delay merging this for a couple days/weeks to avoid forcing everyone to rebase |
DrJKL
left a comment
There was a problem hiding this comment.
Approving — this is a clean, scoped refactor that puts the right files in the right folders and locks the layout in with an ESLint rule. Two small inline suggestions:
- Placement Rule contradiction in
browser_tests/AGENTS.md. As written, every existingcomponents/class (Actionbar,ContextMenu,SettingDialog,Topbar, …) is wired intoComfyPageand would be routed tohelpers/by the rule. Suggested a Mermaid decision tree that keys off what the class owns (locators-for-a-region vs. cross-app actions), which matches the actual placement. fitToView.tsdocstring lost a useful rationale line that explains why this lives outsideComfyPage. Suggesting it back so future readers don't pull it into a helper class.
Nice touches:
- ESLint guard added in both
browser_testsandsrc/lib/litegraph/testblocks — symmetric and prevents regression. mimeTypeUtil.tscorrectly rehomed fromhelpers/toutils/(it was a pure function in the wrong folder pre-PR).- Cross-doc consistency caught —
perf-fix-with-proof/SKILL.mdreference table updated to the new path.
Before merge please confirm pnpm typecheck:browser + pnpm exec eslint browser_tests/ + a small e2e smoke (e.g. one app-mode + one subgraph spec) pass — path-alias mismatches sometimes only surface at runtime.
| ### Placement Rule | ||
|
|
||
| When adding a new file, use this decision flow: | ||
|
|
||
| 1. **Is it a class?** | ||
| - **Yes, and wired into `ComfyPage`** → `fixtures/helpers/` | ||
| - **Yes, but standalone** → `fixtures/components/` | ||
| - **No (exported functions)** → `fixtures/utils/` | ||
| 2. **Is it static data with no code?** → `fixtures/data/` |
There was a problem hiding this comment.
The decision flow as written contradicts the actual placement. Every page-object class in fixtures/components/ is wired into ComfyPage (actionbar, templates, settingDialog, contextMenu, topbar, sidebar tabs, …), so the first branch (Yes, and wired into ComfyPage → fixtures/helpers/) would route every future component there and leave components/ empty.
The real distinction (which the prose paragraph above already gets right) is what the class owns: locators for a specific UI region → components/; multi-region action coordination with no locator surface of its own → helpers/.
Suggested replacement using a Mermaid decision tree that keys off ownership instead of the misleading wired/standalone test:
| ### Placement Rule | |
| When adding a new file, use this decision flow: | |
| 1. **Is it a class?** | |
| - **Yes, and wired into `ComfyPage`** → `fixtures/helpers/` | |
| - **Yes, but standalone** → `fixtures/components/` | |
| - **No (exported functions)** → `fixtures/utils/` | |
| 2. **Is it static data with no code?** → `fixtures/data/` | |
| ### Placement Rule | |
| When adding a new file, use this decision tree: | |
| ```mermaid | |
| flowchart TD | |
| A[New file in browser_tests/fixtures/] --> B{Has any code?} | |
| B -- No, JSON/data only --> D[fixtures/data/] | |
| B -- Yes --> C{Is it a class?} | |
| C -- No, exported functions --> U[fixtures/utils/] | |
| C -- Yes --> E{Owns locators for a<br/>specific UI region?} | |
| E -- Yes --> P[fixtures/components/] | |
| E -- No, coordinates actions<br/>across the app --> H[fixtures/helpers/] | |
| ``` |
There was a problem hiding this comment.
You're right — the "wired into ComfyPage" test is misleading since components like Actionbar, ContextMenu, Topbar are all wired into ComfyPage too. The real distinction is ownership: locators for a UI region → components/, cross-region action coordination → helpers/.
Replaced the decision flow with your Mermaid diagram in b45ab6b.
| } | ||
|
|
||
| /** | ||
| * Instantly fits the canvas view to graph content without waiting for UI animation. |
There was a problem hiding this comment.
The removed line (Lives outside the shared fixture to keep the default ComfyPage interactions user-oriented.) explains why this isn't a method on CanvasHelper / ComfyPage. The reasoning is still valid after the move and worth keeping so a future reader doesn't fold it back into a helper class.
| * Instantly fits the canvas view to graph content without waiting for UI animation. | |
| * Instantly fits the canvas view to graph content without waiting for UI animation. | |
| * | |
| * Lives outside the shared fixture to keep the default ComfyPage interactions user-oriented. |
There was a problem hiding this comment.
Good call — restored in b45ab6b. The reasoning for why this isn't on CanvasHelper is still valid and worth keeping.
Replace misleading wired/standalone decision flow with ownership-based Mermaid diagram per DrJKL's review: classes that own locators for a UI region → components/, classes that coordinate across regions → helpers/. Restore the fitToView.ts docstring explaining why it lives outside CanvasHelper.
b45ab6b
Amp-Thread-ID: https://ampcode.com/threads/T-019dd1c0-dc07-72a9-babf-34e5c9f83389 Co-authored-by: Amp <amp@ampcode.com>
…pers-structure' into glary/refactor-browser-tests-helpers-structure
The helper was moved from browser_tests/tests/propertiesPanel/ to browser_tests/fixtures/helpers/ on main (PR #11411). The stale path caused 'Cannot find package @e2e/tests' in CI for all 6 tests.
Update @e2e/helpers/promotedWidgets to @e2e/fixtures/utils/promotedWidgets to match #11411 which moved browser_tests/helpers/ into fixtures/utils/.
*PR Created by the Glary-Bot Agent* --- ## Summary - Eliminates the confusing dual-helpers structure where `browser_tests/helpers/` and `browser_tests/fixtures/helpers/` coexisted one tier apart with overlapping purposes - Routes each file to its natural home based on what it actually *is*: page objects → `components/`, standalone utils → `utils/`, domain helper classes stay in `helpers/` - Adds an ESLint guard (`no-restricted-imports`) to prevent re-creating `browser_tests/helpers/` ## File Moves | File | From | To | Reason | |---|---|---|---| | `actionbar.ts` | `helpers/` | `fixtures/components/Actionbar.ts` | Page object class imported by ComfyPage | | `templates.ts` | `helpers/` | `fixtures/components/Templates.ts` | Page object class imported by ComfyPage | | `boundsUtils.ts` | `fixtures/helpers/` | `fixtures/utils/` | Pure function, not a helper class | | `mimeTypeUtil.ts` | `fixtures/helpers/` | `fixtures/utils/` | Pure function, not a helper class | | `builderTestUtils.ts` | `helpers/` | `fixtures/utils/` | Shared test setup functions | | `clipboardSpy.ts` | `helpers/` | `fixtures/utils/` | Page injection utility | | `fitToView.ts` | `helpers/` | `fixtures/utils/` | Canvas utility function | | `manageGroupNode.ts` | `helpers/` | `fixtures/utils/` | Litegraph interaction helper | | `painter.ts` | `helpers/` | `fixtures/utils/` | Test helper functions | | `perfReporter.ts` | `helpers/` | `fixtures/utils/` | Test infrastructure | | `promotedWidgets.ts` | `helpers/` | `fixtures/utils/` | Query helpers for specs | ## What Changed Beyond File Moves - **28 import statements** updated across test specs, fixtures, and infra files - **AGENTS.md** — directory tree diagram and architectural separation descriptions updated - **README.md** — "Leverage Existing Fixtures and Helpers" section updated - **`.claude/skills/perf-fix-with-proof/SKILL.md`** — perfReporter path reference updated - **`eslint.config.ts`** — added `@e2e/helpers/*` restricted import pattern to both spec and non-spec browser_tests rules ## Verification - `pnpm typecheck` — clean - `pnpm typecheck:browser` — clean - `pnpm lint` — 0 errors, 0 warnings - `pnpm format:check` — all files formatted - `pnpm knip` — clean - Pre-commit hooks passed full pipeline (oxfmt, oxlint, eslint, typecheck, typecheck:browser) ## Config Audit No changes needed to: `tsconfig.json` (`@e2e/*` alias covers all subdirs), `playwright.config.ts`, `vite.config.mts`, `knip.config.ts`, `.oxlintrc.json`, `nx.json` ## Manual Verification Note This is a pure structural refactoring (file moves + import updates) with zero behavioral or visual changes. The typecheck and lint passes confirm all imports resolve correctly. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11411-refactor-consolidate-browser_tests-helpers-into-fixtures-3476d73d3650816cb671ef7fa8433f66) by [Unito](https://www.unito.io) --------- Co-authored-by: glary-bot <glary-bot@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: DrJKL <DrJKL0424@gmail.com> Co-authored-by: Amp <amp@ampcode.com>
Resolve conflicts against declared integration head 3517e14: - browser_tests/tests/performance.spec.ts: take main's version. Main already has the equivalent 'large graph viewport pan sweep' test (added in #10479, refactored to use canvasOps.panSweep() helper in #11411) plus 'large graph legacy node drag' and 'large graph zoom interaction' (#10478) that this branch's last commit (3517e14) had already reverted to defer to. - src/components/graph/GraphCanvas.vue: main replaced the useVueNodeLifecycle/VueNodeData node source with nodeDataStore/ NodeState (node-data-store migration, unrelated to this PR). Rebased viewport culling on top of the new source: - rawNodes now reads from nodeDataStore.getGraphNodesFor() instead of the removed vueNodeLifecycle.nodeManager. - useViewportCulling's type changed from VueNodeData[] to NodeState[] (both carry .id, otherwise unrelated shapes). - layoutStore.getAllNodes() (bulk map) no longer exists on main; every other consumer of layout data now uses the per-node layoutStore.getNodeLayout(rootGraphId, nodeId) lookup, so useViewportCulling was rewired to do the same, keyed off a new rootGraphId prop, and to react to layoutStore.nodeGeometryVersion instead of watching a bulk layout map. - useTransformState().isNodeInViewport did not exist on main (the composable's own doc comment calls out viewport culling as a design goal, so this is its natural home) - added it: converts a node's canvas-space position/size to screen space via the existing camera transform and tests for overlap with the margined viewport rect, matching the mapping already used by transformStyle. - Updated useViewportCulling.test.ts to mock layoutStore.getNodeLayout and layoutStore.nodeGeometryVersion instead of passing a raw layouts map, and to build NodeState fixtures instead of VueNodeData. Also dropped two vi.clearAllMocks()/vi.useRealTimers() calls now redundant per the project's vitest setup (comfy/no-redundant-vitest-cleanup).
PR Created by the Glary-Bot Agent
Summary
browser_tests/helpers/andbrowser_tests/fixtures/helpers/coexisted one tier apart with overlapping purposescomponents/, standalone utils →utils/, domain helper classes stay inhelpers/no-restricted-imports) to prevent re-creatingbrowser_tests/helpers/File Moves
actionbar.tshelpers/fixtures/components/Actionbar.tstemplates.tshelpers/fixtures/components/Templates.tsboundsUtils.tsfixtures/helpers/fixtures/utils/mimeTypeUtil.tsfixtures/helpers/fixtures/utils/builderTestUtils.tshelpers/fixtures/utils/clipboardSpy.tshelpers/fixtures/utils/fitToView.tshelpers/fixtures/utils/manageGroupNode.tshelpers/fixtures/utils/painter.tshelpers/fixtures/utils/perfReporter.tshelpers/fixtures/utils/promotedWidgets.tshelpers/fixtures/utils/What Changed Beyond File Moves
.claude/skills/perf-fix-with-proof/SKILL.md— perfReporter path reference updatedeslint.config.ts— added@e2e/helpers/*restricted import pattern to both spec and non-spec browser_tests rulesVerification
pnpm typecheck— cleanpnpm typecheck:browser— cleanpnpm lint— 0 errors, 0 warningspnpm format:check— all files formattedpnpm knip— cleanConfig Audit
No changes needed to:
tsconfig.json(@e2e/*alias covers all subdirs),playwright.config.ts,vite.config.mts,knip.config.ts,.oxlintrc.json,nx.jsonManual Verification Note
This is a pure structural refactoring (file moves + import updates) with zero behavioral or visual changes. The typecheck and lint passes confirm all imports resolve correctly.
┆Issue is synchronized with this Notion page by Unito