Repository navigation
test: reorganize subgraph E2E tests into domain-organized directory - #10695
Conversation
Restructure 17 flat spec files into 10 domain-organized files under browser_tests/tests/subgraph/, grouped by behavioral concern: - subgraphSlots: I/O CRUD, rename, alignment, slot position - subgraphCrud: create, delete, copy, unpack - subgraphOperations: copy/paste and undo/redo inside subgraphs - subgraphNavigation: breadcrumb, viewport, hotkeys, progress state - subgraphPromotion: auto-promote, visibility, reactivity, context menu - subgraphPromotionDom: DOM widget persistence, cleanup, positioning - subgraphSerialization: hydration, round-trip, legacy formats, ID remap - subgraphNested: configure order, duplicate names, pack values - subgraphLifecycle: source removal cleanup, pseudo-preview lifecycle - subgraphSearch: search aliases, description, persistence No test logic changes. All 96 test cases preserved with original names. Consistent camelCase naming. Follows existing subdirectory pattern (vueNodes/, sidebar/). Amp-Thread-ID: https://ampcode.com/threads/T-019d3709-4138-737c-bad2-7220f6fd6fce Co-authored-by: Amp <amp@ampcode.com>
🎨 Storybook: ✅ Built — View Storybook |
📝 WalkthroughWalkthroughRestructured subgraph browser test suite by consolidating dispersed test files into an organized Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 765 passed, 0 failed · 3 flaky📊 Browser Reports
|
📦 Bundle: 5.09 MB gzip 🔴 +141 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.14 MB (baseline 1.14 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 484 kB (baseline 484 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 12 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.96 MB (baseline 2.96 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 334 kB (baseline 334 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 12 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.43 MB (baseline 8.43 MB) • ⚪ 0 BBundles that do not match a named category
Status: 55 added / 55 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-03-29T01:23:53.073Z",
"gitSha": "3e2549a79506b17d1d274836cbd82709615fb960",
"branch": "drjkl/test/subgraphs-2-take-2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.9519999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.866000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.061,
"heapDeltaBytes": 20208068,
"heapUsedBytes": 63053068,
"domNodes": 20,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 23.680000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-idle",
"durationMs": 2006.3410000000204,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.29699999999997,
"heapDeltaBytes": 20320556,
"heapUsedBytes": 62852296,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 25.585,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "canvas-idle",
"durationMs": 2039.4390000000158,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.29,
"heapDeltaBytes": 20996152,
"heapUsedBytes": 63413036,
"domNodes": 22,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 26.362000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2096.216999999996,
"styleRecalcs": 83,
"styleRecalcDurationMs": 50.39300000000001,
"layouts": 12,
"layoutDurationMs": 3.806,
"taskDurationMs": 1100.7610000000002,
"heapDeltaBytes": 16988492,
"heapUsedBytes": 59692604,
"domNodes": 65,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 158.864,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2023.2690000000275,
"styleRecalcs": 81,
"styleRecalcDurationMs": 43.564,
"layouts": 12,
"layoutDurationMs": 3.376,
"taskDurationMs": 997.5820000000001,
"heapDeltaBytes": 16295960,
"heapUsedBytes": 58809516,
"domNodes": 66,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 138.84600000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.65199999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.514,
"layouts": 12,
"layoutDurationMs": 3.3790000000000004,
"taskDurationMs": 756.5880000000001,
"heapDeltaBytes": 15819684,
"heapUsedBytes": 58395056,
"domNodes": 58,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 134.51100000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.0050000000483,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.861,
"layouts": 6,
"layoutDurationMs": 0.603,
"taskDurationMs": 326.27000000000004,
"heapDeltaBytes": 24641964,
"heapUsedBytes": 67375908,
"domNodes": 79,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 28.023,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1130000000262,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.496000000000006,
"layouts": 6,
"layoutDurationMs": 0.6249999999999999,
"taskDurationMs": 321.91999999999996,
"heapDeltaBytes": 24676688,
"heapUsedBytes": 67170372,
"domNodes": 80,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 28.613,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.6410000000633,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.487,
"layouts": 6,
"layoutDurationMs": 0.6480000000000001,
"taskDurationMs": 333.30099999999993,
"heapDeltaBytes": 15388940,
"heapUsedBytes": 67142836,
"domNodes": 80,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 28.039,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "dom-widget-clipping",
"durationMs": 630.3900000000056,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.22299999999996,
"heapDeltaBytes": 6029964,
"heapUsedBytes": 48965004,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 70.77199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "dom-widget-clipping",
"durationMs": 581.1160000000086,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.989999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.31,
"heapDeltaBytes": 6600032,
"heapUsedBytes": 48997164,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 71.533,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "dom-widget-clipping",
"durationMs": 532.2910000001002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.331,
"heapDeltaBytes": -3165592,
"heapUsedBytes": 49063876,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 59.840999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2022.6669999999842,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.534999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.2969999999999,
"heapDeltaBytes": 5134512,
"heapUsedBytes": 55920744,
"domNodes": -259,
"jsHeapTotalBytes": 16453632,
"scriptDurationMs": 112.59899999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "large-graph-idle",
"durationMs": 2036.4270000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.442,
"heapDeltaBytes": 5486448,
"heapUsedBytes": 56232464,
"domNodes": -259,
"jsHeapTotalBytes": 16453632,
"scriptDurationMs": 111.088,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-idle",
"durationMs": 2038.1909999999834,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.096000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.078,
"heapDeltaBytes": 4688664,
"heapUsedBytes": 55494080,
"domNodes": -259,
"jsHeapTotalBytes": 16715776,
"scriptDurationMs": 110.328,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "large-graph-pan",
"durationMs": 2175.542999999976,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.630999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1149.8519999999999,
"heapDeltaBytes": 21073944,
"heapUsedBytes": 72944704,
"domNodes": -259,
"jsHeapTotalBytes": 17707008,
"scriptDurationMs": 418.214,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-pan",
"durationMs": 2158.0490000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1127.055,
"heapDeltaBytes": 16661948,
"heapUsedBytes": 68906012,
"domNodes": -258,
"jsHeapTotalBytes": 17707008,
"scriptDurationMs": 408.799,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-pan",
"durationMs": 2156.9670000000087,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1105.181,
"heapDeltaBytes": 18547160,
"heapUsedBytes": 70893744,
"domNodes": -257,
"jsHeapTotalBytes": 18493440,
"scriptDurationMs": 410.509,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-zoom",
"durationMs": 3160.5950000000007,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.786,
"layouts": 60,
"layoutDurationMs": 7.393999999999999,
"taskDurationMs": 1360.7589999999998,
"heapDeltaBytes": 3839960,
"heapUsedBytes": 58367356,
"domNodes": -266,
"jsHeapTotalBytes": 17240064,
"scriptDurationMs": 502.31000000000006,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "large-graph-zoom",
"durationMs": 3198.7799999999993,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.595,
"layouts": 60,
"layoutDurationMs": 7.355,
"taskDurationMs": 1401.426,
"heapDeltaBytes": 11041720,
"heapUsedBytes": 66327056,
"domNodes": -266,
"jsHeapTotalBytes": 16977920,
"scriptDurationMs": 548.624,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "large-graph-zoom",
"durationMs": 3134.809999999902,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.288,
"layouts": 60,
"layoutDurationMs": 7.426,
"taskDurationMs": 1333.301,
"heapDeltaBytes": 8989888,
"heapUsedBytes": 64224288,
"domNodes": -268,
"jsHeapTotalBytes": 15142912,
"scriptDurationMs": 495.988,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "minimap-idle",
"durationMs": 2034.9630000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.7010000000001,
"heapDeltaBytes": 15218580,
"heapUsedBytes": 69325028,
"domNodes": -260,
"jsHeapTotalBytes": 14938112,
"scriptDurationMs": 110.08999999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "minimap-idle",
"durationMs": 2021.8580000000088,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.334000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.802,
"heapDeltaBytes": 4210236,
"heapUsedBytes": 56469728,
"domNodes": -261,
"jsHeapTotalBytes": 16191488,
"scriptDurationMs": 113.926,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "minimap-idle",
"durationMs": 2021.983999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.522000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.8069999999999,
"heapDeltaBytes": 4070044,
"heapUsedBytes": 56208096,
"domNodes": -260,
"jsHeapTotalBytes": 16715776,
"scriptDurationMs": 111.936,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.5950000000348,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.057000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.138,
"heapDeltaBytes": 6482744,
"heapUsedBytes": 49487268,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 123.054,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.5279999999821,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.015,
"heapDeltaBytes": 6452472,
"heapUsedBytes": 49506144,
"domNodes": 21,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 123.803,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.8790000000517,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.54600000000005,
"heapDeltaBytes": 6461204,
"heapUsedBytes": 49471504,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 126.22500000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999
},
{
"name": "subgraph-idle",
"durationMs": 2004.8389999999756,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.706999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.973,
"heapDeltaBytes": 19898436,
"heapUsedBytes": 62924308,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.654,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-idle",
"durationMs": 1994.3719999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.667,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.333,
"heapDeltaBytes": 19929356,
"heapUsedBytes": 62920916,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.081,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-idle",
"durationMs": 2001.6440000000557,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.07,
"heapDeltaBytes": 19891628,
"heapUsedBytes": 62898048,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 21.987,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.4589999999769,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.061,
"layouts": 16,
"layoutDurationMs": 4.748,
"taskDurationMs": 690.004,
"heapDeltaBytes": 11453048,
"heapUsedBytes": 54524660,
"domNodes": 63,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 96.85100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1976.3269999999693,
"styleRecalcs": 84,
"styleRecalcDurationMs": 46.534,
"layouts": 16,
"layoutDurationMs": 4.543,
"taskDurationMs": 915.434,
"heapDeltaBytes": 12187192,
"heapUsedBytes": 55300904,
"domNodes": 72,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 102.42099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1976.9189999999526,
"styleRecalcs": 84,
"styleRecalcDurationMs": 47.898999999999994,
"layouts": 16,
"layoutDurationMs": 4.595,
"taskDurationMs": 909.991,
"heapDeltaBytes": 11783624,
"heapUsedBytes": 54536200,
"domNodes": 74,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 105.709,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.179999999993,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.83100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3880.5239999999994,
"heapDeltaBytes": 21715504,
"heapUsedBytes": 72127016,
"domNodes": -256,
"jsHeapTotalBytes": 20590592,
"scriptDurationMs": 1278.455,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68000000000011
},
{
"name": "viewport-pan-sweep",
"durationMs": 8161.468999999954,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3743.0229999999997,
"heapDeltaBytes": 25783276,
"heapUsedBytes": 76284060,
"domNodes": -256,
"jsHeapTotalBytes": 19017728,
"scriptDurationMs": 1260.9550000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.5640000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3818.1710000000003,
"heapDeltaBytes": 26953104,
"heapUsedBytes": 77582964,
"domNodes": -258,
"jsHeapTotalBytes": 19279872,
"scriptDurationMs": 1275.719,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 12664.964999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12651.139000000001,
"heapDeltaBytes": -42179152,
"heapUsedBytes": 166029880,
"domNodes": -8332,
"jsHeapTotalBytes": 29712384,
"scriptDurationMs": 615.444,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.340000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 12476.492000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12464.059,
"heapDeltaBytes": -46925012,
"heapUsedBytes": 165272292,
"domNodes": -8331,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 644.64,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33000000000029
},
{
"name": "vue-large-graph-idle",
"durationMs": 12514.287999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12489.014000000001,
"heapDeltaBytes": -38047328,
"heapUsedBytes": 157990892,
"domNodes": -8331,
"jsHeapTotalBytes": 18440192,
"scriptDurationMs": 601.8489999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.009999999999856
},
{
"name": "vue-large-graph-pan",
"durationMs": 14616.03100000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.647000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14590.115000000002,
"heapDeltaBytes": -45834976,
"heapUsedBytes": 147966700,
"domNodes": -8331,
"jsHeapTotalBytes": -2007040,
"scriptDurationMs": 881.5799999999999,
"eventListeners": -16486,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.340000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 14416.479999999978,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.30999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14394.862,
"heapDeltaBytes": -29063180,
"heapUsedBytes": 165150320,
"domNodes": -8331,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 953.322,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20
},
{
"name": "vue-large-graph-pan",
"durationMs": 14952.842000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.70699999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14928.715,
"heapDeltaBytes": -22415476,
"heapUsedBytes": 171528156,
"domNodes": -8333,
"jsHeapTotalBytes": -14675968,
"scriptDurationMs": 984.1309999999999,
"eventListeners": -16459,
"totalBlockingTimeMs": 51,
"frameDurationMs": 19.990000000000144
},
{
"name": "workflow-execution",
"durationMs": 442.85999999999603,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.647000000000002,
"layouts": 4,
"layoutDurationMs": 1.1280000000000001,
"taskDurationMs": 118.599,
"heapDeltaBytes": 4610076,
"heapUsedBytes": 48426928,
"domNodes": 169,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.354000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999
},
{
"name": "workflow-execution",
"durationMs": 441.94899999990866,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.903,
"layouts": 5,
"layoutDurationMs": 1.336,
"taskDurationMs": 129.548,
"heapDeltaBytes": 4555428,
"heapUsedBytes": 48453452,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.238,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999
},
{
"name": "workflow-execution",
"durationMs": 445.74199999999564,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.041999999999998,
"layouts": 5,
"layoutDurationMs": 1.3229999999999997,
"taskDurationMs": 121.553,
"heapDeltaBytes": 4508264,
"heapUsedBytes": 48066040,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.856999999999996,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (5)
browser_tests/tests/subgraph/subgraphSlots.spec.ts (2)
340-341: Redundantfill('')beforefill(value)calls.Playwright's
fill()method automatically clears the input before typing. The explicitfill('')call is unnecessary and can be removed throughout the file.♻️ Remove redundant clear calls
// Clear and enter new name - await comfyPage.page.fill(SELECTORS.promptDialog, '') await comfyPage.page.fill(SELECTORS.promptDialog, RENAMED_NAME)This pattern appears at lines 340-341, 387-388, 432-433, 524-525, and 740-741.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSlots.spec.ts` around lines 340 - 341, Remove the redundant explicit clears before filling inputs: wherever comfyPage.page.fill(SELECTORS.promptDialog, '') is immediately followed by comfyPage.page.fill(SELECTORS.promptDialog, <value>) (e.g., the pairs using RENAMED_NAME and other values), delete the first comfyPage.page.fill(..., '') call since Playwright's fill() already clears the field; update occurrences at the noted repetitive locations so only the single comfyPage.page.fill(SELECTORS.promptDialog, <value>) remains.
138-142: Consider using Locator-based waiting for the prompt dialog.While
waitForSelectorworks, Playwright best practices prefer using Locator methods for better auto-waiting and retry behavior. However, since.graphdialog inputis a LiteGraph legacy dialog, the current approach is acceptable if the Locator pattern doesn't work well with dynamic canvas dialogs.♻️ Optional: Locator-based alternative
- await comfyPage.page.waitForSelector(SELECTORS.promptDialog, { - state: 'visible' - }) - await comfyPage.page.fill(SELECTORS.promptDialog, RENAMED_INPUT_NAME) + const promptDialog = comfyPage.page.locator(SELECTORS.promptDialog) + await promptDialog.waitFor({ state: 'visible' }) + await promptDialog.fill(RENAMED_INPUT_NAME)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSlots.spec.ts` around lines 138 - 142, Replace the selector-based wait/fill/keyboard sequence with Locator-based operations: create a Locator from SELECTORS.promptDialog (via comfyPage.page.locator), use the Locator's waitFor or .waitFor({state:'visible'}) to await visibility, then call the Locator's fill with RENAMED_INPUT_NAME and use the Locator.press('Enter') instead of comfyPage.page.keyboard.press; if the legacy LiteGraph dialog proves incompatible with Locator behavior, keep the existing page-based approach but add a brief comment explaining the fallback.browser_tests/tests/subgraph/subgraphNavigation.spec.ts (1)
388-393: Useexpect.poll()for this single-value wait.This block polls one
page.evaluate()result and makes one assertion, soexpect.poll()is the simpler retry primitive and matches the repo guidance.Suggested change
- await expect(async () => { - const progressAfter = await comfyPage.page.evaluate((nodeId) => { - return window.app!.canvas.graph!.getNodeById(nodeId)!.progress - }, subgraphNodeId!) - expect(progressAfter).toBeUndefined() - }).toPass({ timeout: 2_000 }) + await expect + .poll( + () => + comfyPage.page.evaluate( + (nodeId) => window.app!.canvas.graph!.getNodeById(nodeId)!.progress, + subgraphNodeId + ), + { timeout: 2_000 } + ) + .toBeUndefined()As per coding guidelines "Prefer
expect.poll()overexpect(async () => { ... }).toPass()when the block contains a single async call with a single assertion".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphNavigation.spec.ts` around lines 388 - 393, Replace the toPass retry wrapper with expect.poll: call expect.poll(() => comfyPage.page.evaluate(nodeId => window.app!.canvas.graph!.getNodeById(nodeId)!.progress, subgraphNodeId!)) and assert the polled value is undefined using .toBeUndefined(), ensuring you reference comfyPage.page.evaluate, window.app!.canvas.graph!.getNodeById and subgraphNodeId and use expect.poll() with an appropriate timeout.browser_tests/tests/subgraph/subgraphNested.spec.ts (1)
130-130: Avoid asserting promoted state through a CSS class.This regression is currently coupled to
ring-component-node-widget-promoted, so a harmless styling/class refactor can fail the test without changing the promoted behavior. Please expose a semantic hook for the promoted state and assert that instead.As per coding guidelines "Do not write tests dependent on non-behavioral features like utility classes or styles".
Also applies to: 231-250
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphNested.spec.ts` at line 130, The test currently asserts promoted state by checking the CSS class constant PROMOTED_BORDER_CLASS; instead expose and assert a semantic hook (for example a data-promoted="true"/aria attribute or a dedicated DOM role) on the promoted node and update the test to query that attribute rather than the class; change the assertions around PROMOTED_BORDER_CLASS (including occurrences around lines ~231-250) to check the semantic attribute (e.g., getByTestId/getAttribute or getAttribute('data-promoted')/toBe('true')) and, if needed, add the corresponding attribute in the component rendering logic so the promoted state is represented by a stable, behavioral hook instead of a styling class.browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
288-292: Preferexpect.pollfor this single-call retry assertion.This block retries one async read with one assertion, so
expect.pollis the simpler/idiomatic form here.♻️ Proposed refactor
- await expect(async () => { - const afterSnapshot = - await comfyPage.subgraph.getHostPromotedTupleSnapshot() - expect(afterSnapshot).toEqual(beforeSnapshot) - }).toPass({ timeout: 5_000 }) + await expect + .poll( + async () => comfyPage.subgraph.getHostPromotedTupleSnapshot(), + { timeout: 5_000 } + ) + .toEqual(beforeSnapshot)As per coding guidelines: "Prefer
expect.poll()overexpect(async () => { ... }).toPass()when the block contains a single async call with a single assertion".🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 288 - 292, Replace the retry wrapper that uses expect(...).toPass with expect.poll: call expect.poll(() => comfyPage.subgraph.getHostPromotedTupleSnapshot(), { timeout: 5_000 }) and assert the polled value equals beforeSnapshot; locate the call to comfyPage.subgraph.getHostPromotedTupleSnapshot and the beforeSnapshot variable and change the assertion to use expect.poll with the same timeout so the single async read + assertion uses the idiomatic expect.poll API.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/tests/subgraph/subgraphNavigation.spec.ts`:
- Around line 261-274: The test currently mutates app state directly by calling
canvas.setGraph(...) inside comfyPage.page.evaluate which bypasses the real user
navigation flow; replace this direct mutation with the real entry interaction by
invoking the existing navigation helper (e.g., navigateIntoSubgraph or the
CanvasHelper/ComfyMouse method that simulates clicking the subgraph node) so the
test exercises the actual navigation path and first-visit fit behavior; locate
the block that finds sgNode and remove the canvas.setGraph call, and instead
call the helper that performs the UI click/enter action on that subgraph node
(ensuring any helper receives the same node reference or an identifying
selector) so the viewport test uses the proper user-driven flow.
In `@browser_tests/tests/subgraph/subgraphNested.spec.ts`:
- Around line 105-110: The test currently only excludes status 400 which lets
other error statuses (500/503) pass; update the assertion after
comfyPage.page.waitForResponse('**/api/prompt') and
comfyPage.command.executeCommand('Comfy.QueuePrompt') to assert a successful
HTTP status range instead (e.g., use response.ok() or assert response.status()
is between 200 and 299) so any non-2xx prompt responses cause the test to fail.
In `@browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts`:
- Around line 174-176: The test is using index-based lookup
window.app!.canvas.graph!.nodes[0] which is brittle; update the
comfyPage.page.evaluate call to locate the node by id (use subgraphNode.id)
instead of index — e.g., find the node where node.id === subgraphNode.id and
then return node.widgets?.length || 0 so the cleanup validation targets the
correct subgraph node; reference the existing symbols comfyPage.page.evaluate,
window.app!.canvas.graph!.nodes and subgraphNode.id when making the change.
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 419-430: The test "Promoted widget value is editable as a text
input" currently only checks visibility; update it to actually mutate the input
and assert the new value to verify editability: locate the node via
comfyPage.vueNodes.getNodeLocator('5') and the textbox with getByRole('textbox',
{ name: 'string_a' }), then perform a user input action (e.g., fill/type) on
that textbox and assert the value changed (e.g., expect(...).toHaveValue(...) or
checking .inputValue()) instead of only expect(...).toBeVisible().
- Around line 200-206: This test duplicates the Alt+drag "clone node" mouse
choreography found in many specs; extract it into a reusable helper (e.g., add
ComfyMouse.dragWithModifier(page, startPos, endPos, modifier) or
NodeOperationsHelper.cloneDragAndDrop(comfyPage, startPos, endPos)) that
performs moving the mouse to start, keydown(modifier), mouse.down(),
nextFrame(), mouse.move() to end, mouse.up(), and keyup(modifier); replace the
inline sequence in subgraphSerialization.spec.ts (and other specs) with a single
call to the new helper (use the existing comfyPage or page object names to
locate where to add and call the helper).
---
Nitpick comments:
In `@browser_tests/tests/subgraph/subgraphNavigation.spec.ts`:
- Around line 388-393: Replace the toPass retry wrapper with expect.poll: call
expect.poll(() => comfyPage.page.evaluate(nodeId =>
window.app!.canvas.graph!.getNodeById(nodeId)!.progress, subgraphNodeId!)) and
assert the polled value is undefined using .toBeUndefined(), ensuring you
reference comfyPage.page.evaluate, window.app!.canvas.graph!.getNodeById and
subgraphNodeId and use expect.poll() with an appropriate timeout.
In `@browser_tests/tests/subgraph/subgraphNested.spec.ts`:
- Line 130: The test currently asserts promoted state by checking the CSS class
constant PROMOTED_BORDER_CLASS; instead expose and assert a semantic hook (for
example a data-promoted="true"/aria attribute or a dedicated DOM role) on the
promoted node and update the test to query that attribute rather than the class;
change the assertions around PROMOTED_BORDER_CLASS (including occurrences around
lines ~231-250) to check the semantic attribute (e.g., getByTestId/getAttribute
or getAttribute('data-promoted')/toBe('true')) and, if needed, add the
corresponding attribute in the component rendering logic so the promoted state
is represented by a stable, behavioral hook instead of a styling class.
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 288-292: Replace the retry wrapper that uses expect(...).toPass
with expect.poll: call expect.poll(() =>
comfyPage.subgraph.getHostPromotedTupleSnapshot(), { timeout: 5_000 }) and
assert the polled value equals beforeSnapshot; locate the call to
comfyPage.subgraph.getHostPromotedTupleSnapshot and the beforeSnapshot variable
and change the assertion to use expect.poll with the same timeout so the single
async read + assertion uses the idiomatic expect.poll API.
In `@browser_tests/tests/subgraph/subgraphSlots.spec.ts`:
- Around line 340-341: Remove the redundant explicit clears before filling
inputs: wherever comfyPage.page.fill(SELECTORS.promptDialog, '') is immediately
followed by comfyPage.page.fill(SELECTORS.promptDialog, <value>) (e.g., the
pairs using RENAMED_NAME and other values), delete the first
comfyPage.page.fill(..., '') call since Playwright's fill() already clears the
field; update occurrences at the noted repetitive locations so only the single
comfyPage.page.fill(SELECTORS.promptDialog, <value>) remains.
- Around line 138-142: Replace the selector-based wait/fill/keyboard sequence
with Locator-based operations: create a Locator from SELECTORS.promptDialog (via
comfyPage.page.locator), use the Locator's waitFor or
.waitFor({state:'visible'}) to await visibility, then call the Locator's fill
with RENAMED_INPUT_NAME and use the Locator.press('Enter') instead of
comfyPage.page.keyboard.press; if the legacy LiteGraph dialog proves
incompatible with Locator behavior, keep the existing page-based approach but
add a brief comment explaining the fallback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5ef6f2aa-b844-4c8f-938a-c0704f091463
📒 Files selected for processing (24)
browser_tests/tests/subgraph-duplicate-ids.spec.tsbrowser_tests/tests/subgraph-promoted-slot-position.spec.tsbrowser_tests/tests/subgraph-promoted-widget-dom.spec.tsbrowser_tests/tests/subgraph-rename-dialog.spec.tsbrowser_tests/tests/subgraph.spec.tsbrowser_tests/tests/subgraph/subgraphCrud.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphNested.spec.tsbrowser_tests/tests/subgraph/subgraphOperations.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/subgraphInputSlotRename.spec.tsbrowser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.tsbrowser_tests/tests/subgraphNestedConfigureOrder.spec.tsbrowser_tests/tests/subgraphNestedDuplicateWidgetNames.spec.tsbrowser_tests/tests/subgraphNestedPackValues.spec.tsbrowser_tests/tests/subgraphNestedStaleProxyWidgets.spec.tsbrowser_tests/tests/subgraphProgressClear.spec.tsbrowser_tests/tests/subgraphSlotAlignment.spec.tsbrowser_tests/tests/subgraphViewport.spec.ts
💤 Files with no reviewable changes (14)
- browser_tests/tests/subgraphNestedStaleProxyWidgets.spec.ts
- browser_tests/tests/subgraph-promoted-widget-dom.spec.ts
- browser_tests/tests/subgraphProgressClear.spec.ts
- browser_tests/tests/subgraphInputSlotRename.spec.ts
- browser_tests/tests/subgraph-duplicate-ids.spec.ts
- browser_tests/tests/subgraph-promoted-slot-position.spec.ts
- browser_tests/tests/subgraphNestedConfigureOrder.spec.ts
- browser_tests/tests/subgraphNestedDuplicateWidgetNames.spec.ts
- browser_tests/tests/subgraphSlotAlignment.spec.ts
- browser_tests/tests/subgraph-rename-dialog.spec.ts
- browser_tests/tests/subgraphLegacyPrefixedProxyWidgets.spec.ts
- browser_tests/tests/subgraphViewport.spec.ts
- browser_tests/tests/subgraph.spec.ts
- browser_tests/tests/subgraphNestedPackValues.spec.ts
| await comfyPage.page.evaluate(() => { | ||
| const canvas = window.app!.canvas | ||
| const graph = canvas.graph! | ||
| const sgNode = graph._nodes.find((n) => | ||
| 'isSubgraphNode' in n | ||
| ? ( | ||
| n as unknown as { isSubgraphNode: () => boolean } | ||
| ).isSubgraphNode() | ||
| : false | ||
| ) as unknown as { subgraph?: typeof graph } | undefined | ||
| if (!sgNode?.subgraph) throw new Error('No subgraph node') | ||
|
|
||
| canvas.setGraph(sgNode.subgraph) | ||
| }) |
There was a problem hiding this comment.
Use the real subgraph entry flow in this viewport test.
Lines 261-274 call canvas.setGraph() directly, which bypasses the navigation path this spec is supposed to verify. If navigateIntoSubgraph() stops triggering the first-visit fit behavior, this test can still pass because it mutates the canvas state underneath the app.
Suggested change
- await comfyPage.page.evaluate(() => {
- const canvas = window.app!.canvas
- const graph = canvas.graph!
- const sgNode = graph._nodes.find((n) =>
- 'isSubgraphNode' in n
- ? (
- n as unknown as { isSubgraphNode: () => boolean }
- ).isSubgraphNode()
- : false
- ) as unknown as { subgraph?: typeof graph } | undefined
- if (!sgNode?.subgraph) throw new Error('No subgraph node')
-
- canvas.setGraph(sgNode.subgraph)
- })
+ const subgraphNode = await comfyPage.nodeOps.getNodeRefById('11')
+ await subgraphNode.navigateIntoSubgraph()As per coding guidelines "Delegate page interactions to helper classes (ComfyMouse, VueNodeHelpers, CanvasHelper, CommandHelper, KeyboardHelper, NodeOperationsHelper, SettingsHelper, WorkflowHelper) rather than implementing interaction logic directly in tests".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/subgraph/subgraphNavigation.spec.ts` around lines 261 -
274, The test currently mutates app state directly by calling
canvas.setGraph(...) inside comfyPage.page.evaluate which bypasses the real user
navigation flow; replace this direct mutation with the real entry interaction by
invoking the existing navigation helper (e.g., navigateIntoSubgraph or the
CanvasHelper/ComfyMouse method that simulates clicking the subgraph node) so the
test exercises the actual navigation path and first-visit fit behavior; locate
the block that finds sgNode and remove the canvas.setGraph call, and instead
call the helper that performs the UI click/enter action on that subgraph node
(ensuring any helper receives the same node reference or an identifying
selector) so the viewport test uses the proper user-driven flow.
| const responsePromise = comfyPage.page.waitForResponse('**/api/prompt') | ||
|
|
||
| await comfyPage.command.executeCommand('Comfy.QueuePrompt') | ||
|
|
||
| const response = await responsePromise | ||
| expect(response.status()).not.toBe(400) |
There was a problem hiding this comment.
Fail this test on any prompt error status.
Lines 105-110 only exclude 400, so a 500 or 503 response still passes even though queueing failed. Assert a success range here so this regression does not go green on other server-side prompt failures.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/subgraph/subgraphNested.spec.ts` around lines 105 - 110,
The test currently only excludes status 400 which lets other error statuses
(500/503) pass; update the assertion after
comfyPage.page.waitForResponse('**/api/prompt') and
comfyPage.command.executeCommand('Comfy.QueuePrompt') to assert a successful
HTTP status range instead (e.g., use response.ok() or assert response.status()
is between 200 and 299) so any non-2xx prompt responses cause the test to fail.
| const widgetCount = await comfyPage.page.evaluate(() => { | ||
| return window.app!.canvas.graph!.nodes[0].widgets?.length || 0 | ||
| }) |
There was a problem hiding this comment.
Avoid index-based node lookup for cleanup validation
Line 175 uses graph.nodes[0], which can point to the wrong node if ordering changes. This can make the test pass/fail for the wrong reason. Resolve the node by subgraphNode.id instead.
Proposed fix
- const widgetCount = await comfyPage.page.evaluate(() => {
- return window.app!.canvas.graph!.nodes[0].widgets?.length || 0
- })
+ const subgraphNodeId = String(subgraphNode.id)
+ const widgetCount = await comfyPage.page.evaluate((nodeId) => {
+ const node = window.app!.canvas.graph!.nodes.find(
+ (graphNode) => String(graphNode.id) === nodeId
+ )
+ return node?.widgets?.length ?? 0
+ }, subgraphNodeId)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const widgetCount = await comfyPage.page.evaluate(() => { | |
| return window.app!.canvas.graph!.nodes[0].widgets?.length || 0 | |
| }) | |
| const subgraphNodeId = String(subgraphNode.id) | |
| const widgetCount = await comfyPage.page.evaluate((nodeId) => { | |
| const node = window.app!.canvas.graph!.nodes.find( | |
| (graphNode) => String(graphNode.id) === nodeId | |
| ) | |
| return node?.widgets?.length ?? 0 | |
| }, subgraphNodeId) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts` around lines 174 -
176, The test is using index-based lookup window.app!.canvas.graph!.nodes[0]
which is brittle; update the comfyPage.page.evaluate call to locate the node by
id (use subgraphNode.id) instead of index — e.g., find the node where node.id
=== subgraphNode.id and then return node.widgets?.length || 0 so the cleanup
validation targets the correct subgraph node; reference the existing symbols
comfyPage.page.evaluate, window.app!.canvas.graph!.nodes and subgraphNode.id
when making the change.
| await comfyPage.page.mouse.move(originalPos.x + 16, originalPos.y + 16) | ||
| await comfyPage.page.keyboard.down('Alt') | ||
| await comfyPage.page.mouse.down() | ||
| await comfyPage.nextFrame() | ||
| await comfyPage.page.mouse.move(originalPos.x + 72, originalPos.y + 72) | ||
| await comfyPage.page.mouse.up() | ||
| await comfyPage.page.keyboard.up('Alt') |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether a reusable helper already exists for clone/duplicate/alt-drag flows.
fd -i 'NodeOperationsHelper.ts' browser_tests
fd -i 'ComfyMouse.ts' browser_tests
rg -n -C3 -e 'clone|duplicate|alt|drag' browser_tests/fixtures browser_tests/tests/subgraph/subgraphSerialization.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 19273
🏁 Script executed:
cat -n browser_tests/fixtures/ComfyMouse.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 3188
🏁 Script executed:
rg -n 'keyboard.down.*Alt|keyboard\.down\([^)]*Alt' browser_tests --type tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 869
🏁 Script executed:
sed -n '100,115p' browser_tests/tests/copyPaste.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 660
🏁 Script executed:
sed -n '102,145p' browser_tests/tests/copyPaste.spec.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 1755
🏁 Script executed:
rg -n -B5 -A8 "keyboard.down\('Alt" browser_tests/tests/copyPaste.spec.ts | head -40Repository: Comfy-Org/ComfyUI_frontend
Length of output: 628
Extract Alt-drag (node cloning) interaction into a reusable helper method.
Lines 200-206 duplicate the low-level Alt+drag choreography found in 8 other test files across the codebase (copyPaste.spec.ts, interaction.spec.ts, linkInteraction.spec.ts, domWidget.spec.ts, rerouteNode.spec.ts, subgraphCrud.spec.ts, etc.). Extract this pattern into a dedicated method—either as ComfyMouse.dragWithModifier() or NodeOperationsHelper.cloneDragAndDrop()—to centralize the interaction semantics and reduce flake risk.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 200
- 206, This test duplicates the Alt+drag "clone node" mouse choreography found
in many specs; extract it into a reusable helper (e.g., add
ComfyMouse.dragWithModifier(page, startPos, endPos, modifier) or
NodeOperationsHelper.cloneDragAndDrop(comfyPage, startPos, endPos)) that
performs moving the mouse to start, keydown(modifier), mouse.down(),
nextFrame(), mouse.move() to end, mouse.up(), and keyup(modifier); replace the
inline sequence in subgraphSerialization.spec.ts (and other specs) with a single
call to the new helper (use the existing comfyPage or page object names to
locate where to add and call the helper).
| test('Promoted widget value is editable as a text input', async ({ | ||
| comfyPage | ||
| }) => { | ||
| await comfyPage.workflow.loadWorkflow(WORKFLOW) | ||
| await comfyPage.vueNodes.waitForNodes() | ||
|
|
||
| const outerNode = comfyPage.vueNodes.getNodeLocator('5') | ||
| const textarea = outerNode | ||
| .getByRole('textbox', { name: 'string_a' }) | ||
| .first() | ||
| await expect(textarea).toBeVisible() | ||
| }) |
There was a problem hiding this comment.
Test name says “editable”, but current assertion only checks visibility.
Line 419-Line 430 should actually mutate and assert value to verify editability; otherwise this can pass even for a read-only input.
✅ Minimal behavioral assertion
const outerNode = comfyPage.vueNodes.getNodeLocator('5')
const textarea = outerNode
.getByRole('textbox', { name: 'string_a' })
.first()
await expect(textarea).toBeVisible()
+ await textarea.fill('updated value')
+ await expect(textarea).toHaveValue('updated value')🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 419
- 430, The test "Promoted widget value is editable as a text input" currently
only checks visibility; update it to actually mutate the input and assert the
new value to verify editability: locate the node via
comfyPage.vueNodes.getNodeLocator('5') and the textbox with getByRole('textbox',
{ name: 'string_a' }), then perform a user input action (e.g., fill/type) on
that textbox and assert the value changed (e.g., expect(...).toHaveValue(...) or
checking .inputValue()) instead of only expect(...).toBeVisible().
|
Could also remove some redundancy, or I can do it as it's own PR. |
christian-byrne
left a comment
There was a problem hiding this comment.
LGTM -- verified no tests are removed and purely a refactor
…ted test subgraphSlotAlignment.spec.ts was moved to subgraph/subgraphSlots.spec.ts in #10695. Accept deletion and apply shared util to the new location.
…10695) ## Summary From the primordial entropy of 17 scattered spec files — a formless sprawl of mixed concerns and inconsistent naming — emerges a clean, domain-organized hierarchy. Order triumphs over chaos. ## Changes - **What**: Reorganize all subgraph E2E tests from 17 flat files in `browser_tests/tests/` into 10 domain-grouped files under `browser_tests/tests/subgraph/`. | File | Tests | Domain | |------|-------|--------| | `subgraphSlots` | 16 | I/O slot CRUD, rename, alignment, promoted slot position | | `subgraphPromotion` | 22 | Auto-promote, visibility, reactivity, context menu, cleanup | | `subgraphSerialization` | 16 | Hydration, round-trip, legacy formats, ID remapping | | `subgraphNavigation` | 10 | Breadcrumb, viewport, hotkeys, progress state | | `subgraphNested` | 9 | Configure order, duplicate names, pack values, stale proxies | | `subgraphLifecycle` | 7 | Source removal cleanup, pseudo-preview lifecycle | | `subgraphPromotionDom` | 6 | DOM widget persistence, cleanup, positioning | | `subgraphCrud` | 5 | Create, delete, copy, unpack | | `subgraphSearch` | 3 | Search aliases, description, persistence | | `subgraphOperations` | 2 | Copy/paste inside, undo/redo inside | Where once the monolith `subgraph.spec.ts` (856 lines) mixed slot CRUD with hotkeys, DOM widgets with navigation, and copy/paste with undo/redo — now each behavioral domain has its sovereign territory. Where once `subgraph-rename-dialog.spec.ts`, `subgraphInputSlotRename.spec.ts`, and `subgraph-promoted-slot-position.spec.ts` scattered rename concerns across three kingdoms — now they answer to one crown: `subgraphSlots.spec.ts`. Where once `kebab-case` and `camelCase` warred for dominion — now a single convention reigns. All 96 test cases preserved. Zero test logic changes. Purely structural. ## Review Focus - Verify no tests were lost in the consolidation - Confirm import paths all resolve correctly at the new depth (`../../fixtures/`) - The `import.meta.dirname` asset path in `subgraphSlots.spec.ts` (slot alignment test) updated for new directory depth ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10695-test-reorganize-subgraph-E2E-tests-into-domain-organized-directory-3326d73d36508197939be8825b69ea88) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
…10695) ## Summary From the primordial entropy of 17 scattered spec files — a formless sprawl of mixed concerns and inconsistent naming — emerges a clean, domain-organized hierarchy. Order triumphs over chaos. ## Changes - **What**: Reorganize all subgraph E2E tests from 17 flat files in `browser_tests/tests/` into 10 domain-grouped files under `browser_tests/tests/subgraph/`. | File | Tests | Domain | |------|-------|--------| | `subgraphSlots` | 16 | I/O slot CRUD, rename, alignment, promoted slot position | | `subgraphPromotion` | 22 | Auto-promote, visibility, reactivity, context menu, cleanup | | `subgraphSerialization` | 16 | Hydration, round-trip, legacy formats, ID remapping | | `subgraphNavigation` | 10 | Breadcrumb, viewport, hotkeys, progress state | | `subgraphNested` | 9 | Configure order, duplicate names, pack values, stale proxies | | `subgraphLifecycle` | 7 | Source removal cleanup, pseudo-preview lifecycle | | `subgraphPromotionDom` | 6 | DOM widget persistence, cleanup, positioning | | `subgraphCrud` | 5 | Create, delete, copy, unpack | | `subgraphSearch` | 3 | Search aliases, description, persistence | | `subgraphOperations` | 2 | Copy/paste inside, undo/redo inside | Where once the monolith `subgraph.spec.ts` (856 lines) mixed slot CRUD with hotkeys, DOM widgets with navigation, and copy/paste with undo/redo — now each behavioral domain has its sovereign territory. Where once `subgraph-rename-dialog.spec.ts`, `subgraphInputSlotRename.spec.ts`, and `subgraph-promoted-slot-position.spec.ts` scattered rename concerns across three kingdoms — now they answer to one crown: `subgraphSlots.spec.ts`. Where once `kebab-case` and `camelCase` warred for dominion — now a single convention reigns. All 96 test cases preserved. Zero test logic changes. Purely structural. ## Review Focus - Verify no tests were lost in the consolidation - Confirm import paths all resolve correctly at the new depth (`../../fixtures/`) - The `import.meta.dirname` asset path in `subgraphSlots.spec.ts` (slot alignment test) updated for new directory depth ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10695-test-reorganize-subgraph-E2E-tests-into-domain-organized-directory-3326d73d36508197939be8825b69ea88) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
Summary
From the primordial entropy of 17 scattered spec files — a formless sprawl of mixed concerns and inconsistent naming — emerges a clean, domain-organized hierarchy. Order triumphs over chaos.
Changes
browser_tests/tests/into 10 domain-grouped files underbrowser_tests/tests/subgraph/.subgraphSlotssubgraphPromotionsubgraphSerializationsubgraphNavigationsubgraphNestedsubgraphLifecyclesubgraphPromotionDomsubgraphCrudsubgraphSearchsubgraphOperationsWhere once the monolith
subgraph.spec.ts(856 lines) mixed slot CRUD with hotkeys, DOM widgets with navigation, and copy/paste with undo/redo — now each behavioral domain has its sovereign territory.Where once
subgraph-rename-dialog.spec.ts,subgraphInputSlotRename.spec.ts, andsubgraph-promoted-slot-position.spec.tsscattered rename concerns across three kingdoms — now they answer to one crown:subgraphSlots.spec.ts.Where once
kebab-caseandcamelCasewarred for dominion — now a single convention reigns.All 96 test cases preserved. Zero test logic changes. Purely structural.
Review Focus
../../fixtures/)import.meta.dirnameasset path insubgraphSlots.spec.ts(slot alignment test) updated for new directory depth┆Issue is synchronized with this Notion page by Unito