Repository navigation
Conversation
📝 WalkthroughWalkthroughAdds a ChangesCurly enforcement and control-flow formatting
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1665 passed, 0 failed · 3 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #12825 +/- ##
===========================================
- Coverage 76.13% 61.81% -14.33%
===========================================
Files 1568 1457 -111
Lines 99425 73802 -25623
Branches 28786 19550 -9236
===========================================
- Hits 75698 45621 -30077
- Misses 22923 27827 +4904
+ Partials 804 354 -450
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1073 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Enables the eslint/curly rule with ["multi-or-nest", "consistent"] options in .oxlintrc.json. Braces are required only for multi-line or nested blocks, with consistent brace use within if-else chains. All 3019 violations were resolved by oxlint --fix.
4c90fc2 to
0f549a9
Compare
|
Updated per feedback: switched the curly config from default This requires braces only for multi-line / nested blocks and enforces consistent brace use within Force-pushed: previous 897-file diff is replaced by a single commit with 820 files / -3,635 net lines. All 3019 violations under the new config were resolved entirely via Re-verified: oxlint, eslint, stylelint, oxfmt, vue-tsc, vite build all green. |
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (7)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)
107-123: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winUse the optional method call here.
isSubgraphNodeis treated as optional elsewhere in this file, buthostNode?.isSubgraphNode()will still throw if the method is absent. Use the optional call form to keep this helper safe.🔧 Proposed fix
- if (!hostNode?.isSubgraphNode()) { + if (!hostNode?.isSubgraphNode?.()) { return ids.map(() => false) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 107 - 123, The evaluate callback can still throw if isSubgraphNode is undefined because it is being invoked; change the invocation to use the optional call operator so the check is safe: replace the current call to hostNode?.isSubgraphNode() with hostNode?.isSubgraphNode?.() inside the evaluate closure (also ensure subsequent access to hostNode.subgraph is only reached when the optional call returned true). This targets the evaluate callback where hostNode and isSubgraphNode are used.browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts (1)
15-20: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winAvoid a module-scoped “future” timestamp here.
PUBLISHED_RECORD.publish_timecan age out during a slow test run and make the shared-state case look stale. Generate the timestamp per test or use a fixed far-future value instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts` around lines 15 - 20, The module-scoped PUBLISHED_RECORD sets publish_time to Date.now()+60_000 which can become stale during slow runs; update the tests to set publish_time dynamically per test (e.g., create or clone PUBLISHED_RECORD inside beforeEach/each test and assign a fresh future timestamp) or replace the module-scoped value with a fixed far-future ISO string; locate the PUBLISHED_RECORD constant in shareWorkflowDialog.spec.ts and change its publish_time handling so each test gets a non-expiring/fresh timestamp.src/components/graph/GraphCanvas.vue (1)
355-381: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winDon't drop setting updates when the canvas is still uninitialized.
Both watchers now return early on
!canvasStore.canvas, but neither watch source includes canvas readiness. If the setting changes before the canvas exists, the update is lost and never replayed. IncludecanvasStore.canvasin the watched source or defer the work until setup completes.Also applies to: 394-409
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/graph/GraphCanvas.vue` around lines 355 - 381, The watch on settingStore.get('Comfy.WidgetControlMode') returns early when canvasStore.canvas is not yet initialized, so setting changes that occur before canvas readiness are dropped; update the watcher to include canvasStore.canvas in its watch source (e.g. watch([() => settingStore.get('Comfy.WidgetControlMode'), () => canvasStore.canvas], ...)) or otherwise defer/queue the update until canvasStore.canvas becomes truthy, then run the same logic that iterates comfyApp.rootGraph via forEachNode and calls updateControlWidgetLabel for widgets and linkedWidgets and finally canvasStore.canvas.setDirty(true); apply the same change to the other watcher at the noted lines (394-409) to ensure updates are replayed once the canvas is initialized.src/components/searchbox/NodeSearchBoxPopover.vue (1)
134-145: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winKeep
disconnectOnResetcleanup on every exit path.The new early returns in
addNodeandshowContextMenuskip the reconnect cleanup. If node creation fails or no link is available,disconnectOnResetstays armed and the nextreset()can disconnect unrelated links.Suggested cleanup
function addNode(nodeDef: ComfyNodeDefImpl, dragEvent?: MouseEvent) { const followCursor = settingStore.get('Comfy.NodeSearchBoxImpl.FollowCursor') const node = withNodeAddSource('search_modal', () => @@ ) if (!node) { + disconnectOnReset = false return } @@ function showContextMenu(e: CanvasPointerEvent) { const firstLink = getFirstLink() if (!firstLink) { + disconnectOnReset = false return }Also applies to: 205-209
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/searchbox/NodeSearchBoxPopover.vue` around lines 134 - 145, addNode and showContextMenu currently return early without clearing the armed disconnectOnReset state, so ensure disconnectOnReset cleanup always runs on every exit path: after setting/arming disconnectOnReset (or before any early return in addNode and showContextMenu) call the existing cleanup/reset function or explicitly clear the disconnectOnReset flag (and any related listener) so it cannot fire later on unrelated reset(); alternatively wrap the node creation/link logic in a try/finally where the finally always performs the disconnectOnReset cleanup; reference the disconnectOnReset variable and the addNode and showContextMenu functions (and the reset() path) when applying the fix.src/components/graph/NodeTooltip.vue (1)
71-87: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMove the collapsed-node guard above the title-tooltip branch.
node.flags?.collapsedstill reaches the title-description path, so collapsed nodes can keep showing tooltips when hovered on the title. Put the check before thetitle_modeblock so every tooltip path is skipped.💡 Suggested fix
const node = canvas?.node_over if (!node || node.flags?.ghost) { return } + if (node.flags?.collapsed) { + return + } const ctor = node.constructor as { title_mode?: 0 | 1 | 2 | 3 } const nodeDef = nodeDefStore.nodeDefsByName[node.type ?? ''] @@ - if (node.flags?.collapsed) { - return - } - const inputSlot = isOverNodeInput(🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/graph/NodeTooltip.vue` around lines 71 - 87, Move the collapsed-node guard so collapsed nodes never reach the title-tooltip logic: in NodeTooltip.vue, check node.flags?.collapsed before the block that inspects ctor.title_mode / LiteGraph.NO_TITLE and the canvas.graph_mouse vs node.pos comparison (the block that calls showTooltip(nodeDef?.description)); return early for collapsed nodes to skip all tooltip paths (the other relevant symbols are node, nodeDef, ctor, canvas.graph_mouse, node.pos, and showTooltip).src/components/node/NodePricingBadge.vue (1)
20-38: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winClear the old price before kicking off the new lookup.
priceLabelonly changes on a successful match, so a renamed node can keep showing the previous node’s price while the new promise is in flight, or forever if it fails. Resetting the label at the start of the watcher avoids stale UI.♻️ Proposed fix
watch( () => nodeDef.name, (name) => { if (!nodeDef.api_node) { priceLabel.value = '' return } + priceLabel.value = '' const capturedName = name evaluateNodeDefPricing(nodeDef)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/node/NodePricingBadge.vue` around lines 20 - 38, In the watch callback for () => nodeDef.name, clear the displayed price immediately when starting a new lookup so stale prices don’t remain; specifically, after the existing if (!nodeDef.api_node) branch (which already sets priceLabel.value = ''), also set priceLabel.value = '' right before calling evaluateNodeDefPricing(nodeDef) so the UI is reset while the promise is in flight, retaining the capturedName comparison and existing .then/.catch handling.src/components/graph/NodeContextMenu.vue (1)
296-323: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winClear stale submenu overflow styles when the menu fits.
constrainMenuHeight()only setsmaxHeight/overflowYin the overflow case, but it never clears those inline styles on a later open when the menu is shorter. That can leave the submenu clipped or scrollable from the previous invocation.🔧 Suggested fix
function constrainMenuHeight() { const menuInstance = contextMenu.value as unknown as { container?: HTMLElement } const rootList = menuInstance?.container?.querySelector( ':scope > ul' ) as HTMLElement | null if (!rootList) { return } + rootList.style.maxHeight = '' + rootList.style.overflowY = '' + const rect = rootList.getBoundingClientRect() const availableHeight = window.innerHeight - rect.top - 8 if (availableHeight <= 0) { return } @@ if (rootList.scrollHeight <= availableHeight) { return } rootList.style.maxHeight = `${availableHeight}px` rootList.style.overflowY = 'auto' }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/graph/NodeContextMenu.vue` around lines 296 - 323, constrainMenuHeight currently only applies inline styles when content overflows, leaving stale maxHeight/overflowY on root <ul> from prior opens; update constrainMenuHeight to explicitly clear rootList.style.maxHeight and rootList.style.overflowY (set to empty string) whenever the menu does NOT need the constraint (i.e., when availableHeight <= 0 OR when rootList.scrollHeight <= availableHeight) so any previously-applied inline styles are removed; reference the existing contextMenu.value -> menuInstance and rootList variables inside constrainMenuHeight to locate where to clear the styles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/breadcrumb/SubgraphBreadcrumb.vue`:
- Around line 171-173: The early return inside the items-length guard (the "if
(items.length < 3) { return }" branch) leaves collapseTabs.value in a collapsed
state; before returning, explicitly reset collapseTabs.value = false so the
breadcrumb is expanded when the stack shrinks below three items (update the
conditional in SubgraphBreadcrumb.vue that checks items.length and ensure
collapseTabs.value is cleared prior to the return).
In `@src/components/queue/job/JobAssetsList.vue`:
- Around line 267-275: The current showDetailsNow function clears hover timers
before confirming the hovered job is still displayed, which can leave stale
details open; change the order so you first verify the job is displayed (using
hasDisplayedJob(nextActive.jobId)) and that any referenced DOM element
(activeRowElement) still corresponds to nextActive, and only then call
clearHoverTimers() and set activeDetails.value/isDetailsOpen.value; apply the
same pattern to the analogous logic in the other block (around the 306-331
region) to ensure timers are cleared only after the guard checks pass.
In `@src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue`:
- Around line 159-164: In handleContextMenu, call event.preventDefault() before
returning when !isUserBlueprint.value so the native browser context menu is
suppressed; specifically, update the handleContextMenu function to invoke
event.preventDefault() (or switch to using the `@contextmenu.prevent` modifier on
the component) and then return, leaving menu.value?.show(event) for the
isUserBlueprint.value case.
In `@src/composables/bottomPanelTabs/useLogsTerminal.ts`:
- Around line 86-117: Move creation of the AbortController (and assignment to
mountController) to before awaiting until(terminal).toBeTruthy() inside
onMounted in useLogsTerminal, then after the await check signal.aborted and
return early if true; ensure the rest of the flow (calling api.getRawLogs(),
writeEntries, and subscribe logic) only runs when mountController.signal is not
aborted. Specifically: create the controller and extract { signal } before
calling until(terminal).toBeTruthy(), and add a short-circuit check using
signal.aborted immediately after the await to prevent continuing into
getRawLogs() or subscribeLogs when unmounted.
---
Outside diff comments:
In `@browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts`:
- Around line 15-20: The module-scoped PUBLISHED_RECORD sets publish_time to
Date.now()+60_000 which can become stale during slow runs; update the tests to
set publish_time dynamically per test (e.g., create or clone PUBLISHED_RECORD
inside beforeEach/each test and assign a fresh future timestamp) or replace the
module-scoped value with a fixed far-future ISO string; locate the
PUBLISHED_RECORD constant in shareWorkflowDialog.spec.ts and change its
publish_time handling so each test gets a non-expiring/fresh timestamp.
In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 107-123: The evaluate callback can still throw if isSubgraphNode
is undefined because it is being invoked; change the invocation to use the
optional call operator so the check is safe: replace the current call to
hostNode?.isSubgraphNode() with hostNode?.isSubgraphNode?.() inside the evaluate
closure (also ensure subsequent access to hostNode.subgraph is only reached when
the optional call returned true). This targets the evaluate callback where
hostNode and isSubgraphNode are used.
In `@src/components/graph/GraphCanvas.vue`:
- Around line 355-381: The watch on settingStore.get('Comfy.WidgetControlMode')
returns early when canvasStore.canvas is not yet initialized, so setting changes
that occur before canvas readiness are dropped; update the watcher to include
canvasStore.canvas in its watch source (e.g. watch([() =>
settingStore.get('Comfy.WidgetControlMode'), () => canvasStore.canvas], ...)) or
otherwise defer/queue the update until canvasStore.canvas becomes truthy, then
run the same logic that iterates comfyApp.rootGraph via forEachNode and calls
updateControlWidgetLabel for widgets and linkedWidgets and finally
canvasStore.canvas.setDirty(true); apply the same change to the other watcher at
the noted lines (394-409) to ensure updates are replayed once the canvas is
initialized.
In `@src/components/graph/NodeContextMenu.vue`:
- Around line 296-323: constrainMenuHeight currently only applies inline styles
when content overflows, leaving stale maxHeight/overflowY on root <ul> from
prior opens; update constrainMenuHeight to explicitly clear
rootList.style.maxHeight and rootList.style.overflowY (set to empty string)
whenever the menu does NOT need the constraint (i.e., when availableHeight <= 0
OR when rootList.scrollHeight <= availableHeight) so any previously-applied
inline styles are removed; reference the existing contextMenu.value ->
menuInstance and rootList variables inside constrainMenuHeight to locate where
to clear the styles.
In `@src/components/graph/NodeTooltip.vue`:
- Around line 71-87: Move the collapsed-node guard so collapsed nodes never
reach the title-tooltip logic: in NodeTooltip.vue, check node.flags?.collapsed
before the block that inspects ctor.title_mode / LiteGraph.NO_TITLE and the
canvas.graph_mouse vs node.pos comparison (the block that calls
showTooltip(nodeDef?.description)); return early for collapsed nodes to skip all
tooltip paths (the other relevant symbols are node, nodeDef, ctor,
canvas.graph_mouse, node.pos, and showTooltip).
In `@src/components/node/NodePricingBadge.vue`:
- Around line 20-38: In the watch callback for () => nodeDef.name, clear the
displayed price immediately when starting a new lookup so stale prices don’t
remain; specifically, after the existing if (!nodeDef.api_node) branch (which
already sets priceLabel.value = ''), also set priceLabel.value = '' right before
calling evaluateNodeDefPricing(nodeDef) so the UI is reset while the promise is
in flight, retaining the capturedName comparison and existing .then/.catch
handling.
In `@src/components/searchbox/NodeSearchBoxPopover.vue`:
- Around line 134-145: addNode and showContextMenu currently return early
without clearing the armed disconnectOnReset state, so ensure disconnectOnReset
cleanup always runs on every exit path: after setting/arming disconnectOnReset
(or before any early return in addNode and showContextMenu) call the existing
cleanup/reset function or explicitly clear the disconnectOnReset flag (and any
related listener) so it cannot fire later on unrelated reset(); alternatively
wrap the node creation/link logic in a try/finally where the finally always
performs the disconnectOnReset cleanup; reference the disconnectOnReset variable
and the addNode and showContextMenu functions (and the reset() path) when
applying the fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a5dfa38c-48fd-44e0-bee4-f0e7b1c196b6
📒 Files selected for processing (300)
.oxlintrc.jsonbrowser_tests/fixtures/ComfyMouse.tsbrowser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/VueNodeHelpers.tsbrowser_tests/fixtures/components/ComfyNodeSearchBoxV2.tsbrowser_tests/fixtures/components/SubgraphEditor.tsbrowser_tests/fixtures/helpers/AppModeHelper.tsbrowser_tests/fixtures/helpers/AppModeWidgetHelper.tsbrowser_tests/fixtures/helpers/AssetHelper.tsbrowser_tests/fixtures/helpers/AssetsHelper.tsbrowser_tests/fixtures/helpers/BuilderSelectHelper.tsbrowser_tests/fixtures/helpers/CanvasHelper.tsbrowser_tests/fixtures/helpers/CommandHelper.tsbrowser_tests/fixtures/helpers/DragDropHelper.tsbrowser_tests/fixtures/helpers/FeatureFlagHelper.tsbrowser_tests/fixtures/helpers/MaskEditorHelper.tsbrowser_tests/fixtures/helpers/MobileAppHelper.tsbrowser_tests/fixtures/helpers/ModelLibraryHelper.tsbrowser_tests/fixtures/helpers/NodeOperationsHelper.tsbrowser_tests/fixtures/helpers/PerformanceHelper.tsbrowser_tests/fixtures/helpers/Preview3DPipelineFixture.tsbrowser_tests/fixtures/helpers/SubgraphHelper.tsbrowser_tests/fixtures/helpers/UserDataHelper.tsbrowser_tests/fixtures/helpers/WorkflowHelper.tsbrowser_tests/fixtures/sharedWorkflowImportFixture.tsbrowser_tests/fixtures/utils/boundsUtils.tsbrowser_tests/fixtures/utils/dragAndDrop.tsbrowser_tests/fixtures/utils/fitToView.tsbrowser_tests/fixtures/utils/groupHelpers.tsbrowser_tests/fixtures/utils/litegraphUtils.tsbrowser_tests/fixtures/utils/mimeTypeUtil.tsbrowser_tests/fixtures/utils/painter.tsbrowser_tests/fixtures/utils/perfReporter.tsbrowser_tests/fixtures/utils/preview3dCameraState.tsbrowser_tests/fixtures/utils/promotedWidgets.tsbrowser_tests/fixtures/utils/slotBoundsUtil.tsbrowser_tests/fixtures/ws.tsbrowser_tests/tests/appMode.spec.tsbrowser_tests/tests/assetDeleteClearsLoadImage.spec.tsbrowser_tests/tests/builderSaveFlow.spec.tsbrowser_tests/tests/changeTrackerLoadGuard.spec.tsbrowser_tests/tests/cloud-asset-default.spec.tsbrowser_tests/tests/colorPalette.spec.tsbrowser_tests/tests/containAudit.spec.tsbrowser_tests/tests/curveWidget.spec.tsbrowser_tests/tests/customIcons.spec.tsbrowser_tests/tests/dialogs/settingsDialog.spec.tsbrowser_tests/tests/dialogs/shareWorkflowDialog.spec.tsbrowser_tests/tests/graph.spec.tsbrowser_tests/tests/groupNode.spec.tsbrowser_tests/tests/groupSelectChildren.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/load3d/load3d.spec.tsbrowser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/nodeBadge.spec.tsbrowser_tests/tests/nodeGhostPlacement.spec.tsbrowser_tests/tests/nodeTemplates.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/performance.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingMediaRuntime.spec.tsbrowser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.tsbrowser_tests/tests/queue/queueOverlay.spec.tsbrowser_tests/tests/queue/queueSettings.spec.tsbrowser_tests/tests/rendererToggleStability.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/sharedWorkflowMissingMedia.spec.tsbrowser_tests/tests/sidebar/assets.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphCrud.spec.tsbrowser_tests/tests/subgraph/subgraphDraftPositions.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/rename.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/vueNodes/nodeStates/collapse.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/nodeStates/pin.spec.tsbrowser_tests/tests/vueNodes/widgets/imageCrop.spec.tsbrowser_tests/tests/webcamCapture.spec.tsbrowser_tests/tests/widget.spec.tsbrowser_tests/tests/workflowPersistence.spec.tsbrowser_tests/tests/workflowSettings.spec.tsbrowser_tests/utils/backupUtils.tssrc/base/assert.tssrc/base/common/downloadUtil.tssrc/base/credits/comfyCredits.tssrc/base/webviewDetection.tssrc/components/LiteGraphCanvasSplitterOverlay.vuesrc/components/TopMenuSection.test.tssrc/components/TopMenuSection.vuesrc/components/actionbar/ComfyActionbar.test.tssrc/components/actionbar/ComfyActionbar.vuesrc/components/bottomPanel/tabs/terminal/BaseTerminal.vuesrc/components/bottomPanel/tabs/terminal/CommandTerminal.vuesrc/components/breadcrumb/SubgraphBreadcrumb.vuesrc/components/builder/AppBuilder.vuesrc/components/builder/AppModeWidgetList.vuesrc/components/builder/BuilderFooterToolbar.vuesrc/components/builder/BuilderMenu.vuesrc/components/builder/IoItem.vuesrc/components/builder/useAppModeWidgetResizing.tssrc/components/builder/useBuilderSave.test.tssrc/components/builder/useBuilderSave.tssrc/components/builder/useBuilderSteps.tssrc/components/builder/useEmptyWorkflowDialog.tssrc/components/builder/useResolvedSelectedInputs.tssrc/components/common/DraggableList.vuesrc/components/common/EditableText.vuesrc/components/common/FormRadioGroup.vuesrc/components/common/ScrubableNumberInput.vuesrc/components/common/SystemStatsPanel.vuesrc/components/common/TextTicker.vuesrc/components/common/TreeExplorerV2.vuesrc/components/common/TreeExplorerV2Node.vuesrc/components/common/UrlInput.vuesrc/components/common/VirtualGrid.vuesrc/components/common/WaveAudioPlayer.vuesrc/components/curve/CurveEditor.test.tssrc/components/curve/CurveEditor.vuesrc/components/curve/WidgetCurve.test.tssrc/components/curve/WidgetCurve.vuesrc/components/curve/curveUtils.tssrc/components/custom/widget/WorkflowTemplateSelectorDialog.vuesrc/components/dialog/GlobalDialog.vuesrc/components/dialog/content/ConfirmationDialogContent.vuesrc/components/dialog/content/TopUpCreditsDialogContentLegacy.vuesrc/components/dialog/content/setting/KeybindingPanel.vuesrc/components/dialog/content/setting/UsageLogsTable.test.tssrc/components/dialog/content/setting/keybinding/EditKeybindingContent.vuesrc/components/dialog/content/setting/keybinding/EditKeybindingFooter.vuesrc/components/dialog/content/setting/keybinding/KeybindingList.vuesrc/components/dialog/content/subscription/CancelSubscriptionDialogContent.vuesrc/components/error/useErrorOverlayState.tssrc/components/gradientslider/GradientSlider.vuesrc/components/gradientslider/gradients.tssrc/components/graph/CanvasModeSelector.vuesrc/components/graph/DomWidgets.test.tssrc/components/graph/DomWidgets.vuesrc/components/graph/GraphCanvas.vuesrc/components/graph/LinkOverlayCanvas.vuesrc/components/graph/NodeContextMenu.vuesrc/components/graph/NodeTooltip.vuesrc/components/graph/SelectionRectangle.vuesrc/components/graph/modals/ZoomControlsModal.test.tssrc/components/graph/modals/ZoomControlsModal.vuesrc/components/graph/selectionToolbox/ArrangeButton.vuesrc/components/graph/selectionToolbox/ColorPickerButton.vuesrc/components/graph/selectionToolbox/InfoButton.vuesrc/components/graph/selectionToolbox/SubmenuPopover.vuesrc/components/graph/widgets/DomWidget.test.tssrc/components/graph/widgets/DomWidget.vuesrc/components/graph/widgets/TextPreviewWidget.vuesrc/components/graph/widgets/domWidgetZIndex.tssrc/components/helpcenter/HelpCenterMenuContent.vuesrc/components/imagecrop/WidgetImageCrop.vuesrc/components/load3d/Load3DControls.vuesrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/controls/AnimationControls.test.tssrc/components/load3d/controls/AnimationControls.vuesrc/components/load3d/controls/CameraControls.test.tssrc/components/load3d/controls/GizmoControls.test.tssrc/components/load3d/controls/GizmoControls.vuesrc/components/load3d/controls/HDRIControls.test.tssrc/components/load3d/controls/HDRIControls.vuesrc/components/load3d/controls/LightControls.test.tssrc/components/load3d/controls/LightControls.vuesrc/components/load3d/controls/ModelControls.test.tssrc/components/load3d/controls/PopupSlider.test.tssrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/RecordingControls.test.tssrc/components/load3d/controls/SceneControls.test.tssrc/components/load3d/controls/viewer/ViewerCameraControls.test.tssrc/components/load3d/controls/viewer/ViewerCameraControls.vuesrc/components/load3d/controls/viewer/ViewerExportControls.test.tssrc/components/load3d/controls/viewer/ViewerGizmoControls.test.tssrc/components/load3d/controls/viewer/ViewerLightControls.test.tssrc/components/load3d/controls/viewer/ViewerLightControls.vuesrc/components/load3d/controls/viewer/ViewerModelControls.test.tssrc/components/load3d/controls/viewer/ViewerSceneControls.test.tssrc/components/maskeditor/PointerZone.vuesrc/components/maskeditor/ToolPanel.test.tssrc/components/node/NodePreview.vuesrc/components/node/NodePreviewCard.vuesrc/components/node/NodePricingBadge.vuesrc/components/painter/WidgetPainter.test.tssrc/components/queue/JobHistoryActionsMenu.test.tssrc/components/queue/QueueOverlayExpanded.vuesrc/components/queue/QueueProgressOverlay.vuesrc/components/queue/dialogs/QueueClearHistoryDialog.vuesrc/components/queue/job/JobAssetsList.vuesrc/components/queue/job/JobContextMenu.vuesrc/components/queue/job/JobDetailsPopover.vuesrc/components/queue/job/JobFilterTabs.vuesrc/components/queue/job/useQueueEstimates.tssrc/components/range/RangeEditor.test.tssrc/components/range/RangeEditor.vuesrc/components/range/WidgetRange.test.tssrc/components/range/WidgetRange.vuesrc/components/range/rangeUtils.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorNodeCard.vuesrc/components/rightSidePanel/errors/MissingNodeCard.vuesrc/components/rightSidePanel/errors/MissingPackGroupRow.vuesrc/components/rightSidePanel/errors/TabErrors.vuesrc/components/rightSidePanel/errors/useErrorGroups.test.tssrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/rightSidePanel/errors/useErrorReport.tssrc/components/rightSidePanel/layout/PropertiesAccordionItem.vuesrc/components/rightSidePanel/parameters/SectionWidgets.vuesrc/components/rightSidePanel/parameters/TabGlobalParameters.vuesrc/components/rightSidePanel/parameters/TabSubgraphInputs.vuesrc/components/rightSidePanel/parameters/WidgetActions.vuesrc/components/rightSidePanel/parameters/WidgetItem.test.tssrc/components/rightSidePanel/parameters/WidgetItem.vuesrc/components/rightSidePanel/settings/SetNodeColor.vuesrc/components/rightSidePanel/settings/SetNodeState.vuesrc/components/rightSidePanel/settings/TabGlobalSettings.vuesrc/components/rightSidePanel/shared.tssrc/components/rightSidePanel/subgraph/SubgraphEditor.vuesrc/components/searchbox/NodeSearchBox.vuesrc/components/searchbox/NodeSearchBoxPopover.test.tssrc/components/searchbox/NodeSearchBoxPopover.vuesrc/components/searchbox/v2/NodeSearchCategoryTreeNode.vuesrc/components/searchbox/v2/NodeSearchContent.vuesrc/components/searchbox/v2/NodeSearchInput.test.tssrc/components/searchbox/v2/NodeSearchInput.vuesrc/components/searchbox/v2/NodeSearchTypeFilterPopover.vuesrc/components/sidebar/SideToolbar.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/sidebar/tabs/BaseWorkflowsSidebarTab.test.tssrc/components/sidebar/tabs/BaseWorkflowsSidebarTab.vuesrc/components/sidebar/tabs/JobHistorySidebarTab.vuesrc/components/sidebar/tabs/ModelLibrarySidebarTab.test.tssrc/components/sidebar/tabs/ModelLibrarySidebarTab.vuesrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.vuesrc/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vuesrc/components/sidebar/tabs/nodeLibrary/EssentialNodeCard.vuesrc/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vuesrc/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vuesrc/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vuesrc/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vuesrc/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vuesrc/components/tab/Tab.vuesrc/components/templates/thumbnails/CompareSliderThumbnail.vuesrc/components/templates/thumbnails/LogoOverlay.vuesrc/components/toast/GlobalToast.vuesrc/components/topbar/CurrentUserButton.vuesrc/components/topbar/TopbarBadges.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/ui/ZoomPane.vuesrc/components/ui/chart/useChart.tssrc/components/ui/color-picker/ColorPickerSaturationValue.vuesrc/components/ui/color-picker/ColorPickerSlider.vuesrc/components/ui/search-input/AsyncSearchInput.vuesrc/components/ui/search-input/SearchAutocomplete.vuesrc/components/ui/search-input/SearchInput.test.tssrc/components/ui/select/SelectDropdown.stories.tssrc/components/widget/layout/BaseModalLayout.vuesrc/components/widget/nav/NavItem.vuesrc/composables/auth/useAuthActions.tssrc/composables/auth/useCurrentUser.tssrc/composables/billing/useBillingContext.tssrc/composables/billing/useLegacyBilling.tssrc/composables/bottomPanelTabs/useLogsTerminal.tssrc/composables/canvas/useFocusNode.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/composables/canvas/useSelectionToolboxPosition.tssrc/composables/element/useCanvasPositionConversion.tssrc/composables/element/useDomClipping.tssrc/composables/graph/contextMenuConverter.tssrc/composables/graph/useArrangeNodes.tssrc/composables/graph/useArrangeSession.tssrc/composables/graph/useErrorClearingHooks.test.tssrc/composables/graph/useErrorClearingHooks.tssrc/composables/graph/useFrameNodes.tssrc/composables/graph/useGraphHierarchy.tssrc/composables/graph/useGraphNodeManager.test.tssrc/composables/graph/useGraphNodeManager.tssrc/composables/graph/useGroupMenuOptions.tssrc/composables/graph/useImageMenuOptions.tssrc/composables/graph/useNodeCustomization.tssrc/composables/graph/useNodeErrorFlagSync.tssrc/composables/graph/useSelectedNodeActions.tssrc/composables/graph/useSelectionState.tssrc/composables/graph/useSubgraphOperations.tssrc/composables/graph/useVueNodeLifecycle.tssrc/composables/maskeditor/brushDrawingUtils.test.ts
| if (items.length < 3) { | ||
| return | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Clear the collapsed state before bailing out on short breadcrumb lists.
Returning here skips the collapseTabs.value = false path, so a breadcrumb that was already collapsed can stay collapsed even after the stack shrinks below three items.
💡 Suggested fix
- if (items.length < 3) {
- return
- }
+ if (items.length < 3) {
+ collapseTabs.value = false
+ return
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (items.length < 3) { | |
| return | |
| } | |
| if (items.length < 3) { | |
| collapseTabs.value = false | |
| return | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/breadcrumb/SubgraphBreadcrumb.vue` around lines 171 - 173, The
early return inside the items-length guard (the "if (items.length < 3) { return
}" branch) leaves collapseTabs.value in a collapsed state; before returning,
explicitly reset collapseTabs.value = false so the breadcrumb is expanded when
the stack shrinks below three items (update the conditional in
SubgraphBreadcrumb.vue that checks items.length and ensure collapseTabs.value is
cleared prior to the return).
There was a problem hiding this comment.
Confirmed valid bug, but pre-existing on main — this PR is a pure brace-style rollout and doesn't touch the surrounding logic. Mixing a functional fix into an 800+ file style change would muddy the diff and complicate review/revert. Worth a separate PR / issue. Also note: after the latest force-push (multi-or-nest mode), this line is back to if (items.length < 3) return — most of the bracing CodeRabbit reviewed has been reverted.
There was a problem hiding this comment.
Skipped: comment is from another GitHub bot.
| function showDetailsNow(nextActive: { jobId: string; workflowId?: string }) { | ||
| clearHoverTimers() | ||
| if (!hasDisplayedJob(nextActive.jobId)) return | ||
| if (!hasDisplayedJob(nextActive.jobId)) { | ||
| return | ||
| } | ||
|
|
||
| activeDetails.value = nextActive | ||
| isDetailsOpen.value = true | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Guard the hover state before clearing timers.
showDetailsNow() now clears the existing hide timer before it knows the hovered job is still displayed. If a stale mouseenter arrives after the list changed, the previous details stay open with no timer to close them, and activeRowElement has already moved to the removed row.
♻️ Proposed fix
function showDetailsNow(nextActive: { jobId: string; workflowId?: string }) {
- clearHoverTimers()
if (!hasDisplayedJob(nextActive.jobId)) {
return
}
+ clearHoverTimers()
activeDetails.value = nextActive
isDetailsOpen.value = true
}
function onJobEnter(job: JobListItem, event: MouseEvent) {
- hoveredJobId.value = job.id
-
const rowElement = event.currentTarget
if (!(rowElement instanceof HTMLElement)) {
return
}
const nextActive = {
jobId: job.id,
workflowId: job.taskRef?.workflowId
}
+
+ if (!hasDisplayedJob(nextActive.jobId)) {
+ return
+ }
+
+ hoveredJobId.value = job.id
+ activeRowElement.value = rowElement
-
- activeRowElement.value = rowElement
...
}Also applies to: 306-331
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/queue/job/JobAssetsList.vue` around lines 267 - 275, The
current showDetailsNow function clears hover timers before confirming the
hovered job is still displayed, which can leave stale details open; change the
order so you first verify the job is displayed (using
hasDisplayedJob(nextActive.jobId)) and that any referenced DOM element
(activeRowElement) still corresponds to nextActive, and only then call
clearHoverTimers() and set activeDetails.value/isDetailsOpen.value; apply the
same pattern to the analogous logic in the other block (around the 306-331
region) to ensure timers are cleared only after the guard checks pass.
There was a problem hiding this comment.
Valid race condition, but pre-existing on main — showDetailsNow already clears timers before the guard there. Not introduced by this PR; this PR only adds/removes braces.
Out of scope here for the same reason as the other findings — keeping this PR a mechanical style change. The latest force-push (multi-or-nest mode) also reverts the bracing this comment is anchored to. Recommend a dedicated PR for the hover-state race.
There was a problem hiding this comment.
Skipped: comment is from another GitHub bot.
| function handleContextMenu(event: Event) { | ||
| if (!isUserBlueprint.value) return | ||
| if (!isUserBlueprint.value) { | ||
| return | ||
| } | ||
| menu.value?.show(event) | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Consume the contextmenu event before returning.
Returning early here skips menu.show(event), so non-user blueprints can fall through to the browser’s native context menu. Call event.preventDefault() (or use @contextmenu.prevent) before exiting.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue` around lines 159 -
164, In handleContextMenu, call event.preventDefault() before returning when
!isUserBlueprint.value so the native browser context menu is suppressed;
specifically, update the handleContextMenu function to invoke
event.preventDefault() (or switch to using the `@contextmenu.prevent` modifier on
the component) and then return, leaving menu.value?.show(event) for the
isUserBlueprint.value case.
There was a problem hiding this comment.
Valid — non-user blueprints fall through to the browser context menu on main too. Pre-existing, not introduced by this PR (which only changes brace style).
Deferring to a separate PR to keep this change focused on the lint rule. Should be a one-liner: event.preventDefault() before the early return, or @contextmenu.prevent on the template binding.
There was a problem hiding this comment.
Skipped: comment is from another GitHub bot.
| onMounted(async () => { | ||
| if (!terminal.value) await until(terminal).toBeTruthy() | ||
| if (!terminal.value) { | ||
| await until(terminal).toBeTruthy() | ||
| } | ||
|
|
||
| const controller = new AbortController() | ||
| mountController = controller | ||
| const { signal } = controller | ||
|
|
||
| try { | ||
| const logs = await api.getRawLogs() | ||
| if (signal.aborted || !terminal.value) return | ||
| if (signal.aborted || !terminal.value) { | ||
| return | ||
| } | ||
| writeEntries(logs.entries) | ||
| } catch (err) { | ||
| if (signal.aborted) return | ||
| if (signal.aborted) { | ||
| return | ||
| } | ||
| console.error('Error loading logs', err) | ||
| errorMessage.value = t('logsTerminal.loadError') | ||
| loading.value = false | ||
| return | ||
| } | ||
|
|
||
| const { clientId } = storeToRefs(useExecutionStore()) | ||
| if (!clientId.value) await until(clientId).not.toBeNull() | ||
| if (signal.aborted) return | ||
| if (!clientId.value) { | ||
| await until(clientId).not.toBeNull() | ||
| } | ||
| if (signal.aborted) { | ||
| return | ||
| } |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Make the mount wait abort-aware.
await until(terminal).toBeTruthy() runs before any AbortController exists, so unmounting while the ref is still unset leaves this async task alive and it can continue into getRawLogs() / subscribeLogs(true) after disposal. Create the controller first, then short-circuit once the wait resolves if the signal was aborted.
🔧 Suggested fix
onMounted(async () => {
+ const controller = new AbortController()
+ mountController = controller
+ const { signal } = controller
+
if (!terminal.value) {
await until(terminal).toBeTruthy()
}
-
- const controller = new AbortController()
- mountController = controller
- const { signal } = controller
+ if (signal.aborted) {
+ return
+ }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/composables/bottomPanelTabs/useLogsTerminal.ts` around lines 86 - 117,
Move creation of the AbortController (and assignment to mountController) to
before awaiting until(terminal).toBeTruthy() inside onMounted in
useLogsTerminal, then after the await check signal.aborted and return early if
true; ensure the rest of the flow (calling api.getRawLogs(), writeEntries, and
subscribe logic) only runs when mountController.signal is not aborted.
Specifically: create the controller and extract { signal } before calling
until(terminal).toBeTruthy(), and add a short-circuit check using signal.aborted
immediately after the await to prevent continuing into getRawLogs() or
subscribeLogs when unmounted.
There was a problem hiding this comment.
Valid stability bug — onMounted awaits until(terminal).toBeTruthy() before the controller exists, so an unmount during that wait leaks the rest of the flow. Pre-existing on main, not introduced by this PR.
Deferring to a separate PR — this one is a mechanical brace-style change across 800+ files and adding functional fixes here would muddy the diff. The suggested fix (create controller first, check signal.aborted after the await) is the right shape.
There was a problem hiding this comment.
Skipped: comment is from another GitHub bot.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/sidebar/tabs/AssetsSidebarTab.vue`:
- Around line 641-643: The click handler handleEmptySpaceClick is checking the
ref object hasSelection instead of its boolean value, causing clearSelection()
to always run; update the condition to use the reactive boolean (e.g.,
hasSelection.value or a computed/unwrapped boolean) so clearSelection() only
runs when hasSelection is true, keeping the call site inside
handleEmptySpaceClick and leaving clearSelection unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: accbf313-2310-4813-9dc5-ef8f36e441b7
📒 Files selected for processing (300)
.oxlintrc.jsonbrowser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/components/Actionbar.tsbrowser_tests/fixtures/components/BottomPanel.tsbrowser_tests/fixtures/components/SidebarTab.tsbrowser_tests/fixtures/components/Topbar.tsbrowser_tests/fixtures/helpers/AssetHelper.tsbrowser_tests/fixtures/helpers/AssetsHelper.tsbrowser_tests/fixtures/helpers/CanvasHelper.tsbrowser_tests/fixtures/helpers/CloudAuthHelper.tsbrowser_tests/fixtures/helpers/DragDropHelper.tsbrowser_tests/fixtures/helpers/FeatureFlagHelper.tsbrowser_tests/fixtures/helpers/MaskEditorHelper.tsbrowser_tests/fixtures/helpers/ModelLibraryHelper.tsbrowser_tests/fixtures/helpers/NodeOperationsHelper.tsbrowser_tests/fixtures/helpers/PerformanceHelper.tsbrowser_tests/fixtures/helpers/PublishApiHelper.tsbrowser_tests/fixtures/helpers/SubgraphHelper.tsbrowser_tests/fixtures/helpers/TemplateHelper.tsbrowser_tests/fixtures/helpers/ToastHelper.tsbrowser_tests/fixtures/helpers/UserDataHelper.tsbrowser_tests/fixtures/helpers/WorkflowHelper.tsbrowser_tests/fixtures/jobsRouteFixture.tsbrowser_tests/fixtures/sharedWorkflowImportFixture.tsbrowser_tests/fixtures/utils/boundsUtils.tsbrowser_tests/fixtures/utils/builderTestUtils.tsbrowser_tests/fixtures/utils/customMatchers.tsbrowser_tests/fixtures/utils/fitToView.tsbrowser_tests/fixtures/utils/litegraphUtils.tsbrowser_tests/fixtures/utils/painter.tsbrowser_tests/fixtures/utils/preview3dCameraState.tsbrowser_tests/fixtures/utils/selectionToolboxMoreOptions.tsbrowser_tests/fixtures/utils/vueNodeFixtures.tsbrowser_tests/tests/actionbar.spec.tsbrowser_tests/tests/appModeDropdownClipping.spec.tsbrowser_tests/tests/appModeWidgetValues.spec.tsbrowser_tests/tests/canvasModeSelector.spec.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/containAudit.spec.tsbrowser_tests/tests/dialogs/queueClearHistory.spec.tsbrowser_tests/tests/domWidget.spec.tsbrowser_tests/tests/execution.spec.tsbrowser_tests/tests/featureFlags.spec.tsbrowser_tests/tests/i18nLocaleFallback.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/keybindingPresets.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/nodeBadge.spec.tsbrowser_tests/tests/nodeContextMenuOverflow.spec.tsbrowser_tests/tests/nodeGhostPlacement.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/performance.spec.tsbrowser_tests/tests/previewAsText.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingMediaRuntime.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabModeAware.spec.tsbrowser_tests/tests/remoteWidgets.spec.tsbrowser_tests/tests/rendererToggleStability.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/selectionToolboxSubmenus.spec.tsbrowser_tests/tests/sidebar/assets-filter.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/subgraph/subgraphCrud.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSerialization.spec.tsbrowser_tests/tests/subgraph/subgraphSlots.spec.tsbrowser_tests/tests/subgraphPromotedWidgetPanel.spec.tsbrowser_tests/tests/vueNodes/groups/groups.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/float/floatWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/imageCrop.spec.tsbrowser_tests/tests/workflowPersistence.spec.tsbrowser_tests/tests/workflowTabThumbnail.spec.tsbrowser_tests/tests/wsReconnectStaleJob.spec.tsbrowser_tests/tests/zoomControls.spec.tssrc/App.vuesrc/base/assert.tssrc/base/common/async.tssrc/base/common/downloadUtil.tssrc/base/credits/comfyCredits.tssrc/base/webviewDetection.tssrc/components/LiteGraphCanvasSplitterOverlay.vuesrc/components/MenuHamburger.vuesrc/components/TopMenuSection.test.tssrc/components/TopMenuSection.vuesrc/components/actionbar/BatchCountEdit.vuesrc/components/actionbar/ComfyActionbar.vuesrc/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/components/bottomPanel/tabs/shortcuts/ShortcutsList.vuesrc/components/bottomPanel/tabs/terminal/BaseTerminal.vuesrc/components/boundingbox/WidgetBoundingBox.test.tssrc/components/breadcrumb/SubgraphBreadcrumb.vuesrc/components/breadcrumb/SubgraphBreadcrumbItem.vuesrc/components/builder/AppModeWidgetList.vuesrc/components/builder/IoItem.vuesrc/components/builder/VueNodeSwitchPopup.vuesrc/components/builder/useBuilderSteps.tssrc/components/builder/useResolvedSelectedInputs.tssrc/components/common/BackgroundImageUpload.vuesrc/components/common/BadgePill.vuesrc/components/common/ColorCustomizationSelector.vuesrc/components/common/CustomizationDialog.vuesrc/components/common/DeviceInfo.vuesrc/components/common/DraggableList.vuesrc/components/common/EditableText.vuesrc/components/common/ExtensionSlot.vuesrc/components/common/FormColorPicker.vuesrc/components/common/FormImageUpload.vuesrc/components/common/FormItem.vuesrc/components/common/FormRadioGroup.vuesrc/components/common/LazyImage.vuesrc/components/common/ScrubableNumberInput.vuesrc/components/common/SystemStatsPanel.vuesrc/components/common/TextTicker.vuesrc/components/common/TreeExplorer.vuesrc/components/common/TreeExplorerTreeNode.vuesrc/components/common/TreeExplorerV2.vuesrc/components/common/TreeExplorerV2Node.vuesrc/components/common/VirtualGrid.test.tssrc/components/common/VirtualGrid.vuesrc/components/curve/WidgetCurve.vuesrc/components/curve/curveUtils.test.tssrc/components/curve/curveUtils.tssrc/components/custom/widget/WorkflowTemplateSelectorDialog.vuesrc/components/dialog/content/ErrorDialogContent.vuesrc/components/dialog/content/SignInContent.vuesrc/components/dialog/content/TopUpCreditsDialogContentLegacy.vuesrc/components/dialog/content/setting/KeybindingPanel.vuesrc/components/dialog/content/setting/LegacyCreditsPanel.vuesrc/components/dialog/content/setting/UsageLogsTable.vuesrc/components/dialog/content/setting/keybinding/EditKeybindingContent.vuesrc/components/dialog/content/signin/SignInForm.vuesrc/components/dialog/content/signin/SignUpForm.vuesrc/components/dialog/rekaPrimeVueBridge.tssrc/components/error/useErrorOverlayState.tssrc/components/graph/CanvasModeSelector.vuesrc/components/graph/DomWidgets.vuesrc/components/graph/GraphCanvas.vuesrc/components/graph/NodeContextMenu.vuesrc/components/graph/NodeTooltip.vuesrc/components/graph/TitleEditor.vuesrc/components/graph/modals/ZoomControlsModal.vuesrc/components/graph/selectionToolbox/ColorPickerButton.vuesrc/components/graph/selectionToolbox/ExecuteButton.vuesrc/components/graph/selectionToolbox/SubmenuPopover.vuesrc/components/graph/widgets/DomWidget.vuesrc/components/helpcenter/HelpCenterMenuContent.vuesrc/components/imagecrop/WidgetImageCrop.test.tssrc/components/load3d/Load3D.test.tssrc/components/load3d/Load3DControls.test.tssrc/components/load3d/Load3DControls.vuesrc/components/load3d/Load3DScene.vuesrc/components/load3d/Load3dViewerContent.test.tssrc/components/load3d/Load3dViewerContent.vuesrc/components/load3d/controls/ExportControls.test.tssrc/components/load3d/controls/ExportControls.vuesrc/components/load3d/controls/LightControls.vuesrc/components/load3d/controls/ModelControls.test.tssrc/components/load3d/controls/ModelControls.vuesrc/components/load3d/controls/PopupSlider.vuesrc/components/load3d/controls/RecordingControls.vuesrc/components/load3d/controls/SceneControls.vuesrc/components/load3d/controls/viewer/ViewerSceneControls.vuesrc/components/maskeditor/BrushCursor.vuesrc/components/maskeditor/BrushSettingsPanel.vuesrc/components/maskeditor/ImageLayerSettingsPanel.test.tssrc/components/maskeditor/ImageLayerSettingsPanel.vuesrc/components/maskeditor/MaskEditorContent.vuesrc/components/maskeditor/PointerZone.vuesrc/components/maskeditor/SettingsPanelContainer.vuesrc/components/maskeditor/ToolPanel.test.tssrc/components/maskeditor/controls/DropdownControl.vuesrc/components/node/NodePreview.vuesrc/components/painter/WidgetPainter.test.tssrc/components/primevueOverride/AutoCompletePlus.vuesrc/components/queue/QueueNotificationBanner.vuesrc/components/queue/QueueProgressOverlay.vuesrc/components/queue/job/JobAssetsList.vuesrc/components/queue/job/JobDetailsPopover.vuesrc/components/queue/job/JobFilterActions.vuesrc/components/queue/job/useJobErrorReporting.tssrc/components/queue/job/useQueueEstimates.tssrc/components/range/WidgetRange.vuesrc/components/range/rangeUtils.test.tssrc/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/ErrorNodeCard.vuesrc/components/rightSidePanel/errors/MissingPackGroupRow.vuesrc/components/rightSidePanel/errors/TabErrors.vuesrc/components/rightSidePanel/errors/useErrorGroups.tssrc/components/rightSidePanel/errors/useErrorReport.tssrc/components/rightSidePanel/parameters/SectionWidgets.vuesrc/components/rightSidePanel/parameters/TabNodes.vuesrc/components/rightSidePanel/parameters/TabNormalInputs.vuesrc/components/rightSidePanel/parameters/TabSubgraphInputs.vuesrc/components/rightSidePanel/settings/NodeSettings.vuesrc/components/rightSidePanel/settings/SetNodeColor.vuesrc/components/rightSidePanel/settings/SetNodeState.vuesrc/components/rightSidePanel/settings/TabGlobalSettings.vuesrc/components/rightSidePanel/shared.tssrc/components/rightSidePanel/subgraph/SubgraphEditor.vuesrc/components/searchbox/NodeSearchBox.vuesrc/components/searchbox/NodeSearchBoxPopover.vuesrc/components/searchbox/NodeSearchFilter.vuesrc/components/searchbox/v2/NodeSearchCategorySidebar.vuesrc/components/searchbox/v2/NodeSearchCategoryTreeNode.vuesrc/components/searchbox/v2/NodeSearchContent.test.tssrc/components/searchbox/v2/NodeSearchContent.vuesrc/components/searchbox/v2/NodeSearchFilterBar.vuesrc/components/searchbox/v2/NodeSearchTypeFilterPopover.vuesrc/components/searchbox/v2/__test__/testUtils.tssrc/components/sidebar/ComfyMenuButton.vuesrc/components/sidebar/SideToolbar.vuesrc/components/sidebar/tabs/AssetsSidebarListView.vuesrc/components/sidebar/tabs/AssetsSidebarTab.vuesrc/components/sidebar/tabs/BaseWorkflowsSidebarTab.test.tssrc/components/sidebar/tabs/BaseWorkflowsSidebarTab.vuesrc/components/sidebar/tabs/JobHistorySidebarTab.vuesrc/components/sidebar/tabs/ModelLibrarySidebarTab.vuesrc/components/sidebar/tabs/NodeLibrarySidebarTab.vuesrc/components/sidebar/tabs/NodeLibrarySidebarTabV2.vuesrc/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vuesrc/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vuesrc/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vuesrc/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vuesrc/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vuesrc/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vuesrc/components/sidebar/tabs/queue/MediaLightbox.vuesrc/components/sidebar/tabs/workflows/WorkflowTreeLeaf.vuesrc/components/tab/Tab.vuesrc/components/toast/GlobalToast.vuesrc/components/topbar/CurrentUserPopoverLegacy.vuesrc/components/topbar/LoginButton.vuesrc/components/topbar/TopbarBadge.vuesrc/components/topbar/WorkflowTab.vuesrc/components/topbar/WorkflowTabPopover.vuesrc/components/topbar/WorkflowTabs.vuesrc/components/ui/color-picker/ColorPicker.vuesrc/components/ui/color-picker/ColorPickerSlider.vuesrc/components/ui/multi-select/MultiSelect.vuesrc/components/ui/search-input/AsyncSearchInput.vuesrc/components/ui/search-input/SearchAutocomplete.vuesrc/components/ui/stepper/FormattedNumberStepper.vuesrc/components/ui/tags-input/TagsInput.vuesrc/components/widget/layout/BaseModalLayout.vuesrc/components/widget/panel/LeftSidePanel.vuesrc/composables/auth/useAuthActions.tssrc/composables/auth/useCurrentUser.tssrc/composables/billing/useBillingContext.tssrc/composables/billing/useLegacyBilling.tssrc/composables/bottomPanelTabs/useCommandSubcategories.tssrc/composables/bottomPanelTabs/useTerminal.tssrc/composables/canvas/useSelectedLiteGraphItems.tssrc/composables/canvas/useSelectionToolboxPosition.tssrc/composables/element/useDomClipping.test.tssrc/composables/element/useDomClipping.tssrc/composables/element/useOverflowObserver.tssrc/composables/functional/useChainCallback.tssrc/composables/graph/contextMenuConverter.test.tssrc/composables/graph/contextMenuConverter.tssrc/composables/graph/useArrangeNodes.tssrc/composables/graph/useErrorClearingHooks.tssrc/composables/graph/useGraphHierarchy.test.tssrc/composables/graph/useGraphNodeManager.tssrc/composables/graph/useMoreOptionsMenu.tssrc/composables/graph/useNodeArrangement.tssrc/composables/graph/useNodeCustomization.tssrc/composables/graph/useNodeErrorFlagSync.tssrc/composables/graph/useSelectionMenuOptions.tssrc/composables/graph/useSubgraphOperations.tssrc/composables/graph/useVueNodeLifecycle.tssrc/composables/maskeditor/StrokeProcessor.test.tssrc/composables/maskeditor/StrokeProcessor.tssrc/composables/maskeditor/brushDrawingUtils.tssrc/composables/maskeditor/gpu/GPUBrushRenderer.test.tssrc/composables/maskeditor/gpuUtils.tssrc/composables/maskeditor/useBrushAdjustment.tssrc/composables/maskeditor/useBrushDrawing.tssrc/composables/maskeditor/useBrushPersistence.tssrc/composables/maskeditor/useCanvasHistory.test.tssrc/composables/maskeditor/useCanvasHistory.tssrc/composables/maskeditor/useCanvasManager.test.tssrc/composables/maskeditor/useCanvasManager.tssrc/composables/maskeditor/useCanvasTools.test.tssrc/composables/maskeditor/useCanvasTools.tssrc/composables/maskeditor/useCanvasTransform.test.tssrc/composables/maskeditor/useCanvasTransform.tssrc/composables/maskeditor/useImageLoader.tssrc/composables/maskeditor/useKeyboard.tssrc/composables/maskeditor/useMaskEditorLoader.tssrc/composables/maskeditor/useMaskEditorSaver.tssrc/composables/maskeditor/usePanAndZoom.tssrc/composables/maskeditor/useToolManager.tssrc/composables/node/useNodeBadge.tssrc/composables/node/useNodeDragToCanvas.tssrc/composables/node/useNodeImage.tssrc/composables/node/useNodeImageUpload.ts
✅ Files skipped from review due to trivial changes (212)
- src/components/dialog/content/ErrorDialogContent.vue
- src/components/maskeditor/controls/DropdownControl.vue
- src/components/queue/job/useJobErrorReporting.ts
- src/components/common/ExtensionSlot.vue
- src/components/common/BadgePill.vue
- browser_tests/fixtures/helpers/TemplateHelper.ts
- src/components/dialog/content/SignInContent.vue
- src/components/sidebar/tabs/workflows/WorkflowTreeLeaf.vue
- browser_tests/tests/previewAsText.spec.ts
- src/composables/element/useOverflowObserver.ts
- src/components/common/LazyImage.vue
- browser_tests/tests/changeTracker.spec.ts
- src/components/curve/curveUtils.test.ts
- src/composables/functional/useChainCallback.ts
- browser_tests/fixtures/utils/selectionToolboxMoreOptions.ts
- src/composables/bottomPanelTabs/useCommandSubcategories.ts
- browser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.ts
- browser_tests/tests/featureFlags.spec.ts
- browser_tests/tests/subgraphPromotedWidgetPanel.spec.ts
- browser_tests/tests/selectionToolboxSubmenus.spec.ts
- src/components/maskeditor/MaskEditorContent.vue
- browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts
- browser_tests/tests/nodeContextMenuOverflow.spec.ts
- src/composables/graph/useGraphHierarchy.test.ts
- src/components/range/rangeUtils.test.ts
- src/components/load3d/controls/ExportControls.test.ts
- src/composables/bottomPanelTabs/useTerminal.ts
- browser_tests/tests/sidebar/assets-filter.spec.ts
- src/components/common/CustomizationDialog.vue
- src/composables/maskeditor/useBrushAdjustment.ts
- src/composables/maskeditor/StrokeProcessor.test.ts
- src/components/topbar/TopbarBadge.vue
- src/components/primevueOverride/AutoCompletePlus.vue
- src/components/load3d/Load3D.test.ts
- src/components/searchbox/v2/NodeSearchContent.test.ts
- src/composables/graph/useSelectionMenuOptions.ts
- src/components/sidebar/ComfyMenuButton.vue
- browser_tests/tests/workflowTabThumbnail.spec.ts
- src/components/dialog/content/signin/SignUpForm.vue
- src/components/imagecrop/WidgetImageCrop.test.ts
- src/components/common/BackgroundImageUpload.vue
- src/components/load3d/controls/SceneControls.vue
- src/components/load3d/Load3DControls.vue
- src/components/maskeditor/SettingsPanelContainer.vue
- src/components/dialog/content/setting/LegacyCreditsPanel.vue
- src/composables/maskeditor/useBrushPersistence.ts
- src/components/builder/VueNodeSwitchPopup.vue
- src/components/maskeditor/ImageLayerSettingsPanel.test.ts
- src/composables/maskeditor/StrokeProcessor.ts
- browser_tests/fixtures/jobsRouteFixture.ts
- src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
- src/components/maskeditor/BrushCursor.vue
- src/components/sidebar/tabs/AssetsSidebarListView.vue
- src/components/load3d/controls/ExportControls.vue
- browser_tests/tests/vueNodes/widgets/float/floatWidget.spec.ts
- browser_tests/tests/wsReconnectStaleJob.spec.ts
- src/composables/graph/useNodeArrangement.ts
- src/components/load3d/controls/viewer/ViewerSceneControls.vue
- src/components/common/FormColorPicker.vue
- src/components/common/DeviceInfo.vue
- src/components/ui/multi-select/MultiSelect.vue
- browser_tests/fixtures/utils/builderTestUtils.ts
- src/components/dialog/rekaPrimeVueBridge.ts
- src/components/common/TreeExplorerTreeNode.vue
- browser_tests/tests/execution.spec.ts
- src/composables/node/useNodeImage.ts
- src/composables/graph/contextMenuConverter.test.ts
- src/components/boundingbox/WidgetBoundingBox.test.ts
- src/components/searchbox/v2/test/testUtils.ts
- src/composables/maskeditor/useCanvasManager.test.ts
- src/components/queue/job/JobFilterActions.vue
- src/components/rightSidePanel/parameters/TabSubgraphInputs.vue
- src/components/searchbox/v2/NodeSearchFilterBar.vue
- src/composables/element/useDomClipping.test.ts
- src/components/load3d/Load3dViewerContent.test.ts
- src/components/searchbox/NodeSearchFilter.vue
- src/components/load3d/Load3DControls.test.ts
- src/components/sidebar/tabs/NodeLibrarySidebarTab.vue
- src/components/common/TreeExplorer.vue
- src/components/common/FormImageUpload.vue
- src/components/dialog/content/setting/UsageLogsTable.vue
- src/composables/maskeditor/useKeyboard.ts
- browser_tests/fixtures/helpers/PublishApiHelper.ts
- src/components/maskeditor/BrushSettingsPanel.vue
- src/components/dialog/content/TopUpCreditsDialogContentLegacy.vue
- browser_tests/tests/appModeDropdownClipping.spec.ts
- src/components/load3d/controls/PopupSlider.vue
- src/composables/maskeditor/useImageLoader.ts
- browser_tests/tests/actionbar.spec.ts
- src/components/rightSidePanel/parameters/TabNodes.vue
- src/components/dialog/content/signin/SignInForm.vue
- browser_tests/fixtures/helpers/UserDataHelper.ts
- src/composables/graph/useNodeErrorFlagSync.ts
- src/components/graph/CanvasModeSelector.vue
- browser_tests/fixtures/helpers/CloudAuthHelper.ts
- browser_tests/tests/vueNodes/groups/groups.spec.ts
- src/composables/maskeditor/useCanvasHistory.test.ts
- src/composables/maskeditor/brushDrawingUtils.ts
- browser_tests/tests/remoteWidgets.spec.ts
- browser_tests/fixtures/utils/customMatchers.ts
- browser_tests/tests/keybindingPresets.spec.ts
- src/components/widget/panel/LeftSidePanel.vue
- src/composables/maskeditor/useCanvasHistory.ts
- src/composables/billing/useLegacyBilling.ts
- browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
- src/components/rightSidePanel/parameters/TabNormalInputs.vue
- browser_tests/tests/nodeGhostPlacement.spec.ts
- src/composables/maskeditor/gpuUtils.ts
- src/composables/maskeditor/useCanvasTransform.test.ts
- src/components/actionbar/ComfyRunButton/ComfyQueueButton.vue
- src/components/topbar/CurrentUserPopoverLegacy.vue
- src/components/maskeditor/ToolPanel.test.ts
- src/components/sidebar/tabs/queue/MediaLightbox.vue
- src/composables/graph/useVueNodeLifecycle.ts
- src/composables/maskeditor/useMaskEditorSaver.ts
- browser_tests/fixtures/sharedWorkflowImportFixture.ts
- src/base/common/async.ts
- src/components/curve/curveUtils.ts
- src/components/widget/layout/BaseModalLayout.vue
- src/components/common/ColorCustomizationSelector.vue
- src/components/searchbox/v2/NodeSearchTypeFilterPopover.vue
- browser_tests/tests/nodeHelp.spec.ts
- src/App.vue
- src/components/common/ScrubableNumberInput.vue
- src/base/credits/comfyCredits.ts
- src/components/load3d/controls/ModelControls.vue
- src/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vue
- src/components/ui/stepper/FormattedNumberStepper.vue
- src/components/maskeditor/ImageLayerSettingsPanel.vue
- src/components/error/useErrorOverlayState.ts
- src/components/builder/IoItem.vue
- browser_tests/fixtures/helpers/ModelLibraryHelper.ts
- src/components/rightSidePanel/parameters/SectionWidgets.vue
- src/components/graph/selectionToolbox/ColorPickerButton.vue
- browser_tests/fixtures/helpers/FeatureFlagHelper.ts
- src/composables/maskeditor/useToolManager.ts
- src/components/builder/useBuilderSteps.ts
- src/composables/maskeditor/gpu/GPUBrushRenderer.test.ts
- src/composables/maskeditor/usePanAndZoom.ts
- src/components/rightSidePanel/errors/useErrorReport.ts
- src/components/load3d/Load3dViewerContent.vue
- browser_tests/fixtures/components/SidebarTab.ts
- src/components/toast/GlobalToast.vue
- src/components/breadcrumb/SubgraphBreadcrumb.vue
- src/base/webviewDetection.ts
- browser_tests/tests/subgraph/subgraphCrud.spec.ts
- src/composables/graph/useArrangeNodes.ts
- src/components/rightSidePanel/errors/MissingPackGroupRow.vue
- src/composables/maskeditor/useMaskEditorLoader.ts
- src/components/range/WidgetRange.vue
- src/components/rightSidePanel/settings/TabGlobalSettings.vue
- browser_tests/fixtures/utils/painter.ts
- src/composables/maskeditor/useCanvasTools.ts
- src/components/graph/selectionToolbox/SubmenuPopover.vue
- src/composables/maskeditor/useCanvasTools.test.ts
- src/components/searchbox/NodeSearchBox.vue
- src/components/node/NodePreview.vue
- browser_tests/fixtures/utils/preview3dCameraState.ts
- src/composables/maskeditor/useCanvasManager.ts
- src/composables/maskeditor/useBrushDrawing.ts
- src/components/searchbox/v2/NodeSearchCategorySidebar.vue
- src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue
- browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
- src/composables/maskeditor/useCanvasTransform.ts
- src/components/builder/AppModeWidgetList.vue
- src/components/helpcenter/HelpCenterMenuContent.vue
- src/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vue
- src/components/load3d/controls/ModelControls.test.ts
- src/composables/graph/useSubgraphOperations.ts
- src/components/rightSidePanel/errors/ErrorNodeCard.vue
- src/components/custom/widget/WorkflowTemplateSelectorDialog.vue
- src/composables/graph/useMoreOptionsMenu.ts
- src/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vue
- browser_tests/fixtures/helpers/PerformanceHelper.ts
- src/components/rightSidePanel/settings/SetNodeState.vue
- src/components/graph/selectionToolbox/ExecuteButton.vue
- src/components/curve/WidgetCurve.vue
- browser_tests/tests/subgraph/subgraphSerialization.spec.ts
- src/components/ui/search-input/AsyncSearchInput.vue
- src/composables/element/useDomClipping.ts
- src/components/painter/WidgetPainter.test.ts
- browser_tests/fixtures/ComfyPage.ts
- browser_tests/fixtures/helpers/CanvasHelper.ts
- src/components/queue/QueueProgressOverlay.vue
- src/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vue
- browser_tests/tests/i18nLocaleFallback.spec.ts
- browser_tests/fixtures/helpers/AssetHelper.ts
- browser_tests/tests/painter.spec.ts
- src/components/common/VirtualGrid.vue
- src/composables/auth/useAuthActions.ts
- src/composables/billing/useBillingContext.ts
- src/components/LiteGraphCanvasSplitterOverlay.vue
- src/composables/canvas/useSelectionToolboxPosition.ts
- src/composables/graph/contextMenuConverter.ts
- src/composables/graph/useGraphNodeManager.ts
- src/base/common/downloadUtil.ts
- browser_tests/tests/nodeBadge.spec.ts
- src/components/rightSidePanel/RightSidePanel.vue
- src/components/graph/GraphCanvas.vue
- src/components/builder/useResolvedSelectedInputs.ts
- browser_tests/tests/performance.spec.ts
- browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
- src/components/searchbox/v2/NodeSearchContent.vue
- src/components/queue/job/JobDetailsPopover.vue
- browser_tests/fixtures/helpers/WorkflowHelper.ts
- src/components/searchbox/NodeSearchBoxPopover.vue
- src/components/queue/job/JobAssetsList.vue
- src/components/sidebar/tabs/ModelLibrarySidebarTab.vue
- browser_tests/fixtures/helpers/AssetsHelper.ts
- browser_tests/tests/rerouteNode.spec.ts
- src/composables/graph/useErrorClearingHooks.ts
- browser_tests/fixtures/helpers/DragDropHelper.ts
🚧 Files skipped from review as they are similar to previous changes (12)
- browser_tests/tests/rendererToggleStability.spec.ts
- .oxlintrc.json
- src/components/ui/color-picker/ColorPickerSlider.vue
- src/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vue
- src/components/dialog/content/setting/keybinding/EditKeybindingContent.vue
- src/components/rightSidePanel/settings/SetNodeColor.vue
- browser_tests/tests/interaction.spec.ts
- browser_tests/fixtures/helpers/MaskEditorHelper.ts
- src/components/dialog/content/setting/KeybindingPanel.vue
- src/components/sidebar/tabs/JobHistorySidebarTab.vue
- src/components/rightSidePanel/errors/useErrorGroups.ts
- src/components/graph/NodeTooltip.vue
| const handleEmptySpaceClick = () => { | ||
| if (hasSelection) { | ||
| clearSelection() | ||
| } | ||
| if (hasSelection) clearSelection() | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use the reactive boolean value, not the ref object.
Line 642 checks hasSelection (the ref object) instead of its boolean value, so the condition is always truthy and clearSelection() runs on every empty-space click.
Suggested fix
const handleEmptySpaceClick = () => {
- if (hasSelection) clearSelection()
+ if (hasSelection.value) clearSelection()
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const handleEmptySpaceClick = () => { | |
| if (hasSelection) { | |
| clearSelection() | |
| } | |
| if (hasSelection) clearSelection() | |
| } | |
| const handleEmptySpaceClick = () => { | |
| if (hasSelection.value) clearSelection() | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/sidebar/tabs/AssetsSidebarTab.vue` around lines 641 - 643, The
click handler handleEmptySpaceClick is checking the ref object hasSelection
instead of its boolean value, causing clearSelection() to always run; update the
condition to use the reactive boolean (e.g., hasSelection.value or a
computed/unwrapped boolean) so clearSelection() only runs when hasSelection is
true, keeping the call site inside handleEmptySpaceClick and leaving
clearSelection unchanged.
There was a problem hiding this comment.
Real bug, confirmed — hasSelection is a ref (compare line 431: hasSelection.value && ...), so this branch is always truthy and clearSelection() runs on every empty-space click. But pre-existing on main (the original if (hasSelection) { clearSelection() } had the same bug — braces don't change the predicate). The lint autofix just made the bug more visible by collapsing it to one line.
Deferring to a separate PR to keep this one mechanical. One-line fix: hasSelection → hasSelection.value.
There was a problem hiding this comment.
Skipped: comment is from another GitHub bot.
PR Created by the Glary-Bot Agent
Enables the
eslint/curlyrule in.oxlintrc.json(default"all"option — require braces on everyif/else/for/while/do/with), and fixes the existing 4947 violations across the codebase.Approach
"curly": "error"to.oxlintrc.json.pnpm oxlint --fix— autofixer resolved 4942 / 4947 violations.src/lib/litegraph/src/utils/type.tssrc/lib/litegraph/src/LGraphCanvas.ts(2 sites)src/core/graph/subgraph/migration/proxyWidgetMigration.tssrc/components/builder/AppModeWidgetList.vue@ts-expect-errordirectives that the autofixer separated from the line they were suppressing (LGraphCanvas.ts× 3,LGraphNode.ts× 2).eslint-disable-next-line no-emptyto two intentional empty-bodywhileloops (LGraph.ts,LGraphCanvas.ts) where side effects happen in the condition.pnpm formatafter the fixes.Verification
pnpm oxlint— 0 errorspnpm exec eslint src --cache— 0 errorspnpm stylelint— 0 errorspnpm format:check— cleanpnpm typecheck(vue-tsc --noEmit) — 0 errorspnpm build— successfulpnpm test:unit— 11368 passed. One pre-existing failure insrc/extensions/core/load3dLazy.test.ts(circular dependency:Class extends value undefinedinAssetWidget→BaseWidget); reproduces onmainand is unrelated to this change.Note on litegraph
src/lib/litegraph/AGENTS.mdpreviously suggested "prefer single lineifsyntax for concise expressions." That guideline is now superseded by the project-wide curly rule. Worth a follow-up edit to the litegraph AGENTS.md if you want to keep the two in sync.