Skip to content

style: enable oxlint eslint/curly rule and fix violations - #12825

Closed
DrJKL wants to merge 3 commits into
mainfrom
glary/enable-curly-rule
Closed

DrJKL wants to merge 3 commits into
mainfrom
glary/enable-curly-rule

Conversation

@DrJKL

@DrJKL DrJKL commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Enables the eslint/curly rule in .oxlintrc.json (default "all" option — require braces on every if/else/for/while/do/with), and fixes the existing 4947 violations across the codebase.

Approach

  1. Added "curly": "error" to .oxlintrc.json.
  2. Ran pnpm oxlint --fix — autofixer resolved 4942 / 4947 violations.
  3. Fixed the 5 remaining nested cases by hand (autofixer wraps the outer statement but does not recurse into the body):
    • src/lib/litegraph/src/utils/type.ts
    • src/lib/litegraph/src/LGraphCanvas.ts (2 sites)
    • src/core/graph/subgraph/migration/proxyWidgetMigration.ts
    • src/components/builder/AppModeWidgetList.vue
  4. Repaired four @ts-expect-error directives that the autofixer separated from the line they were suppressing (LGraphCanvas.ts × 3, LGraphNode.ts × 2).
  5. Added eslint-disable-next-line no-empty to two intentional empty-body while loops (LGraph.ts, LGraphCanvas.ts) where side effects happen in the condition.
  6. Ran pnpm format after the fixes.

Verification

  • pnpm oxlint — 0 errors
  • pnpm exec eslint src --cache — 0 errors
  • pnpm stylelint — 0 errors
  • pnpm format:check — clean
  • pnpm typecheck (vue-tsc --noEmit) — 0 errors
  • pnpm build — successful
  • pnpm test:unit — 11368 passed. One pre-existing failure in src/extensions/core/load3dLazy.test.ts (circular dependency: Class extends value undefined in AssetWidget → BaseWidget); reproduces on main and is unrelated to this change.

Note on litegraph

src/lib/litegraph/AGENTS.md previously suggested "prefer single line if syntax for concise expressions." That guideline is now superseded by the project-wide curly rule. Worth a follow-up edit to the litegraph AGENTS.md if you want to keep the two in sync.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adds a curly lint rule and reformats conditional and loop bodies across browser fixtures, browser tests, core utilities, composables, and Vue components.

Changes

Curly enforcement and control-flow formatting

Layer / File(s) Summary
Lint rule and browser fixture updates
*.oxlintrc.json, browser_tests/fixtures/*, browser_tests/fixtures/helpers/*, browser_tests/fixtures/components/*
curly is added to lint config, and browser fixture helpers/components change guard and loop structure around setup, routing, teardown, and Playwright actions.
Base, composable, and shared logic
src/base/*, src/components/*, src/composables/*
Conditional returns, early exits, and loop bodies are reformatted across core utilities, composables, shared helpers, and many Vue components.
Browser tests and e2e helpers
browser_tests/tests/*, src/**/__test__/*, src/**/*.test.ts
Playwright tests and browser-side helpers adjust polling predicates, guard checks, and repeated loop bodies without changing assertions or fixtures.
UI components and sidebar flows
src/components/**
Vue components for menus, sidebars, dialogs, graph UI, load3d, search, queue, and mask editor simplify branching and watcher callbacks while preserving the same emitted actions and returned values.
Mask editor and graph utilities
src/composables/maskeditor/*, src/composables/graph/*
Mask editor, graph, and related utility code reformat guards, recursive loops, and state synchronization paths without changing the underlying calculations or state transitions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Suggested labels

size:M

Poem

A bunny hopped through braces neat,
and tidied loops with thumping feet. 🐰
“Curly braces,” it softly said,
“now guard the code in lines well-bred.”
Then off it bounced, quite tidy-eyed.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/enable-curly-rule

@github-actions

github-actions Bot commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/12/2026, 11:47:17 PM UTC

Links

@github-actions

github-actions Bot commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1665 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1646 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

@codecov

codecov Bot commented Jun 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 47.97980% with 309 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ponents/dialog/content/setting/KeybindingPanel.vue 0.00% 14 Missing ⚠️
src/composables/auth/useCurrentUser.ts 0.00% 13 Missing ⚠️
src/components/common/TreeExplorer.vue 0.00% 10 Missing ⚠️
src/composables/maskeditor/useMaskEditorLoader.ts 0.00% 10 Missing ⚠️
src/components/sidebar/tabs/AssetsSidebarTab.vue 0.00% 9 Missing ⚠️
...omponents/sidebar/tabs/NodeLibrarySidebarTabV2.vue 20.00% 8 Missing ⚠️
src/composables/graph/useMoreOptionsMenu.ts 0.00% 8 Missing ⚠️
src/components/graph/NodeContextMenu.vue 0.00% 7 Missing ⚠️
...c/components/breadcrumb/SubgraphBreadcrumbItem.vue 0.00% 6 Missing ⚠️
src/components/graph/GraphCanvas.vue 0.00% 6 Missing ⚠️
... and 103 more
@@             Coverage Diff             @@
##             main   #12825       +/-   ##
===========================================
- Coverage   76.13%   61.81%   -14.33%     
===========================================
  Files        1568     1457      -111     
  Lines       99425    73802    -25623     
  Branches    28786    19550     -9236     
===========================================
- Hits        75698    45621    -30077     
- Misses      22923    27827     +4904     
+ Partials      804      354      -450     
Flag Coverage Δ
e2e ?
unit 61.81% <47.97%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/base/assert.ts 100.00% <100.00%> (ø)
src/base/common/downloadUtil.ts 97.01% <100.00%> (+3.86%) ⬆️
src/base/credits/comfyCredits.ts 91.17% <ø> (ø)
src/base/webviewDetection.ts 86.66% <ø> (-10.21%) ⬇️
src/components/TopMenuSection.vue 87.31% <100.00%> (-1.58%) ⬇️
src/components/actionbar/BatchCountEdit.vue 97.77% <100.00%> (-0.19%) ⬇️
...nents/bottomPanel/tabs/shortcuts/ShortcutsList.vue 100.00% <100.00%> (ø)
...ponents/bottomPanel/tabs/terminal/BaseTerminal.vue 94.44% <100.00%> (+1.94%) ⬆️
src/components/builder/useBuilderSteps.ts 95.83% <100.00%> (-0.17%) ⬇️
...rc/components/builder/useResolvedSelectedInputs.ts 96.15% <100.00%> (ø)
... and 186 more

... and 1073 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Enables the eslint/curly rule with ["multi-or-nest", "consistent"] options in .oxlintrc.json. Braces are required only for multi-line or nested blocks, with consistent brace use within if-else chains. All 3019 violations were resolved by oxlint --fix.
@glary-bot
glary-bot Bot force-pushed the glary/enable-curly-rule branch from 4c90fc2 to 0f549a9 Compare June 12, 2026 23:35
@glary-bot

glary-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Updated per feedback: switched the curly config from default "all" to ["multi-or-nest", "consistent"].

This requires braces only for multi-line / nested blocks and enforces consistent brace use within if/else chains — single-statement single-line bodies are now allowed (and required to be unbraced). It also lines up with the existing litegraph guideline ("prefer single line if syntax for concise expressions").

Force-pushed: previous 897-file diff is replaced by a single commit with 820 files / -3,635 net lines. All 3019 violations under the new config were resolved entirely via pnpm oxlint --fix — no manual fix-ups needed this round.

Re-verified: oxlint, eslint, stylelint, oxfmt, vue-tsc, vite build all green.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (7)
browser_tests/tests/subgraph/subgraphSerialization.spec.ts (1)

107-123: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Use the optional method call here.

isSubgraphNode is treated as optional elsewhere in this file, but hostNode?.isSubgraphNode() will still throw if the method is absent. Use the optional call form to keep this helper safe.

🔧 Proposed fix
-      if (!hostNode?.isSubgraphNode()) {
+      if (!hostNode?.isSubgraphNode?.()) {
         return ids.map(() => false)
       }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts` around lines 107
- 123, The evaluate callback can still throw if isSubgraphNode is undefined
because it is being invoked; change the invocation to use the optional call
operator so the check is safe: replace the current call to
hostNode?.isSubgraphNode() with hostNode?.isSubgraphNode?.() inside the evaluate
closure (also ensure subsequent access to hostNode.subgraph is only reached when
the optional call returned true). This targets the evaluate callback where
hostNode and isSubgraphNode are used.
browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts (1)

15-20: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

Avoid a module-scoped “future” timestamp here.

PUBLISHED_RECORD.publish_time can age out during a slow test run and make the shared-state case look stale. Generate the timestamp per test or use a fixed far-future value instead.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts` around lines 15 -
20, The module-scoped PUBLISHED_RECORD sets publish_time to Date.now()+60_000
which can become stale during slow runs; update the tests to set publish_time
dynamically per test (e.g., create or clone PUBLISHED_RECORD inside
beforeEach/each test and assign a fresh future timestamp) or replace the
module-scoped value with a fixed far-future ISO string; locate the
PUBLISHED_RECORD constant in shareWorkflowDialog.spec.ts and change its
publish_time handling so each test gets a non-expiring/fresh timestamp.
src/components/graph/GraphCanvas.vue (1)

355-381: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Don't drop setting updates when the canvas is still uninitialized.

Both watchers now return early on !canvasStore.canvas, but neither watch source includes canvas readiness. If the setting changes before the canvas exists, the update is lost and never replayed. Include canvasStore.canvas in the watched source or defer the work until setup completes.

Also applies to: 394-409

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/graph/GraphCanvas.vue` around lines 355 - 381, The watch on
settingStore.get('Comfy.WidgetControlMode') returns early when
canvasStore.canvas is not yet initialized, so setting changes that occur before
canvas readiness are dropped; update the watcher to include canvasStore.canvas
in its watch source (e.g. watch([() =>
settingStore.get('Comfy.WidgetControlMode'), () => canvasStore.canvas], ...)) or
otherwise defer/queue the update until canvasStore.canvas becomes truthy, then
run the same logic that iterates comfyApp.rootGraph via forEachNode and calls
updateControlWidgetLabel for widgets and linkedWidgets and finally
canvasStore.canvas.setDirty(true); apply the same change to the other watcher at
the noted lines (394-409) to ensure updates are replayed once the canvas is
initialized.
src/components/searchbox/NodeSearchBoxPopover.vue (1)

134-145: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Keep disconnectOnReset cleanup on every exit path.

The new early returns in addNode and showContextMenu skip the reconnect cleanup. If node creation fails or no link is available, disconnectOnReset stays armed and the next reset() can disconnect unrelated links.

Suggested cleanup
 function addNode(nodeDef: ComfyNodeDefImpl, dragEvent?: MouseEvent) {
   const followCursor = settingStore.get('Comfy.NodeSearchBoxImpl.FollowCursor')
   const node = withNodeAddSource('search_modal', () =>
@@
   )
   if (!node) {
+    disconnectOnReset = false
     return
   }
@@
 function showContextMenu(e: CanvasPointerEvent) {
   const firstLink = getFirstLink()
   if (!firstLink) {
+    disconnectOnReset = false
     return
   }

Also applies to: 205-209

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/searchbox/NodeSearchBoxPopover.vue` around lines 134 - 145,
addNode and showContextMenu currently return early without clearing the armed
disconnectOnReset state, so ensure disconnectOnReset cleanup always runs on
every exit path: after setting/arming disconnectOnReset (or before any early
return in addNode and showContextMenu) call the existing cleanup/reset function
or explicitly clear the disconnectOnReset flag (and any related listener) so it
cannot fire later on unrelated reset(); alternatively wrap the node
creation/link logic in a try/finally where the finally always performs the
disconnectOnReset cleanup; reference the disconnectOnReset variable and the
addNode and showContextMenu functions (and the reset() path) when applying the
fix.
src/components/graph/NodeTooltip.vue (1)

71-87: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Move the collapsed-node guard above the title-tooltip branch.

node.flags?.collapsed still reaches the title-description path, so collapsed nodes can keep showing tooltips when hovered on the title. Put the check before the title_mode block so every tooltip path is skipped.

💡 Suggested fix
   const node = canvas?.node_over
   if (!node || node.flags?.ghost) {
     return
   }
+  if (node.flags?.collapsed) {
+    return
+  }
 
   const ctor = node.constructor as { title_mode?: 0 | 1 | 2 | 3 }
   const nodeDef = nodeDefStore.nodeDefsByName[node.type ?? '']
@@
-  if (node.flags?.collapsed) {
-    return
-  }
-
   const inputSlot = isOverNodeInput(
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/graph/NodeTooltip.vue` around lines 71 - 87, Move the
collapsed-node guard so collapsed nodes never reach the title-tooltip logic: in
NodeTooltip.vue, check node.flags?.collapsed before the block that inspects
ctor.title_mode / LiteGraph.NO_TITLE and the canvas.graph_mouse vs node.pos
comparison (the block that calls showTooltip(nodeDef?.description)); return
early for collapsed nodes to skip all tooltip paths (the other relevant symbols
are node, nodeDef, ctor, canvas.graph_mouse, node.pos, and showTooltip).
src/components/node/NodePricingBadge.vue (1)

20-38: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Clear the old price before kicking off the new lookup.

priceLabel only changes on a successful match, so a renamed node can keep showing the previous node’s price while the new promise is in flight, or forever if it fails. Resetting the label at the start of the watcher avoids stale UI.

♻️ Proposed fix
 watch(
   () => nodeDef.name,
   (name) => {
     if (!nodeDef.api_node) {
       priceLabel.value = ''
       return
     }
+    priceLabel.value = ''
     const capturedName = name
     evaluateNodeDefPricing(nodeDef)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/node/NodePricingBadge.vue` around lines 20 - 38, In the watch
callback for () => nodeDef.name, clear the displayed price immediately when
starting a new lookup so stale prices don’t remain; specifically, after the
existing if (!nodeDef.api_node) branch (which already sets priceLabel.value =
''), also set priceLabel.value = '' right before calling
evaluateNodeDefPricing(nodeDef) so the UI is reset while the promise is in
flight, retaining the capturedName comparison and existing .then/.catch
handling.
src/components/graph/NodeContextMenu.vue (1)

296-323: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Clear stale submenu overflow styles when the menu fits.

constrainMenuHeight() only sets maxHeight / overflowY in the overflow case, but it never clears those inline styles on a later open when the menu is shorter. That can leave the submenu clipped or scrollable from the previous invocation.

🔧 Suggested fix
 function constrainMenuHeight() {
   const menuInstance = contextMenu.value as unknown as {
     container?: HTMLElement
   }
   const rootList = menuInstance?.container?.querySelector(
     ':scope > ul'
   ) as HTMLElement | null
   if (!rootList) {
     return
   }
 
+  rootList.style.maxHeight = ''
+  rootList.style.overflowY = ''
+
   const rect = rootList.getBoundingClientRect()
   const availableHeight = window.innerHeight - rect.top - 8
   if (availableHeight <= 0) {
     return
   }
@@
   if (rootList.scrollHeight <= availableHeight) {
     return
   }
 
   rootList.style.maxHeight = `${availableHeight}px`
   rootList.style.overflowY = 'auto'
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/graph/NodeContextMenu.vue` around lines 296 - 323,
constrainMenuHeight currently only applies inline styles when content overflows,
leaving stale maxHeight/overflowY on root <ul> from prior opens; update
constrainMenuHeight to explicitly clear rootList.style.maxHeight and
rootList.style.overflowY (set to empty string) whenever the menu does NOT need
the constraint (i.e., when availableHeight <= 0 OR when rootList.scrollHeight <=
availableHeight) so any previously-applied inline styles are removed; reference
the existing contextMenu.value -> menuInstance and rootList variables inside
constrainMenuHeight to locate where to clear the styles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/breadcrumb/SubgraphBreadcrumb.vue`:
- Around line 171-173: The early return inside the items-length guard (the "if
(items.length < 3) { return }" branch) leaves collapseTabs.value in a collapsed
state; before returning, explicitly reset collapseTabs.value = false so the
breadcrumb is expanded when the stack shrinks below three items (update the
conditional in SubgraphBreadcrumb.vue that checks items.length and ensure
collapseTabs.value is cleared prior to the return).

In `@src/components/queue/job/JobAssetsList.vue`:
- Around line 267-275: The current showDetailsNow function clears hover timers
before confirming the hovered job is still displayed, which can leave stale
details open; change the order so you first verify the job is displayed (using
hasDisplayedJob(nextActive.jobId)) and that any referenced DOM element
(activeRowElement) still corresponds to nextActive, and only then call
clearHoverTimers() and set activeDetails.value/isDetailsOpen.value; apply the
same pattern to the analogous logic in the other block (around the 306-331
region) to ensure timers are cleared only after the guard checks pass.

In `@src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue`:
- Around line 159-164: In handleContextMenu, call event.preventDefault() before
returning when !isUserBlueprint.value so the native browser context menu is
suppressed; specifically, update the handleContextMenu function to invoke
event.preventDefault() (or switch to using the `@contextmenu.prevent` modifier on
the component) and then return, leaving menu.value?.show(event) for the
isUserBlueprint.value case.

In `@src/composables/bottomPanelTabs/useLogsTerminal.ts`:
- Around line 86-117: Move creation of the AbortController (and assignment to
mountController) to before awaiting until(terminal).toBeTruthy() inside
onMounted in useLogsTerminal, then after the await check signal.aborted and
return early if true; ensure the rest of the flow (calling api.getRawLogs(),
writeEntries, and subscribe logic) only runs when mountController.signal is not
aborted. Specifically: create the controller and extract { signal } before
calling until(terminal).toBeTruthy(), and add a short-circuit check using
signal.aborted immediately after the await to prevent continuing into
getRawLogs() or subscribeLogs when unmounted.

---

Outside diff comments:
In `@browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts`:
- Around line 15-20: The module-scoped PUBLISHED_RECORD sets publish_time to
Date.now()+60_000 which can become stale during slow runs; update the tests to
set publish_time dynamically per test (e.g., create or clone PUBLISHED_RECORD
inside beforeEach/each test and assign a fresh future timestamp) or replace the
module-scoped value with a fixed far-future ISO string; locate the
PUBLISHED_RECORD constant in shareWorkflowDialog.spec.ts and change its
publish_time handling so each test gets a non-expiring/fresh timestamp.

In `@browser_tests/tests/subgraph/subgraphSerialization.spec.ts`:
- Around line 107-123: The evaluate callback can still throw if isSubgraphNode
is undefined because it is being invoked; change the invocation to use the
optional call operator so the check is safe: replace the current call to
hostNode?.isSubgraphNode() with hostNode?.isSubgraphNode?.() inside the evaluate
closure (also ensure subsequent access to hostNode.subgraph is only reached when
the optional call returned true). This targets the evaluate callback where
hostNode and isSubgraphNode are used.

In `@src/components/graph/GraphCanvas.vue`:
- Around line 355-381: The watch on settingStore.get('Comfy.WidgetControlMode')
returns early when canvasStore.canvas is not yet initialized, so setting changes
that occur before canvas readiness are dropped; update the watcher to include
canvasStore.canvas in its watch source (e.g. watch([() =>
settingStore.get('Comfy.WidgetControlMode'), () => canvasStore.canvas], ...)) or
otherwise defer/queue the update until canvasStore.canvas becomes truthy, then
run the same logic that iterates comfyApp.rootGraph via forEachNode and calls
updateControlWidgetLabel for widgets and linkedWidgets and finally
canvasStore.canvas.setDirty(true); apply the same change to the other watcher at
the noted lines (394-409) to ensure updates are replayed once the canvas is
initialized.

In `@src/components/graph/NodeContextMenu.vue`:
- Around line 296-323: constrainMenuHeight currently only applies inline styles
when content overflows, leaving stale maxHeight/overflowY on root <ul> from
prior opens; update constrainMenuHeight to explicitly clear
rootList.style.maxHeight and rootList.style.overflowY (set to empty string)
whenever the menu does NOT need the constraint (i.e., when availableHeight <= 0
OR when rootList.scrollHeight <= availableHeight) so any previously-applied
inline styles are removed; reference the existing contextMenu.value ->
menuInstance and rootList variables inside constrainMenuHeight to locate where
to clear the styles.

In `@src/components/graph/NodeTooltip.vue`:
- Around line 71-87: Move the collapsed-node guard so collapsed nodes never
reach the title-tooltip logic: in NodeTooltip.vue, check node.flags?.collapsed
before the block that inspects ctor.title_mode / LiteGraph.NO_TITLE and the
canvas.graph_mouse vs node.pos comparison (the block that calls
showTooltip(nodeDef?.description)); return early for collapsed nodes to skip all
tooltip paths (the other relevant symbols are node, nodeDef, ctor,
canvas.graph_mouse, node.pos, and showTooltip).

In `@src/components/node/NodePricingBadge.vue`:
- Around line 20-38: In the watch callback for () => nodeDef.name, clear the
displayed price immediately when starting a new lookup so stale prices don’t
remain; specifically, after the existing if (!nodeDef.api_node) branch (which
already sets priceLabel.value = ''), also set priceLabel.value = '' right before
calling evaluateNodeDefPricing(nodeDef) so the UI is reset while the promise is
in flight, retaining the capturedName comparison and existing .then/.catch
handling.

In `@src/components/searchbox/NodeSearchBoxPopover.vue`:
- Around line 134-145: addNode and showContextMenu currently return early
without clearing the armed disconnectOnReset state, so ensure disconnectOnReset
cleanup always runs on every exit path: after setting/arming disconnectOnReset
(or before any early return in addNode and showContextMenu) call the existing
cleanup/reset function or explicitly clear the disconnectOnReset flag (and any
related listener) so it cannot fire later on unrelated reset(); alternatively
wrap the node creation/link logic in a try/finally where the finally always
performs the disconnectOnReset cleanup; reference the disconnectOnReset variable
and the addNode and showContextMenu functions (and the reset() path) when
applying the fix.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a5dfa38c-48fd-44e0-bee4-f0e7b1c196b6

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5801d and 4c90fc2.

📒 Files selected for processing (300)
  • .oxlintrc.json
  • browser_tests/fixtures/ComfyMouse.ts
  • browser_tests/fixtures/ComfyPage.ts
  • browser_tests/fixtures/VueNodeHelpers.ts
  • browser_tests/fixtures/components/ComfyNodeSearchBoxV2.ts
  • browser_tests/fixtures/components/SubgraphEditor.ts
  • browser_tests/fixtures/helpers/AppModeHelper.ts
  • browser_tests/fixtures/helpers/AppModeWidgetHelper.ts
  • browser_tests/fixtures/helpers/AssetHelper.ts
  • browser_tests/fixtures/helpers/AssetsHelper.ts
  • browser_tests/fixtures/helpers/BuilderSelectHelper.ts
  • browser_tests/fixtures/helpers/CanvasHelper.ts
  • browser_tests/fixtures/helpers/CommandHelper.ts
  • browser_tests/fixtures/helpers/DragDropHelper.ts
  • browser_tests/fixtures/helpers/FeatureFlagHelper.ts
  • browser_tests/fixtures/helpers/MaskEditorHelper.ts
  • browser_tests/fixtures/helpers/MobileAppHelper.ts
  • browser_tests/fixtures/helpers/ModelLibraryHelper.ts
  • browser_tests/fixtures/helpers/NodeOperationsHelper.ts
  • browser_tests/fixtures/helpers/PerformanceHelper.ts
  • browser_tests/fixtures/helpers/Preview3DPipelineFixture.ts
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/fixtures/helpers/UserDataHelper.ts
  • browser_tests/fixtures/helpers/WorkflowHelper.ts
  • browser_tests/fixtures/sharedWorkflowImportFixture.ts
  • browser_tests/fixtures/utils/boundsUtils.ts
  • browser_tests/fixtures/utils/dragAndDrop.ts
  • browser_tests/fixtures/utils/fitToView.ts
  • browser_tests/fixtures/utils/groupHelpers.ts
  • browser_tests/fixtures/utils/litegraphUtils.ts
  • browser_tests/fixtures/utils/mimeTypeUtil.ts
  • browser_tests/fixtures/utils/painter.ts
  • browser_tests/fixtures/utils/perfReporter.ts
  • browser_tests/fixtures/utils/preview3dCameraState.ts
  • browser_tests/fixtures/utils/promotedWidgets.ts
  • browser_tests/fixtures/utils/slotBoundsUtil.ts
  • browser_tests/fixtures/ws.ts
  • browser_tests/tests/appMode.spec.ts
  • browser_tests/tests/assetDeleteClearsLoadImage.spec.ts
  • browser_tests/tests/builderSaveFlow.spec.ts
  • browser_tests/tests/changeTrackerLoadGuard.spec.ts
  • browser_tests/tests/cloud-asset-default.spec.ts
  • browser_tests/tests/colorPalette.spec.ts
  • browser_tests/tests/containAudit.spec.ts
  • browser_tests/tests/curveWidget.spec.ts
  • browser_tests/tests/customIcons.spec.ts
  • browser_tests/tests/dialogs/settingsDialog.spec.ts
  • browser_tests/tests/dialogs/shareWorkflowDialog.spec.ts
  • browser_tests/tests/graph.spec.ts
  • browser_tests/tests/groupNode.spec.ts
  • browser_tests/tests/groupSelectChildren.spec.ts
  • browser_tests/tests/imageCompare.spec.ts
  • browser_tests/tests/interaction.spec.ts
  • browser_tests/tests/load3d/load3d.spec.ts
  • browser_tests/tests/maskEditor.spec.ts
  • browser_tests/tests/minimap.spec.ts
  • browser_tests/tests/nodeBadge.spec.ts
  • browser_tests/tests/nodeGhostPlacement.spec.ts
  • browser_tests/tests/nodeTemplates.spec.ts
  • browser_tests/tests/painter.spec.ts
  • browser_tests/tests/performance.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabMissingMediaRuntime.spec.ts
  • browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts
  • browser_tests/tests/queue/queueOverlay.spec.ts
  • browser_tests/tests/queue/queueSettings.spec.ts
  • browser_tests/tests/rendererToggleStability.spec.ts
  • browser_tests/tests/rerouteNode.spec.ts
  • browser_tests/tests/sharedWorkflowMissingMedia.spec.ts
  • browser_tests/tests/sidebar/assets.spec.ts
  • browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
  • browser_tests/tests/sidebar/workflows.spec.ts
  • browser_tests/tests/subgraph/subgraphCrud.spec.ts
  • browser_tests/tests/subgraph/subgraphDraftPositions.spec.ts
  • browser_tests/tests/subgraph/subgraphLifecycle.spec.ts
  • browser_tests/tests/subgraph/subgraphNavigation.spec.ts
  • browser_tests/tests/subgraph/subgraphPromotion.spec.ts
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts
  • browser_tests/tests/subgraph/subgraphSlots.spec.ts
  • browser_tests/tests/topbar/workflowTabs.spec.ts
  • browser_tests/tests/vueNodes/interactions/canvas/zoom.spec.ts
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/bringToFront.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/contextMenu.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/move.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/rename.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/resize.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/select.spec.ts
  • browser_tests/tests/vueNodes/nodeStates/collapse.spec.ts
  • browser_tests/tests/vueNodes/nodeStates/error.spec.ts
  • browser_tests/tests/vueNodes/nodeStates/pin.spec.ts
  • browser_tests/tests/vueNodes/widgets/imageCrop.spec.ts
  • browser_tests/tests/webcamCapture.spec.ts
  • browser_tests/tests/widget.spec.ts
  • browser_tests/tests/workflowPersistence.spec.ts
  • browser_tests/tests/workflowSettings.spec.ts
  • browser_tests/utils/backupUtils.ts
  • src/base/assert.ts
  • src/base/common/downloadUtil.ts
  • src/base/credits/comfyCredits.ts
  • src/base/webviewDetection.ts
  • src/components/LiteGraphCanvasSplitterOverlay.vue
  • src/components/TopMenuSection.test.ts
  • src/components/TopMenuSection.vue
  • src/components/actionbar/ComfyActionbar.test.ts
  • src/components/actionbar/ComfyActionbar.vue
  • src/components/bottomPanel/tabs/terminal/BaseTerminal.vue
  • src/components/bottomPanel/tabs/terminal/CommandTerminal.vue
  • src/components/breadcrumb/SubgraphBreadcrumb.vue
  • src/components/builder/AppBuilder.vue
  • src/components/builder/AppModeWidgetList.vue
  • src/components/builder/BuilderFooterToolbar.vue
  • src/components/builder/BuilderMenu.vue
  • src/components/builder/IoItem.vue
  • src/components/builder/useAppModeWidgetResizing.ts
  • src/components/builder/useBuilderSave.test.ts
  • src/components/builder/useBuilderSave.ts
  • src/components/builder/useBuilderSteps.ts
  • src/components/builder/useEmptyWorkflowDialog.ts
  • src/components/builder/useResolvedSelectedInputs.ts
  • src/components/common/DraggableList.vue
  • src/components/common/EditableText.vue
  • src/components/common/FormRadioGroup.vue
  • src/components/common/ScrubableNumberInput.vue
  • src/components/common/SystemStatsPanel.vue
  • src/components/common/TextTicker.vue
  • src/components/common/TreeExplorerV2.vue
  • src/components/common/TreeExplorerV2Node.vue
  • src/components/common/UrlInput.vue
  • src/components/common/VirtualGrid.vue
  • src/components/common/WaveAudioPlayer.vue
  • src/components/curve/CurveEditor.test.ts
  • src/components/curve/CurveEditor.vue
  • src/components/curve/WidgetCurve.test.ts
  • src/components/curve/WidgetCurve.vue
  • src/components/curve/curveUtils.ts
  • src/components/custom/widget/WorkflowTemplateSelectorDialog.vue
  • src/components/dialog/GlobalDialog.vue
  • src/components/dialog/content/ConfirmationDialogContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContentLegacy.vue
  • src/components/dialog/content/setting/KeybindingPanel.vue
  • src/components/dialog/content/setting/UsageLogsTable.test.ts
  • src/components/dialog/content/setting/keybinding/EditKeybindingContent.vue
  • src/components/dialog/content/setting/keybinding/EditKeybindingFooter.vue
  • src/components/dialog/content/setting/keybinding/KeybindingList.vue
  • src/components/dialog/content/subscription/CancelSubscriptionDialogContent.vue
  • src/components/error/useErrorOverlayState.ts
  • src/components/gradientslider/GradientSlider.vue
  • src/components/gradientslider/gradients.ts
  • src/components/graph/CanvasModeSelector.vue
  • src/components/graph/DomWidgets.test.ts
  • src/components/graph/DomWidgets.vue
  • src/components/graph/GraphCanvas.vue
  • src/components/graph/LinkOverlayCanvas.vue
  • src/components/graph/NodeContextMenu.vue
  • src/components/graph/NodeTooltip.vue
  • src/components/graph/SelectionRectangle.vue
  • src/components/graph/modals/ZoomControlsModal.test.ts
  • src/components/graph/modals/ZoomControlsModal.vue
  • src/components/graph/selectionToolbox/ArrangeButton.vue
  • src/components/graph/selectionToolbox/ColorPickerButton.vue
  • src/components/graph/selectionToolbox/InfoButton.vue
  • src/components/graph/selectionToolbox/SubmenuPopover.vue
  • src/components/graph/widgets/DomWidget.test.ts
  • src/components/graph/widgets/DomWidget.vue
  • src/components/graph/widgets/TextPreviewWidget.vue
  • src/components/graph/widgets/domWidgetZIndex.ts
  • src/components/helpcenter/HelpCenterMenuContent.vue
  • src/components/imagecrop/WidgetImageCrop.vue
  • src/components/load3d/Load3DControls.vue
  • src/components/load3d/Load3dViewerContent.vue
  • src/components/load3d/controls/AnimationControls.test.ts
  • src/components/load3d/controls/AnimationControls.vue
  • src/components/load3d/controls/CameraControls.test.ts
  • src/components/load3d/controls/GizmoControls.test.ts
  • src/components/load3d/controls/GizmoControls.vue
  • src/components/load3d/controls/HDRIControls.test.ts
  • src/components/load3d/controls/HDRIControls.vue
  • src/components/load3d/controls/LightControls.test.ts
  • src/components/load3d/controls/LightControls.vue
  • src/components/load3d/controls/ModelControls.test.ts
  • src/components/load3d/controls/PopupSlider.test.ts
  • src/components/load3d/controls/PopupSlider.vue
  • src/components/load3d/controls/RecordingControls.test.ts
  • src/components/load3d/controls/SceneControls.test.ts
  • src/components/load3d/controls/viewer/ViewerCameraControls.test.ts
  • src/components/load3d/controls/viewer/ViewerCameraControls.vue
  • src/components/load3d/controls/viewer/ViewerExportControls.test.ts
  • src/components/load3d/controls/viewer/ViewerGizmoControls.test.ts
  • src/components/load3d/controls/viewer/ViewerLightControls.test.ts
  • src/components/load3d/controls/viewer/ViewerLightControls.vue
  • src/components/load3d/controls/viewer/ViewerModelControls.test.ts
  • src/components/load3d/controls/viewer/ViewerSceneControls.test.ts
  • src/components/maskeditor/PointerZone.vue
  • src/components/maskeditor/ToolPanel.test.ts
  • src/components/node/NodePreview.vue
  • src/components/node/NodePreviewCard.vue
  • src/components/node/NodePricingBadge.vue
  • src/components/painter/WidgetPainter.test.ts
  • src/components/queue/JobHistoryActionsMenu.test.ts
  • src/components/queue/QueueOverlayExpanded.vue
  • src/components/queue/QueueProgressOverlay.vue
  • src/components/queue/dialogs/QueueClearHistoryDialog.vue
  • src/components/queue/job/JobAssetsList.vue
  • src/components/queue/job/JobContextMenu.vue
  • src/components/queue/job/JobDetailsPopover.vue
  • src/components/queue/job/JobFilterTabs.vue
  • src/components/queue/job/useQueueEstimates.ts
  • src/components/range/RangeEditor.test.ts
  • src/components/range/RangeEditor.vue
  • src/components/range/WidgetRange.test.ts
  • src/components/range/WidgetRange.vue
  • src/components/range/rangeUtils.ts
  • src/components/rightSidePanel/RightSidePanel.vue
  • src/components/rightSidePanel/errors/ErrorNodeCard.vue
  • src/components/rightSidePanel/errors/MissingNodeCard.vue
  • src/components/rightSidePanel/errors/MissingPackGroupRow.vue
  • src/components/rightSidePanel/errors/TabErrors.vue
  • src/components/rightSidePanel/errors/useErrorGroups.test.ts
  • src/components/rightSidePanel/errors/useErrorGroups.ts
  • src/components/rightSidePanel/errors/useErrorReport.ts
  • src/components/rightSidePanel/layout/PropertiesAccordionItem.vue
  • src/components/rightSidePanel/parameters/SectionWidgets.vue
  • src/components/rightSidePanel/parameters/TabGlobalParameters.vue
  • src/components/rightSidePanel/parameters/TabSubgraphInputs.vue
  • src/components/rightSidePanel/parameters/WidgetActions.vue
  • src/components/rightSidePanel/parameters/WidgetItem.test.ts
  • src/components/rightSidePanel/parameters/WidgetItem.vue
  • src/components/rightSidePanel/settings/SetNodeColor.vue
  • src/components/rightSidePanel/settings/SetNodeState.vue
  • src/components/rightSidePanel/settings/TabGlobalSettings.vue
  • src/components/rightSidePanel/shared.ts
  • src/components/rightSidePanel/subgraph/SubgraphEditor.vue
  • src/components/searchbox/NodeSearchBox.vue
  • src/components/searchbox/NodeSearchBoxPopover.test.ts
  • src/components/searchbox/NodeSearchBoxPopover.vue
  • src/components/searchbox/v2/NodeSearchCategoryTreeNode.vue
  • src/components/searchbox/v2/NodeSearchContent.vue
  • src/components/searchbox/v2/NodeSearchInput.test.ts
  • src/components/searchbox/v2/NodeSearchInput.vue
  • src/components/searchbox/v2/NodeSearchTypeFilterPopover.vue
  • src/components/sidebar/SideToolbar.vue
  • src/components/sidebar/tabs/AssetsSidebarTab.vue
  • src/components/sidebar/tabs/BaseWorkflowsSidebarTab.test.ts
  • src/components/sidebar/tabs/BaseWorkflowsSidebarTab.vue
  • src/components/sidebar/tabs/JobHistorySidebarTab.vue
  • src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts
  • src/components/sidebar/tabs/ModelLibrarySidebarTab.vue
  • src/components/sidebar/tabs/NodeLibrarySidebarTabV2.vue
  • src/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vue
  • src/components/sidebar/tabs/nodeLibrary/EssentialNodeCard.vue
  • src/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue
  • src/components/tab/Tab.vue
  • src/components/templates/thumbnails/CompareSliderThumbnail.vue
  • src/components/templates/thumbnails/LogoOverlay.vue
  • src/components/toast/GlobalToast.vue
  • src/components/topbar/CurrentUserButton.vue
  • src/components/topbar/TopbarBadges.vue
  • src/components/topbar/WorkflowTabs.vue
  • src/components/ui/ZoomPane.vue
  • src/components/ui/chart/useChart.ts
  • src/components/ui/color-picker/ColorPickerSaturationValue.vue
  • src/components/ui/color-picker/ColorPickerSlider.vue
  • src/components/ui/search-input/AsyncSearchInput.vue
  • src/components/ui/search-input/SearchAutocomplete.vue
  • src/components/ui/search-input/SearchInput.test.ts
  • src/components/ui/select/SelectDropdown.stories.ts
  • src/components/widget/layout/BaseModalLayout.vue
  • src/components/widget/nav/NavItem.vue
  • src/composables/auth/useAuthActions.ts
  • src/composables/auth/useCurrentUser.ts
  • src/composables/billing/useBillingContext.ts
  • src/composables/billing/useLegacyBilling.ts
  • src/composables/bottomPanelTabs/useLogsTerminal.ts
  • src/composables/canvas/useFocusNode.ts
  • src/composables/canvas/useSelectedLiteGraphItems.ts
  • src/composables/canvas/useSelectionToolboxPosition.ts
  • src/composables/element/useCanvasPositionConversion.ts
  • src/composables/element/useDomClipping.ts
  • src/composables/graph/contextMenuConverter.ts
  • src/composables/graph/useArrangeNodes.ts
  • src/composables/graph/useArrangeSession.ts
  • src/composables/graph/useErrorClearingHooks.test.ts
  • src/composables/graph/useErrorClearingHooks.ts
  • src/composables/graph/useFrameNodes.ts
  • src/composables/graph/useGraphHierarchy.ts
  • src/composables/graph/useGraphNodeManager.test.ts
  • src/composables/graph/useGraphNodeManager.ts
  • src/composables/graph/useGroupMenuOptions.ts
  • src/composables/graph/useImageMenuOptions.ts
  • src/composables/graph/useNodeCustomization.ts
  • src/composables/graph/useNodeErrorFlagSync.ts
  • src/composables/graph/useSelectedNodeActions.ts
  • src/composables/graph/useSelectionState.ts
  • src/composables/graph/useSubgraphOperations.ts
  • src/composables/graph/useVueNodeLifecycle.ts
  • src/composables/maskeditor/brushDrawingUtils.test.ts

Comment on lines +171 to +173
if (items.length < 3) {
return
}

@coderabbitai coderabbitai Bot Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Clear the collapsed state before bailing out on short breadcrumb lists.

Returning here skips the collapseTabs.value = false path, so a breadcrumb that was already collapsed can stay collapsed even after the stack shrinks below three items.

💡 Suggested fix
-          if (items.length < 3) {
-            return
-          }
+          if (items.length < 3) {
+            collapseTabs.value = false
+            return
+          }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (items.length < 3) {
return
}
if (items.length < 3) {
collapseTabs.value = false
return
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/breadcrumb/SubgraphBreadcrumb.vue` around lines 171 - 173, The
early return inside the items-length guard (the "if (items.length < 3) { return
}" branch) leaves collapseTabs.value in a collapsed state; before returning,
explicitly reset collapseTabs.value = false so the breadcrumb is expanded when
the stack shrinks below three items (update the conditional in
SubgraphBreadcrumb.vue that checks items.length and ensure collapseTabs.value is
cleared prior to the return).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed valid bug, but pre-existing on main — this PR is a pure brace-style rollout and doesn't touch the surrounding logic. Mixing a functional fix into an 800+ file style change would muddy the diff and complicate review/revert. Worth a separate PR / issue. Also note: after the latest force-push (multi-or-nest mode), this line is back to if (items.length < 3) return — most of the bracing CodeRabbit reviewed has been reverted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

Comment on lines 267 to 275
function showDetailsNow(nextActive: { jobId: string; workflowId?: string }) {
clearHoverTimers()
if (!hasDisplayedJob(nextActive.jobId)) return
if (!hasDisplayedJob(nextActive.jobId)) {
return
}

activeDetails.value = nextActive
isDetailsOpen.value = true
}

@coderabbitai coderabbitai Bot Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Guard the hover state before clearing timers.

showDetailsNow() now clears the existing hide timer before it knows the hovered job is still displayed. If a stale mouseenter arrives after the list changed, the previous details stay open with no timer to close them, and activeRowElement has already moved to the removed row.

♻️ Proposed fix
 function showDetailsNow(nextActive: { jobId: string; workflowId?: string }) {
-  clearHoverTimers()
   if (!hasDisplayedJob(nextActive.jobId)) {
     return
   }
+  clearHoverTimers()
 
   activeDetails.value = nextActive
   isDetailsOpen.value = true
 }
 
 function onJobEnter(job: JobListItem, event: MouseEvent) {
-  hoveredJobId.value = job.id
-
   const rowElement = event.currentTarget
   if (!(rowElement instanceof HTMLElement)) {
     return
   }
 
   const nextActive = {
     jobId: job.id,
     workflowId: job.taskRef?.workflowId
   }
+
+  if (!hasDisplayedJob(nextActive.jobId)) {
+    return
+  }
+
+  hoveredJobId.value = job.id
+  activeRowElement.value = rowElement
-
-  activeRowElement.value = rowElement
   ...
 }

Also applies to: 306-331

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/queue/job/JobAssetsList.vue` around lines 267 - 275, The
current showDetailsNow function clears hover timers before confirming the
hovered job is still displayed, which can leave stale details open; change the
order so you first verify the job is displayed (using
hasDisplayedJob(nextActive.jobId)) and that any referenced DOM element
(activeRowElement) still corresponds to nextActive, and only then call
clearHoverTimers() and set activeDetails.value/isDetailsOpen.value; apply the
same pattern to the analogous logic in the other block (around the 306-331
region) to ensure timers are cleared only after the guard checks pass.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid race condition, but pre-existing on main — showDetailsNow already clears timers before the guard there. Not introduced by this PR; this PR only adds/removes braces.

Out of scope here for the same reason as the other findings — keeping this PR a mechanical style change. The latest force-push (multi-or-nest mode) also reverts the bracing this comment is anchored to. Recommend a dedicated PR for the hover-state race.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

Comment on lines 159 to 164
function handleContextMenu(event: Event) {
if (!isUserBlueprint.value) return
if (!isUserBlueprint.value) {
return
}
menu.value?.show(event)
}

@coderabbitai coderabbitai Bot Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Consume the contextmenu event before returning.

Returning early here skips menu.show(event), so non-user blueprints can fall through to the browser’s native context menu. Call event.preventDefault() (or use @contextmenu.prevent) before exiting.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue` around lines 159 -
164, In handleContextMenu, call event.preventDefault() before returning when
!isUserBlueprint.value so the native browser context menu is suppressed;
specifically, update the handleContextMenu function to invoke
event.preventDefault() (or switch to using the `@contextmenu.prevent` modifier on
the component) and then return, leaving menu.value?.show(event) for the
isUserBlueprint.value case.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid — non-user blueprints fall through to the browser context menu on main too. Pre-existing, not introduced by this PR (which only changes brace style).

Deferring to a separate PR to keep this change focused on the lint rule. Should be a one-liner: event.preventDefault() before the early return, or @contextmenu.prevent on the template binding.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

Comment on lines +86 to +117
onMounted(async () => {
if (!terminal.value) await until(terminal).toBeTruthy()
if (!terminal.value) {
await until(terminal).toBeTruthy()
}

const controller = new AbortController()
mountController = controller
const { signal } = controller

try {
const logs = await api.getRawLogs()
if (signal.aborted || !terminal.value) return
if (signal.aborted || !terminal.value) {
return
}
writeEntries(logs.entries)
} catch (err) {
if (signal.aborted) return
if (signal.aborted) {
return
}
console.error('Error loading logs', err)
errorMessage.value = t('logsTerminal.loadError')
loading.value = false
return
}

const { clientId } = storeToRefs(useExecutionStore())
if (!clientId.value) await until(clientId).not.toBeNull()
if (signal.aborted) return
if (!clientId.value) {
await until(clientId).not.toBeNull()
}
if (signal.aborted) {
return
}

@coderabbitai coderabbitai Bot Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Make the mount wait abort-aware.

await until(terminal).toBeTruthy() runs before any AbortController exists, so unmounting while the ref is still unset leaves this async task alive and it can continue into getRawLogs() / subscribeLogs(true) after disposal. Create the controller first, then short-circuit once the wait resolves if the signal was aborted.

🔧 Suggested fix
 onMounted(async () => {
+  const controller = new AbortController()
+  mountController = controller
+  const { signal } = controller
+
   if (!terminal.value) {
     await until(terminal).toBeTruthy()
   }
-
-  const controller = new AbortController()
-  mountController = controller
-  const { signal } = controller
+  if (signal.aborted) {
+    return
+  }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/composables/bottomPanelTabs/useLogsTerminal.ts` around lines 86 - 117,
Move creation of the AbortController (and assignment to mountController) to
before awaiting until(terminal).toBeTruthy() inside onMounted in
useLogsTerminal, then after the await check signal.aborted and return early if
true; ensure the rest of the flow (calling api.getRawLogs(), writeEntries, and
subscribe logic) only runs when mountController.signal is not aborted.
Specifically: create the controller and extract { signal } before calling
until(terminal).toBeTruthy(), and add a short-circuit check using signal.aborted
immediately after the await to prevent continuing into getRawLogs() or
subscribeLogs when unmounted.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid stability bug — onMounted awaits until(terminal).toBeTruthy() before the controller exists, so an unmount during that wait leaks the rest of the flow. Pre-existing on main, not introduced by this PR.

Deferring to a separate PR — this one is a mechanical brace-style change across 800+ files and adding functional fixes here would muddy the diff. The suggested fix (create controller first, check signal.aborted after the await) is the right shape.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/sidebar/tabs/AssetsSidebarTab.vue`:
- Around line 641-643: The click handler handleEmptySpaceClick is checking the
ref object hasSelection instead of its boolean value, causing clearSelection()
to always run; update the condition to use the reactive boolean (e.g.,
hasSelection.value or a computed/unwrapped boolean) so clearSelection() only
runs when hasSelection is true, keeping the call site inside
handleEmptySpaceClick and leaving clearSelection unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: accbf313-2310-4813-9dc5-ef8f36e441b7

📥 Commits

Reviewing files that changed from the base of the PR and between 4c90fc2 and 82f873b.

📒 Files selected for processing (300)
  • .oxlintrc.json
  • browser_tests/fixtures/ComfyPage.ts
  • browser_tests/fixtures/components/Actionbar.ts
  • browser_tests/fixtures/components/BottomPanel.ts
  • browser_tests/fixtures/components/SidebarTab.ts
  • browser_tests/fixtures/components/Topbar.ts
  • browser_tests/fixtures/helpers/AssetHelper.ts
  • browser_tests/fixtures/helpers/AssetsHelper.ts
  • browser_tests/fixtures/helpers/CanvasHelper.ts
  • browser_tests/fixtures/helpers/CloudAuthHelper.ts
  • browser_tests/fixtures/helpers/DragDropHelper.ts
  • browser_tests/fixtures/helpers/FeatureFlagHelper.ts
  • browser_tests/fixtures/helpers/MaskEditorHelper.ts
  • browser_tests/fixtures/helpers/ModelLibraryHelper.ts
  • browser_tests/fixtures/helpers/NodeOperationsHelper.ts
  • browser_tests/fixtures/helpers/PerformanceHelper.ts
  • browser_tests/fixtures/helpers/PublishApiHelper.ts
  • browser_tests/fixtures/helpers/SubgraphHelper.ts
  • browser_tests/fixtures/helpers/TemplateHelper.ts
  • browser_tests/fixtures/helpers/ToastHelper.ts
  • browser_tests/fixtures/helpers/UserDataHelper.ts
  • browser_tests/fixtures/helpers/WorkflowHelper.ts
  • browser_tests/fixtures/jobsRouteFixture.ts
  • browser_tests/fixtures/sharedWorkflowImportFixture.ts
  • browser_tests/fixtures/utils/boundsUtils.ts
  • browser_tests/fixtures/utils/builderTestUtils.ts
  • browser_tests/fixtures/utils/customMatchers.ts
  • browser_tests/fixtures/utils/fitToView.ts
  • browser_tests/fixtures/utils/litegraphUtils.ts
  • browser_tests/fixtures/utils/painter.ts
  • browser_tests/fixtures/utils/preview3dCameraState.ts
  • browser_tests/fixtures/utils/selectionToolboxMoreOptions.ts
  • browser_tests/fixtures/utils/vueNodeFixtures.ts
  • browser_tests/tests/actionbar.spec.ts
  • browser_tests/tests/appModeDropdownClipping.spec.ts
  • browser_tests/tests/appModeWidgetValues.spec.ts
  • browser_tests/tests/canvasModeSelector.spec.ts
  • browser_tests/tests/changeTracker.spec.ts
  • browser_tests/tests/containAudit.spec.ts
  • browser_tests/tests/dialogs/queueClearHistory.spec.ts
  • browser_tests/tests/domWidget.spec.ts
  • browser_tests/tests/execution.spec.ts
  • browser_tests/tests/featureFlags.spec.ts
  • browser_tests/tests/i18nLocaleFallback.spec.ts
  • browser_tests/tests/imageCompare.spec.ts
  • browser_tests/tests/interaction.spec.ts
  • browser_tests/tests/keybindingPresets.spec.ts
  • browser_tests/tests/minimap.spec.ts
  • browser_tests/tests/nodeBadge.spec.ts
  • browser_tests/tests/nodeContextMenuOverflow.spec.ts
  • browser_tests/tests/nodeGhostPlacement.spec.ts
  • browser_tests/tests/nodeHelp.spec.ts
  • browser_tests/tests/painter.spec.ts
  • browser_tests/tests/performance.spec.ts
  • browser_tests/tests/previewAsText.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabMissingMediaRuntime.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
  • browser_tests/tests/remoteWidgets.spec.ts
  • browser_tests/tests/rendererToggleStability.spec.ts
  • browser_tests/tests/rerouteNode.spec.ts
  • browser_tests/tests/selectionToolboxSubmenus.spec.ts
  • browser_tests/tests/sidebar/assets-filter.spec.ts
  • browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
  • browser_tests/tests/subgraph/subgraphCrud.spec.ts
  • browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts
  • browser_tests/tests/subgraph/subgraphSlots.spec.ts
  • browser_tests/tests/subgraphPromotedWidgetPanel.spec.ts
  • browser_tests/tests/vueNodes/groups/groups.spec.ts
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
  • browser_tests/tests/vueNodes/interactions/node/resize.spec.ts
  • browser_tests/tests/vueNodes/nodeStates/error.spec.ts
  • browser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.ts
  • browser_tests/tests/vueNodes/widgets/float/floatWidget.spec.ts
  • browser_tests/tests/vueNodes/widgets/imageCrop.spec.ts
  • browser_tests/tests/workflowPersistence.spec.ts
  • browser_tests/tests/workflowTabThumbnail.spec.ts
  • browser_tests/tests/wsReconnectStaleJob.spec.ts
  • browser_tests/tests/zoomControls.spec.ts
  • src/App.vue
  • src/base/assert.ts
  • src/base/common/async.ts
  • src/base/common/downloadUtil.ts
  • src/base/credits/comfyCredits.ts
  • src/base/webviewDetection.ts
  • src/components/LiteGraphCanvasSplitterOverlay.vue
  • src/components/MenuHamburger.vue
  • src/components/TopMenuSection.test.ts
  • src/components/TopMenuSection.vue
  • src/components/actionbar/BatchCountEdit.vue
  • src/components/actionbar/ComfyActionbar.vue
  • src/components/actionbar/ComfyRunButton/ComfyQueueButton.vue
  • src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
  • src/components/bottomPanel/tabs/terminal/BaseTerminal.vue
  • src/components/boundingbox/WidgetBoundingBox.test.ts
  • src/components/breadcrumb/SubgraphBreadcrumb.vue
  • src/components/breadcrumb/SubgraphBreadcrumbItem.vue
  • src/components/builder/AppModeWidgetList.vue
  • src/components/builder/IoItem.vue
  • src/components/builder/VueNodeSwitchPopup.vue
  • src/components/builder/useBuilderSteps.ts
  • src/components/builder/useResolvedSelectedInputs.ts
  • src/components/common/BackgroundImageUpload.vue
  • src/components/common/BadgePill.vue
  • src/components/common/ColorCustomizationSelector.vue
  • src/components/common/CustomizationDialog.vue
  • src/components/common/DeviceInfo.vue
  • src/components/common/DraggableList.vue
  • src/components/common/EditableText.vue
  • src/components/common/ExtensionSlot.vue
  • src/components/common/FormColorPicker.vue
  • src/components/common/FormImageUpload.vue
  • src/components/common/FormItem.vue
  • src/components/common/FormRadioGroup.vue
  • src/components/common/LazyImage.vue
  • src/components/common/ScrubableNumberInput.vue
  • src/components/common/SystemStatsPanel.vue
  • src/components/common/TextTicker.vue
  • src/components/common/TreeExplorer.vue
  • src/components/common/TreeExplorerTreeNode.vue
  • src/components/common/TreeExplorerV2.vue
  • src/components/common/TreeExplorerV2Node.vue
  • src/components/common/VirtualGrid.test.ts
  • src/components/common/VirtualGrid.vue
  • src/components/curve/WidgetCurve.vue
  • src/components/curve/curveUtils.test.ts
  • src/components/curve/curveUtils.ts
  • src/components/custom/widget/WorkflowTemplateSelectorDialog.vue
  • src/components/dialog/content/ErrorDialogContent.vue
  • src/components/dialog/content/SignInContent.vue
  • src/components/dialog/content/TopUpCreditsDialogContentLegacy.vue
  • src/components/dialog/content/setting/KeybindingPanel.vue
  • src/components/dialog/content/setting/LegacyCreditsPanel.vue
  • src/components/dialog/content/setting/UsageLogsTable.vue
  • src/components/dialog/content/setting/keybinding/EditKeybindingContent.vue
  • src/components/dialog/content/signin/SignInForm.vue
  • src/components/dialog/content/signin/SignUpForm.vue
  • src/components/dialog/rekaPrimeVueBridge.ts
  • src/components/error/useErrorOverlayState.ts
  • src/components/graph/CanvasModeSelector.vue
  • src/components/graph/DomWidgets.vue
  • src/components/graph/GraphCanvas.vue
  • src/components/graph/NodeContextMenu.vue
  • src/components/graph/NodeTooltip.vue
  • src/components/graph/TitleEditor.vue
  • src/components/graph/modals/ZoomControlsModal.vue
  • src/components/graph/selectionToolbox/ColorPickerButton.vue
  • src/components/graph/selectionToolbox/ExecuteButton.vue
  • src/components/graph/selectionToolbox/SubmenuPopover.vue
  • src/components/graph/widgets/DomWidget.vue
  • src/components/helpcenter/HelpCenterMenuContent.vue
  • src/components/imagecrop/WidgetImageCrop.test.ts
  • src/components/load3d/Load3D.test.ts
  • src/components/load3d/Load3DControls.test.ts
  • src/components/load3d/Load3DControls.vue
  • src/components/load3d/Load3DScene.vue
  • src/components/load3d/Load3dViewerContent.test.ts
  • src/components/load3d/Load3dViewerContent.vue
  • src/components/load3d/controls/ExportControls.test.ts
  • src/components/load3d/controls/ExportControls.vue
  • src/components/load3d/controls/LightControls.vue
  • src/components/load3d/controls/ModelControls.test.ts
  • src/components/load3d/controls/ModelControls.vue
  • src/components/load3d/controls/PopupSlider.vue
  • src/components/load3d/controls/RecordingControls.vue
  • src/components/load3d/controls/SceneControls.vue
  • src/components/load3d/controls/viewer/ViewerSceneControls.vue
  • src/components/maskeditor/BrushCursor.vue
  • src/components/maskeditor/BrushSettingsPanel.vue
  • src/components/maskeditor/ImageLayerSettingsPanel.test.ts
  • src/components/maskeditor/ImageLayerSettingsPanel.vue
  • src/components/maskeditor/MaskEditorContent.vue
  • src/components/maskeditor/PointerZone.vue
  • src/components/maskeditor/SettingsPanelContainer.vue
  • src/components/maskeditor/ToolPanel.test.ts
  • src/components/maskeditor/controls/DropdownControl.vue
  • src/components/node/NodePreview.vue
  • src/components/painter/WidgetPainter.test.ts
  • src/components/primevueOverride/AutoCompletePlus.vue
  • src/components/queue/QueueNotificationBanner.vue
  • src/components/queue/QueueProgressOverlay.vue
  • src/components/queue/job/JobAssetsList.vue
  • src/components/queue/job/JobDetailsPopover.vue
  • src/components/queue/job/JobFilterActions.vue
  • src/components/queue/job/useJobErrorReporting.ts
  • src/components/queue/job/useQueueEstimates.ts
  • src/components/range/WidgetRange.vue
  • src/components/range/rangeUtils.test.ts
  • src/components/rightSidePanel/RightSidePanel.vue
  • src/components/rightSidePanel/errors/ErrorNodeCard.vue
  • src/components/rightSidePanel/errors/MissingPackGroupRow.vue
  • src/components/rightSidePanel/errors/TabErrors.vue
  • src/components/rightSidePanel/errors/useErrorGroups.ts
  • src/components/rightSidePanel/errors/useErrorReport.ts
  • src/components/rightSidePanel/parameters/SectionWidgets.vue
  • src/components/rightSidePanel/parameters/TabNodes.vue
  • src/components/rightSidePanel/parameters/TabNormalInputs.vue
  • src/components/rightSidePanel/parameters/TabSubgraphInputs.vue
  • src/components/rightSidePanel/settings/NodeSettings.vue
  • src/components/rightSidePanel/settings/SetNodeColor.vue
  • src/components/rightSidePanel/settings/SetNodeState.vue
  • src/components/rightSidePanel/settings/TabGlobalSettings.vue
  • src/components/rightSidePanel/shared.ts
  • src/components/rightSidePanel/subgraph/SubgraphEditor.vue
  • src/components/searchbox/NodeSearchBox.vue
  • src/components/searchbox/NodeSearchBoxPopover.vue
  • src/components/searchbox/NodeSearchFilter.vue
  • src/components/searchbox/v2/NodeSearchCategorySidebar.vue
  • src/components/searchbox/v2/NodeSearchCategoryTreeNode.vue
  • src/components/searchbox/v2/NodeSearchContent.test.ts
  • src/components/searchbox/v2/NodeSearchContent.vue
  • src/components/searchbox/v2/NodeSearchFilterBar.vue
  • src/components/searchbox/v2/NodeSearchTypeFilterPopover.vue
  • src/components/searchbox/v2/__test__/testUtils.ts
  • src/components/sidebar/ComfyMenuButton.vue
  • src/components/sidebar/SideToolbar.vue
  • src/components/sidebar/tabs/AssetsSidebarListView.vue
  • src/components/sidebar/tabs/AssetsSidebarTab.vue
  • src/components/sidebar/tabs/BaseWorkflowsSidebarTab.test.ts
  • src/components/sidebar/tabs/BaseWorkflowsSidebarTab.vue
  • src/components/sidebar/tabs/JobHistorySidebarTab.vue
  • src/components/sidebar/tabs/ModelLibrarySidebarTab.vue
  • src/components/sidebar/tabs/NodeLibrarySidebarTab.vue
  • src/components/sidebar/tabs/NodeLibrarySidebarTabV2.vue
  • src/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vue
  • src/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue
  • src/components/sidebar/tabs/queue/MediaLightbox.vue
  • src/components/sidebar/tabs/workflows/WorkflowTreeLeaf.vue
  • src/components/tab/Tab.vue
  • src/components/toast/GlobalToast.vue
  • src/components/topbar/CurrentUserPopoverLegacy.vue
  • src/components/topbar/LoginButton.vue
  • src/components/topbar/TopbarBadge.vue
  • src/components/topbar/WorkflowTab.vue
  • src/components/topbar/WorkflowTabPopover.vue
  • src/components/topbar/WorkflowTabs.vue
  • src/components/ui/color-picker/ColorPicker.vue
  • src/components/ui/color-picker/ColorPickerSlider.vue
  • src/components/ui/multi-select/MultiSelect.vue
  • src/components/ui/search-input/AsyncSearchInput.vue
  • src/components/ui/search-input/SearchAutocomplete.vue
  • src/components/ui/stepper/FormattedNumberStepper.vue
  • src/components/ui/tags-input/TagsInput.vue
  • src/components/widget/layout/BaseModalLayout.vue
  • src/components/widget/panel/LeftSidePanel.vue
  • src/composables/auth/useAuthActions.ts
  • src/composables/auth/useCurrentUser.ts
  • src/composables/billing/useBillingContext.ts
  • src/composables/billing/useLegacyBilling.ts
  • src/composables/bottomPanelTabs/useCommandSubcategories.ts
  • src/composables/bottomPanelTabs/useTerminal.ts
  • src/composables/canvas/useSelectedLiteGraphItems.ts
  • src/composables/canvas/useSelectionToolboxPosition.ts
  • src/composables/element/useDomClipping.test.ts
  • src/composables/element/useDomClipping.ts
  • src/composables/element/useOverflowObserver.ts
  • src/composables/functional/useChainCallback.ts
  • src/composables/graph/contextMenuConverter.test.ts
  • src/composables/graph/contextMenuConverter.ts
  • src/composables/graph/useArrangeNodes.ts
  • src/composables/graph/useErrorClearingHooks.ts
  • src/composables/graph/useGraphHierarchy.test.ts
  • src/composables/graph/useGraphNodeManager.ts
  • src/composables/graph/useMoreOptionsMenu.ts
  • src/composables/graph/useNodeArrangement.ts
  • src/composables/graph/useNodeCustomization.ts
  • src/composables/graph/useNodeErrorFlagSync.ts
  • src/composables/graph/useSelectionMenuOptions.ts
  • src/composables/graph/useSubgraphOperations.ts
  • src/composables/graph/useVueNodeLifecycle.ts
  • src/composables/maskeditor/StrokeProcessor.test.ts
  • src/composables/maskeditor/StrokeProcessor.ts
  • src/composables/maskeditor/brushDrawingUtils.ts
  • src/composables/maskeditor/gpu/GPUBrushRenderer.test.ts
  • src/composables/maskeditor/gpuUtils.ts
  • src/composables/maskeditor/useBrushAdjustment.ts
  • src/composables/maskeditor/useBrushDrawing.ts
  • src/composables/maskeditor/useBrushPersistence.ts
  • src/composables/maskeditor/useCanvasHistory.test.ts
  • src/composables/maskeditor/useCanvasHistory.ts
  • src/composables/maskeditor/useCanvasManager.test.ts
  • src/composables/maskeditor/useCanvasManager.ts
  • src/composables/maskeditor/useCanvasTools.test.ts
  • src/composables/maskeditor/useCanvasTools.ts
  • src/composables/maskeditor/useCanvasTransform.test.ts
  • src/composables/maskeditor/useCanvasTransform.ts
  • src/composables/maskeditor/useImageLoader.ts
  • src/composables/maskeditor/useKeyboard.ts
  • src/composables/maskeditor/useMaskEditorLoader.ts
  • src/composables/maskeditor/useMaskEditorSaver.ts
  • src/composables/maskeditor/usePanAndZoom.ts
  • src/composables/maskeditor/useToolManager.ts
  • src/composables/node/useNodeBadge.ts
  • src/composables/node/useNodeDragToCanvas.ts
  • src/composables/node/useNodeImage.ts
  • src/composables/node/useNodeImageUpload.ts
✅ Files skipped from review due to trivial changes (212)
  • src/components/dialog/content/ErrorDialogContent.vue
  • src/components/maskeditor/controls/DropdownControl.vue
  • src/components/queue/job/useJobErrorReporting.ts
  • src/components/common/ExtensionSlot.vue
  • src/components/common/BadgePill.vue
  • browser_tests/fixtures/helpers/TemplateHelper.ts
  • src/components/dialog/content/SignInContent.vue
  • src/components/sidebar/tabs/workflows/WorkflowTreeLeaf.vue
  • browser_tests/tests/previewAsText.spec.ts
  • src/composables/element/useOverflowObserver.ts
  • src/components/common/LazyImage.vue
  • browser_tests/tests/changeTracker.spec.ts
  • src/components/curve/curveUtils.test.ts
  • src/composables/functional/useChainCallback.ts
  • browser_tests/fixtures/utils/selectionToolboxMoreOptions.ts
  • src/composables/bottomPanelTabs/useCommandSubcategories.ts
  • browser_tests/tests/vueNodes/widgets/combo/comboWidget.spec.ts
  • browser_tests/tests/featureFlags.spec.ts
  • browser_tests/tests/subgraphPromotedWidgetPanel.spec.ts
  • browser_tests/tests/selectionToolboxSubmenus.spec.ts
  • src/components/maskeditor/MaskEditorContent.vue
  • browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts
  • browser_tests/tests/nodeContextMenuOverflow.spec.ts
  • src/composables/graph/useGraphHierarchy.test.ts
  • src/components/range/rangeUtils.test.ts
  • src/components/load3d/controls/ExportControls.test.ts
  • src/composables/bottomPanelTabs/useTerminal.ts
  • browser_tests/tests/sidebar/assets-filter.spec.ts
  • src/components/common/CustomizationDialog.vue
  • src/composables/maskeditor/useBrushAdjustment.ts
  • src/composables/maskeditor/StrokeProcessor.test.ts
  • src/components/topbar/TopbarBadge.vue
  • src/components/primevueOverride/AutoCompletePlus.vue
  • src/components/load3d/Load3D.test.ts
  • src/components/searchbox/v2/NodeSearchContent.test.ts
  • src/composables/graph/useSelectionMenuOptions.ts
  • src/components/sidebar/ComfyMenuButton.vue
  • browser_tests/tests/workflowTabThumbnail.spec.ts
  • src/components/dialog/content/signin/SignUpForm.vue
  • src/components/imagecrop/WidgetImageCrop.test.ts
  • src/components/common/BackgroundImageUpload.vue
  • src/components/load3d/controls/SceneControls.vue
  • src/components/load3d/Load3DControls.vue
  • src/components/maskeditor/SettingsPanelContainer.vue
  • src/components/dialog/content/setting/LegacyCreditsPanel.vue
  • src/composables/maskeditor/useBrushPersistence.ts
  • src/components/builder/VueNodeSwitchPopup.vue
  • src/components/maskeditor/ImageLayerSettingsPanel.test.ts
  • src/composables/maskeditor/StrokeProcessor.ts
  • browser_tests/fixtures/jobsRouteFixture.ts
  • src/components/bottomPanel/tabs/shortcuts/ShortcutsList.vue
  • src/components/maskeditor/BrushCursor.vue
  • src/components/sidebar/tabs/AssetsSidebarListView.vue
  • src/components/load3d/controls/ExportControls.vue
  • browser_tests/tests/vueNodes/widgets/float/floatWidget.spec.ts
  • browser_tests/tests/wsReconnectStaleJob.spec.ts
  • src/composables/graph/useNodeArrangement.ts
  • src/components/load3d/controls/viewer/ViewerSceneControls.vue
  • src/components/common/FormColorPicker.vue
  • src/components/common/DeviceInfo.vue
  • src/components/ui/multi-select/MultiSelect.vue
  • browser_tests/fixtures/utils/builderTestUtils.ts
  • src/components/dialog/rekaPrimeVueBridge.ts
  • src/components/common/TreeExplorerTreeNode.vue
  • browser_tests/tests/execution.spec.ts
  • src/composables/node/useNodeImage.ts
  • src/composables/graph/contextMenuConverter.test.ts
  • src/components/boundingbox/WidgetBoundingBox.test.ts
  • src/components/searchbox/v2/test/testUtils.ts
  • src/composables/maskeditor/useCanvasManager.test.ts
  • src/components/queue/job/JobFilterActions.vue
  • src/components/rightSidePanel/parameters/TabSubgraphInputs.vue
  • src/components/searchbox/v2/NodeSearchFilterBar.vue
  • src/composables/element/useDomClipping.test.ts
  • src/components/load3d/Load3dViewerContent.test.ts
  • src/components/searchbox/NodeSearchFilter.vue
  • src/components/load3d/Load3DControls.test.ts
  • src/components/sidebar/tabs/NodeLibrarySidebarTab.vue
  • src/components/common/TreeExplorer.vue
  • src/components/common/FormImageUpload.vue
  • src/components/dialog/content/setting/UsageLogsTable.vue
  • src/composables/maskeditor/useKeyboard.ts
  • browser_tests/fixtures/helpers/PublishApiHelper.ts
  • src/components/maskeditor/BrushSettingsPanel.vue
  • src/components/dialog/content/TopUpCreditsDialogContentLegacy.vue
  • browser_tests/tests/appModeDropdownClipping.spec.ts
  • src/components/load3d/controls/PopupSlider.vue
  • src/composables/maskeditor/useImageLoader.ts
  • browser_tests/tests/actionbar.spec.ts
  • src/components/rightSidePanel/parameters/TabNodes.vue
  • src/components/dialog/content/signin/SignInForm.vue
  • browser_tests/fixtures/helpers/UserDataHelper.ts
  • src/composables/graph/useNodeErrorFlagSync.ts
  • src/components/graph/CanvasModeSelector.vue
  • browser_tests/fixtures/helpers/CloudAuthHelper.ts
  • browser_tests/tests/vueNodes/groups/groups.spec.ts
  • src/composables/maskeditor/useCanvasHistory.test.ts
  • src/composables/maskeditor/brushDrawingUtils.ts
  • browser_tests/tests/remoteWidgets.spec.ts
  • browser_tests/fixtures/utils/customMatchers.ts
  • browser_tests/tests/keybindingPresets.spec.ts
  • src/components/widget/panel/LeftSidePanel.vue
  • src/composables/maskeditor/useCanvasHistory.ts
  • src/composables/billing/useLegacyBilling.ts
  • browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
  • src/components/rightSidePanel/parameters/TabNormalInputs.vue
  • browser_tests/tests/nodeGhostPlacement.spec.ts
  • src/composables/maskeditor/gpuUtils.ts
  • src/composables/maskeditor/useCanvasTransform.test.ts
  • src/components/actionbar/ComfyRunButton/ComfyQueueButton.vue
  • src/components/topbar/CurrentUserPopoverLegacy.vue
  • src/components/maskeditor/ToolPanel.test.ts
  • src/components/sidebar/tabs/queue/MediaLightbox.vue
  • src/composables/graph/useVueNodeLifecycle.ts
  • src/composables/maskeditor/useMaskEditorSaver.ts
  • browser_tests/fixtures/sharedWorkflowImportFixture.ts
  • src/base/common/async.ts
  • src/components/curve/curveUtils.ts
  • src/components/widget/layout/BaseModalLayout.vue
  • src/components/common/ColorCustomizationSelector.vue
  • src/components/searchbox/v2/NodeSearchTypeFilterPopover.vue
  • browser_tests/tests/nodeHelp.spec.ts
  • src/App.vue
  • src/components/common/ScrubableNumberInput.vue
  • src/base/credits/comfyCredits.ts
  • src/components/load3d/controls/ModelControls.vue
  • src/components/sidebar/tabs/nodeLibrary/EssentialNodesPanel.vue
  • src/components/ui/stepper/FormattedNumberStepper.vue
  • src/components/maskeditor/ImageLayerSettingsPanel.vue
  • src/components/error/useErrorOverlayState.ts
  • src/components/builder/IoItem.vue
  • browser_tests/fixtures/helpers/ModelLibraryHelper.ts
  • src/components/rightSidePanel/parameters/SectionWidgets.vue
  • src/components/graph/selectionToolbox/ColorPickerButton.vue
  • browser_tests/fixtures/helpers/FeatureFlagHelper.ts
  • src/composables/maskeditor/useToolManager.ts
  • src/components/builder/useBuilderSteps.ts
  • src/composables/maskeditor/gpu/GPUBrushRenderer.test.ts
  • src/composables/maskeditor/usePanAndZoom.ts
  • src/components/rightSidePanel/errors/useErrorReport.ts
  • src/components/load3d/Load3dViewerContent.vue
  • browser_tests/fixtures/components/SidebarTab.ts
  • src/components/toast/GlobalToast.vue
  • src/components/breadcrumb/SubgraphBreadcrumb.vue
  • src/base/webviewDetection.ts
  • browser_tests/tests/subgraph/subgraphCrud.spec.ts
  • src/composables/graph/useArrangeNodes.ts
  • src/components/rightSidePanel/errors/MissingPackGroupRow.vue
  • src/composables/maskeditor/useMaskEditorLoader.ts
  • src/components/range/WidgetRange.vue
  • src/components/rightSidePanel/settings/TabGlobalSettings.vue
  • browser_tests/fixtures/utils/painter.ts
  • src/composables/maskeditor/useCanvasTools.ts
  • src/components/graph/selectionToolbox/SubmenuPopover.vue
  • src/composables/maskeditor/useCanvasTools.test.ts
  • src/components/searchbox/NodeSearchBox.vue
  • src/components/node/NodePreview.vue
  • browser_tests/fixtures/utils/preview3dCameraState.ts
  • src/composables/maskeditor/useCanvasManager.ts
  • src/composables/maskeditor/useBrushDrawing.ts
  • src/components/searchbox/v2/NodeSearchCategorySidebar.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeLeaf.vue
  • browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
  • src/composables/maskeditor/useCanvasTransform.ts
  • src/components/builder/AppModeWidgetList.vue
  • src/components/helpcenter/HelpCenterMenuContent.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeTreeFolder.vue
  • src/components/load3d/controls/ModelControls.test.ts
  • src/composables/graph/useSubgraphOperations.ts
  • src/components/rightSidePanel/errors/ErrorNodeCard.vue
  • src/components/custom/widget/WorkflowTemplateSelectorDialog.vue
  • src/composables/graph/useMoreOptionsMenu.ts
  • src/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vue
  • browser_tests/fixtures/helpers/PerformanceHelper.ts
  • src/components/rightSidePanel/settings/SetNodeState.vue
  • src/components/graph/selectionToolbox/ExecuteButton.vue
  • src/components/curve/WidgetCurve.vue
  • browser_tests/tests/subgraph/subgraphSerialization.spec.ts
  • src/components/ui/search-input/AsyncSearchInput.vue
  • src/composables/element/useDomClipping.ts
  • src/components/painter/WidgetPainter.test.ts
  • browser_tests/fixtures/ComfyPage.ts
  • browser_tests/fixtures/helpers/CanvasHelper.ts
  • src/components/queue/QueueProgressOverlay.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeBookmarkTreeExplorer.vue
  • browser_tests/tests/i18nLocaleFallback.spec.ts
  • browser_tests/fixtures/helpers/AssetHelper.ts
  • browser_tests/tests/painter.spec.ts
  • src/components/common/VirtualGrid.vue
  • src/composables/auth/useAuthActions.ts
  • src/composables/billing/useBillingContext.ts
  • src/components/LiteGraphCanvasSplitterOverlay.vue
  • src/composables/canvas/useSelectionToolboxPosition.ts
  • src/composables/graph/contextMenuConverter.ts
  • src/composables/graph/useGraphNodeManager.ts
  • src/base/common/downloadUtil.ts
  • browser_tests/tests/nodeBadge.spec.ts
  • src/components/rightSidePanel/RightSidePanel.vue
  • src/components/graph/GraphCanvas.vue
  • src/components/builder/useResolvedSelectedInputs.ts
  • browser_tests/tests/performance.spec.ts
  • browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts
  • src/components/searchbox/v2/NodeSearchContent.vue
  • src/components/queue/job/JobDetailsPopover.vue
  • browser_tests/fixtures/helpers/WorkflowHelper.ts
  • src/components/searchbox/NodeSearchBoxPopover.vue
  • src/components/queue/job/JobAssetsList.vue
  • src/components/sidebar/tabs/ModelLibrarySidebarTab.vue
  • browser_tests/fixtures/helpers/AssetsHelper.ts
  • browser_tests/tests/rerouteNode.spec.ts
  • src/composables/graph/useErrorClearingHooks.ts
  • browser_tests/fixtures/helpers/DragDropHelper.ts
🚧 Files skipped from review as they are similar to previous changes (12)
  • browser_tests/tests/rendererToggleStability.spec.ts
  • .oxlintrc.json
  • src/components/ui/color-picker/ColorPickerSlider.vue
  • src/components/sidebar/tabs/nodeLibrary/NodeDragPreview.vue
  • src/components/dialog/content/setting/keybinding/EditKeybindingContent.vue
  • src/components/rightSidePanel/settings/SetNodeColor.vue
  • browser_tests/tests/interaction.spec.ts
  • browser_tests/fixtures/helpers/MaskEditorHelper.ts
  • src/components/dialog/content/setting/KeybindingPanel.vue
  • src/components/sidebar/tabs/JobHistorySidebarTab.vue
  • src/components/rightSidePanel/errors/useErrorGroups.ts
  • src/components/graph/NodeTooltip.vue

Comment on lines 641 to 643
const handleEmptySpaceClick = () => {
if (hasSelection) {
clearSelection()
}
if (hasSelection) clearSelection()
}

@coderabbitai coderabbitai Bot Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Use the reactive boolean value, not the ref object.

Line 642 checks hasSelection (the ref object) instead of its boolean value, so the condition is always truthy and clearSelection() runs on every empty-space click.

Suggested fix
 const handleEmptySpaceClick = () => {
-  if (hasSelection) clearSelection()
+  if (hasSelection.value) clearSelection()
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const handleEmptySpaceClick = () => {
if (hasSelection) {
clearSelection()
}
if (hasSelection) clearSelection()
}
const handleEmptySpaceClick = () => {
if (hasSelection.value) clearSelection()
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/sidebar/tabs/AssetsSidebarTab.vue` around lines 641 - 643, The
click handler handleEmptySpaceClick is checking the ref object hasSelection
instead of its boolean value, causing clearSelection() to always run; update the
condition to use the reactive boolean (e.g., hasSelection.value or a
computed/unwrapped boolean) so clearSelection() only runs when hasSelection is
true, keeping the call site inside handleEmptySpaceClick and leaving
clearSelection unchanged.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real bug, confirmed — hasSelection is a ref (compare line 431: hasSelection.value && ...), so this branch is always truthy and clearSelection() runs on every empty-space click. But pre-existing on main (the original if (hasSelection) { clearSelection() } had the same bug — braces don't change the predicate). The lint autofix just made the bug more visible by collapsing it to one line.

Deferring to a separate PR to keep this one mechanical. One-line fix: hasSelection → hasSelection.value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped: comment is from another GitHub bot.

@DrJKL DrJKL closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants