Skip to content

libobs: characterize and extract hotkey background state query (Refs #5255) - #5263

Merged
zackees merged 2 commits into
masterfrom
test/5255-hotkey-background-state
Nov 19, 2026
Merged

zackees merged 2 commits into
masterfrom
test/5255-hotkey-background-state

Conversation

@zackees

@zackees zackees commented Nov 19, 2026

Copy link
Copy Markdown
Member

Refs #5255.

obs_hotkeys_get_background_state now lives in libobs/obs-hotkey-background-state.c.h, with its original body preserved verbatim. The sorted core unity group and all eleven isolated hotkey consumers include it beside the original lock helpers. The tests.d pointer, canonical graph, expected native inventories and CI membership assertion agree. The C-owned global core and mutex remain unchanged.

The new C-source characterization records locking, unlocking and global-core reads. It checks that optional flags are cleared before locking, failed locking returns NATIVE without unlock or field access, and success preserves every state and flag bit before exactly one unlock. It covers every declared state, an unknown enum, unknown flag bits and NULL output. Its original-C snapshot passed 25 times per library mode. RED commit 6fb00123b then failed on the missing extraction file; GREEN commit 9028566f0740 extracts that exact body. No public headers, existing C tests, Rust code or workflows changed. The new fixture characterizes C source; the later Rust swap must connect its unchanged assertions through real adapters.

Validation: whole native_build:: module (322 passing tests), 50 focused build-group/inventory/Windows-diagnostic checks, and a clean one-agent clud-review. Linux built all 65 *_rust targets and the new plus eleven affected C fixtures, then passed all twelve suites once per library and repeated the new fixture 25 times per library. Both libraries export exactly the same 1,769 symbols. The Windows checker passed all eight category links and hybrid libobs plus 56 Rust-static fixtures on Windows MSVC and Darwin arm64; the new C fixture also linked explicitly on both. Full SOLDR_PORCELAIN=0 ./lint passed once (441.1 seconds).

Forced-fetch merge-tree checks covered open PRs #5254, #5250, #5246, #5155, #5142, #5061 and #4124. Four merge cleanly. The conflicts on #5155, #5061 and #4124 also occur against the unchanged master baseline; this branch introduces no additional conflicting paths. All temporary refs were deleted.

This is the C-only prerequisite. Unit-specific Rust Tier 1/differential coverage belongs to the separately filed Rust swap; network Tier 4 does not apply. Native Windows/macOS execution, the complete cmocka suite and a real desktop/portal run were not performed. There is no behavior change requiring a features-ledger entry.

Ci-Attestation: {"at":1795106368,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":126,"stamp":"fcfc120c8442c4108edf56fb689498a1","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106368,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":126,"stamp":"665506a4c617c3d64dfcbc01f7313e91","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106368,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":126,"stamp":"fbbf57e544d3869f31a79dae8f085268","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106368,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":126,"stamp":"f506eedb0864b42d2c9564b31fd467c0","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106240,"gate":"general/all/client-lint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"52f7fa031a2de12a8d46278585529409","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106368,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":126,"stamp":"516504df571f1d4ab330d4ab0c1d018e","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"6752301a6f2d891ab216e8c1f8a72026","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"ce0575c64345e33243d053fca8511925","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"bb753c98675b9cb64409ac2843262781","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"10cfeb29b4f614dfcd22c8dd2417f3d0","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106240,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"2a230300efe27a25f2e624f969f1cadb","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106240,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"5a8d1d6c06bef5a5fbde82aecb2ef54c","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"672074ee6c5fa9bea4f9f06b183892f0","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"68cad3267447b50d8b7d90d1336db8bf","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"6db50835367b62d18780c91c82cecb3b","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106241,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"7c4daef1ba9b47da8d632518bfe587e3","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106240,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"ff8c3cbcaafdf1d89274eaa27b58258b","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106240,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"d69b79dbc11bd4f360766d2bd787c14d5ff293f8e9e7c1459df7ab178434f601","lane":"client-lint","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":216,"stamp":"f4add3d3102a7b8bdb5ff7231a63dbde","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}
Ci-Attestation: {"at":1795106916,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"8cb8a0d4af3f544b3f90a66d72f90831a37ba35e36a1c3b911b421492c1cc16e","lane":"client-test-x86_64-unknown-linux-gnu","parents":["6fb00123b7574d45e424958b807d46e5db654d8d"],"secs":546,"stamp":"5c9475221a3a7725f2029ffeed4187bd","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237","v":1,"via":"run"}

Client-Checks: {"checks":{"base":"9135554e3e5b9c608f75794f930709ea15dd2af8","coverage":"all-tracked-applicable-files","diff":["ci/test_hotkey_register_extraction.py","libobs/build/libobs.core+.h.c","libobs/obs-hotkey-background-state.c.h","libobs/obs-hotkey.c.h","rust/obs-build/tests/native/registration/headless_characterizations_expected.json","rust/obs-build/tests/native/registration/portal_output_expected.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_enum.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_press.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_background_trigger.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_binding_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_getters_characterization.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_load.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_pair_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_press_steps.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_hotkey_unregister_entry.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_portal_shortcuts.json","rust/obs-build/tests/native/registration/rust-static/cases/hotkey-control/test_wayland_hotkeys.json","test/cmocka/build/test-graph.json","test/cmocka/test_hotkey_background_state.c","test/cmocka/tests.d/test_hotkey_background_state.cmake"],"head":"aec7c0329d686e25ba48cf5f7272d964c1abc6a3","tools":{"orchestrator-python":"3.14.7 (main, Aug 14 2026, 15:35:28) [Clang 22.1.3 ]","schema-dependencies":"3.14.7 (main, Aug 14 2026, 15:35:28) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n   compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"c6f2bfd0c074229baad4b077982b3e6b4aad7101646304f9121e808ff1d3c019","tree":"164f766f0959e7a2d50991fdc3cc0faa3ab64237"}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant