Skip to content

test: Extract and characterize hotkey combination background id query before Rust swap #5275

Open

Description

@zackees

Phase 6 prerequisite for a later obs-hotkey Rust swap. The identifier wrapper obs_hotkey_combination_get_background_id is still inline in libobs/obs-hotkey.c.h (Group C). Existing portal coverage does not characterize lock failure, callback capture, reentrancy, partial-output cleanup or exact allocation transfer.

Add deterministic C characterization against the original wrapper, then extract it verbatim into its own C implementation file. Pin failed lock returning NULL without callback-field access or unlock; success reads the callback while locked and unlocks before invoking it; absent callback returns NULL; callback false frees partial dstr output; callback true transfers exactly id.array including NULL and empty success. Record combination/callback identity, call count and ordering with the real libobs allocator/dstr contract.

Add the tests.d pointer, sorted canonical test graph and unity-group member; keep native registration inventories consistent. No Rust, public-header or existing-C-test changes. Follow sibling #5263 with characterization, RED then GREEN. Validate the entire native_build module, focused Linux Tier 2 including EVERY *_rust target, Windows/Darwin links and one full lint. Check merge trees against #5259 and all overlapping PRs before publication; file the separate Rust swap afterward.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: hotkey combination background id prerequisite in pool slot obs-studio2, branch test/5275-hotkey-combo-id. 1. Characterize original C with deterministic locking, callback capture/reentry and allocator ownership; commit extraction RED then verbatim GREEN. 2. Register the C fixture, sorted unity group and matching inventories without Rust code, public-header or existing-C-test edits. 3. Run the whole native_build module, focused Linux Tier 2 and EVERY *_rust target, Windows/Darwin links and one full lint; merge-tree overlapping PRs including #5259/#5272/#5268, publish READY or branch-only according to backpressure, then file the Rust follow-up. First publication expected this session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions