Skip to content

test: Extract and characterize service type registry lookup before Rust swap #5267

Closed

Description

@zackees

C-only Phase 6 prerequisite for the hidden service type registry lookup find_service in libobs/obs-service.c.h:22-30, later targeting obs-output. This unit is explicitly disjoint from #3840's context, state and handler accessors. #3839 ported module accessors but left this lookup in C.

Characterize the original lookup with a portable, controlled private-header registry: empty table, misses, byte-exact C-string IDs including non-UTF-8, first matching entry, exact borrowed registry pointer, no callbacks and no ownership changes. Extract the entire body verbatim into libobs/obs-service-find.c.h in the sorted O unity group (libobs/build/libobs.core-output+.h.c). Preserve its hidden declaration, C-owned storage/lifetime and existing valid-string/initialized-core preconditions. No caching, sorting, locking, lifecycle changes or Rust.

Acceptance: new immutable C characterization, tests.d pointer and sorted canonical test graph, agreeing native/source inventories, RED then GREEN commits. Validate the whole native_build:: module, focused Linux Tier 2 new target and every *_rust target, Windows MSVC/Darwin link checks and full lint once. Check open-PR conflicts including #5257 and #5246 with forced fetched refs and merge-tree. No existing C test, public header, WebSocket or workflow edits. File the Rust swap separately after publication.

Decisions: ready / P2 / port / size:S. No functional dependency; behavior-neutral prerequisite following #5232 and #5263.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: service type registry lookup C-only characterization and extraction, pool slot obs-studio2. Branch: test/5267-find-service. 1. Pin the original hidden lookup with a controlled private registry. 2. Commit extraction-contract RED then verbatim C GREEN. 3. Validate native inventories, every Rust-static Linux consumer, cross links and lint; publish READY when backpressure permits, then file the separate Rust swap. First PR expected this session. Scope excludes #3840 context/state/handler accessors.

  3. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5272 (7d19e18): the hidden service type registry lookup (find_service) is extracted and characterized. The Rust swap is the follow-up issue named in #5272's report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions