Skip to content

test: characterize null audio-monitoring backend (Refs #5262) - #5268

Merged
zackees merged 5 commits into
masterfrom
test/5262-null-audio-monitor
Nov 19, 2026
Merged

zackees merged 5 commits into
masterfrom
test/5262-null-audio-monitor

Conversation

@zackees

@zackees zackees commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Refs #5262

The already isolated null audio-monitoring backend now has an additive C characterization before its Rust swap. The test imports both public monitoring functions from the selected real libobs and checks availability is false and enumeration never calls its callback or changes callback data, including NULL callbacks/data. Renamed copies of the unchanged six C bodies also pin the hidden lifecycle and device-matching functions: NULL creation, no-op reset/destroy, false matches for NULL/equal/different/invalid-byte/nonterminated inputs, unchanged caller storage, and unchanged logging/allocation balance. These private-source assertions are explicitly marked for mirroring against Rust in the follow-up.

The tests.d pointer and sorted canonical graph admit the target only on Linux/FreeBSD with ENABLE_PULSEAUDIO=OFF, exactly where libobs selects this fallback. Windows/macOS and PulseAudio-on builds exclude it. A private forward declaration for devices_match fixes an existing GCC -Werror=missing-prototypes failure in the fallback; all six function bodies and public headers remain unchanged. No existing C test, Rust implementation or workflow changes.

RED: commit 659ac39 deliberately expects true availability (the real C implementation returns false); build-dependency and private-prototype repairs retain that expectation. GREEN restores the characterized false result.

Validation: the entire native_build:: module passed (322 tests). All eight host/PulseAudio registration combinations passed through the real CMake graph renderer. A focused Linux Tier 2 build passed every configured *_rust target (65, 2,820 build steps), then the four new cases against C-reference and hybrid libobs with PulseAudio disabled. Both variants exported the same 1,769 dynamic symbols; nm confirmed the two public calls import from the selected shared library. ci/windows_link_check.py passed all eight Windows Rust category links, then hybrid libobs and all 57 configured *_rust cmocka targets for both Windows MSVC and Darwin arm64. The Linux core inventory now explicitly requires the null test only with PulseAudio off while retaining all six PulseAudio-only tests; all 29 tests in that inventory file pass.

Forced-refspec merge-tree checks found no new conflicts with the open PRs touching test-graph.json or audio-monitoring. #5263, #5254 and #5142 merge cleanly. #5246, #5155 and #4124 show the identical pre-existing conflicts when tested against this branch and its original master base. All temporary refs were deleted.

This is the C-only prerequisite. The follow-up Rust swap must preserve platform-selected canonical symbol ownership and add unchanged-C Tier 2, Tier 1 and Tier 3 coverage for the hidden functions. No protocol surface changes; Tier 4 is not applicable. FreeBSD registration was checked, but no native FreeBSD execution was performed.

Ran ./lint once. Its full CI self-test sweep found only the two old PulseAudio inventory-count assertions described above; the repaired file passed all 29 tests. The remaining original lint stages then passed in order: changed Python ruff, binary/feature inventories, platform/perf/knowledge checks, Rust formatting, workspace clippy and every feature-set clippy invocation. No second full lint run was made.

The repository push entry point also passed clippy and Dylint for all six shipping targets and the complete client self-test/validator checks. Its expanded host run reported 9,223 passed and one failure in the unchanged camera_busy::close::real::a_real_process_that_ignores_sigterm_is_killed test (Exited instead of Killed). That test sleeps a fixed 200 ms before signalling; it passed on a single isolated rerun. No Rust code was changed for this unrelated timing failure. Complete client-test attestation was not produced, so ordinary PR CI remains required. The published head has a valid signature.

Rust swap follow-up: #5269 (rust: Port null audio-monitoring backend to obs-audio-monitoring), to start after this prerequisite merges.

Ci-Attestation: {"at":1795111012,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":356,"stamp":"a93f3f6328386f2ec4a9c2b2426e41b4","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795111012,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":356,"stamp":"a7f85a5a681bf71a8d5af60a75c2ed70","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795111012,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":356,"stamp":"be059a13f9d2e27e5cc383499e4dc61c","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795111012,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":356,"stamp":"7857ec82c8e5c3719e07847d32dc666a","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110649,"gate":"general/all/client-lint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"bf93a5ccce6ba7ac813a63bb9afa207a","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795111012,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":356,"stamp":"b9b786a4e8ff6f40f3a73f08ba28e070","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110652,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"11ebea8cf23fbc03a3f949f2fdad5e1b","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110652,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"d53079177f988d99be1ee1045652f1bb","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110651,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"1021233bb1317f7f61f57fdb42226fca","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110651,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"4d4ec80e0f342661a83e589125347162","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110650,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"4a4c7e201784e175a59ba4b5a7d2dc63","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110650,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"802f8b5c282a91fb6268e4f14fc4a79b","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110651,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"3acdc9644ccec09a8db1b2c499a1a99c","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110652,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"0c11ab19c6d2efe94c6f704e21302d20","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110650,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"3ba7196f6d9c5e70c694d1d9b57e378e","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110651,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"dbea8437c037cf44cae634c76964c7f0","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110649,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"580ef5b6b8d6af948de9f99f472dccaf","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
Ci-Attestation: {"at":1795110649,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"f8d0276b4057afb899edd4c7353901ac31932e10540208103f3e294848bc0fed","lane":"client-lint","parents":["57b4e5302746d4d1e44e5e7a2a1b0048606237f4"],"secs":500,"stamp":"374074172f8c998db9c585a10da9bbeb","tree":"98ca89d794c5d1472ebb4e13503a754a30975735","v":1,"via":"run"}
@zackees zackees added the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees zackees removed the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees enabled auto-merge November 19, 2026 18:17
@zackees
zackees added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit 68a23db Nov 19, 2026
46 checks passed
@zackees
zackees deleted the test/5262-null-audio-monitor branch November 19, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant