Skip to content

test: Extract and characterize scene-item parent-group query before Rust swap #5276

Open

Description

@zackees

Extract only obs_sceneitem_get_group from libobs/obs-scene.c.h into an independently replaceable C implementation before its later obs-scene Rust swap. The static get_sceneitem_parent_group helper remains in place for reorder callers; expose a narrow real callable seam to it, retaining C ownership of scene state and full locking.

Add a portable C characterization that pins NULL scene/item and group-item rejection before locking; exactly one balanced full-lock around lookup; matching parent-group identity, first matching group, foreign/no-group cases; and the exact borrowed pointer with no additional reference. Preserve the helper's walk and source context comparison. No Rust, public-header, existing-C-test, or WebSocket changes.

Register the new test with a tests.d pointer and sorted canonical graph, keep all native inventories consistent and core-source unity includes sorted. Validate RED then GREEN, the complete native_build:: module, focused Linux Tier 2 with the new target and EVERY *_rust target, ci/windows_link_check.py, and one full ./lint. Check merge compatibility with concurrent scene/core-source/graph work before publishing. This behavior-neutral prerequisite follows #5242 and #5263. The subsequent Rust swap is a separate issue dependent on this extraction landing.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: scene-item parent-group C characterization and wrapper-only extraction in pool slot /home/niteris/dev/obs-rust/obs-studio2-extern/fix5159, branch test/5276-sceneitem-get-group.

    1. Pin rejection, balanced full locking, helper walk/identity and borrowed ownership with a portable C characterization, then commit RED and GREEN extraction evidence.
    2. Keep the static helper/reorder callers in place behind a real callable seam; register the new test and synchronize native inventories and sorted S-group includes.
    3. Validate native_build::, Linux Tier 2 including EVERY *_rust target, Windows/Darwin links and one full lint; check concurrent branches before publication. First READY PR expected this session if backpressure permits; otherwise preserve BRANCH-ONLY evidence. A separate follow-up issue will track the Rust swap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions