Skip to content

Remove unused transport switches - #8

Closed
behinddwalls wants to merge 1 commit into
preetam/issue-82-store-retriesfrom
preetam/issue-83-unused-config
Closed

behinddwalls wants to merge 1 commit into
preetam/issue-82-store-retriesfrom
preetam/issue-83-unused-config

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Summary

Why?

server.http2 and store.gcs.direct_connectivity were accepted configuration values with no runtime consumers, so changing them gave operators a false impression that transport behavior changed.

What?

Remove both unsupported switches from the configuration surface and example file, and add a regression test proving the obsolete keys are rejected.

Test Plan

✅ cargo test -p walgit-config removed_transport_switches_are_rejected
✅ cargo fmt --all -- --check
✅ git diff --check

Issue

Closes tobi#83

Test Plan

Issues

ISSUE-83

Stack

  1. Remove ineffective arbitrary-want setting #2
  2. Enforce global request limits #3
  3. Reject zero per-repo concurrency #4
  4. Complete protocol v2 object-info support #5
  5. Remove ignored Git binary setting #6
  6. Apply configured store retry budget #7
  7. @ Remove unused transport switches #8
  8. Ignore macOS Finder metadata #9

## Summary

### Why?

`server.http2` and `store.gcs.direct_connectivity` were accepted configuration values with no runtime consumers, so changing them gave operators a false impression that transport behavior changed.

### What?

Remove both unsupported switches from the configuration surface and example file, and add a regression test proving the obsolete keys are rejected.

## Test Plan

✅ `cargo test -p walgit-config removed_transport_switches_are_rejected`
✅ `cargo fmt --all -- --check`
✅ `git diff --check`

## Issue

Closes tobi#83
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@behinddwalls

Copy link
Copy Markdown
Owner Author

Superseded by upstream draft tobi#91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant