Skip to content

Enforce global request limits - #3

Closed
behinddwalls wants to merge 1 commit into
preetam/issue-77-arbitrary-wantsfrom
preetam/issue-78-request-limits
Closed

behinddwalls wants to merge 1 commit into
preetam/issue-77-arbitrary-wantsfrom
preetam/issue-78-request-limits

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Summary

Why?

The server accepted global concurrency and timeout settings without applying them, allowing unbounded work and requests that could outlive their configured deadline.

What?

Add shared request-limit middleware that bounds queueing and active work, retains permits for streaming bodies, and applies one deadline across queue time, handler execution, and response delivery. Reject zero-valued global limits during configuration validation.

Test Plan

✅ cargo test -p walgit-config
✅ cargo fmt --all -- --check
✅ git diff --check
⚠️ cargo check -p walgit-server reached the protobuf build script but could not run because protoc is unavailable in this environment.

Issue

Closes tobi#78

Test Plan

Issues

ISSUE-78

Stack

  1. Remove ineffective arbitrary-want setting #2
  2. @ Enforce global request limits #3
  3. Reject zero per-repo concurrency #4
  4. Complete protocol v2 object-info support #5
  5. Remove ignored Git binary setting #6
  6. Apply configured store retry budget #7
  7. Remove unused transport switches #8
  8. Ignore macOS Finder metadata #9

## Summary

### Why?

The server accepted global concurrency and timeout settings without applying them, allowing unbounded work and requests that could outlive their configured deadline.

### What?

Add shared request-limit middleware that bounds queueing and active work, retains permits for streaming bodies, and applies one deadline across queue time, handler execution, and response delivery. Reject zero-valued global limits during configuration validation.

## Test Plan

✅ `cargo test -p walgit-config`
✅ `cargo fmt --all -- --check`
✅ `git diff --check`
⚠️ `cargo check -p walgit-server` reached the protobuf build script but could not run because `protoc` is unavailable in this environment.

## Issue

Closes tobi#78
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@behinddwalls

Copy link
Copy Markdown
Owner Author

Superseded by upstream draft tobi#86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant