Repository navigation
Remove ignored Git binary setting - #6
Closed
behinddwalls wants to merge 1 commit into
Closed
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary ### Why? `git.binary` implied that every Git subprocess could use an operator-selected executable, but the implementation consistently invokes `git` from `PATH` and never read the setting. ### What? Remove the unsupported configuration field and example entry, and verify that the obsolete key is rejected instead of silently suggesting custom-binary support. ## Test Plan ✅ `cargo test -p walgit-config removed_git_binary_configuration_is_rejected` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` ## Issue Closes tobi#81
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Sep 30, 2026
Owner
Author
|
Superseded by upstream draft tobi#89. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
Why?
git.binaryimplied that every Git subprocess could use an operator-selected executable, but the implementation consistently invokesgitfromPATHand never read the setting.What?
Remove the unsupported configuration field and example entry, and verify that the obsolete key is rejected instead of silently suggesting custom-binary support.
Test Plan
✅
cargo test -p walgit-config removed_git_binary_configuration_is_rejected✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes tobi#81
Test Plan
Issues
T3-ISSUE-81
Stack