Repository navigation
Apply configured store retry budget - #7
Closed
behinddwalls wants to merge 1 commit into
Closed
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary ### Why? `store.max_retries` was documented as an operator-controlled retry budget, but backend construction ignored it and GCS used fixed retry counts. ### What? Use the configured number of extra attempts for transient GCS metadata failures, interrupted GCS bulk reads, S3 SDK operations, and S3 HTTP GETs. Retry with bounded jittered backoff and preserve zero as the way to disable retries. Healthy store calls remain one request. Only transient failure paths add up to `store.max_retries` attempts, and this change adds no CAS object or healthy-path round trip. ## Test Plan ✅ `cargo check -p walgit-store --all-features` ✅ `cargo test -p walgit-store --all-features bulk_read_resumes_after_mid_stream_cut` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` ## Issue Closes tobi#82
This was referenced Sep 30, 2026
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Owner
Author
|
Superseded by upstream draft tobi#90. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
Why?
store.max_retrieswas documented as an operator-controlled retry budget, but backend construction ignored it and GCS used fixed retry counts.What?
Use the configured number of extra attempts for transient GCS metadata failures, interrupted GCS bulk reads, S3 SDK operations, and S3 HTTP GETs. Retry with bounded jittered backoff and preserve zero as the way to disable retries.
Healthy store calls remain one request. Only transient failure paths add up to
store.max_retriesattempts, and this change adds no CAS object or healthy-path round trip.Test Plan
✅
cargo check -p walgit-store --all-features✅
cargo test -p walgit-store --all-features bulk_read_resumes_after_mid_stream_cut✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes tobi#82
Test Plan
Issues
ISSUE-82
Stack