Repository navigation
Complete protocol v2 object-info support - #5
Closed
behinddwalls wants to merge 1 commit into
Closed
behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary ### Why? The server implemented an undiscoverable, protocol-incompatible `object-info` handler that decoded local objects and could not answer from remote-served pack bases. ### What? Advertise `object-info`, parse its post-delimiter arguments, emit the protocol-defined size response, and read headers through either local or remote object access. Add a manifest-versioned bounded size cache and parallelize remote misses across requested objects. The request path remains one conditional manifest GET. Warm cache hits and local header lookups add zero bucket reads; remote cache misses add only the pack range reads already required by `RemotePacks::header`, issued in parallel across requested objects. No CAS or write rate changes. ## Test Plan ✅ `cargo check -p walgit-server` ✅ `cargo test -p walgit-git read_object_info_args_reads_size_and_oids_after_delimiter` ✅ `cargo test -p walgit-server --test e2e info_refs_v2_advertises_capabilities -- --exact` ✅ `cargo test -p walgit-server --test e2e object_info_v2_reports_object_size -- --exact` ✅ `cargo fmt --all -- --check` ✅ `git diff --check` ## Issue Closes tobi#80
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Sep 30, 2026
Owner
Author
|
Superseded by upstream draft tobi#88. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary
Why?
The server implemented an undiscoverable, protocol-incompatible
object-infohandler that decoded local objects and could not answer from remote-served pack bases.What?
Advertise
object-info, parse its post-delimiter arguments, emit the protocol-defined size response, and read headers through either local or remote object access. Add a manifest-versioned bounded size cache and parallelize remote misses across requested objects.The request path remains one conditional manifest GET. Warm cache hits and local header lookups add zero bucket reads; remote cache misses add only the pack range reads already required by
RemotePacks::header, issued in parallel across requested objects. No CAS or write rate changes.Test Plan
✅
cargo check -p walgit-server✅
cargo test -p walgit-git read_object_info_args_reads_size_and_oids_after_delimiter✅
cargo test -p walgit-server --test e2e info_refs_v2_advertises_capabilities -- --exact✅
cargo test -p walgit-server --test e2e object_info_v2_reports_object_size -- --exact✅
cargo fmt --all -- --check✅
git diff --checkIssue
Closes tobi#80
Test Plan
Issues
ISSUE-80
Stack