Skip to content

Complete protocol v2 object-info support - #5

Closed
behinddwalls wants to merge 1 commit into
preetam/issue-79-per-repo-concurrencyfrom
preetam/issue-80-object-info
Closed

behinddwalls wants to merge 1 commit into
preetam/issue-79-per-repo-concurrencyfrom
preetam/issue-80-object-info

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Summary

Why?

The server implemented an undiscoverable, protocol-incompatible object-info handler that decoded local objects and could not answer from remote-served pack bases.

What?

Advertise object-info, parse its post-delimiter arguments, emit the protocol-defined size response, and read headers through either local or remote object access. Add a manifest-versioned bounded size cache and parallelize remote misses across requested objects.

The request path remains one conditional manifest GET. Warm cache hits and local header lookups add zero bucket reads; remote cache misses add only the pack range reads already required by RemotePacks::header, issued in parallel across requested objects. No CAS or write rate changes.

Test Plan

✅ cargo check -p walgit-server
✅ cargo test -p walgit-git read_object_info_args_reads_size_and_oids_after_delimiter
✅ cargo test -p walgit-server --test e2e info_refs_v2_advertises_capabilities -- --exact
✅ cargo test -p walgit-server --test e2e object_info_v2_reports_object_size -- --exact
✅ cargo fmt --all -- --check
✅ git diff --check

Issue

Closes tobi#80

Test Plan

Issues

ISSUE-80

Stack

  1. Remove ineffective arbitrary-want setting #2
  2. Enforce global request limits #3
  3. Reject zero per-repo concurrency #4
  4. @ Complete protocol v2 object-info support #5
  5. Remove ignored Git binary setting #6
  6. Apply configured store retry budget #7
  7. Remove unused transport switches #8
  8. Ignore macOS Finder metadata #9

## Summary

### Why?

The server implemented an undiscoverable, protocol-incompatible `object-info` handler that decoded local objects and could not answer from remote-served pack bases.

### What?

Advertise `object-info`, parse its post-delimiter arguments, emit the protocol-defined size response, and read headers through either local or remote object access. Add a manifest-versioned bounded size cache and parallelize remote misses across requested objects.

The request path remains one conditional manifest GET. Warm cache hits and local header lookups add zero bucket reads; remote cache misses add only the pack range reads already required by `RemotePacks::header`, issued in parallel across requested objects. No CAS or write rate changes.

## Test Plan

✅ `cargo check -p walgit-server`
✅ `cargo test -p walgit-git read_object_info_args_reads_size_and_oids_after_delimiter`
✅ `cargo test -p walgit-server --test e2e info_refs_v2_advertises_capabilities -- --exact`
✅ `cargo test -p walgit-server --test e2e object_info_v2_reports_object_size -- --exact`
✅ `cargo fmt --all -- --check`
✅ `git diff --check`

## Issue

Closes tobi#80
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@behinddwalls

Copy link
Copy Markdown
Owner Author

Superseded by upstream draft tobi#88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant