Skip to content

[Fix] Personal instructions drafts disappear after settings refresh #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix] Personal instructions drafts disappear after settings refresh #3491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 97 additions & 2 deletions apps/web/src/components/settings/PersonalizationSection.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions apps/web/src/components/settings/PersonalizationSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';

import { useEffect, useState } from 'react';
import { useState } from 'react';
import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query';
import { toast } from 'sonner';

Expand Down Expand Up @@ -28,13 +28,14 @@ export function PersonalizationSection() {
const personalization = useQuery(
trpc.preferences.getPersonalization.queryOptions(),
);
const [instructions, setInstructions] = useState('');
const [draft, setDraft] = useState<string | null>(null);
const settings = personalization.data;
const instructions = draft ?? settings?.instructions ?? '';

useEffect(() => {
if (personalization.data) {
setInstructions(personalization.data.instructions);
}
}, [personalization.data]);
// Once saved data matches the draft, follow subsequent clean refreshes again.
if (draft !== null && draft === settings?.instructions) {
setDraft(null);
}

const update = useMutation(
trpc.preferences.updatePersonalization.mutationOptions({
Expand All @@ -43,7 +44,7 @@ export function PersonalizationSection() {
queryKey,
settings,
);
setInstructions(settings.instructions);
setDraft(null);
},
onError: (error) => {
toast.error(error.message);
Expand All @@ -52,7 +53,6 @@ export function PersonalizationSection() {
}),
);

const settings = personalization.data;
const isBusy = personalization.isPending || update.isPending;
const hasChanges = settings?.instructions !== instructions;

Expand Down Expand Up @@ -80,7 +80,7 @@ export function PersonalizationSection() {
rows={7}
className="md:min-h-48"
placeholder="For example: Keep answers concise, lead with a recommendation, and use examples when explaining unfamiliar concepts."
onChange={(event) => setInstructions(event.target.value)}
onChange={(event) => setDraft(event.target.value)}
/>
{instructions.length > MAX_INSTRUCTIONS_LENGTH * 0.8 && (
<div className="flex justify-end text-xs text-muted-foreground">
Expand Down
Loading