Repository navigation
Conversation
Enable the release branch test trigger and repair the inert recovery provenance fixture exposed by that run. No production app code changes.
(cherry picked from commit f225c19)
This was referenced Oct 17, 2026
This was referenced Oct 18, 2026
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R5 makes unused-key deletion discoverable while preserving wallet-reference protection, and removes confirmed startup/retry failures. This draft reconciles with the submitted R4 / 2.6.4 source. Source ancestry is complete; fresh store state and owner R4 closure remain separate.
Scope and released baseline
codex/r5-key-deletion-startup; head:77b72da29ac5f2cdf3f51c9a0e9f3fd1c2af7238.1d8a86a7462d935cbd0e28b857934b5718c152fc, integrated into R5 througha8947c867562b6148f328289069785b18053b944. R4/sprint/other workstream refs are unchanged. No force push or PR merge.sprint, whose ordinary diff still includes inherited released history.Changes
Executed Cloud validation
Node 22.23.3 / Yarn 1.22.22, reconciled source:
jest --runInBand --coverage=falsenpm run test:recoveryHosted exact-head results (still updating):
Incomplete multi-character sanitizationalert atsrc/services/wallets/operations/index.ts:110–111. This entire module is byte-identical to released R4; the reported expression counts Miniscript witness elements for fee estimation. No dismissal, waiver, exploitability conclusion or unrelated fix is made here; security review remains required. Detailed alert API access returned HTTP403; the check annotation was readable.Run genuine automatic backup source matrix; no pass is claimed or fixture/protocol workaround introduced. The Lint job completed successfully under its inheritedcontinue-on-errorpolicy, which does not make the documented lint failures clean. Prior-head results are not transferred. The inherited genuine lane uses the released public-v2 fixture against newer protocol code; any failure remains visible without a fixture/protocol workaround in R5.keeper/local-validationremains FAIL / NEEDS_LOCAL, as expected without exact-head native evidence.Evidence and limits: reconciliation, startup/investigations, workstream, OpenSpec tasks. JavaScript and Linux Realm results do not establish native authentication, persistent first-wallet idempotency or measured startup performance.
Cloud execution route — owner clarification
The owner explicitly requests no dependency on the personal Mac. Continue R5 in the Bitcoin Keeper Cloud environment, with Android development builds/emulator acceptance on a capable Linux cloud runner and iOS simulator acceptance on hosted macOS/Xcode. This is not a request for owner-Mac execution or a waiver of native/physical tests.
The existing
Codex local handoff,NEEDS_LOCALandRequired local checksfields below are the current AGENTS.md/gate protocol. Their legacy names record missing platform evidence; they do not determine where tests must execute. Do not invent a local pass for a hosted run or change the gate to hide missing evidence.Current worker preflight: Linux x86_64, 24 GiB available disk, Java available; Android SDK/adb/emulator/Maestro and /dev/kvm unavailable; no Xcode runtime. Its managed network is connected/enforced with no configured additional capabilities or credential bindings. Selecting a named environment alone is not proof that these toolchains/devices are present; verify their readiness there.
Existing cloud-native candidates #7060/#7063 (bootstrap) and #7062 (reusable acceptance) remain separate and unmerged. Historical iOS/Android smoke evidence belongs to their tested source, not this R5 head. Their reviewed adoption/execution must preserve privacy, exact-source evidence, unchanged R4/other workstreams, and the no release-signing/distribution boundary. Do not import that infrastructure into R5 as a third feature or merge it as part of this clarification.
Next Cloud action: attach/use the Bitcoin Keeper environment with Android SDK/JDK, disposable emulator access with KVM or an available remote device, and a hosted macOS/Xcode route; then run the exact-head R5 feature matrix below. Physical biometrics/NFC/USB/signers still require real-device access (potentially remote); emulator success does not supply physical credit. No personal-Mac task is requested.
Codex local handoff
State: NEEDS_LOCAL
PR: #7058
Base: sprint
Head branch: codex/r5-key-deletion-startup
Head commit: 77b72da
Goal and acceptance criteria: discoverable safe deletion; reliable startup/retry/authentication; measured first-wallet performance; bounded Android navigation/timezone reproduction; correct Emergency/Assisted Backup copy.
Changes made: released-R4 reconciliation, original-session deletion authority, startup credential/error/token/timer guards, login flow and narrow helper copy as described above.
Cloud checks: PASS 538 Jest, 106 focused, 480 recovery, 11 gate, 31 static, 28 Node/7 Python release tests; frozen/patch/input/OpenSpec/version/diff PASS. Lint FAIL82/25 and TypeScript FAIL943, zero added normalized baseline findings. Ruby unavailable locally; hosted Tests (including Ruby) and public-backend jobs PASS; the separate legacy genuine matrix FAILS; Lint job completed with inherited continue-on-error. CodeQL analysis completed, but its security-result check FAILS on one high-severity alert in unchanged released wallet code; review required. Native NOT RUN.
Required local checks: IOS, ANDROID, HARDWARE
Local checks requested: Execute native checks on Cloud: Android development/emulator on a capable Linux runner and iOS on hosted macOS/Xcode. No owner-Mac work requested. From this exact head, run cold/warm/resume with theme/network/Tor/deep links and credential failure/Retry; disposable unused/hidden deletion, cancellation, active/hidden/canary/multi-wallet blocks, archived retention, references added during confirmation, account/session switches including A → B → A; offline/repeated setup Retry/Next, success/relaunch and persistent wallet counts; at least five raw first-wallet/startup samples with exact build/device/OS/network; #7055 More→Wallets and #6991 timezone/DST/history/details; PIN/biometrics and Emergency/Inheritance/Assisted Server Backup copy. Preserve raw evidence and distinguish each unrun physical scenario.
Risks / known gaps: Native acceptance, performance and scoped Android reproduction remain unrun. Existing genuine fixture mismatch, lint/TypeScript debt, the inherited high-severity CodeQL alert and unavailable local Ruby are explicit. R4 native passes or physical deferrals do not transfer to R5. No new R5 app version assigned. For Cloud native work, verify available disk against the actual build requirement, run one platform build at a time and reuse safe compatible caches/artifacts. The owner requests no personal-Mac dependency; retain its earlier safeguards only as protection if a later explicit fallback is authorized. Never delete other worktrees, simulators, AVD users, wallet data, caches or evidence without approval. Optional Linux setup is not a prerequisite. No merge, signing, publication, deployment or release approval.