Skip to content

R5: full-product native startup and first-wallet measurement harness - #7073

Draft
antuz123 wants to merge 244 commits into
sprintfrom
codex/r5-native-product-measurements
Draft

antuz123 wants to merge 244 commits into
sprintfrom
codex/r5-native-product-measurements

Conversation

@antuz123

@antuz123 antuz123 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The existing hosted startup smoke stops before account creation, and module probes cannot measure the actual first-wallet journey. This separate R5 acceptance package adds five full-app UI samples through normal index.js, production setup and encrypted persistence, with cold relaunch and More→Wallets checks. It exports bounded numeric evidence and fails on incomplete UI, duplicate setup requests or artifact changes.

Refs #7059 / #7061 / #7065. This is an acceptance infrastructure package, not the unidentified running 5.2 package. Preserve active producers and release boundaries.

Source and review scope

  • Based on verified 5.1 source c1c4b80, including core R5: safe key deletion and startup fixes on submitted 2.6.4 source (draft) #7058 and both protected-backup and Version History corrections. Producer refs are unchanged.
  • Exact head: 040955d.
  • Patch-only comparison. Base remains sprint per AGENTS.md; ordinary PR diff includes inherited R4/R5 implementation.
  • Approximately 10.4k changed code/test tokens; one bounded acceptance feature. No app version assigned.
  • Includes the separately reviewed Android diagnostic guard: manual workflow_dispatch only and cancel-in-progress:false. It prevents new PR-triggered package/signing diagnostics without cancelling existing jobs.

Behavior and boundaries

  • Only product change: a FlatList test ID derived from the already-rendered visible wallet count. Hidden/archived counts and wallet IDs are not added to exported evidence.
  • Five fresh disposable DEVELOPMENT/Testnet samples measure startup→passcode and Start New→ready/home. Each generates a real disposable wallet via the production saga, explicitly skips backup, cold-relaunches, unlocks with public fixture PIN1111, and requires the same one-wallet list and More→Wallets navigation.
  • After cold login the flow also visits More→App Settings→Version History, checks the installed native tuple against committed release/version.json and retains the Initially installed row. Fresh current accounts already have that row; missing/stale-history observation insertion and migration remain unproven. Keys→Manage Keys entry/back navigation is checked without creating a deletion intent or opening recovery material.
  • A sixth fresh fixture separately disconnects the first bounded createNewApp request before any server commit, then requires the real creation-error UI, exactly one error title, explicit Retry, one successful response, and cold-relaunch wallet count1. It rejects hidden/extra native requests. This is controlled loopback transport failure, not physical WAN-offline acceptance, and never joins the five performance samples.
  • Normal Metro entrypoint; no helper/probe timing is substituted. Timings include development/driver overhead and do not establish release-build performance.
  • Loopback-only controlled createNewApp response; signing/channel/Sentry endpoints remain blocked. No current Relay compatibility credit. Public Testnet Electrum behavior follows source defaults. No faucet, funded wallet, seed-word view, backup enrollment, transaction or signing operation.
  • Requires the separately reconciled hosted_native.py foundation and a successful exact-source build with its loopback fixture configured before build. It cannot run standalone before those dependencies are integrated.
  • Restricted to disposable GitHub-hosted runners; rejects physical Android devices. Own temporary Maestro diagnostics/screenshots, Metro logs, command output and app state are removed. Upload only the foundation's bounded metadata.json artifact.
  • This bounded fresh-state More→Wallets check does not close R5 follow-up: Android More → Wallets exits to launcher after backup deletion #7055's original backup-delete/multiuser trigger. Deletion/reference, offline/retry, protected-backup and physical-biometric acceptance remain separate.

The prepared package.json module-mapping overlay is narrowly accepted only when its recorded before hash matches committed HEAD, its after hash matches current bytes, its allowlist is exactly browser/react-native/browserify, and every other parsed field remains equal. Unrecorded changes or altered dependencies/scripts fail closed.

Actual checks

  • PASS: 23 loopback HTTP/disconnect/retry/receipt, manifest-overlay and native-version expectation controls covering unknown/oversized requests, fixed metric allowlisting/nonretention, out-of-order/duplicate stages, missing/duplicate setup, numeric complete receipts and partial failures.
  • PASS: Python syntax, JavaScript syntax, YAML parse, git diff --check.
  • iOS/Android full-app build/UI and five raw measurements: NOT RUN. Hosted foundation integration/execution remains required.
  • Existing source failures remain inherited evidence: genuine public-v2 automatic-backup matrix, high CodeQL security result, lint/TypeScript debt and missing native signoff. They are not waived or rerun here.
  • Independent agent source review found no significant blocker in the runner/flow/count marker; its requested bundle-configuration dirty-check extension is included. Native selectors remain unverified until execution. No native acceptance, release readiness or signing/distribution approval claimed.

Codex local handoff

State: NEEDS_LOCAL
PR: #7073
Base: sprint
Head branch: codex/r5-native-product-measurements
Head commit: 040955d
Goal and acceptance criteria: verified full-product UI startup/first-wallet measurements, exactly one setup request and one visible wallet after cold relaunch in all five samples, bounded safe evidence; separate real transport failure→UI Retry→success/cold-persistence fixture.
Changes made: standalone hosted measurement runner/flows, loopback responder, receipt/privacy controls, visible-list testID and separate manual-only Android diagnostic guard.
Cloud checks: 23 HTTP/disconnect/retry/receipt/manifest-overlay/version controls PASS; Python/JavaScript/YAML/diff syntax checks PASS. Native UI and raw samples NOT RUN.
Required local checks: IOS, ANDROID
Local checks requested: Execute on hosted macOS/Xcode and disposable Linux Android emulator after reviewed foundation integration. Use exact combined candidate build, ordinary Metro bundle, loopback setup transport and five raw samples plus the separate sixth controlled-disconnect/Retry fixture. No personal Mac requested. Physical biometrics/hardware are outside this measurement package and receive no credit.
Risks / known gaps: First native selectors and per-platform credential resets unverified until actual execution; fixture is not Relay compatibility; debug/driver timings are not release performance. No PR merge, shared-branch promotion, release signing, upload, distribution, deployment or publication authorized.

antuz123 and others added 30 commits September 25, 2026 21:28
Enable the release branch test trigger and repair the inert recovery provenance fixture exposed by that run. No production app code changes.
redkeep-agents and others added 25 commits October 15, 2026 02:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R5 follow-up: Android More → Wallets exits to launcher after backup deletion

3 participants