Skip to content

Repair missing ESLint lockfile selectors - #7064

Draft
antuz123 wants to merge 1 commit into
sprintfrom
codex/frozen-lock-selectors
Draft

antuz123 wants to merge 1 commit into
sprintfrom
codex/frozen-lock-selectors

Conversation

@antuz123

Copy link
Copy Markdown
Collaborator

The current sprint manifest requests two ESLint selectors absent from yarn.lock. This is the pre-existing mismatch exposed by #7063's frozen dependency installation. This PR copies the existing two-hunk lockfile repair from #7058 into a separate prerequisite; it changes only yarn.lock (8 additions, 1 deletion).

  • Add eslint-plugin-react-native@^5.0.0 resolving to 5.0.0.
  • Add eslint-plugin-react@^7.37.5 to the existing 7.37.5 entry.
  • All 2,299 prior selector entries retain byte-identical version, resolution, integrity and dependency fields. No manifest, app, NitroModules, Podfile.lock, AppDelegate or workflow change is included.

Source and validation

Static checks and scoped independent review PASS with no findings: exactly the two expected selectors were added; every prior selector entry is unchanged; all 150 root selectors are present; all 145 semver resolutions satisfy their manifest constraints (five unchanged Git selectors are outside semver validation); scope and whitespace checks pass.

Fresh dependency installation and app/native tests were NOT RUN for this preparation. #7058's earlier CI passed frozen installation, manifest/lock immutability and 234 tests at that source. This is prior evidence, not a fresh pass for this PR. Publication-triggered CI results must be read separately.

Automatic checks and cost scope

The repository is public. This branch retains only existing standard Ubuntu CI Lint/Tests, CodeQL and the trusted local-validation gate. It includes no hosted-native build/emulator workflow, artifact-upload step, configured dependency cache, new service or permission change. The release-only RAG workflow is not triggered; this head branch matches no push trigger before a PR exists. Standard public-repository runners are free under GitHub's documented policy.

Inherited Tests uses non-frozen yarn install, including the existing prepare/setup script that attempts CocoaPods setup; it does not provide a frozen-install proof. Existing lint tolerance is unchanged, so a green Lint job does not imply a clean lint command. No checks are weakened or bypassed. The keeper/local-validation gate still applies: a yarn.lock change is not covered by its docs/.github exemption, and static review supplies no native sign-off.

Adoption order — no adoption authorized

Keep this PR and #7063 draft and unmerged. This is only the separately reviewable dependency prerequisite; publication grants no merge or trust approval.

After a separately approved baseline change, revalidate #7063 against the repaired sprint baseline while preserving its infrastructure-only scope and draft guards. #7063 remains unchanged at 0984c5b97e7e8326d6856ba662274ecf325e5e0f. Continue remaining native baseline repairs from #7060 separately, then restack #7062 only under separate authorization, preserving diagnostic privacy, provenance, draft guards and failure/hardware requirements.

No R5 features, R4/Mac work, native execution, signing/distribution, deployment, trust/security settings or release operations are included. Existing IAP/Nitro native compatibility work remains outside this lock-only prerequisite.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants