Skip to content

Hide wallet fails locally with “Something went wrong!”; investigate local persistence and backup guards #7075

Open

Description

@antuz123

Owner post-release confirmation — 31 October 2026

The owner reports Hide Wallet still fails on iOS 2.6.5 (621). Keep this issue open and preserve its agreed R6 / 2.6.6 first-priority bug-fix placement.

On the same installation, both Check Again and Back Up Now fail at local-capture / non-transport, with no HTTP status (318 ms and 311 ms respectively); see #7066. The shared local recovery capture/backup guard is an investigation lead, not a confirmed common root cause.

The owner explicitly prioritizes backup and hide-wallet above the remaining Version History issue. Version History is parked in Later, unscheduled. No additional repeated phone test is requested now; implementation and native verification remain outstanding. No release placement beyond the existing R6 decision is changed by this update.


Earlier release decisions and evidence retained

Release decision — R6 / 2.6.6

22 October 2026 — updated release placement following the owner's latest guidance: keep hide-wallet #7075 in R6 / 2.6.6 as the first-priority bug fix. Move the companion dust/manual-spendability correction #7077 to R7 / 2.6.7 to reduce R6's scope. This supersedes the earlier plan to include both in R6. R5 remains 2.6.5; no intermediate maintenance release is scheduled. The investigation is complete to the extent recorded below; implementation and native/device acceptance remain pending.

Describe the bug

The owner reports that Hide wallet does not work on an existing iPhone installation after the 2.6.4 update. The supplied Wallet Settings screenshot shows “Something went wrong!” after the attempt. A separate screenshot shows “Could not confirm protected-backup deletion. Your local wallets and Recovery Key are unchanged. Check the backup status before trying again.”

Latest owner clarification, 22 October 2026: the wallet did not hide locally either. Treat failed local hiding as the primary reported incident. This is not merely an unsuccessful backend update or an inaccurate error toast after an otherwise successful hide. The post-commit error-contract defect described below is an additional demonstrated failure mode; fixing that alone does not satisfy this report.

The owner reasonably suspects a relationship to the ongoing backup failure. Investigation finds a shared local backup bookkeeping dependency, but a remote upload failure alone is not the mechanism blocking hiding.

Status: reported incident; source investigation and controlled reproductions completed; implementation and native/device confirmation pending. The exact failure stage on the owner's phone remains unconfirmed.

Reproduction and expected result

  1. On an existing upgraded account, open a bitcoin wallet → Wallet Settings.
  2. Choose Hide wallet and complete any normal confirmation.
  3. Observe the generic failure toast; the wallet remains visible locally, as confirmed by the owner.
  4. In disposable reproduction, inspect both the stored visibility and Home/Manage Wallets/reopen behavior to distinguish a rejected/failed local save from a saved flag that is not reflected in the list or is later overwritten. The phone's database value has not been inspected; do not infer it from UI evidence alone.

Expected: a successful local hide removes the wallet from normal Home display, remains reversible through the existing authenticated show/unhide flow, and survives restart. Backup availability must be represented separately. Genuine local persistence failure must not be reported as success; an already committed hide must not be falsely reported as an uncommitted transaction.

The screenshot layout is consistent with the vault-backed wallet settings screen. The exact wallet kind should be established in disposable reproduction; both WALLET and VAULT use the same worker and are covered below.

Evidence and source checkpoints

Confirmed code behavior

The settings callback displays the supplied generic error when its local-completion result is false.

The visibility worker:

  1. Validates account/session ownership.
  2. Begins a backup-local operation, capturing the account's complete recovery snapshot.
  3. Writes local presentationData.visibility.
  4. Completes the operation, including another recovery snapshot.
  5. Acknowledges local success to the UI.
  6. Only then calls the backup upload worker.

The local-operation helpers and whole-account snapshot therefore require investigation independently of server HTTP results.

Additional confirmed error-contract defect (not established as the cause of the owner's failed local hide): completeBackupLocalOperation calls local() after the Realm transaction has committed. If this post-commit capture throws, the outer catch in commitBackupLocalOperation returns { committed: false }. The visibility worker consequently reports failure even though the visibility write can already be committed. It then skips the success/navigation path and backup producer.

The owner has confirmed the local hiding behavior failed. The toast alone still cannot tell whether the underlying write was rejected, failed, or was not reflected in the view. Establish that distinction in disposable/native reproduction; do not substitute the post-commit scenario for the reported incident.

Controlled source reproduction actually executed

Executed the unmodified source-extracted released-R4 visibility worker and backup-local operation helpers with Node TypeScript stripping. Account state, Realm transaction boundaries, recovery-snapshot capture and transport were controlled synthetic adapters.

14/14 expected-outcome assertions passed: seven cases for WALLET and seven for VAULT. These are tests demonstrating current failure behavior, not fixed behavior.

Controlled condition Persisted visibility UI callback Backup worker reached
Upload throws after local save HIDDEN true yes
Server returns an unsuccessful result HIDDEN true yes
No verified backup write intent HIDDEN true yes
Recovery snapshot fails before local save unchanged false no
Local transaction fails unchanged false no
Wrong selected account unchanged false no
Recovery snapshot fails after transaction commits HIDDEN false no

Deterministic failing case for a repository regression: allow the begin-operation and pre-write captures to succeed; commit the visibility transaction; make the post-transaction capture fail; assert that the current implementation returns a false local-completion result despite reading HIDDEN from the persisted entity.

No native iOS/Android UI, genuine encrypted Realm, live Relay, or original-phone reproduction was executed in this investigation. Those are remaining acceptance work.

Decisive diagnostic for the clarified local failure

Source inspection confirms that Home filters hidden wallets, Manage Wallets separates DEFAULT/HIDDEN, and the wallet hook uses reactive Realm queries and memoized snapshots. There is no demonstrated missing visibility filter, and no upgrade-specific schema cause has yet been established.

On a disposable native reproduction, record the target's visibility enum only before dispatch, after the callback, and after settled refresh/cold reopen, with bounded stage code and account-match/entity-exists booleans:

Observed persisted state What to investigate next
DEFAULT throughout Pre-commit snapshot, account/session rejection, or Realm transaction failure
HIDDEN in Realm but still visible in Home Reactive query/snapshot/list propagation
HIDDEN then DEFAULT A later writer replacing the visibility value

Do not log stable account/wallet identifiers, recovery snapshots, keys, addresses or raw exception contents. This diagnostic distinguishes the real local failure without requiring server acknowledgement.

Narrow correction requested

  • Primary correction: reproduce and fix the owner's failed local hide. Trace originating account/session validation, pre-commit whole-account snapshot, actual Realm write/readback, and Home/Manage Wallets visibility propagation. The demonstrated post-commit error-reporting fix alone is insufficient.
  • Diagnose the actual failure stage using disposable upgraded-account fixtures. Retain a bounded stage/result category if runtime evidence is needed; do not emit raw recovery data or full data-bearing exceptions.
  • Separate actual local persistence outcome from backup proof/capture/upload outcome. Confirm the originating account and persisted target state before reporting local success.
  • Keep a truthful backup-pending/reconciliation state when hiding succeeds but backup proof/upload fails. Do not invent a verified revision or grant destructive-operation authority.
  • Preserve current-account/session guards and the backup consent/readback/deletion safeguards. Do not globally reinterpret all failed backup commits as success or bypass safeguards for deletion.
  • If local state genuinely cannot be saved, return accurate actionable failure feedback.
  • Continue supporting local hide/unhide when automatic backup is disabled, remote backup is unverified, connectivity is unavailable, or a prior remote request failed.
  • Do not redesign backup enrollment, legacy purge, USDT, archived wallets, or unrelated settings.

Acceptance required before closure

  • Reproduce the generic-error-plus-local-wallet-still-visible case, demonstrate the underlying local cause, and show actual hiding works after the correction. Do not close this issue based only on a more accurate toast or successful backup upload.
  • Failing-before/passing-after regression for the post-commit snapshot failure, plus pre-commit snapshot failure, local write failure and stale-account rejection.
  • Hide and unhide for both normal wallets and vault-backed wallets through Settings and Manage Wallets.
  • Home visibility and persisted state agree immediately, after navigation, after cold restart and after subsequent wallet refresh.
  • Local success survives offline/remote upload failure; backup state remains honest and can reconcile later.
  • Account switches, including A → B → A, cannot apply a stale result or callback to another account/session.
  • Run targeted native iOS/Android acceptance on the exact final PR SHA. Finally confirm normal hide/reopen/unhide on the affected phone using an approved build; no reset/reinstall/restore-over/deleting backups is a diagnostic step.
  • Do not close solely because source fixtures or unrelated backup tests pass.

Release placement and Codex Cloud handoff

Target: R6 / 2.6.6 — first-priority bug fix within the release. Implement and validate the reported local hide failure in a focused PR, adopting the verified completed R5 source and any relevant existing fixes. The companion dust correction #7077 is assigned to R7 / 2.6.7 and is no longer part of this issue's R6 scope. Include the accepted hide-wallet correction in the R6 integration candidate and its iOS/Android acceptance. Preserve current R5 work and already-running producers. New R6 implementation follows the existing roadmap sequence after R5 closes; this scheduling update does not launch a Codex task.

Provisional remaining estimate for this issue: 2k–5k changed code/test tokens, subject to diagnosis of the affected-phone failure. The companion #7077 adds an estimated 3k–6k to R7, not R6. At R6 kickoff, reconcile completed work and estimate the whole remaining R6 scope, including Assisted Multisig and this hide-wallet fix. Apply the existing ~20k / more-than-two-substantial-features advisory to the combined release scope; keep any further allocation changes within numbered releases.

When handed off, use the Bitcoin Keeper Codex Cloud environment, not base. Re-read current AGENTS.md, applicable repo instructions, #7065, latest PR heads/comments and the companion dust report. Verify the actual source ancestry before branching; the PR base may be sprint per AGENTS.md even while the implementation baseline must include the relevant released/R5 work. Use a separate task branch and focused PR, preserve existing producers, add real regression coverage, report exact check results and provide the required exact-head Codex local handoff / NEEDS_LOCAL with IOS and ANDROID acceptance. Keep physical affected-phone confirmation explicit. No merge, signing, deployment or release approval is granted.

Related: #7077 (companion dust-override incident), #7066 (original protected-backup incident), #7067 (existing backup correction), #5716 (different hidden-wallet UX issue).

Activity

  1. changed the title [-]Hide wallet reports “Something went wrong”; backup snapshot failure can misreport a committed hide[/-] [+]Hide wallet fails locally with “Something went wrong!”; investigate local persistence and backup guards[/+] on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: to-do 📋Items not yet picked upType: bug🐛severity:S2Major: core flow blocked or degraded; provisional until reproduced

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions