Repository navigation
Open
Description
Goal
Before R5 release acceptance, reduce Mac-unlocked dependency by running native iOS simulator and Android emulator/build smoke tests in GitHub Actions. Keep physical device, signer, NFC/USB, real biometric, and user-approval/signing activities explicit and separate. Infrastructure-only work: do not expand R5 app feature scope or block ongoing R4 local validation.
Related: R5 draft #7058; current gate in AGENTS.md and .github/workflows/keeper-local-validation.yml; R4 #7045. Target base sprint with a separate CI-only PR. Do not merge until approved.
Codex Cloud task
- Inspect current workflows,
AGENTS.md,package.json, native setup and current R4/R5 PRs. Estimate scope first and split if unexpectedly large. Build upon existing trusted workflows; avoid duplication and broad refactors. Resolve or clearly expose manifest/lockfile and native-install blockers rather than reporting a misleading pass. - Add bounded hosted macOS iOS Simulator native build + one safe disposable startup/onboarding smoke path, and Linux Android emulator native build + one corresponding safe smoke path, as technically feasible. Existing Android build diagnostics are not emulator evidence. Use non-production configs and throwaway state, no production keys/PINs, no live funds, no release signing. Record OS/Xcode/SDK/device/runner version, commands, actual test results and exact tested app/source SHA; retain safe logs/artifacts with appropriate redaction.
- Modify native-validation evidence/gate minimally so genuine successful hosted runs on the exact current PR head satisfy
IOSand/orANDROIDwithout a Mac-local attestation. Keep an explicitHARDWAREgate, including existing owner-scoped physical-deferral rules; fail closed for stale, skipped, cancelled, untrusted, wrong-SHA or merely build-only results. Do not accept a PR-author assertion as CI evidence. Do not let PR code execute with elevatedpull_request_targetor signing credentials. Preserve local fallback if hosted setup is unavailable. Maintain branch protections and report their required administrative configuration rather than silently claiming enforcement. - Document a deterministic handoff: Cloud code complete → hosted native validation → one short Mac session only for physical cases / signing after approval → release review. New commits invalidate native evidence. Make this usable on R5 once its R4 baseline is settled; do not change R4 or R5 app code in this infrastructure PR.
- Prove CI and gate behavior with positive and negative exact-SHA scenarios, report practical runner cost/runtime and remaining unautomated cases. Keep tests bounded, avoid needless workflow/approval bureaucracy, and propose phased delivery if hosted iOS or emulator smoke tests cannot be made reliable quickly.
Acceptance
- New infrastructure PR with verified check outcomes and clear
pass/fail/not-runby platform on the actual head. - Trustworthy exact-head checks can satisfy
IOS/ANDROIDgating without Mac login; neither hardware nor signing approvals are implicitly waived. - R5 R5: safe key deletion and startup fixes on submitted 2.6.4 source (draft) #7058 and R4 R4: 2.6.4 mobile integration and release-readiness candidate #7045 remain unchanged, no merge, publication, TestFlight/Play submission or signing without owner approval.
- Explicitly disclose any parts not yet working; do not call setup complete on configuration-only changes.
Requested as a workflow improvement for R5, separate from R5's estimated 13k–18k changed code/test token feature budget.
Metadata
Metadata
Assignees
Labels
No labels
Activity