Repository navigation
[backport core/1.57] DESK2-183 fix(auth): tell Desktop users to finish sign-in in the browser, not that it was blocked (#21715) - #21794
Conversation
…ser, not that it was blocked (#21715) Inside Comfy Desktop, every Firebase sign-in showed "Your browser blocked the sign-in window. Please allow pop-ups for this site and try again." even though sign-in finished fine. Inside Desktop that code now shows the existing "Finish signing in in your browser" info toast. - Fixes DESK2-183 ([report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792693061887549)) The warning is wrong in Desktop. The browser didn't block anything: Desktop opened the system browser on purpose. Users go looking for a pop-up setting that isn't the problem. - Desktop's `setWindowOpenHandler` intercepts the Firebase `__/auth/handler` popup in every comfy view (local and Cloud) and finishes sign-in in the system browser. `window.open` returns null, so Firebase rejects with `auth/popup-blocked` on every Desktop sign-in. - Desktop hid that toast by matching its text (`COMFY_CLOUD_PATCHES_JS` in Comfy-Desktop `src/main/host/attach.ts`, Comfy-Desktop#853): `auth/popup-blocked` or "signing you in". - #14944 gave `auth/popup-blocked` its own copy ("Your browser blocked the sign-in window…"). That no longer matches, so the toast shows. The matcher only runs on Cloud views and only matches English text. In local views and other locales it never hid anything. - In `useAuthActions.reportError`, when `window.__comfyDesktop2` is present and the code is `auth/popup-blocked`, show `auth.desktopHost.continueInBrowser` as an info toast. That is the same toast and copy the Desktop-hosted SSO sign-in already uses. - `auth/popup-closed-by-user` and `auth/cancelled-popup-request` still warn. Those come from the user, not from Desktop. - No new strings. No change outside Desktop. - Desktop can drop the text matcher once this ships. That cleanup is a Desktop change and is not in this PR. - `pnpm test:unit src/composables/auth/useAuthActions.test.ts`: 59 passed. - The new Desktop case fails on `main` and passes with the fix. Checked by running it against the unfixed file. - No overlap with open billing/top-up PRs (#21694, #21708, #21536, Desktop SSO PRs (#20383, #20484) are merged and use separate code (`desktopHost/*`, `SignInContent`). AS IS (main, `window.__comfyDesktop2` set, real Chromium popup block): <img width="900" alt="as-is" src="https://github.com/user-attachments/assets/e1b13f0f-fceb-449f-abae-3c17d03b09ea" /> TO BE (this branch, same setup): <img width="900" alt="to-be" src="https://github.com/user-attachments/assets/618dbc87-b746-4d75-81ce-2498d0a34bf9" />
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T11:29:11.311Z",
"gitSha": "741e0d27d890ccf52faa6c93ce6941d0c7ed4201",
"branch": "backport-21715-to-core-1-57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.8860000000327,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1730000000000005,
"layouts": 9,
"layoutDurationMs": 3.133,
"taskDurationMs": 547.524,
"heapDeltaBytes": 22106140,
"heapUsedBytes": 87946772,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.754999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.3390000000782,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1530000000000005,
"layouts": 10,
"layoutDurationMs": 2.9990000000000006,
"taskDurationMs": 578.5519999999999,
"heapDeltaBytes": -877456,
"heapUsedBytes": 74534036,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.367,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.736999999981,
"styleRecalcs": 84,
"styleRecalcDurationMs": 17.867,
"layouts": 9,
"layoutDurationMs": 3.059,
"taskDurationMs": 986.7929999999999,
"heapDeltaBytes": 15614220,
"heapUsedBytes": 81431572,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 183.29000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1827.0200000000614,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.585999999999995,
"layouts": 9,
"layoutDurationMs": 2.755,
"taskDurationMs": 904.663,
"heapDeltaBytes": 15164160,
"heapUsedBytes": 81680052,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 170.80200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.1619999999643,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.14,
"layouts": 11,
"layoutDurationMs": 3.182,
"taskDurationMs": 322.18399999999997,
"heapDeltaBytes": 18789432,
"heapUsedBytes": 84620740,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.21,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6279999999624,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.940999999999999,
"layouts": 11,
"layoutDurationMs": 3.814,
"taskDurationMs": 451.19699999999995,
"heapDeltaBytes": -4151012,
"heapUsedBytes": 70903068,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 14.772999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 706.2689999999634,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2830000000000004,
"layouts": 10,
"layoutDurationMs": 3.3369999999999997,
"taskDurationMs": 504.489,
"heapDeltaBytes": 1991904,
"heapUsedBytes": 76963256,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 168.03199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.2489999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.815,
"layouts": 8,
"layoutDurationMs": 2.768,
"taskDurationMs": 524.636,
"heapDeltaBytes": 2416900,
"heapUsedBytes": 77532864,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 175.61200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.07317073170733,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1247.0459999999548,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.3789999999999,
"heapDeltaBytes": -11769352,
"heapUsedBytes": 80921940,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 69.68,
"eventListeners": -106,
"totalBlockingTimeMs": 564,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1233.9269999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.769,
"heapDeltaBytes": 913008,
"heapUsedBytes": 81077984,
"domNodes": -192,
"jsHeapTotalBytes": 12591104,
"scriptDurationMs": 69.89399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 552,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.6940000000241,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.1200000000002,
"heapDeltaBytes": -4399320,
"heapUsedBytes": 75157544,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.11300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.2510000000957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.4759999999994,
"heapDeltaBytes": -4328680,
"heapUsedBytes": 76468696,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.11299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11325.58499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10362.227,
"heapDeltaBytes": -25765740,
"heapUsedBytes": 72974888,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8417.312,
"eventListeners": -68,
"totalBlockingTimeMs": 1379,
"frameDurationMs": 32.057223796033995,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10321.782999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9467.91,
"heapDeltaBytes": 2707180,
"heapUsedBytes": 96760580,
"domNodes": -258,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 7656.424999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 908,
"frameDurationMs": 31.072891566265056,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10853.206999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10017.002,
"heapDeltaBytes": 6632908,
"heapUsedBytes": 94082348,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 8188.5560000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 1018,
"frameDurationMs": 31.539244186046513,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10422.586000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9581.009,
"heapDeltaBytes": -10103060,
"heapUsedBytes": 83809252,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 7768.026,
"eventListeners": -68,
"totalBlockingTimeMs": 990,
"frameDurationMs": 31.186227544910178,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 241.2270000000376,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.21,
"layouts": 10,
"layoutDurationMs": 3.2000000000000006,
"taskDurationMs": 188.86700000000005,
"heapDeltaBytes": -8149412,
"heapUsedBytes": 79039620,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.732999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 225.21900000003825,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.854,
"layouts": 10,
"layoutDurationMs": 3.284,
"taskDurationMs": 172.49800000000002,
"heapDeltaBytes": 13059484,
"heapUsedBytes": 90261064,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.190999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2054.7540000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.902,
"layouts": 8,
"layoutDurationMs": 2.953,
"taskDurationMs": 698.4190000000001,
"heapDeltaBytes": -19843148,
"heapUsedBytes": 77329088,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 35.09499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.4300000000676,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.391,
"layouts": 8,
"layoutDurationMs": 2.6409999999999996,
"taskDurationMs": 733.8760000000001,
"heapDeltaBytes": -18142120,
"heapUsedBytes": 78964316,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 37.62500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2579.8560000000066,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.803,
"layouts": 7,
"layoutDurationMs": 2.1539999999999995,
"taskDurationMs": 1762.1159999999998,
"heapDeltaBytes": -19973724,
"heapUsedBytes": 77935164,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 861.185,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88552631578947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2755.423999999948,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.2829999999999995,
"layouts": 5,
"layoutDurationMs": 1.4809999999999997,
"taskDurationMs": 1804.8310000000001,
"heapDeltaBytes": -12125048,
"heapUsedBytes": 68178068,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 854.442,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.869938650306743,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3861.1339999999927,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.945,
"layouts": 63,
"layoutDurationMs": 11.045000000000002,
"taskDurationMs": 1847.8780000000002,
"heapDeltaBytes": 3212568,
"heapUsedBytes": 84817692,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 804.692,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665948275862064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3926.0060000000294,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.095,
"layouts": 64,
"layoutDurationMs": 11.262,
"taskDurationMs": 1897.4410000000003,
"heapDeltaBytes": 8931424,
"heapUsedBytes": 90567928,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 830.4430000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3093.310000000031,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.087,
"layouts": 4,
"layoutDurationMs": 1.4050000000000005,
"taskDurationMs": 1868.6820000000002,
"heapDeltaBytes": 16622696,
"heapUsedBytes": 99984856,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1020.432,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.939344262295084,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3180.2040000000034,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.989999999999999,
"layouts": 4,
"layoutDurationMs": 1.6230000000000002,
"taskDurationMs": 2090.2139999999995,
"heapDeltaBytes": -6382332,
"heapUsedBytes": 72057084,
"domNodes": 0,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 1042.5120000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.203225806451613,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.7969999999682,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6000000000000005,
"layouts": 8,
"layoutDurationMs": 2.354,
"taskDurationMs": 508.93399999999997,
"heapDeltaBytes": -3002568,
"heapUsedBytes": 78038092,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 34.406,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2073.3920000000126,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2709999999999995,
"layouts": 7,
"layoutDurationMs": 2.309,
"taskDurationMs": 689.8219999999999,
"heapDeltaBytes": -21282328,
"heapUsedBytes": 77585796,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 37.296,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 698.8420000000133,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.414000000000001,
"layouts": 9,
"layoutDurationMs": 2.9379999999999997,
"taskDurationMs": 494.934,
"heapDeltaBytes": -1111680,
"heapUsedBytes": 76332416,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 155.432,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.4220000000823,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.159000000000001,
"layouts": 9,
"layoutDurationMs": 2.3469999999999995,
"taskDurationMs": 446.80299999999994,
"heapDeltaBytes": -1102900,
"heapUsedBytes": 76461520,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 148.73600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.0729999999676,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.343999999999999,
"layouts": 9,
"layoutDurationMs": 3.1510000000000002,
"taskDurationMs": 589.048,
"heapDeltaBytes": -248492,
"heapUsedBytes": 76779208,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.358,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.6790000000683,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.680000000000001,
"layouts": 10,
"layoutDurationMs": 3.651,
"taskDurationMs": 570.174,
"heapDeltaBytes": -265132,
"heapUsedBytes": 77636248,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.928999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.222999999995,
"styleRecalcs": 87,
"styleRecalcDurationMs": 19.989,
"layouts": 9,
"layoutDurationMs": 2.731,
"taskDurationMs": 1068.748,
"heapDeltaBytes": -11401924,
"heapUsedBytes": 65511660,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.72999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.48600000006,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.480000000000004,
"layouts": 9,
"layoutDurationMs": 2.581,
"taskDurationMs": 1081.316,
"heapDeltaBytes": -11378652,
"heapUsedBytes": 66000108,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 118.84999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.6900000000614,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.688999999999993,
"layouts": 5,
"layoutDurationMs": 16.857999999999997,
"taskDurationMs": 1145.2119999999998,
"heapDeltaBytes": 5106480,
"heapUsedBytes": 97301364,
"domNodes": 15953,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 34.099,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 20.090410958904116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8322.981000000027,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.618,
"layouts": 7,
"layoutDurationMs": 2.111,
"taskDurationMs": 5287.049,
"heapDeltaBytes": -10479248,
"heapUsedBytes": 68853648,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 2711.768,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732997987927565,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10102.187999999955,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.543,
"layouts": 7,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 6275.367,
"heapDeltaBytes": 4758516,
"heapUsedBytes": 84347492,
"domNodes": -258,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2842.969,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693388429752066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16838.053000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16026.574,
"heapDeltaBytes": -4910324,
"heapUsedBytes": 290402372,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 270.44100000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.427797202797198,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 23310.857000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22810.497,
"heapDeltaBytes": -42615560,
"heapUsedBytes": 258182164,
"domNodes": -3330,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 339.95300000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.379549393414216,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28294.610000000033,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.86499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27896.884000000002,
"heapDeltaBytes": -9921136,
"heapUsedBytes": 271710604,
"domNodes": -3330,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 939.4319999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 37,
"frameDurationMs": 52.569144981412634,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-large-graph-pan",
"durationMs": 28630.57200000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.198999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28286.191,
"heapDeltaBytes": -4200548,
"heapUsedBytes": 277170248,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 943.2449999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 53.61835205992509,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8666.738000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.24099999999997,
"layouts": 20,
"layoutDurationMs": 25.419999999999998,
"taskDurationMs": 8522.895,
"heapDeltaBytes": -15532120,
"heapUsedBytes": 260798736,
"domNodes": -3330,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 132.992,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.2409090909091,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8580.372999999894,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.95400000000002,
"layouts": 20,
"layoutDurationMs": 25.27499999999999,
"taskDurationMs": 8466.499,
"heapDeltaBytes": -36472692,
"heapUsedBytes": 259518308,
"domNodes": -3330,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 177.63199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.76704545454545,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11572.291000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11396.239999999998,
"heapDeltaBytes": -253688,
"heapUsedBytes": 272140440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.04000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.45591397849463,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8326.283000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7885.370999999999,
"heapDeltaBytes": -140352,
"heapUsedBytes": 264239852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.853,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.095608108108106,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 156.8849999999884,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.196999999999997,
"layouts": 9,
"layoutDurationMs": 4.208,
"taskDurationMs": 123.92200000000001,
"heapDeltaBytes": -15407964,
"heapUsedBytes": 67768284,
"domNodes": 120,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.408000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 137.58199999995213,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.749,
"layouts": 9,
"layoutDurationMs": 6.423,
"taskDurationMs": 97.57199999999999,
"heapDeltaBytes": -15525692,
"heapUsedBytes": 68147208,
"domNodes": 117,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.418999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 499.52399999995123,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0959999999999999,
"layouts": 76,
"layoutDurationMs": 15.642,
"taskDurationMs": 452.2,
"heapDeltaBytes": 11566324,
"heapUsedBytes": 83075068,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 220.34300000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 631.1080000000402,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.363,
"layouts": 76,
"layoutDurationMs": 19.792,
"taskDurationMs": 579.8480000000001,
"heapDeltaBytes": -12525728,
"heapUsedBytes": 83468944,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 273.856,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 583.3579999999756,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.862,
"layouts": 76,
"layoutDurationMs": 14.665,
"taskDurationMs": 543.759,
"heapDeltaBytes": 472124,
"heapUsedBytes": 119111892,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 225.819,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 643.5340000000451,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.455,
"layouts": 76,
"layoutDurationMs": 16.639,
"taskDurationMs": 598.1730000000001,
"heapDeltaBytes": 1076888,
"heapUsedBytes": 123712564,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 248.037,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2282 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b40292d0f2efd573af147c7b5af19ba6fdd3206e
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21794 +/- ##
=============================================
- Coverage 84.12% 84.12% -0.01%
=============================================
Files 2840 2840
Lines 158035 158042 +7
Branches 40605 40609 +4
=============================================
+ Hits 132942 132947 +5
- Misses 24704 24706 +2
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this backport is mechanically faithful to its merged source. The full exact-head check set is settled, the review thread set is empty, and no package manifest or export map changes.
Full context for agent readers
I compared the sorted additions and deletions with the merged source and inspected the resulting release-line diff. The behavior and verification remain intact.
Backport of #21715 to core/1.57.
Why
Same fix as #21715, needed on this release branch.
Root cause / How
See #21715. Cherry-picked from its merge commit.
AS IS / TO BE
See #21715.
Conflicts
computedimport and the addedafterEachimport.