Repository navigation
[backport core/1.58] DESK2-183 fix(auth): tell Desktop users to finish sign-in in the browser, not that it was blocked - #21762
Conversation
…ser, not that it was blocked (#21715) ## Summary Inside Comfy Desktop, every Firebase sign-in showed "Your browser blocked the sign-in window. Please allow pop-ups for this site and try again." even though sign-in finished fine. Inside Desktop that code now shows the existing "Finish signing in in your browser" info toast. - Fixes DESK2-183 ([report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792693061887549)) ## Why The warning is wrong in Desktop. The browser didn't block anything: Desktop opened the system browser on purpose. Users go looking for a pop-up setting that isn't the problem. ## Root cause - Desktop's `setWindowOpenHandler` intercepts the Firebase `__/auth/handler` popup in every comfy view (local and Cloud) and finishes sign-in in the system browser. `window.open` returns null, so Firebase rejects with `auth/popup-blocked` on every Desktop sign-in. - Desktop hid that toast by matching its text (`COMFY_CLOUD_PATCHES_JS` in Comfy-Desktop `src/main/host/attach.ts`, Comfy-Desktop#853): `auth/popup-blocked` or "signing you in". - #14944 gave `auth/popup-blocked` its own copy ("Your browser blocked the sign-in window…"). That no longer matches, so the toast shows. The matcher only runs on Cloud views and only matches English text. In local views and other locales it never hid anything. ## How - In `useAuthActions.reportError`, when `window.__comfyDesktop2` is present and the code is `auth/popup-blocked`, show `auth.desktopHost.continueInBrowser` as an info toast. That is the same toast and copy the Desktop-hosted SSO sign-in already uses. - `auth/popup-closed-by-user` and `auth/cancelled-popup-request` still warn. Those come from the user, not from Desktop. - No new strings. No change outside Desktop. - Desktop can drop the text matcher once this ships. That cleanup is a Desktop change and is not in this PR. ## Verification - `pnpm test:unit src/composables/auth/useAuthActions.test.ts`: 59 passed. - The new Desktop case fails on `main` and passes with the fix. Checked by running it against the unfixed file. - No overlap with open billing/top-up PRs (#21694, #21708, #21536, #21366). They share only `main.json`, which this PR doesn't touch. The Desktop SSO PRs (#20383, #20484) are merged and use separate code (`desktopHost/*`, `SignInContent`). ## AS IS / TO BE AS IS (main, `window.__comfyDesktop2` set, real Chromium popup block): <img width="900" alt="as-is" src="https://github.com/user-attachments/assets/e1b13f0f-fceb-449f-abae-3c17d03b09ea" /> TO BE (this branch, same setup): <img width="900" alt="to-be" src="https://github.com/user-attachments/assets/618dbc87-b746-4d75-81ce-2498d0a34bf9" />
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T01:07:58.494Z",
"gitSha": "a7660153960104f114a59771a93ccab3c56cc19f",
"branch": "backport-21715-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.2340000000304,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9040000000000004,
"layouts": 9,
"layoutDurationMs": 1.8980000000000001,
"taskDurationMs": 473.704,
"heapDeltaBytes": -6244168,
"heapUsedBytes": 82106876,
"domNodes": -200,
"jsHeapTotalBytes": -2961408,
"scriptDurationMs": 9.452000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.3759999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8380000000000003,
"layouts": 10,
"layoutDurationMs": 1.9560000000000002,
"taskDurationMs": 482.8310000000001,
"heapDeltaBytes": -15926100,
"heapUsedBytes": 91365768,
"domNodes": -200,
"jsHeapTotalBytes": 6266880,
"scriptDurationMs": 9.066999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.956000000001,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.338999999999999,
"layouts": 10,
"layoutDurationMs": 1.813,
"taskDurationMs": 727.6610000000001,
"heapDeltaBytes": 3097968,
"heapUsedBytes": 90641452,
"domNodes": -180,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 112.838,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.484999999925,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.303,
"layouts": 9,
"layoutDurationMs": 1.5749999999999997,
"taskDurationMs": 617.251,
"heapDeltaBytes": -3834532,
"heapUsedBytes": 94837876,
"domNodes": -180,
"jsHeapTotalBytes": 7512064,
"scriptDurationMs": 107.276,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.6649999999645,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.7330000000000005,
"layouts": 12,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 339.529,
"heapDeltaBytes": 2006988,
"heapUsedBytes": 109061628,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.869,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8589999999003,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.052,
"layouts": 13,
"layoutDurationMs": 2.659,
"taskDurationMs": 258.19199999999995,
"heapDeltaBytes": 1826764,
"heapUsedBytes": 105165460,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.142999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 596.3639999999941,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.396,
"layouts": 10,
"layoutDurationMs": 2.0170000000000003,
"taskDurationMs": 431.053,
"heapDeltaBytes": 6875628,
"heapUsedBytes": 110577332,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 135.90099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 599.252999999976,
"styleRecalcs": 13,
"styleRecalcDurationMs": 1.783,
"layouts": 9,
"layoutDurationMs": 1.605,
"taskDurationMs": 416.674,
"heapDeltaBytes": 7300680,
"heapUsedBytes": 111657188,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 131.18,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1072.0580000000268,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.835,
"heapDeltaBytes": -14877448,
"heapUsedBytes": 102252184,
"domNodes": -230,
"jsHeapTotalBytes": 17481728,
"scriptDurationMs": 46.12400000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 403,
"frameDurationMs": 29.63055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1054.8900000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.0780000000001,
"heapDeltaBytes": -8606696,
"heapUsedBytes": 101942780,
"domNodes": -210,
"jsHeapTotalBytes": 10928128,
"scriptDurationMs": 45.13700000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 402,
"frameDurationMs": 29.997142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 746.7749999999569,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.393,
"heapDeltaBytes": 23367016,
"heapUsedBytes": 124061232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.937,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 22.055882352941193,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 729.2760000000271,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.78600000000006,
"heapDeltaBytes": -4239048,
"heapUsedBytes": 97490724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.23899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 118,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7514.561000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6741.6539999999995,
"heapDeltaBytes": 20763704,
"heapUsedBytes": 131347300,
"domNodes": -276,
"jsHeapTotalBytes": 18063360,
"scriptDurationMs": 4997.039999999999,
"eventListeners": -126,
"totalBlockingTimeMs": 114,
"frameDurationMs": 24.724999999999998,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6559.8549999999705,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6979999999999998,
"layouts": 3,
"layoutDurationMs": 0.6480000000000001,
"taskDurationMs": 5860.632,
"heapDeltaBytes": -4792380,
"heapUsedBytes": 117147812,
"domNodes": -276,
"jsHeapTotalBytes": 19308544,
"scriptDurationMs": 4529.847,
"eventListeners": -130,
"totalBlockingTimeMs": 79,
"frameDurationMs": 24.96768060836502,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6692.4490000000105,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3630000000000005,
"layouts": 2,
"layoutDurationMs": 0.36399999999999977,
"taskDurationMs": 5972.259,
"heapDeltaBytes": -6105788,
"heapUsedBytes": 115571264,
"domNodes": -276,
"jsHeapTotalBytes": 19308544,
"scriptDurationMs": 4650.475,
"eventListeners": -130,
"totalBlockingTimeMs": 135,
"frameDurationMs": 25.314393939393938,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6504.413999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6810000000000002,
"layouts": 3,
"layoutDurationMs": 0.6610000000000001,
"taskDurationMs": 5831.085,
"heapDeltaBytes": -3372780,
"heapUsedBytes": 118811528,
"domNodes": -276,
"jsHeapTotalBytes": 22192128,
"scriptDurationMs": 4527.956,
"eventListeners": -130,
"totalBlockingTimeMs": 124,
"frameDurationMs": 25.48901960784314,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 165.0009999999611,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.565,
"layouts": 12,
"layoutDurationMs": 2.9330000000000003,
"taskDurationMs": 117.42,
"heapDeltaBytes": 13267052,
"heapUsedBytes": 117703020,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.964999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 176.4939999999342,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.361999999999997,
"layouts": 11,
"layoutDurationMs": 2.64,
"taskDurationMs": 133.52800000000005,
"heapDeltaBytes": 13301036,
"heapUsedBytes": 117890192,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.132999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2025.4770000000235,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9959999999999996,
"layouts": 9,
"layoutDurationMs": 2.007,
"taskDurationMs": 423.18500000000006,
"heapDeltaBytes": 5868800,
"heapUsedBytes": 108288872,
"domNodes": -276,
"jsHeapTotalBytes": -6119424,
"scriptDurationMs": 30.456999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.087999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.576,
"layouts": 8,
"layoutDurationMs": 1.628,
"taskDurationMs": 411.659,
"heapDeltaBytes": -118424,
"heapUsedBytes": 102642960,
"domNodes": -296,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 28.447,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2163.6139999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.101999999999999,
"layouts": 7,
"layoutDurationMs": 1.3439999999999999,
"taskDurationMs": 1358.693,
"heapDeltaBytes": -328,
"heapUsedBytes": 104106756,
"domNodes": -296,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 623.5350000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.62500000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.906999999999999,
"layouts": 6,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 1385.8389999999997,
"heapDeltaBytes": 913500,
"heapUsedBytes": 104098704,
"domNodes": -277,
"jsHeapTotalBytes": 397312,
"scriptDurationMs": 620.059,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3237.8309999999715,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.298000000000002,
"layouts": 65,
"layoutDurationMs": 11.135,
"taskDurationMs": 1298.239,
"heapDeltaBytes": 6848820,
"heapUsedBytes": 111946828,
"domNodes": 24,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 620.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752849740932643,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3277.0570000000134,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.376,
"layouts": 67,
"layoutDurationMs": 11.474,
"taskDurationMs": 1490.2029999999997,
"heapDeltaBytes": -9013124,
"heapUsedBytes": 95757756,
"domNodes": -272,
"jsHeapTotalBytes": -745472,
"scriptDurationMs": 610.479,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75128205128205,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2189.7519999999986,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.933,
"layouts": 5,
"layoutDurationMs": 1.1219999999999999,
"taskDurationMs": 1528.9109999999998,
"heapDeltaBytes": 4279376,
"heapUsedBytes": 107333428,
"domNodes": 0,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 698.5649999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.924031007751935,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2209.247000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.604999999999999,
"layouts": 5,
"layoutDurationMs": 1.138,
"taskDurationMs": 1490.2290000000003,
"heapDeltaBytes": 15735424,
"heapUsedBytes": 122057700,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 691.378,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92230769230769,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.588000000028,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7279999999999995,
"layouts": 8,
"layoutDurationMs": 1.714,
"taskDurationMs": 414.54400000000004,
"heapDeltaBytes": 4480188,
"heapUsedBytes": 107604416,
"domNodes": -296,
"jsHeapTotalBytes": -4808704,
"scriptDurationMs": 30.592999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.974000000062,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9789999999999999,
"layouts": 8,
"layoutDurationMs": 1.86,
"taskDurationMs": 541.353,
"heapDeltaBytes": -23774788,
"heapUsedBytes": 96977240,
"domNodes": -276,
"jsHeapTotalBytes": -1036288,
"scriptDurationMs": 29.410999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.3670000000261,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.050000000000001,
"layouts": 9,
"layoutDurationMs": 1.772,
"taskDurationMs": 309.48699999999997,
"heapDeltaBytes": 5597592,
"heapUsedBytes": 106706180,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 110.38600000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.4030000000075,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.9590000000000005,
"layouts": 10,
"layoutDurationMs": 2.052,
"taskDurationMs": 345.085,
"heapDeltaBytes": 622888,
"heapUsedBytes": 93544172,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 110.02999999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.7170000000137,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.975,
"layouts": 9,
"layoutDurationMs": 1.932,
"taskDurationMs": 479.256,
"heapDeltaBytes": -17386704,
"heapUsedBytes": 88988428,
"domNodes": -224,
"jsHeapTotalBytes": 2793472,
"scriptDurationMs": 8.233000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.1220000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0559999999999996,
"layouts": 10,
"layoutDurationMs": 1.9,
"taskDurationMs": 319.003,
"heapDeltaBytes": 4531668,
"heapUsedBytes": 106264584,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.905,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.1310000000135,
"styleRecalcs": 85,
"styleRecalcDurationMs": 12.145999999999999,
"layouts": 10,
"layoutDurationMs": 2.055,
"taskDurationMs": 835.709,
"heapDeltaBytes": -16982436,
"heapUsedBytes": 89211828,
"domNodes": -210,
"jsHeapTotalBytes": 3317760,
"scriptDurationMs": 80.871,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.9879999999393,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.694999999999999,
"layouts": 10,
"layoutDurationMs": 2.082,
"taskDurationMs": 724.984,
"heapDeltaBytes": -13365560,
"heapUsedBytes": 92465608,
"domNodes": -190,
"jsHeapTotalBytes": 3317760,
"scriptDurationMs": 83.10699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.1490000000167,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.430000000000003,
"layouts": 5,
"layoutDurationMs": 11.031,
"taskDurationMs": 828.1779999999999,
"heapDeltaBytes": 35660068,
"heapUsedBytes": 135385784,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 27.769999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 119,
"frameDurationMs": 18.949315068493153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8228.582999999959,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.450000000000006,
"layouts": 7,
"layoutDurationMs": 1.4899999999999998,
"taskDurationMs": 4885.6230000000005,
"heapDeltaBytes": -14459476,
"heapUsedBytes": 88940068,
"domNodes": -296,
"jsHeapTotalBytes": -1073152,
"scriptDurationMs": 2124.4480000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699797160243406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8216.545999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.017,
"layouts": 8,
"layoutDurationMs": 1.435,
"taskDurationMs": 4764.603,
"heapDeltaBytes": 1871312,
"heapUsedBytes": 103601476,
"domNodes": -276,
"jsHeapTotalBytes": -1175552,
"scriptDurationMs": 2100.414,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979674796748,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16662.972999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16018.456999999999,
"heapDeltaBytes": -33738068,
"heapUsedBytes": 274729664,
"domNodes": -3344,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 228.33100000000002,
"eventListeners": -656,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.705862068965512,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16752.602000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16120.842,
"heapDeltaBytes": 10850432,
"heapUsedBytes": 316179784,
"domNodes": -3344,
"jsHeapTotalBytes": 30134272,
"scriptDurationMs": 275.12399999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.093425605536332,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19900.427000000036,
"styleRecalcs": 157,
"styleRecalcDurationMs": 17.237000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19534.075999999997,
"heapDeltaBytes": 745060,
"heapUsedBytes": 305500412,
"domNodes": -3344,
"jsHeapTotalBytes": 11976704,
"scriptDurationMs": 754.429,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.11470054446461,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 19828.09599999996,
"styleRecalcs": 154,
"styleRecalcDurationMs": 17.947999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19499.069999999996,
"heapDeltaBytes": -2738780,
"heapUsedBytes": 302881968,
"domNodes": -3344,
"jsHeapTotalBytes": 6209536,
"scriptDurationMs": 755.9480000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 35.9286231884058,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6191.453000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.544000000000004,
"layouts": 20,
"layoutDurationMs": 21.548,
"taskDurationMs": 6070.14,
"heapDeltaBytes": -30620508,
"heapUsedBytes": 293445068,
"domNodes": -3344,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 95.75399999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 6,
"frameDurationMs": 34.161325966850825,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4648.808999999915,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.385,
"layouts": 20,
"layoutDurationMs": 27.653999999999996,
"taskDurationMs": 4452.7789999999995,
"heapDeltaBytes": -39562208,
"heapUsedBytes": 276180584,
"domNodes": -3344,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 80.897,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.122471910112356,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8248.340000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7900.674999999997,
"heapDeltaBytes": 19022288,
"heapUsedBytes": 294824344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.207,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.060204081632655,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8321.44500000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8052.782,
"heapDeltaBytes": -20592500,
"heapUsedBytes": 283125428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.97000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.095608108108106,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 90.40199999998322,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.074000000000001,
"layouts": 6,
"layoutDurationMs": 2.088,
"taskDurationMs": 64.076,
"heapDeltaBytes": 4806840,
"heapUsedBytes": 106336200,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.444,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 93.05000000006203,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.1419999999999995,
"layouts": 6,
"layoutDurationMs": 2.2399999999999998,
"taskDurationMs": 69.625,
"heapDeltaBytes": 4682672,
"heapUsedBytes": 101420276,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.947,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 291.0430000000588,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6679999999999999,
"layouts": 76,
"layoutDurationMs": 11.904,
"taskDurationMs": 249.964,
"heapDeltaBytes": -19129624,
"heapUsedBytes": 69044160,
"domNodes": 4,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 109.186,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666643,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 298.4759999999369,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.642,
"layouts": 76,
"layoutDurationMs": 11.707,
"taskDurationMs": 252.10900000000004,
"heapDeltaBytes": -18563580,
"heapUsedBytes": 68561840,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 111.703,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666643,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 357.3679999999513,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.517,
"layouts": 76,
"layoutDurationMs": 11.787,
"taskDurationMs": 311.592,
"heapDeltaBytes": -907968,
"heapUsedBytes": 115707912,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 115.15299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 330.77800000000934,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4729999999999999,
"layouts": 76,
"layoutDurationMs": 11.433,
"taskDurationMs": 296.203,
"heapDeltaBytes": -1137456,
"heapUsedBytes": 115505516,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 108.668,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2951 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9e5bf1583b82cb0a05da5d10356969ab7a7740c1
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21762 +/- ##
=============================================
- Coverage 86.17% 84.76% -1.42%
=============================================
Files 2786 2901 +115
Lines 154654 159238 +4584
Branches 41350 39215 -2135
=============================================
+ Hits 133273 134972 +1699
- Misses 20989 23874 +2885
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 272 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches the original PR exactly; CI green.
Backport of #21715 to
core/1.58Automatically created by backport workflow.