Repository navigation
[backport cloud/1.57] DESK2-183 fix(auth): tell Desktop users to finish sign-in in the browser, not that it was blocked (#21715) - #21795
Conversation
…ser, not that it was blocked (#21715) Inside Comfy Desktop, every Firebase sign-in showed "Your browser blocked the sign-in window. Please allow pop-ups for this site and try again." even though sign-in finished fine. Inside Desktop that code now shows the existing "Finish signing in in your browser" info toast. - Fixes DESK2-183 ([report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792693061887549)) The warning is wrong in Desktop. The browser didn't block anything: Desktop opened the system browser on purpose. Users go looking for a pop-up setting that isn't the problem. - Desktop's `setWindowOpenHandler` intercepts the Firebase `__/auth/handler` popup in every comfy view (local and Cloud) and finishes sign-in in the system browser. `window.open` returns null, so Firebase rejects with `auth/popup-blocked` on every Desktop sign-in. - Desktop hid that toast by matching its text (`COMFY_CLOUD_PATCHES_JS` in Comfy-Desktop `src/main/host/attach.ts`, Comfy-Desktop#853): `auth/popup-blocked` or "signing you in". - #14944 gave `auth/popup-blocked` its own copy ("Your browser blocked the sign-in window…"). That no longer matches, so the toast shows. The matcher only runs on Cloud views and only matches English text. In local views and other locales it never hid anything. - In `useAuthActions.reportError`, when `window.__comfyDesktop2` is present and the code is `auth/popup-blocked`, show `auth.desktopHost.continueInBrowser` as an info toast. That is the same toast and copy the Desktop-hosted SSO sign-in already uses. - `auth/popup-closed-by-user` and `auth/cancelled-popup-request` still warn. Those come from the user, not from Desktop. - No new strings. No change outside Desktop. - Desktop can drop the text matcher once this ships. That cleanup is a Desktop change and is not in this PR. - `pnpm test:unit src/composables/auth/useAuthActions.test.ts`: 59 passed. - The new Desktop case fails on `main` and passes with the fix. Checked by running it against the unfixed file. - No overlap with open billing/top-up PRs (#21694, #21708, #21536, Desktop SSO PRs (#20383, #20484) are merged and use separate code (`desktopHost/*`, `SignInContent`). AS IS (main, `window.__comfyDesktop2` set, real Chromium popup block): <img width="900" alt="as-is" src="https://github.com/user-attachments/assets/e1b13f0f-fceb-449f-abae-3c17d03b09ea" /> TO BE (this branch, same setup): <img width="900" alt="to-be" src="https://github.com/user-attachments/assets/618dbc87-b746-4d75-81ce-2498d0a34bf9" />
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T11:25:37.802Z",
"gitSha": "7ade6a38d8d796e3721153c9a19b762bf92d7b9b",
"branch": "backport-21715-to-cloud-1-57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.4239999999672,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0019999999999993,
"layouts": 10,
"layoutDurationMs": 2.74,
"taskDurationMs": 353.351,
"heapDeltaBytes": -894628,
"heapUsedBytes": 74549900,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.271999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2006.799000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.633,
"layouts": 9,
"layoutDurationMs": 2.4540000000000006,
"taskDurationMs": 308.427,
"heapDeltaBytes": 21693928,
"heapUsedBytes": 87954268,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.044999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6470000000122,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.386999999999999,
"layouts": 9,
"layoutDurationMs": 2.003,
"taskDurationMs": 535.926,
"heapDeltaBytes": -3214740,
"heapUsedBytes": 71077268,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 102.34800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664356435643562,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.4940000000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.546,
"layouts": 10,
"layoutDurationMs": 2.5399999999999996,
"taskDurationMs": 563.0690000000001,
"heapDeltaBytes": -8207204,
"heapUsedBytes": 66838300,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 106.414,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3889999999874,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.068,
"layouts": 11,
"layoutDurationMs": 2.8129999999999997,
"taskDurationMs": 268.12800000000004,
"heapDeltaBytes": 18692948,
"heapUsedBytes": 84903712,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.751000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.1070000000173,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.442000000000001,
"layouts": 11,
"layoutDurationMs": 2.821,
"taskDurationMs": 291.06200000000007,
"heapDeltaBytes": 18708956,
"heapUsedBytes": 84578716,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.923,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 532.3429999999689,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.882999999999999,
"layouts": 9,
"layoutDurationMs": 2.4399999999999995,
"taskDurationMs": 347.236,
"heapDeltaBytes": 25692588,
"heapUsedBytes": 91420680,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 116.303,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 494.5099999999911,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5100000000000002,
"layouts": 9,
"layoutDurationMs": 2.186,
"taskDurationMs": 305.41499999999996,
"heapDeltaBytes": 25102788,
"heapUsedBytes": 91564372,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 106.402,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 920.9690000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.384,
"heapDeltaBytes": -13556952,
"heapUsedBytes": 80773848,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 38.547999999999995,
"eventListeners": -105,
"totalBlockingTimeMs": 272,
"frameDurationMs": 26.191428571428577,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 891.6740000000232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.037,
"heapDeltaBytes": 1275680,
"heapUsedBytes": 81174448,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 33.31100000000001,
"eventListeners": -105,
"totalBlockingTimeMs": 267,
"frameDurationMs": 25.711428571428574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.2410000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.8620000000002,
"heapDeltaBytes": -4807828,
"heapUsedBytes": 76303844,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 94.18799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.3790000000454,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.70700000000016,
"heapDeltaBytes": -4310640,
"heapUsedBytes": 76568168,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.87899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6406.735000000026,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8619999999999999,
"layouts": 3,
"layoutDurationMs": 0.7540000000000003,
"taskDurationMs": 5289.648,
"heapDeltaBytes": -16105636,
"heapUsedBytes": 83374100,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 4095.8430000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 51,
"frameDurationMs": 19.682208588957053,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6665.531999999985,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8349999999999999,
"layouts": 3,
"layoutDurationMs": 0.7260000000000001,
"taskDurationMs": 5415.151,
"heapDeltaBytes": -16996388,
"heapUsedBytes": 77328808,
"domNodes": -258,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 4265.077,
"eventListeners": -68,
"totalBlockingTimeMs": 17,
"frameDurationMs": 20.575,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6651.136000000008,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0439999999999998,
"layouts": 4,
"layoutDurationMs": 0.9520000000000002,
"taskDurationMs": 5403.461,
"heapDeltaBytes": -32485348,
"heapUsedBytes": 66893904,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 4152.112,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 20.1,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6481.269999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7539999999999994,
"layouts": 3,
"layoutDurationMs": 0.6940000000000002,
"taskDurationMs": 5249.139999999999,
"heapDeltaBytes": -7455076,
"heapUsedBytes": 86491204,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 4102.321999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 15,
"frameDurationMs": 20.14423676012461,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 217.9010000000403,
"styleRecalcs": 25,
"styleRecalcDurationMs": 17.803,
"layouts": 14,
"layoutDurationMs": 5.110999999999999,
"taskDurationMs": 154.706,
"heapDeltaBytes": -8098520,
"heapUsedBytes": 79044696,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.9399999999999995,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 145.32700000000887,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.878,
"layouts": 13,
"layoutDurationMs": 2.9619999999999997,
"taskDurationMs": 106.51,
"heapDeltaBytes": -9377012,
"heapUsedBytes": 79116856,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5.992,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2009.5059999999876,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.750000000000001,
"layouts": 9,
"layoutDurationMs": 2.2860000000000005,
"taskDurationMs": 423.61199999999997,
"heapDeltaBytes": -2541016,
"heapUsedBytes": 76370248,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 29.938000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2028.2780000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.215,
"layouts": 9,
"layoutDurationMs": 1.9120000000000001,
"taskDurationMs": 444.119,
"heapDeltaBytes": -13091780,
"heapUsedBytes": 85183348,
"domNodes": -258,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 33.197,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2418.465000000026,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.213999999999999,
"layouts": 9,
"layoutDurationMs": 2.413,
"taskDurationMs": 1209.951,
"heapDeltaBytes": -11586160,
"heapUsedBytes": 67831992,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 570.033,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666206896551728,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2227.249000000029,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.6499999999999995,
"layouts": 8,
"layoutDurationMs": 1.984,
"taskDurationMs": 1149.9669999999999,
"heapDeltaBytes": -11864044,
"heapUsedBytes": 68763448,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 550.356,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3638.039000000049,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.463000000000001,
"layouts": 67,
"layoutDurationMs": 12.69,
"taskDurationMs": 1239.2479999999998,
"heapDeltaBytes": 5205492,
"heapUsedBytes": 86748632,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 542.0840000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3317.0659999999543,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.256,
"layouts": 66,
"layoutDurationMs": 11.705,
"taskDurationMs": 1207.737,
"heapDeltaBytes": -14832136,
"heapUsedBytes": 83901852,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 532.1890000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633165829146,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2356.420000000014,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.116,
"layouts": 8,
"layoutDurationMs": 2.097,
"taskDurationMs": 1264.0479999999998,
"heapDeltaBytes": 279928,
"heapUsedBytes": 83885780,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 660.287,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665248226950357,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2190.298999999982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.796999999999999,
"layouts": 7,
"layoutDurationMs": 1.7289999999999996,
"taskDurationMs": 1211.759,
"heapDeltaBytes": 159464,
"heapUsedBytes": 81670668,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 614.474,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151514,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3339999999675,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.986999999999999,
"layouts": 10,
"layoutDurationMs": 2.674,
"taskDurationMs": 417.462,
"heapDeltaBytes": -2180192,
"heapUsedBytes": 79588424,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 26.957999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.8870000001061,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1140000000000003,
"layouts": 9,
"layoutDurationMs": 2.306,
"taskDurationMs": 350.83899999999994,
"heapDeltaBytes": -1951472,
"heapUsedBytes": 79380596,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.283,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 433.33999999998696,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.124,
"layouts": 10,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 290.806,
"heapDeltaBytes": -1126724,
"heapUsedBytes": 75845160,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 96.593,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.88799999994444,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.755999999999999,
"layouts": 9,
"layoutDurationMs": 2.48,
"taskDurationMs": 298.42999999999995,
"heapDeltaBytes": 19807608,
"heapUsedBytes": 86823508,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 100.61899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.2219999999656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.092000000000001,
"layouts": 10,
"layoutDurationMs": 2.7399999999999998,
"taskDurationMs": 350.02700000000004,
"heapDeltaBytes": 22341352,
"heapUsedBytes": 89699400,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.171,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.4660000000276,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.211999999999999,
"layouts": 9,
"layoutDurationMs": 3.7489999999999997,
"taskDurationMs": 323.09299999999996,
"heapDeltaBytes": -640044,
"heapUsedBytes": 76433232,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.1,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.5069999999914,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.451999999999998,
"layouts": 9,
"layoutDurationMs": 2.2009999999999996,
"taskDurationMs": 595.1999999999999,
"heapDeltaBytes": 11713144,
"heapUsedBytes": 78532488,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 93.626,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.8040000000374,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.103000000000002,
"layouts": 9,
"layoutDurationMs": 2.0650000000000004,
"taskDurationMs": 522.385,
"heapDeltaBytes": 11667240,
"heapUsedBytes": 78746496,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 82.17099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 887.9190000000108,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.104000000000003,
"layouts": 5,
"layoutDurationMs": 9.385000000000002,
"taskDurationMs": 657.468,
"heapDeltaBytes": 9513780,
"heapUsedBytes": 109059788,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 19.823,
"eventListeners": 3244,
"totalBlockingTimeMs": 67,
"frameDurationMs": 18.74791666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8554.138999999963,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.814999999999998,
"layouts": 9,
"layoutDurationMs": 2.322,
"taskDurationMs": 4122.37,
"heapDeltaBytes": -646872,
"heapUsedBytes": 78894268,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1905.187,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665953307393,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8270.748000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.012999999999998,
"layouts": 9,
"layoutDurationMs": 2.0090000000000003,
"taskDurationMs": 3699.5789999999997,
"heapDeltaBytes": 647876,
"heapUsedBytes": 79424168,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1788.866,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665995975855132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16899.748999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15976.15,
"heapDeltaBytes": 6647688,
"heapUsedBytes": 288632488,
"domNodes": -3330,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 223.836,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.06529209621993,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16617.690999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15687.657,
"heapDeltaBytes": 2652920,
"heapUsedBytes": 284614560,
"domNodes": -3330,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 252.141,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.40358974358974,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18493.85799999999,
"styleRecalcs": 145,
"styleRecalcDurationMs": 13.968000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18098.429,
"heapDeltaBytes": -33677176,
"heapUsedBytes": 266960888,
"domNodes": -3330,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 641.8100000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 34.29035250463822,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18724.950000000033,
"styleRecalcs": 161,
"styleRecalcDurationMs": 14.656999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18353.057,
"heapDeltaBytes": -17051272,
"heapUsedBytes": 265012752,
"domNodes": -3330,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 634.425,
"eventListeners": -651,
"totalBlockingTimeMs": 8,
"frameDurationMs": 34.05909090909091,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5453.318999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.167,
"layouts": 20,
"layoutDurationMs": 18.773999999999997,
"taskDurationMs": 5354.730999999999,
"heapDeltaBytes": -7075408,
"heapUsedBytes": 274685120,
"domNodes": -3330,
"jsHeapTotalBytes": 36429824,
"scriptDurationMs": 72.012,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.230909090909094,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 6092.640999999958,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.397,
"layouts": 20,
"layoutDurationMs": 23.89100000000001,
"taskDurationMs": 5963.549000000001,
"heapDeltaBytes": 6577648,
"heapUsedBytes": 288689652,
"domNodes": -3330,
"jsHeapTotalBytes": 30400512,
"scriptDurationMs": 92.54300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.70055248618784,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7143.78400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6581.668000000001,
"heapDeltaBytes": -27510164,
"heapUsedBytes": 250455368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.74399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.991946308724838,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8079.746,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7462.076999999999,
"heapDeltaBytes": -1879060,
"heapUsedBytes": 259756380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.72600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.493197278911566,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 90.93300000000681,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.773999999999999,
"layouts": 5,
"layoutDurationMs": 1.784,
"taskDurationMs": 53.919000000000004,
"heapDeltaBytes": 4611460,
"heapUsedBytes": 77189004,
"domNodes": 118,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.167000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 440.76400000005833,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.341999999999999,
"layouts": 12,
"layoutDurationMs": 3.1,
"taskDurationMs": 84.334,
"heapDeltaBytes": 6580564,
"heapUsedBytes": 79267744,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.075000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 220.66099999995004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.903,
"layouts": 76,
"layoutDurationMs": 10.895999999999999,
"taskDurationMs": 173.451,
"heapDeltaBytes": 8951520,
"heapUsedBytes": 86699852,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 75.054,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 195.84499999996297,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8809999999999999,
"layouts": 76,
"layoutDurationMs": 9.859,
"taskDurationMs": 161.861,
"heapDeltaBytes": 8806064,
"heapUsedBytes": 94380252,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 70.07,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 288.90499999999975,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.712,
"layouts": 76,
"layoutDurationMs": 11.162,
"taskDurationMs": 243.801,
"heapDeltaBytes": -1590140,
"heapUsedBytes": 124086284,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.798,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 308.29799999992247,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.282,
"layouts": 76,
"layoutDurationMs": 13.592,
"taskDurationMs": 264.96000000000004,
"heapDeltaBytes": -6647376,
"heapUsedBytes": 108151412,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.97999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7a623d99da6fb17fc540943bd9a87eeeecd0db0d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21795 +/- ##
=============================================
Coverage ? 84.18%
=============================================
Files ? 2856
Lines ? 158907
Branches ? 40681
=============================================
Hits ? 133769
Misses ? 24749
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: this backport is mechanically faithful to its merged source. The full exact-head check set is settled, the review thread set is empty, and no package manifest or export map changes.
Full context for agent readers
I compared the sorted additions and deletions with the merged source and inspected the resulting release-line diff. The behavior and verification remain intact.
Backport of #21715 to cloud/1.57.
Why
Same fix as #21715, needed on this release branch.
Root cause / How
See #21715. Cherry-picked from its merge commit.
AS IS / TO BE
See #21715.
Conflicts
computedimport and the addedafterEachimport.