Repository navigation
[backport cloud/1.58] DESK2-183 fix(auth): tell Desktop users to finish sign-in in the browser, not that it was blocked - #21763
Conversation
…ser, not that it was blocked (#21715) ## Summary Inside Comfy Desktop, every Firebase sign-in showed "Your browser blocked the sign-in window. Please allow pop-ups for this site and try again." even though sign-in finished fine. Inside Desktop that code now shows the existing "Finish signing in in your browser" info toast. - Fixes DESK2-183 ([report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1792693061887549)) ## Why The warning is wrong in Desktop. The browser didn't block anything: Desktop opened the system browser on purpose. Users go looking for a pop-up setting that isn't the problem. ## Root cause - Desktop's `setWindowOpenHandler` intercepts the Firebase `__/auth/handler` popup in every comfy view (local and Cloud) and finishes sign-in in the system browser. `window.open` returns null, so Firebase rejects with `auth/popup-blocked` on every Desktop sign-in. - Desktop hid that toast by matching its text (`COMFY_CLOUD_PATCHES_JS` in Comfy-Desktop `src/main/host/attach.ts`, Comfy-Desktop#853): `auth/popup-blocked` or "signing you in". - #14944 gave `auth/popup-blocked` its own copy ("Your browser blocked the sign-in window…"). That no longer matches, so the toast shows. The matcher only runs on Cloud views and only matches English text. In local views and other locales it never hid anything. ## How - In `useAuthActions.reportError`, when `window.__comfyDesktop2` is present and the code is `auth/popup-blocked`, show `auth.desktopHost.continueInBrowser` as an info toast. That is the same toast and copy the Desktop-hosted SSO sign-in already uses. - `auth/popup-closed-by-user` and `auth/cancelled-popup-request` still warn. Those come from the user, not from Desktop. - No new strings. No change outside Desktop. - Desktop can drop the text matcher once this ships. That cleanup is a Desktop change and is not in this PR. ## Verification - `pnpm test:unit src/composables/auth/useAuthActions.test.ts`: 59 passed. - The new Desktop case fails on `main` and passes with the fix. Checked by running it against the unfixed file. - No overlap with open billing/top-up PRs (#21694, #21708, #21536, #21366). They share only `main.json`, which this PR doesn't touch. The Desktop SSO PRs (#20383, #20484) are merged and use separate code (`desktopHost/*`, `SignInContent`). ## AS IS / TO BE AS IS (main, `window.__comfyDesktop2` set, real Chromium popup block): <img width="900" alt="as-is" src="https://github.com/user-attachments/assets/e1b13f0f-fceb-449f-abae-3c17d03b09ea" /> TO BE (this branch, same setup): <img width="900" alt="to-be" src="https://github.com/user-attachments/assets/618dbc87-b746-4d75-81ce-2498d0a34bf9" />
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-23T01:08:23.133Z",
"gitSha": "ac8acc124601269343b7e2c5e0d09af5bf176546",
"branch": "backport-21715-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.8819999999673,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2549999999999994,
"layouts": 9,
"layoutDurationMs": 2.092,
"taskDurationMs": 345.526,
"heapDeltaBytes": -11492948,
"heapUsedBytes": 80188828,
"domNodes": -180,
"jsHeapTotalBytes": 2596864,
"scriptDurationMs": 7.8580000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.5849999999919,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3609999999999998,
"layouts": 10,
"layoutDurationMs": 2.125,
"taskDurationMs": 342.827,
"heapDeltaBytes": -11558144,
"heapUsedBytes": 92678584,
"domNodes": -200,
"jsHeapTotalBytes": 2531328,
"scriptDurationMs": 8.137000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1716.1989999999605,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.134,
"layouts": 9,
"layoutDurationMs": 2.152,
"taskDurationMs": 717.84,
"heapDeltaBytes": 22641748,
"heapUsedBytes": 113982908,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 117.417,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1993.235000000027,
"styleRecalcs": 82,
"styleRecalcDurationMs": 12.115,
"layouts": 10,
"layoutDurationMs": 2.087,
"taskDurationMs": 951.2810000000001,
"heapDeltaBytes": -15219492,
"heapUsedBytes": 89040508,
"domNodes": -200,
"jsHeapTotalBytes": 3842048,
"scriptDurationMs": 121.242,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.6489999999853,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.285,
"layouts": 12,
"layoutDurationMs": 2.547,
"taskDurationMs": 241.45999999999998,
"heapDeltaBytes": 4417748,
"heapUsedBytes": 103405344,
"domNodes": 47,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 9.611,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66442307692307,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.7680000000537,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.199000000000001,
"layouts": 12,
"layoutDurationMs": 2.499,
"taskDurationMs": 234.787,
"heapDeltaBytes": -1279900,
"heapUsedBytes": 90341052,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.556999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.8159999999925,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9930000000000003,
"layouts": 10,
"layoutDurationMs": 2.4540000000000006,
"taskDurationMs": 356.649,
"heapDeltaBytes": 6856104,
"heapUsedBytes": 110642348,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 132.789,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 616.6350000000307,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.684,
"layouts": 10,
"layoutDurationMs": 2.21,
"taskDurationMs": 452.171,
"heapDeltaBytes": 5671988,
"heapUsedBytes": 112482412,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 133.406,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.730000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.699,
"heapDeltaBytes": -17361184,
"heapUsedBytes": 102958312,
"domNodes": -211,
"jsHeapTotalBytes": 15187968,
"scriptDurationMs": 47.929,
"eventListeners": -168,
"totalBlockingTimeMs": 366,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1042.283999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.1719999999999,
"heapDeltaBytes": -8909788,
"heapUsedBytes": 102540188,
"domNodes": -230,
"jsHeapTotalBytes": 9093120,
"scriptDurationMs": 53.57500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 389,
"frameDurationMs": 29.163888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.1790000000183,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.633,
"heapDeltaBytes": -2537920,
"heapUsedBytes": 97515468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.59000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 152,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.6090000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.316,
"heapDeltaBytes": -3963548,
"heapUsedBytes": 97064684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.855,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7829.21300000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7749999999999997,
"layouts": 3,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 7037.13,
"heapDeltaBytes": 22448744,
"heapUsedBytes": 144146832,
"domNodes": -276,
"jsHeapTotalBytes": 33726464,
"scriptDurationMs": 5687.722,
"eventListeners": -130,
"totalBlockingTimeMs": 114,
"frameDurationMs": 25.186495176848876,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7564.095000000008,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4669999999999995,
"layouts": 2,
"layoutDurationMs": 0.441,
"taskDurationMs": 6758.657999999999,
"heapDeltaBytes": 31072164,
"heapUsedBytes": 141922400,
"domNodes": -277,
"jsHeapTotalBytes": 18325504,
"scriptDurationMs": 5239.245000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 89,
"frameDurationMs": 24.275562700964628,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7168.522999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.804,
"layouts": 3,
"layoutDurationMs": 0.6759999999999999,
"taskDurationMs": 6415.279999999999,
"heapDeltaBytes": 417080,
"heapUsedBytes": 121823832,
"domNodes": -276,
"jsHeapTotalBytes": 25862144,
"scriptDurationMs": 4912.635,
"eventListeners": -130,
"totalBlockingTimeMs": 136,
"frameDurationMs": 24.711724137931036,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7232.951000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8060000000000003,
"layouts": 3,
"layoutDurationMs": 0.6410000000000001,
"taskDurationMs": 6409.447,
"heapDeltaBytes": 3473952,
"heapUsedBytes": 125183968,
"domNodes": -276,
"jsHeapTotalBytes": 27435008,
"scriptDurationMs": 5219.422,
"eventListeners": -130,
"totalBlockingTimeMs": 92,
"frameDurationMs": 24.602040816326532,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 166.34100000001695,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.908,
"layouts": 12,
"layoutDurationMs": 2.9360000000000004,
"taskDurationMs": 118.76399999999998,
"heapDeltaBytes": 13243624,
"heapUsedBytes": 118316664,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.529999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 162.67400000003818,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.599000000000002,
"layouts": 11,
"layoutDurationMs": 2.5500000000000003,
"taskDurationMs": 124.23400000000001,
"heapDeltaBytes": 13316668,
"heapUsedBytes": 118333804,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.456999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2025.4580000000146,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9639999999999995,
"layouts": 9,
"layoutDurationMs": 2.0489999999999995,
"taskDurationMs": 519.6970000000001,
"heapDeltaBytes": -993304,
"heapUsedBytes": 101269500,
"domNodes": -296,
"jsHeapTotalBytes": -2449408,
"scriptDurationMs": 28.188000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.4749999999854,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.122,
"layouts": 9,
"layoutDurationMs": 2.124,
"taskDurationMs": 393.993,
"heapDeltaBytes": -16864728,
"heapUsedBytes": 95283984,
"domNodes": -296,
"jsHeapTotalBytes": -2908160,
"scriptDurationMs": 27.165000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2155.0450000000296,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.177,
"layouts": 9,
"layoutDurationMs": 2.124,
"taskDurationMs": 1198.299,
"heapDeltaBytes": -4311556,
"heapUsedBytes": 109255940,
"domNodes": -296,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 639.605,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2200.0340000000165,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.628000000000002,
"layouts": 8,
"layoutDurationMs": 1.954,
"taskDurationMs": 1227.6480000000001,
"heapDeltaBytes": 621220,
"heapUsedBytes": 104152604,
"domNodes": -296,
"jsHeapTotalBytes": -913408,
"scriptDurationMs": 644.419,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793846153846157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3265.179000000046,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.464,
"layouts": 65,
"layoutDurationMs": 9.982,
"taskDurationMs": 1457.1419999999998,
"heapDeltaBytes": -8616080,
"heapUsedBytes": 95808760,
"domNodes": -252,
"jsHeapTotalBytes": -745472,
"scriptDurationMs": 629.848,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581632653061,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3198.474000000033,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.36,
"layouts": 65,
"layoutDurationMs": 9.927,
"taskDurationMs": 1293.3249999999998,
"heapDeltaBytes": -13811360,
"heapUsedBytes": 91091256,
"domNodes": -272,
"jsHeapTotalBytes": -483328,
"scriptDurationMs": 618.7360000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361254,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2280.259000000001,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.701,
"layouts": 7,
"layoutDurationMs": 1.6960000000000002,
"taskDurationMs": 1581.199,
"heapDeltaBytes": 6040896,
"heapUsedBytes": 109001076,
"domNodes": 0,
"jsHeapTotalBytes": 3149824,
"scriptDurationMs": 760.9710000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78962962962963,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2534.848000000011,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.337999999999999,
"layouts": 6,
"layoutDurationMs": 1.282,
"taskDurationMs": 1617.833,
"heapDeltaBytes": -12068972,
"heapUsedBytes": 103802356,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 781.2869999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.888666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.0300000000293,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.152,
"layouts": 9,
"layoutDurationMs": 1.946,
"taskDurationMs": 397.18499999999995,
"heapDeltaBytes": 9668272,
"heapUsedBytes": 112347684,
"domNodes": -276,
"jsHeapTotalBytes": -5332992,
"scriptDurationMs": 27.730000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.6909999999525,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7999999999999996,
"layouts": 8,
"layoutDurationMs": 1.703,
"taskDurationMs": 522.205,
"heapDeltaBytes": -19188264,
"heapUsedBytes": 95254296,
"domNodes": -296,
"jsHeapTotalBytes": -2121728,
"scriptDurationMs": 29.464000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.9180000000429,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.566,
"layouts": 9,
"layoutDurationMs": 2.1529999999999996,
"taskDurationMs": 348.468,
"heapDeltaBytes": 22535344,
"heapUsedBytes": 114996992,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 118.217,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.1820000000253,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.037,
"layouts": 10,
"layoutDurationMs": 2.352,
"taskDurationMs": 360.462,
"heapDeltaBytes": 2696268,
"heapUsedBytes": 108957756,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 119.689,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.450999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0380000000000007,
"layouts": 9,
"layoutDurationMs": 1.739,
"taskDurationMs": 290.25800000000004,
"heapDeltaBytes": 4914320,
"heapUsedBytes": 97687852,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.6800000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.8710000000283,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.448,
"layouts": 10,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 473.958,
"heapDeltaBytes": -13508196,
"heapUsedBytes": 92712704,
"domNodes": -218,
"jsHeapTotalBytes": 2531328,
"scriptDurationMs": 8.056,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.9169999999754,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.917,
"layouts": 11,
"layoutDurationMs": 2.5780000000000003,
"taskDurationMs": 591.9749999999999,
"heapDeltaBytes": -15904872,
"heapUsedBytes": 90306056,
"domNodes": -210,
"jsHeapTotalBytes": 3055616,
"scriptDurationMs": 86.49399999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.6400000000176,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.294,
"layouts": 10,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 596.341,
"heapDeltaBytes": -10866680,
"heapUsedBytes": 94975316,
"domNodes": -190,
"jsHeapTotalBytes": 3317760,
"scriptDurationMs": 85.854,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1319.2640000000324,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.188000000000002,
"layouts": 5,
"layoutDurationMs": 11.717000000000002,
"taskDurationMs": 828.481,
"heapDeltaBytes": 38016240,
"heapUsedBytes": 137032288,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 23.8,
"eventListeners": 3244,
"totalBlockingTimeMs": 100,
"frameDurationMs": 19.04714285714286,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8577.634999999987,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.025,
"layouts": 7,
"layoutDurationMs": 1.7400000000000002,
"taskDurationMs": 4666.969999999999,
"heapDeltaBytes": 2251608,
"heapUsedBytes": 104368548,
"domNodes": -296,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 2117.1,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698443579766536,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.138999999894,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.903,
"layouts": 8,
"layoutDurationMs": 1.655,
"taskDurationMs": 4125.389999999999,
"heapDeltaBytes": 2568072,
"heapUsedBytes": 103478320,
"domNodes": -296,
"jsHeapTotalBytes": -1175552,
"scriptDurationMs": 2126.6470000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18741.68000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18320.098,
"heapDeltaBytes": -33642164,
"heapUsedBytes": 272485244,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 288.817,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.7493006993007,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 19153.69700000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18709.054,
"heapDeltaBytes": 5430404,
"heapUsedBytes": 306575156,
"domNodes": -3344,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 248.28399999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.4777972027972,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 16804.997000000014,
"styleRecalcs": 115,
"styleRecalcDurationMs": 12.862000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16341.273000000001,
"heapDeltaBytes": -14665264,
"heapUsedBytes": 286552520,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 678.49,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.71188299817185,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 16844.732999999906,
"styleRecalcs": 110,
"styleRecalcDurationMs": 12.858999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16460.778000000002,
"heapDeltaBytes": 5910752,
"heapUsedBytes": 317095308,
"domNodes": -3344,
"jsHeapTotalBytes": 24821760,
"scriptDurationMs": 714.8919999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 21,
"frameDurationMs": 31.643527204502814,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 6946.537000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.342000000000006,
"layouts": 20,
"layoutDurationMs": 25.697,
"taskDurationMs": 6844.759999999999,
"heapDeltaBytes": -21617936,
"heapUsedBytes": 298412184,
"domNodes": -3344,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 130.25199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.29772727272727,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6937.741999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.31600000000002,
"layouts": 20,
"layoutDurationMs": 27.517,
"taskDurationMs": 6837.188999999999,
"heapDeltaBytes": -50217208,
"heapUsedBytes": 279029088,
"domNodes": -3344,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 117.62699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 40.543859649122815,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7000.875000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6620.905000000001,
"heapDeltaBytes": -8624120,
"heapUsedBytes": 295521928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.52800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.20902527075813,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9838.115000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9385.761,
"heapDeltaBytes": 266452,
"heapUsedBytes": 294127020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.05099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.445578231292515,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 470.34999999999627,
"styleRecalcs": 19,
"styleRecalcDurationMs": 8.841999999999999,
"layouts": 11,
"layoutDurationMs": 3.5899999999999994,
"taskDurationMs": 124.334,
"heapDeltaBytes": -8434900,
"heapUsedBytes": 88393340,
"domNodes": 124,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 10.874000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.281481481481478,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 99.33599999999387,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.824999999999999,
"layouts": 7,
"layoutDurationMs": 2.505,
"taskDurationMs": 74.926,
"heapDeltaBytes": 4679172,
"heapUsedBytes": 101320704,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.286999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 274.6240000000171,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.612,
"layouts": 76,
"layoutDurationMs": 11.284,
"taskDurationMs": 230.193,
"heapDeltaBytes": 10078164,
"heapUsedBytes": 98172608,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 108.041,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999983,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 286.6679999999633,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.602,
"layouts": 76,
"layoutDurationMs": 11.421000000000001,
"taskDurationMs": 238.26699999999997,
"heapDeltaBytes": 10230656,
"heapUsedBytes": 95983632,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 111.18499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67058823529415,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 307.9699999999548,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4289999999999998,
"layouts": 76,
"layoutDurationMs": 10.657,
"taskDurationMs": 273.87,
"heapDeltaBytes": -1550724,
"heapUsedBytes": 118501360,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.982,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263162,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 319.0789999999879,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.591,
"layouts": 76,
"layoutDurationMs": 10.928,
"taskDurationMs": 283.32,
"heapDeltaBytes": -6139856,
"heapUsedBytes": 104199028,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.367,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2950 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4c4e9dff99448a2f989f4e9c5a1927fe7ec74b47
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (118)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21763 +/- ##
=============================================
Coverage ? 84.77%
=============================================
Files ? 2904
Lines ? 159456
Branches ? 41402
=============================================
Hits ? 135180
Misses ? 23887
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches the original PR exactly; CI green.
Backport of #21715 to
cloud/1.58Automatically created by backport workflow.