Repository navigation
[backport cloud/1.57] fix(agent): recheck funds after an admitted send before showing the out-of-credits card (#21538) - #21590
Conversation
…ut-of-credits card (#21538) ## Summary A new account's first prompt showed the standing "Out of credits" card for the whole turn, although the turn ran normally. The panel had read billing before the send, and pre-turn admission granted the free Agent credits inside that send, so the stale no-funds read stayed on screen until the turn finished. Stopping or finishing the turn cleared it. Now, when the last read says no funds, the panel holds the standing card from the send until a billing read taken after admission settles. A send that is refused keeps its inline card, and funded users make no extra request. Reported by Windows Local Agent QA in `#comfy-agent-user-feedback` on 2026-10-21. The card is shared frontend code, so Cloud has the same race whenever a grant is minted at admission. This finishes the work of [PM-2066](https://linear.app/comfyorg/issue/PM-2066), whose #21241 kept the card hidden only until the first message. <details><summary>Full context for agent readers</summary> - The standing card reads `subscription.agentHasFunds`, which is `scoped_effective_has_funds.agent` from `GET /api/billing/status`. Before this change, billing was refreshed only when a turn finished (`AgentPanelRoot.vue`, the idle branch of the `[status, conversationTurnId]` watch). - Cloud ingest mints the monthly or Local Agent gratis grant in `agentGratisEnsureBeforeAdmission` before `/v1/decide`, and it writes the funds snapshot synchronously. So a 2xx on the turn POST means a status read made after admission shows the grant. - Ingest's `billing_status` websocket push is not consumed by the frontend, and its payload has no Agent funds field, so it cannot correct this read. - The existing empty-thread spec still passes: when a post-admission read still says exhausted, the card shows. </details> ## Verification - New black-box case in `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`: billing is exhausted at load, and the turn POST flips the fixture to funded. On the parent commit it fails with `Expected: 0, Received: 1` (the card is visible during the admitted turn). With this change it passes, after waiting for the billing read that follows admission. - `playwright test` over `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle`, `agentPanel` and `agentFreeUsePlacement` (`--project=cloud`): 19 passed. - `vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`: 465 passed. - Commit hooks passed: oxfmt, stylelint, oxlint, eslint, server-facts, `typecheck:app`, `typecheck:browser`. - Not run: a packaged Desktop build with a brand-new account. ## Linear Fixes [PM-2239](https://linear.app/comfyorg/issue/PM-2239/out-of-credits-banner-shows-on-a-new-account-even-though-free-credits). (cherry picked from commit 340d406) Release adaptation (core/1.57 and cloud/1.57): the three new AgentPanelRoot unit cases use this branch's thread-list URL match and import the promise form of setImmediate. Product code is the unchanged cherry-pick.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T20:38:03.241Z",
"gitSha": "44fca584e66acf2eb32781a7f21af81afe16c48e",
"branch": "backport-21538-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6329999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7520000000000002,
"layouts": 9,
"layoutDurationMs": 2.782,
"taskDurationMs": 352.632,
"heapDeltaBytes": 22152396,
"heapUsedBytes": 87932964,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.526,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.395000000074,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0959999999999996,
"layouts": 9,
"layoutDurationMs": 2.955,
"taskDurationMs": 533.701,
"heapDeltaBytes": 22078888,
"heapUsedBytes": 88317220,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.429999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2006.561999999974,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.979000000000001,
"layouts": 9,
"layoutDurationMs": 3.1069999999999998,
"taskDurationMs": 1062.375,
"heapDeltaBytes": -7836964,
"heapUsedBytes": 66674840,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 167.77900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1974.2240000000493,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.970000000000002,
"layouts": 10,
"layoutDurationMs": 2.9319999999999995,
"taskDurationMs": 1062.005,
"heapDeltaBytes": 15621712,
"heapUsedBytes": 81532496,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 166.22,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.1190000000352,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.251,
"layouts": 11,
"layoutDurationMs": 2.953,
"taskDurationMs": 375.09999999999997,
"heapDeltaBytes": 18717144,
"heapUsedBytes": 84179480,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.489999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1822.5640000000567,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.087,
"layouts": 12,
"layoutDurationMs": 3.314,
"taskDurationMs": 469.448,
"heapDeltaBytes": -4494088,
"heapUsedBytes": 70564536,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.108,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 624.2409999999836,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1209999999999996,
"layouts": 10,
"layoutDurationMs": 2.892,
"taskDurationMs": 447.527,
"heapDeltaBytes": 26108404,
"heapUsedBytes": 91089644,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 180.552,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 681.5290000000687,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0240000000000005,
"layouts": 10,
"layoutDurationMs": 2.719,
"taskDurationMs": 511.60799999999995,
"heapDeltaBytes": 3504600,
"heapUsedBytes": 78877968,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 171.897,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.3420000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.0060000000001,
"heapDeltaBytes": -11547048,
"heapUsedBytes": 81475508,
"domNodes": -212,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 69.468,
"eventListeners": -106,
"totalBlockingTimeMs": 527,
"frameDurationMs": 32.883783783783805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1227.5409999999738,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.6419999999999,
"heapDeltaBytes": 1281300,
"heapUsedBytes": 81384868,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 70.187,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.45526315789472,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 850.9770000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.03599999999966,
"heapDeltaBytes": -3746036,
"heapUsedBytes": 76062884,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.61700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.5560000000642,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.57799999999986,
"heapDeltaBytes": -3589908,
"heapUsedBytes": 76691828,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.07899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10948.078000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10012.856,
"heapDeltaBytes": 9878040,
"heapUsedBytes": 97182972,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 8153.686000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1167,
"frameDurationMs": 31.92274052478134,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10551.77900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9725.369999999999,
"heapDeltaBytes": -12498052,
"heapUsedBytes": 87279092,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7867.518,
"eventListeners": -68,
"totalBlockingTimeMs": 883,
"frameDurationMs": 31.304451038575667,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10627.96099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9828.230999999998,
"heapDeltaBytes": -3111544,
"heapUsedBytes": 96122912,
"domNodes": -258,
"jsHeapTotalBytes": 9302016,
"scriptDurationMs": 8048.578000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1105,
"frameDurationMs": 31.976807228915664,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9470.211000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8650.493,
"heapDeltaBytes": -3312856,
"heapUsedBytes": 96073936,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7273.225,
"eventListeners": -67,
"totalBlockingTimeMs": 827,
"frameDurationMs": 31.98074324324324,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 224.70399999997426,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.129999999999999,
"layouts": 11,
"layoutDurationMs": 3.551,
"taskDurationMs": 175.298,
"heapDeltaBytes": -8357604,
"heapUsedBytes": 79302340,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.036999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.319999999999983,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 237.2769999999491,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.911999999999999,
"layouts": 11,
"layoutDurationMs": 3.185,
"taskDurationMs": 186.36,
"heapDeltaBytes": -8165284,
"heapUsedBytes": 79752316,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.799000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2040.7220000000166,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2770000000000006,
"layouts": 8,
"layoutDurationMs": 2.4240000000000004,
"taskDurationMs": 453.9129999999999,
"heapDeltaBytes": -2429080,
"heapUsedBytes": 76575840,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.412000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.3040000000665,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.262000000000001,
"layouts": 7,
"layoutDurationMs": 2.1100000000000003,
"taskDurationMs": 476.738,
"heapDeltaBytes": -2664984,
"heapUsedBytes": 76178896,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.514,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2228.9129999999773,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.915000000000001,
"layouts": 7,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 1473.4670000000003,
"heapDeltaBytes": -9252464,
"heapUsedBytes": 70903028,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 804.8069999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66691729323308,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2699.803999999972,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.722,
"layouts": 5,
"layoutDurationMs": 1.2149999999999999,
"taskDurationMs": 1764.4920000000002,
"heapDeltaBytes": -8854544,
"heapUsedBytes": 71182664,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 848.4770000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769565217391303,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3907.7069999999594,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.993,
"layouts": 64,
"layoutDurationMs": 10.565999999999999,
"taskDurationMs": 1837.3690000000001,
"heapDeltaBytes": 8730152,
"heapUsedBytes": 90400268,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 820.6210000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6663829787234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3830.879999999979,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.87,
"layouts": 64,
"layoutDurationMs": 10.567,
"taskDurationMs": 1827.368,
"heapDeltaBytes": -18083464,
"heapUsedBytes": 81684272,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 793.6419999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73930131004367,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2916.1750000000097,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.117,
"layouts": 5,
"layoutDurationMs": 1.4150000000000005,
"taskDurationMs": 1934.9190000000003,
"heapDeltaBytes": 9190284,
"heapUsedBytes": 86606988,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 951.604,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762068965517244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2726.7779999999675,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.757000000000001,
"layouts": 4,
"layoutDurationMs": 1.382,
"taskDurationMs": 1760.882,
"heapDeltaBytes": 12347144,
"heapUsedBytes": 95412008,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 965.132,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.87329192546584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.5879999999524,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5579999999999994,
"layouts": 6,
"layoutDurationMs": 1.8539999999999996,
"taskDurationMs": 616.57,
"heapDeltaBytes": -1802200,
"heapUsedBytes": 79575556,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.896,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.1129999999148,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.132,
"layouts": 7,
"layoutDurationMs": 1.981,
"taskDurationMs": 648.142,
"heapDeltaBytes": -2106328,
"heapUsedBytes": 79340032,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 33.786,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 651.7680000000041,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.747000000000001,
"layouts": 8,
"layoutDurationMs": 2.395,
"taskDurationMs": 452.03400000000005,
"heapDeltaBytes": 21674428,
"heapUsedBytes": 88556292,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 150.53499999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.6490000000767,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.294,
"layouts": 10,
"layoutDurationMs": 2.9490000000000003,
"taskDurationMs": 458.3400000000001,
"heapDeltaBytes": -1074700,
"heapUsedBytes": 75956928,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 148.231,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.293999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.189999999999999,
"layouts": 10,
"layoutDurationMs": 3.12,
"taskDurationMs": 501.4029999999999,
"heapDeltaBytes": -258040,
"heapUsedBytes": 77069108,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.809,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.5019999999413,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.096999999999999,
"layouts": 10,
"layoutDurationMs": 3.0420000000000003,
"taskDurationMs": 536.91,
"heapDeltaBytes": 22494540,
"heapUsedBytes": 88960700,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.863000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.9010000000026,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.618000000000002,
"layouts": 9,
"layoutDurationMs": 3.0080000000000005,
"taskDurationMs": 916.1730000000001,
"heapDeltaBytes": 11641348,
"heapUsedBytes": 79077488,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 116.316,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5980000000145,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.57,
"layouts": 10,
"layoutDurationMs": 2.7470000000000003,
"taskDurationMs": 877.658,
"heapDeltaBytes": -7269168,
"heapUsedBytes": 69807632,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 115.88300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1454.4309999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.508,
"layouts": 5,
"layoutDurationMs": 16.807,
"taskDurationMs": 1137.4899999999998,
"heapDeltaBytes": 7277944,
"heapUsedBytes": 104262496,
"domNodes": 15953,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 31.762999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.82027027027028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8309.270000000026,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.249000000000002,
"layouts": 7,
"layoutDurationMs": 2.411,
"taskDurationMs": 5114.306999999999,
"heapDeltaBytes": 912696,
"heapUsedBytes": 79558244,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2682.598,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76693548387097,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8325.609999999982,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.437,
"layouts": 6,
"layoutDurationMs": 1.8169999999999995,
"taskDurationMs": 5183.518999999999,
"heapDeltaBytes": 7996764,
"heapUsedBytes": 87503220,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2712.363,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80060606060606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23097.02500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22479.724,
"heapDeltaBytes": -6463936,
"heapUsedBytes": 275764460,
"domNodes": -3330,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 345.476,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.62109777015438,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23143.443000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22466.530000000002,
"heapDeltaBytes": -28937168,
"heapUsedBytes": 252632920,
"domNodes": -3330,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 353.601,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.81480206540447,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27912.73700000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.976999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27535.999000000003,
"heapDeltaBytes": -44912716,
"heapUsedBytes": 255902004,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 953.779,
"eventListeners": -651,
"totalBlockingTimeMs": 37,
"frameDurationMs": 51.6,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28330.258999999955,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.218999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27836.683999999997,
"heapDeltaBytes": -14060264,
"heapUsedBytes": 267939408,
"domNodes": -3330,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 885.0079999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 36,
"frameDurationMs": 51.51327272727272,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8343.203000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.23100000000001,
"layouts": 20,
"layoutDurationMs": 22.201999999999998,
"taskDurationMs": 8215.998000000001,
"heapDeltaBytes": -26582580,
"heapUsedBytes": 269220936,
"domNodes": -3330,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 153.10000000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.80107526881721,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6007.828000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.54299999999999,
"layouts": 20,
"layoutDurationMs": 22.234000000000005,
"taskDurationMs": 5885.986000000001,
"heapDeltaBytes": -19699524,
"heapUsedBytes": 261564300,
"domNodes": -3330,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 94.80799999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 18,
"frameDurationMs": 36.243975903614455,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11511.056999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11272.431999999999,
"heapDeltaBytes": 805844,
"heapUsedBytes": 258489888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.86600000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.65344827586207,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11536.323000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11268.294999999998,
"heapDeltaBytes": 4728528,
"heapUsedBytes": 279633264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.47699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.96216216216216,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 142.1059999998988,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.531,
"layouts": 10,
"layoutDurationMs": 4.289,
"taskDurationMs": 123.764,
"heapDeltaBytes": -15104220,
"heapUsedBytes": 68287836,
"domNodes": 124,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 13.167000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 463.3370000000241,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.177000000000001,
"layouts": 11,
"layoutDurationMs": 3.6619999999999995,
"taskDurationMs": 112.20199999999998,
"heapDeltaBytes": -13593184,
"heapUsedBytes": 70202204,
"domNodes": 95,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.882000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.88899999991554,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.108,
"layouts": 76,
"layoutDurationMs": 14.664,
"taskDurationMs": 454.57200000000006,
"heapDeltaBytes": -21201800,
"heapUsedBytes": 71921272,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 228.33100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 495.28399999996964,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.948,
"layouts": 76,
"layoutDurationMs": 15.06,
"taskDurationMs": 453.72,
"heapDeltaBytes": 11859372,
"heapUsedBytes": 91073556,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 221.659,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 526.0880000000725,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.428,
"layouts": 76,
"layoutDurationMs": 14.267999999999999,
"taskDurationMs": 489.95,
"heapDeltaBytes": 11039192,
"heapUsedBytes": 159504120,
"domNodes": 4,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 190.57500000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.20322580645162,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 535.9649999999192,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.925,
"layouts": 76,
"layoutDurationMs": 14.312,
"taskDurationMs": 501.57399999999996,
"heapDeltaBytes": -172640,
"heapUsedBytes": 131172768,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 202.912,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a15b483bbe22f41f53282effb032c1c64e5ba8d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21590 +/- ##
=============================================
Coverage ? 85.84%
=============================================
Files ? 2715
Lines ? 152575
Branches ? 40556
=============================================
Hits ? 130974
Misses ? 21211
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 95a4c5d has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
threadListRoute does not exist on the 1.58 branches, so the backported AgentPanelRoot tests failed typecheck. Use the same endsWith check the 1.57 backport (#21590) uses.
threadListRoute does not exist on the 1.58 branches, so the backported AgentPanelRoot tests failed typecheck. Use the same endsWith check the 1.57 backport (#21590) uses.
Backport of #21538 to
cloud/1.57.A new account's first prompt no longer shows the "Out of credits" card while the turn runs on the free credits granted at admission. Cloud production serves
ba2c2c2269, which is on this branch, so Cloud gets the fix from the nextcloud/1.57patch promotion.The product code is the clean cherry-pick. Only the three new
AgentPanelRootunit cases were adapted to this branch: they match the thread list the way the rest of this file does and import the promise form ofsetImmediate.Full context for agent readers
git patch-id --stableof the unadapted cherry-pick equals the source.-xprovenance line kept. No AI co-author trailer.browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts› "keeps the card hidden when the first send is admitted on credits granted at admission",--project=cloud, local ComfyUI CI container 0.0.27 plus aDISTRIBUTION=clouddev server:cloud/1.57product files, new spec kept): fails; the page snapshot shows "Out of credits" and "Add credits" under the admitted user message.agentCreditsExhaustionEmptyThread,agentCreditsExhaustionLifecycleandagentFreeUsePlacement.agentPanel.spec.ts: 18 of 19 pass. "flag off › does not expose the Agent button" fails the same way with and without this change on the local dev server, so it is a local-environment result, not a regression; CI decides.AgentPanelRoot.test.ts,useAgentSession.test.ts,agentPanelStore.test.ts: 713 passed.typecheckandtypecheck:browserclean.cloud/1.58andcore/1.58are not in the program's release authority yet and also lack fix(agent): recheck funds after an admitted send before showing the out-of-credits card #21538.