Repository navigation
[backport core/1.57] fix(agent): recheck funds after an admitted send before showing the out-of-credits card (#21538) - #21589
Conversation
…ut-of-credits card (#21538) ## Summary A new account's first prompt showed the standing "Out of credits" card for the whole turn, although the turn ran normally. The panel had read billing before the send, and pre-turn admission granted the free Agent credits inside that send, so the stale no-funds read stayed on screen until the turn finished. Stopping or finishing the turn cleared it. Now, when the last read says no funds, the panel holds the standing card from the send until a billing read taken after admission settles. A send that is refused keeps its inline card, and funded users make no extra request. Reported by Windows Local Agent QA in `#comfy-agent-user-feedback` on 2026-10-21. The card is shared frontend code, so Cloud has the same race whenever a grant is minted at admission. This finishes the work of [PM-2066](https://linear.app/comfyorg/issue/PM-2066), whose #21241 kept the card hidden only until the first message. <details><summary>Full context for agent readers</summary> - The standing card reads `subscription.agentHasFunds`, which is `scoped_effective_has_funds.agent` from `GET /api/billing/status`. Before this change, billing was refreshed only when a turn finished (`AgentPanelRoot.vue`, the idle branch of the `[status, conversationTurnId]` watch). - Cloud ingest mints the monthly or Local Agent gratis grant in `agentGratisEnsureBeforeAdmission` before `/v1/decide`, and it writes the funds snapshot synchronously. So a 2xx on the turn POST means a status read made after admission shows the grant. - Ingest's `billing_status` websocket push is not consumed by the frontend, and its payload has no Agent funds field, so it cannot correct this read. - The existing empty-thread spec still passes: when a post-admission read still says exhausted, the card shows. </details> ## Verification - New black-box case in `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`: billing is exhausted at load, and the turn POST flips the fixture to funded. On the parent commit it fails with `Expected: 0, Received: 1` (the card is visible during the admitted turn). With this change it passes, after waiting for the billing read that follows admission. - `playwright test` over `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle`, `agentPanel` and `agentFreeUsePlacement` (`--project=cloud`): 19 passed. - `vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`: 465 passed. - Commit hooks passed: oxfmt, stylelint, oxlint, eslint, server-facts, `typecheck:app`, `typecheck:browser`. - Not run: a packaged Desktop build with a brand-new account. ## Linear Fixes [PM-2239](https://linear.app/comfyorg/issue/PM-2239/out-of-credits-banner-shows-on-a-new-account-even-though-free-credits). (cherry picked from commit 340d406) Release adaptation (core/1.57 and cloud/1.57): the three new AgentPanelRoot unit cases use this branch's thread-list URL match and import the promise form of setImmediate. Product code is the unchanged cherry-pick.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T22:33:51.967Z",
"gitSha": "ed99edb38d3db06a0092ec52af3fa15aee3c34da",
"branch": "backport-21538-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.2119999999813,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.680999999999999,
"layouts": 9,
"layoutDurationMs": 2.5910000000000006,
"taskDurationMs": 429.542,
"heapDeltaBytes": 21646268,
"heapUsedBytes": 88871648,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.264,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.8969999999904,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.299,
"layouts": 8,
"layoutDurationMs": 2.2819999999999996,
"taskDurationMs": 417.51899999999995,
"heapDeltaBytes": 22020408,
"heapUsedBytes": 88412908,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.116,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1969.2660000000046,
"styleRecalcs": 82,
"styleRecalcDurationMs": 17.769,
"layouts": 9,
"layoutDurationMs": 2.5570000000000004,
"taskDurationMs": 955.636,
"heapDeltaBytes": -6844752,
"heapUsedBytes": 68170372,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 142.41700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1959.2010000000073,
"styleRecalcs": 83,
"styleRecalcDurationMs": 17.267,
"layouts": 10,
"layoutDurationMs": 3.1030000000000006,
"taskDurationMs": 910.999,
"heapDeltaBytes": -7242028,
"heapUsedBytes": 68269176,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 131.444,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6269999999981,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.543999999999999,
"layouts": 11,
"layoutDurationMs": 2.9199999999999995,
"taskDurationMs": 341.824,
"heapDeltaBytes": 18283596,
"heapUsedBytes": 84549736,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 14.725999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1805.998000000045,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.33,
"layouts": 11,
"layoutDurationMs": 3.039,
"taskDurationMs": 329.038,
"heapDeltaBytes": 18361628,
"heapUsedBytes": 84386488,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.62,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 634.8600000000033,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.0189999999999992,
"layouts": 10,
"layoutDurationMs": 2.4779999999999998,
"taskDurationMs": 445.496,
"heapDeltaBytes": 3531288,
"heapUsedBytes": 78882604,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 144.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 625.7459999999924,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1060000000000003,
"layouts": 9,
"layoutDurationMs": 2.3419999999999996,
"taskDurationMs": 432.54800000000006,
"heapDeltaBytes": 25684480,
"heapUsedBytes": 91522592,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 141.454,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621621,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1082.8830000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.8660000000001,
"heapDeltaBytes": -10888020,
"heapUsedBytes": 81715480,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 53.76700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 396,
"frameDurationMs": 29.278378378378385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1068.3530000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.043,
"heapDeltaBytes": -11486520,
"heapUsedBytes": 81154104,
"domNodes": -192,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 45.559000000000005,
"eventListeners": -105,
"totalBlockingTimeMs": 377,
"frameDurationMs": 28.829729729729724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 744.8230000000251,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.684,
"heapDeltaBytes": -4802332,
"heapUsedBytes": 76017584,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 110.66300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 125,
"frameDurationMs": 22.055882352941165,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 730.686999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.41200000000003,
"heapDeltaBytes": -4764860,
"heapUsedBytes": 76058120,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 101.54600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8095.743000000028,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5339999999999998,
"layouts": 2,
"layoutDurationMs": 0.47599999999999987,
"taskDurationMs": 7106.22,
"heapDeltaBytes": -8274088,
"heapUsedBytes": 87607772,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 5417.965,
"eventListeners": -68,
"totalBlockingTimeMs": 102,
"frameDurationMs": 24.419939577039273,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7456.240999999977,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5300000000000001,
"layouts": 2,
"layoutDurationMs": 0.4699999999999999,
"taskDurationMs": 6535.056,
"heapDeltaBytes": -805536,
"heapUsedBytes": 76632328,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 4968.49,
"eventListeners": -68,
"totalBlockingTimeMs": 27,
"frameDurationMs": 24.030967741935484,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7809.761000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8430000000000009,
"layouts": 3,
"layoutDurationMs": 0.8079999999999997,
"taskDurationMs": 6840.269,
"heapDeltaBytes": -17103468,
"heapUsedBytes": 77664104,
"domNodes": -278,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 5212.135,
"eventListeners": -68,
"totalBlockingTimeMs": 85,
"frameDurationMs": 24.45078369905956,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7384.818999999993,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5079999999999998,
"layouts": 2,
"layoutDurationMs": 0.41399999999999987,
"taskDurationMs": 6440.539000000001,
"heapDeltaBytes": 27264904,
"heapUsedBytes": 104269828,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 4895.597000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 33,
"frameDurationMs": 23.81612903225807,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 209.37699999998927,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.246999999999996,
"layouts": 12,
"layoutDurationMs": 3.6659999999999995,
"taskDurationMs": 151.728,
"heapDeltaBytes": 13059672,
"heapUsedBytes": 92087040,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.635000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 189.2010000000255,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.027000000000001,
"layouts": 12,
"layoutDurationMs": 3.1660000000000004,
"taskDurationMs": 140.951,
"heapDeltaBytes": -8206556,
"heapUsedBytes": 79140564,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.055000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2040.3459999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2630000000000003,
"layouts": 8,
"layoutDurationMs": 1.8609999999999998,
"taskDurationMs": 523.163,
"heapDeltaBytes": -25571616,
"heapUsedBytes": 72781820,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 32.017,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.4430000000389,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.549,
"layouts": 9,
"layoutDurationMs": 2.4319999999999995,
"taskDurationMs": 559.178,
"heapDeltaBytes": -25841636,
"heapUsedBytes": 72376492,
"domNodes": -258,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 38.259,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2199.551999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.381,
"layouts": 8,
"layoutDurationMs": 2.059,
"taskDurationMs": 1455.121,
"heapDeltaBytes": -12446364,
"heapUsedBytes": 68218884,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 667.359,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2204.140999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.504000000000001,
"layouts": 8,
"layoutDurationMs": 2.152,
"taskDurationMs": 1461.799,
"heapDeltaBytes": -30594808,
"heapUsedBytes": 67810724,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 681.7800000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3447.3930000000337,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.202,
"layouts": 65,
"layoutDurationMs": 12.903999999999998,
"taskDurationMs": 1622.916,
"heapDeltaBytes": 11293916,
"heapUsedBytes": 88677728,
"domNodes": -254,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 676.061,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.747087378640774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3480.209000000059,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.998999999999997,
"layouts": 64,
"layoutDurationMs": 12.604000000000001,
"taskDurationMs": 1626.7659999999998,
"heapDeltaBytes": 11250516,
"heapUsedBytes": 88751972,
"domNodes": -234,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 685.3430000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746376811594203,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2581.22400000002,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.771,
"layouts": 6,
"layoutDurationMs": 1.708,
"taskDurationMs": 1672.77,
"heapDeltaBytes": 10149908,
"heapUsedBytes": 94025916,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 792.736,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88486842105263,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2670.4749999999535,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.054,
"layouts": 5,
"layoutDurationMs": 1.2199999999999998,
"taskDurationMs": 1713.0709999999997,
"heapDeltaBytes": 4202092,
"heapUsedBytes": 82647096,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 802.4870000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.876582278481013,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2049.601999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0480000000000005,
"layouts": 7,
"layoutDurationMs": 1.8809999999999998,
"taskDurationMs": 523.68,
"heapDeltaBytes": -1515412,
"heapUsedBytes": 80275396,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 29.791999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2052.944000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1910000000000003,
"layouts": 8,
"layoutDurationMs": 2.265,
"taskDurationMs": 395.813,
"heapDeltaBytes": -1649992,
"heapUsedBytes": 79742004,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.900999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.8919999999907,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.606,
"layouts": 10,
"layoutDurationMs": 3.1180000000000003,
"taskDurationMs": 333.479,
"heapDeltaBytes": 20266568,
"heapUsedBytes": 86770632,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 123.96600000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.1750000000147,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.851,
"layouts": 9,
"layoutDurationMs": 2.4119999999999995,
"taskDurationMs": 350.607,
"heapDeltaBytes": -1098376,
"heapUsedBytes": 76848072,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 116.67,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.0730000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.216,
"layouts": 10,
"layoutDurationMs": 2.8469999999999995,
"taskDurationMs": 449.047,
"heapDeltaBytes": -204140,
"heapUsedBytes": 76273724,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.626,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.723999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6999999999999993,
"layouts": 9,
"layoutDurationMs": 2.496,
"taskDurationMs": 449.922,
"heapDeltaBytes": -9587876,
"heapUsedBytes": 57425716,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.198000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.2809999999758,
"styleRecalcs": 86,
"styleRecalcDurationMs": 19.236,
"layouts": 9,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 932.607,
"heapDeltaBytes": 11602148,
"heapUsedBytes": 79059128,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 102.69399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.4519999999989,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.912,
"layouts": 10,
"layoutDurationMs": 2.8390000000000004,
"taskDurationMs": 929.8650000000001,
"heapDeltaBytes": 15307288,
"heapUsedBytes": 91929184,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 102.478,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1369.5529999999962,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.629,
"layouts": 5,
"layoutDurationMs": 11.886,
"taskDurationMs": 877.1090000000002,
"heapDeltaBytes": 4910372,
"heapUsedBytes": 101207592,
"domNodes": 15953,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 28.700000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.212500000000002,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8347.87,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.435999999999996,
"layouts": 7,
"layoutDurationMs": 1.7810000000000001,
"taskDurationMs": 5181.4400000000005,
"heapDeltaBytes": -1083908,
"heapUsedBytes": 78649352,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2317.3790000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73266533066132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.692000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.997,
"layouts": 8,
"layoutDurationMs": 2.005,
"taskDurationMs": 5088.89,
"heapDeltaBytes": -30520992,
"heapUsedBytes": 68552936,
"domNodes": -278,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 2297.4080000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16787.484000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16355.449,
"heapDeltaBytes": -12412836,
"heapUsedBytes": 283151936,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 289.309,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.65982905982906,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16634.041000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16127.258000000002,
"heapDeltaBytes": -10976,
"heapUsedBytes": 281745504,
"domNodes": -3330,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 247.331,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.43840707964602,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 21045.27300000001,
"styleRecalcs": 163,
"styleRecalcDurationMs": 20.44600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20726.816,
"heapDeltaBytes": -23288840,
"heapUsedBytes": 267827876,
"domNodes": -3330,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 837.495,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.10667938931298,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20355.176999999912,
"styleRecalcs": 158,
"styleRecalcDurationMs": 17.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19925.637000000002,
"heapDeltaBytes": -4575688,
"heapUsedBytes": 277038940,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 826.23,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 37.262522851919556,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6217.843999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.848,
"layouts": 20,
"layoutDurationMs": 36.67099999999999,
"taskDurationMs": 6119.473999999999,
"heapDeltaBytes": -15966844,
"heapUsedBytes": 279953348,
"domNodes": -307,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 99.522,
"eventListeners": -7,
"totalBlockingTimeMs": 17,
"frameDurationMs": 37.22335329341317,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6213.529999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.21299999999999,
"layouts": 20,
"layoutDurationMs": 26.979000000000003,
"taskDurationMs": 6057.1449999999995,
"heapDeltaBytes": -21120944,
"heapUsedBytes": 269909192,
"domNodes": -3330,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 100.203,
"eventListeners": -653,
"totalBlockingTimeMs": 12,
"frameDurationMs": 34.82977528089887,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9134.286999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8665.729000000001,
"heapDeltaBytes": 85656,
"heapUsedBytes": 270212508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.52999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.71145833333334,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8548.806999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8305.491999999998,
"heapDeltaBytes": 13215828,
"heapUsedBytes": 293120984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.693,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.98169491525423,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 134.7729999999956,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.613000000000001,
"layouts": 8,
"layoutDurationMs": 3.999,
"taskDurationMs": 97.852,
"heapDeltaBytes": 4617008,
"heapUsedBytes": 78217056,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.785000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 109.68499999989945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.340000000000002,
"layouts": 7,
"layoutDurationMs": 2.618,
"taskDurationMs": 84.396,
"heapDeltaBytes": -15697340,
"heapUsedBytes": 68483888,
"domNodes": 117,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.1000000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.466666666666697,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 354.91799999999785,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.987,
"layouts": 76,
"layoutDurationMs": 12.997,
"taskDurationMs": 314.81100000000004,
"heapDeltaBytes": -19373384,
"heapUsedBytes": 70467948,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 138.57,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 342.78100000005907,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.008,
"layouts": 76,
"layoutDurationMs": 12.217,
"taskDurationMs": 305.229,
"heapDeltaBytes": -21191068,
"heapUsedBytes": 73074564,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 133.219,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 396.78299999991395,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.159,
"layouts": 76,
"layoutDurationMs": 12.34,
"taskDurationMs": 354.565,
"heapDeltaBytes": -897140,
"heapUsedBytes": 118273768,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 127.95800000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 411.77300000003925,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.95,
"layouts": 76,
"layoutDurationMs": 12.506,
"taskDurationMs": 366.194,
"heapDeltaBytes": -5682108,
"heapUsedBytes": 106245448,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 133.744,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 07bebc7f81373ffdd7cb27540d3391716631a861
Full docs: ADR-DEVEX-LINT-0015 |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21589 +/- ##
=============================================
- Coverage 84.12% 83.84% -0.28%
=============================================
Files 2840 2841 +1
Lines 158012 158917 +905
Branches 38427 40633 +2206
=============================================
+ Hits 132922 133242 +320
- Misses 24701 25287 +586
+ Partials 389 388 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 263 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit dd12523 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #21538 to
core/1.57.A new account's first prompt no longer shows the "Out of credits" card while the turn runs on the free credits granted at admission. ComfyUI core pins
comfyui-frontend-package==1.57.1, which is this branch, so Desktop and Local Agent get the fix from the next 1.57 package.The product code is the clean cherry-pick. Only the three new
AgentPanelRootunit cases were adapted to this branch: they match the thread list the way the rest of this file does and import the promise form ofsetImmediate.Full context for agent readers
git patch-id --stableof the unadapted cherry-pick equals the source.-xprovenance line kept. No AI co-author trailer.browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts› "keeps the card hidden when the first send is admitted on credits granted at admission",--project=cloud, local ComfyUI CI container 0.0.27 plus aDISTRIBUTION=clouddev server:core/1.57product files, new spec kept): fails; the page snapshot shows "Out of credits" and "Add credits" under the admitted user message.agentCreditsExhaustionEmptyThread,agentCreditsExhaustionLifecycleandagentFreeUsePlacement.agentPanel.spec.ts: 18 of 19 pass. "flag off › does not expose the Agent button" fails the same way with and without this change on the local dev server, so it is a local-environment result, not a regression; CI decides.AgentPanelRoot.test.ts,useAgentSession.test.ts,agentPanelStore.test.ts: 713 passed.typecheckandtypecheck:browserclean.cloud/1.58andcore/1.58are not in the program's release authority yet and also lack fix(agent): recheck funds after an admitted send before showing the out-of-credits card #21538.