Repository navigation
[backport core/1.56] fix(agent): hold the out-of-credits card until the thread is activated (#21241) - #21354
Conversation
#21241) *PR Created by the Glary-Bot Agent* --- ## Summary The standing "Out of credits" card in the agent side panel now appears only after the thread is activated. It no longer shows on a fresh empty thread. **Why:** newly granted gratis credits take about 30s to show up in billing. Until then the workspace reads as exhausted, so the card was appearing on brand-new empty chats. The backend latency fix shipped separately. This is the frontend mitigation agreed in #pillar5-agent. ## Change - `AgentPanelRoot.vue`: `showStandingPaywall` also requires the transcript to hold at least one user message. Brand-new and New Chat threads stay clean; the card appears as soon as the user has sent something. - Gating on transcript content (not the thread id) keeps the card reachable when a first send fails before the server acknowledges it (network, 5xx, or a 402 whose inline card is later resolved), and keeps it hidden while a restored thread is still loading its history. - The `creditsExhausted` gating itself (billing, consent, capability, presentation) is unchanged. - A first send refused with 402 still shows the inline paywall card, so there is no dead end. - Impression telemetry (`credits_exhausted`) is only reported once the card actually shows. ## Test-driven 1. **New e2e test first:** `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`, tagged `@cloud`. It boots with billing exhausted, then checks three things: - the card is hidden on the empty thread; - it shows after the first message; - it hides again after New Chat. On `main` it failed at the empty-thread step: `expected 0, received 1`. 2. **Then the fix.** The new spec passes, and so do these neighbouring specs: - `agentCreditsExhaustionLifecycle.spec.ts` - `agentPaywallSubscribe.spec.ts` - the `agentPanel.spec.ts` case "keeps the standing paywall in sync…" 3. **Unit tests:** `AgentPanelRoot.test.ts`, 458/458 passing. - The standing-paywall cases now record a first user message, so each one still exercises its own gate. - New cases: hidden on an empty thread then shown with one impression after the first message; shown after a failed first send; shown once a refused first send's inline card resolves; hidden while a restored thread has no messages yet. ##⚠️ Revisit if proactive first turns are introduced This uses "the thread is activated by the user" as a stand-in for "the user is engaged". If we ever add **proactive first turns**, where the agent sends the first message, this gating has to be revisited. An "empty thread / no accepted user turn" check would then suppress the card when it should show (or the wrong event would activate it), and the gratis-latency issue it covers would come back. A failed first send (503, network error, refused 402) still counts as the user's first message, so the standing card shows after it when the workspace is exhausted. ## Screenshots Empty thread with billing exhausted (no card), and the same session after the first message (card shown).   --------- (cherry picked from commit 592d64c)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-19T06:26:50.022Z",
"gitSha": "cbc32f345a44251bc9333353612f2ac20dfc7e17",
"branch": "backport-21241-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.8550000000396,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.556000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.34200000000004,
"heapDeltaBytes": 1281508,
"heapUsedBytes": 68823108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.087000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2010.8149999999796,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2500000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.657,
"heapDeltaBytes": 1251456,
"heapUsedBytes": 69969876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.831000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.9359999999851,
"styleRecalcs": 52,
"styleRecalcDurationMs": 12.398,
"layouts": 12,
"layoutDurationMs": 3.549,
"taskDurationMs": 652.612,
"heapDeltaBytes": -1767720,
"heapUsedBytes": 65781244,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 119.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1751.2720000000854,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.892999999999999,
"layouts": 12,
"layoutDurationMs": 3.676,
"taskDurationMs": 656.145,
"heapDeltaBytes": -2089328,
"heapUsedBytes": 65481700,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 120.57099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.826923076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.998000000021,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.497000000000002,
"layouts": 6,
"layoutDurationMs": 1.2260000000000002,
"taskDurationMs": 305.30800000000005,
"heapDeltaBytes": 4106556,
"heapUsedBytes": 71938956,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.945999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633663366336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.709999999949,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.496000000000002,
"layouts": 6,
"layoutDurationMs": 1.3100000000000003,
"taskDurationMs": 300.88300000000004,
"heapDeltaBytes": 4170348,
"heapUsedBytes": 72307412,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.353000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 580.867000000012,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7270000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.11600000000004,
"heapDeltaBytes": -6797956,
"heapUsedBytes": 61341584,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 137.44,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 581.0270000000628,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.609,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.741,
"heapDeltaBytes": -7796576,
"heapUsedBytes": 61179812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.28600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1088.4850000000483,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.919,
"heapDeltaBytes": 15161356,
"heapUsedBytes": 84922892,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 48.28300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 466,
"frameDurationMs": 32.83030303030302,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1066.5370000000394,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.678,
"heapDeltaBytes": 15419896,
"heapUsedBytes": 85976724,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 47.81400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 452,
"frameDurationMs": 32.327272727272735,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.7529999999847,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.3090000000001,
"heapDeltaBytes": 17708148,
"heapUsedBytes": 105274156,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 117.259,
"eventListeners": 0,
"totalBlockingTimeMs": 143,
"frameDurationMs": 22.549999999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.6369999999797,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.85800000000023,
"heapDeltaBytes": -8827276,
"heapUsedBytes": 78461652,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 123.164,
"eventListeners": 0,
"totalBlockingTimeMs": 151,
"frameDurationMs": 23.03823529411768,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8589.133000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6360000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7710.4710000000005,
"heapDeltaBytes": -1268664,
"heapUsedBytes": 76394084,
"domNodes": -142,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 6207.963000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 242,
"frameDurationMs": 30.221830985915492,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6950.5759999999555,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.978999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6119.313,
"heapDeltaBytes": -17558184,
"heapUsedBytes": 68118320,
"domNodes": -173,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 5013.439,
"eventListeners": -82,
"totalBlockingTimeMs": 52,
"frameDurationMs": 27.403557312252964,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6905.978000000005,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6306.916,
"heapDeltaBytes": -12768584,
"heapUsedBytes": 72172096,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 4928.793,
"eventListeners": -78,
"totalBlockingTimeMs": 51,
"frameDurationMs": 27.37936507936508,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6728.4100000000535,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6620000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6183.217,
"heapDeltaBytes": -3933464,
"heapUsedBytes": 81393732,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 4822.134999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 37,
"frameDurationMs": 26.973493975903615,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2008.9439999999854,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3160000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.79400000000004,
"heapDeltaBytes": -7167796,
"heapUsedBytes": 78294288,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.376000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.6949999999651,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.733000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.3410000000001,
"heapDeltaBytes": -9537144,
"heapUsedBytes": 79635928,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.778,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.516999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1341.944,
"heapDeltaBytes": -16994580,
"heapUsedBytes": 69502252,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 698.3710000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664843750000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2138.415000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1290.495,
"heapDeltaBytes": 10296492,
"heapUsedBytes": 90249508,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 667.1049999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3494.216999999992,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.868,
"layouts": 60,
"layoutDurationMs": 14.818,
"taskDurationMs": 1453.3700000000001,
"heapDeltaBytes": 4581452,
"heapUsedBytes": 83288236,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 662.362,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66555023923445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3362.173999999982,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.239,
"layouts": 60,
"layoutDurationMs": 13.455000000000002,
"taskDurationMs": 1403.964,
"heapDeltaBytes": 9489524,
"heapUsedBytes": 94946372,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 644.663,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2545.514999999966,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.329999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.839,
"heapDeltaBytes": 3809612,
"heapUsedBytes": 72430364,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 811.194,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776158940397348,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2603.6129999999957,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.416000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1613.5509999999997,
"heapDeltaBytes": -14544628,
"heapUsedBytes": 68931860,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 820.094,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658064516129,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.9860000000217,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6669999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.573,
"heapDeltaBytes": -8033552,
"heapUsedBytes": 81493332,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.36,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.3829999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8970000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.19699999999995,
"heapDeltaBytes": -9254128,
"heapUsedBytes": 81264880,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 36.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.3390000000231,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.469000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.365,
"heapDeltaBytes": -12003976,
"heapUsedBytes": 57788404,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.029,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.2489999999798,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.496999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.18899999999996,
"heapDeltaBytes": -12359900,
"heapUsedBytes": 57864776,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 116.49399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.7190000000423,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5389999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.658,
"heapDeltaBytes": 1131740,
"heapUsedBytes": 71116144,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.661000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2009.8169999999982,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.634,
"heapDeltaBytes": -2642964,
"heapUsedBytes": 61620340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.513000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.4930000000136,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.185,
"layouts": 16,
"layoutDurationMs": 4.313,
"taskDurationMs": 613.1220000000001,
"heapDeltaBytes": -5627972,
"heapUsedBytes": 65199732,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 81.31200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.6360000000323,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.481000000000002,
"layouts": 16,
"layoutDurationMs": 4.508,
"taskDurationMs": 625.867,
"heapDeltaBytes": -5954200,
"heapUsedBytes": 63604832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.24100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.7449999999308,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.284,
"layouts": 5,
"layoutDurationMs": 10.786,
"taskDurationMs": 772.7530000000003,
"heapDeltaBytes": 1219436,
"heapUsedBytes": 95615772,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 22.192000000000004,
"eventListeners": 2463,
"totalBlockingTimeMs": 121,
"frameDurationMs": 20.289130434782592,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.814000000013,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4697.212,
"heapDeltaBytes": -19393164,
"heapUsedBytes": 69856756,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2244.9309999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.929999999942,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.492000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4841.534000000001,
"heapDeltaBytes": -12206532,
"heapUsedBytes": 76449316,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2389.1310000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665987780040734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13721.916000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12751.776,
"heapDeltaBytes": -34030232,
"heapUsedBytes": 178984260,
"domNodes": -3045,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 212.19699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.784219269102987,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14027.805000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13186.834,
"heapDeltaBytes": -37474728,
"heapUsedBytes": 179039980,
"domNodes": -3055,
"jsHeapTotalBytes": 4857856,
"scriptDurationMs": 213.49400000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.3991652754591,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 17383.856000000036,
"styleRecalcs": 147,
"styleRecalcDurationMs": 18.035999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16928.462,
"heapDeltaBytes": -18540136,
"heapUsedBytes": 197267272,
"domNodes": -3045,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 803.062,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.79522123893806,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 17483.418000000027,
"styleRecalcs": 152,
"styleRecalcDurationMs": 19.836999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17074.994,
"heapDeltaBytes": -39246008,
"heapUsedBytes": 183114300,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 823.247,
"eventListeners": -14915,
"totalBlockingTimeMs": 9,
"frameDurationMs": 30.972389380530977,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 5112.1579999999085,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.29000000000002,
"layouts": 20,
"layoutDurationMs": 22.75200000000001,
"taskDurationMs": 4951.472,
"heapDeltaBytes": 940864,
"heapUsedBytes": 222462624,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 85.942,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.141714285714283,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5053.406000000109,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.81099999999998,
"layouts": 20,
"layoutDurationMs": 23.683999999999997,
"taskDurationMs": 4914.946000000001,
"heapDeltaBytes": 756264,
"heapUsedBytes": 214195852,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 81.932,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.359302325581403,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7203.225999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6714.557999999998,
"heapDeltaBytes": -26761356,
"heapUsedBytes": 179108688,
"domNodes": -3045,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 103.22600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.241414141414143,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7094.419000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6586.993999999999,
"heapDeltaBytes": -16837620,
"heapUsedBytes": 185873384,
"domNodes": -3045,
"jsHeapTotalBytes": 13651968,
"scriptDurationMs": 101.97899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.431353135313522,
"p95FrameDurationMs": 33.5
},
{
"name": "workflow-execution",
"durationMs": 461.7840000000797,
"styleRecalcs": 22,
"styleRecalcDurationMs": 17.419999999999998,
"layouts": 5,
"layoutDurationMs": 2.06,
"taskDurationMs": 127.13199999999996,
"heapDeltaBytes": 5953948,
"heapUsedBytes": 71698872,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.228000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 89.48500000008153,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.575,
"layouts": 2,
"layoutDurationMs": 0.8610000000000002,
"taskDurationMs": 64.6,
"heapDeltaBytes": 3755200,
"heapUsedBytes": 69629284,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.586999999999994,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67999999999993,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 561.7609999999331,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.698,
"layouts": 76,
"layoutDurationMs": 18.541999999999998,
"taskDurationMs": 531.5939999999999,
"heapDeltaBytes": -17376348,
"heapUsedBytes": 66433468,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 197.78,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 593.2400000000371,
"styleRecalcs": 78,
"styleRecalcDurationMs": 84.467,
"layouts": 76,
"layoutDurationMs": 18.502000000000002,
"taskDurationMs": 563.922,
"heapDeltaBytes": -16887828,
"heapUsedBytes": 67372808,
"domNodes": 76,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 218.428,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1020.5870000000914,
"styleRecalcs": 78,
"styleRecalcDurationMs": 218.067,
"layouts": 76,
"layoutDurationMs": 21.025,
"taskDurationMs": 997.191,
"heapDeltaBytes": 6247488,
"heapUsedBytes": 112540292,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 304.002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225808,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 909.9159999999529,
"styleRecalcs": 78,
"styleRecalcDurationMs": 202.339,
"layouts": 76,
"layoutDurationMs": 18.889,
"taskDurationMs": 885.115,
"heapDeltaBytes": 5219108,
"heapUsedBytes": 110985932,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 261.106,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667272727272724,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2206 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 45946bad530785b1a100a0e65778f2d552180397
Full docs: ADR-DEVEX-LINT-0015 |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #21354 +/- ##
============================================
Coverage 85.95% 85.95%
============================================
Files 2484 2484
Lines 141888 141890 +2
Branches 38645 36667 -1978
============================================
+ Hits 121966 121968 +2
Misses 19538 19538
Partials 384 384
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit ea51be7 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #21241 to
core/1.56.The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it.
Conflict resolved by hand: 1.56 still has the older
showStandingPaywallbody, so the user-message check was added to that body instead of taking main's version. The lifecycle e2e fixture keeps this branch's single-socket shape.Checked locally on this branch:
AgentPanelRoot.test.tspasses, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.