Repository navigation
[backport cloud/1.57] fix(agent): hold the out-of-credits card until the thread is activated (#21241) - #21353
Conversation
#21241) *PR Created by the Glary-Bot Agent* --- ## Summary The standing "Out of credits" card in the agent side panel now appears only after the thread is activated. It no longer shows on a fresh empty thread. **Why:** newly granted gratis credits take about 30s to show up in billing. Until then the workspace reads as exhausted, so the card was appearing on brand-new empty chats. The backend latency fix shipped separately. This is the frontend mitigation agreed in #pillar5-agent. ## Change - `AgentPanelRoot.vue`: `showStandingPaywall` also requires the transcript to hold at least one user message. Brand-new and New Chat threads stay clean; the card appears as soon as the user has sent something. - Gating on transcript content (not the thread id) keeps the card reachable when a first send fails before the server acknowledges it (network, 5xx, or a 402 whose inline card is later resolved), and keeps it hidden while a restored thread is still loading its history. - The `creditsExhausted` gating itself (billing, consent, capability, presentation) is unchanged. - A first send refused with 402 still shows the inline paywall card, so there is no dead end. - Impression telemetry (`credits_exhausted`) is only reported once the card actually shows. ## Test-driven 1. **New e2e test first:** `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`, tagged `@cloud`. It boots with billing exhausted, then checks three things: - the card is hidden on the empty thread; - it shows after the first message; - it hides again after New Chat. On `main` it failed at the empty-thread step: `expected 0, received 1`. 2. **Then the fix.** The new spec passes, and so do these neighbouring specs: - `agentCreditsExhaustionLifecycle.spec.ts` - `agentPaywallSubscribe.spec.ts` - the `agentPanel.spec.ts` case "keeps the standing paywall in sync…" 3. **Unit tests:** `AgentPanelRoot.test.ts`, 458/458 passing. - The standing-paywall cases now record a first user message, so each one still exercises its own gate. - New cases: hidden on an empty thread then shown with one impression after the first message; shown after a failed first send; shown once a refused first send's inline card resolves; hidden while a restored thread has no messages yet. ##⚠️ Revisit if proactive first turns are introduced This uses "the thread is activated by the user" as a stand-in for "the user is engaged". If we ever add **proactive first turns**, where the agent sends the first message, this gating has to be revisited. An "empty thread / no accepted user turn" check would then suppress the card when it should show (or the wrong event would activate it), and the gratis-latency issue it covers would come back. A failed first send (503, network error, refused 402) still counts as the user's first message, so the standing card shows after it when the workspace is exhausted. ## Screenshots Empty thread with billing exhausted (no card), and the same session after the first message (card shown).   --------- (cherry picked from commit 592d64c)
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-19T06:27:13.266Z",
"gitSha": "5c316bcaf003aaa30d92082e6a5b23cdd51686ea",
"branch": "backport-21241-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.9790000000203,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8440000000000003,
"layouts": 8,
"layoutDurationMs": 2.595999999999999,
"taskDurationMs": 435.80500000000006,
"heapDeltaBytes": 22143312,
"heapUsedBytes": 87560040,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.908,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2007.9389999999648,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.965,
"layouts": 9,
"layoutDurationMs": 2.654,
"taskDurationMs": 344.76500000000004,
"heapDeltaBytes": 22097140,
"heapUsedBytes": 88430396,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.799999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.2900000000263,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.985,
"layouts": 9,
"layoutDurationMs": 3.1220000000000003,
"taskDurationMs": 944.695,
"heapDeltaBytes": -7660676,
"heapUsedBytes": 67267796,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 172.657,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665486725663715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.9770000000572,
"styleRecalcs": 85,
"styleRecalcDurationMs": 16.570999999999998,
"layouts": 10,
"layoutDurationMs": 3.0940000000000003,
"taskDurationMs": 1056.4119999999998,
"heapDeltaBytes": -7248732,
"heapUsedBytes": 68209412,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 169.814,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487396,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.72999999997,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.205,
"layouts": 10,
"layoutDurationMs": 2.7830000000000004,
"taskDurationMs": 440.485,
"heapDeltaBytes": -4129240,
"heapUsedBytes": 70761960,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.905999999999995,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.8280000000686,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.693999999999999,
"layouts": 12,
"layoutDurationMs": 3.195,
"taskDurationMs": 307.393,
"heapDeltaBytes": 18295120,
"heapUsedBytes": 84711244,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 12.969000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 728.1429999999887,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.882,
"layouts": 8,
"layoutDurationMs": 2.599,
"taskDurationMs": 522.004,
"heapDeltaBytes": 2024448,
"heapUsedBytes": 76913280,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 168.41699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.053488372093028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.6369999999206,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.431,
"layouts": 9,
"layoutDurationMs": 2.48,
"taskDurationMs": 444.1700000000001,
"heapDeltaBytes": -212404,
"heapUsedBytes": 65944600,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 175.995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857128,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1272.198000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 986.5659999999999,
"heapDeltaBytes": -3200796,
"heapUsedBytes": 81345516,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 73.46299999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 580,
"frameDurationMs": 34.23243243243242,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.2140000001018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.245,
"heapDeltaBytes": -11239072,
"heapUsedBytes": 81636032,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 71.06,
"eventListeners": -105,
"totalBlockingTimeMs": 517,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.0499999999915,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.09300000000013,
"heapDeltaBytes": -3258536,
"heapUsedBytes": 76507304,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.00599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.6580000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.7709999999997,
"heapDeltaBytes": -5487616,
"heapUsedBytes": 75303972,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.15800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10561.67099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9654.555999999999,
"heapDeltaBytes": -1363688,
"heapUsedBytes": 97900600,
"domNodes": -278,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7722.089,
"eventListeners": -68,
"totalBlockingTimeMs": 1040,
"frameDurationMs": 30.986217008797652,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10330.19999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9485.668,
"heapDeltaBytes": -24270604,
"heapUsedBytes": 75456568,
"domNodes": -258,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 7704.233,
"eventListeners": -68,
"totalBlockingTimeMs": 911,
"frameDurationMs": 31.50304878048781,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9788.87599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8928.987000000001,
"heapDeltaBytes": -26278520,
"heapUsedBytes": 72199244,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 7497.916,
"eventListeners": -68,
"totalBlockingTimeMs": 1020,
"frameDurationMs": 31.866123778501628,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9616.462000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8805.685000000001,
"heapDeltaBytes": -7910280,
"heapUsedBytes": 79453556,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7174.146000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 625,
"frameDurationMs": 31.842052980132447,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 227.70399999996016,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.895,
"layouts": 11,
"layoutDurationMs": 3.374,
"taskDurationMs": 170.16,
"heapDeltaBytes": 13059624,
"heapUsedBytes": 91616656,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.642000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 243.67700000004788,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.066999999999997,
"layouts": 12,
"layoutDurationMs": 3.65,
"taskDurationMs": 182.47599999999997,
"heapDeltaBytes": -8168308,
"heapUsedBytes": 79112492,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.655,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2039.18299999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3229999999999995,
"layouts": 7,
"layoutDurationMs": 2.4760000000000004,
"taskDurationMs": 544.378,
"heapDeltaBytes": -2364800,
"heapUsedBytes": 76474140,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 37.331,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.020000000103,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.281999999999999,
"layouts": 8,
"layoutDurationMs": 2.3770000000000007,
"taskDurationMs": 627.2410000000001,
"heapDeltaBytes": -18898812,
"heapUsedBytes": 77829820,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 34.287,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2729.686000000015,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.9510000000000005,
"layouts": 5,
"layoutDurationMs": 1.4760000000000004,
"taskDurationMs": 1771.877,
"heapDeltaBytes": -30528896,
"heapUsedBytes": 67544164,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 835.88,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2258.8889999999537,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.802,
"layouts": 6,
"layoutDurationMs": 1.8210000000000002,
"taskDurationMs": 1482.824,
"heapDeltaBytes": -11948592,
"heapUsedBytes": 68574360,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 798.046,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91417910447761,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3556.280000000015,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.147,
"layouts": 64,
"layoutDurationMs": 11.328,
"taskDurationMs": 1583.808,
"heapDeltaBytes": 1462108,
"heapUsedBytes": 82900680,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 786.499,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3680.845999999974,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.26,
"layouts": 64,
"layoutDurationMs": 10.605,
"taskDurationMs": 1747.875,
"heapDeltaBytes": -26993676,
"heapUsedBytes": 72204392,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 769.072,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741818181818182,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3018.3450000000107,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.061999999999999,
"layouts": 4,
"layoutDurationMs": 1.2889999999999997,
"taskDurationMs": 1831.2,
"heapDeltaBytes": 13442100,
"heapUsedBytes": 96494556,
"domNodes": 0,
"jsHeapTotalBytes": 8019968,
"scriptDurationMs": 995.4759999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.949152542372882,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2870.3270000000884,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.33,
"layouts": 4,
"layoutDurationMs": 1.136,
"taskDurationMs": 1885.2190000000003,
"heapDeltaBytes": 8221836,
"heapUsedBytes": 86649688,
"domNodes": 0,
"jsHeapTotalBytes": 5206016,
"scriptDurationMs": 935.578,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763742690058482,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.7410000000114,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1929999999999996,
"layouts": 6,
"layoutDurationMs": 1.636,
"taskDurationMs": 523.313,
"heapDeltaBytes": -4404436,
"heapUsedBytes": 77047664,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.025000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.9019999999737,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.236,
"layouts": 7,
"layoutDurationMs": 2.119,
"taskDurationMs": 625.1289999999999,
"heapDeltaBytes": -24821708,
"heapUsedBytes": 74167272,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 32.11299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.4450000000152,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.456999999999999,
"layouts": 10,
"layoutDurationMs": 2.927,
"taskDurationMs": 481.002,
"heapDeltaBytes": -2294108,
"heapUsedBytes": 74232324,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 151.17600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.5119999999424,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.6690000000000005,
"layouts": 9,
"layoutDurationMs": 2.538,
"taskDurationMs": 418.01800000000003,
"heapDeltaBytes": 21586364,
"heapUsedBytes": 88920236,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 143.88500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.5440000000153,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3690000000000007,
"layouts": 9,
"layoutDurationMs": 3.2880000000000003,
"taskDurationMs": 575.218,
"heapDeltaBytes": -285476,
"heapUsedBytes": 76684856,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.399000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.6600000000872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1730000000000005,
"layouts": 9,
"layoutDurationMs": 3.2620000000000005,
"taskDurationMs": 504.074,
"heapDeltaBytes": 3884308,
"heapUsedBytes": 80918824,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 8.931000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.8340000000007,
"styleRecalcs": 87,
"styleRecalcDurationMs": 20.636000000000003,
"layouts": 9,
"layoutDurationMs": 2.8049999999999997,
"taskDurationMs": 1095.914,
"heapDeltaBytes": 11761396,
"heapUsedBytes": 78627296,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 119.537,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.8880000000017,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.847,
"layouts": 10,
"layoutDurationMs": 2.302,
"taskDurationMs": 1004.124,
"heapDeltaBytes": -11428584,
"heapUsedBytes": 65644460,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 106.43799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.5970000000216,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.664999999999996,
"layouts": 5,
"layoutDurationMs": 16.677,
"taskDurationMs": 1092.2359999999999,
"heapDeltaBytes": 7124976,
"heapUsedBytes": 108943972,
"domNodes": 15953,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 29.533000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.517105263157898,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10218.434000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.916,
"layouts": 7,
"layoutDurationMs": 2.118,
"taskDurationMs": 6122.402,
"heapDeltaBytes": 8867148,
"heapUsedBytes": 87577864,
"domNodes": -258,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2766.089,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72045826513912,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8250.14299999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.366,
"layouts": 7,
"layoutDurationMs": 2.143,
"taskDurationMs": 4927.441,
"heapDeltaBytes": 6727184,
"heapUsedBytes": 85387596,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2600.4010000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733671399594318,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17036.854000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16199.853999999998,
"heapDeltaBytes": -23576440,
"heapUsedBytes": 267394612,
"domNodes": -3330,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 258.949,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.215608919382504,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 15144.780999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14578.355000000001,
"heapDeltaBytes": -17245484,
"heapUsedBytes": 273816948,
"domNodes": -3330,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 228.855,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.852218430034128,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27970.26599999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.677999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27633.927000000003,
"heapDeltaBytes": 774116,
"heapUsedBytes": 282399292,
"domNodes": -3330,
"jsHeapTotalBytes": 4374528,
"scriptDurationMs": 915.767,
"eventListeners": -651,
"totalBlockingTimeMs": 58,
"frameDurationMs": 51.40716911764706,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27502.839999999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.604000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27125.031,
"heapDeltaBytes": -22146212,
"heapUsedBytes": 273689232,
"domNodes": -3330,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 858.6320000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 50.64272559852671,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8198.083999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.09600000000002,
"layouts": 20,
"layoutDurationMs": 22.985999999999994,
"taskDurationMs": 8029.198999999999,
"heapDeltaBytes": -32501396,
"heapUsedBytes": 249365668,
"domNodes": -3330,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 126.52400000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.124712643678166,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5932.959000000096,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.338,
"layouts": 20,
"layoutDurationMs": 22.791000000000004,
"taskDurationMs": 5789.493,
"heapDeltaBytes": -7947528,
"heapUsedBytes": 282714988,
"domNodes": -3330,
"jsHeapTotalBytes": 27516928,
"scriptDurationMs": 104.99099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 4,
"frameDurationMs": 33.90342857142856,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8143.252999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7555.4039999999995,
"heapDeltaBytes": -8582824,
"heapUsedBytes": 251493656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.2010033444816,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11465.330999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11290.009000000002,
"heapDeltaBytes": 18984156,
"heapUsedBytes": 260403192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.806,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.13378839590444,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 125.72900000009213,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.528999999999998,
"layouts": 8,
"layoutDurationMs": 3.665,
"taskDurationMs": 95.95599999999999,
"heapDeltaBytes": -15237428,
"heapUsedBytes": 68103208,
"domNodes": 116,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.985000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 482.87999999990916,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.023,
"layouts": 13,
"layoutDurationMs": 4.723000000000001,
"taskDurationMs": 137.677,
"heapDeltaBytes": -13607520,
"heapUsedBytes": 70086556,
"domNodes": 95,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.186,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 439.12499999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.949,
"layouts": 76,
"layoutDurationMs": 14.458,
"taskDurationMs": 383.92199999999997,
"heapDeltaBytes": 11031724,
"heapUsedBytes": 83352864,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 186.641,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 466.73699999996643,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9420000000000001,
"layouts": 76,
"layoutDurationMs": 14.312,
"taskDurationMs": 421.76000000000005,
"heapDeltaBytes": -13905992,
"heapUsedBytes": 82322212,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 207.51799999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517268,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 563.6240000000043,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.442,
"layouts": 76,
"layoutDurationMs": 15.748999999999999,
"taskDurationMs": 536.131,
"heapDeltaBytes": 11149188,
"heapUsedBytes": 162189528,
"domNodes": 4,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 216.308,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.158823529411755,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 463.01200000004883,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.73,
"layouts": 76,
"layoutDurationMs": 12.873000000000001,
"taskDurationMs": 424.79699999999997,
"heapDeltaBytes": -530484,
"heapUsedBytes": 118016352,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.87899999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d515bd917499f7ba54a8e5c3edae52c9ee32e80f
Full docs: ADR-DEVEX-LINT-0015 |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21353 +/- ##
=============================================
Coverage ? 87.22%
=============================================
Files ? 2636
Lines ? 148106
Branches ? 40709
=============================================
Hits ? 129189
Misses ? 18527
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit a2716a4 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
…d before showing the out-of-credits card (#21538) (#21590) Backport of #21538 to `cloud/1.57`. A new account's first prompt no longer shows the "Out of credits" card while the turn runs on the free credits granted at admission. Cloud production serves `ba2c2c2269`, which is on this branch, so Cloud gets the fix from the next `cloud/1.57` patch promotion. The product code is the clean cherry-pick. Only the three new `AgentPanelRoot` unit cases were adapted to this branch: they match the thread list the way the rest of this file does and import the promise form of `setImmediate`. <details><summary>Full context for agent readers</summary> - Source: #21538, merged as 340d406. Its prerequisite #21241 is already on this branch (#21353)). `git patch-id --stable` of the unadapted cherry-pick equals the source. - Author and author date preserved; `-x` provenance line kept. No AI co-author trailer. - Black-box proof, `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts` › "keeps the card hidden when the first send is admitted on credits granted at admission", `--project=cloud`, local ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud` dev server: - parent (`cloud/1.57` product files, new spec kept): fails; the page snapshot shows "Out of credits" and "Add credits" under the admitted user message. - this head: passes, along with the rest of `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle` and `agentFreeUsePlacement`. - `agentPanel.spec.ts`: 18 of 19 pass. "flag off › does not expose the Agent button" fails the same way with and without this change on the local dev server, so it is a local-environment result, not a regression; CI decides. - Vitest `AgentPanelRoot.test.ts`, `useAgentSession.test.ts`, `agentPanelStore.test.ts`: 713 passed. `typecheck` and `typecheck:browser` clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: 1.56 trains are not carried (no consumer; product code diverged). `cloud/1.58` and `core/1.58` are not in the program's release authority yet and also lack #21538. </details>
Backport of #21241 to
cloud/1.57.The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it.
Conflict resolved by hand in the lifecycle e2e fixture only: this branch still passes a single socket, so the new thread-history route was added around that.
Checked locally on this branch:
AgentPanelRoot.test.tspasses, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.