Repository navigation
fix(billing): stop reading saved payment methods in the workspace top-up dialog - #20367
Conversation
…-up dialog The top-up dialog read /api/billing/payment-methods to choose a payment note. The server refuses that read while embedded checkout is disabled, which it is for every production session, so the note never rendered and every open reported saved_payment_methods_read_failure. Remove the read, the note and the now-unused useHasSavedPaymentMethod composable.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 526ab682653318e776c73570385a273f0fd3b151
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.29 MB gzip 🟢 -683 BDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 678 kB (baseline 678 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 7 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 1 unchanged UI Components — 203 kB (baseline 203 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 11 unchanged Data & Services — 4.19 MB (baseline 4.2 MB) • 🟢 -2.22 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 584 kB (baseline 584 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 19 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • 🟢 -263 BBundles that do not match a named category
Status: 89 added / 89 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T12:11:53.378Z",
"gitSha": "94eb8eb3b3115c3a9a36067ffb2cf3949f0f5c3b",
"branch": "fix/remove-saved-payment-method-lookup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.1119999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.656000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.296,
"heapDeltaBytes": -26672352,
"heapUsedBytes": 82745376,
"domNodes": -212,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 14.485999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.097999999938,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.58900000000006,
"heapDeltaBytes": 3574456,
"heapUsedBytes": 67908620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.487000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.940999999973,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.081,
"layouts": 12,
"layoutDurationMs": 5.094,
"taskDurationMs": 958.6300000000001,
"heapDeltaBytes": -30269112,
"heapUsedBytes": 78715036,
"domNodes": -212,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 171.278,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1746.2459999999282,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.278000000000002,
"layouts": 12,
"layoutDurationMs": 4.550999999999999,
"taskDurationMs": 859.362,
"heapDeltaBytes": 25956736,
"heapUsedBytes": 82659564,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.113,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.4749999999926,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.405,
"layouts": 3,
"layoutDurationMs": 0.8670000000000001,
"taskDurationMs": 334.30299999999994,
"heapDeltaBytes": 9624760,
"heapUsedBytes": 80093880,
"domNodes": 45,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.705999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.463000000006,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.536000000000001,
"layouts": 3,
"layoutDurationMs": 0.8999999999999998,
"taskDurationMs": 460.84999999999997,
"heapDeltaBytes": -51872648,
"heapUsedBytes": 57535504,
"domNodes": -167,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 14.988999999999999,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 721.5699999999856,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.480000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.4599999999999,
"heapDeltaBytes": -37330840,
"heapUsedBytes": 71959704,
"domNodes": -212,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 172.58499999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 678.7939999999253,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.107000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.848,
"heapDeltaBytes": 300864,
"heapUsedBytes": 109687024,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 179.04399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1271.6880000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.7549999999999,
"heapDeltaBytes": 17062044,
"heapUsedBytes": 89439468,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 79.758,
"eventListeners": 0,
"totalBlockingTimeMs": 620,
"frameDurationMs": 36.19142857142857,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.4640000000354,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 879.8960000000001,
"heapDeltaBytes": 13667836,
"heapUsedBytes": 96111664,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 70.00500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 588,
"frameDurationMs": 35.782352941176484,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 904.6200000000226,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.1980000000009,
"heapDeltaBytes": 19315068,
"heapUsedBytes": 126066036,
"domNodes": 0,
"jsHeapTotalBytes": 2887680,
"scriptDurationMs": 175.73699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 890.48200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.3039999999995,
"heapDeltaBytes": -8086012,
"heapUsedBytes": 82351284,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 178.52800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.23714285714289,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12307.495999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11316.967,
"heapDeltaBytes": 15339812,
"heapUsedBytes": 98322980,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 9418.095,
"eventListeners": 0,
"totalBlockingTimeMs": 2092,
"frameDurationMs": 34.20941828254848,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10885.245000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9950.175,
"heapDeltaBytes": 12428804,
"heapUsedBytes": 84479184,
"domNodes": -141,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 8243.762,
"eventListeners": -65,
"totalBlockingTimeMs": 1216,
"frameDurationMs": 31.821637426900583,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10232.648999999981,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9380.742000000002,
"heapDeltaBytes": -1662392,
"heapUsedBytes": 69286572,
"domNodes": -141,
"jsHeapTotalBytes": -15077376,
"scriptDurationMs": 7713.781,
"eventListeners": -69,
"totalBlockingTimeMs": 981,
"frameDurationMs": 31.681114551083592,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9992.719999999963,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.31699999999999956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9120.018999999998,
"heapDeltaBytes": -16838492,
"heapUsedBytes": 70572244,
"domNodes": -141,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 7491.539,
"eventListeners": -69,
"totalBlockingTimeMs": 963,
"frameDurationMs": 31.692063492063493,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2047.535000000039,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8400000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.5000000000001,
"heapDeltaBytes": -49512204,
"heapUsedBytes": 82474824,
"domNodes": -308,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 38.71499999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.8169999999654,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.1269999999998,
"heapDeltaBytes": -3200704,
"heapUsedBytes": 87358732,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.168000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2527.4800000000255,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1710.6500000000003,
"heapDeltaBytes": -1299420,
"heapUsedBytes": 90093112,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 882.6120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2395.028000000025,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.8290000000004,
"heapDeltaBytes": 12100048,
"heapUsedBytes": 76942100,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 831.3159999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.782394366197178,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3798.3389999999986,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.851999999999998,
"layouts": 60,
"layoutDurationMs": 16.767,
"taskDurationMs": 1771.8290000000004,
"heapDeltaBytes": 8560096,
"heapUsedBytes": 75406136,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 819.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154187,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3683.319000000097,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.9060000000000015,
"layouts": 60,
"layoutDurationMs": 15.656,
"taskDurationMs": 1729.2559999999999,
"heapDeltaBytes": 4471268,
"heapUsedBytes": 70879836,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.232,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3138.7130000000525,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1985.5949999999998,
"heapDeltaBytes": 23963980,
"heapUsedBytes": 94558364,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1047.7939999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84462365591398,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3148.9400000000387,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.3500000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1998.0540000000003,
"heapDeltaBytes": 1143068,
"heapUsedBytes": 71870240,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 1035.132,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.844385026737967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.4259999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.722,
"heapDeltaBytes": -2738616,
"heapUsedBytes": 89615072,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 44.477000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.1669999999767,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.877000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.2120000000001,
"heapDeltaBytes": -5106824,
"heapUsedBytes": 75121888,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.474,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.9410000000253,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.254999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.712,
"heapDeltaBytes": 10975548,
"heapUsedBytes": 67537884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.36599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.1730000000789,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.520999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.87399999999997,
"heapDeltaBytes": -43353820,
"heapUsedBytes": 67347232,
"domNodes": -230,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 145.179,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.1530000000125,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.083999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.678,
"heapDeltaBytes": 4186608,
"heapUsedBytes": 69549552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2041.969999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.4209999999999,
"heapDeltaBytes": -49261068,
"heapUsedBytes": 58317516,
"domNodes": -230,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 11.748999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.1370000000138,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.392,
"layouts": 16,
"layoutDurationMs": 6.693,
"taskDurationMs": 832.7,
"heapDeltaBytes": -386908,
"heapUsedBytes": 71656036,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 118.951,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3520000000672,
"styleRecalcs": 59,
"styleRecalcDurationMs": 16.929,
"layouts": 16,
"layoutDurationMs": 6.364,
"taskDurationMs": 797.5200000000001,
"heapDeltaBytes": -3983240,
"heapUsedBytes": 61070400,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.23499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.7259999999687,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.440999999999995,
"layouts": 5,
"layoutDurationMs": 15.493,
"taskDurationMs": 1042.6680000000001,
"heapDeltaBytes": 10394076,
"heapUsedBytes": 112726544,
"domNodes": 14570,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 34.53399999999999,
"eventListeners": 2458,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.632876712328766,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9528.362000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.051000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6207.058,
"heapDeltaBytes": -8782948,
"heapUsedBytes": 82289716,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2974.469,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69526315789474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9387.887999999975,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5970.425,
"heapDeltaBytes": -17464372,
"heapUsedBytes": 73385128,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2930.9829999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607460035524,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18735.06199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18143.997,
"heapDeltaBytes": -37232624,
"heapUsedBytes": 183169012,
"domNodes": -3046,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 282.38199999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.912436115843267,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18653.09699999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17963.313,
"heapDeltaBytes": -47530348,
"heapUsedBytes": 183852348,
"domNodes": -3046,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 286.73800000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.20932642487047,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 23908.515999999963,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.465999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23585.338999999996,
"heapDeltaBytes": -28150456,
"heapUsedBytes": 189478812,
"domNodes": -3046,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 933.8530000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 20,
"frameDurationMs": 44.288518518518515,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23376.983999999993,
"styleRecalcs": 180,
"styleRecalcDurationMs": 17.672000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22969.87,
"heapDeltaBytes": -30287176,
"heapUsedBytes": 189466024,
"domNodes": -3046,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 886.721,
"eventListeners": -14915,
"totalBlockingTimeMs": 11,
"frameDurationMs": 43.542644320297946,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6892.2959999999875,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.12000000000002,
"layouts": 20,
"layoutDurationMs": 28.662999999999993,
"taskDurationMs": 6763.906999999999,
"heapDeltaBytes": -6720188,
"heapUsedBytes": 216490832,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.342,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.97083333333334,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6642.001999999934,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.40800000000003,
"layouts": 20,
"layoutDurationMs": 26.76299999999998,
"taskDurationMs": 6521.655000000001,
"heapDeltaBytes": 1000680,
"heapUsedBytes": 217874156,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.03600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.79005847953218,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9536.211999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9144.910999999998,
"heapDeltaBytes": -31847488,
"heapUsedBytes": 185358156,
"domNodes": -3046,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 142.73199999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.20608108108108,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9434.83900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9047.318000000001,
"heapDeltaBytes": -33787280,
"heapUsedBytes": 184003508,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 138.64600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.86790540540541,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 457.07199999992554,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.076999999999998,
"layouts": 3,
"layoutDurationMs": 1.014,
"taskDurationMs": 115.689,
"heapDeltaBytes": 6148308,
"heapUsedBytes": 68375512,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.974,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 166.66800000007242,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.053,
"layouts": 2,
"layoutDurationMs": 0.7340000000000001,
"taskDurationMs": 102.62299999999999,
"heapDeltaBytes": 4032328,
"heapUsedBytes": 111726240,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.982000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.5222222222222,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 962.7480000000332,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.008,
"layouts": 76,
"layoutDurationMs": 28.336,
"taskDurationMs": 938.683,
"heapDeltaBytes": 19059756,
"heapUsedBytes": 88806792,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 400.419,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 940.2250000000549,
"styleRecalcs": 78,
"styleRecalcDurationMs": 92.084,
"layouts": 76,
"layoutDurationMs": 27.837,
"taskDurationMs": 911.2320000000001,
"heapDeltaBytes": 18661608,
"heapUsedBytes": 91472176,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 382.9030000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664912280701763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1481.296000000043,
"styleRecalcs": 78,
"styleRecalcDurationMs": 262.58,
"layouts": 76,
"layoutDurationMs": 30.375,
"taskDurationMs": 1457.065,
"heapDeltaBytes": 14059716,
"heapUsedBytes": 132606832,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 515.633,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.31111111111112,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1400.600000000054,
"styleRecalcs": 78,
"styleRecalcDurationMs": 244.38899999999998,
"layouts": 76,
"layoutDurationMs": 28.648,
"taskDurationMs": 1383.323,
"heapDeltaBytes": 14028900,
"heapUsedBytes": 135058360,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 481.64599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.488888888888894,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2239 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe workspace top-up confirmation no longer displays saved-payment-method details or provides a billing-management link. The saved-payment-method composable and related locale messages were removed. Tests now check the billing instructions shown after a ChangesWorkspace top-up confirmation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The top-up confirmation no longer shows saved-payment details or a billing link, while users rejected for NO_PAYMENT_METHOD still receive workspace billing instructions. No actionable merge risk remains in the reviewed changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20367 +/- ##
==========================================
+ Coverage 85.49% 86.46% +0.97%
==========================================
Files 3533 2491 -1042
Lines 169469 141714 -27755
Branches 44489 36662 -7827
==========================================
- Hits 144883 122530 -22353
+ Misses 22588 18804 -3784
+ Partials 1998 380 -1618
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1128 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
What this PR removesThis is the confirm step of the workspace top-up dialog. The red boxes mark what is removed: the payment note under "Total due today" and, when no card is saved, its inline Manage billing link. Nothing else in the dialog changes, and the embedded checkout UI itself (the Stripe form in the subscription dialogs) is untouched. The note depended on How the screenshots were taken: local Generated by Claude Code |
|
|
|
|
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
… in the workspace top-up dialog (#20488) Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate. --------- Co-authored-by: Dante <bunggl@naver.com>
…s in the workspace top-up dialog (#20489) Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate. --------- Co-authored-by: Dante <bunggl@naver.com>
…s in the workspace top-up dialog (#20491) Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate. --------- Co-authored-by: Dante <bunggl@naver.com>
… in the workspace top-up dialog (#20490) Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate. --------- Co-authored-by: Dante <bunggl@naver.com>

Summary
The workspace top-up dialog called
GET /api/billing/payment-methodsto pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, andembedded_checked_enabledwasfalsein every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reportedsaved_payment_methods_read_failureto Sentry and Datadog (1,114 events in 14d; 1,043 of them sayEmbedded checkout is disabled, and the rail's 73REQUEST_FAILEDcome from the same call).This PR removes the read, the note, its Manage billing button and the
useHasSavedPaymentMethodcomposable, which had no other caller. Subscription checkout already skips this read when the flag is off (loadSavedPaymentMethodsinuseSubscriptionCheckout.ts).billing-web is unaffected. It does not import from
src/; it reads payment methods through@comfyorg/account-core(PaymentMethodsPanel,useFullPageCheckout,useFullPageTopup). This PR does not touchpackages/.Follow-ups, not in this PR:
hosted_billing_destinationmoves offstripe(it isstripefor every production session today), confirm that the server no longer gates/billing/payment-methodson embedded checkout.embedded_checked_enabledcode fromsrc/is a separate cleanup.Part of the WorkspaceApiError triage started in #20344.
Verification
pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged.typecheck:app) and the pre-push hook (knip) pass.saved_payment_methods_read_failureshould drop to zero in Datadog RUM (env:prod-v2) and in Sentry.Generated by Claude Code