Repository navigation
[backport core/1.54] fix(billing): stop reading saved payment methods in the workspace top-up dialog - #20488
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1984 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T01:34:20.945Z",
"gitSha": "aa30fceb8afe415b1bdf546516fbea3e487c0e16",
"branch": "christian/backport-20367-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2089.574999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.741999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.97999999999996,
"heapDeltaBytes": 8252084,
"heapUsedBytes": 79045196,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.949999999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.6269999999904,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.4990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.341,
"heapDeltaBytes": 4523252,
"heapUsedBytes": 75004204,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.768999999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.4269999999774,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.967000000000002,
"layouts": 14,
"layoutDurationMs": 3.902,
"taskDurationMs": 622.39,
"heapDeltaBytes": 3743788,
"heapUsedBytes": 75006148,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.296,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.4279999999835,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.148,
"layouts": 14,
"layoutDurationMs": 3.82,
"taskDurationMs": 559.554,
"heapDeltaBytes": 4533588,
"heapUsedBytes": 75986460,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.306,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.3549999999955,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.398,
"layouts": 6,
"layoutDurationMs": 1.0330000000000001,
"taskDurationMs": 255.871,
"heapDeltaBytes": 4966448,
"heapUsedBytes": 78166016,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.090000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.934999999905,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.916,
"layouts": 6,
"layoutDurationMs": 0.9860000000000001,
"taskDurationMs": 247.79399999999998,
"heapDeltaBytes": 4489824,
"heapUsedBytes": 75828864,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.731000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 581.9129999999859,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.668,
"heapDeltaBytes": -7109928,
"heapUsedBytes": 65974104,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 125.86900000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 454.63500000005297,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.221000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.235,
"heapDeltaBytes": -8427084,
"heapUsedBytes": 64680228,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 99.368,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2024.6549999999957,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.599000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.9580000000001,
"heapDeltaBytes": -8640828,
"heapUsedBytes": 69483288,
"domNodes": -280,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 33.934,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.5260000000135,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.603999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.15599999999995,
"heapDeltaBytes": -8343940,
"heapUsedBytes": 71913708,
"domNodes": -274,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 22.795,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2354.479999999967,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.328000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1195.935,
"heapDeltaBytes": 383636,
"heapUsedBytes": 66746168,
"domNodes": -277,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 594.5450000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2232.8059999999823,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1161.9890000000003,
"heapDeltaBytes": 7163780,
"heapUsedBytes": 88267556,
"domNodes": -284,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 564.484,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3345.5579999999827,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.152,
"layouts": 60,
"layoutDurationMs": 13.971,
"taskDurationMs": 1243.6560000000002,
"heapDeltaBytes": 1081200,
"heapUsedBytes": 83365068,
"domNodes": -260,
"jsHeapTotalBytes": 2916352,
"scriptDurationMs": 534.157,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3238.6599999999817,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.791,
"layouts": 60,
"layoutDurationMs": 13.777,
"taskDurationMs": 1194.242,
"heapDeltaBytes": -3007720,
"heapUsedBytes": 79120736,
"domNodes": -260,
"jsHeapTotalBytes": 3178496,
"scriptDurationMs": 517.437,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2483.1459999999765,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1403.73,
"heapDeltaBytes": -16350792,
"heapUsedBytes": 68571308,
"domNodes": -248,
"jsHeapTotalBytes": -1015808,
"scriptDurationMs": 700.949,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2320.6330000000435,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.787,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1303.781,
"heapDeltaBytes": 7483436,
"heapUsedBytes": 89863908,
"domNodes": 14,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 666.632,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.885999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.644,
"heapDeltaBytes": -11186028,
"heapUsedBytes": 70971620,
"domNodes": -278,
"jsHeapTotalBytes": -2064384,
"scriptDurationMs": 23.804,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.4450000000852,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.448999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.44199999999995,
"heapDeltaBytes": -3861828,
"heapUsedBytes": 75238316,
"domNodes": -268,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 25.862000000000002,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.4229999999998,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.964,
"heapDeltaBytes": 14245168,
"heapUsedBytes": 89453276,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 91.683,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.22400000004745,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.617,
"heapDeltaBytes": 14542404,
"heapUsedBytes": 89751756,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 95.19,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.220999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.025000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.001,
"heapDeltaBytes": -8081404,
"heapUsedBytes": 64718944,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.95,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.3840000000155,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.136000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.85699999999997,
"heapDeltaBytes": 7731380,
"heapUsedBytes": 81224672,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.205999999999998,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1744.9770000000058,
"styleRecalcs": 79,
"styleRecalcDurationMs": 26.567,
"layouts": 18,
"layoutDurationMs": 4.901,
"taskDurationMs": 646.983,
"heapDeltaBytes": -6936576,
"heapUsedBytes": 66708652,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 89.407,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.4630000000461,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.812,
"layouts": 18,
"layoutDurationMs": 4.763,
"taskDurationMs": 557.7189999999999,
"heapDeltaBytes": 8386344,
"heapUsedBytes": 81465932,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 79.866,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.6180000000095,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.998999999999995,
"layouts": 17,
"layoutDurationMs": 10.49,
"taskDurationMs": 536.7610000000001,
"heapDeltaBytes": -6898888,
"heapUsedBytes": 83713128,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 18.501000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 61,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8418.87300000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.956999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4118.892,
"heapDeltaBytes": -8092764,
"heapUsedBytes": 69221388,
"domNodes": -239,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 2002.996,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8352.11700000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4090.629,
"heapDeltaBytes": 12858916,
"heapUsedBytes": 89058060,
"domNodes": -283,
"jsHeapTotalBytes": 3264512,
"scriptDurationMs": 1909.824,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12675.19500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12011.362000000001,
"heapDeltaBytes": -62610596,
"heapUsedBytes": 174478844,
"domNodes": -8068,
"jsHeapTotalBytes": -18001920,
"scriptDurationMs": 181.62,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12755.143999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12131.894,
"heapDeltaBytes": -53704136,
"heapUsedBytes": 186529000,
"domNodes": -8068,
"jsHeapTotalBytes": -13008896,
"scriptDurationMs": 187.63599999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14491.198999999995,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.135000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14116.927,
"heapDeltaBytes": -26808760,
"heapUsedBytes": 186275936,
"domNodes": -8068,
"jsHeapTotalBytes": -12746752,
"scriptDurationMs": 651.4570000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15102.971999999909,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.24700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14601.395,
"heapDeltaBytes": -53401060,
"heapUsedBytes": 186660056,
"domNodes": -8068,
"jsHeapTotalBytes": -13533184,
"scriptDurationMs": 647.378,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4437.294000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.60599999999999,
"layouts": 20,
"layoutDurationMs": 23.036,
"taskDurationMs": 4336.4,
"heapDeltaBytes": -34044372,
"heapUsedBytes": 185275408,
"domNodes": -8068,
"jsHeapTotalBytes": 20197376,
"scriptDurationMs": 70.012,
"eventListeners": -14931,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4369.884999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.02499999999999,
"layouts": 20,
"layoutDurationMs": 22.33199999999999,
"taskDurationMs": 4311.6320000000005,
"heapDeltaBytes": -59906136,
"heapUsedBytes": 173890684,
"domNodes": -8068,
"jsHeapTotalBytes": 13725696,
"scriptDurationMs": 75.991,
"eventListeners": -14931,
"totalBlockingTimeMs": 32,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6014.962000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5577.842000000001,
"heapDeltaBytes": 14073756,
"heapUsedBytes": 179925476,
"domNodes": -1,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 81.06100000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6396.69600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6076.2429999999995,
"heapDeltaBytes": -16835924,
"heapUsedBytes": 164361364,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 87.63900000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 71.20400000002292,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.253,
"layouts": 3,
"layoutDurationMs": 1.214,
"taskDurationMs": 51.382,
"heapDeltaBytes": 3026072,
"heapUsedBytes": 72715536,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.122999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 70.57499999996253,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.669999999999998,
"layouts": 2,
"layoutDurationMs": 0.993,
"taskDurationMs": 46.932,
"heapDeltaBytes": 2919892,
"heapUsedBytes": 72062688,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.2499999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #20488 +/- ##
=============================================
+ Coverage 84.31% 84.32% +0.01%
=============================================
Files 2125 2125
Lines 127691 127788 +97
Branches 34420 32582 -1838
=============================================
+ Hits 107659 107756 +97
- Misses 19844 19845 +1
+ Partials 188 187 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes for one regression-safety-net gap (Gate 1), anchored on the retained refusal test. The current removal behaves correctly in direct validation; the existing tests do not protect its stated no-read guarantee.
Exact 1e2a3252c60e320fc02fdb833935afb16f6907e2, isolated checkout and own frozen install:
- PASS: 221 unit tests/5 files, app/browser types, release-distribution production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Unit ESLint is ignored by config and NOT_RUN.
- PASS: 8 OSS production browser checks passed (one repeats the retained refusal journey; 7 distinct checks). Auth/billing/feature flags and payment responses are controlled; the bundle is real production output served by an isolated local ComfyUI backend. These are not live charges.
- RED: pre-patch production restored -> independent component guard 1 failed/27 passed; production browser no-read guard failed. Original source/output restored -> component suite 27 passed and corresponding browser guard passed. All changed/deleted files match the exact head; checkout clean.
- Contract/code review: no new response declarations or frontend-derived server facts; existing generated response types and purchase/recovery code remain authoritative and unchanged. Graph/extension callbacks are untouched.
CI results were queried separately at this head; in-progress workflows are not own PASS and do not settle the safety-net gap. NOT_RUN: live customer/payment/Stripe, native Desktop, other OS/browser, broad performance and unrelated suites. Initial Cloud use of the local-only workspace fixture failed before app readiness; the Cloud fixture then passed. Initial SDK probe omitted unified-auth/server flag prerequisites and stayed on XHR; corrected fixtures proved actual SDK fetch and were mutation-checked. No source changes, reruns, thread resolution or merge were performed.
| test('offers Manage billing and explains a refused purchase', async ({ | ||
| comfyPage | ||
| }) => { | ||
| test('explains a refused purchase', async ({ comfyPage }) => { |
There was a problem hiding this comment.
issue: The modified refusal test still passes if the removed saved-payment lookup is reintroduced. In this isolated head I restored the pre-PR component and lookup: all 27 existing component tests stayed green. An independent guard passed with the patch (28 tests), then failed only its no-read assertion without it (1 failed/27 passed), observing one listSavedPaymentMethods call; an actual production-browser probe likewise caught the payment-method GET. Could we keep one behavioral regression proving that a usable confirmation dialog no longer starts this lookup (legacy and SDK rows on 1.55)? The obsolete note/portal tests can remain removed. This is a missing safety net for the PR's stated behavior, rather than a claim that the current head still reads the endpoint.
|
Added the requested behavioral guard on the current head: the usable top-up confirmation now asserts that it starts no saved-payment-method GET. Local-head Chromium journey passed; commit hooks also passed browser typecheck, formatting, type-aware oxlint, ESLint, and knip. Please re-review. |
dante01yoon
left a comment
There was a problem hiding this comment.
The previous no-read regression-test gap is addressed on 317f1fe670766a974f646e6edba88144ed9878d8. Own frozen install, 221 relevant unit tests, app/browser type checks, the respective OSS production build (plus Cloud for 1.55), changed-file oxlint/ESLint/format, and knip passed. 1 committed OSS production-browser refusal/no-read case passed. Restoring the pre-PR production caller/composable/locales made the committed guard fail with one payment-method GET; restoring this head passed again. Auth, billing, SDK and Stripe were controlled fixtures against the actual production app/local ComfyUI backend; this is not live payment evidence. Production code is unchanged from the prior reviewed head. No new server-owned inference or response-type duplication was introduced.
BLOCKED: current CI is not clean. Check AI Co-Authors failed on this exact head, reporting the trailer in prior commit 1e2a3252c6; running the repository checker locally against the PR range reproduced the failure. The new test commit itself has no trailer. Latest required contexts and their matching-head workflows were checked separately; unfinished runs are not PASS.
Unanchored question: Could you remove the prohibited trailer from the prior PR commit and allow current CI to finish successfully before approval? This concerns commit metadata and CI, so there is no changed source-line anchor. I have not rewritten commits, rerun CI, or resolved the prior review thread. Native Desktop/live accounts/payment and unrelated suites were NOT_RUN for this test-only increment.
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
317f1fe to
a4190cb
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
The prohibited commit trailer is fixed on a4190cb03b0af2c8643eb15a4ff0a29ea3c37bd5. The repository checker against the freshly fetched release-base PR range PASS, and Check AI Co-Authors completed successfully on this exact head. Its entire Git tree eff02d56cdbd983c6d1003453b5ec8106292728e is identical to the previously validated 317f1fe670766a974f646e6edba88144ed9878d8; the change is commit metadata only.
Fresh own verification after an isolated exact-head checkout and frozen install: 221 related unit tests, app/browser types, the respective production build, changed-file type-aware oxlint/ESLint/format, and knip PASS. Browser and patch-removal mutations were NOT_RUN again because no source, test, dependency or layout changed. The prior actual production-browser no-read guard and pre-patch failure/restoration results are retained in the previous strict review as historical evidence, not new executions. Generated response types/server-owned state and the previously reviewed checkout behavior are unchanged.
Approval remains BLOCKED while the current matching-head required unit/E2E workflows finish; pending contexts are not PASS. Native Desktop/live account/payment, other OS/browser, broad accessibility/performance and unrelated suites: NOT_RUN. No source changes, commits, pushes, merges, CI reruns or review-thread resolution were performed.
Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate.