Repository navigation
[backport core/1.55] fix(billing): stop reading saved payment methods in the workspace top-up dialog - #20490
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2154 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d64157960cea3edb2133549cba255befed27bb36
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T01:39:30.408Z",
"gitSha": "58b1a8d6b5ca49e0b74ede785273a2cdcee3038a",
"branch": "christian/backport-20367-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.5909999999712,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.654,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.23600000000005,
"heapDeltaBytes": 11175992,
"heapUsedBytes": 79825656,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.246999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.2020000000539,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.25199999999995,
"heapDeltaBytes": -8278864,
"heapUsedBytes": 60917120,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.867000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.3780000000365,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.628,
"heapDeltaBytes": 9493940,
"heapUsedBytes": 78551960,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 166.02999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.0979999999936,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.499999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.68,
"heapDeltaBytes": 9498756,
"heapUsedBytes": 78301076,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 160.90300000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2930000000024,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.684,
"layouts": 6,
"layoutDurationMs": 1.1039999999999999,
"taskDurationMs": 253.131,
"heapDeltaBytes": 2495572,
"heapUsedBytes": 65373900,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.440000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.8419999999978,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.872,
"layouts": 6,
"layoutDurationMs": 0.982,
"taskDurationMs": 354.50500000000005,
"heapDeltaBytes": 3566496,
"heapUsedBytes": 72368796,
"domNodes": 81,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.915,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 627.5519999999801,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.1090000000001,
"heapDeltaBytes": -7719024,
"heapUsedBytes": 61499576,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 173.701,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.7609999999122,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.812999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.616,
"heapDeltaBytes": -7978324,
"heapUsedBytes": 61145420,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 166.491,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.3389999999758,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 892.296,
"heapDeltaBytes": -18105984,
"heapUsedBytes": 73638700,
"domNodes": -298,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 73.00399999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 536,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1235.7810000000882,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 890.2,
"heapDeltaBytes": 11890360,
"heapUsedBytes": 103948140,
"domNodes": -294,
"jsHeapTotalBytes": 22171648,
"scriptDurationMs": 71.33000000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 603,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.3279999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.65300000000025,
"heapDeltaBytes": 14681632,
"heapUsedBytes": 92230108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.281,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.548000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.2100000000001,
"heapDeltaBytes": 15227584,
"heapUsedBytes": 91020844,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.058,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10723.01299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9838.516,
"heapDeltaBytes": -8480268,
"heapUsedBytes": 72860060,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8266.619,
"eventListeners": 0,
"totalBlockingTimeMs": 1397,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9378.68299999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8557.761,
"heapDeltaBytes": -892084,
"heapUsedBytes": 80485000,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7363.433,
"eventListeners": 0,
"totalBlockingTimeMs": 1003,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10345.463999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9457.213000000002,
"heapDeltaBytes": -660640,
"heapUsedBytes": 80771272,
"domNodes": -12,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7937.755,
"eventListeners": 0,
"totalBlockingTimeMs": 1237,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9986.324999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9115.074999999999,
"heapDeltaBytes": -3221224,
"heapUsedBytes": 72564552,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7620.166,
"eventListeners": 0,
"totalBlockingTimeMs": 996,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2039.68500000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2490000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.8860000000001,
"heapDeltaBytes": -16090628,
"heapUsedBytes": 73595544,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.51599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2038.0930000000035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.4430000000001,
"heapDeltaBytes": 2246440,
"heapUsedBytes": 85375240,
"domNodes": -257,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 29.397,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2216.115000000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.613000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.6100000000001,
"heapDeltaBytes": -24907016,
"heapUsedBytes": 65685004,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 865.669,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2219.1810000000487,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.5370000000003,
"heapDeltaBytes": 31310128,
"heapUsedBytes": 96015132,
"domNodes": 8,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 843.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3552.6630000000523,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.798000000000004,
"layouts": 60,
"layoutDurationMs": 13.573,
"taskDurationMs": 1675.2719999999997,
"heapDeltaBytes": -267556,
"heapUsedBytes": 65444736,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.5,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3513.76700000003,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.040000000000001,
"layouts": 60,
"layoutDurationMs": 13.161,
"taskDurationMs": 1607.525,
"heapDeltaBytes": 967660,
"heapUsedBytes": 66152196,
"domNodes": 34,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 779.43,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3113.226999999995,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.357000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1880.291,
"heapDeltaBytes": 17245872,
"heapUsedBytes": 83368640,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1027.215,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3149.652999999944,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.859,
"heapDeltaBytes": -17921140,
"heapUsedBytes": 75411244,
"domNodes": 14,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 1016.829,
"eventListeners": 180,
"totalBlockingTimeMs": 32,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.4629999999602,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.642000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.391,
"heapDeltaBytes": -23485252,
"heapUsedBytes": 67858588,
"domNodes": -256,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 36.248,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.7950000000592,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.851999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.7929999999999,
"heapDeltaBytes": -23438980,
"heapUsedBytes": 67688144,
"domNodes": -256,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 39.635,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.4960000000242,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.059999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.96799999999996,
"heapDeltaBytes": 12897024,
"heapUsedBytes": 84039440,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.495,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.359000000054,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.19399999999996,
"heapDeltaBytes": 13147704,
"heapUsedBytes": 84047620,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.495,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.9280000000203,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.455000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.47,
"heapDeltaBytes": -5536604,
"heapUsedBytes": 64721888,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.171999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.3570000000173,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.80899999999997,
"heapDeltaBytes": 8427172,
"heapUsedBytes": 78629920,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.432000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.5339999999765,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.801,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.8480000000001,
"heapDeltaBytes": -3101820,
"heapUsedBytes": 68031384,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 106.727,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2340000000986,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 748.9540000000001,
"heapDeltaBytes": -10619848,
"heapUsedBytes": 60607756,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 107.382,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.62099999994,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.542000000000005,
"layouts": 5,
"layoutDurationMs": 12.709000000000001,
"taskDurationMs": 907.0899999999999,
"heapDeltaBytes": -6305752,
"heapUsedBytes": 83667952,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.954,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8274.511000000019,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.422999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5502.929,
"heapDeltaBytes": -1387936,
"heapUsedBytes": 88092972,
"domNodes": -243,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2803.459,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8309.127999999986,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.961999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5586.650000000001,
"heapDeltaBytes": -4726936,
"heapUsedBytes": 84921888,
"domNodes": -252,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 2837.895,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16863.518999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16462.001,
"heapDeltaBytes": -43241764,
"heapUsedBytes": 172130240,
"domNodes": -8061,
"jsHeapTotalBytes": -13754368,
"scriptDurationMs": 268.10699999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16857.943999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16579.642999999996,
"heapDeltaBytes": -49576668,
"heapUsedBytes": 178627836,
"domNodes": -8061,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 261.533,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20621.659999999963,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.611999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20270.726,
"heapDeltaBytes": -59886464,
"heapUsedBytes": 181325400,
"domNodes": -8061,
"jsHeapTotalBytes": -19075072,
"scriptDurationMs": 888.4499999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20547.900000000027,
"styleRecalcs": 144,
"styleRecalcDurationMs": 18.31499999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20352.899999999998,
"heapDeltaBytes": -70749704,
"heapUsedBytes": 170169884,
"domNodes": -8061,
"jsHeapTotalBytes": -19075072,
"scriptDurationMs": 905.3109999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6139.784000000077,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.309,
"layouts": 20,
"layoutDurationMs": 23.447999999999997,
"taskDurationMs": 6022.275,
"heapDeltaBytes": -45558100,
"heapUsedBytes": 195486396,
"domNodes": -8061,
"jsHeapTotalBytes": 11333632,
"scriptDurationMs": 106.887,
"eventListeners": -14928,
"totalBlockingTimeMs": 362,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4984.573999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.21000000000001,
"layouts": 20,
"layoutDurationMs": 28.641,
"taskDurationMs": 4934.14,
"heapDeltaBytes": -36815428,
"heapUsedBytes": 197597020,
"domNodes": -8091,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 100.7,
"eventListeners": -14944,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8526.71100000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8283.501,
"heapDeltaBytes": 21133372,
"heapUsedBytes": 180076304,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 154.78099999999995,
"eventListeners": -20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8513.813000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8326.704,
"heapDeltaBytes": -20830356,
"heapUsedBytes": 169905344,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 153.825,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.75600000002851,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.482999999999999,
"layouts": 2,
"layoutDurationMs": 0.7049999999999998,
"taskDurationMs": 90.076,
"heapDeltaBytes": 3199064,
"heapUsedBytes": 70070204,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.8,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 122.70399999999881,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.152000000000005,
"layouts": 4,
"layoutDurationMs": 2.137,
"taskDurationMs": 88.57199999999999,
"heapDeltaBytes": 3074096,
"heapUsedBytes": 69448048,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.133000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes for one regression-safety-net gap (Gate 1), anchored on the retained refusal test. The current removal behaves correctly in direct validation; the existing tests do not protect its stated no-read guarantee.
Exact 72b8231820ed3556381339072477dcbdf2f34dc8, isolated checkout and own frozen install:
- PASS: 276 unit tests/6 files, app/browser types, release-distribution production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Unit ESLint is ignored by config and NOT_RUN.
- PASS: 7 OSS production browser checks and 1 independent Cloud SDK journey passed; additional Cloud build passed. Auth/billing/feature flags and payment responses are controlled; the bundle is real production output served by an isolated local ComfyUI backend. These are not live charges.
- RED: pre-patch production restored -> independent component guard 1 failed/37 passed; production browser no-read guard failed. Original source/output restored -> component suite 37 passed and corresponding browser guard passed. All changed/deleted files match the exact head; checkout clean.
- Contract/code review: no new response declarations or frontend-derived server facts; existing generated response types and purchase/recovery code remain authoritative and unchanged. Graph/extension callbacks are untouched.
CI results were queried separately at this head; in-progress workflows are not own PASS and do not settle the safety-net gap. NOT_RUN: live customer/payment/Stripe, native Desktop, other OS/browser, broad performance and unrelated suites. Initial Cloud use of the local-only workspace fixture failed before app readiness; the Cloud fixture then passed. Initial SDK probe omitted unified-auth/server flag prerequisites and stayed on XHR; corrected fixtures proved actual SDK fetch and were mutation-checked. No source changes, reruns, thread resolution or merge were performed.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #20490 +/- ##
============================================
Coverage 84.92% 84.92%
============================================
Files 2345 2346 +1
Lines 133938 134004 +66
Branches 35772 33921 -1851
============================================
+ Hits 113747 113808 +61
- Misses 19828 19834 +6
+ Partials 363 362 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Added the requested behavioral guard on the current head: the retained refusal journey asserts no saved-payment GET, and Cloud parity now covers usable legacy-XHR and SDK-fetch confirmations. Local-head results: 1 Chromium refusal journey + both Cloud rail rows passed; commit hooks passed browser typecheck, formatting, type-aware oxlint, ESLint, and knip. Please re-review. |
dante01yoon
left a comment
There was a problem hiding this comment.
The previous no-read regression-test gap is addressed on e9dc9b812f68c03ab9fca872184643bd867e3650. Own frozen install, 276 relevant unit tests, app/browser type checks, the respective OSS production build (plus Cloud for 1.55), changed-file oxlint/ESLint/format, and knip passed. 9 production-browser cases passed: the committed OSS refusal/no-read guard plus all 8 Cloud billing-parity cases. Restoring the pre-PR production caller/composable/locales made the new legacy and SDK guards fail (2 failures, one payment-method GET each) and the OSS guard fail (1 failure). Restoring this head passed the two Cloud guards and OSS guard again. Auth, billing, SDK and Stripe were controlled fixtures against the actual production app/local ComfyUI backend; this is not live payment evidence. Production code is unchanged from the prior reviewed head. No new server-owned inference or response-type duplication was introduced.
BLOCKED: current CI is not clean. Check AI Co-Authors failed on this exact head, reporting the trailer in prior commit 72b8231820; running the repository checker locally against the PR range reproduced the failure. The new test commit itself has no trailer. Latest required contexts and their matching-head workflows were checked separately; unfinished runs are not PASS.
Unanchored question: Could you remove the prohibited trailer from the prior PR commit and allow current CI to finish successfully before approval? This concerns commit metadata and CI, so there is no changed source-line anchor. I have not rewritten commits, rerun CI, or resolved the prior review thread. Native Desktop/live accounts/payment and unrelated suites were NOT_RUN for this test-only increment.
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
e9dc9b8 to
6d492a3
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
The prohibited commit trailer is fixed on 6d492a333b4bdad0eb7cc2de0e8abb73ef1247b5. The repository checker against the freshly fetched release-base PR range PASS, and Check AI Co-Authors completed successfully on this exact head. Its entire Git tree 14e7fc498c50565cb7f982529d1e06b5920f6b61 is identical to the previously validated e9dc9b812f68c03ab9fca872184643bd867e3650; the change is commit metadata only.
Fresh own verification after an isolated exact-head checkout and frozen install: 276 related unit tests, app/browser types, the respective production build, changed-file type-aware oxlint/ESLint/format, and knip PASS. Browser and patch-removal mutations were NOT_RUN again because no source, test, dependency or layout changed. The prior actual production-browser no-read guard and pre-patch failure/restoration results are retained in the previous strict review as historical evidence, not new executions. Generated response types/server-owned state and the previously reviewed checkout behavior are unchanged.
Approval remains BLOCKED while the current matching-head required unit/E2E workflows finish; pending contexts are not PASS. Native Desktop/live account/payment, other OS/browser, broad accessibility/performance and unrelated suites: NOT_RUN. No source changes, commits, pushes, merges, CI reruns or review-thread resolution were performed.
Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate.