Repository navigation
[backport cloud/1.55] fix(billing): stop reading saved payment methods in the workspace top-up dialog - #20491
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2154 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9e1dbe03b7b08207d9e8c3bfe94e5816c47300c6
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-08T01:37:39.501Z",
"gitSha": "161d815fad1bfb7944c76ddabd9ef181e04d8c55",
"branch": "christian/backport-20367-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.0020000000468,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.515999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.11800000000005,
"heapDeltaBytes": -10391100,
"heapUsedBytes": 59139848,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.883,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.6209999999855,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.043000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.66800000000006,
"heapDeltaBytes": 10922140,
"heapUsedBytes": 79994312,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.989,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.7059999999965,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.973,
"heapDeltaBytes": -5888516,
"heapUsedBytes": 57142936,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 119.777,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.991000000059,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.778,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.5600000000001,
"heapDeltaBytes": -8208980,
"heapUsedBytes": 61095476,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 124.954,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.467999999949,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.423,
"layouts": 6,
"layoutDurationMs": 1.1360000000000001,
"taskDurationMs": 302.299,
"heapDeltaBytes": 3555516,
"heapUsedBytes": 72544832,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.264,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.9380000000265,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.352,
"layouts": 6,
"layoutDurationMs": 1.016,
"taskDurationMs": 283.088,
"heapDeltaBytes": 3646576,
"heapUsedBytes": 72781704,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.781,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 548.8179999999829,
"styleRecalcs": 15,
"styleRecalcDurationMs": 6.752999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.248,
"heapDeltaBytes": 18389008,
"heapUsedBytes": 81341412,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 125.83800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 559.654999999907,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.456,
"heapDeltaBytes": -7779392,
"heapUsedBytes": 61576960,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 135.894,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1115.4249999999593,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.542,
"heapDeltaBytes": 9841344,
"heapUsedBytes": 102191768,
"domNodes": -297,
"jsHeapTotalBytes": 25841664,
"scriptDurationMs": 46.30000000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 484,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.2629999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.1370000000001,
"heapDeltaBytes": 28160312,
"heapUsedBytes": 99608548,
"domNodes": -291,
"jsHeapTotalBytes": 18239488,
"scriptDurationMs": 50.07700000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 532,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 747.4909999999682,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.9840000000002,
"heapDeltaBytes": 15702900,
"heapUsedBytes": 91835544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.13999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.9189999999207,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.30000000000007,
"heapDeltaBytes": 14919852,
"heapUsedBytes": 90872120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.25800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7337.476999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6447.361000000001,
"heapDeltaBytes": 11068296,
"heapUsedBytes": 93028292,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5200.454,
"eventListeners": 0,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6733.090000000061,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.6759999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6092.954,
"heapDeltaBytes": -7693420,
"heapUsedBytes": 71965272,
"domNodes": -259,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 5003.326,
"eventListeners": -152,
"totalBlockingTimeMs": 10,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7476.990000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05099999999999896,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6609.147999999999,
"heapDeltaBytes": 1812668,
"heapUsedBytes": 83437636,
"domNodes": -18,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 5378.594000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 144,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7715.655000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6939.108,
"heapDeltaBytes": -6653328,
"heapUsedBytes": 69175484,
"domNodes": -10,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5575.254999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 73,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2022.2140000000763,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.53099999999995,
"heapDeltaBytes": -22988972,
"heapUsedBytes": 67151932,
"domNodes": -249,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 25.438000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.9310000000805,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.909000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.51900000000006,
"heapDeltaBytes": -16630472,
"heapUsedBytes": 73152744,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.996000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2134.1979999999694,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.282000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1141.974,
"heapDeltaBytes": -24473000,
"heapUsedBytes": 66167176,
"domNodes": -212,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 622.348,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.851000000027,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.722,
"heapDeltaBytes": -2186656,
"heapUsedBytes": 88751824,
"domNodes": -256,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 658.0780000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3224.3670000000293,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.139000000000001,
"layouts": 60,
"layoutDurationMs": 10.456,
"taskDurationMs": 1377.0570000000002,
"heapDeltaBytes": -11131584,
"heapUsedBytes": 73868988,
"domNodes": -239,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 603.2330000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3251.9230000000334,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.082,
"layouts": 60,
"layoutDurationMs": 11.833,
"taskDurationMs": 1425.922,
"heapDeltaBytes": -9023204,
"heapUsedBytes": 76694628,
"domNodes": -240,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 614.0980000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2324.8270000000275,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.134999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1402.7930000000001,
"heapDeltaBytes": 3648764,
"heapUsedBytes": 70057620,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 717.816,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2232.323000000065,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1472.9930000000002,
"heapDeltaBytes": 4345412,
"heapUsedBytes": 70309908,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.162,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2000.128000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.05,
"heapDeltaBytes": -23733172,
"heapUsedBytes": 68047468,
"domNodes": -253,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 32.607000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.8900000000285,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.63299999999987,
"heapDeltaBytes": -23120620,
"heapUsedBytes": 68890424,
"domNodes": -251,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 25.521,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.6499999999805,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.528999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.353,
"heapDeltaBytes": 13450900,
"heapUsedBytes": 84518048,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 113.44299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.1949999999533,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.368000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.751,
"heapDeltaBytes": 12792200,
"heapUsedBytes": 77345096,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 104.75699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.7179999999353,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.863000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.4630000000001,
"heapDeltaBytes": 9376764,
"heapUsedBytes": 80249372,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.536000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1992.0570000000453,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.06800000000004,
"heapDeltaBytes": -2625920,
"heapUsedBytes": 68822320,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.446,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.1650000000263,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.270000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.407,
"heapDeltaBytes": -6418344,
"heapUsedBytes": 64846580,
"domNodes": -271,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 71.20499999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.742000000043,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.1589999999999,
"heapDeltaBytes": 5481544,
"heapUsedBytes": 76352596,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 78.264,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.5540000000346,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.252000000000002,
"layouts": 5,
"layoutDurationMs": 9.702,
"taskDurationMs": 771.854,
"heapDeltaBytes": -6336876,
"heapUsedBytes": 82252496,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 22.325000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.0669999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.306000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4533.902999999999,
"heapDeltaBytes": 2372768,
"heapUsedBytes": 92475096,
"domNodes": -214,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2168.0139999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8159.066999999936,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4397.302999999999,
"heapDeltaBytes": -2469624,
"heapUsedBytes": 80806160,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 2102.716,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13458.044000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12658.366000000002,
"heapDeltaBytes": -23313564,
"heapUsedBytes": 197213172,
"domNodes": -8061,
"jsHeapTotalBytes": -18731008,
"scriptDurationMs": 201.84099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12054.322999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10998.541,
"heapDeltaBytes": -68415972,
"heapUsedBytes": 172891276,
"domNodes": -8062,
"jsHeapTotalBytes": -16977920,
"scriptDurationMs": 130.257,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16924.92400000003,
"styleRecalcs": 127,
"styleRecalcDurationMs": 16.192999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16435.81,
"heapDeltaBytes": -61298836,
"heapUsedBytes": 180132312,
"domNodes": -8062,
"jsHeapTotalBytes": -18812928,
"scriptDurationMs": 837.702,
"eventListeners": -14928,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14550.416000000041,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.883000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13701.496,
"heapDeltaBytes": -57376548,
"heapUsedBytes": 182728816,
"domNodes": -8062,
"jsHeapTotalBytes": -17195008,
"scriptDurationMs": 606.244,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3596.5360000000146,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.90599999999999,
"layouts": 20,
"layoutDurationMs": 21.416000000000004,
"taskDurationMs": 3501.9590000000003,
"heapDeltaBytes": -49456152,
"heapUsedBytes": 178277684,
"domNodes": -8062,
"jsHeapTotalBytes": 6352896,
"scriptDurationMs": 66.79,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4329.703999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.04599999999999,
"layouts": 20,
"layoutDurationMs": 18.941,
"taskDurationMs": 4159.156999999999,
"heapDeltaBytes": -65172760,
"heapUsedBytes": 176177792,
"domNodes": -8062,
"jsHeapTotalBytes": 13168640,
"scriptDurationMs": 59.471999999999994,
"eventListeners": -14927,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6972.580999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6494.212999999999,
"heapDeltaBytes": 8002272,
"heapUsedBytes": 178096908,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 99.72999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6163.128000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5566.859000000001,
"heapDeltaBytes": 15758384,
"heapUsedBytes": 202967200,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 63.892,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.7029999999577,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.417,
"layouts": 6,
"layoutDurationMs": 2.859,
"taskDurationMs": 140.902,
"heapDeltaBytes": 5406548,
"heapUsedBytes": 72308860,
"domNodes": 155,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.179999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 437.9300000000512,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.061,
"layouts": 3,
"layoutDurationMs": 0.745,
"taskDurationMs": 93.92499999999998,
"heapDeltaBytes": 5019952,
"heapUsedBytes": 72004992,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.687000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes for one regression-safety-net gap (Gate 1), anchored on the retained refusal test. The current removal behaves correctly in direct validation; the existing tests do not protect its stated no-read guarantee.
Exact f7d67a0733a9c490a93767cdaee143ff000dcdcc, isolated checkout and own frozen install:
- PASS: 289 unit tests/6 files, app/browser types, release-distribution production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Unit ESLint is ignored by config and NOT_RUN.
- PASS: 6 existing Cloud parity journeys plus independent legacy and SDK journeys passed. Auth/billing/feature flags and payment responses are controlled; the bundle is real production output served by an isolated local ComfyUI backend. These are not live charges.
- RED: pre-patch production restored -> independent component guard 1 failed/42 passed; production browser no-read guard failed. Original source/output restored -> component suite 42 passed and corresponding browser guard passed. All changed/deleted files match the exact head; checkout clean.
- Contract/code review: no new response declarations or frontend-derived server facts; existing generated response types and purchase/recovery code remain authoritative and unchanged. Graph/extension callbacks are untouched.
CI results were queried separately at this head; in-progress workflows are not own PASS and do not settle the safety-net gap. NOT_RUN: live customer/payment/Stripe, native Desktop, other OS/browser, broad performance and unrelated suites. Initial Cloud use of the local-only workspace fixture failed before app readiness; the Cloud fixture then passed. Initial SDK probe omitted unified-auth/server flag prerequisites and stayed on XHR; corrected fixtures proved actual SDK fetch and were mutation-checked. No source changes, reruns, thread resolution or merge were performed.
| test('offers Manage billing and explains a refused purchase', async ({ | ||
| comfyPage | ||
| }) => { | ||
| test('explains a refused purchase', async ({ comfyPage }) => { |
There was a problem hiding this comment.
issue: The modified refusal test still passes if the removed saved-payment lookup is reintroduced. In this isolated head I restored the pre-PR component and lookup: all 42 existing component tests stayed green. An independent guard passed with the patch (43 tests), then failed only its no-read assertion without it (1 failed/42 passed), observing one listSavedPaymentMethods call; an actual production-browser probe likewise caught the payment-method GET. For 1.55 I also exercised legacy XHR and SDK fetch on actual production bundles: the pre-patch lookup sends one payment-method GET on each rail and the restored head sends none. Could we keep one behavioral regression proving that a usable confirmation dialog no longer starts this lookup (legacy and SDK rows on 1.55)? The obsolete note/portal tests can remain removed. This is a missing safety net for the PR's stated behavior, rather than a claim that the current head still reads the endpoint.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20491 +/- ##
=============================================
Coverage ? 85.02%
=============================================
Files ? 2346
Lines ? 134644
Branches ? 36323
=============================================
Hits ? 114485
Misses ? 19797
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Added the requested behavioral guard on the current head: the retained refusal journey asserts no saved-payment GET, and Cloud parity now covers usable legacy-XHR and SDK-fetch confirmations. The identical core/1.55 local-head runs passed all three rows; this cloud branch also passed commit-time checks. Please re-review. |
dante01yoon
left a comment
There was a problem hiding this comment.
The previous no-read regression-test gap is addressed on 7caa1c807e68be1ad6dbb1198ea64ab04bcfa074. Own frozen install, 289 relevant unit tests, app/browser type checks, Cloud and OSS production builds, changed-file oxlint/ESLint/format, and knip passed. 9 production-browser cases passed: the committed OSS refusal/no-read guard plus all 8 Cloud billing-parity cases. Restoring the pre-PR production caller/composable/locales made the new legacy and SDK guards fail (2 failures, one payment-method GET each) and the OSS guard fail (1 failure). Restoring this head passed the two Cloud guards and OSS guard again. Auth, billing, SDK and Stripe were controlled fixtures against the actual production app/local ComfyUI backend; this is not live payment evidence. Production code is unchanged from the prior reviewed head. No new server-owned inference or response-type duplication was introduced.
BLOCKED: current CI is not clean. Check AI Co-Authors failed on this exact head, reporting the trailer in prior commit f7d67a0733; running the repository checker locally against the PR range reproduced the failure. The new test commit itself has no trailer. Latest required contexts and their matching-head workflows were checked separately; unfinished runs are not PASS.
Unanchored question: Could you remove the prohibited trailer from the prior PR commit and allow current CI to finish successfully before approval? This concerns commit metadata and CI, so there is no changed source-line anchor. I have not rewritten commits, rerun CI, or resolved the prior review thread. Native Desktop/live accounts/payment and unrelated suites were NOT_RUN for this test-only increment.
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
7caa1c8 to
c78bf4b
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
The prohibited commit trailer is fixed on c78bf4bd47c31950e0f12c95ee3bb2643247d412. The repository checker against the freshly fetched release-base PR range PASS, and Check AI Co-Authors completed successfully on this exact head. Its entire Git tree e26b7d55da98bfba9c57ebc2b97d3fd9587f021c is identical to the previously validated 7caa1c807e68be1ad6dbb1198ea64ab04bcfa074; the change is commit metadata only.
Fresh own verification after an isolated exact-head checkout and frozen install: 289 related unit tests, app/browser types, the respective production build, changed-file type-aware oxlint/ESLint/format, and knip PASS. Browser and patch-removal mutations were NOT_RUN again because no source, test, dependency or layout changed. The prior actual production-browser no-read guard and pre-patch failure/restoration results are retained in the previous strict review as historical evidence, not new executions. Generated response types/server-owned state and the previously reviewed checkout behavior are unchanged.
Approval remains BLOCKED while the current matching-head required unit/E2E workflows finish; pending contexts are not PASS. Native Desktop/live account/payment, other OS/browser, broad accessibility/performance and unrelated suites: NOT_RUN. No source changes, commits, pushes, merges, CI reruns or review-thread resolution were performed.
Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate.