Skip to content

[backport cloud/1.54] fix(billing): stop reading saved payment methods in the workspace top-up dialog - #20489

Merged
christian-byrne merged 2 commits into
cloud/1.54from
christian/backport-20367-cloud-1.54
Oct 8, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
christian/backport-20367-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual recovery for #20367 after the automated backport conflicted with release-line billing and test changes.\n\nPreserves the release branch checkout implementation while removing the retired saved-payment-method read, note, billing-portal link, composable, and obsolete tests. No exposure or feature flag changes.\n\nValidation: conflict resolution audited against the release branch; diff check clean; no remaining source reference to the deleted composable. CI is the final gate.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 7, 2026
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 8, 2026 1:25am UTC
billing-web-test Ignored Ignored Oct 8, 2026 1:25am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: dc932456-d819-4aa1-a8d3-75515c8ef03c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne enabled auto-merge (squash) October 7, 2026 23:51
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 01:26:56 AM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 122ms TBT · 99.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 45ms TBT · 166.9 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 150ms TBT · 172.0 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 422ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.5 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 728ms
canvas-mouse-sweep: script duration 115ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 299ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 75.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 354ms
dom-widget-clipping: script duration 123ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 74.0 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 490ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.8 MB
large-graph-idle: DOM nodes -279
large-graph-idle: event listeners -191
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1207ms
large-graph-pan: script duration 589ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.1 MB
large-graph-pan: DOM nodes -137
large-graph-pan: event listeners -92
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1369ms
large-graph-zoom: script duration 579ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.5 MB
large-graph-zoom: DOM nodes -263
large-graph-zoom: event listeners -196
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1496ms
legacy-node-drag: script duration 755ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.9 MB
legacy-node-drag: DOM nodes 7
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 503ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.5 MB
minimap-idle: DOM nodes -285
minimap-idle: event listeners -191
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 325ms
subgraph-dom-widget-clipping: script duration 105ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 85.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 423ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.7 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 20ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 635ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.8 MB
subgraph-mouse-sweep: DOM nodes -128
subgraph-mouse-sweep: event listeners -103
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 739ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 122ms
subgraph-transition-enter: heap used 99.0 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 26ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 4381ms
viewport-pan-sweep: script duration 2042ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.5 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12026ms
vue-large-graph-idle: script duration 212ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 80
vue-large-graph-pan: task duration 14803ms
vue-large-graph-pan: script duration 749ms
vue-large-graph-pan: TBT 45ms
vue-large-graph-pan: heap used 166.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 68ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4415ms
vue-node-resize-workload: script duration 104ms
vue-node-resize-workload: TBT 150ms
vue-node-resize-workload: heap used 172.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5817ms
vue-zoom-out-idle: script duration 99ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 77ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.3 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-10-08T01:35:33.440Z",
  "gitSha": "a51f1781e5eaa316a20f54196353f2e7240d81d6",
  "branch": "christian/backport-20367-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.84200000003,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.078000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.56399999999996,
      "heapDeltaBytes": -5009908,
      "heapUsedBytes": 68252664,
      "domNodes": -282,
      "jsHeapTotalBytes": 2916352,
      "scriptDurationMs": 7.014999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.155000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.153,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.65999999999997,
      "heapDeltaBytes": -13029452,
      "heapUsedBytes": 60659104,
      "domNodes": -282,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 7.351,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1768.2189999999878,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 19.803,
      "layouts": 14,
      "layoutDurationMs": 2.847,
      "taskDurationMs": 784.948,
      "heapDeltaBytes": -10679356,
      "heapUsedBytes": 62459052,
      "domNodes": -285,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 122.84899999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1737.858000000017,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 19.078,
      "layouts": 14,
      "layoutDurationMs": 2.726,
      "taskDurationMs": 670.9300000000001,
      "heapDeltaBytes": 3382132,
      "heapUsedBytes": 77395512,
      "domNodes": -277,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 106.899,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1668.061000000023,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 11.229999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.029,
      "taskDurationMs": 290.791,
      "heapDeltaBytes": 4938596,
      "heapUsedBytes": 79146652,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.161000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.3700000000026,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.385000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1740000000000002,
      "taskDurationMs": 306.378,
      "heapDeltaBytes": 4934000,
      "heapUsedBytes": 78955980,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.617999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 541.3790000000063,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.892,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.693,
      "heapDeltaBytes": -7452312,
      "heapUsedBytes": 66488212,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 122.72300000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 531.8780000000061,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 5.207,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.997,
      "heapDeltaBytes": 17877204,
      "heapUsedBytes": 88775928,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 123.33,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.2470000000162,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.724000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.3040000000001,
      "heapDeltaBytes": -7737620,
      "heapUsedBytes": 72562976,
      "domNodes": -275,
      "jsHeapTotalBytes": -753664,
      "scriptDurationMs": 29.359,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.8680000000068,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.6869999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.566,
      "heapDeltaBytes": 15305196,
      "heapUsedBytes": 92619068,
      "domNodes": -283,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 26.411000000000005,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2111.081000000013,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 8.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1222.9679999999998,
      "heapDeltaBytes": 9170744,
      "heapUsedBytes": 90451516,
      "domNodes": -276,
      "jsHeapTotalBytes": -266240,
      "scriptDurationMs": 584.09,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2091.1389999999983,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 6.631999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1190.217,
      "heapDeltaBytes": 592784,
      "heapUsedBytes": 67041992,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 594.1769999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3169.5080000000075,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.711000000000002,
      "layouts": 60,
      "layoutDurationMs": 10.046000000000001,
      "taskDurationMs": 1358.266,
      "heapDeltaBytes": -10070748,
      "heapUsedBytes": 69750400,
      "domNodes": -262,
      "jsHeapTotalBytes": 3301376,
      "scriptDurationMs": 575.0690000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3222.555,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.846000000000002,
      "layouts": 60,
      "layoutDurationMs": 10.825,
      "taskDurationMs": 1379.238,
      "heapDeltaBytes": -6065488,
      "heapUsedBytes": 76074204,
      "domNodes": -264,
      "jsHeapTotalBytes": 3178496,
      "scriptDurationMs": 583.223,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2390.152999999998,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 4.7890000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1527.911,
      "heapDeltaBytes": 3804352,
      "heapUsedBytes": 71148608,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 781.83,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2459.4809999999825,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.919000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1463.8410000000001,
      "heapDeltaBytes": 14354988,
      "heapUsedBytes": 96509160,
      "domNodes": 10,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 727.629,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.5169999999653,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.792,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.58,
      "heapDeltaBytes": -13500512,
      "heapUsedBytes": 66215248,
      "domNodes": -284,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 28.837999999999994,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.4150000000327,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.849,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.47200000000015,
      "heapDeltaBytes": 12660700,
      "heapUsedBytes": 92187080,
      "domNodes": -285,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 28.718000000000007,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 522.5360000000023,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.776999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.558,
      "heapDeltaBytes": 14079308,
      "heapUsedBytes": 89539872,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 101.2,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 534.5190000000457,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.747000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.73900000000003,
      "heapDeltaBytes": 14918396,
      "heapUsedBytes": 88669680,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 108.67999999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.8109999999847,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.530000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.753,
      "heapDeltaBytes": -748608,
      "heapUsedBytes": 72847396,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.0969999999999995,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.8220000000097,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.460999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.078,
      "heapDeltaBytes": -4820508,
      "heapUsedBytes": 71269876,
      "domNodes": -296,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 7.246,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.167999999997,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 21.264,
      "layouts": 18,
      "layoutDurationMs": 3.367,
      "taskDurationMs": 664.6310000000001,
      "heapDeltaBytes": -14051064,
      "heapUsedBytes": 61433904,
      "domNodes": -290,
      "jsHeapTotalBytes": 5013504,
      "scriptDurationMs": 76.364,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.203999999961,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.797,
      "layouts": 18,
      "layoutDurationMs": 3.2830000000000004,
      "taskDurationMs": 605.467,
      "heapDeltaBytes": -3855872,
      "heapUsedBytes": 72442856,
      "domNodes": 34,
      "jsHeapTotalBytes": 17301504,
      "scriptDurationMs": 74.862,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 933.2309999999779,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 27.497,
      "layouts": 16,
      "layoutDurationMs": 11.014,
      "taskDurationMs": 738.5120000000001,
      "heapDeltaBytes": 20219900,
      "heapUsedBytes": 103784284,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 21.8,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 122,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8180.067999999948,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 25.637,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4482.755,
      "heapDeltaBytes": 15951792,
      "heapUsedBytes": 96869136,
      "domNodes": -280,
      "jsHeapTotalBytes": -790528,
      "scriptDurationMs": 2113.041,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8134.4400000000405,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 25.369999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4279.28,
      "heapDeltaBytes": -12527784,
      "heapUsedBytes": 67718356,
      "domNodes": -267,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 1970.4440000000002,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12717.893000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11857.917000000001,
      "heapDeltaBytes": -49731452,
      "heapUsedBytes": 179071196,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20361216,
      "scriptDurationMs": 194.36999999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12884.648999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12194.194000000001,
      "heapDeltaBytes": -33522564,
      "heapUsedBytes": 178188472,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17506304,
      "scriptDurationMs": 229.939,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15060.653999999999,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.696000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14481.806000000002,
      "heapDeltaBytes": -26479616,
      "heapUsedBytes": 180224328,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10207232,
      "scriptDurationMs": 779.089,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15766.489999999976,
      "styleRecalcs": 88,
      "styleRecalcDurationMs": 13.609999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15124.402999999998,
      "heapDeltaBytes": -41916940,
      "heapUsedBytes": 169825660,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16719872,
      "scriptDurationMs": 719.422,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4741.080000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.80999999999999,
      "layouts": 20,
      "layoutDurationMs": 20.898,
      "taskDurationMs": 4261.824,
      "heapDeltaBytes": -50897260,
      "heapUsedBytes": 177675568,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6873088,
      "scriptDurationMs": 123.96300000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 117,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4724.2259999999305,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.52200000000003,
      "layouts": 20,
      "layoutDurationMs": 22.066000000000003,
      "taskDurationMs": 4567.400999999999,
      "heapDeltaBytes": -41189516,
      "heapUsedBytes": 183092480,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10420224,
      "scriptDurationMs": 84.734,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 182,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6347.687000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5940.275999999999,
      "heapDeltaBytes": -3368728,
      "heapUsedBytes": 177064584,
      "domNodes": 0,
      "jsHeapTotalBytes": -33292288,
      "scriptDurationMs": 110.055,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6145.96199999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5694.530000000001,
      "heapDeltaBytes": 897680,
      "heapUsedBytes": 178828672,
      "domNodes": 0,
      "jsHeapTotalBytes": -18350080,
      "scriptDurationMs": 87.87900000000005,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 73.65299999997887,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.126,
      "layouts": 3,
      "layoutDurationMs": 1.5330000000000001,
      "taskDurationMs": 56.172,
      "heapDeltaBytes": 3068072,
      "heapUsedBytes": 72845104,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.151999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 445.1370000000452,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 17.593999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.431,
      "taskDurationMs": 97.071,
      "heapDeltaBytes": 4983784,
      "heapUsedBytes": 74578852,
      "domNodes": 146,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.011000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51176 76659 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one regression-safety-net gap (Gate 1), anchored on the retained refusal test. The current removal behaves correctly in direct validation; the existing tests do not protect its stated no-read guarantee.

Exact dfd9100dfcd92a3211ce470d80c235b4416fc9b6, isolated checkout and own frozen install:

  • PASS: 234 unit tests/5 files, app/browser types, release-distribution production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Unit ESLint is ignored by config and NOT_RUN.
  • PASS: 1 Cloud production journey passed: unchanged $50 request and actionable refusal without a payment-method GET. Auth/billing/feature flags and payment responses are controlled; the bundle is real production output served by an isolated local ComfyUI backend. These are not live charges.
  • RED: pre-patch production restored -> independent component guard 1 failed/36 passed; production browser no-read guard failed. Original source/output restored -> component suite 36 passed and corresponding browser guard passed. All changed/deleted files match the exact head; checkout clean.
  • Contract/code review: no new response declarations or frontend-derived server facts; existing generated response types and purchase/recovery code remain authoritative and unchanged. Graph/extension callbacks are untouched.

CI results were queried separately at this head; in-progress workflows are not own PASS and do not settle the safety-net gap. NOT_RUN: live customer/payment/Stripe, native Desktop, other OS/browser, broad performance and unrelated suites. Initial Cloud use of the local-only workspace fixture failed before app readiness; the Cloud fixture then passed. Initial SDK probe omitted unified-auth/server flag prerequisites and stayed on XHR; corrected fixtures proved actual SDK fetch and were mutation-checked. No source changes, reruns, thread resolution or merge were performed.

test('offers Manage billing and explains a refused purchase', async ({
comfyPage
}) => {
test('explains a refused purchase', async ({ comfyPage }) => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: The modified refusal test still passes if the removed saved-payment lookup is reintroduced. In this isolated head I restored the pre-PR component and lookup: all 36 existing component tests stayed green. An independent guard passed with the patch (37 tests), then failed only its no-read assertion without it (1 failed/36 passed), observing one listSavedPaymentMethods call; an actual production-browser probe likewise caught the payment-method GET. Could we keep one behavioral regression proving that a usable confirmation dialog no longer starts this lookup (legacy and SDK rows on 1.55)? The obsolete note/portal tests can remain removed. This is a missing safety net for the PR's stated behavior, rather than a claim that the current head still reads the endpoint.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20489   +/-   ##
=============================================
  Coverage              ?   84.19%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128640           
  Branches              ?    32763           
=============================================
  Hits                  ?   108304           
  Misses                ?    20156           
  Partials              ?      180           
Flag Coverage Δ
e2e 66.76% <0.00%> (?)
unit 79.65% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../components/TopUpCreditsDialogContentWorkspace.vue 86.77% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
github-actions Bot requested a review from thedatalife October 8, 2026 00:42
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Added the requested behavioral guard on the current head: the usable top-up confirmation now asserts that it starts no saved-payment-method GET. The identical core/1.54 local-head Chromium journey passed; this cloud branch also passed commit-time checks. Please re-review.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous no-read regression-test gap is addressed on cb3cf486acbf2430b702c2328508b0e0e272066e. Own frozen install, 234 relevant unit tests, app/browser type checks, Cloud and OSS production builds, changed-file oxlint/ESLint/format, and knip passed. 2 production-browser cases passed: the committed OSS refusal/no-read guard and an independent Cloud checkout/refusal journey. Restoring the pre-PR production caller/composable/locales made the committed guard fail with one payment-method GET; restoring this head passed again. Auth, billing, SDK and Stripe were controlled fixtures against the actual production app/local ComfyUI backend; this is not live payment evidence. Production code is unchanged from the prior reviewed head. No new server-owned inference or response-type duplication was introduced.

BLOCKED: current CI is not clean. Check AI Co-Authors failed on this exact head, reporting the trailer in prior commit dfd9100dfc; running the repository checker locally against the PR range reproduced the failure. The new test commit itself has no trailer. Latest required contexts and their matching-head workflows were checked separately; unfinished runs are not PASS.

Unanchored question: Could you remove the prohibited trailer from the prior PR commit and allow current CI to finish successfully before approval? This concerns commit metadata and CI, so there is no changed source-line anchor. I have not rewritten commits, rerun CI, or resolved the prior review thread. Native Desktop/live accounts/payment and unrelated suites were NOT_RUN for this test-only increment.

dante01yoon and others added 2 commits October 7, 2026 18:24
…-up dialog (#20367)

The workspace top-up dialog called `GET /api/billing/payment-methods` to
pick a payment note ("charged immediately" or "add a payment method"
with a Manage billing link). The server refuses that read while embedded
checkout is disabled. Embedded checkout is retired, and
`embedded_checked_enabled` was `false` in every one of 45.7k production
sessions over the last 14 days. As a result the note never rendered, and
every open of the dialog reported `saved_payment_methods_read_failure`
to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded
checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the
same call).

This PR removes the read, the note, its Manage billing button and the
`useHasSavedPaymentMethod` composable, which had no other caller.
Subscription checkout already skips this read when the flag is off
(`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`).

billing-web is unaffected. It does not import from `src/`; it reads
payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`,
`useFullPageCheckout`, `useFullPageTopup`). This PR does not touch
`packages/`.

Follow-ups, not in this PR:
- billing-web calls the same endpoint. Before
`hosted_billing_destination` moves off `stripe` (it is `stripe` for
every production session today), confirm that the server no longer gates
`/billing/payment-methods` on embedded checkout.
- Removing the rest of the `embedded_checked_enabled` code from `src/`
is a separate cleanup.

Part of the WorkspaceApiError triage started in #20344.

- `pnpm test:unit
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`:
60 passed. The four tests for the removed note and button were deleted.
The no-payment-method refusal test, which comes from the top-up
response, is unchanged.
- The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the
pre-push hook (knip) pass.
- After release, `saved_payment_methods_read_failure` should drop to
zero in Datadog RUM (`env:prod-v2`) and in Sentry.

(cherry picked from commit dc55612)
@christian-byrne
christian-byrne force-pushed the christian/backport-20367-cloud-1.54 branch from cb3cf48 to 0ca910c Compare October 8, 2026 01:25

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prohibited commit trailer is fixed on 0ca910ccbc8cd64b6525d287ee728d59ea2085b4. The repository checker against the freshly fetched release-base PR range PASS, and Check AI Co-Authors completed successfully on this exact head. Its entire Git tree 28b42327b6dae11de4d886a25dee661ae2688e24 is identical to the previously validated cb3cf486acbf2430b702c2328508b0e0e272066e; the change is commit metadata only.

Fresh own verification after an isolated exact-head checkout and frozen install: 234 related unit tests, app/browser types, the respective production build, changed-file type-aware oxlint/ESLint/format, and knip PASS. Browser and patch-removal mutations were NOT_RUN again because no source, test, dependency or layout changed. The prior actual production-browser no-read guard and pre-patch failure/restoration results are retained in the previous strict review as historical evidence, not new executions. Generated response types/server-owned state and the previously reviewed checkout behavior are unchanged.

Approval remains BLOCKED while the current matching-head required unit/E2E workflows finish; pending contexts are not PASS. Native Desktop/live account/payment, other OS/browser, broad accessibility/performance and unrelated suites: NOT_RUN. No source changes, commits, pushes, merges, CI reruns or review-thread resolution were performed.

@christian-byrne christian-byrne removed their assignment Oct 8, 2026
@christian-byrne
christian-byrne merged commit 2841b17 into cloud/1.54 Oct 8, 2026
98 checks passed
@christian-byrne
christian-byrne deleted the christian/backport-20367-cloud-1.54 branch October 8, 2026 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants