Repository navigation
[backport cloud/1.56] FE-3263 feat(telemetry): group WorkspaceApiError in Sentry by operation, status and code - #20348
Conversation
…on, status and code (#20344) ## Why Sentry groups `WorkspaceApiError` by message and stack. Failures from every workspace/billing endpoint end up in a few large issues that don't say which endpoint failed or what the server answered, so they can't be triaged, silenced or archived one at a time. This PR is the first step for the error-triage loop discussed in [Slack](https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1791320174295749). ## Root cause `handleAxiosError` in `workspaceApi.ts` turns an axios error into `WorkspaceApiError(message, status, code)`. It drops the request that failed. `status` and `code` are own properties of the error, and the cloud Sentry config has no `ExtraErrorData` integration, so neither field reaches Sentry. The only grouping signal left is the message and the stack. ## How - `WorkspaceApiError` gets an optional `operation`: the name of the `workspaceApi` method that failed. Every `handleAxiosError(err, '<method>')` call passes it. It is typed as `keyof typeof workspaceApi`, so a typo or a renamed method fails typecheck. A method name is low-cardinality and needs no URL templating; ids in the path such as `workspaceId`, `inviteId` and `opId` never reach the group key. - New `sentryBeforeSend` runs the existing third-party filter first. Then, for a `WorkspaceApiError`: - tags `workspace_api_operation`, `workspace_api_status` and `workspace_api_code` (`none` when absent); - sets `fingerprint = [error.name, operation, status, code]`, so `NoWorkspaceAccessError` stays a separate group. - An error built outside the HTTP client (billing SDK views, `readOnRail`) has no `operation`. It gets the tags but keeps Sentry's default grouping, so unrelated SDK refusals that share a status/code aren't merged. Note: changing the fingerprint opens new Sentry issues for these errors. The existing `WorkspaceApiError` issues stop receiving events and can be archived once this ships. ## AS IS / TO BE No UI change. What changes is the Sentry event that `beforeSend` emits for a `getBillingCapabilities` timeout (QA-28): AS IS ```json { "exception": [{ "type": "WorkspaceApiError", "value": "timeout of 10000ms exceeded" }], "tags": { "error_type": "...", "surface": "billing" } } ``` TO BE ```json { "exception": [{ "type": "WorkspaceApiError", "value": "timeout of 10000ms exceeded" }], "tags": { "error_type": "...", "surface": "billing", "workspace_api_operation": "getBillingCapabilities", "workspace_api_status": "none", "workspace_api_code": "none" }, "fingerprint": ["WorkspaceApiError", "getBillingCapabilities", "none", "none"] } ``` ## Plan position | # | Item | Ticket | PR | Status | |---|------|--------|----|--------| | 1 | **Group WorkspaceApiError by operation/status/code** | **FE-3263** | **this PR** | **open** | | 2 | One-off triage pass over the regrouped issues (diagnose / expected / low-volume / bug) | — | — | next | | 3 | Code-side expected-failure allowlist + report-after-final-retry | — | — | planned | | 4 | Codify the triage as a skill, then schedule it (read-only Sentry, PRs only) | — | — | planned | ```mermaid graph LR A["Group WorkspaceApiError (this PR)"] --> B["One-off triage pass"] B --> C["Expected-failure allowlist"] B --> D["Triage skill + schedule"] C --> D style A fill:#f9d71c,stroke:#333,stroke-width:2px ``` - Fixes FE-3263 - Related QA-28
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3fb253dfcdfc744a1125bba71523e9f7ceee5160
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T17:23:52.688Z",
"gitSha": "7f4e6155de0ae72e89def1524a377cc7d9beb147",
"branch": "backport-20344-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.8289999999583,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3800000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.8790000000001,
"heapDeltaBytes": 524572,
"heapUsedBytes": 68254540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.631999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.7810000001036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.9419999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.74,
"heapDeltaBytes": 535528,
"heapUsedBytes": 69289560,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.728000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.6620000000062,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.84,
"layouts": 12,
"layoutDurationMs": 4.724000000000001,
"taskDurationMs": 844.6020000000001,
"heapDeltaBytes": -2101044,
"heapUsedBytes": 66030756,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 160.23100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.2689999999748,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.404999999999998,
"layouts": 12,
"layoutDurationMs": 4.733999999999999,
"taskDurationMs": 807.6750000000002,
"heapDeltaBytes": -2158372,
"heapUsedBytes": 65935480,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 157.223,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.2449999999526,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.031,
"layouts": 6,
"layoutDurationMs": 1.4029999999999998,
"taskDurationMs": 373.7349999999999,
"heapDeltaBytes": 3799616,
"heapUsedBytes": 71245528,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.65799999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.0270000000673,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.717,
"layouts": 6,
"layoutDurationMs": 1.271,
"taskDurationMs": 377.51899999999995,
"heapDeltaBytes": 4017656,
"heapUsedBytes": 72866712,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.039000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 729.9709999999777,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.540999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.789,
"heapDeltaBytes": -6766976,
"heapUsedBytes": 61047248,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 162.89399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 711.9650000000775,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.572,
"heapDeltaBytes": -6441948,
"heapUsedBytes": 60455928,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 164.907,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.4540000000407,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.917,
"heapDeltaBytes": 15845724,
"heapUsedBytes": 84550388,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 62.255,
"eventListeners": 0,
"totalBlockingTimeMs": 555,
"frameDurationMs": 34.28285714285713,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.1229999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.7280000000001,
"heapDeltaBytes": 15720576,
"heapUsedBytes": 85347476,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 58.20600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 499,
"frameDurationMs": 33.335294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.5090000000223,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.7710000000002,
"heapDeltaBytes": 17714760,
"heapUsedBytes": 105161544,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.79399999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.9190000000099,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.97,
"heapDeltaBytes": 18862392,
"heapUsedBytes": 104663940,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 147.77800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.757142857142856,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8517.191000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7702.8859999999995,
"heapDeltaBytes": -3716844,
"heapUsedBytes": 81396300,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 6339.204000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 324,
"frameDurationMs": 32.195833333333326,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8429.361999999968,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5590000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7545.561000000001,
"heapDeltaBytes": -10797444,
"heapUsedBytes": 68210428,
"domNodes": -142,
"jsHeapTotalBytes": -13242368,
"scriptDurationMs": 6047.0160000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 141,
"frameDurationMs": 29.486013986013987,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10656.654000000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06700000000000109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9726.093,
"heapDeltaBytes": 11647172,
"heapUsedBytes": 90892928,
"domNodes": -142,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 8042.791999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1055,
"frameDurationMs": 32.27121212121212,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8846.820999999978,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5109999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8051.579000000001,
"heapDeltaBytes": -3913688,
"heapUsedBytes": 80902172,
"domNodes": -142,
"jsHeapTotalBytes": -12980224,
"scriptDurationMs": 6531.778,
"eventListeners": -74,
"totalBlockingTimeMs": 163,
"frameDurationMs": 29.796632996632997,
"p95FrameDurationMs": 50.00000000000091
},
{
"name": "large-graph-idle",
"durationMs": 2038.3580000000165,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.247999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.8059999999999,
"heapDeltaBytes": -10175416,
"heapUsedBytes": 78552668,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.201000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.2659999999778,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.5,
"heapDeltaBytes": -10563260,
"heapUsedBytes": 78272004,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.72700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2443.1169999999724,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1592.543,
"heapDeltaBytes": -19492640,
"heapUsedBytes": 70249644,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 821.506,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2328.864000000067,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.363000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.677,
"heapDeltaBytes": -18838880,
"heapUsedBytes": 70745992,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 812.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666187050359714,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3770.5190000000357,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.866999999999999,
"layouts": 60,
"layoutDurationMs": 15.928999999999998,
"taskDurationMs": 1723.136,
"heapDeltaBytes": 1661932,
"heapUsedBytes": 70048928,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 818.774,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154187,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3667.982000000052,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.976999999999999,
"layouts": 60,
"layoutDurationMs": 16.022000000000002,
"taskDurationMs": 1690.3830000000003,
"heapDeltaBytes": 789904,
"heapUsedBytes": 69111128,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 806.943,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3139.639999999986,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.9030000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1981.7,
"heapDeltaBytes": 4328916,
"heapUsedBytes": 73824784,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1035.3129999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84462365591398,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3171.87100000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.835000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.572,
"heapDeltaBytes": 9196024,
"heapUsedBytes": 77644856,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 1008.904,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.843617021276597,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.5529999999026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9650000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.6279999999999,
"heapDeltaBytes": -9522840,
"heapUsedBytes": 80939448,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.86000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.3900000000112,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.264,
"heapDeltaBytes": -9710316,
"heapUsedBytes": 79271784,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.898999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.6100000000197,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.191,
"heapDeltaBytes": -11947392,
"heapUsedBytes": 57588636,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.23799999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.1300000000128,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.0859999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.68300000000005,
"heapDeltaBytes": -11695104,
"heapUsedBytes": 58333308,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.682,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.8350000000432,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.06200000000007,
"heapDeltaBytes": 1036240,
"heapUsedBytes": 70607140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.52000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.5350000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9360000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.989,
"heapDeltaBytes": 936856,
"heapUsedBytes": 69623076,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.711999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.9720000000261,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.363000000000003,
"layouts": 16,
"layoutDurationMs": 6.088,
"taskDurationMs": 786.4519999999999,
"heapDeltaBytes": -5973924,
"heapUsedBytes": 63792472,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 116.74200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.8320000000158,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.275,
"layouts": 16,
"layoutDurationMs": 6.128,
"taskDurationMs": 753.05,
"heapDeltaBytes": -6484496,
"heapUsedBytes": 61691280,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 112.35799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.4199999999691,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.431,
"layouts": 5,
"layoutDurationMs": 14.157999999999998,
"taskDurationMs": 1005.3190000000001,
"heapDeltaBytes": 1165688,
"heapUsedBytes": 96225796,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 31.119999999999994,
"eventListeners": 2463,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9059.125999999993,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6011.218000000001,
"heapDeltaBytes": -15741036,
"heapUsedBytes": 73121752,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2928.651,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69686346863469,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8420.078999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5663.512,
"heapDeltaBytes": 10883832,
"heapUsedBytes": 90333100,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 2750.815,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18821.312000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18403.183,
"heapDeltaBytes": -21709400,
"heapUsedBytes": 180380564,
"domNodes": -3045,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 309.338,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.391296625222026,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 17655.84000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17148.205,
"heapDeltaBytes": -33498164,
"heapUsedBytes": 179670040,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 334.28799999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.54642857142857,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 22741.962000000058,
"styleRecalcs": 177,
"styleRecalcDurationMs": 25.058000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22543.956000000002,
"heapDeltaBytes": -23738996,
"heapUsedBytes": 193874380,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 903.893,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 43.748269230769225,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 23346.256999999925,
"styleRecalcs": 178,
"styleRecalcDurationMs": 27.376000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23024.438,
"heapDeltaBytes": -42250992,
"heapUsedBytes": 168990256,
"domNodes": -3045,
"jsHeapTotalBytes": 8032256,
"scriptDurationMs": 920.533,
"eventListeners": -14915,
"totalBlockingTimeMs": 55,
"frameDurationMs": 44.81612284069097,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6764.115000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.01600000000003,
"layouts": 20,
"layoutDurationMs": 27.487999999999985,
"taskDurationMs": 6645.689,
"heapDeltaBytes": -3314700,
"heapUsedBytes": 214064276,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 123.57199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.445454545454545,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6579.029999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.38999999999999,
"layouts": 20,
"layoutDurationMs": 27.352,
"taskDurationMs": 6520.044,
"heapDeltaBytes": -17313740,
"heapUsedBytes": 213829944,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 115.17500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.5566265060241,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9391.749000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8963.774,
"heapDeltaBytes": -29525064,
"heapUsedBytes": 184234932,
"domNodes": -3045,
"jsHeapTotalBytes": 12079104,
"scriptDurationMs": 151.48399999999995,
"eventListeners": -14919,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.981052631578955,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9549.39999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9297.806999999999,
"heapDeltaBytes": -38199808,
"heapUsedBytes": 179320044,
"domNodes": -8043,
"jsHeapTotalBytes": 4857856,
"scriptDurationMs": 157.87199999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.04359861591696,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 501.8590000000813,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.533,
"layouts": 5,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 153.156,
"heapDeltaBytes": 6134320,
"heapUsedBytes": 60260784,
"domNodes": -101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.923,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 489.27900000001046,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.038999999999998,
"layouts": 4,
"layoutDurationMs": 1.955,
"taskDurationMs": 134.11,
"heapDeltaBytes": 5794108,
"heapUsedBytes": 71472640,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.82099999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1026.9720000000007,
"styleRecalcs": 78,
"styleRecalcDurationMs": 114.054,
"layouts": 76,
"layoutDurationMs": 29.384,
"taskDurationMs": 1002.8409999999999,
"heapDeltaBytes": 19427004,
"heapUsedBytes": 86603332,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 414.35699999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1049.45500000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 117.377,
"layouts": 76,
"layoutDurationMs": 30.603,
"taskDurationMs": 1025.8709999999999,
"heapDeltaBytes": 19486376,
"heapUsedBytes": 86114364,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 416.155,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1488.7320000000273,
"styleRecalcs": 78,
"styleRecalcDurationMs": 289.109,
"layouts": 76,
"layoutDurationMs": 31.269,
"taskDurationMs": 1466.1119999999999,
"heapDeltaBytes": 8483464,
"heapUsedBytes": 115650184,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 483.29299999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.748749999999994,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1590.012999999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 320.877,
"layouts": 76,
"layoutDurationMs": 32.016999999999996,
"taskDurationMs": 1563.8339999999998,
"heapDeltaBytes": 8762148,
"heapUsedBytes": 115801016,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 496.577,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.713414634146343,
"p95FrameDurationMs": 33.399999999999636
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #20348 +/- ##
=============================================
Coverage ? 85.96%
=============================================
Files ? 2475
Lines ? 141158
Branches ? 38423
=============================================
Hits ? 121347
Misses ? 19430
Partials ? 381
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Deep strict review of the cloud/1.56 backport at a291fd3: one blocking test failure.
FAIL: freshly executed focused tests produced 115 PASS / 1 FAIL on the exact head. The failing new third-party-noise case expects a generic AbortError to be discarded, but this branch's established filter only discards the named browser-extension messages. Current matching-head CI logs contain this same failure; these are completed failed runs, not cancelled historical gates.
PASS: own frozen-lockfile installation, app typecheck, production Cloud build, changed-file type-aware oxlint/production ESLint/format and knip. Two disposable diagnostic cases passed: known extension noise is dropped while ordinary AbortError is retained, and a report through the real Sentry SDK normalization pipeline emits the expected stable operation/status/code fingerprint and preserves caller tags. Transport was controlled; this is not live Sentry ingestion evidence.
Grouping-removal mutation produced 5 FAIL / 1 PASS in the six new hook cases (four additional failures beyond the existing noise failure). Restoring the exact source returned to 1 FAIL / 5 PASS. All seven PR files are byte-identical to the head and checkout is clean. No new frontend-derived server state or handwritten API response contract was introduced.
NOT_RUN: unrelated full suites, local browser and live telemetry/account flows. This change has no UI interaction; the actual SDK pipeline was checked directly. The Cloud backport also retains a separate current CI cloudSsoSignIn failure; its product cause was not reproduced in this telemetry-focused review.
| }) | ||
|
|
||
| it('still drops third-party noise', () => { | ||
| const error = new DOMException('aborted', 'AbortError') |
There was a problem hiding this comment.
issue: This fixture assumes that a generic DOMException('aborted', 'AbortError') is filtered out, but cloud/1.56's isThirdPartyErrorNoise only matches the named browser-extension messages. Both the existing filter and the new composed hook correctly retain this event, so this new test deterministically fails: I reproduced 1 FAIL / 115 PASS locally, and the current matching-head CI unit shard fails at line 110 for the same reason. Could this safety-net case use an actual filtered extension error (for example Invalid call to runtime.sendMessage(). Tab not found.), consistent with thirdPartyErrorNoise.test.ts? Broadening the production filter just to satisfy this fixture would change the release's error-reporting policy rather than validate the grouping backport.
…vey and retention offer (#20487) ## Why Manual backport of #19671 to `cloud/1.56`. The auto-backport failed on conflicts. ## Root cause - `src/platform/remoteConfig/serverFeatureFlag.ts`: modify/delete. #19089 (moves `ServerFeatureFlag` into that file) is not on `cloud/1.56`, so the enum still lives in `src/composables/useFeatureFlags.ts`. - `src/platform/workspace/api/workspaceApi.ts`: main's `handleAxiosError(err, operation)` comes from #20344, whose backport #20348 is still open. On `cloud/1.56` it takes only the error. The retention route types were already on `cloud/1.56` (#20364), so nothing else was missing. ## How - Cherry-picked 0ccdb81. - Kept `serverFeatureFlag.ts` deleted and dropped `CHURNKEY_APP_ID` from the enum in `useFeatureFlags.ts`. The cherry-pick had already removed its getter and telemetry entry. - `prepareRetentionFlow`, `acceptRetentionOffer` and `recordRetentionFlowEvent` call `handleAxiosError(err)`. When #20348 lands after this, it needs operation names for these three calls, since its `operation` parameter is required. ## Test plan - [x] Vitest across `src/platform/cloud/subscription`, `src/platform/workspace`, `src/services`, `src/components/dialog/content/subscription`, `src/platform/telemetry`, `src/composables/billing`, `src/platform/remoteConfig`, feature flags and `numberUtil`: 4,329 passed, 1 failed. The failure is `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe"), which fails identically on unmodified `cloud/1.56` (Firebase `INTERNAL ASSERTION FAILED`). - [x] `typecheck:app`, `typecheck:browser`, `typecheck:account-core`, oxlint and eslint clean (pre-commit). knip and fallow clean (pre-push). - [ ] Playwright `cloud` project: CI
|
The unit failure was the backported test |
Backport of #20344 to
cloud/1.56Automatically created by backport workflow.