Repository navigation
[backport cloud/1.56] feat: Cloud cancellation flow with a reason survey and retention offer - #20487
Conversation
…vey and retention offer (#19671) Cherry-pick of 0ccdb81 with two conflicts resolved for cloud/1.56: - ServerFeatureFlag still lives in useFeatureFlags.ts here (#19089 is not on this branch), so drop CHURNKEY_APP_ID there instead of from serverFeatureFlag.ts. - handleAxiosError takes no operation argument here (#20348 is still open), so the three retention methods call it with the error only. (cherry picked from commit 0ccdb81)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (59 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bd360e6dd90dba7ab2aca0fee9783c87a10f951e
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T23:59:54.583Z",
"gitSha": "f8b758453900ff88b57d427ee9f14b50ce69f131",
"branch": "backport-19671-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.1880000000187,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8190000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.445,
"heapDeltaBytes": 548420,
"heapUsedBytes": 68616704,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.610999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.665999999982,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.263999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.945,
"heapDeltaBytes": 552796,
"heapUsedBytes": 69325052,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.260000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5240000000385,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.325,
"layouts": 12,
"layoutDurationMs": 4.686,
"taskDurationMs": 637.91,
"heapDeltaBytes": -2091380,
"heapUsedBytes": 65455572,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 127.737,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.5929999999935,
"styleRecalcs": 71,
"styleRecalcDurationMs": 19.203,
"layouts": 12,
"layoutDurationMs": 4.678,
"taskDurationMs": 657.4060000000001,
"heapDeltaBytes": -2103464,
"heapUsedBytes": 65367552,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 137.10500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4720000000052,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.931,
"layouts": 6,
"layoutDurationMs": 1.387,
"taskDurationMs": 300.16600000000005,
"heapDeltaBytes": 4137184,
"heapUsedBytes": 72191700,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.457000000000006,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.7420000000866,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.129999999999999,
"layouts": 6,
"layoutDurationMs": 1.4320000000000002,
"taskDurationMs": 318.396,
"heapDeltaBytes": 4078508,
"heapUsedBytes": 73017956,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.328000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.1489999999717,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.955000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.133,
"heapDeltaBytes": -7365448,
"heapUsedBytes": 61651364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.46199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.4320000000007,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.062999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.3690000000001,
"heapDeltaBytes": -7431268,
"heapUsedBytes": 61362492,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 136.629,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.184375000000003,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 969.4470000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.4499999999999,
"heapDeltaBytes": 15397652,
"heapUsedBytes": 85424668,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 40.858999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 350,
"frameDurationMs": 29.29090909090909,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 979.7140000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.57,
"heapDeltaBytes": 39315036,
"heapUsedBytes": 109454524,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 47.07699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 339,
"frameDurationMs": 28.091428571428565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 711.9480000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.33699999999976,
"heapDeltaBytes": 17289624,
"heapUsedBytes": 104089808,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 106.30700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 101,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.3010000000204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.12899999999996,
"heapDeltaBytes": 17348768,
"heapUsedBytes": 104363876,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 101.50299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6762.304999999998,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.1859999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5864.456999999999,
"heapDeltaBytes": -7465816,
"heapUsedBytes": 78406888,
"domNodes": -143,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 4596.838,
"eventListeners": -82,
"totalBlockingTimeMs": 33,
"frameDurationMs": 24.5768115942029,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6222.437999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.5180000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5213.858,
"heapDeltaBytes": 11728464,
"heapUsedBytes": 88888460,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 4156.625,
"eventListeners": -74,
"totalBlockingTimeMs": 23,
"frameDurationMs": 24.766533864541827,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6392.665999999991,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.549,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5498.339,
"heapDeltaBytes": -13710500,
"heapUsedBytes": 71276800,
"domNodes": -142,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 4225.772,
"eventListeners": -78,
"totalBlockingTimeMs": 31,
"frameDurationMs": 24.149811320754715,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6270.891000000006,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.4630000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5323.797,
"heapDeltaBytes": 953660,
"heapUsedBytes": 85766032,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 4124.834,
"eventListeners": -78,
"totalBlockingTimeMs": 28,
"frameDurationMs": 22.005985915492953,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2007.2720000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8040000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.375,
"heapDeltaBytes": -9450948,
"heapUsedBytes": 79844148,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.564,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.610999999983,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.13599999999997,
"heapDeltaBytes": -9345516,
"heapUsedBytes": 79416104,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.220999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2149.312000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.882,
"heapDeltaBytes": -18792396,
"heapUsedBytes": 70418992,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 663.1320000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2168.1560000000104,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.712000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1169.4560000000001,
"heapDeltaBytes": -19373676,
"heapUsedBytes": 70047164,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 627.7669999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3135.3490000000193,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.763,
"layouts": 60,
"layoutDurationMs": 16.725,
"taskDurationMs": 1334.645,
"heapDeltaBytes": 866836,
"heapUsedBytes": 70260436,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 600.5579999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3171.948999999927,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.392000000000003,
"layouts": 60,
"layoutDurationMs": 15.923000000000004,
"taskDurationMs": 1228.046,
"heapDeltaBytes": 3702124,
"heapUsedBytes": 93984060,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 558.356,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2315.367999999978,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.908000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1495.002,
"heapDeltaBytes": 3089420,
"heapUsedBytes": 72258380,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 766.0669999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2174.477999999965,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.782,
"heapDeltaBytes": 8230336,
"heapUsedBytes": 76904740,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 693.373,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615387,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.5949999999857,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4699999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.045,
"heapDeltaBytes": -8343204,
"heapUsedBytes": 82418340,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.584,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.1400000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.59499999999997,
"heapDeltaBytes": -8559644,
"heapUsedBytes": 81150304,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.097,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.378000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.222,
"heapDeltaBytes": -12865300,
"heapUsedBytes": 57946048,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 102.919,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 477.65100000003713,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.110999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.956,
"heapDeltaBytes": -12322800,
"heapUsedBytes": 57741232,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 101.37299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.0699999999988,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.50199999999995,
"heapDeltaBytes": 1035708,
"heapUsedBytes": 70557784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.721000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.3970000000495,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.88,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.443,
"heapDeltaBytes": 1009444,
"heapUsedBytes": 71170740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.305,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.1500000000265,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.613000000000003,
"layouts": 16,
"layoutDurationMs": 6.3870000000000005,
"taskDurationMs": 644.6759999999999,
"heapDeltaBytes": -5958636,
"heapUsedBytes": 63534792,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 108.45299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9509999999937,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.562,
"layouts": 16,
"layoutDurationMs": 5.606,
"taskDurationMs": 553.4259999999999,
"heapDeltaBytes": -5907104,
"heapUsedBytes": 64876128,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 91.69999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 934.190000000001,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.118,
"layouts": 5,
"layoutDurationMs": 9.857000000000001,
"taskDurationMs": 703.56,
"heapDeltaBytes": 1267440,
"heapUsedBytes": 94946544,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.673,
"eventListeners": 2463,
"totalBlockingTimeMs": 77,
"frameDurationMs": 19.44166666666668,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.101999999976,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4363.89,
"heapDeltaBytes": -19156024,
"heapUsedBytes": 70163676,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2109.4339999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8242.938999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4174.681,
"heapDeltaBytes": -18911332,
"heapUsedBytes": 70253172,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2064.2889999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13327.267000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12643.461,
"heapDeltaBytes": -36109788,
"heapUsedBytes": 187891676,
"domNodes": -3045,
"jsHeapTotalBytes": 8757248,
"scriptDurationMs": 190.48399999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.37030201342282,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 12883.754000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12309.634,
"heapDeltaBytes": -18131940,
"heapUsedBytes": 181960076,
"domNodes": -3045,
"jsHeapTotalBytes": 9457664,
"scriptDurationMs": 195.434,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.615604026845638,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 15970.412000000011,
"styleRecalcs": 92,
"styleRecalcDurationMs": 19.267000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15519.271,
"heapDeltaBytes": -30064704,
"heapUsedBytes": 186448364,
"domNodes": -3045,
"jsHeapTotalBytes": 8585216,
"scriptDurationMs": 692.495,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 28.634470377019753,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 15247.814000000062,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.388000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14783.769999999999,
"heapDeltaBytes": -21536436,
"heapUsedBytes": 192012816,
"domNodes": -3048,
"jsHeapTotalBytes": 7028736,
"scriptDurationMs": 654.9889999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 27.27960644007155,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4893.402999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.85599999999999,
"layouts": 20,
"layoutDurationMs": 26.488999999999997,
"taskDurationMs": 4775.522,
"heapDeltaBytes": 930896,
"heapUsedBytes": 224802636,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 79.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.34011976047905,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5088.178999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.66099999999999,
"layouts": 20,
"layoutDurationMs": 27.84400000000001,
"taskDurationMs": 4965.538999999999,
"heapDeltaBytes": -2942660,
"heapUsedBytes": 218834648,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 88.369,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 30.35595238095238,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6764.560000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6443.643999999999,
"heapDeltaBytes": -36226500,
"heapUsedBytes": 181655684,
"domNodes": -3045,
"jsHeapTotalBytes": 8527872,
"scriptDurationMs": 99.75300000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.880338983050844,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6706.252999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6446.672,
"heapDeltaBytes": -20299436,
"heapUsedBytes": 186428208,
"domNodes": -3045,
"jsHeapTotalBytes": 14295040,
"scriptDurationMs": 105.02899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.48255033557047,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 453.9429999999811,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.504,
"layouts": 3,
"layoutDurationMs": 0.9630000000000001,
"taskDurationMs": 92.87800000000001,
"heapDeltaBytes": 5603788,
"heapUsedBytes": 70760276,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.986000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 455.95700000001216,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.276000000000002,
"layouts": 3,
"layoutDurationMs": 0.965,
"taskDurationMs": 94.83299999999998,
"heapDeltaBytes": 5510296,
"heapUsedBytes": 72181596,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.395,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 618.443999999954,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.328,
"layouts": 76,
"layoutDurationMs": 29.955,
"taskDurationMs": 578.883,
"heapDeltaBytes": -16938164,
"heapUsedBytes": 67626104,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 192.666,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 725.9380000000419,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.211,
"layouts": 76,
"layoutDurationMs": 31.169999999999998,
"taskDurationMs": 676.7709999999998,
"heapDeltaBytes": -15783772,
"heapUsedBytes": 68119760,
"domNodes": 76,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 235.74499999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190475,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1373.7300000000232,
"styleRecalcs": 78,
"styleRecalcDurationMs": 369.811,
"layouts": 76,
"layoutDurationMs": 36.254000000000005,
"taskDurationMs": 1344.8609999999999,
"heapDeltaBytes": 8000396,
"heapUsedBytes": 115883032,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 361.63,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.221333333333337,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1185.5460000000448,
"styleRecalcs": 78,
"styleRecalcDurationMs": 281.775,
"layouts": 76,
"layoutDurationMs": 31.632,
"taskDurationMs": 1151.0069999999998,
"heapDeltaBytes": -20352860,
"heapUsedBytes": 109486096,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 318.629,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.901408450704224,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20487 +/- ##
=============================================
Coverage ? 85.12%
=============================================
Files ? 3508
Lines ? 168769
Branches ? 44286
=============================================
Hits ? 143662
Misses ? 23124
Partials ? 1983
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5254dfe7d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const result = await redeem(sessionId, workspaceId) | ||
| dispatch(result) | ||
| if (result.type === 'applied') await refreshPlan() |
There was a problem hiding this comment.
Recheck workspace scope after retention redemption
When the active workspace changes after the owner clicks Accept but before redeem() settles, this path still dispatches applied and calls the global billing context's fetchStatus() for whichever workspace is now active. An immediately succeeded response can therefore show the old workspace's offer as applied while refreshing the new workspace; for pending responses, the operation poller pauses on a workspace mismatch and leaves this dialog locked in accepting until timeout. Pass the scope guard into this composable and recheck it after the await before updating the phase or refreshing.
Useful? React with 👍 / 👎.
| function headlinePrice(cents: number) { | ||
| return formatCurrencyCents(locale.value, cents, subscription.currency) | ||
| } | ||
|
|
||
| function exactAmount(cents: number) { | ||
| return formatQuoteMoney(cents, subscription.currency, locale.value) |
There was a problem hiding this comment.
Format offer amounts using the currency's minor unit
For zero- or three-decimal currencies, this displays the retention price incorrectly because the API contract defines unit_amount in the currency's smallest unit, while formatCurrencyCents() and formatQuoteMoney() always divide by 100. For example, a JPY unit_amount of 10000 represents ¥10,000 but is rendered as ¥100, misleading the customer about the offer; convert according to the returned currency's minor-unit exponent rather than assuming cents.
Useful? React with 👍 / 👎.
Why
Manual backport of #19671 to
cloud/1.56. The auto-backport failed on conflicts.Root cause
src/platform/remoteConfig/serverFeatureFlag.ts: modify/delete. refactor: move ServerFeatureFlag enum to a leaf module #19089 (movesServerFeatureFlaginto that file) is not oncloud/1.56, so the enum still lives insrc/composables/useFeatureFlags.ts.src/platform/workspace/api/workspaceApi.ts: main'shandleAxiosError(err, operation)comes from FE-3263 feat(telemetry): group WorkspaceApiError in Sentry by operation, status and code #20344, whose backport [backport cloud/1.56] FE-3263 feat(telemetry): group WorkspaceApiError in Sentry by operation, status and code #20348 is still open. Oncloud/1.56it takes only the error.The retention route types were already on
cloud/1.56(#20364), so nothing else was missing.How
serverFeatureFlag.tsdeleted and droppedCHURNKEY_APP_IDfrom the enum inuseFeatureFlags.ts. The cherry-pick had already removed its getter and telemetry entry.prepareRetentionFlow,acceptRetentionOfferandrecordRetentionFlowEventcallhandleAxiosError(err). When [backport cloud/1.56] FE-3263 feat(telemetry): group WorkspaceApiError in Sentry by operation, status and code #20348 lands after this, it needs operation names for these three calls, since itsoperationparameter is required.Test plan
src/platform/cloud/subscription,src/platform/workspace,src/services,src/components/dialog/content/subscription,src/platform/telemetry,src/composables/billing,src/platform/remoteConfig, feature flags andnumberUtil: 4,329 passed, 1 failed. The failure isUnifiedPricingTable.test.ts("prompts free-tier users to subscribe"), which fails identically on unmodifiedcloud/1.56(FirebaseINTERNAL ASSERTION FAILED).typecheck:app,typecheck:browser,typecheck:account-core, oxlint and eslint clean (pre-commit). knip and fallow clean (pre-push).cloudproject: CI