Repository navigation
FE-3297 refactor(auth): take the Desktop auth bridge types from the published package - #20500
Conversation
… package Bumps @comfyorg/comfyui-desktop-bridge-types to 0.4.0, which exports ComfyDesktop2AuthState and ComfyDesktop2AuthBridge, and drops the local copy of that response contract. Only switchWorkspace stays as a local optional extension until 0.5.0 (Comfy-Desktop #1671) is published.
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f65f85ae862fbc0832bac1e87f8001d368118a0f
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.32 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 4.04 kB (baseline 4.04 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.9 MB (baseline 1.9 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 144 kB (baseline 144 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 10 unchanged UI Components — 209 kB (baseline 209 kB) • ⚪ 0 BReusable component library chunks Status: 21 unchanged Data & Services — 3.62 MB (baseline 3.62 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 19 unchanged Utilities & Hooks — 728 kB (baseline 728 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 46 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 BBundles that do not match a named category Status: 332 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T01:40:43.589Z",
"gitSha": "80b46f528c7bf07f3e8137298b08d6cf4778fdf4",
"branch": "jaewon/fe-3297-bridge-types-040",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2058.9180000000056,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.9709999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.4179999999999,
"heapDeltaBytes": -52685884,
"heapUsedBytes": 56183848,
"domNodes": -212,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.075,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.9279999999653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.505999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.89899999999994,
"heapDeltaBytes": -49282660,
"heapUsedBytes": 60380308,
"domNodes": -230,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 7.2540000000000004,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.8689999999692,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.450000000000001,
"layouts": 12,
"layoutDurationMs": 4.12,
"taskDurationMs": 762.811,
"heapDeltaBytes": 1011244,
"heapUsedBytes": 64870592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.117,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.2520000000532,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.823,
"layouts": 12,
"layoutDurationMs": 4.553,
"taskDurationMs": 621.7710000000001,
"heapDeltaBytes": 1059688,
"heapUsedBytes": 65427580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.49300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1773.5500000000002,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.4319999999999995,
"layouts": 3,
"layoutDurationMs": 0.7689999999999999,
"taskDurationMs": 395.85799999999995,
"heapDeltaBytes": -51154100,
"heapUsedBytes": 58788964,
"domNodes": -167,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 9.001999999999999,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.66000000008,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.495,
"layouts": 3,
"layoutDurationMs": 0.9060000000000001,
"taskDurationMs": 328.605,
"heapDeltaBytes": 6851976,
"heapUsedBytes": 71165756,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.781,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 629.0549999999939,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.4239999999999,
"heapDeltaBytes": 18737928,
"heapUsedBytes": 83251200,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 166.432,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 613.7509999999793,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5300000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.96899999999994,
"heapDeltaBytes": 18763556,
"heapUsedBytes": 82486900,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.14,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.0630000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.2539999999999,
"heapDeltaBytes": 11713052,
"heapUsedBytes": 96481888,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 69.62800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1129.5639999999594,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.711,
"heapDeltaBytes": 12556988,
"heapUsedBytes": 98040772,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 67.48300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 507,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.107999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.32700000000006,
"heapDeltaBytes": 19263576,
"heapUsedBytes": 102137748,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.006,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.9880000000148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.56300000000016,
"heapDeltaBytes": 19372772,
"heapUsedBytes": 106094756,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.69,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10172.604000000036,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8050000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9255.625,
"heapDeltaBytes": 14410280,
"heapUsedBytes": 87649200,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 7647.1720000000005,
"eventListeners": -65,
"totalBlockingTimeMs": 909,
"frameDurationMs": 32.37675159235668,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8431.712000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7581.626000000001,
"heapDeltaBytes": -13228544,
"heapUsedBytes": 69725320,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 6443.398,
"eventListeners": 0,
"totalBlockingTimeMs": 448,
"frameDurationMs": 32.876171875000004,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8892.274000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8200.282,
"heapDeltaBytes": -2933860,
"heapUsedBytes": 73973460,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 6743.483,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 32.480656934306566,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8763.458000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8076.751,
"heapDeltaBytes": -1144968,
"heapUsedBytes": 82310720,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 6617.405000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 468,
"frameDurationMs": 32.28671586715868,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2007.092,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3299999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.569,
"heapDeltaBytes": -3178592,
"heapUsedBytes": 79724360,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.179999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.671999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5870000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.33300000000014,
"heapDeltaBytes": -49102544,
"heapUsedBytes": 84098432,
"domNodes": -308,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 28.199999999999996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2161.8909999999687,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.286999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1463.377,
"heapDeltaBytes": 15129992,
"heapUsedBytes": 80829732,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 763.6679999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2179.0220000000318,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.604000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1529.91,
"heapDeltaBytes": -28522540,
"heapUsedBytes": 77191104,
"domNodes": -308,
"jsHeapTotalBytes": -2007040,
"scriptDurationMs": 785.0350000000001,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793846153846154,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3491.6900000000055,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.743999999999999,
"layouts": 60,
"layoutDurationMs": 15.286000000000001,
"taskDurationMs": 1583.484,
"heapDeltaBytes": 10835392,
"heapUsedBytes": 96161744,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 761.198,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665550239234452,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3489.090000000033,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.57,
"layouts": 60,
"layoutDurationMs": 14.980000000000002,
"taskDurationMs": 1601.055,
"heapDeltaBytes": 12379216,
"heapUsedBytes": 93421056,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 755.58,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6665071770335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2865.7010000000014,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.2109999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.2469999999998,
"heapDeltaBytes": -11675160,
"heapUsedBytes": 75426780,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 965.4189999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763742690058475,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2808.347000000026,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.182,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1797.2970000000003,
"heapDeltaBytes": 17894648,
"heapUsedBytes": 85246228,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 927.364,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.866867469879516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8020000000229,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2800000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.4209999999999,
"heapDeltaBytes": -23390832,
"heapUsedBytes": 84334692,
"domNodes": -308,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 27.266999999999992,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.5009999999538,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5740000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.2890000000001,
"heapDeltaBytes": -21786852,
"heapUsedBytes": 85062600,
"domNodes": -308,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 28.683999999999994,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.6070000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.486,
"heapDeltaBytes": -45534916,
"heapUsedBytes": 66215940,
"domNodes": -230,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 144.476,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.5259999999771,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.949999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.572,
"heapDeltaBytes": 13019224,
"heapUsedBytes": 77337684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.27700000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.3940000000061,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2070000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.2050000000001,
"heapDeltaBytes": -50791056,
"heapUsedBytes": 61291380,
"domNodes": -247,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 7.099999999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.211999999954,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.325,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.04099999999994,
"heapDeltaBytes": -51797524,
"heapUsedBytes": 59257344,
"domNodes": -230,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 6.957,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.25200000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.648,
"layouts": 16,
"layoutDurationMs": 5.043,
"taskDurationMs": 701.489,
"heapDeltaBytes": -2470408,
"heapUsedBytes": 64139316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.02,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3500000000859,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.783999999999999,
"layouts": 16,
"layoutDurationMs": 5.672,
"taskDurationMs": 712.447,
"heapDeltaBytes": -33287712,
"heapUsedBytes": 78654828,
"domNodes": -230,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 94.861,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.564999999915,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.429999999999996,
"layouts": 6,
"layoutDurationMs": 14.622000000000003,
"taskDurationMs": 902.62,
"heapDeltaBytes": 32363624,
"heapUsedBytes": 109159168,
"domNodes": 14650,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 27.513999999999996,
"eventListeners": 2456,
"totalBlockingTimeMs": 127,
"frameDurationMs": 19.143243243243237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8225.74099999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 16.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4644.5380000000005,
"heapDeltaBytes": -65851916,
"heapUsedBytes": 67542532,
"domNodes": -328,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 2555.544,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659229208925,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8242.578999999978,
"styleRecalcs": 251,
"styleRecalcDurationMs": 16.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5292.407,
"heapDeltaBytes": -51719512,
"heapUsedBytes": 81638576,
"domNodes": -308,
"jsHeapTotalBytes": -3051520,
"scriptDurationMs": 2534.7239999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666194331983807,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16587.299000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15684.828999999998,
"heapDeltaBytes": -32207952,
"heapUsedBytes": 184768620,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 227.227,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.2981228668942,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 11786.736000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10927.972,
"heapDeltaBytes": -34360224,
"heapUsedBytes": 191669636,
"domNodes": -3046,
"jsHeapTotalBytes": 9019392,
"scriptDurationMs": 172.83399999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.67095158597663,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 22335.260000000006,
"styleRecalcs": 177,
"styleRecalcDurationMs": 13.250000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21850.555,
"heapDeltaBytes": -26413080,
"heapUsedBytes": 189950040,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 838.466,
"eventListeners": -14913,
"totalBlockingTimeMs": 9,
"frameDurationMs": 40.238378378378385,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21628.554000000007,
"styleRecalcs": 178,
"styleRecalcDurationMs": 13.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21205.626000000004,
"heapDeltaBytes": -27006184,
"heapUsedBytes": 189885684,
"domNodes": -3046,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 832.087,
"eventListeners": -14913,
"totalBlockingTimeMs": 37,
"frameDurationMs": 39.54753199268738,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.209999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.45599999999999,
"layouts": 20,
"layoutDurationMs": 21.934999999999995,
"taskDurationMs": 6110.514999999999,
"heapDeltaBytes": -13927304,
"heapUsedBytes": 216352592,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 97.54700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.79375,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6225.055999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.34400000000002,
"layouts": 20,
"layoutDurationMs": 22.303000000000004,
"taskDurationMs": 6077.782,
"heapDeltaBytes": -13936800,
"heapUsedBytes": 216362992,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 100.36399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.88224852071005,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8629.737000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8326.935000000001,
"heapDeltaBytes": -34446484,
"heapUsedBytes": 184492232,
"domNodes": -3046,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 118.228,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.71172413793104,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8545.108000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8174.810000000002,
"heapDeltaBytes": -23569572,
"heapUsedBytes": 184074396,
"domNodes": -3046,
"jsHeapTotalBytes": 8384512,
"scriptDurationMs": 116.48999999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.63422818791946,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 515.7820000000584,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.186,
"layouts": 4,
"layoutDurationMs": 1.831,
"taskDurationMs": 223.05099999999996,
"heapDeltaBytes": -49235264,
"heapUsedBytes": 58268424,
"domNodes": -96,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 12.743999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 155.36500000007436,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.248999999999999,
"layouts": 3,
"layoutDurationMs": 1.9169999999999998,
"taskDurationMs": 143.05100000000002,
"heapDeltaBytes": 4039444,
"heapUsedBytes": 111678752,
"domNodes": 119,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.345,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1052.1459999999934,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.34,
"layouts": 76,
"layoutDurationMs": 29.008,
"taskDurationMs": 1029.702,
"heapDeltaBytes": 19271728,
"heapUsedBytes": 95137048,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 424.332,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667187499999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1074.3929999999864,
"styleRecalcs": 78,
"styleRecalcDurationMs": 104.05300000000001,
"layouts": 76,
"layoutDurationMs": 31.28,
"taskDurationMs": 1038.824,
"heapDeltaBytes": 19085544,
"heapUsedBytes": 93033992,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 442.51800000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.485245901639335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1514.5019999999931,
"styleRecalcs": 78,
"styleRecalcDurationMs": 285.992,
"layouts": 76,
"layoutDurationMs": 31.686,
"taskDurationMs": 1499.077,
"heapDeltaBytes": 14003176,
"heapUsedBytes": 138837020,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 502.8159999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.928395061728406,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1573.5370000001012,
"styleRecalcs": 78,
"styleRecalcDurationMs": 288.223,
"layouts": 76,
"layoutDurationMs": 32.798,
"taskDurationMs": 1550.2769999999998,
"heapDeltaBytes": -19161600,
"heapUsedBytes": 117078116,
"domNodes": 76,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 525.5340000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.075903614457843,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2237 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe workspace now uses version 0.4.0 of the desktop bridge types package. Desktop auth declarations use the package’s auth state and bridge types, while retaining the optional ChangesDesktop auth bridge types
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The updated auth types match their consumers, and the lockfile matches the selected package version. No merge-blocking behavior is identified. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The shared authentication types match the previous local contract. The change adds no executable authentication paths or privileges, and workspace switching remains optional for older Desktop builds. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
… package Bumps @comfyorg/comfyui-desktop-bridge-types to 0.4.0 and drops the local copy of Desktop's auth response contract; only switchWorkspace stays as a local optional extension until 0.5.0. Same change as #20500.
… package Bumps @comfyorg/comfyui-desktop-bridge-types to 0.4.0 and drops the local copy of Desktop's auth response contract; only switchWorkspace stays as a local optional extension until 0.5.0. Same change as #20500.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20500 +/- ##
==========================================
- Coverage 85.71% 85.70% -0.02%
==========================================
Files 3558 3558
Lines 170613 170613
Branches 46772 46772
==========================================
- Hits 146249 146225 -24
- Misses 22353 22377 +24
Partials 2011 2011
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
|
…kspace refresh failures (Comfy-Org#20531) ## Summary This PR closes out two follow-ups from FE-3297. It moves the Desktop host bridge types to `@comfyorg/comfyui-desktop-bridge-types` 0.5.0, and it reports a refresh failure that was previously swallowed. **Why:** - 0.5.0, published with Comfy-Org/Comfy-Desktop#1671, adds `switchWorkspace` to `ComfyDesktop2AuthBridge`. Since Comfy-Org#20500 we have kept a local copy of that one member, which can now go. - A CodeRabbit finding on Comfy-Org#20484 (deferred so the approved head would not be reset): when the tab follows a Desktop workspace switch and the list refresh fails, the failure was swallowed by `.catch(() => undefined)`. **How:** - Pin 0.5.0, with the release-age exclusion moved from 0.4.0 to 0.5.0. `DesktopHostAuthBridge` is now the package type with `switchWorkspace` made optional. Desktop builds older than Comfy-Org#1671 do not ship that method, and the account menu already falls back to a fixed workspace row for them. - `followDesktopHostWorkspace` reports the refresh failure via `reportError` (`error_refreshing_workspaces_for_desktop_host`). The tab still keeps no active workspace, which is the fail-closed behaviour Christian asked for on Comfy-Org#20484. No UI change, so there are no AS IS/TO BE screenshots. ## Verification - The new store test (a failed refresh is reported and the active workspace stays null) fails on `main` and passes here. - Desktop host, auth store, workspace store and account popover suites: 318 tests pass. - `pnpm typecheck:app` is clean. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Summary
The Desktop host auth bridge no longer keeps a hand-declared copy of Desktop's auth response contract. It takes
ComfyDesktop2AuthStateandComfyDesktop2AuthBridgefrom@comfyorg/comfyui-desktop-bridge-types, bumped from 0.3.0 to 0.4.0. Follow-up to #20383 and #20484 (FE-3297).Why: review on the 1.56 backports of #20484 (#20493, #20494) flagged the local
DesktopHostAuthState/DesktopHostAuthBridgeas a copy of a published shared contract that can drift. Version 0.4.0, published Oct 7, exports both types; the pin was just behind.How:
minimumReleaseAgeExcludeentry because 0.4.0 is under the release-age gate; the entry replaces the 0.3.0 one.DesktopHostAuthStateis now an alias ofComfyDesktop2AuthState.DesktopHostAuthBridgeextendsComfyDesktop2AuthBridgeand adds only the optionalswitchWorkspace. That method ships in bridge types 0.5.0 with feat(auth): let the hosted view switch Desktop's workspace Comfy-Desktop#1671, which is not merged or published yet. It stays optional for Desktop builds without it.Types only, with no runtime or UI change, so there are no AS IS/TO BE screenshots.
Verification
pnpm typecheck:appis clean.