Repository navigation
FE-3263 feat(telemetry): group WorkspaceApiError in Sentry by operation, status and code - #20344
Conversation
…on, status and code
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bc69ba46e59621dcfa4c5c5aa3c9761419496de6
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.3 MB gzip 🔴 +288 BDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 672 kB (baseline 672 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 7 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 1 unchanged UI Components — 205 kB (baseline 205 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 11 unchanged Data & Services — 4.19 MB (baseline 4.19 MB) • 🔴 +456 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 18 unchanged Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • 🔴 +889 BBundles that do not match a named category
Status: 89 added / 89 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T21:51:10.154Z",
"gitSha": "06f2d98bf965aaf54051aef19d1c7d1ad5b4cde7",
"branch": "dante/workspace-api-error-grouping",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.9949999999753,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.135,
"heapDeltaBytes": 3082424,
"heapUsedBytes": 63811660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.823000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2041.6989999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6969999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.29999999999995,
"heapDeltaBytes": -51643400,
"heapUsedBytes": 56048500,
"domNodes": -212,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 9.642000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.0490000000364,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.087000000000002,
"layouts": 12,
"layoutDurationMs": 4.267,
"taskDurationMs": 819.8369999999999,
"heapDeltaBytes": 3601424,
"heapUsedBytes": 72525040,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 166.745,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.7469999998966,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.423000000000002,
"layouts": 12,
"layoutDurationMs": 4.892,
"taskDurationMs": 795.9019999999999,
"heapDeltaBytes": -489764,
"heapUsedBytes": 62274480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.479,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.135000000023,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.0040000000000004,
"layouts": 3,
"layoutDurationMs": 0.8190000000000001,
"taskDurationMs": 344.82,
"heapDeltaBytes": 5357000,
"heapUsedBytes": 65701924,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.908999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.651000000018,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.517999999999998,
"layouts": 3,
"layoutDurationMs": 0.912,
"taskDurationMs": 369.637,
"heapDeltaBytes": 5586736,
"heapUsedBytes": 66784060,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.666,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 655.9560000000033,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.692000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.058,
"heapDeltaBytes": -6084916,
"heapUsedBytes": 62517376,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.307,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 627.6209999999764,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2950000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.3250000000001,
"heapDeltaBytes": 18194716,
"heapUsedBytes": 80681668,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 162.017,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1155.7960000000094,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.527,
"heapDeltaBytes": 44056712,
"heapUsedBytes": 112438072,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 70.887,
"eventListeners": 0,
"totalBlockingTimeMs": 515,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.3390000000163,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.9730000000001,
"heapDeltaBytes": 16750284,
"heapUsedBytes": 88036976,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 65.888,
"eventListeners": 0,
"totalBlockingTimeMs": 512,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 890.5249999999683,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.496,
"heapDeltaBytes": -6627844,
"heapUsedBytes": 81272240,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 172.87499999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.23714285714289,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.7579999999089,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.1169999999999,
"heapDeltaBytes": -6910044,
"heapUsedBytes": 80890880,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.50799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10655.124999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9719.643000000002,
"heapDeltaBytes": -1178716,
"heapUsedBytes": 85134540,
"domNodes": -141,
"jsHeapTotalBytes": -5640192,
"scriptDurationMs": 8045.710999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1299,
"frameDurationMs": 32.46829268292682,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9114.473999999973,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.38900000000000046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8273.094000000001,
"heapDeltaBytes": -11552796,
"heapUsedBytes": 73772920,
"domNodes": -141,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 6991.455,
"eventListeners": -73,
"totalBlockingTimeMs": 801,
"frameDurationMs": 32.21272084805654,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10253.052999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9451.689,
"heapDeltaBytes": 3584564,
"heapUsedBytes": 84558748,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 7744.193,
"eventListeners": 0,
"totalBlockingTimeMs": 935,
"frameDurationMs": 31.440490797546012,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9435.831999999891,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.367000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8636.92,
"heapDeltaBytes": -15380356,
"heapUsedBytes": 70246040,
"domNodes": -141,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7079.953,
"eventListeners": -73,
"totalBlockingTimeMs": 825,
"frameDurationMs": 31.234768211920528,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2023.145999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6899999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.5759999999999,
"heapDeltaBytes": -5046716,
"heapUsedBytes": 74726692,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.03900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.1129999999803,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.049,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.8679999999999,
"heapDeltaBytes": -2995828,
"heapUsedBytes": 86205452,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 41.43900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2323.9379999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.298999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1591.7559999999996,
"heapDeltaBytes": 16183016,
"heapUsedBytes": 92539828,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 833.4970000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666187050359714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2374.170999999933,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.889000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1632.647,
"heapDeltaBytes": 14237960,
"heapUsedBytes": 91987832,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 845.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3682.448999999963,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.460999999999999,
"layouts": 60,
"layoutDurationMs": 16.142,
"taskDurationMs": 1684.1750000000002,
"heapDeltaBytes": 5718276,
"heapUsedBytes": 74364048,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 806.0240000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66651583710407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3590.210999999954,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.065000000000001,
"layouts": 60,
"layoutDurationMs": 16.323999999999998,
"taskDurationMs": 1719.1999999999998,
"heapDeltaBytes": -14587844,
"heapUsedBytes": 73618020,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 799.495,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604651162791,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2963.7710000000084,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.013000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.4999999999998,
"heapDeltaBytes": -11193728,
"heapUsedBytes": 72399968,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 983.9209999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760227272727267,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3038.7680000000046,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.601999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.8519999999999,
"heapDeltaBytes": -11621104,
"heapUsedBytes": 70494772,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 979.0989999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723756,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.7540000000058,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2510000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.5210000000001,
"heapDeltaBytes": -2285204,
"heapUsedBytes": 88105616,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 35.07299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.400999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.8330000000001,
"heapDeltaBytes": -2893368,
"heapUsedBytes": 87798760,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.556999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2729999999965,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.489999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.548,
"heapDeltaBytes": -10237868,
"heapUsedBytes": 60634028,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.49200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.7979999999634,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.429999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.112,
"heapDeltaBytes": -9965160,
"heapUsedBytes": 60812788,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 144.056,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7050000000304,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.1209999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.235,
"heapDeltaBytes": 8101392,
"heapUsedBytes": 78924008,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.522999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2008.5390000000416,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7070000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.72,
"heapDeltaBytes": 8106932,
"heapUsedBytes": 78802828,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.565000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.5140000000033,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.61,
"layouts": 16,
"layoutDurationMs": 4.948,
"taskDurationMs": 759.9050000000001,
"heapDeltaBytes": -753284,
"heapUsedBytes": 70480376,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.25599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.9060000000181,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.894,
"layouts": 16,
"layoutDurationMs": 6.971000000000001,
"taskDurationMs": 765.475,
"heapDeltaBytes": 21175492,
"heapUsedBytes": 76497940,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.20100000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.2239999999329,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.91099999999999,
"layouts": 5,
"layoutDurationMs": 15.447000000000003,
"taskDurationMs": 1006.337,
"heapDeltaBytes": 32253488,
"heapUsedBytes": 107248740,
"domNodes": 14570,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 33.164,
"eventListeners": 2458,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8621.100999999953,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.212,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5610.982,
"heapDeltaBytes": -19025904,
"heapUsedBytes": 70025124,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2744.234,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8678.049999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.945999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5774.4529999999995,
"heapDeltaBytes": 11396748,
"heapUsedBytes": 91084800,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 2767.391,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69826923076923,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18643.98,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17901.419,
"heapDeltaBytes": -17113304,
"heapUsedBytes": 181565064,
"domNodes": -3046,
"jsHeapTotalBytes": 7917568,
"scriptDurationMs": 287.596,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.608813559322034,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 19041.691999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18547.450999999997,
"heapDeltaBytes": -34012228,
"heapUsedBytes": 181065808,
"domNodes": -3046,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 315.024,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.368367346938776,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 23086.963999999967,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22721.240999999998,
"heapDeltaBytes": -27399596,
"heapUsedBytes": 187505268,
"domNodes": -3046,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 940.723,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 42.93494423791822,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22906.888999999977,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.232999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22561.503,
"heapDeltaBytes": -21759800,
"heapUsedBytes": 188971740,
"domNodes": -3048,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 886.9630000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 42.96266416510319,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6605.79899999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.13399999999997,
"layouts": 20,
"layoutDurationMs": 24.437000000000015,
"taskDurationMs": 6494.23,
"heapDeltaBytes": 1075692,
"heapUsedBytes": 215982692,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.13199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.262087912087914,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6638.1509999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.6,
"layouts": 20,
"layoutDurationMs": 23.924000000000014,
"taskDurationMs": 6455.3409999999985,
"heapDeltaBytes": 1059052,
"heapUsedBytes": 216215768,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.209,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.4456043956044,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9630.705999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9188.958999999999,
"heapDeltaBytes": -33050632,
"heapUsedBytes": 182695384,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 144.77000000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.487162162162164,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9674.759999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9344.11,
"heapDeltaBytes": -43167648,
"heapUsedBytes": 181561416,
"domNodes": -3046,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 223.87,
"eventListeners": -14914,
"totalBlockingTimeMs": 29,
"frameDurationMs": 33.217525773195874,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 126.7760000000635,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.123000000000001,
"layouts": 4,
"layoutDurationMs": 2.1380000000000003,
"taskDurationMs": 100.576,
"heapDeltaBytes": 4315520,
"heapUsedBytes": 70484556,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.224000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.675000000000068,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.30199999999968,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.691,
"layouts": 3,
"layoutDurationMs": 1.347,
"taskDurationMs": 79.96900000000001,
"heapDeltaBytes": 3962308,
"heapUsedBytes": 69778064,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.214999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 807.0240000000695,
"styleRecalcs": 78,
"styleRecalcDurationMs": 85.73899999999999,
"layouts": 76,
"layoutDurationMs": 26.072000000000003,
"taskDurationMs": 779.996,
"heapDeltaBytes": 17501448,
"heapUsedBytes": 95118336,
"domNodes": 76,
"jsHeapTotalBytes": 17039360,
"scriptDurationMs": 322.262,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448968,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 814.832000000024,
"styleRecalcs": 78,
"styleRecalcDurationMs": 86.955,
"layouts": 76,
"layoutDurationMs": 25.317,
"taskDurationMs": 783.381,
"heapDeltaBytes": 17591884,
"heapUsedBytes": 88201688,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 319.667,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667346938775506,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1406.06200000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.677,
"layouts": 76,
"layoutDurationMs": 28.558,
"taskDurationMs": 1384.452,
"heapDeltaBytes": 13898720,
"heapUsedBytes": 130827736,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 483.68,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.707500000000003,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1434.5650000000205,
"styleRecalcs": 78,
"styleRecalcDurationMs": 254.42700000000002,
"layouts": 76,
"layoutDurationMs": 29.590999999999998,
"taskDurationMs": 1406.258,
"heapDeltaBytes": 14079520,
"heapUsedBytes": 128910984,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 484.691,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493825,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2237 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughWorkspace API errors now include the operation name that failed. Sentry initialization uses a callback that filters third-party errors and adds tags and fingerprints to workspace API error events. ChangesWorkspace API Error Telemetry
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds operation, status and code tags and fingerprints to workspace API errors in Sentry. It does not change user-facing behavior. Existing workspace API error issues in Sentry will stop receiving events, as the PR states. No merge-blocking risk is evident. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is limited to error telemetry. Workspace authentication, request destinations, and billing sequencing remain unchanged. Operation labels are fixed method names, not workspace identifiers. Server error codes are newly sent to Sentry, but their production contents and privacy constraints have not been established. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #20344 +/- ##
==========================================
+ Coverage 85.48% 86.28% +0.80%
==========================================
Files 3528 2487 -1041
Lines 169353 141392 -27961
Branches 46383 38430 -7953
==========================================
- Hits 144769 121999 -22770
+ Misses 22590 19012 -3578
+ Partials 1994 381 -1613
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1048 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@dante01yoon Successfully backported to #20347 |
|
@dante01yoon Successfully backported to #20348 |
…-up dialog (Comfy-Org#20367) ## Summary The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in Comfy-Org#20344. ## Verification - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. --- _Generated by [Claude Code](https://claude.ai/code/session_011Ay6DXcEaDGFw3Y47D9xZq)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
…vey and retention offer (#20487) ## Why Manual backport of #19671 to `cloud/1.56`. The auto-backport failed on conflicts. ## Root cause - `src/platform/remoteConfig/serverFeatureFlag.ts`: modify/delete. #19089 (moves `ServerFeatureFlag` into that file) is not on `cloud/1.56`, so the enum still lives in `src/composables/useFeatureFlags.ts`. - `src/platform/workspace/api/workspaceApi.ts`: main's `handleAxiosError(err, operation)` comes from #20344, whose backport #20348 is still open. On `cloud/1.56` it takes only the error. The retention route types were already on `cloud/1.56` (#20364), so nothing else was missing. ## How - Cherry-picked 0ccdb81. - Kept `serverFeatureFlag.ts` deleted and dropped `CHURNKEY_APP_ID` from the enum in `useFeatureFlags.ts`. The cherry-pick had already removed its getter and telemetry entry. - `prepareRetentionFlow`, `acceptRetentionOffer` and `recordRetentionFlowEvent` call `handleAxiosError(err)`. When #20348 lands after this, it needs operation names for these three calls, since its `operation` parameter is required. ## Test plan - [x] Vitest across `src/platform/cloud/subscription`, `src/platform/workspace`, `src/services`, `src/components/dialog/content/subscription`, `src/platform/telemetry`, `src/composables/billing`, `src/platform/remoteConfig`, feature flags and `numberUtil`: 4,329 passed, 1 failed. The failure is `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe"), which fails identically on unmodified `cloud/1.56` (Firebase `INTERNAL ASSERTION FAILED`). - [x] `typecheck:app`, `typecheck:browser`, `typecheck:account-core`, oxlint and eslint clean (pre-commit). knip and fallow clean (pre-push). - [ ] Playwright `cloud` project: CI
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
…-up dialog (#20367) The workspace top-up dialog called `GET /api/billing/payment-methods` to pick a payment note ("charged immediately" or "add a payment method" with a Manage billing link). The server refuses that read while embedded checkout is disabled. Embedded checkout is retired, and `embedded_checked_enabled` was `false` in every one of 45.7k production sessions over the last 14 days. As a result the note never rendered, and every open of the dialog reported `saved_payment_methods_read_failure` to Sentry and Datadog (1,114 events in 14d; 1,043 of them say `Embedded checkout is disabled`, and the rail's 73 `REQUEST_FAILED` come from the same call). This PR removes the read, the note, its Manage billing button and the `useHasSavedPaymentMethod` composable, which had no other caller. Subscription checkout already skips this read when the flag is off (`loadSavedPaymentMethods` in `useSubscriptionCheckout.ts`). billing-web is unaffected. It does not import from `src/`; it reads payment methods through `@comfyorg/account-core` (`PaymentMethodsPanel`, `useFullPageCheckout`, `useFullPageTopup`). This PR does not touch `packages/`. Follow-ups, not in this PR: - billing-web calls the same endpoint. Before `hosted_billing_destination` moves off `stripe` (it is `stripe` for every production session today), confirm that the server no longer gates `/billing/payment-methods` on embedded checkout. - Removing the rest of the `embedded_checked_enabled` code from `src/` is a separate cleanup. Part of the WorkspaceApiError triage started in #20344. - `pnpm test:unit src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 60 passed. The four tests for the removed note and button were deleted. The no-payment-method refusal test, which comes from the top-up response, is unchanged. - The pre-commit hook (oxfmt, oxlint, eslint, `typecheck:app`) and the pre-push hook (knip) pass. - After release, `saved_payment_methods_read_failure` should drop to zero in Datadog RUM (`env:prod-v2`) and in Sentry. (cherry picked from commit dc55612)
|
…eration they replace (Comfy-Org#20714) ## Why Comfy-Org#20344 added `operation`-based fingerprints for `WorkspaceApiError`, but in production (1.56.3, last 7d) **all 666** tagged events have an empty `workspace_api_operation`, so none of them got the new grouping. Every one of them is a billing read on the SDK rail, not a legacy HTTP call: | code | status | events | |---|---|---| | REQUEST_FAILED | none | 536 | | REQUEST_FAILED | 400 | 111 | | NOT_AUTHENTICATED | none | 13 | | MALFORMED_RESPONSE | 200 | 4 | | REQUEST_FAILED | 200 | 2 | ## Root cause `readOnRail` turns a failed SDK read into `WorkspaceApiError(code, httpStatus, code)` with no `operation`. `sentryBeforeSend` only fingerprints errors that carry one, so these fall back to message grouping, and the message is just the code (`REQUEST_FAILED`). Reads of status, balance, capabilities, plans, payment methods and events all land in the same issue. ## How - `readOnRail(read, operation)` now requires the `workspaceApi` method the read replaces (`WorkspaceApiOperation`, exported). A read on either rail lands in the same Sentry group, e.g. `[WorkspaceApiError, getBillingStatus, 400, REQUEST_FAILED]`. - All 8 call sites pass their legacy counterpart: `getBillingStatus`, `getBillingBalance`, `getBillingCapabilities`, `getBillingPlans`, `listSavedPaymentMethods`, `getBillingEvents`. - SDK operation refusals (`subscriptionOperationView`, `topupOperationView`) still have no `operation` and keep default grouping; unchanged. - `readOnRail.test.ts` checks a failed read through `sentryBeforeSend` gets the operation fingerprint and tag. ## AS IS / TO BE No UI change. Sentry event for an SDK-rail status read that fails with a 400: AS IS ```json { "tags": { "workspace_api_status": "400", "workspace_api_code": "REQUEST_FAILED" } } ``` TO BE ```json { "tags": { "workspace_api_operation": "getBillingStatus", "workspace_api_status": "400", "workspace_api_code": "REQUEST_FAILED" }, "fingerprint": ["WorkspaceApiError", "getBillingStatus", "400", "REQUEST_FAILED"] } ``` ## Plan position | # | Item | Ticket | PR | Status | |---|------|--------|----|--------| | 1 | Group WorkspaceApiError by operation/status/code | FE-3263 | Comfy-Org#20344 | merged | | 1b | **Same grouping for SDK-rail reads** | FE-3263 | **this PR** | **open** | | 2 | One-off triage pass over the regrouped issues | — | — | next, after 1b ships | | 3 | Code-side expected-failure allowlist + report-after-final-retry | — | — | planned | | 4 | Codify the triage as a skill, then schedule it (read-only Sentry, PRs only) | — | — | planned | ```mermaid graph LR A["Group WorkspaceApiError (Comfy-Org#20344)"] --> A2["SDK-rail reads (this PR)"] A2 --> B["One-off triage pass"] B --> C["Expected-failure allowlist"] B --> D["Triage skill + schedule"] C --> D style A2 fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ``` - Related FE-3263
Why
Sentry groups
WorkspaceApiErrorby message and stack. Failures from every workspace/billing endpoint end up in a few large issues that don't say which endpoint failed or what the server answered, so they can't be triaged, silenced or archived one at a time. This PR is the first step for the error-triage loop discussed in Slack.Root cause
handleAxiosErrorinworkspaceApi.tsturns an axios error intoWorkspaceApiError(message, status, code). It drops the request that failed.statusandcodeare own properties of the error, and the cloud Sentry config has noExtraErrorDataintegration, so neither field reaches Sentry. The only grouping signal left is the message and the stack.How
WorkspaceApiErrorgets an optionaloperation: the name of theworkspaceApimethod that failed. EveryhandleAxiosError(err, '<method>')call passes it. It is typed askeyof typeof workspaceApi, so a typo or a renamed method fails typecheck. A method name is low-cardinality and needs no URL templating; ids in the path such asworkspaceId,inviteIdandopIdnever reach the group key.sentryBeforeSendruns the existing third-party filter first. Then, for aWorkspaceApiError:workspace_api_operation,workspace_api_statusandworkspace_api_code(nonewhen absent);fingerprint = [error.name, operation, status, code], soNoWorkspaceAccessErrorstays a separate group.readOnRail) has nooperation. It gets the tags but keeps Sentry's default grouping, so unrelated SDK refusals that share a status/code aren't merged.Note: changing the fingerprint opens new Sentry issues for these errors. The existing
WorkspaceApiErrorissues stop receiving events and can be archived once this ships.AS IS / TO BE
No UI change. What changes is the Sentry event that
beforeSendemits for agetBillingCapabilitiestimeout (QA-28):AS IS
{ "exception": [{ "type": "WorkspaceApiError", "value": "timeout of 10000ms exceeded" }], "tags": { "error_type": "...", "surface": "billing" } }TO BE
{ "exception": [{ "type": "WorkspaceApiError", "value": "timeout of 10000ms exceeded" }], "tags": { "error_type": "...", "surface": "billing", "workspace_api_operation": "getBillingCapabilities", "workspace_api_status": "none", "workspace_api_code": "none" }, "fingerprint": ["WorkspaceApiError", "getBillingCapabilities", "none", "none"] }Plan position