Repository navigation
FE-3297 refactor(auth): use bridge types 0.5.0 and report Desktop workspace refresh failures - #20531
Conversation
…efresh failures 0.5.0 publishes switchWorkspace on ComfyDesktop2AuthBridge; the host bridge now takes it from the package and keeps it optional only for older Desktop builds. A failed list refresh while following a Desktop workspace switch is now reported instead of swallowed; the tab still keeps no active workspace.
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b786346badf345d2782e81504bf46b4df122e374
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.35 MB gzip 🔴 +185 BDetailsSummary
Category Glance App Entry Points — 4.43 kB (baseline 4.43 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.14 MB (baseline 2.14 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 5 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 19 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 325 kB (baseline 325 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • 🔴 +113 BStores, services, APIs, and repositories
Status: 18 added / 18 removed / 4 unchanged Utilities & Hooks — 812 kB (baseline 812 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 29 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 87 added / 87 removed / 260 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T16:58:56.205Z",
"gitSha": "574eb70400b32ea22a2df0f1a0bf729fd8a33644",
"branch": "jaewon/fe-3297-bridge-types-050",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.4280000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.123999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.01199999999994,
"heapDeltaBytes": 8715752,
"heapUsedBytes": 73384912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.978,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.4530000000314,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.392,
"heapDeltaBytes": 7806212,
"heapUsedBytes": 64680828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.612000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.6329999999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.759,
"layouts": 12,
"layoutDurationMs": 4.919,
"taskDurationMs": 904.0010000000001,
"heapDeltaBytes": -27557216,
"heapUsedBytes": 82165468,
"domNodes": -212,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 160.725,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.5979999999754,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.588999999999999,
"layouts": 12,
"layoutDurationMs": 4.388000000000001,
"taskDurationMs": 673.888,
"heapDeltaBytes": 3732040,
"heapUsedBytes": 66634664,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.43200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.7939999999735,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.800000000000001,
"layouts": 3,
"layoutDurationMs": 1.046,
"taskDurationMs": 345.638,
"heapDeltaBytes": 8071500,
"heapUsedBytes": 64245384,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.392000000000001,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.866000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 7.989999999999998,
"layouts": 3,
"layoutDurationMs": 0.8179999999999997,
"taskDurationMs": 419.32,
"heapDeltaBytes": -49041016,
"heapUsedBytes": 61332440,
"domNodes": -167,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.383999999999997,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 682.4439999999754,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.778000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.345,
"heapDeltaBytes": -38173176,
"heapUsedBytes": 72369388,
"domNodes": -212,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 181.876,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 668.3749999999691,
"styleRecalcs": 16,
"styleRecalcDurationMs": 5.473999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.701,
"heapDeltaBytes": -38522128,
"heapUsedBytes": 72053644,
"domNodes": -212,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 178.95999999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1134.6879999999828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.425,
"heapDeltaBytes": 13746032,
"heapUsedBytes": 99021708,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 66.57300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 508,
"frameDurationMs": 33.335294117647045,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.2960000000357,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.3439999999999,
"heapDeltaBytes": 14159440,
"heapUsedBytes": 99688036,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 76.40200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.1959999999735,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.1519999999997,
"heapDeltaBytes": 19789516,
"heapUsedBytes": 106900336,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 161.304,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.5259999999262,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.50399999999973,
"heapDeltaBytes": -5119188,
"heapUsedBytes": 102347488,
"domNodes": 0,
"jsHeapTotalBytes": 3411968,
"scriptDurationMs": 165.29100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9604.733000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8630.05,
"heapDeltaBytes": -1937072,
"heapUsedBytes": 80708576,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 7326.0779999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 928,
"frameDurationMs": 32.875,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9470.966999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8637.741,
"heapDeltaBytes": 1943492,
"heapUsedBytes": 85002352,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 7032.84,
"eventListeners": 0,
"totalBlockingTimeMs": 634,
"frameDurationMs": 31.554333333333336,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10856.709000000024,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.44399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9999.898,
"heapDeltaBytes": 26933540,
"heapUsedBytes": 99955728,
"domNodes": -141,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 8340.983000000002,
"eventListeners": -65,
"totalBlockingTimeMs": 1231,
"frameDurationMs": 32.09940828402367,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10873.025999999982,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3630000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10037.048,
"heapDeltaBytes": 19161992,
"heapUsedBytes": 92805648,
"domNodes": -141,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 8400.434000000001,
"eventListeners": -65,
"totalBlockingTimeMs": 1435,
"frameDurationMs": 32.10265486725664,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 219.18899999997166,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.245999999999995,
"layouts": 5,
"layoutDurationMs": 1.836,
"taskDurationMs": 163.632,
"heapDeltaBytes": -10591988,
"heapUsedBytes": 76387908,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.088,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.066666666666606,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 191.9510000000173,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.611,
"layouts": 5,
"layoutDurationMs": 1.9459999999999997,
"taskDurationMs": 140.20299999999997,
"heapDeltaBytes": 12137860,
"heapUsedBytes": 77390684,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.17,
"eventListeners": 202,
"totalBlockingTimeMs": 3,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2007.7969999999823,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4850000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.678,
"heapDeltaBytes": 2459200,
"heapUsedBytes": 94381020,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.233000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2060.479999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.132000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.784,
"heapDeltaBytes": -46663956,
"heapUsedBytes": 87154388,
"domNodes": -308,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 33.50600000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2206.5059999999903,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.473000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1483.506,
"heapDeltaBytes": 7774744,
"heapUsedBytes": 98142316,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 873.36,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666412213740454,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2297.7050000000645,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.866,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.6470000000002,
"heapDeltaBytes": 23468672,
"heapUsedBytes": 88948868,
"domNodes": -308,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 816.079,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985512,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3566.086999999982,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.642000000000001,
"layouts": 60,
"layoutDurationMs": 15.968000000000004,
"taskDurationMs": 1669.9389999999999,
"heapDeltaBytes": 13989908,
"heapUsedBytes": 86055264,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 777.667,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.262999999999,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.812000000000001,
"layouts": 60,
"layoutDurationMs": 16.812,
"taskDurationMs": 1676.6570000000002,
"heapDeltaBytes": 11998020,
"heapUsedBytes": 94826288,
"domNodes": 24,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 797.9430000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665898617511527,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2853.320999999994,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.585999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1851.556,
"heapDeltaBytes": 22690056,
"heapUsedBytes": 89650968,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 942.9369999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86390532544379,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2734.911000000011,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.779999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1674.1390000000004,
"heapDeltaBytes": 23882240,
"heapUsedBytes": 90974032,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 945.276,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768098159509208,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.614999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.965,
"heapDeltaBytes": -19504152,
"heapUsedBytes": 88462840,
"domNodes": -308,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 31.56300000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.5010000000111,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2309999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.967,
"heapDeltaBytes": -19689904,
"heapUsedBytes": 88482852,
"domNodes": -308,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 31.461999999999996,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.7419999999815,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.866999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.92199999999997,
"heapDeltaBytes": 14585540,
"heapUsedBytes": 81187680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.541,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.061999999939,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.949999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.062,
"heapDeltaBytes": -23758668,
"heapUsedBytes": 68239080,
"domNodes": -230,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 142.89499999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.9410000000266,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.612999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.17900000000003,
"heapDeltaBytes": 9114604,
"heapUsedBytes": 75805704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.626000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.461999999976,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.298,
"heapDeltaBytes": 9139776,
"heapUsedBytes": 75503376,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.832999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1748.9810000000148,
"styleRecalcs": 57,
"styleRecalcDurationMs": 15.274000000000001,
"layouts": 16,
"layoutDurationMs": 6.123,
"taskDurationMs": 820.967,
"heapDeltaBytes": -11902160,
"heapUsedBytes": 80331032,
"domNodes": -230,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 104.98800000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.8499999999758,
"styleRecalcs": 60,
"styleRecalcDurationMs": 16.120999999999995,
"layouts": 16,
"layoutDurationMs": 5.829000000000001,
"taskDurationMs": 855.8090000000001,
"heapDeltaBytes": -32600712,
"heapUsedBytes": 79036924,
"domNodes": -230,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 106.691,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.6700000000574,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.765,
"layouts": 6,
"layoutDurationMs": 14.577999999999998,
"taskDurationMs": 932.8150000000002,
"heapDeltaBytes": 34078148,
"heapUsedBytes": 113900088,
"domNodes": 14650,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 30.749,
"eventListeners": 2456,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.676388888888887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8756.551000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5816.222,
"heapDeltaBytes": -63861944,
"heapUsedBytes": 70076272,
"domNodes": -308,
"jsHeapTotalBytes": -3768320,
"scriptDurationMs": 2777.314,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697709923664124,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8266.939999999977,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4947.938000000001,
"heapDeltaBytes": -66460252,
"heapUsedBytes": 67259164,
"domNodes": -308,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 2674.7290000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18768.977000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18135.976,
"heapDeltaBytes": -44145372,
"heapUsedBytes": 185806016,
"domNodes": -3046,
"jsHeapTotalBytes": 11350016,
"scriptDurationMs": 280.38,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.91479591836735,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 13567.160999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12799.647999999997,
"heapDeltaBytes": -37519900,
"heapUsedBytes": 189297668,
"domNodes": -3046,
"jsHeapTotalBytes": 7970816,
"scriptDurationMs": 219.586,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.87706576728499,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 23870.762999999955,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.944999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23464.679,
"heapDeltaBytes": -38949284,
"heapUsedBytes": 191110624,
"domNodes": -3046,
"jsHeapTotalBytes": 9093120,
"scriptDurationMs": 967.9340000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 19,
"frameDurationMs": 44.19574074074074,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16825.612999999976,
"styleRecalcs": 121,
"styleRecalcDurationMs": 10.676999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16354.201,
"heapDeltaBytes": -27317404,
"heapUsedBytes": 190908568,
"domNodes": -3046,
"jsHeapTotalBytes": 8077312,
"scriptDurationMs": 843.6170000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 10,
"frameDurationMs": 29.95124555160142,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 6696.634000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.94000000000001,
"layouts": 20,
"layoutDurationMs": 24.62399999999999,
"taskDurationMs": 6574.168,
"heapDeltaBytes": 5224108,
"heapUsedBytes": 217922860,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 108.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.429050279329616,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6693.891000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.36600000000001,
"layouts": 20,
"layoutDurationMs": 23.835999999999995,
"taskDurationMs": 6575.029999999999,
"heapDeltaBytes": -13626176,
"heapUsedBytes": 216321804,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 112.75,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.18914285714285,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9575.311000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9149.101000000002,
"heapDeltaBytes": -30065500,
"heapUsedBytes": 185139368,
"domNodes": -3046,
"jsHeapTotalBytes": 8249344,
"scriptDurationMs": 210.777,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.53843537414966,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9323.747000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8895.902999999998,
"heapDeltaBytes": -30531948,
"heapUsedBytes": 184847580,
"domNodes": -3046,
"jsHeapTotalBytes": 10276864,
"scriptDurationMs": 155.69,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.530405405405407,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 209.35999999994692,
"styleRecalcs": 11,
"styleRecalcDurationMs": 20.775000000000002,
"layouts": 3,
"layoutDurationMs": 1.6959999999999997,
"taskDurationMs": 179.422,
"heapDeltaBytes": -52240768,
"heapUsedBytes": 55908004,
"domNodes": 122,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 17.177,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.699999999999985,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 121.3270000000648,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.381,
"layouts": 5,
"layoutDurationMs": 2.3739999999999997,
"taskDurationMs": 92.29100000000001,
"heapDeltaBytes": 4201508,
"heapUsedBytes": 66395792,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.727,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 836.1869999999954,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.81400000000001,
"layouts": 76,
"layoutDurationMs": 25.18,
"taskDurationMs": 811.774,
"heapDeltaBytes": 17764204,
"heapUsedBytes": 95130208,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 334.766,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 838.7319999999363,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.007,
"layouts": 76,
"layoutDurationMs": 24.452,
"taskDurationMs": 810.141,
"heapDeltaBytes": 17888176,
"heapUsedBytes": 94568268,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 338.76500000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1387.0520000000397,
"styleRecalcs": 77,
"styleRecalcDurationMs": 245.553,
"layouts": 76,
"layoutDurationMs": 27.712,
"taskDurationMs": 1361.61,
"heapDeltaBytes": 10516476,
"heapUsedBytes": 128828444,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 466.57800000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.291250000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1403.632000000016,
"styleRecalcs": 77,
"styleRecalcDurationMs": 250.16500000000002,
"layouts": 76,
"layoutDurationMs": 28.04,
"taskDurationMs": 1389.039,
"heapDeltaBytes": -19350548,
"heapUsedBytes": 118748108,
"domNodes": 77,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 494.109,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.930379746835442,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2249 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe desktop bridge types dependency is updated to version 0.5.0, and ChangesDesktop host workspace
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Failed Desktop workspace refreshes now surface an error without activating an unlisted workspace, and older hosts safely skip the optional switch method. No actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR contains a bug-fix signal: the commit subject
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20531 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.01%
==========================================
Files 3586 3586
Lines 171877 171878 +1
Branches 45155 47153 +1998
==========================================
- Hits 147508 147502 -6
- Misses 22354 22361 +7
Partials 2015 2015
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…-types-050 # Conflicts: # pnpm-workspace.yaml
christian-byrne
left a comment
There was a problem hiding this comment.
Verified at exact head db0f10ea79fe9bdcd9158d5560bc15dab92edae1. Bridge types bump to 0.5.0 is paired with making switchWorkspace genuinely optional in DesktopHostAuthBridge (works on Desktop builds both before and after Comfy-Org/Comfy-Desktop#1671, which is when the bridge gained it). The silently-swallowed refreshWorkspaces failure on a Desktop host switch now reports through reportError with a dedicated error type, with a regression test for the failure path. CI green, no open threads.
|
|
…nd report Desktop workspace refresh failures (#20531) (#20579) Backport of #20531 to `core/1.56`. **Why:** the bot's cherry-pick failed, and the 1.56 line should carry the bridge types 0.5.0 bump and the reported Desktop workspace refresh failure before 1.56.3 is cut for the Desktop SSO internal test. **Root cause (of the conflict):** `pnpm-workspace.yaml` `minimumReleaseAgeExclude` on `core/1.56` also lists `@comfyorg/comfy-multi-player@0.3.6`, next to the bridge-types `0.4.0` entry that #20531 replaces. **How:** cherry-picked the merge commit and kept the multi-player entry, replacing bridge-types `0.4.0` with `0.5.0`. The rest applied cleanly. `pnpm install --frozen-lockfile` resolves; the workspace store and Desktop host suites pass (125 tests). **AS IS / TO BE:** no UI change. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…and report Desktop workspace refresh failures (#20531) (#20580) Backport of #20531 to `cloud/1.56`. **Why:** the bot's cherry-pick failed, and the 1.56 line should carry the bridge types 0.5.0 bump and the reported Desktop workspace refresh failure before 1.56.3 is cut for the Desktop SSO internal test. **Root cause (of the conflict):** `pnpm-workspace.yaml` `minimumReleaseAgeExclude` on `cloud/1.56` also lists `@comfyorg/comfy-multi-player@0.3.6`, next to the bridge-types `0.4.0` entry that #20531 replaces. **How:** cherry-picked the merge commit and kept the multi-player entry, replacing bridge-types `0.4.0` with `0.5.0`. The rest applied cleanly. `pnpm install --frozen-lockfile` resolves; the workspace store and Desktop host suites pass (125 tests). **AS IS / TO BE:** no UI change. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
Summary
This PR closes out two follow-ups from FE-3297. It moves the Desktop host bridge types to
@comfyorg/comfyui-desktop-bridge-types0.5.0, and it reports a refresh failure that was previously swallowed.Why:
switchWorkspacetoComfyDesktop2AuthBridge. Since FE-3297 refactor(auth): take the Desktop auth bridge types from the published package #20500 we have kept a local copy of that one member, which can now go..catch(() => undefined).How:
DesktopHostAuthBridgeis now the package type withswitchWorkspacemade optional. Desktop builds older than Change dialog to multi-window mode #1671 do not ship that method, and the account menu already falls back to a fixed workspace row for them.followDesktopHostWorkspacereports the refresh failure viareportError(error_refreshing_workspaces_for_desktop_host). The tab still keeps no active workspace, which is the fail-closed behaviour Christian asked for on FE-3297 feat(auth): switch workspaces in the Desktop-hosted view #20484.No UI change, so there are no AS IS/TO BE screenshots.
Verification
mainand passes here.pnpm typecheck:appis clean.