Repository navigation
fix(website): bump router catalog model count to 213 - #19574
Conversation
website-unit is red on main and on every PR: router-providers.test.ts counts the models the docs catalog lists fails because the live docs catalog (docs.comfy.org/development/comfy-router/models.md) has drifted to 213 unique model paths while ROUTER_CATALOG_MODEL_COUNT is still pinned at 212. Bump ROUTER_CATALOG_MODEL_COUNT 212 -> 213 and refresh ROUTER_PROVIDER_COVERAGE_VERIFIED_AT, same shape as #18843 which did the same for the 209 -> 212 drift.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 790e92c65f27dd797a0a3052e42038ed505e56ec
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19574.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-bt6lvt06h-comfyui.vercel.app Last updated: 2026-09-30T05:54:28Z for |
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19574 +/- ##
==========================================
- Coverage 85.18% 84.23% -0.96%
==========================================
Files 2414 3253 +839
Lines 136302 157848 +21546
Branches 35006 40935 +5929
==========================================
+ Hits 116115 132966 +16851
- Misses 19715 23091 +3376
- Partials 472 1791 +1319
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 982 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL: APPROVED at 4b68ba00e2. 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.
This is the right narrow fix. ROUTER_CATALOG_MODEL_COUNT goes 212 → 213 and ROUTER_PROVIDER_COVERAGE_VERIFIED_AT goes to 2026-09-30, with no other change, so all live-docs drift coverage and all page copy are kept. The Router page's "+N more models" / "Browse all 213 models" labels are derived from this constant, so they stay accurate.
Verified against the live docs: with CI=1 (so nothing skips), router-providers.test.ts, RouterProviderCoverageSection.test.ts and routerCopy.test.ts pass 13/13. That covers the catalog count (213 today) and the header, provider-row and Comfy-only preview checks.
Note for the PRs this unblocks: this turns website-unit green, but website-unit isn't a required check. Their required website-e2e currently fails on models-render-guard.spec.ts:169 (the /hub/models/ loader is visible 1005–1359 ms against a 1000 ms budget), which is a separate fix on main. Longer term, running these live checks on a schedule rather than in PR CI would stop docs changes from turning unrelated PRs red.
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
… 213 (#19574) (#19642) ## Summary Backport merged #19574 so the release branch website catalog assertion matches the live 213-model Router catalog. ## Changes - **What**: Bump `ROUTER_CATALOG_MODEL_COUNT` from 212 to 213 and refresh the verification date to 2026-09-30. - **Dependencies**: None. This is the complete one-file source diff from merged #19574 (`cafc0dc37e7652a40a92850f71259b720b77788f`). ## Review Focus The parent `core/1.55` tip fails `router-providers.test.ts` with `expected 213 to be 212`; this exact head passes all 5 focused tests. Commit hooks also passed website typecheck, formatting/lint, and knip. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Robert Paige · Slack thread
Summary
website-unit/website-unit-gateis red onmainand on every PR because the live docs catalog has drifted past the hardcoded model count.Changes
router-providers.test.ts› "counts the models the docs catalog lists" fetchesdocs.comfy.org/development/comfy-router/models.mdand asserts the count of distinct model paths equalsROUTER_CATALOG_MODEL_COUNT. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. BumpedROUTER_CATALOG_MODEL_COUNT212 → 213 and refreshedROUTER_PROVIDER_COVERAGE_VERIFIED_ATto today, matching the shape of fix(website): bump the Router catalog model count to 212 #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched.Before / After
website-unitfails withexpected 213 to be 212; blocks unrelated PRs, including fix(website): polish comfy-api hero animation, badges, and page content #19565.website-unit/website-unit-gatepass again.Review Focus
Minimal, scoped change: only the two constants in
apps/website/src/config/router-providers.tswere touched, following the same pattern as #18843.Generated by Claude Code