Skip to content

fix(website): bump router catalog model count to 213 - #19574

Merged
benjcooley merged 1 commit into
mainfrom
fix/router-catalog-count-213
Sep 30, 2026
Merged

benjcooley merged 1 commit into
mainfrom
fix/router-catalog-count-213

Conversation

@claude

@claude claude Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Requested by Robert Paige · Slack thread

Summary

website-unit / website-unit-gate is red on main and on every PR because the live docs catalog has drifted past the hardcoded model count.

Changes

  • What: router-providers.test.ts › "counts the models the docs catalog lists" fetches docs.comfy.org/development/comfy-router/models.md and asserts the count of distinct model paths equals ROUTER_CATALOG_MODEL_COUNT. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped ROUTER_CATALOG_MODEL_COUNT 212 → 213 and refreshed ROUTER_PROVIDER_COVERAGE_VERIFIED_AT to today, matching the shape of fix(website): bump the Router catalog model count to 212 #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched.

Before / After

Review Focus

Minimal, scoped change: only the two constants in apps/website/src/config/router-providers.ts were touched, following the same pattern as #18843.


Generated by Claude Code

website-unit is red on main and on every PR: router-providers.test.ts
counts the models the docs catalog lists fails because the live
docs catalog (docs.comfy.org/development/comfy-router/models.md) has
drifted to 213 unique model paths while ROUTER_CATALOG_MODEL_COUNT is
still pinned at 212.

Bump ROUTER_CATALOG_MODEL_COUNT 212 -> 213 and refresh
ROUTER_PROVIDER_COVERAGE_VERIFIED_AT, same shape as #18843 which did
the same for the 209 -> 212 drift.
@claude
claude Bot requested a review from a team September 30, 2026 05:52
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 5:52am UTC
billing-web-test Ignored Ignored Sep 30, 2026 5:52am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 20a25d1c-eae2-4658-9d68-4e8ba3513054

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 790e92c65f27dd797a0a3052e42038ed505e56ec

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19574.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-bt6lvt06h-comfyui.vercel.app

Last updated: 2026-09-30T05:54:28Z for 4b68ba0

@claude

claude Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

build failure is pre-existing on main, unrelated to this PR

This PR only touches apps/website/src/config/router-providers.ts (ROUTER_CATALOG_MODEL_COUNT 212→213 and the verified-at date), which the CI: Website Build job doesn't reference at all.

The actual failure is check:link-slashes:

[link-slashes] 1 internal page href(s) lack a trailing slash or use https://www.comfy.org instead of https://comfy.org (2 links across 948 pages):
  /customers/svedka-silverside  (2 page(s), e.g. /platform/comfy-api/index.html, /zh-CN/platform/comfy-api/index.html)

That link lives in apps/website/src/templates/platform/ServerlessCustomerProofSection.vue:57 (href="/customers/svedka-silverside", missing the trailing slash), which was added by #19565.

Confirmed this is not caused by our change: the latest CI: Website Build run on main (run 36675322099, from merging #19565) is also failing with the identical check:link-slashes error, before this PR's commit ever entered the tree.

No action needed on this PR for the build check; it will go green once the svedka-silverside link is fixed on main (separately).

Requested by Robert Paige · Slack thread

🤖 Generated with Claude Code

https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19574      +/-   ##
==========================================
- Coverage   85.18%   84.23%   -0.96%     
==========================================
  Files        2414     3253     +839     
  Lines      136302   157848   +21546     
  Branches    35006    40935    +5929     
==========================================
+ Hits       116115   132966   +16851     
- Misses      19715    23091    +3376     
- Partials      472     1791    +1319     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/router-providers.ts 100.00% <100.00%> (ø)

... and 982 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at 4b68ba00e2. 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.

This is the right narrow fix. ROUTER_CATALOG_MODEL_COUNT goes 212 → 213 and ROUTER_PROVIDER_COVERAGE_VERIFIED_AT goes to 2026-09-30, with no other change, so all live-docs drift coverage and all page copy are kept. The Router page's "+N more models" / "Browse all 213 models" labels are derived from this constant, so they stay accurate.

Verified against the live docs: with CI=1 (so nothing skips), router-providers.test.ts, RouterProviderCoverageSection.test.ts and routerCopy.test.ts pass 13/13. That covers the catalog count (213 today) and the header, provider-row and Comfy-only preview checks.

Note for the PRs this unblocks: this turns website-unit green, but website-unit isn't a required check. Their required website-e2e currently fails on models-render-guard.spec.ts:169 (the /hub/models/ loader is visible 1005–1359 ms against a 1000 ms budget), which is a separate fix on main. Longer term, running these live checks on a schedule rather than in PR CI would stop docs changes from turning unrelated PRs red.

@benjcooley
benjcooley added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit cafc0dc Sep 30, 2026
92 of 93 checks passed
@benjcooley
benjcooley deleted the fix/router-catalog-count-213 branch September 30, 2026 06:43
claude Bot added a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

Co-authored-by: Claude <noreply@anthropic.com>
claude Bot added a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

Co-authored-by: Claude <noreply@anthropic.com>
christian-byrne pushed a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
christian-byrne pushed a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
christian-byrne added a commit that referenced this pull request Sep 30, 2026
… 213 (#19574) (#19642)

## Summary

Backport merged #19574 so the release branch website catalog assertion
matches the live 213-model Router catalog.

## Changes

- **What**: Bump `ROUTER_CATALOG_MODEL_COUNT` from 212 to 213 and
refresh the verification date to 2026-09-30.
- **Dependencies**: None. This is the complete one-file source diff from
merged #19574 (`cafc0dc37e7652a40a92850f71259b720b77788f`).

## Review Focus

The parent `core/1.55` tip fails `router-providers.test.ts` with
`expected 213 to be 212`; this exact head passes all 5 focused tests.
Commit hooks also passed website typecheck, formatting/lint, and knip.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants