Repository navigation
[backport core/1.55] feat: use generated ToolCallSummary type for persisted tool-call schema (#19585) - #19609
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d173dc61fc50e6a8a38bdde816abbbd6b98834b7
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T06:06:03.202Z",
"gitSha": "51cf81507cf9d48e857ebc69fb8a08dd272c82cf",
"branch": "backport-19585-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.9949999999844,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.455000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.529,
"heapDeltaBytes": 9236436,
"heapUsedBytes": 76886952,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.863999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.4989999999016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.29999999999995,
"heapDeltaBytes": -6396860,
"heapUsedBytes": 61228992,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.536,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.3479999999736,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.892000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 804.962,
"heapDeltaBytes": 13106072,
"heapUsedBytes": 80587608,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 163.46699999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.6020000000863,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.852999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.3349999999999,
"heapDeltaBytes": 10942112,
"heapUsedBytes": 78577180,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 167.062,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.1440000000075,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.227999999999998,
"layouts": 6,
"layoutDurationMs": 1.0429999999999997,
"taskDurationMs": 330.68699999999995,
"heapDeltaBytes": 3154996,
"heapUsedBytes": 70738928,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.713999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7539999999453,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.333000000000002,
"layouts": 6,
"layoutDurationMs": 0.9719999999999999,
"taskDurationMs": 321.051,
"heapDeltaBytes": 3119412,
"heapUsedBytes": 70759916,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.462,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 658.8730000000282,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.351999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.02799999999996,
"heapDeltaBytes": 18847084,
"heapUsedBytes": 86517344,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 172.08100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 611.1210000000256,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.358999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.05500000000006,
"heapDeltaBytes": 18881036,
"heapUsedBytes": 86558108,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 168.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1206.637999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.833,
"heapDeltaBytes": 12031576,
"heapUsedBytes": 89418780,
"domNodes": 0,
"jsHeapTotalBytes": 21131264,
"scriptDurationMs": 68.66499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 586,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.9930000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 878.862,
"heapDeltaBytes": -17603788,
"heapUsedBytes": 72527892,
"domNodes": -293,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 71.37,
"eventListeners": -217,
"totalBlockingTimeMs": 579,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4859999999844,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.6840000000001,
"heapDeltaBytes": 14591880,
"heapUsedBytes": 91519812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.42600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 852.5090000000546,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.0509999999999,
"heapDeltaBytes": 14632956,
"heapUsedBytes": 91628228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.94500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11170.242000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10170.428999999998,
"heapDeltaBytes": -5511952,
"heapUsedBytes": 76378616,
"domNodes": -14,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8712.936,
"eventListeners": 0,
"totalBlockingTimeMs": 1691,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10927.165999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10045.191,
"heapDeltaBytes": 985084,
"heapUsedBytes": 83886024,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8367.023,
"eventListeners": 0,
"totalBlockingTimeMs": 1320,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11440.944000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10532.474,
"heapDeltaBytes": 2382028,
"heapUsedBytes": 85238440,
"domNodes": -14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8807.288,
"eventListeners": 0,
"totalBlockingTimeMs": 1510,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11089.222999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10182.108,
"heapDeltaBytes": 10492760,
"heapUsedBytes": 84964984,
"domNodes": -4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 8454.121000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1514,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2043.8819999999964,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.428999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.981,
"heapDeltaBytes": -2411640,
"heapUsedBytes": 84006480,
"domNodes": -247,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 35.762,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.133000000068,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.815999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.9470000000001,
"heapDeltaBytes": -3529372,
"heapUsedBytes": 83422200,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.043000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2240.2210000000196,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.198999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1619.656,
"heapDeltaBytes": 19537236,
"heapUsedBytes": 84083700,
"domNodes": -246,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 839.623,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.410999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.367,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1473.8189999999997,
"heapDeltaBytes": -11636988,
"heapUsedBytes": 76591224,
"domNodes": -244,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 842.364,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3561.154999999985,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.987000000000004,
"layouts": 60,
"layoutDurationMs": 13.597999999999999,
"taskDurationMs": 1780.367,
"heapDeltaBytes": -16086164,
"heapUsedBytes": 73558924,
"domNodes": -256,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 810.169,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3550.4740000000083,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.476000000000004,
"layouts": 60,
"layoutDurationMs": 13.298,
"taskDurationMs": 1697.656,
"heapDeltaBytes": 8087144,
"heapUsedBytes": 74200648,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.081,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3118.5670000000414,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.998999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1937.6190000000001,
"heapDeltaBytes": 25628028,
"heapUsedBytes": 92088916,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1002.694,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3105.179000000021,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.798000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1897.1459999999997,
"heapDeltaBytes": 17314516,
"heapUsedBytes": 83354120,
"domNodes": 4,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 983.0060000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2018.619000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.9820000000001,
"heapDeltaBytes": -5093660,
"heapUsedBytes": 84283936,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 32.663,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.2950000000328,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.894,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.0019999999998,
"heapDeltaBytes": -3876656,
"heapUsedBytes": 84537996,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.904999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.860000000001,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.861,
"heapDeltaBytes": 13843984,
"heapUsedBytes": 83811704,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.89999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.1380000000709,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.46600000000007,
"heapDeltaBytes": 13699996,
"heapUsedBytes": 83948528,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.47799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.6070000000173,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.674999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.712,
"heapDeltaBytes": 5913116,
"heapUsedBytes": 75883280,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.677000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.0929999999744,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.688,
"heapDeltaBytes": 9310532,
"heapUsedBytes": 78755816,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.9159999999999995,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8789999999913,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.4159999999999,
"heapDeltaBytes": 8320956,
"heapUsedBytes": 78454372,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.656,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.2170000000806,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.136999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.435,
"heapDeltaBytes": -8932728,
"heapUsedBytes": 60602060,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.299,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.155999999999,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.994,
"layouts": 5,
"layoutDurationMs": 13.215000000000002,
"taskDurationMs": 869.9050000000002,
"heapDeltaBytes": -6293856,
"heapUsedBytes": 80936772,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.46200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8511.810999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.196,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6059.381,
"heapDeltaBytes": 14785156,
"heapUsedBytes": 78631576,
"domNodes": -243,
"jsHeapTotalBytes": 2027520,
"scriptDurationMs": 2974.418,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.599999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5827.035,
"heapDeltaBytes": -5200684,
"heapUsedBytes": 76319456,
"domNodes": -244,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2785.6549999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17094.03599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16666.003999999997,
"heapDeltaBytes": -42699140,
"heapUsedBytes": 171542316,
"domNodes": -8061,
"jsHeapTotalBytes": -8138752,
"scriptDurationMs": 268.245,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17298.556000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16762.681999999997,
"heapDeltaBytes": -41337416,
"heapUsedBytes": 184580660,
"domNodes": -8061,
"jsHeapTotalBytes": -13377536,
"scriptDurationMs": 281.13899999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20687.864999999987,
"styleRecalcs": 167,
"styleRecalcDurationMs": 17.478000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20415.082000000002,
"heapDeltaBytes": 8553228,
"heapUsedBytes": 192889004,
"domNodes": 0,
"jsHeapTotalBytes": -14749696,
"scriptDurationMs": 879.7570000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20844.85200000006,
"styleRecalcs": 160,
"styleRecalcDurationMs": 16.444000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20535.079,
"heapDeltaBytes": -50617492,
"heapUsedBytes": 170119520,
"domNodes": -8061,
"jsHeapTotalBytes": -20123648,
"scriptDurationMs": 860.986,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6206.362000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.91700000000002,
"layouts": 20,
"layoutDurationMs": 24.49499999999999,
"taskDurationMs": 6102.991,
"heapDeltaBytes": -57447832,
"heapUsedBytes": 182712672,
"domNodes": -8061,
"jsHeapTotalBytes": 12603392,
"scriptDurationMs": 106.67900000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 496,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6220.715000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.135,
"layouts": 20,
"layoutDurationMs": 24.601000000000013,
"taskDurationMs": 6121.164,
"heapDeltaBytes": -33861444,
"heapUsedBytes": 184996976,
"domNodes": -8061,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 110.723,
"eventListeners": -14928,
"totalBlockingTimeMs": 459,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8888.880999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8595.053,
"heapDeltaBytes": 262124,
"heapUsedBytes": 195239232,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 143.85499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8612.80899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8385.029999999999,
"heapDeltaBytes": -14856272,
"heapUsedBytes": 172202852,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 135.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 124.02499999996053,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.163999999999998,
"layouts": 4,
"layoutDurationMs": 2.244,
"taskDurationMs": 95.26199999999999,
"heapDeltaBytes": 3241588,
"heapUsedBytes": 68791816,
"domNodes": 134,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.951999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.03100000004451,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.780000000000003,
"layouts": 3,
"layoutDurationMs": 1.5739999999999998,
"taskDurationMs": 77.98299999999999,
"heapDeltaBytes": 3071568,
"heapUsedBytes": 65206228,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.544000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19609 +/- ##
=============================================
- Coverage 84.66% 83.80% -0.87%
=============================================
Files 2314 3072 +758
Lines 131658 150507 +18849
Branches 35139 40526 +5387
=============================================
+ Hits 111464 126125 +14661
- Misses 19835 22976 +3141
- Partials 359 1406 +1047
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 762 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
Root cause: This PR's diff only touches No fix needed in this PR; the stale count would need bumping directly on |
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
|
Adding the existing fix links for the website and billing failures at
Neither affected app is changed by this backport. Once those fixes land on The additional cloud Playwright standing-paywall failure discussed above remains a separate item. These two fixes do not address it; I have not confirmed a fix or established that it is flaky, so this is not a claim that they will make all CI green. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
856645f to
20f1c15
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review under the recorded core/1.55 release-backport authority at exact head 20f1c15. Reviewed the generated-file conflict resolution against source PR #19585: the carrier keeps the ToolCallSummary/AgentMessage.tool_calls additions and excludes the unrelated RenewalInvoice main-only drift. Reviewed the lenient REST boundary and per-entry parsing changes against all seven Cursor findings; each is addressed and the threads are resolved. Local focused evidence: 133/133 transcript/event/store tests pass, plus app and browser typechecks. The message-only rewrite changed 856645f to 20f1c15 with identical tree 57884ec67af6cafbd62520834362bf196fd39c0a and removed only forbidden Claude co-author trailers. Fresh hosted checks are running; this comment is review evidence, not a merge while checks are pending.
|
Exact-head classification at |
|
Repaired the exact-head cloud E2E failure at |
41e50fb to
4b13140
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review under the recorded core/1.55 release-backport authority at exact head 4b13140. The repaired range is one commit directly on core/1.55 tip 7c1c1c6 and changes only the nine files carried by merged #19585. The scope repair removed the unrelated website, billing, malformed-history compatibility, and paywall commits. The generated conflict resolution retains ToolCallSummary and AgentMessage.content.tool_calls while excluding unrelated RenewalInvoice drift. Local proof: 130 focused unit tests passed, browser typecheck passed, and agentToolCallHistoryPersistence.spec.ts passed 1/1 on the cloud Playwright project. Hosted checks are re-running at this head; this is review evidence, not a merge while checks are pending.
|
Heads up: the 17:01 UTC rescope (commit As a result, (Run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36748335049/job/110001753138 — Flagging in case the rescope was meant to keep the paywall fix alongside the pure backport — the fix and this ToolCallSummary change touch different files, so they shouldn't conflict if re-added. Generated by Claude Code |
…ma (#19585) Replaces the interim hand-written zPersistedToolCallSummary zod schema in agentApiSchema.ts with the generated zToolCallSummary from @comfyorg/ingest-types/zod, now that Comfy-Org/cloud#10360 added the ToolCallSummary OpenAPI schema for persisted tool-call history. Backport of #19585 to core/1.55. Manual backport: the automated bot's cherry-pick conflicted in packages/ingest-types/src/{types,zod}.gen.ts. The conflict was unrelated codegen drift (an unrelated RenewalInvoice billing type present on main but not yet generated on core/1.55) rather than a real conflict with this PR's change. Resolved by keeping only this PR's actual addition (ToolCallSummary type/schema, AgentMessage.content.tool_calls field) and dropping the unrelated RenewalInvoice hunk. Claude-Session: https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb
4b13140 to
5a2ca3d
Compare
|
Exact-head refresh under the recorded core/1.55 release-backport authority: head |
Backport of #19585 to
core/1.55.Scope
Carries the merged generated
ToolCallSummarypersisted-history contract and its existing tests across nine files:AgentMessage.content.tool_callsagentToolCallHistoryPersistence.spec.tsblack-box reload/chat-switch proofThe generated-file conflict was target drift:
mainalso contained an unrelatedRenewalInvoicetype absent fromcore/1.55. This carrier keeps only #19585 content and does not import that unrelated generated hunk.A scope repair removed four unrelated follow-up commits (website catalog count, billing checkout re-quote, malformed historical-row compatibility policy, and Agent paywall restoration). The resulting range is one commit based directly on the current
core/1.55tip.Verification
pnpm typecheck:browserpassedagentToolCallHistoryPersistence.spec.tspassed on the cloud Playwright project