Skip to content

fix(website): unblock builds and defer offscreen footer loading - #19580

Merged
benjcooley merged 3 commits into
mainfrom
fix/svedka-silverside-trailing-slash
Sep 30, 2026
Merged

benjcooley merged 3 commits into
mainfrom
fix/svedka-silverside-trailing-slash

Conversation

@claude

@claude claude Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix the customer-story link that breaks the website build and defer the off-screen footer animation so it does not compete with initial catalogue loading.

Changes

  • Add the missing trailing slash to the Svedka customer link, shared by the English and Chinese Comfy API pages, and update its assertion.
  • Hydrate the footer when it comes within 200px of the viewport. Its links remain server-rendered. The failed CI trace showed all 75 animation frames requested before the catalogue could load.
  • Add a browser regression proving no footer frames load while browsing the top of the catalogue and that they load after scrolling to the footer. The existing one-second loader and layout-shift limits are unchanged.

Review Focus

The new regression fails against main and passes with the fix. Production build, internal-link check, website typecheck, targeted lint/formatting, 12 unit tests, and 69 browser runs pass locally. Across 12 catalogue loads, the local median loader time fell from 198ms to 137ms; the maximum fell from 260ms to 169ms. CI must confirm the original budget on its runners.

Footer markup, styles, and animation are unchanged; only hydration timing changes.

The comfy-api platform page's customer proof section linked to
/customers/svedka-silverside without a trailing slash, failing the
check:link-slashes build check on main. Regression from #19565.
@claude
claude Bot requested a review from a team September 30, 2026 06:10
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 7:00am UTC
billing-web-test Ignored Ignored Sep 30, 2026 7:00am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 50fbd4f8-5167-4e15-a8d4-152b26c21eba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cafc0dc37e7652a40a92850f71259b720b77788f

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19580.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-i9ho8hl1z-comfyui.vercel.app

Last updated: 2026-09-30T07:03:24Z for bc9c841

@claude

claude Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

The website-unit check failure here is a pre-existing, repo-wide issue, not caused by this PR's trailing-slash fix.

The docs catalog gained a model, so ROUTER_CATALOG_MODEL_COUNT in apps/website/src/config/router-providers.ts is stale (212 vs. the current 213). This branch was cut from main before #19574 merged the fix, so it still carries the old constant and fails the same assertion:

FAIL src/config/router-providers.test.ts > Router provider coverage > counts the models the docs catalog lists
AssertionError: expected 213 to be 212
❯ src/config/router-providers.test.ts:145:25

Original diagnosis: #19574 (comment)
Fix (merged): #19574

This will go green once #19574 is merged into main and this branch is rebased/merged past it. No action needed on this PR's own changes.


Generated by Claude Code

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@datadog-official

This comment has been minimized.

@claude

claude Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

The website-e2e-shard (2, 4) failure here is the known pre-existing models-render-guard.spec.ts perf-budget flake, not caused by this PR's trailing-slash change.

Job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36679916865/job/109773521073

1) [desktop] › e2e/models-render-guard.spec.ts:169:9 › models pages at 393px › /hub/models/ with the flag on settles without a loader or layout jump
Error: ms after navigation the loader was last visible
expect(received).toBeLessThan(expected)
Expected: < 1000
Received:   1253.7999999999884   (attempt 1)
Received:   1689.5               (retry 1)
Received:   1000.7999999999884   (retry 2)

This is the same LOADER_GRACE_MS (1000ms) loader-visibility budget flagged by @benjcooley on #19574 as borderline-failing on main independent of any diff (they saw 1005-1359ms there). This PR only touches a href string in ServerlessCustomerProofSection.vue, nothing in the models hub render path, so it can't be the cause. Tightening/loosening the budget is a perf/product call, not something to patch here.

Re-ran just this shard job to check flakiness: it passed on retry (run attempt after rerun_failed_jobs), consistent with a borderline timing budget rather than a hard regression.


Generated by Claude Code

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19580      +/-   ##
==========================================
+ Coverage   84.21%   84.23%   +0.01%     
==========================================
  Files        3325     3253      -72     
  Lines      160026   157848    -2178     
  Branches    43556    42832     -724     
==========================================
- Hits       134768   132965    -1803     
+ Misses      23357    23092     -265     
+ Partials     1901     1791     -110     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...plates/platform/ServerlessCustomerProofSection.vue 100.00% <ø> (ø)

... and 115 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley changed the title fix(website): add trailing slash to svedka-silverside customer link fix(website): unblock builds and defer offscreen footer loading Sep 30, 2026

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at bc9c84181a. 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.

  • Footer defer: it's safe. SiteFooter is server-rendered links plus useFrameScrub (frames preloaded in onMounted, a GSAP ScrollTrigger). It has no global side effects, forms, consent or cross-island state, so client:visible={{ rootMargin: '200px' }} only delays the animation's 75 frame requests until the footer is within 200px. Links work before hydration, and a short page with the footer in view hydrates immediately. The markup, styles, animation and the 1000 ms / CLS budgets are unchanged.
  • Regression test: asserts no /footer-logo-seq/ request before the catalogue search is ready, then a successful frame response after scrolling the footer in.
  • Slash fix: /customers/svedka-silverside/; the page exists in en + zh-CN.

Verified independently (fresh worktree install; this clone's shared node_modules had a corrupt shiki entry):

  • CI-env build OK, and link-slashes "every internal page link in 948 pages ends with a slash";
  • models-render-guard + models-performance 67/69 at --repeat-each=3;
  • an interleaved A/B of the /hub/models/ guard cases against a build of this PR's base (main cafc0dc37e), 5 repeats per round:
Round main this PR
quiet 20/20 20/20
machine busy 8 misses, 1030–1261 ms 4 misses, 1024–1063 ms

So this is a real improvement: it halves the misses and removes most of the overshoot. CI on this head is fully green, including shard 3 (render-guard) and required website-e2e.

Residual: under load the /hub/models/ loader still lands near the 1 s budget, so the guard can still be marginal on a busy runner. If it recurs, the next step is shaving the catalogue's own time-to-ready, not loosening the budget.

@benjcooley
benjcooley added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 62cb6da Sep 30, 2026
91 checks passed
@benjcooley
benjcooley deleted the fix/svedka-silverside-trailing-slash branch September 30, 2026 07:16
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…ic Studio (Comfy-Org#19579)

## ELI5
Seedance 2.5 can turn a still picture into a video, but when you hand it
that starting picture it insists on keeping the picture's own shape — it
refuses any request that also names a frame size like 16:9. Cinematic
Studio was always naming one, so every "animate this still" attempt on
Seedance 2.5 was turned away. This stops asking for a frame size on that
model, and makes the failure message stop pointing at highlighted fields
that don't exist.

## Motivation
In Cinematic Studio, choosing Seedance 2.5 and adding a starting frame
fails every take with "This take failed — Check the highlighted fields,"
and nothing is highlighted. PostHog shows every studio Seedance 2.5 take
with a starting frame failing with a Router `400 invalid_input`, while
text-to-video on the same model succeeds. ComfyUI's own Seedance node
documents the constraint (`comfy_api_nodes/nodes_bytedance.py`): 2.5
accepts `ratio="adaptive"` only in first/last-frame mode and keeps the
first frame's aspect. The studio mapped the shot's frame onto `ratio`,
so the request could never succeed. The model page's own ratio control
could send the same value.

## Provenance
- **Authored by:** interactive session
- **Verified:** reproduced the failure in the live studio (two rejected
takes, request IDs recorded); rebuilt the studio's request body offline
before and after the change (`ratio` goes from `16:9` to `adaptive`);
`pnpm vitest run` on `src/lib/workshop/cinematic-studio` and
`src/components/workshop/cinematic-studio`: 40 files, 377 passed;
`src/config/workshop-contract.test.ts` +
`scripts/workshop-creator-forms.test.ts` (includes the packed-contracts
determinism check): passed; `src/components/workshop/cinematic-studio`
rerun after the styling commit: 17 files, 128 passed; the red message
previewed in the live studio failure card; `pnpm lint:unstaged:fix`: no
new findings
- **Deviations:** no live end-to-end generation after the fix; that
needs the deployed change. Before/after screenshots not attached.

## Reviewer context
- **Type:** bug fix — Seedance 2.5 image-to-video in Cinematic Studio
and its model page
- **Slots into:** no project or epic; ad-hoc work

## Summary
- `scripts/workshop-creator-forms.ts`: the Seedance 2.5 `first-last`
form fixes `ratio` to `adaptive` (a hidden const, sent through
`fixedValues`). Regenerated `workshop-router-contracts.json`; the only
change is that page's `ratio` input.
- The studio then sees no frame choice for this operation, so it stops
mapping the shot's aspect onto `ratio` and the clip keeps the starting
frame's shape, the same as Seedance 2.5 Edit. The model page no longer
shows a Ratio picker for this operation.
- `CinematicTakeNotice.vue`: a take the provider rejects without a field
error now uses the existing `workshop.error.inputRejected` copy. The
studio never highlights fields, so "Check the highlighted fields." was
always wrong there.
- `CinematicTakeNotice.vue`: failed, rejected and blocked takes show
their message at `text-base` in `text-primary-comfy-red`, the error text
token the model page's failure message already uses
(`PlaygroundOutput.vue`). Cancelled and out-of-credits notices keep the
neutral `text-primary-comfy-canvas`.
- Tests: a regression test that the prepared studio body carries `ratio:
"adaptive"`; a notice copy test; one existing `videoParameters`
expectation updated, since it asserted that `aspect_ratio: '21:9'`
reaches this operation.

## Test plan
- [ ] On the preview, open Cinematic Studio, pick Seedance 2.5, set a
starting frame (e.g. animate a finished still) and generate; the take
should render instead of failing
- [ ] With a starting frame set on Seedance 2.5, the Format frame menu
no longer changes the request
- [ ] Force a provider rejection (or use a stubbed 400) and confirm the
notice no longer says "Check the highlighted fields." and its message
shows in red, one size up
- [ ] `/models/byteplus--seedance-2-5-first-last-frame--animate-images/`
no longer shows a Ratio picker and its example still generates
- [ ] No feature flag: this fixes an existing flow rather than adding
behavior

## Shared CI fix

This branch includes the reviewed main-branch CI fixes from Comfy-Org#19580
(`bc9c84181a`): the Svedka customer-link trailing slash and
viewport-triggered hydration of the off-screen footer animation, with a
browser regression test. This lets CI validate the feature and shared
fix together; the feature implementation is unchanged by that merge.
Footer HTML, styling and links remain server-rendered, and the
catalogue's 1,000 ms loader limit and layout-shift limit are unchanged.
Comfy-Org#19580 remains the dedicated review and tracking PR for the shared fix.

---------

Co-authored-by: eric.sun <shengkai.sun@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…app pages to /hub/apps (Comfy-Org#19594)

## Summary

Workflows and apps get their own hub pages, `/hub/workflows/` and
`/hub/apps/`, instead of living as `?type=` tabs of `/hub/models/`, and
the two app pages move to `/hub/apps/<slug>/`. `/hub/models/` stays
models only, with its "ComfyUI models" H1 and A to Z directory.

Part of [FE-2912](https://linear.app/comfyorg/issue/FE-2912)

Deploy order: this PR goes live before the router change
(Comfy-Org/comfy-router#49). The router is what sends `/hub/workflows/`
and `/hub/apps/*` on comfy.org to this site, so shipping it first would
turn both pages into 404s.

## Changes

The section pages (first half):

- `src/routes/models/hub-section.astro` builds `/hub/workflows/` and
`/hub/apps/`, each with its own title, meta description, H1 and
self-canonical, and mounts `ModelsPage` with a `section` prop. It throws
at build time for a pattern it has no section for.
- Changed from the plan: the title, description and H1 (en and zh-CN)
live in `hub-section-copy.ts`, not `translations.ts`. `translations.ts`
ships whole to every island, so the six strings would have added about 1
KB for every visitor and pushed `/hub/models/` past the
`models-performance` JavaScript ceiling. They are only server-rendered.
- `ModelsCatalogue` renders the one section it is given rather than
reading `?type=`, and counts `catalogue_viewed` once per page with that
section's content type.
- `CatalogueTabs` has a `links` mode that renders `<a
aria-current="page">` inside a `<nav>`. The hub pages use it; the
homepage toggle keeps its buttons. The Workflows and Apps tabs are gated
by the same flags as today.
- With the workflows or apps flag off, `ModelsPage` shows the same
showcase fallback the workflow detail pages use, and the section heading
goes with the rest of the page. The heading is still server-rendered
over the loading state.
- The registry has a new `section` kind for the two pages: navigable,
and out of the sitemap unless indexable. `/hub/workflows/` follows
`launchedWorkflowPages` (noindex today); `/hub/apps/` is always noindex.
The llms.txt test now takes its exclusions from the sitemap policy, so
it skips both.
- `/hub/models/?type=workflows` (or `workflow`) and `?type=apps` run a
small head script that replaces the URL with the section page, keeping
the other query parameters and the hash.
- Back to workflows, the workflow shelf pills, the homepage workflows
button and Back to apps now link the section pages. `routes.ts` gains
`hubWorkflows` and `hubApps`, both locale-invariant.

The app move (second half):

- Cinematic Studio and Re-shoot build at `/hub/apps/<slug>/`.
`apps/<slug>` stays the id for content, flags and analytics.
- `src/config/hub-app-names.json` lists the built apps, kept honest by a
file-snapshot test like `hub-workflow-names.json`. The registry, the
redirects, the noindex list and the stale-link check all read it.
- `/models/apps/<slug>` and `/models/apps/<slug>/` send a temporary
redirect to `/hub/apps/<slug>/`, and they go permanent once the router
serves `/hub/apps/` on production. `vercel.json` gains exactly those
four rows.
- The README, the content README, `model-urls.ts` and `MODEL_URL_MAP.md`
describe the new layout.

## Review Focus

- The section pages have no markdown twin (`/hub/workflows.md`,
`/hub/apps.md`), which is deliberate: like every noindex page they are
out of the sitemap, so the twins integration skips them. Router #49
routes those two `.md` paths here, so they will 404 until the pages are
indexable.
- Between this deploy and router #49, `/models/apps/<slug>` redirects to
`/hub/apps/<slug>/` on comfy.org before the router sends that path here.
Apps are behind `workshop-apps-enabled`, so only people with the flag
are affected, and only for that window.
- A flag-off visitor who follows an old `?type=workflows` link now lands
on the showcase at `/hub/workflows/` rather than on the models
catalogue. That is the owner's call from the plan (`hub-section.astro`,
`ModelsPage.vue:34`).

## QA

- [x] Unit: the full website suite passes, and each new or changed test
failed against the code with its change reverted.
- [x] `/hub/models/` loads 1,824,561 bytes of JavaScript, 357 fewer than
main, under the 1,825,000 ceiling.
- [x] Build with the CI env (`WORKSHOP_IN_BUILD=1`, indexable), release
gate green; `check:hreflang`, `validate:llms-txt-links`,
`validate:jsonld` pass.
- [x] Website e2e on desktop and mobile, run twice.
- [x] `WORKSHOP_IN_BUILD=0` build keeps every Models page, the two new
ones included.
- [x] Browser pass on `astro preview`: the three hub pages, both app
pages, three workflow pages and the `?type=` links, flags on and off,
desktop and mobile.
- [x] `check:link-slashes` failed only on
`/customers/svedka-silverside`, which came from main and is fixed there
by Comfy-Org#19580.

Proof for each line is in the QA comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants