Repository navigation
Conversation
The catalog size was a hard-coded number checked against docs.comfy.org. The site has no in-repo source for that count, so the labels no longer show one. Co-authored-by: ShihChi Huang <huge.huang@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 07779a14ff2bcc195b0f32a2c5974cf09ce28a2f
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19581.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2a4mb7rls-comfyui.vercel.app Last updated: 2026-09-30T06:32:24Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe router coverage section now uses fixed “More models” and “Browse all models” labels in English and Chinese. The catalog model count constant and count-based label interpolation were removed. Related unit and browser tests were updated, and provider tests no longer check documentation coverage or catalog counts. ChangesRouter coverage labels
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The router now displays fixed English and Chinese labels without catalog counts, while retaining the browse-all destination. No merge-blocking issue is identified; merge after normal checks pass. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL: CHANGES REQUESTED at b0e4a61e10 (d66a0af12f + the bot's formatting commit)
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 0 |
SHOULD FIX 1: it removes far more coverage than the failing assertion. Only "counts the models the docs catalog lists" is broken (212 → 213). This PR also deletes the table-header check, "lists every model the docs show with an alternate provider" (provider list, every row served by Comfy, rows equal to ROUTER_PROVIDER_COVERAGE) and "previews catalog models that only Comfy serves". Those are the only guards that keep the Router page's provider-coverage table in sync with the published docs, and none of them is failing. Please keep them.
SHOULD FIX 2: it changes user-facing copy to fix a test. "+{count} more models" / "Browse all {count} models" become generic labels (en + zh-CN). Dropping the catalog size from the Router page is a product and copy decision for its owners, not a CI fix.
Recommended path:
- Today: #19574's one-line bump (212 → 213,
VERIFIED_AT2026-09-30) makes the check pass with no loss of coverage or copy. - Long term: the problem is that a live external check gates unrelated PRs. Keep the static data and all the drift checks, but run
router-providers.test.ts's live checks on a schedule (e.g. a nightly workflow that fails or opens an issue on drift) instead of in PRwebsite-unit. The count then gets bumped deliberately when the docs change.
Context: website-unit isn't a required check on main (test, lint-and-format, e2e-status, website-e2e are), so neither docs PR unblocks #19473 or #19579. Their required website-e2e fails on models-render-guard.spec.ts:169: the /hub/models/ loader is visible for 1005–1359 ms against a 1000 ms budget, on every retry, on both PRs. That's on main since #19494 moved the page to /hub/models/ (a build of main passes it locally, so it's CI-speed sensitive).
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19581 +/- ##
==========================================
- Coverage 85.18% 84.23% -0.96%
==========================================
Files 2414 3253 +839
Lines 136302 157847 +21545
Branches 36903 42832 +5929
==========================================
+ Hits 116114 132964 +16850
- Misses 19716 23092 +3376
- Partials 472 1791 +1319
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 980 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Stop unit tests from live-fetching the docs catalog count, and drop that hard-coded number from the router labels because the site has no in-repo source for it.
Verification
pnpm --filter @comfyorg/website test:unit— passed on Node 26 (package engines): 562 files, 10541 passed, 1 skippedpnpm typecheck:website— passed, 0 errorspnpm knip— passed, no unused exportspnpm exec eslint apps/website— passed