Skip to content

fix(website): drop live docs catalog count test - #19581

Closed
huang47 wants to merge 2 commits into
mainfrom
cursor/drop-live-docs-catalog-count-4c26
Closed

huang47 wants to merge 2 commits into
mainfrom
cursor/drop-live-docs-catalog-count-4c26

Conversation

@huang47

@huang47 huang47 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stop unit tests from live-fetching the docs catalog count, and drop that hard-coded number from the router labels because the site has no in-repo source for it.

Verification

  • pnpm --filter @comfyorg/website test:unit — passed on Node 26 (package engines): 562 files, 10541 passed, 1 skipped
  • pnpm typecheck:website — passed, 0 errors
  • pnpm knip — passed, no unused exports
  • pnpm exec eslint apps/website — passed
Open in Web Open in Cursor 

The catalog size was a hard-coded number checked against docs.comfy.org.
The site has no in-repo source for that count, so the labels no longer show one.

Co-authored-by: ShihChi Huang <huge.huang@gmail.com>
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 6:28am UTC
billing-web-test Ignored Ignored Sep 30, 2026 6:28am UTC

Request Review

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 07779a14ff2bcc195b0f32a2c5974cf09ce28a2f

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19581.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-2a4mb7rls-comfyui.vercel.app

Last updated: 2026-09-30T06:32:24Z for b0e4a61

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b2d7f75c-c299-4513-9008-18cb0ad42e83

📥 Commits

Reviewing files that changed from the base of the PR and between 07779a1 and b0e4a61.

📒 Files selected for processing (7)
  • apps/website/e2e/router.spec.ts
  • apps/website/src/config/router-providers.test.ts
  • apps/website/src/config/router-providers.ts
  • apps/website/src/templates/platform/RouterProviderCoverageSection.test.ts
  • apps/website/src/templates/platform/RouterProviderCoverageSection.vue
  • apps/website/src/templates/platform/routerCopy.test.ts
  • apps/website/src/templates/platform/routerCopy.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The router coverage section now uses fixed “More models” and “Browse all models” labels in English and Chinese. The catalog model count constant and count-based label interpolation were removed. Related unit and browser tests were updated, and provider tests no longer check documentation coverage or catalog counts.

Changes

Router coverage labels

Layer / File(s) Summary
Remove catalog counts from router coverage labels
apps/website/src/config/router-providers.ts, apps/website/src/templates/platform/routerCopy.ts, apps/website/src/templates/platform/RouterProviderCoverageSection.vue, apps/website/src/templates/platform/routerCopy.test.ts, apps/website/src/templates/platform/RouterProviderCoverageSection.test.ts, apps/website/e2e/router.spec.ts, apps/website/src/config/router-providers.test.ts
The English and Chinese coverage labels no longer interpolate model counts. The catalog count constant was removed. Unit and browser tests now expect fixed labels. Provider tests no longer check documentation coverage or catalog counts.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: maanilverma, shrimbly

Merge Risk: ⚪ Minimal · up to b0e4a

The router now displays fixed English and Chinese labels without catalog counts, while retaining the browse-all destination. No merge-blocking issue is identified; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PASS. The PR uses bug-fix language, but all changed files are under apps/website. The custom check explicitly excludes changes that are exclusively in apps/website, which uses apps/website/e2e/ …
Website End-To-End Regression Coverage ✅ Passed The changed website runtime files only remove model-count interpolation and use fixed router copy. This is a text/copy-only change, which the custom check excludes from failure. The PR also updates an…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only files under apps/website. It does not include src/lib/litegraph/, src/ecs/, or files related to graph entities. This check is not applicable.
Title check ✅ Passed The title clearly identifies the primary change: removing the live documentation catalog count test and related hard-coded count.
Description check ✅ Passed The description explains the purpose of the change and lists verification results. It does not include the template's Changes or Review Focus headings, but the core change and validation details are c…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@huang47
huang47 marked this pull request as ready for review September 30, 2026 06:34
@huang47
huang47 requested a review from a team September 30, 2026 06:34

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: CHANGES REQUESTED at b0e4a61e10 (d66a0af12f + the bot's formatting commit)

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 0

SHOULD FIX 1: it removes far more coverage than the failing assertion. Only "counts the models the docs catalog lists" is broken (212 → 213). This PR also deletes the table-header check, "lists every model the docs show with an alternate provider" (provider list, every row served by Comfy, rows equal to ROUTER_PROVIDER_COVERAGE) and "previews catalog models that only Comfy serves". Those are the only guards that keep the Router page's provider-coverage table in sync with the published docs, and none of them is failing. Please keep them.

SHOULD FIX 2: it changes user-facing copy to fix a test. "+{count} more models" / "Browse all {count} models" become generic labels (en + zh-CN). Dropping the catalog size from the Router page is a product and copy decision for its owners, not a CI fix.

Recommended path:

  • Today: #19574's one-line bump (212 → 213, VERIFIED_AT 2026-09-30) makes the check pass with no loss of coverage or copy.
  • Long term: the problem is that a live external check gates unrelated PRs. Keep the static data and all the drift checks, but run router-providers.test.ts's live checks on a schedule (e.g. a nightly workflow that fails or opens an issue on drift) instead of in PR website-unit. The count then gets bumped deliberately when the docs change.

Context: website-unit isn't a required check on main (test, lint-and-format, e2e-status, website-e2e are), so neither docs PR unblocks #19473 or #19579. Their required website-e2e fails on models-render-guard.spec.ts:169: the /hub/models/ loader is visible for 1005–1359 ms against a 1000 ms budget, on every retry, on both PRs. That's on main since #19494 moved the page to /hub/models/ (a build of main passes it locally, so it's CI-speed sensitive).

@cursor
cursor Bot enabled auto-merge September 30, 2026 06:34
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@DrJKL
DrJKL self-requested a review September 30, 2026 06:35
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19581      +/-   ##
==========================================
- Coverage   85.18%   84.23%   -0.96%     
==========================================
  Files        2414     3253     +839     
  Lines      136302   157847   +21545     
  Branches    36903    42832    +5929     
==========================================
+ Hits       116114   132964   +16850     
- Misses      19716    23092    +3376     
- Partials      472     1791    +1319     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/router-providers.ts 100.00% <ø> (ø)
...mplates/platform/RouterProviderCoverageSection.vue 100.00% <100.00%> (ø)
apps/website/src/templates/platform/routerCopy.ts 92.30% <ø> (ø)

... and 980 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley closed this Sep 30, 2026
auto-merge was automatically disabled September 30, 2026 06:45

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants