Skip to content

[backport cloud/1.55] feat: use generated ToolCallSummary type for persisted tool-call schema - #19607

Merged
christian-byrne merged 4 commits into
cloud/1.55from
backport-19585-to-cloud-1.55
Sep 30, 2026
Merged

christian-byrne merged 4 commits into
cloud/1.55from
backport-19585-to-cloud-1.55

Conversation

@comfy-pr-bot

@comfy-pr-bot comfy-pr-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Backport of #19585 to cloud/1.55

Automatically created by backport workflow.

Justification: Agent release-backport authority covers cloud/1.55. Exact head 30c177d is tree-equivalent to the reviewed carrier except prohibited co-author trailers, has 112 terminal success/neutral/skipped checks, no unresolved reviewer objection, and passed the target-aware gate against cloud/1.55@7e2d6c9a81dc295270e2a67bcbc2bb6d081f7044.

…ma (#19585)

## Summary

Replaces the interim hand-written `zPersistedToolCallSummary` zod schema
in `agentApiSchema.ts` with the generated `zToolCallSummary` from
`@comfyorg/ingest-types/zod`, now that
[Comfy-Org/cloud#10360](Comfy-Org/cloud#10360)
added the `ToolCallSummary` OpenAPI schema for persisted tool-call
history.

## Base branch note

`main` does not yet have `ToolCallSummary` in `packages/ingest-types` —
the automated type-update PR that adds it, #19526, is still open
(unmerged) at the time of this PR. Its single commit (`c819ad46`) is a
pure, isolated `packages/ingest-types` regen with no conflicts against
`main`'s tip, so I cherry-picked just that commit onto a fresh branch
off `main` rather than basing on #19526's own branch, to keep this PR's
history clean and independent of that bot-managed branch's future churn.
If #19526 merges first, this PR's first commit becomes a no-op on
rebase; if this merges first, #19526 will need a trivial rebase.

## Changes

- **What**:
- `zPersistedToolCallSummary` now aliases the generated
`zToolCallSummary` directly instead of a hand-rolled permissive schema.
- Fixed a codegen gap this surfaced: `AgentMessage.content`'s generated
**TS type** keeps a `[key: string]: unknown` index signature, but its
generated **zod schema** dropped `z.record(z.unknown())` for a bare `{
tool_calls }` object with no `.passthrough()` — which would otherwise
reject every other `content` field (`text`, `attachments`,
`workflow_references`, ...) this file relies on. Added a local
`zAgentMessageContent` (tool_calls typed via `zToolCallSummary`,
`.passthrough()` for the rest) to bridge it.
- Updated `agentTranscript.ts`'s
`parseToolCallEntry`/`toolCallPartState`/`toolCallOk` now that
`tool_call_id` is guaranteed present and `status` is closed to
`'success' | 'error'` (previously `z.string().optional()` with an
`id`-fallback for pre-`tool_call_id` rows).
- Updated test fixtures in `agentTranscript.test.ts`,
`agentEventTransport.test.ts`, and `agentConversationStore.test.ts` to
match the tightened contract (valid fixtures now include `tool_call_id`
+ `'success'/'error'` status; fixtures deliberately testing
malformed/legacy shapes now assert the entry is **dropped** rather than
rendered with a broadened status vocabulary, matching the generated
schema's own docstring: "a row a dead turn left in pending/running ...
is dropped rather than shown as a perpetual-progress chip").
- **Breaking**: None externally — this is FE-internal parsing of
already-persisted rows. Behavior only changes for the
never-before-possible edge cases the interim schema was defensively
permissive about (a persisted row missing `tool_call_id`, or carrying a
non-terminal/unrecognized `status`): those are now dropped instead of
rendered, matching what the finalized backend contract guarantees can no
longer occur.
- **Dependencies**: None new — `@comfyorg/ingest-types` is an existing
workspace dependency; only its generated content changed (via
cherry-picked commit).

## Before / After

**Before** (`agentApiSchema.ts`):
```ts
export const zPersistedToolCallSummary = z
  .object({
    id: z.string(),
    tool_call_id: z.string().optional(),
    tool_name: z.string(),
    status: z.string().optional(),
    duration_ms: z.unknown().optional()
  })
  .passthrough()
```

**After**:
```ts
import { zToolCallSummary } from '@comfyorg/ingest-types/zod'
// ...
export const zPersistedToolCallSummary = zToolCallSummary
```

## Review Focus

- The codegen-gap fix (`zAgentMessageContent`) is the part most worth a
second look — it's necessary for anything to compile/parse once
`content`'s zod schema tightened, but it's patching a mismatch between
the OpenAPI-generated TS type and its zod counterpart rather than
something this PR set out to change. Cloud/codegen maintainers may want
to fix this upstream (route `additionalProperties`/index-signature cases
through `.passthrough()` in the zod plugin) so future consumers don't
need this kind of local patch.
- `tool_call_id` is now required and `status` is a closed `'success' |
'error'` enum — I removed the old `id`-fallback and
broadened-status-vocabulary handling in `agentTranscript.ts`
accordingly, trusting the backend's own docstring that only terminal,
`tool_call_id`-bearing rows are ever persisted. Worth a sanity check
against how `services/agent/internal/persist.ToolCallSummary` actually
writes these rows.
- Verification: `pnpm typecheck` (repo-wide, clean) and `pnpm test:unit`
for every changed/affected file — `agentApiSchema.test.ts`,
`agentTranscript.test.ts` (34 tests), `agentEventTransport.test.ts`,
`agentConversationStore.test.ts` — all green. Did not run the full unit
suite; a large, pre-existing and unrelated set of `.vue`-component test
files fail in this environment with `Cannot find package
'@vue/compiler-sfc'` even on unmodified `main` (verified via `git
stash`), so that failure is not from this change.

---

_Requested by **Christian Byrne** · #comfy-agent-user-feedback_

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb

---
_Generated by [Claude
Code](https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb)_

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 30, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 30, 2026 08:53
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 12:34:43 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2123 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2102 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 7e2d6c9a81dc295270e2a67bcbc2bb6d081f7044

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 570ms TBT · 100.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 235ms TBT · 87.4 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 979ms TBT · 83.2 MB heap
extension-rgthree-prototype-draw: · 50.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1100ms TBT · 67.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 3ms TBT · 85.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 83.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 1ms TBT · 179.1 MB heap
vue-node-resize-workload: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 390ms TBT · 171.5 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 444ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.7 MB
canvas-idle: DOM nodes -263
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 47
canvas-mouse-sweep: task duration 745ms
canvas-mouse-sweep: script duration 163ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.7 MB
canvas-mouse-sweep: DOM nodes -260
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 330ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.8 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 10ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 441ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.4 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 813ms
dom-widget-order-dense-n200-w200-i120: script duration 75ms
dom-widget-order-dense-n200-w200-i120: TBT 570ms
dom-widget-order-dense-n200-w200-i120: heap used 100.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 471ms
dom-widget-order-sparse-n1000-w20-i120: script duration 165ms
dom-widget-order-sparse-n1000-w20-i120: TBT 235ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9147ms
extension-clean-combined-draw: script duration 7570ms
extension-clean-combined-draw: TBT 979ms
extension-clean-combined-draw: heap used 83.2 MB
extension-clean-combined-draw: DOM nodes -14
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 20ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9109ms
extension-rgthree-prototype-draw: script duration 7671ms
extension-rgthree-prototype-draw: TBT 1100ms
extension-rgthree-prototype-draw: heap used 67.8 MB
extension-rgthree-prototype-draw: DOM nodes -16
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 570ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.4 MB
large-graph-idle: DOM nodes -240
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1550ms
large-graph-pan: script duration 855ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.8 MB
large-graph-pan: DOM nodes -232
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1605ms
large-graph-zoom: script duration 780ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.8 MB
large-graph-zoom: DOM nodes -253
large-graph-zoom: event listeners -87
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1904ms
legacy-node-drag: script duration 985ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 85.4 MB
legacy-node-drag: DOM nodes -122
legacy-node-drag: event listeners 93
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 517ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.6 MB
minimap-idle: DOM nodes -249
minimap-idle: event listeners -152
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 401ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.8 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 394ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.6 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 724ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.4 MB
subgraph-mouse-sweep: DOM nodes -275
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 859ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 83.4 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5944ms
viewport-pan-sweep: script duration 2836ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.0 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16075ms
vue-large-graph-idle: script duration 264ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.8 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 123
vue-large-graph-pan: task duration 17435ms
vue-large-graph-pan: script duration 838ms
vue-large-graph-pan: TBT 1ms
vue-large-graph-pan: heap used 179.1 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5939ms
vue-node-resize-workload: script duration 107ms
vue-node-resize-workload: TBT 390ms
vue-node-resize-workload: heap used 171.5 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5994ms
vue-zoom-out-idle: script duration 111ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 4
workflow-execution: style recalc count 8
workflow-execution: task duration 80ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.3 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-30T12:46:12.374Z",
  "gitSha": "541ddbc92203d6681d7b2628737ffbd138aa31df",
  "branch": "backport-19585-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2016.5399999999636,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.2730000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.506,
      "heapDeltaBytes": 4110508,
      "heapUsedBytes": 71864252,
      "domNodes": -263,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.4289999999999985,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.2190000000537,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.463999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.3430000000001,
      "heapDeltaBytes": -7148484,
      "heapUsedBytes": 55329924,
      "domNodes": -263,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.467000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1752.9930000000604,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 14.886999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 800.426,
      "heapDeltaBytes": -440400,
      "heapUsedBytes": 67254540,
      "domNodes": -261,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 163.31699999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1703.2349999999497,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.149000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 689.394,
      "heapDeltaBytes": -5922116,
      "heapUsedBytes": 62185800,
      "domNodes": -258,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 162.632,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1702.9890000000023,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.075,
      "layouts": 6,
      "layoutDurationMs": 1.1550000000000002,
      "taskDurationMs": 320.681,
      "heapDeltaBytes": 2143652,
      "heapUsedBytes": 63253556,
      "domNodes": 78,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.240999999999996,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.9520000000612,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.354,
      "layouts": 6,
      "layoutDurationMs": 1.135,
      "taskDurationMs": 339.21999999999997,
      "heapDeltaBytes": 3172548,
      "heapUsedBytes": 70547508,
      "domNodes": 79,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.481999999999996,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 614.039000000048,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.145999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.275,
      "heapDeltaBytes": 18880336,
      "heapUsedBytes": 86642400,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 171.404,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.6920000000109,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.896,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.20400000000006,
      "heapDeltaBytes": 18913420,
      "heapUsedBytes": 86060496,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 167.84500000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1168.435000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 778.893,
      "heapDeltaBytes": 38394608,
      "heapUsedBytes": 104830820,
      "domNodes": 0,
      "jsHeapTotalBytes": 19820544,
      "scriptDurationMs": 66.36699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 558,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1193.4179999999515,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 847.0289999999999,
      "heapDeltaBytes": 38809612,
      "heapUsedBytes": 106161148,
      "domNodes": 0,
      "jsHeapTotalBytes": 18247680,
      "scriptDurationMs": 83.832,
      "eventListeners": 0,
      "totalBlockingTimeMs": 581,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 859.1270000000577,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.9489999999996,
      "heapDeltaBytes": 14650956,
      "heapUsedBytes": 91779804,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 167.64700000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 239,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 843.2430000000295,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.1999999999997,
      "heapDeltaBytes": 14631096,
      "heapUsedBytes": 91583100,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 162.058,
      "eventListeners": 0,
      "totalBlockingTimeMs": 230,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10236.991999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9325.755000000001,
      "heapDeltaBytes": 11125308,
      "heapUsedBytes": 93472612,
      "domNodes": -16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7696.28,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1079,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9835.274000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8967.921,
      "heapDeltaBytes": -867192,
      "heapUsedBytes": 80912096,
      "domNodes": -12,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 7444.442999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 879,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9994.136000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9081.673,
      "heapDeltaBytes": -10187016,
      "heapUsedBytes": 72656716,
      "domNodes": -18,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 7796.2429999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1317,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9932.698999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9136.79,
      "heapDeltaBytes": -12605596,
      "heapUsedBytes": 69631116,
      "domNodes": -14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 7544.778,
      "eventListeners": 0,
      "totalBlockingTimeMs": 882,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.1660000000757,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.342000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585,
      "heapDeltaBytes": -4048172,
      "heapUsedBytes": 83270984,
      "domNodes": -239,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 32.87899999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.4239999999772,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.509000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.5649999999999,
      "heapDeltaBytes": -4096196,
      "heapUsedBytes": 83253984,
      "domNodes": -240,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 31.97799999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2241.6070000000445,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.032999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1458.233,
      "heapDeltaBytes": -11752700,
      "heapUsedBytes": 76010904,
      "domNodes": -246,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 847.1370000000001,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2248.3170000000428,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.012000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1641.2510000000002,
      "heapDeltaBytes": -11066264,
      "heapUsedBytes": 76694508,
      "domNodes": -218,
      "jsHeapTotalBytes": 2351104,
      "scriptDurationMs": 863.803,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3516.736000000037,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.502000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.753,
      "taskDurationMs": 1680.049,
      "heapDeltaBytes": -15228488,
      "heapUsedBytes": 74169604,
      "domNodes": -254,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 781.999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3485.5780000000323,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.591999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.047999999999998,
      "taskDurationMs": 1530.155,
      "heapDeltaBytes": 9829804,
      "heapUsedBytes": 74231696,
      "domNodes": -252,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 778.498,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3203.710000000001,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.584999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1962.3110000000001,
      "heapDeltaBytes": 991996,
      "heapUsedBytes": 91930848,
      "domNodes": -252,
      "jsHeapTotalBytes": 1232896,
      "scriptDurationMs": 1009.854,
      "eventListeners": 6,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2976.8530000000055,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.256000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1845.4160000000002,
      "heapDeltaBytes": 21046028,
      "heapUsedBytes": 87225540,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 959.4010000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1994.6510000000899,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.4649999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.433,
      "heapDeltaBytes": 20187296,
      "heapUsedBytes": 84401116,
      "domNodes": -250,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.415999999999997,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.8319999998002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.457,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.099,
      "heapDeltaBytes": -4058800,
      "heapUsedBytes": 84654068,
      "domNodes": -247,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 33.428,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 558.5859999999911,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 11.895999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.2650000000001,
      "heapDeltaBytes": 13778064,
      "heapUsedBytes": 83751044,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.22099999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 587.3080000000073,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.308000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.066,
      "heapDeltaBytes": 13737924,
      "heapUsedBytes": 83685136,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 147.22000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.0410000000193,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.422000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.19599999999997,
      "heapDeltaBytes": -5322748,
      "heapUsedBytes": 64657764,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.843999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.2150000000347,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.628,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.55699999999996,
      "heapDeltaBytes": 9103488,
      "heapUsedBytes": 79126940,
      "domNodes": -274,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.057999999999998,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.6500000000015,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 15.038999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 716.252,
      "heapDeltaBytes": 4255108,
      "heapUsedBytes": 73867604,
      "domNodes": -273,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 102.988,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.8219999999274,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.309999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 731.1019999999999,
      "heapDeltaBytes": 6227688,
      "heapUsedBytes": 75931420,
      "domNodes": -276,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 106.131,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.1380000000072,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 28.809,
      "layouts": 5,
      "layoutDurationMs": 13.010000000000002,
      "taskDurationMs": 859.2979999999999,
      "heapDeltaBytes": -6327824,
      "heapUsedBytes": 87416440,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 28.229999999999997,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8492.196000000036,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 37.437,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5840.704,
      "heapDeltaBytes": -19941984,
      "heapUsedBytes": 66615604,
      "domNodes": -213,
      "jsHeapTotalBytes": 3174400,
      "scriptDurationMs": 2817.04,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8558.831000000055,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.96900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6046.367,
      "heapDeltaBytes": -2646252,
      "heapUsedBytes": 84309108,
      "domNodes": -243,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 2854.81,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16731.967000000055,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16161.168,
      "heapDeltaBytes": -56412660,
      "heapUsedBytes": 163301444,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17543168,
      "scriptDurationMs": 265.189,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16615.628000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15988.174,
      "heapDeltaBytes": -35269164,
      "heapUsedBytes": 190633108,
      "domNodes": -8061,
      "jsHeapTotalBytes": -15998976,
      "scriptDurationMs": 262.813,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20166.26199999996,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 16.03500000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19762.214,
      "heapDeltaBytes": -28053288,
      "heapUsedBytes": 191947736,
      "domNodes": -8061,
      "jsHeapTotalBytes": -18100224,
      "scriptDurationMs": 864.358,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15607.213000000002,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 11.748999999999981,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15107.125,
      "heapDeltaBytes": -43477404,
      "heapUsedBytes": 183753296,
      "domNodes": -8061,
      "jsHeapTotalBytes": -13959168,
      "scriptDurationMs": 811.4060000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 17.22666666666664,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6021.862999999939,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.07600000000001,
      "layouts": 20,
      "layoutDurationMs": 21.486000000000004,
      "taskDurationMs": 5914.753999999999,
      "heapDeltaBytes": -44182832,
      "heapUsedBytes": 176661072,
      "domNodes": -8061,
      "jsHeapTotalBytes": 3731456,
      "scriptDurationMs": 108.064,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 395,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6084.4600000000355,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.624,
      "layouts": 20,
      "layoutDurationMs": 21.875000000000007,
      "taskDurationMs": 5962.371000000001,
      "heapDeltaBytes": -42803348,
      "heapUsedBytes": 182903656,
      "domNodes": -8061,
      "jsHeapTotalBytes": 14147584,
      "scriptDurationMs": 105.984,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6354.862999999909,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5948.607999999998,
      "heapDeltaBytes": -12421084,
      "heapUsedBytes": 174641820,
      "domNodes": 0,
      "jsHeapTotalBytes": -30146560,
      "scriptDurationMs": 99.87000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6359.624999999824,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6039.155999999998,
      "heapDeltaBytes": 84368,
      "heapUsedBytes": 179114580,
      "domNodes": 0,
      "jsHeapTotalBytes": -33030144,
      "scriptDurationMs": 122.61800000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.66200000000481,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.109,
      "layouts": 3,
      "layoutDurationMs": 1.6660000000000001,
      "taskDurationMs": 81.91400000000002,
      "heapDeltaBytes": 3090600,
      "heapUsedBytes": 67925840,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.877000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.61399999991772,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 14.439000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.71,
      "taskDurationMs": 77.272,
      "heapDeltaBytes": 3051336,
      "heapUsedBytes": 69071156,
      "domNodes": 128,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.675999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52458 79387 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/scripts/pnginfo.ts 20.7% 222

@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 08:54
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #19607   +/-   ##
=============================================
  Coverage              ?   83.77%           
=============================================
  Files                 ?     3072           
  Lines                 ?   150570           
  Branches              ?    40847           
=============================================
  Hits                  ?   126137           
  Misses                ?    23026           
  Partials              ?     1407           
Flag Coverage Δ
billing-web-unit 91.45% <100.00%> (?)
e2e 66.08% <100.00%> (?)
unit 80.55% <100.00%> (?)
website-unit 76.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/checkout/payVerdict.ts 97.72% <100.00%> (ø)
apps/website/src/config/router-providers.ts 100.00% <100.00%> (ø)
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
...extensions/agent/services/agent/agentTranscript.ts 97.72% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts

@ryan-di

ryan-di commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

CI triage for 30ae9d9 — the website and billing failures have existing fixes on main that are missing from cloud/1.55:

I compared the PR head with its base: apps/website, apps/billing-web, packages/account-core, and the two CI workflows are identical. These two failures are inherited from the release branch, unrelated to the ToolCallSummary backport. The corresponding gate failures just reflect those jobs.

Suggested unblock: backport #19499 and #19574 to cloud/1.55, then update this branch and rerun CI. The AI co-author trailer check is a separate commit-metadata issue that also needs resolving.

@ryan-di ryan-di assigned christian-byrne and unassigned ryan-di Sep 30, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 30, 2026
@DrJKL
DrJKL self-requested a review September 30, 2026 11:07
claude Bot and others added 2 commits September 30, 2026 11:10
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
…19499)

## Summary

Fixes the `full-page-promo.spec.ts` "a code that lapses before Pay"
failure that has been red on main since #19126. The full-page checkout
now re-quotes when a subscribe comes back as `QUOTE_STALE`.

## Changes

- **What**: #19253 made `payVerdictOf` re-quote only when a raw
`SUBSCRIPTION_QUOTE_STALE` `serverCode` came back. #19126 then changed
account-core to turn a 4xx with that code into `{ code: 'QUOTE_STALE' }`
with no `serverCode`. The two PRs were written in parallel and merged
about 40 minutes apart. Since then, `payVerdictOf` falls through to
`failure`. The page shows "Your quote changed…" instead of re-pricing
and showing the expired-promo card. `payVerdictOf` now maps
`QUOTE_STALE` to `requote`.
- The `payVerdict` and `FullPageCheckoutView` unit tests built the
pre-#19126 result shape by hand, so they missed this. They now use the
shape account-core actually returns.

## Review Focus

`SUBSCRIPTION_QUOTE_STALE` is gone from `STALE_QUOTE_SERVER_CODES`. Only
`subscribe` emits it, and account-core now maps it for 4xx responses. A
5xx that echoes the code arrives as `REQUEST_FAILED`, which account-core
treats as an upstream failure, not a stale quote. With this change, that
5xx no longer triggers a re-quote.

Red/green: both updated unit tests fail without the `payVerdict.ts`
change and pass with it. `pnpm test:e2e:local
e2e/full-page-promo.spec.ts` passes 6/6.
@claude
claude Bot requested review from a team and dante01yoon as code owners September 30, 2026 11:15

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 6 finding(s).

Severity Count
🔴 Critical 1
🟠 High 1
🟡 Medium 1
🟢 Low 3

Panel: 8/8 reviewers contributed findings.

tool_name: z.string(),
status: z.string().optional(),
duration_ms: z.unknown().optional()
tool_calls: z.array(zToolCallSummary).optional()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — Validating tool_calls as a strict z.array(zToolCallSummary) at the message level makes history loading all-or-nothing: getMessages runs this through schema.parse, so one entry with a legacy status, a missing tool_call_id, or a fractional duration_ms rejects the entire GET /threads/{id}/messages response and blanks the thread (surfacing the raw Zod issue list through pushError) instead of dropping a single chip. It also makes parseToolCallEntry's per-entry safeParse unreachable for wire data, so the tolerance that function implements can never fire. Use z.array(z.unknown()) here (or a per-element .catch()) and leave the filtering to parseToolCallEntry. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).

* and is dropped server-side rather than reaching this parser.
*/
export const zPersistedToolCallSummary = z
export const zPersistedToolCallSummary = zToolCallSummary

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Aliasing zPersistedToolCallSummary to the generated zToolCallSummary makes status a closed success|error enum and tool_call_id required, with no tolerance for rows already persisted: the deleted comments recorded that the terminal vocabulary was "not yet settled" and that "rows recorded before tool_call_id existed have none", and this PR's own e2e mock had to be rewritten from status: 'ok' to 'success' with a tool_call_id added. Combined with the strict message-level array above, a frontend deploy ahead of Comfy-Org/cloud#10360 (or a backend rollback) makes old threads unloadable rather than degraded. Accept legacy terminal values as failure-mapped statuses and keep a fallback for a missing tool_call_id. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).

* (`success`/`error`) row — the backend drops a row a dead turn left in
* `pending`/`running` before persisting it. `isLive` (the row is the one
* actively backed by a live transport — the run_approval mid-ask case) is
* kept only for a call that arrives through the live WebSocket path with a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Dropping pending/running rows means a reload during a live run_approval ask no longer restores the in-flight tool chip — the rewritten test asserts exactly that, with parts reduced to [{ type: 'runApproval' }] — and because the tool is blocked on the user's answer, no further agent_tool_call frame arrives to recreate it. As a consequence toolCallPartState's isLive/'streaming' branch and toolCallOk's state === 'streaming' guard are now dead code: live frames are built by handleToolCallEvent in agentEventTransport.ts and never reach this parser, so this comment's rationale describes an input that cannot occur. Either keep non-terminal statuses for the live row or delete the unreachable branches along with the comment. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).

* already treat `undefined` as terminal-and-failed, matching the old
* parser's behavior for a status-less call).
* to the live WebSocket's `zAgentToolCallData` above. Sourced directly from
* the generated `ToolCallSummary` schema (Comfy-Org/cloud#10360) — the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Adopting the whole generated ToolCallSummary also pulls in validation of started_at/finished_at, which this parser never reads; as z.string().datetime() on zod 3 they reject any timezone offset (only a trailing Z passes), while Go's RFC3339 marshaling emits +00:00-style offsets for non-UTC locations. Consider .pick()ing only the fields the transcript actually consumes so an unused timestamp cannot fail the entry. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

})
})

it.for([NaN, Infinity, -Infinity])(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — These rewritten cases assert graceful per-entry dropping by calling normalizeAgentTranscript with hand-built objects that need as unknown as AgentMessages[number]['content'] to compile — the casts are the tell that the wire schema now rejects the whole payload. In the real reload path the same input fails zAgentMessages.parse and loses the entire thread, so add a case that feeds a deviating tool call through the schema to document the actual blast radius. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

…ry load

`agentRestClient.ts`'s `getMessages()` calls `zAgentMessages.parse()`
(throws, not safeParse). Since `zAgentMessage.content.tool_calls` was typed
as `z.array(zToolCallSummary)` -- the generated schema, which requires
`tool_call_id`, closes `status` to `'success' | 'error'`, and requires an
integer `duration_ms` -- a single non-conforming historical tool-call row
threw during `.parse()` and failed the entire array/message/response parse,
surfacing as `agent_history_load_failed` instead of gracefully degrading
just that one entry.

- agentApiSchema.ts: the message-parse boundary's `content.tool_calls` is
  now `z.array(z.unknown())`, so a malformed entry can never throw at
  `zAgentMessages.parse()`. `zPersistedToolCallSummary` (used only by
  `parseToolCallEntry`'s own `safeParse`) relaxes the generated schema:
  `tool_call_id` optional, `status` a bare string, `duration_ms` not
  required to be an integer.
- agentTranscript.ts: `parseToolCallEntry` validates only the fields it
  reads (`.pick()`), restores the `tool_call_id ?? id` fallback for rows
  predating `tool_call_id`, and `toolCallOk` treats the older `'ok'` status
  alias the same as `'success'`.
- agentTranscript.test.ts: restores the pre-tightening fixtures/tests this
  broke, and adds a regression test that exercises the actual
  `zAgentMessages.parse()` boundary with a malformed row, confirming the
  whole history still loads and only that one tool-call entry degrades.

Claude-Session: https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb
@christian-byrne
christian-byrne force-pushed the backport-19585-to-cloud-1.55 branch from e39d6f6 to 30c177d Compare September 30, 2026 12:32

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fresh exact-head review at 30c177d after the authorized message-only repair: compared all four rewritten commit objects to their predecessors, allowing only parent-hash propagation and deletion of prohibited Claude Co-authored-by trailer lines. Every corresponding commit tree is identical and the final tree remains 88f18f2af38563845a29af7b976e4f7083be6b56. The human Christian Byrne and github-actions[bot] trailers are preserved. Repository check-ai-co-authors passes locally and the fresh hosted Check for AI agent co-author trailers is green. No product content was changed; awaiting the remainder of fresh hosted checks before any landing decision.

@christian-byrne
christian-byrne merged commit 44cbbe3 into cloud/1.55 Sep 30, 2026
113 checks passed
@christian-byrne
christian-byrne deleted the backport-19585-to-cloud-1.55 branch September 30, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants