Repository navigation
fix(website): make every published Cloud workflow run - #19291
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19291.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-23gty4bej-comfyui.vercel.app Last updated: 2026-09-28T21:21:03Z for 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7f38fbf7ed87f918fe05ee016e2e0a43c4185f5f
Full docs: ADR-DEVEX-LINT-0015 |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — review of #19291 at 7db03a963a.
Verdict: accepted. It's the exact union of what I already accepted, with no findings.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
Verified as the union, patch by patch. For each of the 7 files, the added and removed lines against main (21e7421e0b) are identical to the accepted patch from its own base (578a331ad6):
- From #19284 at
7c3f7304e4(ConcatenateVideo):product-photo-to-video.json,product-photo-to-video.svgandworkshop-workflows.jsonl. - From #19272 at
74dd5ee84d:workshop-display.json,workshop-workflow-content.test.tsande2e/workshop-workflows.spec.ts. The mask PNG's blob is identical. - Nothing else: no other files and no edits. The availability manifest is untouched, so all 30 workflows publish (6 per category), and the unit-test counts from #19272's pre-stack commits match that.
Merge context: #19288, #19272 and #19284 are closed in favour of this. It merges cleanly with #19256 (which lands first and fixes the shard-3 JS-budget failure), including in the shared e2e spec. After deploy, one live remove-object Run through the site will confirm the new mask end to end.
Verification: 296 tests pass locally on this head (workflow content, workflow catalog, src/content, prepare-workflow-previews). CI was 29 passed, 14 pending, none failed, when I posted.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe remove-object and virtual-try-on examples now include prefilled image inputs. Tests check workflow validation, the Bria mask asset, and input controls. The product photo-to-video workflow now concatenates its three generated clips directly. ChangesPrefilled workshop inputs
Product photo-to-video workflow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is identified for the workflow updates; normal checks remain appropriate. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: Website End-To-End Regression CoverageExplanation The PR changes observable website workflow behavior in Resolution Add or update a Playwright assertion under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19291 +/- ##
==========================================
- Coverage 84.22% 84.19% -0.04%
==========================================
Files 3210 3173 -37
Lines 156605 155814 -791
Branches 40671 40475 -196
==========================================
- Hits 131899 131185 -714
+ Misses 23014 22983 -31
+ Partials 1692 1646 -46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Building the combined video decodes MiniMax's clips into frames, and
that step takes the Cloud worker down ("RIP to the server") on every
run, even at 768p with a quarter-size stitch. The three clips alone
complete (167s, all three delivered), so the workflow now outputs just
those. The downloadable graph and preview drop the same Combine Video
subgraph and save node so they stay consistent with the Cloud request.
Cloud's core ConcatenateVideo node joins VIDEO objects without decoding them into frames (the BE-6855 fix), so the combined video no longer needs the decode-and-batch stitch that exceeded the 10 GiB CPU-job limit. The three MiniMax clips feed ConcatenateVideo, and its output is saved as before. The downloadable graph swaps the Combine Video subgraph for the same node and keeps its links. Verified on prod: 157s, all four outputs.
…examples Both workflow pages shipped examples missing a required input (the Bria mask, the try-on subject), so the default Run could not submit. Add a website-owned apple mask matching the example image, and the template's own try-on subject from the pinned workflow_templates revision.
7db03a9 to
04345d3
Compare
|
@coderabbitai The E2E regression-coverage check: the reason a browser test is not practical for the product-photo-to-video graph change is now recorded in the PR description (the change only takes effect inside Cloud execution, which the website's Playwright suites stub; it is verified by three live production runs). Please re-evaluate the pre-merge checks. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -uo pipefail
repo=Comfy-Org/ComfyUI_frontend
gh pr view 19291 --repo "$repo" --json title,body,headRefOid,statusCheckRollup,files --jq '{title,body,headRefOid,checks:[.statusCheckRollup[]?|{name:(.name // .context),conclusion:(.conclusion // .state),url:(.detailsUrl // .targetUrl)}],files:[.files[]|.path]}'
echo '--- PR comments ---'
gh api "repos/$repo/issues/19291/comments" --paginate --jq '.[]|{user:.user.login,body,created_at,html_url}' | tail -120
echo '--- review comments ---'
gh api "repos/$repo/pulls/19291/comments" --paginate --jq '.[]|{user:.user.login,body,path,line,html_url}' | tail -180Length of output: 42377 🏁 Script executed: #!/bin/bash
set -uo pipefail
echo '--- cited test file location ---'
fd 'workshop-workflow-runs\.spec\.ts$'
echo '--- cited test file outline ---'
ast-grep outline apps/website/e2e/workshop-workflow-runs.spec.ts --items all | head -100
echo '--- relevant request stubs ---'
rg -n -C 5 '/api/(prompt|jobs)|page\.route|route\(' apps/website/e2e/workshop-workflow-runs.spec.ts | head -170
echo '--- refreshed relevant checks ---'
gh pr view 19291 --repo Comfy-Org/ComfyUI_frontend --json headRefOid,statusCheckRollup --jq '{headRefOid,checks:[.statusCheckRollup[]?|select((.name // .context) | test("website-e2e|website-unit|CodeRabbit"))|{name:(.name // .context),status,conclusion:(.conclusion // .state)}]}'Length of output: 8039
The four website E2E shards passed in the latest check snapshot. The aggregate Thanks for the clarification. ✏️ Learnings added
|
|
Code reviewed by multiple accounts and all issues resolved. All CI passes. Merging. |
Summary
Makes every published Cloud workflow run. Combines the remaining workflow fixes into one PR: #19284 (product-photo-to-video) and #19272 (remove-object, virtual-try-on). #19288's temporary disables are no longer needed because all three are fixed here. Together with #19251 (already merged), all 30 published workflows pass live on production.
Changes
ConcatenateVideo(joins VIDEO objects without decoding); the downloadable graph and SVG match.public/workflow-inputs/remove-object-apple-mask.png).Review Focus
Live evidence on production (
test:workflow-pages --execute):7c3f7304e4: 3/3 passed, all 4 outputs incl. the combined video — runs56635afd…(191 s),daff6b57…(184 s),98babfa5…(213 s).1de167fa-7317-4963-b3aa-24e3535a016b; virtual-try-on with this subject: run33160fe7-ea1e-46a4-b4cf-e8531cc335f9.Post-deploy: the mask is served from comfy.org once this ships; run remove-object once through the site.
Previously accepted by Bill as #19272 and #19284 (same commits). CI's
/models/JavaScript-budget failure is fixed by #19256, which merges first.Validation: 7,377 website unit tests, website typecheck, 15 workflow browser tests on the CI-equivalent build.
Why product-photo-to-video has no new browser test
The change is inside the Cloud graph (
ConcatenateVideoreplacing the decode-and-stitch subgraph) and only has an effect when Cloud executes it. The website's Playwright suites stub Cloud's/api/promptand/api/jobs(e2e/workshop-workflow-runs.spec.ts), so no browser test can observe whether Cloud keeps the worker alive or produces the combined video. The page, its form and its submission path are unchanged and remain covered by the existing workflow browser tests; the graph change is verified where it runs — three live production runs above (all four outputs, combined video included) — and by the scheduled live sweep in #19274.