Skip to content

fix(website): make every published Cloud workflow run - #19291

Merged
benjcooley merged 4 commits into
mainfrom
benjcooley/workflows-all-working
Sep 28, 2026
Merged

benjcooley merged 4 commits into
mainfrom
benjcooley/workflows-all-working

Conversation

@benjcooley

@benjcooley benjcooley commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Makes every published Cloud workflow run. Combines the remaining workflow fixes into one PR: #19284 (product-photo-to-video) and #19272 (remove-object, virtual-try-on). #19288's temporary disables are no longer needed because all three are fixed here. Together with #19251 (already merged), all 30 published workflows pass live on production.

Changes

  • product-photo-to-video (Bob's commits from fix(website): make product-photo-to-video's combined video run on Cloud #19284): Cloud lost the worker at ~700 s decoding the three MiniMax videos to stitch them. The combined video now uses core ConcatenateVideo (joins VIDEO objects without decoding); the downloadable graph and SVG match.
  • remove-object: the example now includes a website-owned 1024×1024 mask over the apple (public/workflow-inputs/remove-object-apple-mask.png).
  • virtual-try-on: the example now includes the template's own subject (pinned workflow_templates revision).
  • Tests: every published workflow's example must validate in the shared form; a browser test opens remove-object and virtual-try-on and asserts their inputs are pre-filled.

Review Focus

Live evidence on production (test:workflow-pages --execute):

  • product-photo-to-video at 7c3f7304e4: 3/3 passed, all 4 outputs incl. the combined video — runs 56635afd… (191 s), daff6b57… (184 s), 98babfa5… (213 s).
  • remove-object with this mask: run 1de167fa-7317-4963-b3aa-24e3535a016b; virtual-try-on with this subject: run 33160fe7-ea1e-46a4-b4cf-e8531cc335f9.
  • Every other published workflow passed in the full sweep after fix(website): make the failing Cloud workflows run #19251.

Post-deploy: the mask is served from comfy.org once this ships; run remove-object once through the site.

Previously accepted by Bill as #19272 and #19284 (same commits). CI's /models/ JavaScript-budget failure is fixed by #19256, which merges first.

Validation: 7,377 website unit tests, website typecheck, 15 workflow browser tests on the CI-equivalent build.

Why product-photo-to-video has no new browser test

The change is inside the Cloud graph (ConcatenateVideo replacing the decode-and-stitch subgraph) and only has an effect when Cloud executes it. The website's Playwright suites stub Cloud's /api/prompt and /api/jobs (e2e/workshop-workflow-runs.spec.ts), so no browser test can observe whether Cloud keeps the worker alive or produces the combined video. The page, its form and its submission path are unchanged and remain covered by the existing workflow browser tests; the graph change is verified where it runs — three live production runs above (all four outputs, combined video included) — and by the scheduled live sweep in #19274.

@benjcooley
benjcooley requested review from a team September 28, 2026 20:55
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 9:16pm UTC
billing-web-test Ignored Ignored Sep 28, 2026 9:16pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19291.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-23gty4bej-comfyui.vercel.app

Last updated: 2026-09-28T21:21:03Z for 04345d3

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 7f38fbf7ed87f918fe05ee016e2e0a43c4185f5f

Full docs: ADR-DEVEX-LINT-0015

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL — review of #19291 at 7db03a963a.

Verdict: accepted. It's the exact union of what I already accepted, with no findings.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

Verified as the union, patch by patch. For each of the 7 files, the added and removed lines against main (21e7421e0b) are identical to the accepted patch from its own base (578a331ad6):

  • From #19284 at 7c3f7304e4 (ConcatenateVideo): product-photo-to-video.json, product-photo-to-video.svg and workshop-workflows.jsonl.
  • From #19272 at 74dd5ee84d: workshop-display.json, workshop-workflow-content.test.ts and e2e/workshop-workflows.spec.ts. The mask PNG's blob is identical.
  • Nothing else: no other files and no edits. The availability manifest is untouched, so all 30 workflows publish (6 per category), and the unit-test counts from #19272's pre-stack commits match that.

Merge context: #19288, #19272 and #19284 are closed in favour of this. It merges cleanly with #19256 (which lands first and fixes the shard-3 JS-budget failure), including in the shared e2e spec. After deploy, one live remove-object Run through the site will confirm the new mask end to end.

Verification: 296 tests pass locally on this head (workflow content, workflow catalog, src/content, prepare-workflow-previews). CI was 29 passed, 14 pending, none failed, when I posted.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6a9295e0-78ec-4ac3-b16d-b1a615e7f770

📥 Commits

Reviewing files that changed from the base of the PR and between 7db03a9 and 04345d3.

⛔ Files ignored due to path filters (2)
  • apps/website/public/workflow-graphs/product-photo-to-video.svg is excluded by !**/*.svg
  • apps/website/public/workflow-inputs/remove-object-apple-mask.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • apps/website/e2e/workshop-workflows.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The remove-object and virtual-try-on examples now include prefilled image inputs. Tests check workflow validation, the Bria mask asset, and input controls. The product photo-to-video workflow now concatenates its three generated clips directly.

Changes

Prefilled workshop inputs

Layer / File(s) Summary
Workflow input defaults
apps/website/src/content/workshop-display.json, apps/website/src/config/workshop-workflow-content.test.ts
The remove-object example adds a mask URL, and virtual-try-on adds a character image URL. Tests check workflow validation and the Bria mask asset.
Input control checks
apps/website/e2e/workshop-workflows.spec.ts
End-to-end tests load local input assets on both workflow pages and check that the expected input group shows Replace and Remove controls.

Product photo-to-video workflow

Layer / File(s) Summary
Direct video concatenation
apps/website/public/workflow-graphs/product-photo-to-video.json, apps/website/src/content/workshop-workflows.jsonl
The workflow connects three generated clips to ConcatenateVideo, then sends the concatenated video to the existing save node. The individual clip outputs remain.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: anupreet-comfy, comfyrob

Merge Risk: ⚪ Minimal · up to 04345

No actionable merge-blocking risk is identified for the workflow updates; normal checks remain appropriate.

Architecture Summary

Architecture risk: 🔵 Low · up to 04345

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 5 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/public/workflow-graphs/product-photo-to-video.json: The former nested-subgraph node is replaced with a ConcatenateVideo node. Its first three video inputs connect to the three generated videos, and it adds an optional, unconnected fourth input.
  • observed — Modified behavior in apps/website/public/workflow-graphs/product-photo-to-video.json: The node’s S&R name and title are set to ConcatenateVideo, and its widget value changes to auto; the prior subgraph metadata and empty widget configuration are removed.
  • observed — Modified behavior in apps/website/src/config/workshop-workflow-content.test.ts: The shared-form test now expects an empty validation result for every curated workflow, replacing per-workflow partial-error expectations. The partialExamples mapping for remove-object and virtual-try-on was removed.
  • observed — Modified behavior in apps/website/src/config/workshop-workflow-content.test.ts: The Bria example test now verifies that the initial mask value is the website-hosted apple-mask URL and that the matching public asset exists, replacing the check that the example description says a mask is not included.

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Website End-To-End Regression Coverage ❌ Error The PR changes observable website workflow behavior in apps/website/public/workflow-graphs/product-photo-to-video.json and apps/website/src/content/workshop-workflows.jsonl by replacing the video-… Add or update a Playwright assertion under apps/website/e2e/ that exercises the product-photo-to-video workflow and verifies the changed combined-video behavior. If such a test is not practical, record the concrete reason in the PR desc…
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR uses bug-fix language, and it changes files under apps/website/src/. However, all listed changes are exclusively under apps/website, which the check explicitly excludes because that package…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes a workflow graph JSON, so the check applies. The available diff summary shows only node and link configuration changes: it replaces a subgraph with a ConcatenateVideo node and updates…
Title check ✅ Passed The title clearly summarizes the primary change: making all published website Cloud workflows runnable.
Description check ✅ Passed The description follows the required structure and provides clear summaries, change details, review focus, validation evidence, and testing context. No critical section is missing.
Full details: Website End-To-End Regression Coverage

Explanation

The PR changes observable website workflow behavior in apps/website/public/workflow-graphs/product-photo-to-video.json and apps/website/src/content/workshop-workflows.jsonl by replacing the video-combination flow with ConcatenateVideo. The added Playwright coverage checks prefilled inputs for remove-object and virtual-try-on, but it does not exercise the changed product-photo-to-video flow. The PR description reports live production runs, but it does not explain why a Playwright regression test for this behavior was not added.

Resolution

Add or update a Playwright assertion under apps/website/e2e/ that exercises the product-photo-to-video workflow and verifies the changed combined-video behavior. If such a test is not practical, record the concrete reason in the PR description.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19291      +/-   ##
==========================================
- Coverage   84.22%   84.19%   -0.04%     
==========================================
  Files        3210     3173      -37     
  Lines      156605   155814     -791     
  Branches    40671    40475     -196     
==========================================
- Hits       131899   131185     -714     
+ Misses      23014    22983      -31     
+ Partials     1692     1646      -46     
Flag Coverage Δ
billing-web-unit ?
website-unit 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
Building the combined video decodes MiniMax's clips into frames, and
that step takes the Cloud worker down ("RIP to the server") on every
run, even at 768p with a quarter-size stitch. The three clips alone
complete (167s, all three delivered), so the workflow now outputs just
those. The downloadable graph and preview drop the same Combine Video
subgraph and save node so they stay consistent with the Cloud request.
Cloud's core ConcatenateVideo node joins VIDEO objects without decoding
them into frames (the BE-6855 fix), so the combined video no longer
needs the decode-and-batch stitch that exceeded the 10 GiB CPU-job
limit. The three MiniMax clips feed ConcatenateVideo, and its output is
saved as before. The downloadable graph swaps the Combine Video subgraph
for the same node and keeps its links. Verified on prod: 157s, all four
outputs.
…examples

Both workflow pages shipped examples missing a required input (the Bria mask, the try-on subject), so the default Run could not submit. Add a website-owned apple mask matching the example image, and the template's own try-on subject from the pinned workflow_templates revision.
@benjcooley
benjcooley force-pushed the benjcooley/workflows-all-working branch from 7db03a9 to 04345d3 Compare September 28, 2026 21:16
coderabbitai[bot]
coderabbitai Bot previously requested changes Sep 28, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

@coderabbitai The E2E regression-coverage check: the reason a browser test is not practical for the product-photo-to-video graph change is now recorded in the PR description (the change only takes effect inside Cloud execution, which the website's Playwright suites stub; it is verified by three live production runs). Please re-evaluate the pre-merge checks.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor
🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -uo pipefail
repo=Comfy-Org/ComfyUI_frontend
gh pr view 19291 --repo "$repo" --json title,body,headRefOid,statusCheckRollup,files --jq '{title,body,headRefOid,checks:[.statusCheckRollup[]?|{name:(.name // .context),conclusion:(.conclusion // .state),url:(.detailsUrl // .targetUrl)}],files:[.files[]|.path]}'
echo '--- PR comments ---'
gh api "repos/$repo/issues/19291/comments" --paginate --jq '.[]|{user:.user.login,body,created_at,html_url}' | tail -120
echo '--- review comments ---'
gh api "repos/$repo/pulls/19291/comments" --paginate --jq '.[]|{user:.user.login,body,path,line,html_url}' | tail -180

Length of output: 42377


🏁 Script executed:

#!/bin/bash
set -uo pipefail
echo '--- cited test file location ---'
fd 'workshop-workflow-runs\.spec\.ts$'
echo '--- cited test file outline ---'
ast-grep outline apps/website/e2e/workshop-workflow-runs.spec.ts --items all | head -100
echo '--- relevant request stubs ---'
rg -n -C 5 '/api/(prompt|jobs)|page\.route|route\(' apps/website/e2e/workshop-workflow-runs.spec.ts | head -170
echo '--- refreshed relevant checks ---'
gh pr view 19291 --repo Comfy-Org/ComfyUI_frontend --json headRefOid,statusCheckRollup --jq '{headRefOid,checks:[.statusCheckRollup[]?|select((.name // .context) | test("website-e2e|website-unit|CodeRabbit"))|{name:(.name // .context),status,conclusion:(.conclusion // .state)}]}'

Length of output: 8039


@benjcooley, the Website End-To-End Regression Coverage check is satisfied. The PR description now gives the concrete reason the check requested: product-photo-to-video changes Cloud execution, while apps/website/e2e/workshop-workflow-runs.spec.ts stubs /api/prompt and /api/jobs. It also reports three production runs that produced the combined video. I have not independently verified those runs.

The four website E2E shards passed in the latest check snapshot. The aggregate website-e2e job was still queued, so I cannot call all CI checks complete. I’ll request a review to refresh the stale pre-merge check result.

Thanks for the clarification.


✏️ Learnings added
Learnt from: benjcooley
URL: https://github.com/Comfy-Org/ComfyUI_frontend/pull/19291

Timestamp: 2026-09-28T21:39:00.859Z
Learning: In Comfy-Org/ComfyUI_frontend, apps/website/e2e/workshop-workflow-runs.spec.ts stubs Cloud /api/prompt and /api/jobs requests. For the product-photo-to-video workflow graph change in PR #19291, a website Playwright test cannot verify Cloud worker survival or production of the combined video. The PR description reports three live production runs for that behavior.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

Code reviewed by multiple accounts and all issues resolved. All CI passes. Merging.

@benjcooley
benjcooley merged commit 4dde68b into main Sep 28, 2026
93 checks passed
@benjcooley
benjcooley deleted the benjcooley/workflows-all-working branch September 28, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant